rubocop 0.70.0 → 1.6.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +64 -40
- data/config/default.yml +1316 -986
- data/config/obsoletion.yml +196 -0
- data/exe/rubocop +1 -1
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +4 -2
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +100 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
- data/lib/rubocop/cli/command/show_cops.rb +77 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +80 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/cli.rb +22 -230
- data/lib/rubocop/comment_config.rb +29 -16
- data/lib/rubocop/config.rb +80 -509
- data/lib/rubocop/config_loader.rb +122 -91
- data/lib/rubocop/config_loader_resolver.rb +65 -24
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +34 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +101 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +19 -5
- data/lib/rubocop/config_validator.rb +239 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +83 -6
- data/lib/rubocop/cop/badge.rb +15 -30
- data/lib/rubocop/cop/base.rb +447 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +28 -4
- data/lib/rubocop/cop/bundler/gem_comment.rb +83 -9
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +15 -23
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
- data/lib/rubocop/cop/commissioner.rb +102 -70
- data/lib/rubocop/cop/cop.rb +102 -186
- data/lib/rubocop/cop/corrector.rb +71 -122
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +45 -23
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +36 -5
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +9 -14
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -5
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -5
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +45 -20
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
- data/lib/rubocop/cop/generator/configuration_injector.rb +12 -7
- data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
- data/lib/rubocop/cop/generator.rb +15 -21
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +3 -3
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +13 -15
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +11 -10
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +12 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +10 -10
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +5 -5
- data/lib/rubocop/cop/internal_affairs.rb +1 -0
- data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +11 -2
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +30 -27
- data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
- data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
- data/lib/rubocop/cop/layout/class_structure.rb +53 -69
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
- data/lib/rubocop/cop/layout/condition_position.rb +16 -8
- data/lib/rubocop/cop/layout/def_end_alignment.rb +7 -4
- data/lib/rubocop/cop/layout/dot_position.rb +21 -20
- data/lib/rubocop/cop/layout/else_alignment.rb +23 -2
- data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +43 -25
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +15 -15
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +100 -31
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +21 -20
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +13 -9
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +4 -7
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +17 -22
- data/lib/rubocop/cop/layout/end_of_line.rb +16 -11
- data/lib/rubocop/cop/layout/extra_spacing.rb +34 -94
- data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +28 -15
- data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
- data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +8 -4
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +41 -37
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +30 -17
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +29 -13
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +72 -11
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
- data/lib/rubocop/cop/{metrics → layout}/line_length.rb +92 -130
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +70 -27
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -11
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +8 -4
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
- data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +59 -26
- data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -42
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
- data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +127 -44
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +37 -21
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
- data/lib/rubocop/cop/layout/space_inside_parens.rb +43 -26
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -41
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +56 -16
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -6
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +19 -6
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -11
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +98 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +18 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +93 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +3 -13
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +10 -13
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +4 -3
- data/lib/rubocop/cop/lint/else_layout.rb +30 -4
- data/lib/rubocop/cop/lint/empty_block.rb +82 -0
- data/lib/rubocop/cop/lint/empty_class.rb +93 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -9
- data/lib/rubocop/cop/lint/empty_when.rb +31 -8
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +66 -8
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +52 -41
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +12 -15
- data/lib/rubocop/cop/lint/inherit_exception.rb +13 -8
- data/lib/rubocop/cop/lint/interpolation_check.rb +26 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +46 -15
- data/lib/rubocop/cop/lint/loop.rb +30 -7
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
- data/lib/rubocop/cop/lint/missing_super.rb +102 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
- data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +11 -12
- data/lib/rubocop/cop/lint/nested_method_definition.rb +20 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +16 -2
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +2 -2
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +10 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +54 -23
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +98 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
- data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
- data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
- data/lib/rubocop/cop/lint/rand_one.rb +4 -3
- data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +128 -0
- data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +9 -11
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
- data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +25 -16
- data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +11 -18
- data/lib/rubocop/cop/lint/redundant_with_index.rb +13 -16
- data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -16
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +11 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +11 -3
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +87 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +12 -13
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +20 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
- data/lib/rubocop/cop/lint/syntax.rb +11 -28
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +86 -0
- data/lib/rubocop/cop/lint/to_json.rb +21 -12
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +5 -9
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +199 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +3 -3
- data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +30 -9
- data/lib/rubocop/cop/lint/unused_method_argument.rb +63 -14
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +5 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +95 -47
- data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +15 -8
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/lint/void.rb +10 -33
- data/lib/rubocop/cop/message_annotator.rb +16 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +27 -3
- data/lib/rubocop/cop/metrics/block_length.rb +40 -10
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +39 -8
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
- data/lib/rubocop/cop/metrics/method_length.rb +33 -5
- data/lib/rubocop/cop/metrics/module_length.rb +27 -4
- data/lib/rubocop/cop/metrics/parameter_lists.rb +71 -9
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +95 -14
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +146 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +83 -0
- data/lib/rubocop/cop/mixin/alignment.rb +8 -6
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +20 -17
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -4
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +4 -2
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +15 -5
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -6
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +5 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
- data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
- data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +24 -4
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +5 -5
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +88 -1
- data/lib/rubocop/cop/mixin/range_help.rb +19 -5
- data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +51 -23
- data/lib/rubocop/cop/mixin/string_help.rb +4 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +19 -33
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +36 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +19 -3
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +16 -6
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
- data/lib/rubocop/cop/naming/constant_name.rb +5 -4
- data/lib/rubocop/cop/naming/file_name.rb +40 -22
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +12 -6
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +69 -20
- data/lib/rubocop/cop/naming/method_name.rb +39 -2
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/predicate_name.rb +12 -15
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +27 -28
- data/lib/rubocop/cop/naming/variable_name.rb +2 -1
- data/lib/rubocop/cop/naming/variable_number.rb +101 -9
- data/lib/rubocop/cop/offense.rb +62 -12
- data/lib/rubocop/cop/registry.rb +97 -11
- data/lib/rubocop/cop/security/eval.rb +4 -3
- data/lib/rubocop/cop/security/json_load.rb +8 -9
- data/lib/rubocop/cop/security/marshal_load.rb +4 -5
- data/lib/rubocop/cop/security/open.rb +15 -12
- data/lib/rubocop/cop/security/yaml_load.rb +8 -7
- data/lib/rubocop/cop/severity.rb +1 -11
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
- data/lib/rubocop/cop/style/alias.rb +45 -38
- data/lib/rubocop/cop/style/and_or.rb +27 -22
- data/lib/rubocop/cop/style/arguments_forwarding.rb +142 -0
- data/lib/rubocop/cop/style/array_coercion.rb +67 -0
- data/lib/rubocop/cop/style/array_join.rb +8 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +22 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +137 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +79 -27
- data/lib/rubocop/cop/style/case_equality.rb +54 -4
- data/lib/rubocop/cop/style/case_like_if.rb +248 -0
- data/lib/rubocop/cop/style/character_literal.rb +10 -11
- data/lib/rubocop/cop/style/class_and_module_children.rb +26 -16
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +23 -7
- data/lib/rubocop/cop/style/collection_compact.rb +91 -0
- data/lib/rubocop/cop/style/collection_methods.rb +13 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +9 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
- data/lib/rubocop/cop/style/command_literal.rb +24 -25
- data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
- data/lib/rubocop/cop/style/commented_keyword.rb +23 -35
- data/lib/rubocop/cop/style/conditional_assignment.rb +77 -82
- data/lib/rubocop/cop/style/constant_visibility.rb +17 -5
- data/lib/rubocop/cop/style/copyright.rb +27 -23
- data/lib/rubocop/cop/style/date_time.rb +17 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +11 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +62 -15
- data/lib/rubocop/cop/style/documentation_method.rb +46 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
- data/lib/rubocop/cop/style/double_negation.rb +49 -6
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +6 -9
- data/lib/rubocop/cop/style/each_with_object.rb +17 -20
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +26 -27
- data/lib/rubocop/cop/style/empty_method.rb +13 -20
- data/lib/rubocop/cop/style/encoding.rb +6 -10
- data/lib/rubocop/cop/style/end_block.rb +6 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +10 -10
- data/lib/rubocop/cop/style/even_odd.rb +10 -13
- data/lib/rubocop/cop/style/expand_path_arguments.rb +30 -29
- data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
- data/lib/rubocop/cop/style/float_division.rb +136 -0
- data/lib/rubocop/cop/style/for.rb +7 -15
- data/lib/rubocop/cop/style/format_string.rb +48 -37
- data/lib/rubocop/cop/style/format_string_token.rb +70 -77
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +113 -65
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +69 -16
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +32 -23
- data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +9 -4
- data/lib/rubocop/cop/style/if_inside_else.rb +80 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +124 -44
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -28
- data/lib/rubocop/cop/style/inline_comment.rb +4 -4
- data/lib/rubocop/cop/style/inverse_methods.rb +39 -39
- data/lib/rubocop/cop/style/ip_addresses.rb +6 -6
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +65 -0
- data/lib/rubocop/cop/style/lambda.rb +9 -15
- data/lib/rubocop/cop/style/lambda_call.rb +17 -34
- data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +169 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -226
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +18 -10
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
- data/lib/rubocop/cop/style/min_max.rb +9 -13
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +26 -33
- data/lib/rubocop/cop/style/mixin_usage.rb +12 -21
- data/lib/rubocop/cop/style/module_function.rb +64 -21
- data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
- data/lib/rubocop/cop/style/multiline_when_then.rb +73 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +56 -8
- data/lib/rubocop/cop/style/mutable_constant.rb +30 -29
- data/lib/rubocop/cop/style/negated_if.rb +9 -9
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +106 -0
- data/lib/rubocop/cop/style/negated_unless.rb +9 -9
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +31 -16
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
- data/lib/rubocop/cop/style/next.rb +19 -23
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/nil_lambda.rb +52 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
- data/lib/rubocop/cop/style/numeric_literals.rb +21 -14
- data/lib/rubocop/cop/style/numeric_predicate.rb +14 -19
- data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
- data/lib/rubocop/cop/style/option_hash.rb +5 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
- data/lib/rubocop/cop/style/or_assignment.rb +24 -15
- data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +21 -7
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +91 -16
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +7 -7
- data/lib/rubocop/cop/style/raise_args.rb +33 -30
- data/lib/rubocop/cop/style/random_with_offset.rb +29 -34
- data/lib/rubocop/cop/style/redundant_argument.rb +88 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
- data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +43 -15
- data/lib/rubocop/cop/style/redundant_conditional.rb +11 -11
- data/lib/rubocop/cop/style/redundant_exception.rb +21 -15
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +7 -9
- data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
- data/lib/rubocop/cop/style/redundant_parentheses.rb +53 -32
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +121 -0
- data/lib/rubocop/cop/style/redundant_return.rb +52 -44
- data/lib/rubocop/cop/style/redundant_self.rb +36 -21
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
- data/lib/rubocop/cop/style/redundant_sort_by.rb +6 -10
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +53 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +23 -19
- data/lib/rubocop/cop/style/return_nil.rb +7 -7
- data/lib/rubocop/cop/style/safe_navigation.rb +54 -20
- data/lib/rubocop/cop/style/sample.rb +14 -16
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +23 -12
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +26 -20
- data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +32 -7
- data/lib/rubocop/cop/style/single_line_methods.rb +26 -18
- data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +128 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +18 -41
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
- data/lib/rubocop/cop/style/static_class.rb +97 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +7 -8
- data/lib/rubocop/cop/style/string_concatenation.rb +143 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +8 -9
- data/lib/rubocop/cop/style/string_literals.rb +14 -8
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +4 -3
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +10 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +23 -5
- data/lib/rubocop/cop/style/swap_values.rb +108 -0
- data/lib/rubocop/cop/style/symbol_array.rb +13 -24
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
- data/lib/rubocop/cop/style/symbol_proc.rb +22 -24
- data/lib/rubocop/cop/style/ternary_parentheses.rb +57 -31
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +39 -25
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -34
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +19 -22
- data/lib/rubocop/cop/style/trivial_accessors.rb +36 -39
- data/lib/rubocop/cop/style/unless_else.rb +6 -9
- data/lib/rubocop/cop/style/unpack_first.rb +5 -12
- data/lib/rubocop/cop/style/variable_interpolation.rb +11 -24
- data/lib/rubocop/cop/style/when_then.rb +5 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +17 -22
- data/lib/rubocop/cop/style/word_array.rb +8 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
- data/lib/rubocop/cop/style/zero_length_predicate.rb +25 -27
- data/lib/rubocop/cop/team.rb +159 -87
- data/lib/rubocop/cop/util.rb +36 -19
- data/lib/rubocop/cop/utils/format_string.rb +135 -0
- data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
- data/lib/rubocop/cop/variable_force/branch.rb +2 -7
- data/lib/rubocop/cop/variable_force/scope.rb +2 -1
- data/lib/rubocop/cop/variable_force/variable.rb +20 -8
- data/lib/rubocop/cop/variable_force.rb +16 -17
- data/lib/rubocop/cops_documentation_generator.rb +284 -0
- data/lib/rubocop/core_ext/hash.rb +20 -0
- data/lib/rubocop/core_ext/string.rb +2 -26
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/error.rb +24 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +95 -0
- data/lib/rubocop/file_finder.rb +13 -12
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +8 -5
- data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -22
- data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +20 -19
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +47 -0
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/json_formatter.rb +6 -5
- data/lib/rubocop/formatter/junit_formatter.rb +84 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +1 -1
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +54 -10
- data/lib/rubocop/formatter/tap_formatter.rb +19 -6
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -1
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +7 -3
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +131 -60
- data/lib/rubocop/path_util.rb +19 -19
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +10 -11
- data/lib/rubocop/remote_config.rb +2 -3
- data/lib/rubocop/result_cache.rb +69 -27
- data/lib/rubocop/rspec/cop_helper.rb +11 -32
- data/lib/rubocop/rspec/expect_offense.rb +107 -25
- data/lib/rubocop/rspec/shared_contexts.rb +89 -40
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +127 -73
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +61 -48
- data/lib/rubocop/target_ruby.rb +224 -0
- data/lib/rubocop/version.rb +65 -7
- data/lib/rubocop/yaml_duplication_checker.rb +9 -2
- data/lib/rubocop.rb +172 -145
- metadata +230 -184
- data/bin/console +0 -9
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -79
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -29
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -646
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
- data/lib/rubocop/cop/layout/tab.rb +0 -87
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb +0 -116
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
- data/lib/rubocop/cop/rails/blank.rb +0 -164
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -161
- data/lib/rubocop/cop/rails/delegate.rb +0 -132
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -51
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -179
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -153
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
- data/lib/rubocop/cop/rails/time_zone.rb +0 -238
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -109
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -190
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -720
- data/lib/rubocop/processed_source.rb +0 -208
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -22,6 +22,8 @@ module RuboCop
|
|
22
22
|
#
|
23
23
|
# def after_declaring_variable(variable, variable_table)
|
24
24
|
# end
|
25
|
+
#
|
26
|
+
# @api private
|
25
27
|
class VariableForce < Force # rubocop:disable Metrics/ClassLength
|
26
28
|
VARIABLE_ASSIGNMENT_TYPE = :lvasgn
|
27
29
|
REGEXP_NAMED_CAPTURE_TYPE = :match_with_lvasgn
|
@@ -152,9 +154,7 @@ module RuboCop
|
|
152
154
|
def process_variable_assignment(node)
|
153
155
|
name = node.children.first
|
154
156
|
|
155
|
-
unless variable_table.variable_exist?(name)
|
156
|
-
variable_table.declare_variable(name, node)
|
157
|
-
end
|
157
|
+
variable_table.declare_variable(name, node) unless variable_table.variable_exist?(name)
|
158
158
|
|
159
159
|
# Need to scan rhs before assignment so that we can mark previous
|
160
160
|
# assignments as referenced if rhs has referencing to the variable
|
@@ -190,13 +190,15 @@ module RuboCop
|
|
190
190
|
end
|
191
191
|
|
192
192
|
def regexp_captured_names(node)
|
193
|
-
regexp_string = node.children
|
193
|
+
regexp_string = node.children.select(&:str_type?).map do |child|
|
194
|
+
child.children.first
|
195
|
+
end.join || ''
|
196
|
+
|
194
197
|
regexp = Regexp.new(regexp_string)
|
195
198
|
|
196
199
|
regexp.named_captures.keys
|
197
200
|
end
|
198
201
|
|
199
|
-
# rubocop:disable Metrics/AbcSize
|
200
202
|
def process_variable_operator_assignment(node)
|
201
203
|
if LOGICAL_OPERATOR_ASSIGNMENT_TYPES.include?(node.type)
|
202
204
|
asgn_node, rhs_node = *node
|
@@ -208,9 +210,7 @@ module RuboCop
|
|
208
210
|
|
209
211
|
name = asgn_node.children.first
|
210
212
|
|
211
|
-
unless variable_table.variable_exist?(name)
|
212
|
-
variable_table.declare_variable(name, asgn_node)
|
213
|
-
end
|
213
|
+
variable_table.declare_variable(name, asgn_node) unless variable_table.variable_exist?(name)
|
214
214
|
|
215
215
|
# The following statements:
|
216
216
|
#
|
@@ -233,7 +233,6 @@ module RuboCop
|
|
233
233
|
|
234
234
|
skip_children!
|
235
235
|
end
|
236
|
-
# rubocop:enable Metrics/AbcSize
|
237
236
|
|
238
237
|
def process_variable_multiple_assignment(node)
|
239
238
|
lhs_node, rhs_node = *node
|
@@ -284,11 +283,7 @@ module RuboCop
|
|
284
283
|
def process_scope(node)
|
285
284
|
if TWISTED_SCOPE_TYPES.include?(node.type)
|
286
285
|
# See the comment at the end of file for this behavior.
|
287
|
-
twisted_nodes
|
288
|
-
twisted_nodes << node.children[1] if node.class_type?
|
289
|
-
twisted_nodes.compact!
|
290
|
-
|
291
|
-
twisted_nodes.each do |twisted_node|
|
286
|
+
twisted_nodes(node).each do |twisted_node|
|
292
287
|
process_node(twisted_node)
|
293
288
|
scanned_nodes << twisted_node
|
294
289
|
end
|
@@ -298,6 +293,12 @@ module RuboCop
|
|
298
293
|
skip_children!
|
299
294
|
end
|
300
295
|
|
296
|
+
def twisted_nodes(node)
|
297
|
+
twisted_nodes = [node.children[0]]
|
298
|
+
twisted_nodes << node.children[1] if node.class_type?
|
299
|
+
twisted_nodes.compact
|
300
|
+
end
|
301
|
+
|
301
302
|
def process_send(node)
|
302
303
|
_receiver, method_name, args = *node
|
303
304
|
return unless method_name == :binding
|
@@ -364,9 +365,7 @@ module RuboCop
|
|
364
365
|
AssignmentReference.new(node)
|
365
366
|
when *OPERATOR_ASSIGNMENT_TYPES
|
366
367
|
asgn_node = node.children.first
|
367
|
-
if asgn_node.lvasgn_type?
|
368
|
-
VariableReference.new(asgn_node.children.first)
|
369
|
-
end
|
368
|
+
VariableReference.new(asgn_node.children.first) if asgn_node.lvasgn_type?
|
370
369
|
end
|
371
370
|
end
|
372
371
|
|
@@ -0,0 +1,284 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
# Class for generating documentation of all cops departments
|
4
|
+
# @api private
|
5
|
+
class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
|
6
|
+
include ::RuboCop::Cop::Documentation
|
7
|
+
# This class will only generate documentation for cops that belong to one of
|
8
|
+
# the departments given in the `departments` array. E.g. if we only wanted
|
9
|
+
# documentation for Lint cops:
|
10
|
+
#
|
11
|
+
# CopsDocumentationGenerator.new(departments: ['Lint']).call
|
12
|
+
#
|
13
|
+
def initialize(departments: [])
|
14
|
+
@departments = departments.map(&:to_sym).sort!
|
15
|
+
@cops = RuboCop::Cop::Registry.global
|
16
|
+
@config = RuboCop::ConfigLoader.default_configuration
|
17
|
+
end
|
18
|
+
|
19
|
+
def call
|
20
|
+
YARD::Registry.load!
|
21
|
+
departments.each do |department|
|
22
|
+
print_cops_of_department(department)
|
23
|
+
end
|
24
|
+
|
25
|
+
print_table_of_contents
|
26
|
+
ensure
|
27
|
+
RuboCop::ConfigLoader.default_configuration = nil
|
28
|
+
end
|
29
|
+
|
30
|
+
private
|
31
|
+
|
32
|
+
attr_reader :departments, :cops, :config
|
33
|
+
|
34
|
+
def cops_of_department(department)
|
35
|
+
cops.with_department(department).sort!
|
36
|
+
end
|
37
|
+
|
38
|
+
def cops_body(cop, description, examples_objects, pars)
|
39
|
+
content = h2(cop.cop_name)
|
40
|
+
content << required_ruby_version(cop)
|
41
|
+
content << properties(cop)
|
42
|
+
content << "#{description}\n"
|
43
|
+
content << examples(examples_objects) if examples_objects.count.positive?
|
44
|
+
content << configurations(pars)
|
45
|
+
content << references(cop)
|
46
|
+
content
|
47
|
+
end
|
48
|
+
|
49
|
+
def examples(examples_object)
|
50
|
+
examples_object.each_with_object(h3('Examples').dup) do |example, content|
|
51
|
+
content << "\n" unless content.end_with?("\n\n")
|
52
|
+
content << h4(example.name) unless example.name == ''
|
53
|
+
content << code_example(example)
|
54
|
+
end
|
55
|
+
end
|
56
|
+
|
57
|
+
def required_ruby_version(cop)
|
58
|
+
return '' unless cop.respond_to?(:required_minimum_ruby_version)
|
59
|
+
|
60
|
+
"NOTE: Required Ruby version: #{cop.required_minimum_ruby_version}\n\n"
|
61
|
+
end
|
62
|
+
|
63
|
+
# rubocop:disable Metrics/MethodLength
|
64
|
+
def properties(cop)
|
65
|
+
header = [
|
66
|
+
'Enabled by default', 'Safe', 'Supports autocorrection', 'VersionAdded',
|
67
|
+
'VersionChanged'
|
68
|
+
]
|
69
|
+
autocorrect = if cop.support_autocorrect?
|
70
|
+
"Yes#{' (Unsafe)' unless cop.new(config).safe_autocorrect?}"
|
71
|
+
else
|
72
|
+
'No'
|
73
|
+
end
|
74
|
+
cop_config = config.for_cop(cop)
|
75
|
+
content = [[
|
76
|
+
cop_status(cop_config.fetch('Enabled')),
|
77
|
+
cop_config.fetch('Safe', true) ? 'Yes' : 'No',
|
78
|
+
autocorrect,
|
79
|
+
cop_config.fetch('VersionAdded', '-'),
|
80
|
+
cop_config.fetch('VersionChanged', '-')
|
81
|
+
]]
|
82
|
+
"#{to_table(header, content)}\n"
|
83
|
+
end
|
84
|
+
# rubocop:enable Metrics/MethodLength
|
85
|
+
|
86
|
+
def h2(title)
|
87
|
+
content = +"\n"
|
88
|
+
content << "== #{title}\n"
|
89
|
+
content << "\n"
|
90
|
+
content
|
91
|
+
end
|
92
|
+
|
93
|
+
def h3(title)
|
94
|
+
content = +"\n"
|
95
|
+
content << "=== #{title}\n"
|
96
|
+
content << "\n"
|
97
|
+
content
|
98
|
+
end
|
99
|
+
|
100
|
+
def h4(title)
|
101
|
+
content = +"==== #{title}\n"
|
102
|
+
content << "\n"
|
103
|
+
content
|
104
|
+
end
|
105
|
+
|
106
|
+
def code_example(ruby_code)
|
107
|
+
content = +"[source,ruby]\n----\n"
|
108
|
+
content << ruby_code.text.gsub('@good', '# good')
|
109
|
+
.gsub('@bad', '# bad').strip
|
110
|
+
content << "\n----\n"
|
111
|
+
content
|
112
|
+
end
|
113
|
+
|
114
|
+
def configurations(pars)
|
115
|
+
return '' if pars.empty?
|
116
|
+
|
117
|
+
header = ['Name', 'Default value', 'Configurable values']
|
118
|
+
configs = pars
|
119
|
+
.each_key
|
120
|
+
.reject { |key| key.start_with?('Supported') }
|
121
|
+
.reject { |key| key.start_with?('AllowMultipleStyles') }
|
122
|
+
content = configs.map do |name|
|
123
|
+
configurable = configurable_values(pars, name)
|
124
|
+
default = format_table_value(pars[name])
|
125
|
+
[name, default, configurable]
|
126
|
+
end
|
127
|
+
|
128
|
+
h3('Configurable attributes') + to_table(header, content)
|
129
|
+
end
|
130
|
+
|
131
|
+
# rubocop:disable Metrics/CyclomaticComplexity,Metrics/MethodLength
|
132
|
+
def configurable_values(pars, name)
|
133
|
+
case name
|
134
|
+
when /^Enforced/
|
135
|
+
supported_style_name = RuboCop::Cop::Util.to_supported_styles(name)
|
136
|
+
format_table_value(pars[supported_style_name])
|
137
|
+
when 'IndentationWidth'
|
138
|
+
'Integer'
|
139
|
+
when 'Database'
|
140
|
+
format_table_value(pars['SupportedDatabases'])
|
141
|
+
else
|
142
|
+
case pars[name]
|
143
|
+
when String
|
144
|
+
'String'
|
145
|
+
when Integer
|
146
|
+
'Integer'
|
147
|
+
when Float
|
148
|
+
'Float'
|
149
|
+
when true, false
|
150
|
+
'Boolean'
|
151
|
+
when Array
|
152
|
+
'Array'
|
153
|
+
else
|
154
|
+
''
|
155
|
+
end
|
156
|
+
end
|
157
|
+
end
|
158
|
+
# rubocop:enable Metrics/CyclomaticComplexity,Metrics/MethodLength
|
159
|
+
|
160
|
+
def to_table(header, content)
|
161
|
+
table = [
|
162
|
+
'|===',
|
163
|
+
"| #{header.join(' | ')}\n\n"
|
164
|
+
].join("\n")
|
165
|
+
marked_contents = content.map do |plain_content|
|
166
|
+
plain_content.map { |c| "| #{c}" }.join("\n")
|
167
|
+
end
|
168
|
+
table << marked_contents.join("\n\n")
|
169
|
+
table << "\n|===\n"
|
170
|
+
end
|
171
|
+
|
172
|
+
def format_table_value(val)
|
173
|
+
value =
|
174
|
+
case val
|
175
|
+
when Array
|
176
|
+
if val.empty?
|
177
|
+
'`[]`'
|
178
|
+
else
|
179
|
+
val.map { |config| format_table_value(config) }.join(', ')
|
180
|
+
end
|
181
|
+
else
|
182
|
+
wrap_backtick(val.nil? ? '<none>' : val)
|
183
|
+
end
|
184
|
+
value.gsub("#{Dir.pwd}/", '').rstrip
|
185
|
+
end
|
186
|
+
|
187
|
+
def wrap_backtick(value)
|
188
|
+
if value.is_a?(String)
|
189
|
+
# Use `+` to prevent text like `**/*.gemspec` from being bold.
|
190
|
+
value.start_with?('*') ? "`+#{value}+`" : "`#{value}`"
|
191
|
+
else
|
192
|
+
"`#{value}`"
|
193
|
+
end
|
194
|
+
end
|
195
|
+
|
196
|
+
def references(cop)
|
197
|
+
cop_config = config.for_cop(cop)
|
198
|
+
urls = RuboCop::Cop::MessageAnnotator.new(
|
199
|
+
config, cop.name, cop_config, {}
|
200
|
+
).urls
|
201
|
+
return '' if urls.empty?
|
202
|
+
|
203
|
+
content = h3('References')
|
204
|
+
content << urls.map { |url| "* #{url}" }.join("\n")
|
205
|
+
content << "\n"
|
206
|
+
content
|
207
|
+
end
|
208
|
+
|
209
|
+
def print_cops_of_department(department)
|
210
|
+
selected_cops = cops_of_department(department)
|
211
|
+
content = +"= #{department}\n"
|
212
|
+
selected_cops.each do |cop|
|
213
|
+
content << print_cop_with_doc(cop)
|
214
|
+
end
|
215
|
+
file_name = "#{Dir.pwd}/docs/modules/ROOT/pages/#{department_to_basename(department)}.adoc"
|
216
|
+
File.open(file_name, 'w') do |file|
|
217
|
+
puts "* generated #{file_name}"
|
218
|
+
file.write("#{content.strip}\n")
|
219
|
+
end
|
220
|
+
end
|
221
|
+
|
222
|
+
def print_cop_with_doc(cop)
|
223
|
+
cop_config = config.for_cop(cop)
|
224
|
+
non_display_keys = %w[
|
225
|
+
Description Enabled StyleGuide Reference Safe SafeAutoCorrect VersionAdded
|
226
|
+
VersionChanged
|
227
|
+
]
|
228
|
+
pars = cop_config.reject { |k| non_display_keys.include? k }
|
229
|
+
description = 'No documentation'
|
230
|
+
examples_object = []
|
231
|
+
cop_code(cop) do |code_object|
|
232
|
+
description = code_object.docstring unless code_object.docstring.blank?
|
233
|
+
examples_object = code_object.tags('example')
|
234
|
+
end
|
235
|
+
cops_body(cop, description, examples_object, pars)
|
236
|
+
end
|
237
|
+
|
238
|
+
def cop_code(cop)
|
239
|
+
YARD::Registry.all(:class).detect do |code_object|
|
240
|
+
next unless RuboCop::Cop::Badge.for(code_object.to_s) == cop.badge
|
241
|
+
|
242
|
+
yield code_object
|
243
|
+
end
|
244
|
+
end
|
245
|
+
|
246
|
+
def table_of_content_for_department(department)
|
247
|
+
type_title = department[0].upcase + department[1..-1]
|
248
|
+
filename = "#{department_to_basename(department)}.adoc"
|
249
|
+
content = +"=== Department xref:#{filename}[#{type_title}]\n\n"
|
250
|
+
cops_of_department(department).each do |cop|
|
251
|
+
anchor = cop.cop_name.sub('/', '').downcase
|
252
|
+
content << "* xref:#{filename}##{anchor}[#{cop.cop_name}]\n"
|
253
|
+
end
|
254
|
+
|
255
|
+
content
|
256
|
+
end
|
257
|
+
|
258
|
+
def print_table_of_contents
|
259
|
+
path = "#{Dir.pwd}/docs/modules/ROOT/pages/cops.adoc"
|
260
|
+
original = File.read(path)
|
261
|
+
content = +"// START_COP_LIST\n\n"
|
262
|
+
|
263
|
+
content << table_contents
|
264
|
+
|
265
|
+
content << "\n// END_COP_LIST"
|
266
|
+
|
267
|
+
content = original.sub(
|
268
|
+
%r{// START_COP_LIST.+// END_COP_LIST}m, content
|
269
|
+
)
|
270
|
+
File.write(path, content)
|
271
|
+
end
|
272
|
+
|
273
|
+
def table_contents
|
274
|
+
departments
|
275
|
+
.map { |department| table_of_content_for_department(department) }
|
276
|
+
.join("\n")
|
277
|
+
end
|
278
|
+
|
279
|
+
def cop_status(status)
|
280
|
+
return 'Disabled' unless status
|
281
|
+
|
282
|
+
status == 'pending' ? 'Pending' : 'Enabled'
|
283
|
+
end
|
284
|
+
end
|
@@ -0,0 +1,20 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
# Extensions to the core Hash class
|
4
|
+
class Hash
|
5
|
+
unless method_defined?(:slice)
|
6
|
+
# Adds `Hash#slice` for Ruby 2.4.
|
7
|
+
# Returns a hash containing a subset of keys. If a given key is not
|
8
|
+
# in the hash, it will not be returned.
|
9
|
+
#
|
10
|
+
# @return [Hash] hash containing only the keys given.
|
11
|
+
#
|
12
|
+
# @example
|
13
|
+
# { one: 1, two: 2 }.slice(:two, :three) #=> { two: 2 }
|
14
|
+
def slice(*keys)
|
15
|
+
h = {}
|
16
|
+
keys.each { |k| h[k] = self[k] if key?(k) }
|
17
|
+
h
|
18
|
+
end
|
19
|
+
end
|
20
|
+
end
|
@@ -2,7 +2,7 @@
|
|
2
2
|
|
3
3
|
# Extensions to the core String class
|
4
4
|
class String
|
5
|
-
unless method_defined?
|
5
|
+
unless method_defined?(:blank?) && ' '.blank?
|
6
6
|
# Checks whether a string is blank. A string is considered blank if it
|
7
7
|
# is either empty or contains only whitespace characters.
|
8
8
|
#
|
@@ -17,31 +17,7 @@ class String
|
|
17
17
|
# @example
|
18
18
|
# ' test'.blank? #=> false
|
19
19
|
def blank?
|
20
|
-
empty? ||
|
21
|
-
end
|
22
|
-
end
|
23
|
-
|
24
|
-
unless method_defined? :strip_indent
|
25
|
-
# The method strips the whitespace preceding the base indentation.
|
26
|
-
# Useful for HEREDOCs and other multi-line strings.
|
27
|
-
#
|
28
|
-
# @example
|
29
|
-
#
|
30
|
-
# code = <<~END
|
31
|
-
# def test
|
32
|
-
# some_method
|
33
|
-
# other_method
|
34
|
-
# end
|
35
|
-
# END
|
36
|
-
#
|
37
|
-
# #=> "def\n some_method\n \nother_method\nend"
|
38
|
-
#
|
39
|
-
# @todo Replace call sites with squiggly heredocs when required Ruby
|
40
|
-
# version is >= 2.3.0
|
41
|
-
def strip_indent
|
42
|
-
leading_space = scan(/^[ \t]*(?=\S)/).min
|
43
|
-
indent = leading_space ? leading_space.size : 0
|
44
|
-
gsub(/^[ \t]{#{indent}}/, '')
|
20
|
+
empty? || lstrip.empty?
|
45
21
|
end
|
46
22
|
end
|
47
23
|
end
|
@@ -0,0 +1,32 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
# This class wraps the `Parser::Source::Comment` object that represents a
|
5
|
+
# special `rubocop:disable` and `rubocop:enable` comment and exposes what
|
6
|
+
# cops it contains.
|
7
|
+
class DirectiveComment
|
8
|
+
attr_reader :comment
|
9
|
+
|
10
|
+
def initialize(comment)
|
11
|
+
@comment = comment
|
12
|
+
end
|
13
|
+
|
14
|
+
# Return all the cops specified in the directive
|
15
|
+
def cops
|
16
|
+
match = comment.text.match(CommentConfig::COMMENT_DIRECTIVE_REGEXP)
|
17
|
+
return unless match
|
18
|
+
|
19
|
+
cops_string = match.captures[1]
|
20
|
+
cops_string.split(/,\s*/).uniq.sort
|
21
|
+
end
|
22
|
+
|
23
|
+
# Checks if this directive contains all the given cop names
|
24
|
+
def match?(cop_names)
|
25
|
+
cops == cop_names.uniq.sort
|
26
|
+
end
|
27
|
+
|
28
|
+
def range
|
29
|
+
comment.location.expression
|
30
|
+
end
|
31
|
+
end
|
32
|
+
end
|
data/lib/rubocop/error.rb
CHANGED
@@ -8,4 +8,28 @@ module RuboCop
|
|
8
8
|
class Error < StandardError; end
|
9
9
|
|
10
10
|
class ValidationError < Error; end
|
11
|
+
|
12
|
+
# A wrapper to display errored location of analyzed file.
|
13
|
+
class ErrorWithAnalyzedFileLocation < Error
|
14
|
+
def initialize(cause:, node:, cop:)
|
15
|
+
super()
|
16
|
+
@cause = cause
|
17
|
+
@cop = cop
|
18
|
+
@location = node.is_a?(RuboCop::AST::Node) ? node.loc : node
|
19
|
+
end
|
20
|
+
|
21
|
+
attr_reader :cause, :cop
|
22
|
+
|
23
|
+
def line
|
24
|
+
@location&.line
|
25
|
+
end
|
26
|
+
|
27
|
+
def column
|
28
|
+
@location&.column
|
29
|
+
end
|
30
|
+
|
31
|
+
def message
|
32
|
+
"cause: #{cause.inspect}"
|
33
|
+
end
|
34
|
+
end
|
11
35
|
end
|
@@ -0,0 +1,18 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Ext
|
5
|
+
# Extensions to AST::ProcessedSource for our cached comment_config
|
6
|
+
module ProcessedSource
|
7
|
+
def comment_config
|
8
|
+
@comment_config ||= CommentConfig.new(self)
|
9
|
+
end
|
10
|
+
|
11
|
+
def disabled_line_ranges
|
12
|
+
comment_config.cop_disabled_line_ranges
|
13
|
+
end
|
14
|
+
end
|
15
|
+
end
|
16
|
+
end
|
17
|
+
|
18
|
+
RuboCop::ProcessedSource.include RuboCop::Ext::ProcessedSource
|
@@ -0,0 +1,87 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Ext
|
5
|
+
# Extensions to AST::RegexpNode for our cached parsed regexp info
|
6
|
+
module RegexpNode
|
7
|
+
ANY = Object.new
|
8
|
+
def ANY.==(_)
|
9
|
+
true
|
10
|
+
end
|
11
|
+
private_constant :ANY
|
12
|
+
|
13
|
+
# @return [Regexp::Expression::Root, nil]
|
14
|
+
# Note: we extend Regexp nodes to provide `loc` and `expression`
|
15
|
+
# see `ext/regexp_parser`.
|
16
|
+
attr_reader :parsed_tree
|
17
|
+
|
18
|
+
if Gem::Version.new(Regexp::Parser::VERSION) >= Gem::Version.new('2.0')
|
19
|
+
def assign_properties(*)
|
20
|
+
super
|
21
|
+
|
22
|
+
str = with_interpolations_blanked
|
23
|
+
@parsed_tree = begin
|
24
|
+
Regexp::Parser.parse(str, options: options)
|
25
|
+
rescue StandardError
|
26
|
+
nil
|
27
|
+
end
|
28
|
+
origin = loc.begin.end
|
29
|
+
@parsed_tree&.each_expression(true) { |e| e.origin = origin }
|
30
|
+
end
|
31
|
+
# Please remove this `else` branch when support for regexp_parser 1.8 will be dropped.
|
32
|
+
# It's for compatibility with regexp_arser 1.8 and will never be maintained.
|
33
|
+
else
|
34
|
+
def assign_properties(*)
|
35
|
+
super
|
36
|
+
|
37
|
+
str = with_interpolations_blanked
|
38
|
+
begin
|
39
|
+
@parsed_tree = Regexp::Parser.parse(str, options: options)
|
40
|
+
rescue StandardError
|
41
|
+
@parsed_tree = nil
|
42
|
+
else
|
43
|
+
origin = loc.begin.end
|
44
|
+
source = @parsed_tree.to_s
|
45
|
+
@parsed_tree.each_expression(true) do |e|
|
46
|
+
e.origin = origin
|
47
|
+
e.source = source
|
48
|
+
end
|
49
|
+
end
|
50
|
+
end
|
51
|
+
end
|
52
|
+
|
53
|
+
def each_capture(named: ANY)
|
54
|
+
return enum_for(__method__, named: named) unless block_given?
|
55
|
+
|
56
|
+
parsed_tree&.traverse do |event, exp, _index|
|
57
|
+
yield(exp) if event == :enter &&
|
58
|
+
named == exp.respond_to?(:name) &&
|
59
|
+
exp.respond_to?(:capturing?) &&
|
60
|
+
exp.capturing?
|
61
|
+
end
|
62
|
+
|
63
|
+
self
|
64
|
+
end
|
65
|
+
|
66
|
+
private
|
67
|
+
|
68
|
+
def with_interpolations_blanked
|
69
|
+
# Ignore the trailing regopt node
|
70
|
+
children[0...-1].map do |child|
|
71
|
+
source = child.source
|
72
|
+
|
73
|
+
# We don't want to consider the contents of interpolations as part of the pattern source,
|
74
|
+
# but need to preserve their width, to allow offsets to correctly line up with the
|
75
|
+
# original source: spaces have no effect, and preserve width.
|
76
|
+
if child.begin_type?
|
77
|
+
' ' * source.length
|
78
|
+
else
|
79
|
+
source
|
80
|
+
end
|
81
|
+
end.join
|
82
|
+
end
|
83
|
+
|
84
|
+
AST::RegexpNode.include self
|
85
|
+
end
|
86
|
+
end
|
87
|
+
end
|
@@ -0,0 +1,95 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Ext
|
5
|
+
# Extensions for `regexp_parser` gem
|
6
|
+
module RegexpParser
|
7
|
+
# Source map for RegexpParser nodes
|
8
|
+
class Map < ::Parser::Source::Map
|
9
|
+
attr_reader :body, :quantifier, :begin, :end
|
10
|
+
|
11
|
+
def initialize(expression, body:, quantifier: nil, begin_l: nil, end_l: nil)
|
12
|
+
@begin = begin_l
|
13
|
+
@end = end_l
|
14
|
+
@body = body
|
15
|
+
@quantifier = quantifier
|
16
|
+
super(expression)
|
17
|
+
end
|
18
|
+
end
|
19
|
+
|
20
|
+
module Expression
|
21
|
+
# Add `expression` and `loc` to all `regexp_parser` nodes
|
22
|
+
module Base
|
23
|
+
attr_accessor :origin
|
24
|
+
|
25
|
+
if Gem::Version.new(Regexp::Parser::VERSION) >= Gem::Version.new('2.0')
|
26
|
+
# Shortcut to `loc.expression`
|
27
|
+
def expression
|
28
|
+
@expression ||= origin.adjust(begin_pos: ts, end_pos: ts + full_length)
|
29
|
+
end
|
30
|
+
# Please remove this `else` branch when support for regexp_parser 1.8 will be dropped.
|
31
|
+
# It's for compatibility with regexp_arser 1.8 and will never be maintained.
|
32
|
+
else
|
33
|
+
attr_accessor :source
|
34
|
+
|
35
|
+
def start_index
|
36
|
+
# ts is a byte index; convert it to a character index
|
37
|
+
@start_index ||= source.byteslice(0, ts).length
|
38
|
+
end
|
39
|
+
|
40
|
+
# Shortcut to `loc.expression`
|
41
|
+
def expression
|
42
|
+
@expression ||= begin
|
43
|
+
origin.adjust(begin_pos: start_index, end_pos: start_index + full_length)
|
44
|
+
end
|
45
|
+
end
|
46
|
+
end
|
47
|
+
|
48
|
+
# @returns a location map like `parser` does, with:
|
49
|
+
# - expression: complete expression
|
50
|
+
# - quantifier: for `+`, `{1,2}`, etc.
|
51
|
+
# - begin/end: for `[` and `]` (only CharacterSet for now)
|
52
|
+
#
|
53
|
+
# E.g.
|
54
|
+
# [a-z]{2,}
|
55
|
+
# ^^^^^^^^^ expression
|
56
|
+
# ^^^^ quantifier
|
57
|
+
# ^^^^^ body
|
58
|
+
# ^ begin
|
59
|
+
# ^ end
|
60
|
+
#
|
61
|
+
# Please open issue if you need other locations
|
62
|
+
def loc
|
63
|
+
@loc ||= begin
|
64
|
+
Map.new(expression, **build_location)
|
65
|
+
end
|
66
|
+
end
|
67
|
+
|
68
|
+
private
|
69
|
+
|
70
|
+
def build_location
|
71
|
+
return { body: expression } unless (q = quantifier)
|
72
|
+
|
73
|
+
body = expression.adjust(end_pos: -q.text.length)
|
74
|
+
q_loc = expression.with(begin_pos: body.end_pos)
|
75
|
+
{ body: body, quantifier: q_loc }
|
76
|
+
end
|
77
|
+
end
|
78
|
+
|
79
|
+
# Provide `CharacterSet` with `begin` and `end` locations.
|
80
|
+
module CharacterSet
|
81
|
+
def build_location
|
82
|
+
h = super
|
83
|
+
body = h[:body]
|
84
|
+
h.merge!(
|
85
|
+
begin_l: body.with(end_pos: body.begin_pos + 1),
|
86
|
+
end_l: body.with(begin_pos: body.end_pos - 1)
|
87
|
+
)
|
88
|
+
end
|
89
|
+
end
|
90
|
+
end
|
91
|
+
::Regexp::Expression::Base.include Expression::Base
|
92
|
+
::Regexp::Expression::CharacterSet.include Expression::CharacterSet
|
93
|
+
end
|
94
|
+
end
|
95
|
+
end
|