rubocop 0.70.0 → 1.6.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (751) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +64 -40
  4. data/config/default.yml +1316 -986
  5. data/config/obsoletion.yml +196 -0
  6. data/exe/rubocop +1 -1
  7. data/lib/rubocop/ast_aliases.rb +8 -0
  8. data/lib/rubocop/cached_data.rb +4 -2
  9. data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
  10. data/lib/rubocop/cli/command/base.rb +35 -0
  11. data/lib/rubocop/cli/command/execute_runner.rb +100 -0
  12. data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
  13. data/lib/rubocop/cli/command/show_cops.rb +77 -0
  14. data/lib/rubocop/cli/command/suggest_extensions.rb +80 -0
  15. data/lib/rubocop/cli/command/version.rb +18 -0
  16. data/lib/rubocop/cli/command.rb +22 -0
  17. data/lib/rubocop/cli/environment.rb +22 -0
  18. data/lib/rubocop/cli.rb +22 -230
  19. data/lib/rubocop/comment_config.rb +29 -16
  20. data/lib/rubocop/config.rb +80 -509
  21. data/lib/rubocop/config_loader.rb +122 -91
  22. data/lib/rubocop/config_loader_resolver.rb +65 -24
  23. data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
  24. data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
  25. data/lib/rubocop/config_obsoletion/cop_rule.rb +34 -0
  26. data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
  27. data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
  28. data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
  29. data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
  30. data/lib/rubocop/config_obsoletion/rule.rb +41 -0
  31. data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
  32. data/lib/rubocop/config_obsoletion.rb +101 -0
  33. data/lib/rubocop/config_regeneration.rb +33 -0
  34. data/lib/rubocop/config_store.rb +19 -5
  35. data/lib/rubocop/config_validator.rb +239 -0
  36. data/lib/rubocop/cop/autocorrect_logic.rb +83 -6
  37. data/lib/rubocop/cop/badge.rb +15 -30
  38. data/lib/rubocop/cop/base.rb +447 -0
  39. data/lib/rubocop/cop/bundler/duplicated_gem.rb +28 -4
  40. data/lib/rubocop/cop/bundler/gem_comment.rb +83 -9
  41. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +15 -23
  42. data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
  43. data/lib/rubocop/cop/commissioner.rb +102 -70
  44. data/lib/rubocop/cop/cop.rb +102 -186
  45. data/lib/rubocop/cop/corrector.rb +71 -122
  46. data/lib/rubocop/cop/correctors/alignment_corrector.rb +45 -23
  47. data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
  48. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
  49. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
  50. data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
  51. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +36 -5
  52. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
  53. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +9 -14
  54. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
  55. data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
  56. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
  57. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
  58. data/lib/rubocop/cop/documentation.rb +22 -0
  59. data/lib/rubocop/cop/force.rb +2 -1
  60. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -5
  61. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -5
  62. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +45 -20
  63. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
  64. data/lib/rubocop/cop/generator/configuration_injector.rb +12 -7
  65. data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
  66. data/lib/rubocop/cop/generator.rb +15 -21
  67. data/lib/rubocop/cop/ignored_node.rb +1 -3
  68. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
  69. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +3 -3
  70. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +13 -15
  71. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +11 -10
  72. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +12 -8
  73. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +10 -10
  74. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +5 -5
  75. data/lib/rubocop/cop/internal_affairs.rb +1 -0
  76. data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
  77. data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
  78. data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +11 -2
  79. data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
  80. data/lib/rubocop/cop/layout/block_alignment.rb +30 -27
  81. data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
  82. data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
  83. data/lib/rubocop/cop/layout/class_structure.rb +53 -69
  84. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
  85. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  86. data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
  87. data/lib/rubocop/cop/layout/condition_position.rb +16 -8
  88. data/lib/rubocop/cop/layout/def_end_alignment.rb +7 -4
  89. data/lib/rubocop/cop/layout/dot_position.rb +21 -20
  90. data/lib/rubocop/cop/layout/else_alignment.rb +23 -2
  91. data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
  92. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +43 -25
  93. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +15 -15
  94. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
  95. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +100 -31
  96. data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
  97. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +21 -20
  98. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +13 -9
  99. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
  100. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
  101. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -5
  102. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +4 -7
  103. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
  104. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
  105. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
  106. data/lib/rubocop/cop/layout/end_alignment.rb +17 -22
  107. data/lib/rubocop/cop/layout/end_of_line.rb +16 -11
  108. data/lib/rubocop/cop/layout/extra_spacing.rb +34 -94
  109. data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +28 -15
  110. data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
  111. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
  112. data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
  113. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
  114. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
  115. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
  116. data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +8 -4
  117. data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +41 -37
  118. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +30 -17
  119. data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
  120. data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
  121. data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
  122. data/lib/rubocop/cop/layout/indentation_width.rb +29 -13
  123. data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
  124. data/lib/rubocop/cop/layout/leading_comment_space.rb +72 -11
  125. data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
  126. data/lib/rubocop/cop/{metrics → layout}/line_length.rb +92 -130
  127. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
  128. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
  129. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
  130. data/lib/rubocop/cop/layout/multiline_block_layout.rb +70 -27
  131. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
  132. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
  133. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -11
  134. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
  135. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +8 -4
  136. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
  137. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
  138. data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
  139. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +59 -26
  140. data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
  141. data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
  142. data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
  143. data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
  144. data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
  145. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -42
  146. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
  147. data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
  148. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
  149. data/lib/rubocop/cop/layout/space_around_operators.rb +127 -44
  150. data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
  151. data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
  152. data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
  153. data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
  154. data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
  155. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
  156. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
  157. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
  158. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +37 -21
  159. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
  160. data/lib/rubocop/cop/layout/space_inside_parens.rb +43 -26
  161. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
  162. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
  163. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
  164. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -41
  165. data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
  166. data/lib/rubocop/cop/layout/trailing_whitespace.rb +56 -16
  167. data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
  168. data/lib/rubocop/cop/legacy/corrector.rb +29 -0
  169. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
  170. data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
  171. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -6
  172. data/lib/rubocop/cop/lint/assignment_in_condition.rb +19 -6
  173. data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -11
  174. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
  175. data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
  176. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  177. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +98 -0
  178. data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
  179. data/lib/rubocop/cop/lint/debugger.rb +18 -26
  180. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
  181. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
  182. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
  183. data/lib/rubocop/cop/lint/duplicate_branch.rb +93 -0
  184. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +3 -13
  185. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
  186. data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
  187. data/lib/rubocop/cop/lint/duplicate_methods.rb +10 -13
  188. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
  189. data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
  190. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
  191. data/lib/rubocop/cop/lint/each_with_object_argument.rb +4 -3
  192. data/lib/rubocop/cop/lint/else_layout.rb +30 -4
  193. data/lib/rubocop/cop/lint/empty_block.rb +82 -0
  194. data/lib/rubocop/cop/lint/empty_class.rb +93 -0
  195. data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
  196. data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
  197. data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
  198. data/lib/rubocop/cop/lint/empty_file.rb +50 -0
  199. data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -9
  200. data/lib/rubocop/cop/lint/empty_when.rb +31 -8
  201. data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
  202. data/lib/rubocop/cop/lint/erb_new_arguments.rb +66 -8
  203. data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
  204. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  205. data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
  206. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +52 -41
  207. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
  208. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
  209. data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
  210. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
  211. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +12 -15
  212. data/lib/rubocop/cop/lint/inherit_exception.rb +13 -8
  213. data/lib/rubocop/cop/lint/interpolation_check.rb +26 -5
  214. data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
  215. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +46 -15
  216. data/lib/rubocop/cop/lint/loop.rb +30 -7
  217. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
  218. data/lib/rubocop/cop/lint/missing_super.rb +102 -0
  219. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
  220. data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +11 -12
  221. data/lib/rubocop/cop/lint/nested_method_definition.rb +20 -26
  222. data/lib/rubocop/cop/lint/nested_percent_literal.rb +16 -2
  223. data/lib/rubocop/cop/lint/next_without_accumulator.rb +2 -2
  224. data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
  225. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
  226. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +10 -10
  227. data/lib/rubocop/cop/lint/number_conversion.rb +54 -23
  228. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
  229. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +98 -0
  230. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
  231. data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
  232. data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
  233. data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
  234. data/lib/rubocop/cop/lint/rand_one.rb +4 -3
  235. data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
  236. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +128 -0
  237. data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +9 -11
  238. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
  239. data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +25 -16
  240. data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +11 -18
  241. data/lib/rubocop/cop/lint/redundant_with_index.rb +13 -16
  242. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -16
  243. data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
  244. data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
  245. data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
  246. data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
  247. data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
  248. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +11 -15
  249. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
  250. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +11 -3
  251. data/lib/rubocop/cop/lint/script_permission.rb +10 -7
  252. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  253. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +87 -0
  254. data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
  255. data/lib/rubocop/cop/lint/shadowed_exception.rb +12 -13
  256. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +20 -7
  257. data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
  258. data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
  259. data/lib/rubocop/cop/lint/syntax.rb +11 -28
  260. data/lib/rubocop/cop/lint/to_enum_arguments.rb +86 -0
  261. data/lib/rubocop/cop/lint/to_json.rb +21 -12
  262. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  263. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
  264. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
  265. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
  266. data/lib/rubocop/cop/lint/unified_integer.rb +5 -9
  267. data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +199 -0
  268. data/lib/rubocop/cop/lint/unreachable_code.rb +3 -3
  269. data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
  270. data/lib/rubocop/cop/lint/unused_block_argument.rb +30 -9
  271. data/lib/rubocop/cop/lint/unused_method_argument.rb +63 -14
  272. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +5 -3
  273. data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
  274. data/lib/rubocop/cop/lint/useless_access_modifier.rb +95 -47
  275. data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
  276. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
  277. data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
  278. data/lib/rubocop/cop/lint/useless_setter_call.rb +15 -8
  279. data/lib/rubocop/cop/lint/useless_times.rb +106 -0
  280. data/lib/rubocop/cop/lint/void.rb +10 -33
  281. data/lib/rubocop/cop/message_annotator.rb +16 -7
  282. data/lib/rubocop/cop/metrics/abc_size.rb +27 -3
  283. data/lib/rubocop/cop/metrics/block_length.rb +40 -10
  284. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  285. data/lib/rubocop/cop/metrics/class_length.rb +39 -8
  286. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
  287. data/lib/rubocop/cop/metrics/method_length.rb +33 -5
  288. data/lib/rubocop/cop/metrics/module_length.rb +27 -4
  289. data/lib/rubocop/cop/metrics/parameter_lists.rb +71 -9
  290. data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
  291. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +95 -14
  292. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
  293. data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
  294. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +146 -0
  295. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
  296. data/lib/rubocop/cop/migration/department_name.rb +83 -0
  297. data/lib/rubocop/cop/mixin/alignment.rb +8 -6
  298. data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
  299. data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
  300. data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
  301. data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
  302. data/lib/rubocop/cop/mixin/check_line_breakable.rb +20 -17
  303. data/lib/rubocop/cop/mixin/code_length.rb +26 -5
  304. data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
  305. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
  306. data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
  307. data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
  308. data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
  309. data/lib/rubocop/cop/mixin/def_node.rb +1 -1
  310. data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -4
  311. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
  312. data/lib/rubocop/cop/mixin/empty_parameter.rb +4 -2
  313. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
  314. data/lib/rubocop/cop/mixin/enforce_superclass.rb +15 -5
  315. data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
  316. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -6
  317. data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +5 -1
  318. data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
  319. data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
  320. data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
  321. data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
  322. data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
  323. data/lib/rubocop/cop/mixin/method_complexity.rb +24 -4
  324. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
  325. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +5 -5
  326. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
  327. data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
  328. data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
  329. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
  330. data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
  331. data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
  332. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +88 -1
  333. data/lib/rubocop/cop/mixin/range_help.rb +19 -5
  334. data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
  335. data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
  336. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
  337. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
  338. data/lib/rubocop/cop/mixin/statement_modifier.rb +51 -23
  339. data/lib/rubocop/cop/mixin/string_help.rb +4 -1
  340. data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
  341. data/lib/rubocop/cop/mixin/surrounding_space.rb +19 -33
  342. data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
  343. data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
  344. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
  345. data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
  346. data/lib/rubocop/cop/mixin/visibility_help.rb +36 -0
  347. data/lib/rubocop/cop/naming/accessor_method_name.rb +19 -3
  348. data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
  349. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +16 -6
  350. data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
  351. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
  352. data/lib/rubocop/cop/naming/constant_name.rb +5 -4
  353. data/lib/rubocop/cop/naming/file_name.rb +40 -22
  354. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +12 -6
  355. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
  356. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +69 -20
  357. data/lib/rubocop/cop/naming/method_name.rb +39 -2
  358. data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
  359. data/lib/rubocop/cop/naming/predicate_name.rb +12 -15
  360. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +27 -28
  361. data/lib/rubocop/cop/naming/variable_name.rb +2 -1
  362. data/lib/rubocop/cop/naming/variable_number.rb +101 -9
  363. data/lib/rubocop/cop/offense.rb +62 -12
  364. data/lib/rubocop/cop/registry.rb +97 -11
  365. data/lib/rubocop/cop/security/eval.rb +4 -3
  366. data/lib/rubocop/cop/security/json_load.rb +8 -9
  367. data/lib/rubocop/cop/security/marshal_load.rb +4 -5
  368. data/lib/rubocop/cop/security/open.rb +15 -12
  369. data/lib/rubocop/cop/security/yaml_load.rb +8 -7
  370. data/lib/rubocop/cop/severity.rb +1 -11
  371. data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -12
  372. data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
  373. data/lib/rubocop/cop/style/alias.rb +45 -38
  374. data/lib/rubocop/cop/style/and_or.rb +27 -22
  375. data/lib/rubocop/cop/style/arguments_forwarding.rb +142 -0
  376. data/lib/rubocop/cop/style/array_coercion.rb +67 -0
  377. data/lib/rubocop/cop/style/array_join.rb +8 -9
  378. data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
  379. data/lib/rubocop/cop/style/attr.rb +22 -13
  380. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
  381. data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
  382. data/lib/rubocop/cop/style/begin_block.rb +2 -2
  383. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +137 -0
  384. data/lib/rubocop/cop/style/block_comments.rb +14 -18
  385. data/lib/rubocop/cop/style/block_delimiters.rb +79 -27
  386. data/lib/rubocop/cop/style/case_equality.rb +54 -4
  387. data/lib/rubocop/cop/style/case_like_if.rb +248 -0
  388. data/lib/rubocop/cop/style/character_literal.rb +10 -11
  389. data/lib/rubocop/cop/style/class_and_module_children.rb +26 -16
  390. data/lib/rubocop/cop/style/class_check.rb +6 -11
  391. data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
  392. data/lib/rubocop/cop/style/class_methods.rb +7 -11
  393. data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
  394. data/lib/rubocop/cop/style/class_vars.rb +23 -7
  395. data/lib/rubocop/cop/style/collection_compact.rb +91 -0
  396. data/lib/rubocop/cop/style/collection_methods.rb +13 -17
  397. data/lib/rubocop/cop/style/colon_method_call.rb +9 -10
  398. data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
  399. data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
  400. data/lib/rubocop/cop/style/command_literal.rb +24 -25
  401. data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
  402. data/lib/rubocop/cop/style/commented_keyword.rb +23 -35
  403. data/lib/rubocop/cop/style/conditional_assignment.rb +77 -82
  404. data/lib/rubocop/cop/style/constant_visibility.rb +17 -5
  405. data/lib/rubocop/cop/style/copyright.rb +27 -23
  406. data/lib/rubocop/cop/style/date_time.rb +17 -6
  407. data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
  408. data/lib/rubocop/cop/style/dir.rb +11 -13
  409. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
  410. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
  411. data/lib/rubocop/cop/style/documentation.rb +62 -15
  412. data/lib/rubocop/cop/style/documentation_method.rb +46 -2
  413. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
  414. data/lib/rubocop/cop/style/double_negation.rb +49 -6
  415. data/lib/rubocop/cop/style/each_for_simple_loop.rb +6 -9
  416. data/lib/rubocop/cop/style/each_with_object.rb +17 -20
  417. data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
  418. data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
  419. data/lib/rubocop/cop/style/empty_else.rb +17 -19
  420. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
  421. data/lib/rubocop/cop/style/empty_literal.rb +26 -27
  422. data/lib/rubocop/cop/style/empty_method.rb +13 -20
  423. data/lib/rubocop/cop/style/encoding.rb +6 -10
  424. data/lib/rubocop/cop/style/end_block.rb +6 -2
  425. data/lib/rubocop/cop/style/eval_with_location.rb +10 -10
  426. data/lib/rubocop/cop/style/even_odd.rb +10 -13
  427. data/lib/rubocop/cop/style/expand_path_arguments.rb +30 -29
  428. data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
  429. data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
  430. data/lib/rubocop/cop/style/float_division.rb +136 -0
  431. data/lib/rubocop/cop/style/for.rb +7 -15
  432. data/lib/rubocop/cop/style/format_string.rb +48 -37
  433. data/lib/rubocop/cop/style/format_string_token.rb +70 -77
  434. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +113 -65
  435. data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
  436. data/lib/rubocop/cop/style/global_vars.rb +2 -2
  437. data/lib/rubocop/cop/style/guard_clause.rb +69 -16
  438. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
  439. data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
  440. data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
  441. data/lib/rubocop/cop/style/hash_syntax.rb +32 -23
  442. data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
  443. data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
  444. data/lib/rubocop/cop/style/identical_conditional_branches.rb +9 -4
  445. data/lib/rubocop/cop/style/if_inside_else.rb +80 -2
  446. data/lib/rubocop/cop/style/if_unless_modifier.rb +124 -44
  447. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
  448. data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
  449. data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
  450. data/lib/rubocop/cop/style/infinite_loop.rb +33 -28
  451. data/lib/rubocop/cop/style/inline_comment.rb +4 -4
  452. data/lib/rubocop/cop/style/inverse_methods.rb +39 -39
  453. data/lib/rubocop/cop/style/ip_addresses.rb +6 -6
  454. data/lib/rubocop/cop/style/keyword_parameters_order.rb +65 -0
  455. data/lib/rubocop/cop/style/lambda.rb +9 -15
  456. data/lib/rubocop/cop/style/lambda_call.rb +17 -34
  457. data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
  458. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +169 -0
  459. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
  460. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -226
  461. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +18 -10
  462. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
  463. data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
  464. data/lib/rubocop/cop/style/min_max.rb +9 -13
  465. data/lib/rubocop/cop/style/missing_else.rb +11 -21
  466. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
  467. data/lib/rubocop/cop/style/mixin_grouping.rb +26 -33
  468. data/lib/rubocop/cop/style/mixin_usage.rb +12 -21
  469. data/lib/rubocop/cop/style/module_function.rb +64 -21
  470. data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
  471. data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
  472. data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
  473. data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
  474. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  475. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
  476. data/lib/rubocop/cop/style/multiline_when_then.rb +73 -0
  477. data/lib/rubocop/cop/style/multiple_comparison.rb +56 -8
  478. data/lib/rubocop/cop/style/mutable_constant.rb +30 -29
  479. data/lib/rubocop/cop/style/negated_if.rb +9 -9
  480. data/lib/rubocop/cop/style/negated_if_else_condition.rb +106 -0
  481. data/lib/rubocop/cop/style/negated_unless.rb +9 -9
  482. data/lib/rubocop/cop/style/negated_while.rb +7 -15
  483. data/lib/rubocop/cop/style/nested_modifier.rb +31 -16
  484. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
  485. data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
  486. data/lib/rubocop/cop/style/next.rb +19 -23
  487. data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
  488. data/lib/rubocop/cop/style/nil_lambda.rb +52 -0
  489. data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
  490. data/lib/rubocop/cop/style/not.rb +20 -26
  491. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
  492. data/lib/rubocop/cop/style/numeric_literals.rb +21 -14
  493. data/lib/rubocop/cop/style/numeric_predicate.rb +14 -19
  494. data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
  495. data/lib/rubocop/cop/style/option_hash.rb +5 -5
  496. data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
  497. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
  498. data/lib/rubocop/cop/style/or_assignment.rb +24 -15
  499. data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
  500. data/lib/rubocop/cop/style/parentheses_around_condition.rb +21 -7
  501. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
  502. data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
  503. data/lib/rubocop/cop/style/perl_backrefs.rb +91 -16
  504. data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
  505. data/lib/rubocop/cop/style/proc.rb +7 -7
  506. data/lib/rubocop/cop/style/raise_args.rb +33 -30
  507. data/lib/rubocop/cop/style/random_with_offset.rb +29 -34
  508. data/lib/rubocop/cop/style/redundant_argument.rb +88 -0
  509. data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
  510. data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
  511. data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
  512. data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +43 -15
  513. data/lib/rubocop/cop/style/redundant_conditional.rb +11 -11
  514. data/lib/rubocop/cop/style/redundant_exception.rb +21 -15
  515. data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
  516. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
  517. data/lib/rubocop/cop/style/redundant_freeze.rb +7 -9
  518. data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
  519. data/lib/rubocop/cop/style/redundant_parentheses.rb +53 -32
  520. data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
  521. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
  522. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +121 -0
  523. data/lib/rubocop/cop/style/redundant_return.rb +52 -44
  524. data/lib/rubocop/cop/style/redundant_self.rb +36 -21
  525. data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
  526. data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
  527. data/lib/rubocop/cop/style/redundant_sort_by.rb +6 -10
  528. data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
  529. data/lib/rubocop/cop/style/rescue_modifier.rb +53 -9
  530. data/lib/rubocop/cop/style/rescue_standard_error.rb +23 -19
  531. data/lib/rubocop/cop/style/return_nil.rb +7 -7
  532. data/lib/rubocop/cop/style/safe_navigation.rb +54 -20
  533. data/lib/rubocop/cop/style/sample.rb +14 -16
  534. data/lib/rubocop/cop/style/self_assignment.rb +26 -22
  535. data/lib/rubocop/cop/style/semicolon.rb +23 -12
  536. data/lib/rubocop/cop/style/send.rb +4 -5
  537. data/lib/rubocop/cop/style/signal_exception.rb +26 -20
  538. data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
  539. data/lib/rubocop/cop/style/single_line_block_params.rb +32 -7
  540. data/lib/rubocop/cop/style/single_line_methods.rb +26 -18
  541. data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
  542. data/lib/rubocop/cop/style/sole_nested_conditional.rb +128 -0
  543. data/lib/rubocop/cop/style/special_global_vars.rb +18 -41
  544. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
  545. data/lib/rubocop/cop/style/static_class.rb +97 -0
  546. data/lib/rubocop/cop/style/stderr_puts.rb +7 -8
  547. data/lib/rubocop/cop/style/string_concatenation.rb +143 -0
  548. data/lib/rubocop/cop/style/string_hash_keys.rb +8 -9
  549. data/lib/rubocop/cop/style/string_literals.rb +14 -8
  550. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +4 -3
  551. data/lib/rubocop/cop/style/string_methods.rb +7 -17
  552. data/lib/rubocop/cop/style/strip.rb +10 -15
  553. data/lib/rubocop/cop/style/struct_inheritance.rb +23 -5
  554. data/lib/rubocop/cop/style/swap_values.rb +108 -0
  555. data/lib/rubocop/cop/style/symbol_array.rb +13 -24
  556. data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
  557. data/lib/rubocop/cop/style/symbol_proc.rb +22 -24
  558. data/lib/rubocop/cop/style/ternary_parentheses.rb +57 -31
  559. data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
  560. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
  561. data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
  562. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +39 -25
  563. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
  564. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
  565. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
  566. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -34
  567. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +19 -22
  568. data/lib/rubocop/cop/style/trivial_accessors.rb +36 -39
  569. data/lib/rubocop/cop/style/unless_else.rb +6 -9
  570. data/lib/rubocop/cop/style/unpack_first.rb +5 -12
  571. data/lib/rubocop/cop/style/variable_interpolation.rb +11 -24
  572. data/lib/rubocop/cop/style/when_then.rb +5 -7
  573. data/lib/rubocop/cop/style/while_until_do.rb +6 -16
  574. data/lib/rubocop/cop/style/while_until_modifier.rb +17 -22
  575. data/lib/rubocop/cop/style/word_array.rb +8 -26
  576. data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
  577. data/lib/rubocop/cop/style/zero_length_predicate.rb +25 -27
  578. data/lib/rubocop/cop/team.rb +159 -87
  579. data/lib/rubocop/cop/util.rb +36 -19
  580. data/lib/rubocop/cop/utils/format_string.rb +135 -0
  581. data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
  582. data/lib/rubocop/cop/variable_force/branch.rb +2 -7
  583. data/lib/rubocop/cop/variable_force/scope.rb +2 -1
  584. data/lib/rubocop/cop/variable_force/variable.rb +20 -8
  585. data/lib/rubocop/cop/variable_force.rb +16 -17
  586. data/lib/rubocop/cops_documentation_generator.rb +284 -0
  587. data/lib/rubocop/core_ext/hash.rb +20 -0
  588. data/lib/rubocop/core_ext/string.rb +2 -26
  589. data/lib/rubocop/directive_comment.rb +32 -0
  590. data/lib/rubocop/error.rb +24 -0
  591. data/lib/rubocop/ext/processed_source.rb +18 -0
  592. data/lib/rubocop/ext/regexp_node.rb +87 -0
  593. data/lib/rubocop/ext/regexp_parser.rb +95 -0
  594. data/lib/rubocop/file_finder.rb +13 -12
  595. data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
  596. data/lib/rubocop/formatter/base_formatter.rb +0 -4
  597. data/lib/rubocop/formatter/clang_style_formatter.rb +8 -5
  598. data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -22
  599. data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
  600. data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
  601. data/lib/rubocop/formatter/formatter_set.rb +20 -19
  602. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +47 -0
  603. data/lib/rubocop/formatter/html_formatter.rb +2 -0
  604. data/lib/rubocop/formatter/json_formatter.rb +6 -5
  605. data/lib/rubocop/formatter/junit_formatter.rb +84 -0
  606. data/lib/rubocop/formatter/offense_count_formatter.rb +1 -1
  607. data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
  608. data/lib/rubocop/formatter/progress_formatter.rb +2 -1
  609. data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
  610. data/lib/rubocop/formatter/simple_text_formatter.rb +54 -10
  611. data/lib/rubocop/formatter/tap_formatter.rb +19 -6
  612. data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -1
  613. data/lib/rubocop/lockfile.rb +40 -0
  614. data/lib/rubocop/magic_comment.rb +7 -3
  615. data/lib/rubocop/name_similarity.rb +18 -10
  616. data/lib/rubocop/options.rb +131 -60
  617. data/lib/rubocop/path_util.rb +19 -19
  618. data/lib/rubocop/platform.rb +1 -1
  619. data/lib/rubocop/rake_task.rb +10 -11
  620. data/lib/rubocop/remote_config.rb +2 -3
  621. data/lib/rubocop/result_cache.rb +69 -27
  622. data/lib/rubocop/rspec/cop_helper.rb +11 -32
  623. data/lib/rubocop/rspec/expect_offense.rb +107 -25
  624. data/lib/rubocop/rspec/shared_contexts.rb +89 -40
  625. data/lib/rubocop/rspec/support.rb +0 -1
  626. data/lib/rubocop/runner.rb +127 -73
  627. data/lib/rubocop/string_interpreter.rb +3 -0
  628. data/lib/rubocop/target_finder.rb +61 -48
  629. data/lib/rubocop/target_ruby.rb +224 -0
  630. data/lib/rubocop/version.rb +65 -7
  631. data/lib/rubocop/yaml_duplication_checker.rb +9 -2
  632. data/lib/rubocop.rb +172 -145
  633. metadata +230 -184
  634. data/bin/console +0 -9
  635. data/bin/setup +0 -7
  636. data/lib/rubocop/ast/builder.rb +0 -79
  637. data/lib/rubocop/ast/node/alias_node.rb +0 -24
  638. data/lib/rubocop/ast/node/and_node.rb +0 -29
  639. data/lib/rubocop/ast/node/args_node.rb +0 -29
  640. data/lib/rubocop/ast/node/array_node.rb +0 -57
  641. data/lib/rubocop/ast/node/block_node.rb +0 -115
  642. data/lib/rubocop/ast/node/break_node.rb +0 -17
  643. data/lib/rubocop/ast/node/case_node.rb +0 -56
  644. data/lib/rubocop/ast/node/class_node.rb +0 -31
  645. data/lib/rubocop/ast/node/def_node.rb +0 -71
  646. data/lib/rubocop/ast/node/defined_node.rb +0 -17
  647. data/lib/rubocop/ast/node/ensure_node.rb +0 -17
  648. data/lib/rubocop/ast/node/for_node.rb +0 -53
  649. data/lib/rubocop/ast/node/hash_node.rb +0 -109
  650. data/lib/rubocop/ast/node/if_node.rb +0 -175
  651. data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
  652. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
  653. data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
  654. data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
  655. data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
  656. data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
  657. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
  658. data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
  659. data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
  660. data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
  661. data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
  662. data/lib/rubocop/ast/node/module_node.rb +0 -24
  663. data/lib/rubocop/ast/node/or_node.rb +0 -29
  664. data/lib/rubocop/ast/node/pair_node.rb +0 -63
  665. data/lib/rubocop/ast/node/range_node.rb +0 -18
  666. data/lib/rubocop/ast/node/regexp_node.rb +0 -35
  667. data/lib/rubocop/ast/node/resbody_node.rb +0 -29
  668. data/lib/rubocop/ast/node/retry_node.rb +0 -17
  669. data/lib/rubocop/ast/node/self_class_node.rb +0 -24
  670. data/lib/rubocop/ast/node/send_node.rb +0 -13
  671. data/lib/rubocop/ast/node/str_node.rb +0 -16
  672. data/lib/rubocop/ast/node/super_node.rb +0 -21
  673. data/lib/rubocop/ast/node/symbol_node.rb +0 -12
  674. data/lib/rubocop/ast/node/until_node.rb +0 -35
  675. data/lib/rubocop/ast/node/when_node.rb +0 -53
  676. data/lib/rubocop/ast/node/while_node.rb +0 -35
  677. data/lib/rubocop/ast/node/yield_node.rb +0 -21
  678. data/lib/rubocop/ast/node.rb +0 -646
  679. data/lib/rubocop/ast/sexp.rb +0 -16
  680. data/lib/rubocop/ast/traversal.rb +0 -183
  681. data/lib/rubocop/cop/layout/align_array.rb +0 -39
  682. data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
  683. data/lib/rubocop/cop/layout/tab.rb +0 -87
  684. data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
  685. data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb +0 -116
  686. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  687. data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
  688. data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
  689. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  690. data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
  691. data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
  692. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
  693. data/lib/rubocop/cop/rails/action_filter.rb +0 -117
  694. data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
  695. data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
  696. data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
  697. data/lib/rubocop/cop/rails/application_job.rb +0 -40
  698. data/lib/rubocop/cop/rails/application_record.rb +0 -40
  699. data/lib/rubocop/cop/rails/assert_not.rb +0 -44
  700. data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
  701. data/lib/rubocop/cop/rails/blank.rb +0 -164
  702. data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
  703. data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
  704. data/lib/rubocop/cop/rails/date.rb +0 -161
  705. data/lib/rubocop/cop/rails/delegate.rb +0 -132
  706. data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
  707. data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
  708. data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
  709. data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
  710. data/lib/rubocop/cop/rails/exit.rb +0 -67
  711. data/lib/rubocop/cop/rails/file_path.rb +0 -108
  712. data/lib/rubocop/cop/rails/find_by.rb +0 -55
  713. data/lib/rubocop/cop/rails/find_each.rb +0 -51
  714. data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
  715. data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
  716. data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
  717. data/lib/rubocop/cop/rails/http_status.rb +0 -179
  718. data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
  719. data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
  720. data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
  721. data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
  722. data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
  723. data/lib/rubocop/cop/rails/output.rb +0 -49
  724. data/lib/rubocop/cop/rails/output_safety.rb +0 -99
  725. data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
  726. data/lib/rubocop/cop/rails/presence.rb +0 -124
  727. data/lib/rubocop/cop/rails/present.rb +0 -153
  728. data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
  729. data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
  730. data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
  731. data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
  732. data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
  733. data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
  734. data/lib/rubocop/cop/rails/request_referer.rb +0 -56
  735. data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
  736. data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
  737. data/lib/rubocop/cop/rails/save_bang.rb +0 -316
  738. data/lib/rubocop/cop/rails/scope_args.rb +0 -29
  739. data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
  740. data/lib/rubocop/cop/rails/time_zone.rb +0 -238
  741. data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
  742. data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
  743. data/lib/rubocop/cop/rails/validation.rb +0 -109
  744. data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -190
  745. data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
  746. data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
  747. data/lib/rubocop/node_pattern.rb +0 -720
  748. data/lib/rubocop/processed_source.rb +0 -208
  749. data/lib/rubocop/rspec/shared_examples.rb +0 -59
  750. data/lib/rubocop/string_util.rb +0 -14
  751. data/lib/rubocop/token.rb +0 -114
@@ -1,646 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # `RuboCop::AST::Node` is a subclass of `Parser::AST::Node`. It provides
6
- # access to parent nodes and an object-oriented way to traverse an AST with
7
- # the power of `Enumerable`.
8
- #
9
- # It has predicate methods for every node type, like this:
10
- #
11
- # @example
12
- # node.send_type? # Equivalent to: `node.type == :send`
13
- # node.op_asgn_type? # Equivalent to: `node.type == :op_asgn`
14
- #
15
- # # Non-word characters (other than a-zA-Z0-9_) in type names are omitted.
16
- # node.defined_type? # Equivalent to: `node.type == :defined?`
17
- #
18
- # # Find the first lvar node under the receiver node.
19
- # lvar_node = node.each_descendant.find(&:lvar_type?)
20
- #
21
- class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength
22
- include RuboCop::AST::Sexp
23
- extend NodePattern::Macros
24
-
25
- # <=> isn't included here, because it doesn't return a boolean.
26
- COMPARISON_OPERATORS = %i[== === != <= >= > <].freeze
27
-
28
- TRUTHY_LITERALS = %i[str dstr xstr int float sym dsym array
29
- hash regexp true irange erange complex
30
- rational regopt].freeze
31
- FALSEY_LITERALS = %i[false nil].freeze
32
- LITERALS = (TRUTHY_LITERALS + FALSEY_LITERALS).freeze
33
- COMPOSITE_LITERALS = %i[dstr xstr dsym array hash irange
34
- erange regexp].freeze
35
- BASIC_LITERALS = (LITERALS - COMPOSITE_LITERALS).freeze
36
- MUTABLE_LITERALS = %i[str dstr xstr array hash
37
- regexp irange erange].freeze
38
- IMMUTABLE_LITERALS = (LITERALS - MUTABLE_LITERALS).freeze
39
-
40
- EQUALS_ASSIGNMENTS = %i[lvasgn ivasgn cvasgn gvasgn
41
- casgn masgn].freeze
42
- SHORTHAND_ASSIGNMENTS = %i[op_asgn or_asgn and_asgn].freeze
43
- ASSIGNMENTS = (EQUALS_ASSIGNMENTS + SHORTHAND_ASSIGNMENTS).freeze
44
-
45
- BASIC_CONDITIONALS = %i[if while until].freeze
46
- CONDITIONALS = [*BASIC_CONDITIONALS, :case].freeze
47
- VARIABLES = %i[ivar gvar cvar lvar].freeze
48
- REFERENCES = %i[nth_ref back_ref].freeze
49
- KEYWORDS = %i[alias and break case class def defs defined?
50
- kwbegin do else ensure for if module next
51
- not or postexe redo rescue retry return self
52
- super zsuper then undef until when while
53
- yield].freeze
54
- OPERATOR_KEYWORDS = %i[and or].freeze
55
- SPECIAL_KEYWORDS = %w[__FILE__ __LINE__ __ENCODING__].freeze
56
-
57
- # @see https://www.rubydoc.info/gems/ast/AST/Node:initialize
58
- def initialize(type, children = [], properties = {})
59
- @mutable_attributes = {}
60
-
61
- # ::AST::Node#initialize freezes itself.
62
- super
63
-
64
- # #parent= may be invoked multiple times for a node because there are
65
- # pending nodes while constructing AST and they are replaced later.
66
- # For example, `lvar` and `send` type nodes are initially created as an
67
- # `ident` type node and fixed to the appropriate type later.
68
- # So, the #parent attribute needs to be mutable.
69
- each_child_node do |child_node|
70
- child_node.parent = self unless child_node.complete?
71
- end
72
- end
73
-
74
- Parser::Meta::NODE_TYPES.each do |node_type|
75
- method_name = "#{node_type.to_s.gsub(/\W/, '')}_type?"
76
- define_method(method_name) do
77
- type == node_type
78
- end
79
- end
80
-
81
- # Returns the parent node, or `nil` if the receiver is a root node.
82
- #
83
- # @return [Node, nil] the parent node or `nil`
84
- def parent
85
- @mutable_attributes[:parent]
86
- end
87
-
88
- def parent=(node)
89
- @mutable_attributes[:parent] = node
90
- end
91
-
92
- def complete!
93
- @mutable_attributes.freeze
94
- each_child_node(&:complete!)
95
- end
96
-
97
- def complete?
98
- @mutable_attributes.frozen?
99
- end
100
-
101
- protected :parent= # rubocop:disable Style/AccessModifierDeclarations
102
-
103
- # Override `AST::Node#updated` so that `AST::Processor` does not try to
104
- # mutate our ASTs. Since we keep references from children to parents and
105
- # not just the other way around, we cannot update an AST and share
106
- # identical subtrees. Rather, the entire AST must be copied any time any
107
- # part of it is changed.
108
- def updated(type = nil, children = nil, properties = {})
109
- properties[:location] ||= @location
110
- klass = RuboCop::AST::Builder::NODE_MAP[type || @type] || Node
111
- klass.new(type || @type, children || @children, properties)
112
- end
113
-
114
- # Returns the index of the receiver node in its siblings. (Sibling index
115
- # uses zero based numbering.)
116
- #
117
- # @return [Integer] the index of the receiver node in its siblings
118
- def sibling_index
119
- parent.children.index { |sibling| sibling.equal?(self) }
120
- end
121
-
122
- # Common destructuring method. This can be used to normalize
123
- # destructuring for different variations of the node.
124
- # Some node types override this with their own custom
125
- # destructuring method.
126
- #
127
- # @return [Array<Node>] the different parts of the ndde
128
- def node_parts
129
- to_a
130
- end
131
-
132
- # Calls the given block for each ancestor node from parent to root.
133
- # If no block is given, an `Enumerator` is returned.
134
- #
135
- # @overload each_ancestor
136
- # Yield all nodes.
137
- # @overload each_ancestor(type)
138
- # Yield only nodes matching the type.
139
- # @param [Symbol] type a node type
140
- # @overload each_ancestor(type_a, type_b, ...)
141
- # Yield only nodes matching any of the types.
142
- # @param [Symbol] type_a a node type
143
- # @param [Symbol] type_b a node type
144
- # @overload each_ancestor(types)
145
- # Yield only nodes matching any of types in the array.
146
- # @param [Array<Symbol>] types an array containing node types
147
- # @yieldparam [Node] node each ancestor node
148
- # @return [self] if a block is given
149
- # @return [Enumerator] if no block is given
150
- def each_ancestor(*types, &block)
151
- return to_enum(__method__, *types) unless block_given?
152
-
153
- visit_ancestors(types, &block)
154
-
155
- self
156
- end
157
-
158
- # Returns an array of ancestor nodes.
159
- # This is a shorthand for `node.each_ancestor.to_a`.
160
- #
161
- # @return [Array<Node>] an array of ancestor nodes
162
- def ancestors
163
- each_ancestor.to_a
164
- end
165
-
166
- # Calls the given block for each child node.
167
- # If no block is given, an `Enumerator` is returned.
168
- #
169
- # Note that this is different from `node.children.each { |child| ... }`
170
- # which yields all children including non-node elements.
171
- #
172
- # @overload each_child_node
173
- # Yield all nodes.
174
- # @overload each_child_node(type)
175
- # Yield only nodes matching the type.
176
- # @param [Symbol] type a node type
177
- # @overload each_child_node(type_a, type_b, ...)
178
- # Yield only nodes matching any of the types.
179
- # @param [Symbol] type_a a node type
180
- # @param [Symbol] type_b a node type
181
- # @overload each_child_node(types)
182
- # Yield only nodes matching any of types in the array.
183
- # @param [Array<Symbol>] types an array containing node types
184
- # @yieldparam [Node] node each child node
185
- # @return [self] if a block is given
186
- # @return [Enumerator] if no block is given
187
- def each_child_node(*types)
188
- return to_enum(__method__, *types) unless block_given?
189
-
190
- children.each do |child|
191
- next unless child.is_a?(Node)
192
-
193
- yield child if types.empty? || types.include?(child.type)
194
- end
195
-
196
- self
197
- end
198
-
199
- # Returns an array of child nodes.
200
- # This is a shorthand for `node.each_child_node.to_a`.
201
- #
202
- # @return [Array<Node>] an array of child nodes
203
- def child_nodes
204
- each_child_node.to_a
205
- end
206
-
207
- # Calls the given block for each descendant node with depth first order.
208
- # If no block is given, an `Enumerator` is returned.
209
- #
210
- # @overload each_descendant
211
- # Yield all nodes.
212
- # @overload each_descendant(type)
213
- # Yield only nodes matching the type.
214
- # @param [Symbol] type a node type
215
- # @overload each_descendant(type_a, type_b, ...)
216
- # Yield only nodes matching any of the types.
217
- # @param [Symbol] type_a a node type
218
- # @param [Symbol] type_b a node type
219
- # @overload each_descendant(types)
220
- # Yield only nodes matching any of types in the array.
221
- # @param [Array<Symbol>] types an array containing node types
222
- # @yieldparam [Node] node each descendant node
223
- # @return [self] if a block is given
224
- # @return [Enumerator] if no block is given
225
- def each_descendant(*types, &block)
226
- return to_enum(__method__, *types) unless block_given?
227
-
228
- visit_descendants(types, &block)
229
-
230
- self
231
- end
232
-
233
- # Returns an array of descendant nodes.
234
- # This is a shorthand for `node.each_descendant.to_a`.
235
- #
236
- # @return [Array<Node>] an array of descendant nodes
237
- def descendants
238
- each_descendant.to_a
239
- end
240
-
241
- # Calls the given block for the receiver and each descendant node in
242
- # depth-first order.
243
- # If no block is given, an `Enumerator` is returned.
244
- #
245
- # This method would be useful when you treat the receiver node as the root
246
- # of a tree and want to iterate over all nodes in the tree.
247
- #
248
- # @overload each_node
249
- # Yield all nodes.
250
- # @overload each_node(type)
251
- # Yield only nodes matching the type.
252
- # @param [Symbol] type a node type
253
- # @overload each_node(type_a, type_b, ...)
254
- # Yield only nodes matching any of the types.
255
- # @param [Symbol] type_a a node type
256
- # @param [Symbol] type_b a node type
257
- # @overload each_node(types)
258
- # Yield only nodes matching any of types in the array.
259
- # @param [Array<Symbol>] types an array containing node types
260
- # @yieldparam [Node] node each node
261
- # @return [self] if a block is given
262
- # @return [Enumerator] if no block is given
263
- def each_node(*types, &block)
264
- return to_enum(__method__, *types) unless block_given?
265
-
266
- yield self if types.empty? || types.include?(type)
267
-
268
- visit_descendants(types, &block)
269
-
270
- self
271
- end
272
-
273
- def source
274
- loc.expression.source
275
- end
276
-
277
- def source_range
278
- loc.expression
279
- end
280
-
281
- def first_line
282
- loc.line
283
- end
284
-
285
- def last_line
286
- loc.last_line
287
- end
288
-
289
- def line_count
290
- return 0 unless source_range
291
-
292
- source_range.last_line - source_range.first_line + 1
293
- end
294
-
295
- def nonempty_line_count
296
- source.lines.grep(/\S/).size
297
- end
298
-
299
- def source_length
300
- source_range ? source_range.size : 0
301
- end
302
-
303
- ## Destructuring
304
-
305
- def_node_matcher :receiver, <<-PATTERN
306
- {(send $_ ...) (block (send $_ ...) ...)}
307
- PATTERN
308
-
309
- # Note: for masgn, #asgn_rhs will be an array node
310
- def_node_matcher :asgn_rhs, '[assignment? (... $_)]'
311
- def_node_matcher :str_content, '(str $_)'
312
-
313
- def const_name
314
- return unless const_type?
315
-
316
- namespace, name = *self
317
- if namespace && !namespace.cbase_type?
318
- "#{namespace.const_name}::#{name}"
319
- else
320
- name.to_s
321
- end
322
- end
323
-
324
- def_node_matcher :defined_module0, <<-PATTERN
325
- {(class (const $_ $_) ...)
326
- (module (const $_ $_) ...)
327
- (casgn $_ $_ (send (const nil? {:Class :Module}) :new ...))
328
- (casgn $_ $_ (block (send (const nil? {:Class :Module}) :new ...) ...))}
329
- PATTERN
330
- # rubocop:disable Style/AccessModifierDeclarations
331
- private :defined_module0
332
- # rubocop:enable Style/AccessModifierDeclarations
333
-
334
- def defined_module
335
- namespace, name = *defined_module0
336
- s(:const, namespace, name) if name
337
- end
338
-
339
- def defined_module_name
340
- (const = defined_module) && const.const_name
341
- end
342
-
343
- ## Searching the AST
344
-
345
- def parent_module_name
346
- # what class or module is this method/constant/etc definition in?
347
- # returns nil if answer cannot be determined
348
- ancestors = each_ancestor(:class, :module, :sclass, :casgn, :block)
349
- result = ancestors.map do |ancestor|
350
- parent_module_name_part(ancestor) { |full_name| return full_name }
351
- end.compact.reverse.join('::')
352
- result.empty? ? 'Object' : result
353
- end
354
-
355
- ## Predicates
356
-
357
- def multiline?
358
- line_count > 1
359
- end
360
-
361
- def single_line?
362
- line_count == 1
363
- end
364
-
365
- def empty_source?
366
- source_length.zero?
367
- end
368
-
369
- # Some cops treat the shovel operator as a kind of assignment.
370
- def_node_matcher :assignment_or_similar?, <<-PATTERN
371
- {assignment? (send _recv :<< ...)}
372
- PATTERN
373
-
374
- def literal?
375
- LITERALS.include?(type)
376
- end
377
-
378
- def basic_literal?
379
- BASIC_LITERALS.include?(type)
380
- end
381
-
382
- def truthy_literal?
383
- TRUTHY_LITERALS.include?(type)
384
- end
385
-
386
- def falsey_literal?
387
- FALSEY_LITERALS.include?(type)
388
- end
389
-
390
- def mutable_literal?
391
- MUTABLE_LITERALS.include?(type)
392
- end
393
-
394
- def immutable_literal?
395
- IMMUTABLE_LITERALS.include?(type)
396
- end
397
-
398
- %i[literal basic_literal].each do |kind|
399
- recursive_kind = :"recursive_#{kind}?"
400
- kind_filter = :"#{kind}?"
401
- define_method(recursive_kind) do
402
- case type
403
- when :send
404
- [*COMPARISON_OPERATORS, :!, :<=>].include?(method_name) &&
405
- receiver.send(recursive_kind) &&
406
- arguments.all?(&recursive_kind)
407
- when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
408
- children.all?(&recursive_kind)
409
- else
410
- send(kind_filter)
411
- end
412
- end
413
- end
414
-
415
- def variable?
416
- VARIABLES.include?(type)
417
- end
418
-
419
- def reference?
420
- REFERENCES.include?(type)
421
- end
422
-
423
- def equals_asgn?
424
- EQUALS_ASSIGNMENTS.include?(type)
425
- end
426
-
427
- def shorthand_asgn?
428
- SHORTHAND_ASSIGNMENTS.include?(type)
429
- end
430
-
431
- def assignment?
432
- ASSIGNMENTS.include?(type)
433
- end
434
-
435
- def basic_conditional?
436
- BASIC_CONDITIONALS.include?(type)
437
- end
438
-
439
- def conditional?
440
- CONDITIONALS.include?(type)
441
- end
442
-
443
- def keyword?
444
- return true if special_keyword? || send_type? && prefix_not?
445
- return false unless KEYWORDS.include?(type)
446
-
447
- !OPERATOR_KEYWORDS.include?(type) || loc.operator.is?(type.to_s)
448
- end
449
-
450
- def special_keyword?
451
- SPECIAL_KEYWORDS.include?(source)
452
- end
453
-
454
- def operator_keyword?
455
- OPERATOR_KEYWORDS.include?(type)
456
- end
457
-
458
- def parenthesized_call?
459
- loc.respond_to?(:begin) && loc.begin && loc.begin.is?('(')
460
- end
461
-
462
- def call_type?
463
- send_type? || csend_type?
464
- end
465
-
466
- def chained?
467
- parent&.call_type? && eql?(parent.receiver)
468
- end
469
-
470
- def argument?
471
- parent&.send_type? && parent.arguments.include?(self)
472
- end
473
-
474
- def numeric_type?
475
- int_type? || float_type?
476
- end
477
-
478
- def range_type?
479
- irange_type? || erange_type?
480
- end
481
-
482
- def_node_matcher :guard_clause?, <<-PATTERN
483
- [{(send nil? {:raise :fail} ...) return break next} single_line?]
484
- PATTERN
485
-
486
- def_node_matcher :proc?, <<-PATTERN
487
- {(block (send nil? :proc) ...)
488
- (block (send (const nil? :Proc) :new) ...)
489
- (send (const nil? :Proc) :new)}
490
- PATTERN
491
-
492
- def_node_matcher :lambda?, '(block (send nil? :lambda) ...)'
493
- def_node_matcher :lambda_or_proc?, '{lambda? proc?}'
494
-
495
- def_node_matcher :class_constructor?, <<-PATTERN
496
- { (send (const nil? {:Class :Module}) :new ...)
497
- (block (send (const nil? {:Class :Module}) :new ...) ...)}
498
- PATTERN
499
-
500
- def_node_matcher :module_definition?, <<-PATTERN
501
- {class module (casgn _ _ class_constructor?)}
502
- PATTERN
503
-
504
- # Some expressions are evaluated for their value, some for their side
505
- # effects, and some for both
506
- # If we know that an expression is useful only for its side effects, that
507
- # means we can transform it in ways which preserve the side effects, but
508
- # change the return value
509
- # So, does the return value of this node matter? If we changed it to
510
- # `(...; nil)`, might that affect anything?
511
- #
512
- # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
513
- def value_used?
514
- # Be conservative and return true if we're not sure.
515
- return false if parent.nil?
516
-
517
- case parent.type
518
- when :array, :defined?, :dstr, :dsym, :eflipflop, :erange, :float,
519
- :hash, :iflipflop, :irange, :not, :pair, :regexp, :str, :sym,
520
- :when, :xstr
521
- parent.value_used?
522
- when :begin, :kwbegin
523
- begin_value_used?
524
- when :for
525
- for_value_used?
526
- when :case, :if
527
- case_if_value_used?
528
- when :while, :until, :while_post, :until_post
529
- while_until_value_used?
530
- else
531
- true
532
- end
533
- end
534
- # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
535
-
536
- # Some expressions are evaluated for their value, some for their side
537
- # effects, and some for both.
538
- # If we know that expressions are useful only for their return values,
539
- # and have no side effects, that means we can reorder them, change the
540
- # number of times they are evaluated, or replace them with other
541
- # expressions which are equivalent in value.
542
- # So, is evaluation of this node free of side effects?
543
- #
544
- def pure?
545
- # Be conservative and return false if we're not sure
546
- case type
547
- when :__FILE__, :__LINE__, :const, :cvar, :defined?, :false, :float,
548
- :gvar, :int, :ivar, :lvar, :nil, :str, :sym, :true, :regopt
549
- true
550
- when :and, :array, :begin, :case, :dstr, :dsym, :eflipflop, :ensure,
551
- :erange, :for, :hash, :if, :iflipflop, :irange, :kwbegin, :not,
552
- :or, :pair, :regexp, :until, :until_post, :when, :while,
553
- :while_post
554
- child_nodes.all?(&:pure?)
555
- else
556
- false
557
- end
558
- end
559
-
560
- protected
561
-
562
- def visit_descendants(types, &block)
563
- each_child_node do |child|
564
- yield child if types.empty? || types.include?(child.type)
565
- child.visit_descendants(types, &block)
566
- end
567
- end
568
-
569
- private
570
-
571
- def visit_ancestors(types)
572
- last_node = self
573
-
574
- while (current_node = last_node.parent)
575
- yield current_node if types.empty? ||
576
- types.include?(current_node.type)
577
- last_node = current_node
578
- end
579
- end
580
-
581
- def begin_value_used?
582
- # the last child node determines the value of the parent
583
- sibling_index == parent.children.size - 1 ? parent.value_used? : false
584
- end
585
-
586
- def for_value_used?
587
- # `for var in enum; body; end`
588
- # (for <var> <enum> <body>)
589
- sibling_index == 2 ? parent.value_used? : true
590
- end
591
-
592
- def case_if_value_used?
593
- # (case <condition> <when...>)
594
- # (if <condition> <truebranch> <falsebranch>)
595
- sibling_index.zero? ? true : parent.value_used?
596
- end
597
-
598
- def while_until_value_used?
599
- # (while <condition> <body>) -> always evaluates to `nil`
600
- sibling_index.zero?
601
- end
602
-
603
- def parent_module_name_part(node)
604
- case node.type
605
- when :class, :module, :casgn
606
- # TODO: if constant name has cbase (leading ::), then we don't need
607
- # to keep traversing up through nested classes/modules
608
- node.defined_module_name
609
- when :sclass
610
- yield parent_module_name_for_sclass(node)
611
- else # block
612
- parent_module_name_for_block(node) { yield nil }
613
- end
614
- end
615
-
616
- def parent_module_name_for_sclass(sclass_node)
617
- # TODO: look for constant definition and see if it is nested
618
- # inside a class or module
619
- subject = sclass_node.children[0]
620
-
621
- if subject.const_type?
622
- "#<Class:#{subject.const_name}>"
623
- elsif subject.self_type?
624
- "#<Class:#{sclass_node.parent_module_name}>"
625
- end
626
- end
627
-
628
- def parent_module_name_for_block(ancestor)
629
- if ancestor.method_name == :class_eval
630
- # `class_eval` with no receiver applies to whatever module or class
631
- # we are currently in
632
- return unless (receiver = ancestor.receiver)
633
-
634
- yield unless receiver.const_type?
635
- receiver.const_name
636
- elsif !new_class_or_module_block?(ancestor)
637
- yield
638
- end
639
- end
640
-
641
- def_node_matcher :new_class_or_module_block?, <<-PATTERN
642
- ^(casgn _ _ (block (send (const _ {:Class :Module}) :new) ...))
643
- PATTERN
644
- end
645
- end
646
- end
@@ -1,16 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # This module provides a shorthand method to create a {Node} like
6
- # `Parser::AST::Sexp`.
7
- #
8
- # @see https://www.rubydoc.info/gems/ast/AST/Sexp
9
- module Sexp
10
- # Creates a {Node} with type `type` and children `children`.
11
- def s(type, *children)
12
- Node.new(type, children)
13
- end
14
- end
15
- end
16
- end