rubocop 0.70.0 → 1.6.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +64 -40
- data/config/default.yml +1316 -986
- data/config/obsoletion.yml +196 -0
- data/exe/rubocop +1 -1
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +4 -2
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +100 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
- data/lib/rubocop/cli/command/show_cops.rb +77 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +80 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/cli.rb +22 -230
- data/lib/rubocop/comment_config.rb +29 -16
- data/lib/rubocop/config.rb +80 -509
- data/lib/rubocop/config_loader.rb +122 -91
- data/lib/rubocop/config_loader_resolver.rb +65 -24
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +34 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +101 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +19 -5
- data/lib/rubocop/config_validator.rb +239 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +83 -6
- data/lib/rubocop/cop/badge.rb +15 -30
- data/lib/rubocop/cop/base.rb +447 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +28 -4
- data/lib/rubocop/cop/bundler/gem_comment.rb +83 -9
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +15 -23
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
- data/lib/rubocop/cop/commissioner.rb +102 -70
- data/lib/rubocop/cop/cop.rb +102 -186
- data/lib/rubocop/cop/corrector.rb +71 -122
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +45 -23
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +36 -5
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +9 -14
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -5
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -5
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +45 -20
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
- data/lib/rubocop/cop/generator/configuration_injector.rb +12 -7
- data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
- data/lib/rubocop/cop/generator.rb +15 -21
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +3 -3
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +13 -15
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +11 -10
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +12 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +10 -10
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +5 -5
- data/lib/rubocop/cop/internal_affairs.rb +1 -0
- data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +11 -2
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +30 -27
- data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
- data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
- data/lib/rubocop/cop/layout/class_structure.rb +53 -69
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
- data/lib/rubocop/cop/layout/condition_position.rb +16 -8
- data/lib/rubocop/cop/layout/def_end_alignment.rb +7 -4
- data/lib/rubocop/cop/layout/dot_position.rb +21 -20
- data/lib/rubocop/cop/layout/else_alignment.rb +23 -2
- data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +43 -25
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +15 -15
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +100 -31
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +21 -20
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +13 -9
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +4 -7
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +17 -22
- data/lib/rubocop/cop/layout/end_of_line.rb +16 -11
- data/lib/rubocop/cop/layout/extra_spacing.rb +34 -94
- data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +28 -15
- data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
- data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +8 -4
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +41 -37
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +30 -17
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +29 -13
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +72 -11
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
- data/lib/rubocop/cop/{metrics → layout}/line_length.rb +92 -130
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +70 -27
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -11
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +8 -4
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
- data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +59 -26
- data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -42
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
- data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +127 -44
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +37 -21
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
- data/lib/rubocop/cop/layout/space_inside_parens.rb +43 -26
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -41
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +56 -16
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -6
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +19 -6
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -11
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +98 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +18 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +93 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +3 -13
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +10 -13
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +4 -3
- data/lib/rubocop/cop/lint/else_layout.rb +30 -4
- data/lib/rubocop/cop/lint/empty_block.rb +82 -0
- data/lib/rubocop/cop/lint/empty_class.rb +93 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -9
- data/lib/rubocop/cop/lint/empty_when.rb +31 -8
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +66 -8
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +52 -41
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +12 -15
- data/lib/rubocop/cop/lint/inherit_exception.rb +13 -8
- data/lib/rubocop/cop/lint/interpolation_check.rb +26 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +46 -15
- data/lib/rubocop/cop/lint/loop.rb +30 -7
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
- data/lib/rubocop/cop/lint/missing_super.rb +102 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
- data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +11 -12
- data/lib/rubocop/cop/lint/nested_method_definition.rb +20 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +16 -2
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +2 -2
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +10 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +54 -23
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +98 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
- data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
- data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
- data/lib/rubocop/cop/lint/rand_one.rb +4 -3
- data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +128 -0
- data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +9 -11
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
- data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +25 -16
- data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +11 -18
- data/lib/rubocop/cop/lint/redundant_with_index.rb +13 -16
- data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -16
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +11 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +11 -3
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +87 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +12 -13
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +20 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
- data/lib/rubocop/cop/lint/syntax.rb +11 -28
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +86 -0
- data/lib/rubocop/cop/lint/to_json.rb +21 -12
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +5 -9
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +199 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +3 -3
- data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +30 -9
- data/lib/rubocop/cop/lint/unused_method_argument.rb +63 -14
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +5 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +95 -47
- data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +15 -8
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/lint/void.rb +10 -33
- data/lib/rubocop/cop/message_annotator.rb +16 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +27 -3
- data/lib/rubocop/cop/metrics/block_length.rb +40 -10
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +39 -8
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
- data/lib/rubocop/cop/metrics/method_length.rb +33 -5
- data/lib/rubocop/cop/metrics/module_length.rb +27 -4
- data/lib/rubocop/cop/metrics/parameter_lists.rb +71 -9
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +95 -14
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +146 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +83 -0
- data/lib/rubocop/cop/mixin/alignment.rb +8 -6
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +20 -17
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -4
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +4 -2
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +15 -5
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -6
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +5 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
- data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
- data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +24 -4
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +5 -5
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +88 -1
- data/lib/rubocop/cop/mixin/range_help.rb +19 -5
- data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +51 -23
- data/lib/rubocop/cop/mixin/string_help.rb +4 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +19 -33
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +36 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +19 -3
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +16 -6
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
- data/lib/rubocop/cop/naming/constant_name.rb +5 -4
- data/lib/rubocop/cop/naming/file_name.rb +40 -22
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +12 -6
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +69 -20
- data/lib/rubocop/cop/naming/method_name.rb +39 -2
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/predicate_name.rb +12 -15
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +27 -28
- data/lib/rubocop/cop/naming/variable_name.rb +2 -1
- data/lib/rubocop/cop/naming/variable_number.rb +101 -9
- data/lib/rubocop/cop/offense.rb +62 -12
- data/lib/rubocop/cop/registry.rb +97 -11
- data/lib/rubocop/cop/security/eval.rb +4 -3
- data/lib/rubocop/cop/security/json_load.rb +8 -9
- data/lib/rubocop/cop/security/marshal_load.rb +4 -5
- data/lib/rubocop/cop/security/open.rb +15 -12
- data/lib/rubocop/cop/security/yaml_load.rb +8 -7
- data/lib/rubocop/cop/severity.rb +1 -11
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
- data/lib/rubocop/cop/style/alias.rb +45 -38
- data/lib/rubocop/cop/style/and_or.rb +27 -22
- data/lib/rubocop/cop/style/arguments_forwarding.rb +142 -0
- data/lib/rubocop/cop/style/array_coercion.rb +67 -0
- data/lib/rubocop/cop/style/array_join.rb +8 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +22 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +137 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +79 -27
- data/lib/rubocop/cop/style/case_equality.rb +54 -4
- data/lib/rubocop/cop/style/case_like_if.rb +248 -0
- data/lib/rubocop/cop/style/character_literal.rb +10 -11
- data/lib/rubocop/cop/style/class_and_module_children.rb +26 -16
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +23 -7
- data/lib/rubocop/cop/style/collection_compact.rb +91 -0
- data/lib/rubocop/cop/style/collection_methods.rb +13 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +9 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
- data/lib/rubocop/cop/style/command_literal.rb +24 -25
- data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
- data/lib/rubocop/cop/style/commented_keyword.rb +23 -35
- data/lib/rubocop/cop/style/conditional_assignment.rb +77 -82
- data/lib/rubocop/cop/style/constant_visibility.rb +17 -5
- data/lib/rubocop/cop/style/copyright.rb +27 -23
- data/lib/rubocop/cop/style/date_time.rb +17 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +11 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +62 -15
- data/lib/rubocop/cop/style/documentation_method.rb +46 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
- data/lib/rubocop/cop/style/double_negation.rb +49 -6
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +6 -9
- data/lib/rubocop/cop/style/each_with_object.rb +17 -20
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +26 -27
- data/lib/rubocop/cop/style/empty_method.rb +13 -20
- data/lib/rubocop/cop/style/encoding.rb +6 -10
- data/lib/rubocop/cop/style/end_block.rb +6 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +10 -10
- data/lib/rubocop/cop/style/even_odd.rb +10 -13
- data/lib/rubocop/cop/style/expand_path_arguments.rb +30 -29
- data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
- data/lib/rubocop/cop/style/float_division.rb +136 -0
- data/lib/rubocop/cop/style/for.rb +7 -15
- data/lib/rubocop/cop/style/format_string.rb +48 -37
- data/lib/rubocop/cop/style/format_string_token.rb +70 -77
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +113 -65
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +69 -16
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +32 -23
- data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +9 -4
- data/lib/rubocop/cop/style/if_inside_else.rb +80 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +124 -44
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -28
- data/lib/rubocop/cop/style/inline_comment.rb +4 -4
- data/lib/rubocop/cop/style/inverse_methods.rb +39 -39
- data/lib/rubocop/cop/style/ip_addresses.rb +6 -6
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +65 -0
- data/lib/rubocop/cop/style/lambda.rb +9 -15
- data/lib/rubocop/cop/style/lambda_call.rb +17 -34
- data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +169 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -226
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +18 -10
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
- data/lib/rubocop/cop/style/min_max.rb +9 -13
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +26 -33
- data/lib/rubocop/cop/style/mixin_usage.rb +12 -21
- data/lib/rubocop/cop/style/module_function.rb +64 -21
- data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
- data/lib/rubocop/cop/style/multiline_when_then.rb +73 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +56 -8
- data/lib/rubocop/cop/style/mutable_constant.rb +30 -29
- data/lib/rubocop/cop/style/negated_if.rb +9 -9
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +106 -0
- data/lib/rubocop/cop/style/negated_unless.rb +9 -9
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +31 -16
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
- data/lib/rubocop/cop/style/next.rb +19 -23
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/nil_lambda.rb +52 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
- data/lib/rubocop/cop/style/numeric_literals.rb +21 -14
- data/lib/rubocop/cop/style/numeric_predicate.rb +14 -19
- data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
- data/lib/rubocop/cop/style/option_hash.rb +5 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
- data/lib/rubocop/cop/style/or_assignment.rb +24 -15
- data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +21 -7
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +91 -16
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +7 -7
- data/lib/rubocop/cop/style/raise_args.rb +33 -30
- data/lib/rubocop/cop/style/random_with_offset.rb +29 -34
- data/lib/rubocop/cop/style/redundant_argument.rb +88 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
- data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +43 -15
- data/lib/rubocop/cop/style/redundant_conditional.rb +11 -11
- data/lib/rubocop/cop/style/redundant_exception.rb +21 -15
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +7 -9
- data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
- data/lib/rubocop/cop/style/redundant_parentheses.rb +53 -32
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +121 -0
- data/lib/rubocop/cop/style/redundant_return.rb +52 -44
- data/lib/rubocop/cop/style/redundant_self.rb +36 -21
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
- data/lib/rubocop/cop/style/redundant_sort_by.rb +6 -10
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +53 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +23 -19
- data/lib/rubocop/cop/style/return_nil.rb +7 -7
- data/lib/rubocop/cop/style/safe_navigation.rb +54 -20
- data/lib/rubocop/cop/style/sample.rb +14 -16
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +23 -12
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +26 -20
- data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +32 -7
- data/lib/rubocop/cop/style/single_line_methods.rb +26 -18
- data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +128 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +18 -41
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
- data/lib/rubocop/cop/style/static_class.rb +97 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +7 -8
- data/lib/rubocop/cop/style/string_concatenation.rb +143 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +8 -9
- data/lib/rubocop/cop/style/string_literals.rb +14 -8
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +4 -3
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +10 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +23 -5
- data/lib/rubocop/cop/style/swap_values.rb +108 -0
- data/lib/rubocop/cop/style/symbol_array.rb +13 -24
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
- data/lib/rubocop/cop/style/symbol_proc.rb +22 -24
- data/lib/rubocop/cop/style/ternary_parentheses.rb +57 -31
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +39 -25
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -34
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +19 -22
- data/lib/rubocop/cop/style/trivial_accessors.rb +36 -39
- data/lib/rubocop/cop/style/unless_else.rb +6 -9
- data/lib/rubocop/cop/style/unpack_first.rb +5 -12
- data/lib/rubocop/cop/style/variable_interpolation.rb +11 -24
- data/lib/rubocop/cop/style/when_then.rb +5 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +17 -22
- data/lib/rubocop/cop/style/word_array.rb +8 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
- data/lib/rubocop/cop/style/zero_length_predicate.rb +25 -27
- data/lib/rubocop/cop/team.rb +159 -87
- data/lib/rubocop/cop/util.rb +36 -19
- data/lib/rubocop/cop/utils/format_string.rb +135 -0
- data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
- data/lib/rubocop/cop/variable_force/branch.rb +2 -7
- data/lib/rubocop/cop/variable_force/scope.rb +2 -1
- data/lib/rubocop/cop/variable_force/variable.rb +20 -8
- data/lib/rubocop/cop/variable_force.rb +16 -17
- data/lib/rubocop/cops_documentation_generator.rb +284 -0
- data/lib/rubocop/core_ext/hash.rb +20 -0
- data/lib/rubocop/core_ext/string.rb +2 -26
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/error.rb +24 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +95 -0
- data/lib/rubocop/file_finder.rb +13 -12
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +8 -5
- data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -22
- data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +20 -19
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +47 -0
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/json_formatter.rb +6 -5
- data/lib/rubocop/formatter/junit_formatter.rb +84 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +1 -1
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +54 -10
- data/lib/rubocop/formatter/tap_formatter.rb +19 -6
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -1
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +7 -3
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +131 -60
- data/lib/rubocop/path_util.rb +19 -19
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +10 -11
- data/lib/rubocop/remote_config.rb +2 -3
- data/lib/rubocop/result_cache.rb +69 -27
- data/lib/rubocop/rspec/cop_helper.rb +11 -32
- data/lib/rubocop/rspec/expect_offense.rb +107 -25
- data/lib/rubocop/rspec/shared_contexts.rb +89 -40
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +127 -73
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +61 -48
- data/lib/rubocop/target_ruby.rb +224 -0
- data/lib/rubocop/version.rb +65 -7
- data/lib/rubocop/yaml_duplication_checker.rb +9 -2
- data/lib/rubocop.rb +172 -145
- metadata +230 -184
- data/bin/console +0 -9
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -79
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -29
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -646
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
- data/lib/rubocop/cop/layout/tab.rb +0 -87
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb +0 -116
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
- data/lib/rubocop/cop/rails/blank.rb +0 -164
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -161
- data/lib/rubocop/cop/rails/delegate.rb +0 -132
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -51
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -179
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -153
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
- data/lib/rubocop/cop/rails/time_zone.rb +0 -238
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -109
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -190
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -720
- data/lib/rubocop/processed_source.rb +0 -208
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -1,286 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks whether the change method of the migration file is
|
7
|
-
# reversible.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# def change
|
12
|
-
# change_table :users do |t|
|
13
|
-
# t.remove :name
|
14
|
-
# end
|
15
|
-
# end
|
16
|
-
#
|
17
|
-
# # good
|
18
|
-
# def change
|
19
|
-
# create_table :users do |t|
|
20
|
-
# t.string :name
|
21
|
-
# end
|
22
|
-
# end
|
23
|
-
#
|
24
|
-
# # good
|
25
|
-
# def change
|
26
|
-
# reversible do |dir|
|
27
|
-
# change_table :users do |t|
|
28
|
-
# dir.up do
|
29
|
-
# t.column :name, :string
|
30
|
-
# end
|
31
|
-
#
|
32
|
-
# dir.down do
|
33
|
-
# t.remove :name
|
34
|
-
# end
|
35
|
-
# end
|
36
|
-
# end
|
37
|
-
# end
|
38
|
-
#
|
39
|
-
# @example
|
40
|
-
# # drop_table
|
41
|
-
#
|
42
|
-
# # bad
|
43
|
-
# def change
|
44
|
-
# drop_table :users
|
45
|
-
# end
|
46
|
-
#
|
47
|
-
# # good
|
48
|
-
# def change
|
49
|
-
# drop_table :users do |t|
|
50
|
-
# t.string :name
|
51
|
-
# end
|
52
|
-
# end
|
53
|
-
#
|
54
|
-
# @example
|
55
|
-
# # change_column_default
|
56
|
-
#
|
57
|
-
# # bad
|
58
|
-
# def change
|
59
|
-
# change_column_default(:suppliers, :qualification, 'new')
|
60
|
-
# end
|
61
|
-
#
|
62
|
-
# # good
|
63
|
-
# def change
|
64
|
-
# change_column_default(:posts, :state, from: nil, to: "draft")
|
65
|
-
# end
|
66
|
-
#
|
67
|
-
# @example
|
68
|
-
# # remove_column
|
69
|
-
#
|
70
|
-
# # bad
|
71
|
-
# def change
|
72
|
-
# remove_column(:suppliers, :qualification)
|
73
|
-
# end
|
74
|
-
#
|
75
|
-
# # good
|
76
|
-
# def change
|
77
|
-
# remove_column(:suppliers, :qualification, :string)
|
78
|
-
# end
|
79
|
-
#
|
80
|
-
# @example
|
81
|
-
# # remove_foreign_key
|
82
|
-
#
|
83
|
-
# # bad
|
84
|
-
# def change
|
85
|
-
# remove_foreign_key :accounts, column: :owner_id
|
86
|
-
# end
|
87
|
-
#
|
88
|
-
# # good
|
89
|
-
# def change
|
90
|
-
# remove_foreign_key :accounts, :branches
|
91
|
-
# end
|
92
|
-
#
|
93
|
-
# @example
|
94
|
-
# # change_table
|
95
|
-
#
|
96
|
-
# # bad
|
97
|
-
# def change
|
98
|
-
# change_table :users do |t|
|
99
|
-
# t.remove :name
|
100
|
-
# t.change_default :authorized, 1
|
101
|
-
# t.change :price, :string
|
102
|
-
# end
|
103
|
-
# end
|
104
|
-
#
|
105
|
-
# # good
|
106
|
-
# def change
|
107
|
-
# change_table :users do |t|
|
108
|
-
# t.string :name
|
109
|
-
# end
|
110
|
-
# end
|
111
|
-
#
|
112
|
-
# # good
|
113
|
-
# def change
|
114
|
-
# reversible do |dir|
|
115
|
-
# change_table :users do |t|
|
116
|
-
# dir.up do
|
117
|
-
# t.change :price, :string
|
118
|
-
# end
|
119
|
-
#
|
120
|
-
# dir.down do
|
121
|
-
# t.change :price, :integer
|
122
|
-
# end
|
123
|
-
# end
|
124
|
-
# end
|
125
|
-
# end
|
126
|
-
#
|
127
|
-
# @see https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html
|
128
|
-
class ReversibleMigration < Cop
|
129
|
-
MSG = '%<action>s is not reversible.'
|
130
|
-
IRREVERSIBLE_CHANGE_TABLE_CALLS = %i[
|
131
|
-
change change_default remove
|
132
|
-
].freeze
|
133
|
-
|
134
|
-
def_node_matcher :irreversible_schema_statement_call, <<-PATTERN
|
135
|
-
(send nil? ${:change_table_comment :execute :remove_belongs_to} ...)
|
136
|
-
PATTERN
|
137
|
-
|
138
|
-
def_node_matcher :drop_table_call, <<-PATTERN
|
139
|
-
(send nil? :drop_table ...)
|
140
|
-
PATTERN
|
141
|
-
|
142
|
-
def_node_matcher :change_column_default_call, <<-PATTERN
|
143
|
-
(send nil? :change_column_default {[(sym _) (sym _)] (splat _)} $...)
|
144
|
-
PATTERN
|
145
|
-
|
146
|
-
def_node_matcher :remove_column_call, <<-PATTERN
|
147
|
-
(send nil? :remove_column $...)
|
148
|
-
PATTERN
|
149
|
-
|
150
|
-
def_node_matcher :remove_foreign_key_call, <<-PATTERN
|
151
|
-
(send nil? :remove_foreign_key _ $_)
|
152
|
-
PATTERN
|
153
|
-
|
154
|
-
def_node_matcher :change_table_call, <<-PATTERN
|
155
|
-
(send nil? :change_table $_ ...)
|
156
|
-
PATTERN
|
157
|
-
|
158
|
-
def on_send(node)
|
159
|
-
return unless within_change_method?(node)
|
160
|
-
return if within_reversible_or_up_only_block?(node)
|
161
|
-
|
162
|
-
check_irreversible_schema_statement_node(node)
|
163
|
-
check_drop_table_node(node)
|
164
|
-
check_change_column_default_node(node)
|
165
|
-
check_remove_column_node(node)
|
166
|
-
check_remove_foreign_key_node(node)
|
167
|
-
end
|
168
|
-
|
169
|
-
def on_block(node)
|
170
|
-
return unless within_change_method?(node)
|
171
|
-
return if within_reversible_or_up_only_block?(node)
|
172
|
-
return if node.body.nil?
|
173
|
-
|
174
|
-
check_change_table_node(node.send_node, node.body)
|
175
|
-
end
|
176
|
-
|
177
|
-
private
|
178
|
-
|
179
|
-
def check_irreversible_schema_statement_node(node)
|
180
|
-
irreversible_schema_statement_call(node) do |method_name|
|
181
|
-
add_offense(node, message: format(MSG, action: method_name))
|
182
|
-
end
|
183
|
-
end
|
184
|
-
|
185
|
-
def check_drop_table_node(node)
|
186
|
-
drop_table_call(node) do
|
187
|
-
unless node.parent.block_type?
|
188
|
-
add_offense(
|
189
|
-
node,
|
190
|
-
message: format(MSG, action: 'drop_table(without block)')
|
191
|
-
)
|
192
|
-
end
|
193
|
-
end
|
194
|
-
end
|
195
|
-
|
196
|
-
def check_change_column_default_node(node)
|
197
|
-
change_column_default_call(node) do |args|
|
198
|
-
unless all_hash_key?(args.last, :from, :to)
|
199
|
-
add_offense(
|
200
|
-
node,
|
201
|
-
message: format(
|
202
|
-
MSG, action: 'change_column_default(without :from and :to)'
|
203
|
-
)
|
204
|
-
)
|
205
|
-
end
|
206
|
-
end
|
207
|
-
end
|
208
|
-
|
209
|
-
def check_remove_column_node(node)
|
210
|
-
remove_column_call(node) do |args|
|
211
|
-
if args.to_a.size < 3
|
212
|
-
add_offense(
|
213
|
-
node,
|
214
|
-
message: format(MSG, action: 'remove_column(without type)')
|
215
|
-
)
|
216
|
-
end
|
217
|
-
end
|
218
|
-
end
|
219
|
-
|
220
|
-
def check_remove_foreign_key_node(node)
|
221
|
-
remove_foreign_key_call(node) do |arg|
|
222
|
-
if arg.hash_type?
|
223
|
-
add_offense(
|
224
|
-
node,
|
225
|
-
message: format(MSG,
|
226
|
-
action: 'remove_foreign_key(without table)')
|
227
|
-
)
|
228
|
-
end
|
229
|
-
end
|
230
|
-
end
|
231
|
-
|
232
|
-
def check_change_table_node(node, block)
|
233
|
-
change_table_call(node) do |arg|
|
234
|
-
if target_rails_version < 4.0
|
235
|
-
add_offense(
|
236
|
-
node,
|
237
|
-
message: format(MSG, action: 'change_table')
|
238
|
-
)
|
239
|
-
elsif block.send_type?
|
240
|
-
check_change_table_offense(arg, block)
|
241
|
-
else
|
242
|
-
block.each_child_node(:send) do |child_node|
|
243
|
-
check_change_table_offense(arg, child_node)
|
244
|
-
end
|
245
|
-
end
|
246
|
-
end
|
247
|
-
end
|
248
|
-
|
249
|
-
def check_change_table_offense(receiver, node)
|
250
|
-
method_name = node.method_name
|
251
|
-
return if receiver != node.receiver &&
|
252
|
-
!IRREVERSIBLE_CHANGE_TABLE_CALLS.include?(method_name)
|
253
|
-
|
254
|
-
add_offense(
|
255
|
-
node,
|
256
|
-
message: format(MSG, action: "change_table(with #{method_name})")
|
257
|
-
)
|
258
|
-
end
|
259
|
-
|
260
|
-
def within_change_method?(node)
|
261
|
-
node.each_ancestor(:def).any? do |ancestor|
|
262
|
-
ancestor.method?(:change)
|
263
|
-
end
|
264
|
-
end
|
265
|
-
|
266
|
-
def within_reversible_or_up_only_block?(node)
|
267
|
-
node.each_ancestor(:block).any? do |ancestor|
|
268
|
-
ancestor.block_type? &&
|
269
|
-
ancestor.send_node.method?(:reversible) ||
|
270
|
-
ancestor.send_node.method?(:up_only)
|
271
|
-
end
|
272
|
-
end
|
273
|
-
|
274
|
-
def all_hash_key?(args, *keys)
|
275
|
-
return false unless args&.hash_type?
|
276
|
-
|
277
|
-
hash_keys = args.keys.map do |key|
|
278
|
-
key.children.first.to_sym
|
279
|
-
end
|
280
|
-
|
281
|
-
hash_keys & keys == keys
|
282
|
-
end
|
283
|
-
end
|
284
|
-
end
|
285
|
-
end
|
286
|
-
end
|
@@ -1,87 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop converts usages of `try!` to `&.`. It can also be configured
|
7
|
-
# to convert `try`. It will convert code to use safe navigation.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # ConvertTry: false
|
11
|
-
# # bad
|
12
|
-
# foo.try!(:bar)
|
13
|
-
# foo.try!(:bar, baz)
|
14
|
-
# foo.try!(:bar) { |e| e.baz }
|
15
|
-
#
|
16
|
-
# foo.try!(:[], 0)
|
17
|
-
#
|
18
|
-
# # good
|
19
|
-
# foo.try(:bar)
|
20
|
-
# foo.try(:bar, baz)
|
21
|
-
# foo.try(:bar) { |e| e.baz }
|
22
|
-
#
|
23
|
-
# foo&.bar
|
24
|
-
# foo&.bar(baz)
|
25
|
-
# foo&.bar { |e| e.baz }
|
26
|
-
#
|
27
|
-
#
|
28
|
-
# # ConvertTry: true
|
29
|
-
# # bad
|
30
|
-
# foo.try!(:bar)
|
31
|
-
# foo.try!(:bar, baz)
|
32
|
-
# foo.try!(:bar) { |e| e.baz }
|
33
|
-
# foo.try(:bar)
|
34
|
-
# foo.try(:bar, baz)
|
35
|
-
# foo.try(:bar) { |e| e.baz }
|
36
|
-
#
|
37
|
-
# # good
|
38
|
-
# foo&.bar
|
39
|
-
# foo&.bar(baz)
|
40
|
-
# foo&.bar { |e| e.baz }
|
41
|
-
class SafeNavigation < Cop
|
42
|
-
include RangeHelp
|
43
|
-
|
44
|
-
MSG = 'Use safe navigation (`&.`) instead of `%<try>s`.'
|
45
|
-
|
46
|
-
def_node_matcher :try_call, <<-PATTERN
|
47
|
-
(send !nil? ${:try :try!} $_ ...)
|
48
|
-
PATTERN
|
49
|
-
|
50
|
-
def on_send(node)
|
51
|
-
try_call(node) do |try_method, dispatch|
|
52
|
-
return if try_method == :try && !cop_config['ConvertTry']
|
53
|
-
return unless dispatch.sym_type? && dispatch.value =~ /\w+[=!?]?/
|
54
|
-
|
55
|
-
add_offense(node, message: format(MSG, try: try_method))
|
56
|
-
end
|
57
|
-
end
|
58
|
-
|
59
|
-
def autocorrect(node)
|
60
|
-
method_node, *params = *node.arguments
|
61
|
-
method = method_node.source[1..-1]
|
62
|
-
|
63
|
-
range = range_between(node.loc.dot.begin_pos,
|
64
|
-
node.loc.expression.end_pos)
|
65
|
-
|
66
|
-
lambda do |corrector|
|
67
|
-
corrector.replace(range, replacement(method, params))
|
68
|
-
end
|
69
|
-
end
|
70
|
-
|
71
|
-
private
|
72
|
-
|
73
|
-
def replacement(method, params)
|
74
|
-
new_params = params.map(&:source).join(', ')
|
75
|
-
|
76
|
-
if method.end_with?('=')
|
77
|
-
"&.#{method[0...-1]} = #{new_params}"
|
78
|
-
elsif params.empty?
|
79
|
-
"&.#{method}"
|
80
|
-
else
|
81
|
-
"&.#{method}(#{new_params})"
|
82
|
-
end
|
83
|
-
end
|
84
|
-
end
|
85
|
-
end
|
86
|
-
end
|
87
|
-
end
|
@@ -1,316 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop identifies possible cases where Active Record save! or related
|
7
|
-
# should be used instead of save because the model might have failed to
|
8
|
-
# save and an exception is better than unhandled failure.
|
9
|
-
#
|
10
|
-
# This will allow:
|
11
|
-
# - update or save calls, assigned to a variable,
|
12
|
-
# or used as a condition in an if/unless/case statement.
|
13
|
-
# - create calls, assigned to a variable that then has a
|
14
|
-
# call to `persisted?`.
|
15
|
-
# - calls if the result is explicitly returned from methods and blocks,
|
16
|
-
# or provided as arguments.
|
17
|
-
# - calls whose signature doesn't look like an ActiveRecord
|
18
|
-
# persistence method.
|
19
|
-
#
|
20
|
-
# By default it will also allow implicit returns from methods and blocks.
|
21
|
-
# that behavior can be turned off with `AllowImplicitReturn: false`.
|
22
|
-
#
|
23
|
-
# You can permit receivers that are giving false positives with
|
24
|
-
# `AllowedReceivers: []`
|
25
|
-
#
|
26
|
-
# @example
|
27
|
-
#
|
28
|
-
# # bad
|
29
|
-
# user.save
|
30
|
-
# user.update(name: 'Joe')
|
31
|
-
# user.find_or_create_by(name: 'Joe')
|
32
|
-
# user.destroy
|
33
|
-
#
|
34
|
-
# # good
|
35
|
-
# unless user.save
|
36
|
-
# # ...
|
37
|
-
# end
|
38
|
-
# user.save!
|
39
|
-
# user.update!(name: 'Joe')
|
40
|
-
# user.find_or_create_by!(name: 'Joe')
|
41
|
-
# user.destroy!
|
42
|
-
#
|
43
|
-
# user = User.find_or_create_by(name: 'Joe')
|
44
|
-
# unless user.persisted?
|
45
|
-
# # ...
|
46
|
-
# end
|
47
|
-
#
|
48
|
-
# def save_user
|
49
|
-
# return user.save
|
50
|
-
# end
|
51
|
-
#
|
52
|
-
# @example AllowImplicitReturn: true (default)
|
53
|
-
#
|
54
|
-
# # good
|
55
|
-
# users.each { |u| u.save }
|
56
|
-
#
|
57
|
-
# def save_user
|
58
|
-
# user.save
|
59
|
-
# end
|
60
|
-
#
|
61
|
-
# @example AllowImplicitReturn: false
|
62
|
-
#
|
63
|
-
# # bad
|
64
|
-
# users.each { |u| u.save }
|
65
|
-
# def save_user
|
66
|
-
# user.save
|
67
|
-
# end
|
68
|
-
#
|
69
|
-
# # good
|
70
|
-
# users.each { |u| u.save! }
|
71
|
-
#
|
72
|
-
# def save_user
|
73
|
-
# user.save!
|
74
|
-
# end
|
75
|
-
#
|
76
|
-
# def save_user
|
77
|
-
# return user.save
|
78
|
-
# end
|
79
|
-
#
|
80
|
-
# @example AllowedReceivers: ['merchant.customers', 'Service::Mailer']
|
81
|
-
#
|
82
|
-
# # bad
|
83
|
-
# merchant.create
|
84
|
-
# customers.builder.save
|
85
|
-
# Mailer.create
|
86
|
-
#
|
87
|
-
# module Service::Mailer
|
88
|
-
# self.create
|
89
|
-
# end
|
90
|
-
#
|
91
|
-
# # good
|
92
|
-
# merchant.customers.create
|
93
|
-
# MerchantService.merchant.customers.destroy
|
94
|
-
# Service::Mailer.update(message: 'Message')
|
95
|
-
# ::Service::Mailer.update
|
96
|
-
# Services::Service::Mailer.update(message: 'Message')
|
97
|
-
# Service::Mailer::update
|
98
|
-
#
|
99
|
-
class SaveBang < Cop
|
100
|
-
include NegativeConditional
|
101
|
-
|
102
|
-
MSG = 'Use `%<prefer>s` instead of `%<current>s` if the return ' \
|
103
|
-
'value is not checked.'
|
104
|
-
CREATE_MSG = (MSG +
|
105
|
-
' Or check `persisted?` on model returned from ' \
|
106
|
-
'`%<current>s`.').freeze
|
107
|
-
CREATE_CONDITIONAL_MSG = '`%<current>s` returns a model which is ' \
|
108
|
-
'always truthy.'
|
109
|
-
|
110
|
-
CREATE_PERSIST_METHODS = %i[create
|
111
|
-
first_or_create find_or_create_by].freeze
|
112
|
-
MODIFY_PERSIST_METHODS = %i[save
|
113
|
-
update update_attributes destroy].freeze
|
114
|
-
PERSIST_METHODS = (CREATE_PERSIST_METHODS +
|
115
|
-
MODIFY_PERSIST_METHODS).freeze
|
116
|
-
|
117
|
-
def join_force?(force_class)
|
118
|
-
force_class == VariableForce
|
119
|
-
end
|
120
|
-
|
121
|
-
def after_leaving_scope(scope, _variable_table)
|
122
|
-
scope.variables.each_value do |variable|
|
123
|
-
variable.assignments.each do |assignment|
|
124
|
-
check_assignment(assignment)
|
125
|
-
end
|
126
|
-
end
|
127
|
-
end
|
128
|
-
|
129
|
-
def check_assignment(assignment)
|
130
|
-
node = right_assignment_node(assignment)
|
131
|
-
|
132
|
-
return unless node&.send_type?
|
133
|
-
return unless persist_method?(node, CREATE_PERSIST_METHODS)
|
134
|
-
return if persisted_referenced?(assignment)
|
135
|
-
|
136
|
-
add_offense_for_node(node, CREATE_MSG)
|
137
|
-
end
|
138
|
-
|
139
|
-
def on_send(node) # rubocop:disable Metrics/CyclomaticComplexity
|
140
|
-
return unless persist_method?(node)
|
141
|
-
return if return_value_assigned?(node)
|
142
|
-
return if check_used_in_conditional(node)
|
143
|
-
return if argument?(node)
|
144
|
-
return if implicit_return?(node)
|
145
|
-
return if explicit_return?(node)
|
146
|
-
|
147
|
-
add_offense_for_node(node)
|
148
|
-
end
|
149
|
-
alias on_csend on_send
|
150
|
-
|
151
|
-
def autocorrect(node)
|
152
|
-
save_loc = node.loc.selector
|
153
|
-
new_method = "#{node.method_name}!"
|
154
|
-
|
155
|
-
->(corrector) { corrector.replace(save_loc, new_method) }
|
156
|
-
end
|
157
|
-
|
158
|
-
private
|
159
|
-
|
160
|
-
def add_offense_for_node(node, msg = MSG)
|
161
|
-
name = node.method_name
|
162
|
-
full_message = format(msg, prefer: "#{name}!", current: name.to_s)
|
163
|
-
|
164
|
-
add_offense(node, location: :selector, message: full_message)
|
165
|
-
end
|
166
|
-
|
167
|
-
def right_assignment_node(assignment)
|
168
|
-
node = assignment.node.child_nodes.first
|
169
|
-
|
170
|
-
return node unless node&.block_type?
|
171
|
-
|
172
|
-
node.send_node
|
173
|
-
end
|
174
|
-
|
175
|
-
def persisted_referenced?(assignment)
|
176
|
-
return unless assignment.referenced?
|
177
|
-
|
178
|
-
assignment.variable.references.any? do |reference|
|
179
|
-
call_to_persisted?(reference.node.parent)
|
180
|
-
end
|
181
|
-
end
|
182
|
-
|
183
|
-
def call_to_persisted?(node)
|
184
|
-
node.send_type? && node.method?(:persisted?)
|
185
|
-
end
|
186
|
-
|
187
|
-
def assignable_node(node)
|
188
|
-
assignable = node.block_node || node
|
189
|
-
while node
|
190
|
-
node = hash_parent(node) || array_parent(node)
|
191
|
-
assignable = node if node
|
192
|
-
end
|
193
|
-
assignable
|
194
|
-
end
|
195
|
-
|
196
|
-
def hash_parent(node)
|
197
|
-
pair = node.parent
|
198
|
-
return unless pair&.pair_type?
|
199
|
-
|
200
|
-
hash = pair.parent
|
201
|
-
return unless hash&.hash_type?
|
202
|
-
|
203
|
-
hash
|
204
|
-
end
|
205
|
-
|
206
|
-
def array_parent(node)
|
207
|
-
array = node.parent
|
208
|
-
return unless array&.array_type?
|
209
|
-
|
210
|
-
array
|
211
|
-
end
|
212
|
-
|
213
|
-
def check_used_in_conditional(node)
|
214
|
-
return false unless conditional?(node)
|
215
|
-
|
216
|
-
unless MODIFY_PERSIST_METHODS.include?(node.method_name)
|
217
|
-
add_offense_for_node(node, CREATE_CONDITIONAL_MSG)
|
218
|
-
end
|
219
|
-
|
220
|
-
true
|
221
|
-
end
|
222
|
-
|
223
|
-
def conditional?(node) # rubocop:disable Metrics/CyclomaticComplexity
|
224
|
-
node = node.block_node || node
|
225
|
-
|
226
|
-
condition = node.parent
|
227
|
-
return false unless condition
|
228
|
-
|
229
|
-
condition.if_type? || condition.case_type? ||
|
230
|
-
condition.or_type? || condition.and_type? ||
|
231
|
-
single_negative?(condition)
|
232
|
-
end
|
233
|
-
|
234
|
-
def allowed_receiver?(node)
|
235
|
-
return false unless node.receiver
|
236
|
-
return false unless cop_config['AllowedReceivers']
|
237
|
-
|
238
|
-
cop_config['AllowedReceivers'].any? do |allowed_receiver|
|
239
|
-
receiver_chain_matches?(node, allowed_receiver)
|
240
|
-
end
|
241
|
-
end
|
242
|
-
|
243
|
-
def receiver_chain_matches?(node, allowed_receiver)
|
244
|
-
allowed_receiver.split('.').reverse.all? do |receiver_part|
|
245
|
-
node = node.receiver
|
246
|
-
return false unless node
|
247
|
-
|
248
|
-
if node.variable?
|
249
|
-
node.node_parts.first == receiver_part.to_sym
|
250
|
-
elsif node.send_type?
|
251
|
-
node.method_name == receiver_part.to_sym
|
252
|
-
elsif node.const_type?
|
253
|
-
const_matches?(node.const_name, receiver_part)
|
254
|
-
end
|
255
|
-
end
|
256
|
-
end
|
257
|
-
|
258
|
-
# Const == Const
|
259
|
-
# ::Const == ::Const
|
260
|
-
# ::Const == Const
|
261
|
-
# Const == ::Const
|
262
|
-
# NameSpace::Const == Const
|
263
|
-
# NameSpace::Const == NameSpace::Const
|
264
|
-
# NameSpace::Const != ::Const
|
265
|
-
# Const != NameSpace::Const
|
266
|
-
def const_matches?(const, allowed_const)
|
267
|
-
parts = allowed_const.split('::').reverse.zip(
|
268
|
-
const.split('::').reverse
|
269
|
-
)
|
270
|
-
parts.all? do |(allowed_part, const_part)|
|
271
|
-
allowed_part == const_part.to_s
|
272
|
-
end
|
273
|
-
end
|
274
|
-
|
275
|
-
def implicit_return?(node)
|
276
|
-
return false unless cop_config['AllowImplicitReturn']
|
277
|
-
|
278
|
-
node = assignable_node(node)
|
279
|
-
method = node.parent
|
280
|
-
return unless method && (method.def_type? || method.block_type?)
|
281
|
-
|
282
|
-
method.children.size == node.sibling_index + 1
|
283
|
-
end
|
284
|
-
|
285
|
-
def argument?(node)
|
286
|
-
assignable_node(node).argument?
|
287
|
-
end
|
288
|
-
|
289
|
-
def explicit_return?(node)
|
290
|
-
ret = assignable_node(node).parent
|
291
|
-
ret && (ret.return_type? || ret.next_type?)
|
292
|
-
end
|
293
|
-
|
294
|
-
def return_value_assigned?(node)
|
295
|
-
assignment = assignable_node(node).parent
|
296
|
-
assignment&.lvasgn_type?
|
297
|
-
end
|
298
|
-
|
299
|
-
def persist_method?(node, methods = PERSIST_METHODS)
|
300
|
-
methods.include?(node.method_name) &&
|
301
|
-
expected_signature?(node) &&
|
302
|
-
!allowed_receiver?(node)
|
303
|
-
end
|
304
|
-
|
305
|
-
# Check argument signature as no arguments or one hash
|
306
|
-
def expected_signature?(node)
|
307
|
-
!node.arguments? ||
|
308
|
-
(node.arguments.one? &&
|
309
|
-
node.method_name != :destroy &&
|
310
|
-
(node.first_argument.hash_type? ||
|
311
|
-
!node.first_argument.literal?))
|
312
|
-
end
|
313
|
-
end
|
314
|
-
end
|
315
|
-
end
|
316
|
-
end
|
@@ -1,29 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks for scope calls where it was passed
|
7
|
-
# a method (usually a scope) instead of a lambda/proc.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
#
|
11
|
-
# # bad
|
12
|
-
# scope :something, where(something: true)
|
13
|
-
#
|
14
|
-
# # good
|
15
|
-
# scope :something, -> { where(something: true) }
|
16
|
-
class ScopeArgs < Cop
|
17
|
-
MSG = 'Use `lambda`/`proc` instead of a plain method call.'
|
18
|
-
|
19
|
-
def_node_matcher :scope?, '(send nil? :scope _ $send)'
|
20
|
-
|
21
|
-
def on_send(node)
|
22
|
-
scope?(node) do |second_arg|
|
23
|
-
add_offense(second_arg)
|
24
|
-
end
|
25
|
-
end
|
26
|
-
end
|
27
|
-
end
|
28
|
-
end
|
29
|
-
end
|