rubocop 0.70.0 → 1.6.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +64 -40
- data/config/default.yml +1316 -986
- data/config/obsoletion.yml +196 -0
- data/exe/rubocop +1 -1
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +4 -2
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +100 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
- data/lib/rubocop/cli/command/show_cops.rb +77 -0
- data/lib/rubocop/cli/command/suggest_extensions.rb +80 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/cli.rb +22 -230
- data/lib/rubocop/comment_config.rb +29 -16
- data/lib/rubocop/config.rb +80 -509
- data/lib/rubocop/config_loader.rb +122 -91
- data/lib/rubocop/config_loader_resolver.rb +65 -24
- data/lib/rubocop/config_obsoletion/changed_enforced_styles.rb +33 -0
- data/lib/rubocop/config_obsoletion/changed_parameter.rb +21 -0
- data/lib/rubocop/config_obsoletion/cop_rule.rb +34 -0
- data/lib/rubocop/config_obsoletion/extracted_cop.rb +44 -0
- data/lib/rubocop/config_obsoletion/parameter_rule.rb +44 -0
- data/lib/rubocop/config_obsoletion/removed_cop.rb +41 -0
- data/lib/rubocop/config_obsoletion/renamed_cop.rb +34 -0
- data/lib/rubocop/config_obsoletion/rule.rb +41 -0
- data/lib/rubocop/config_obsoletion/split_cop.rb +27 -0
- data/lib/rubocop/config_obsoletion.rb +101 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +19 -5
- data/lib/rubocop/config_validator.rb +239 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +83 -6
- data/lib/rubocop/cop/badge.rb +15 -30
- data/lib/rubocop/cop/base.rb +447 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +28 -4
- data/lib/rubocop/cop/bundler/gem_comment.rb +83 -9
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +15 -23
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
- data/lib/rubocop/cop/commissioner.rb +102 -70
- data/lib/rubocop/cop/cop.rb +102 -186
- data/lib/rubocop/cop/corrector.rb +71 -122
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +45 -23
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +36 -5
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +9 -14
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +6 -8
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/force.rb +2 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +5 -5
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +3 -5
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +45 -20
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
- data/lib/rubocop/cop/generator/configuration_injector.rb +12 -7
- data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
- data/lib/rubocop/cop/generator.rb +15 -21
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +3 -3
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +13 -15
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +11 -10
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +12 -8
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +10 -10
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +5 -5
- data/lib/rubocop/cop/internal_affairs.rb +1 -0
- data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +11 -2
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +30 -27
- data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
- data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
- data/lib/rubocop/cop/layout/class_structure.rb +53 -69
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
- data/lib/rubocop/cop/layout/condition_position.rb +16 -8
- data/lib/rubocop/cop/layout/def_end_alignment.rb +7 -4
- data/lib/rubocop/cop/layout/dot_position.rb +21 -20
- data/lib/rubocop/cop/layout/else_alignment.rb +23 -2
- data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +43 -25
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +15 -15
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +100 -31
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +21 -20
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +13 -9
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +4 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +4 -7
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +17 -22
- data/lib/rubocop/cop/layout/end_of_line.rb +16 -11
- data/lib/rubocop/cop/layout/extra_spacing.rb +34 -94
- data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +28 -15
- data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
- data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +8 -4
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +41 -37
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +30 -17
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
- data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
- data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
- data/lib/rubocop/cop/layout/indentation_width.rb +29 -13
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +72 -11
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
- data/lib/rubocop/cop/{metrics → layout}/line_length.rb +92 -130
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +70 -27
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -11
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +8 -4
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
- data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +59 -26
- data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +47 -42
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
- data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +127 -44
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +37 -21
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
- data/lib/rubocop/cop/layout/space_inside_parens.rb +43 -26
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -41
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +56 -16
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -6
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +19 -6
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -11
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +98 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +18 -26
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
- data/lib/rubocop/cop/lint/duplicate_branch.rb +93 -0
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +3 -13
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +10 -13
- data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +77 -0
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +4 -3
- data/lib/rubocop/cop/lint/else_layout.rb +30 -4
- data/lib/rubocop/cop/lint/empty_block.rb +82 -0
- data/lib/rubocop/cop/lint/empty_class.rb +93 -0
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +8 -9
- data/lib/rubocop/cop/lint/empty_when.rb +31 -8
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +66 -8
- data/lib/rubocop/cop/lint/flip_flop.rb +9 -3
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +52 -41
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +12 -15
- data/lib/rubocop/cop/lint/inherit_exception.rb +13 -8
- data/lib/rubocop/cop/lint/interpolation_check.rb +26 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +46 -15
- data/lib/rubocop/cop/lint/loop.rb +30 -7
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
- data/lib/rubocop/cop/lint/missing_super.rb +102 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
- data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +11 -12
- data/lib/rubocop/cop/lint/nested_method_definition.rb +20 -26
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +16 -2
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +2 -2
- data/lib/rubocop/cop/lint/no_return_in_begin_end_blocks.rb +58 -0
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +10 -10
- data/lib/rubocop/cop/lint/number_conversion.rb +54 -23
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +98 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
- data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
- data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
- data/lib/rubocop/cop/lint/rand_one.rb +4 -3
- data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +128 -0
- data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +9 -11
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
- data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +25 -16
- data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +11 -18
- data/lib/rubocop/cop/lint/redundant_with_index.rb +13 -16
- data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -16
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +11 -15
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +11 -3
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +87 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +12 -13
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +20 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
- data/lib/rubocop/cop/lint/syntax.rb +11 -28
- data/lib/rubocop/cop/lint/to_enum_arguments.rb +86 -0
- data/lib/rubocop/cop/lint/to_json.rb +21 -12
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unexpected_block_arity.rb +85 -0
- data/lib/rubocop/cop/lint/unified_integer.rb +5 -9
- data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +199 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +3 -3
- data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +30 -9
- data/lib/rubocop/cop/lint/unused_method_argument.rb +63 -14
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +5 -3
- data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +95 -47
- data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +68 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +15 -8
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/lint/void.rb +10 -33
- data/lib/rubocop/cop/message_annotator.rb +16 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +27 -3
- data/lib/rubocop/cop/metrics/block_length.rb +40 -10
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +39 -8
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
- data/lib/rubocop/cop/metrics/method_length.rb +33 -5
- data/lib/rubocop/cop/metrics/module_length.rb +27 -4
- data/lib/rubocop/cop/metrics/parameter_lists.rb +71 -9
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +95 -14
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +146 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +42 -0
- data/lib/rubocop/cop/migration/department_name.rb +83 -0
- data/lib/rubocop/cop/mixin/alignment.rb +8 -6
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +20 -17
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +4 -3
- data/lib/rubocop/cop/mixin/def_node.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -4
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +4 -2
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +15 -5
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -6
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +5 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
- data/lib/rubocop/cop/mixin/ignored_methods.rb +36 -3
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
- data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +24 -4
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +5 -5
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +88 -1
- data/lib/rubocop/cop/mixin/range_help.rb +19 -5
- data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +51 -23
- data/lib/rubocop/cop/mixin/string_help.rb +4 -1
- data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +19 -33
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +36 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +19 -3
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +16 -6
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
- data/lib/rubocop/cop/naming/constant_name.rb +5 -4
- data/lib/rubocop/cop/naming/file_name.rb +40 -22
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +12 -6
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +69 -20
- data/lib/rubocop/cop/naming/method_name.rb +39 -2
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/predicate_name.rb +12 -15
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +27 -28
- data/lib/rubocop/cop/naming/variable_name.rb +2 -1
- data/lib/rubocop/cop/naming/variable_number.rb +101 -9
- data/lib/rubocop/cop/offense.rb +62 -12
- data/lib/rubocop/cop/registry.rb +97 -11
- data/lib/rubocop/cop/security/eval.rb +4 -3
- data/lib/rubocop/cop/security/json_load.rb +8 -9
- data/lib/rubocop/cop/security/marshal_load.rb +4 -5
- data/lib/rubocop/cop/security/open.rb +15 -12
- data/lib/rubocop/cop/security/yaml_load.rb +8 -7
- data/lib/rubocop/cop/severity.rb +1 -11
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -12
- data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
- data/lib/rubocop/cop/style/alias.rb +45 -38
- data/lib/rubocop/cop/style/and_or.rb +27 -22
- data/lib/rubocop/cop/style/arguments_forwarding.rb +142 -0
- data/lib/rubocop/cop/style/array_coercion.rb +67 -0
- data/lib/rubocop/cop/style/array_join.rb +8 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +22 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +137 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +79 -27
- data/lib/rubocop/cop/style/case_equality.rb +54 -4
- data/lib/rubocop/cop/style/case_like_if.rb +248 -0
- data/lib/rubocop/cop/style/character_literal.rb +10 -11
- data/lib/rubocop/cop/style/class_and_module_children.rb +26 -16
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +23 -7
- data/lib/rubocop/cop/style/collection_compact.rb +91 -0
- data/lib/rubocop/cop/style/collection_methods.rb +13 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +9 -10
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
- data/lib/rubocop/cop/style/command_literal.rb +24 -25
- data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
- data/lib/rubocop/cop/style/commented_keyword.rb +23 -35
- data/lib/rubocop/cop/style/conditional_assignment.rb +77 -82
- data/lib/rubocop/cop/style/constant_visibility.rb +17 -5
- data/lib/rubocop/cop/style/copyright.rb +27 -23
- data/lib/rubocop/cop/style/date_time.rb +17 -6
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +11 -13
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
- data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +169 -0
- data/lib/rubocop/cop/style/documentation.rb +62 -15
- data/lib/rubocop/cop/style/documentation_method.rb +46 -2
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
- data/lib/rubocop/cop/style/double_negation.rb +49 -6
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +6 -9
- data/lib/rubocop/cop/style/each_with_object.rb +17 -20
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +26 -27
- data/lib/rubocop/cop/style/empty_method.rb +13 -20
- data/lib/rubocop/cop/style/encoding.rb +6 -10
- data/lib/rubocop/cop/style/end_block.rb +6 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +10 -10
- data/lib/rubocop/cop/style/even_odd.rb +10 -13
- data/lib/rubocop/cop/style/expand_path_arguments.rb +30 -29
- data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
- data/lib/rubocop/cop/style/float_division.rb +136 -0
- data/lib/rubocop/cop/style/for.rb +7 -15
- data/lib/rubocop/cop/style/format_string.rb +48 -37
- data/lib/rubocop/cop/style/format_string_token.rb +70 -77
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +113 -65
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +69 -16
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +32 -23
- data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +9 -4
- data/lib/rubocop/cop/style/if_inside_else.rb +80 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +124 -44
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +51 -3
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -28
- data/lib/rubocop/cop/style/inline_comment.rb +4 -4
- data/lib/rubocop/cop/style/inverse_methods.rb +39 -39
- data/lib/rubocop/cop/style/ip_addresses.rb +6 -6
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +65 -0
- data/lib/rubocop/cop/style/lambda.rb +9 -15
- data/lib/rubocop/cop/style/lambda_call.rb +17 -34
- data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +169 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +44 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -226
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +18 -10
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
- data/lib/rubocop/cop/style/min_max.rb +9 -13
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +26 -33
- data/lib/rubocop/cop/style/mixin_usage.rb +12 -21
- data/lib/rubocop/cop/style/module_function.rb +64 -21
- data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_memoization.rb +16 -14
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
- data/lib/rubocop/cop/style/multiline_when_then.rb +73 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +56 -8
- data/lib/rubocop/cop/style/mutable_constant.rb +30 -29
- data/lib/rubocop/cop/style/negated_if.rb +9 -9
- data/lib/rubocop/cop/style/negated_if_else_condition.rb +106 -0
- data/lib/rubocop/cop/style/negated_unless.rb +9 -9
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +31 -16
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
- data/lib/rubocop/cop/style/next.rb +19 -23
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/nil_lambda.rb +52 -0
- data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
- data/lib/rubocop/cop/style/numeric_literals.rb +21 -14
- data/lib/rubocop/cop/style/numeric_predicate.rb +14 -19
- data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
- data/lib/rubocop/cop/style/option_hash.rb +5 -5
- data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
- data/lib/rubocop/cop/style/or_assignment.rb +24 -15
- data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +21 -7
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +91 -16
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +7 -7
- data/lib/rubocop/cop/style/raise_args.rb +33 -30
- data/lib/rubocop/cop/style/random_with_offset.rb +29 -34
- data/lib/rubocop/cop/style/redundant_argument.rb +88 -0
- data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
- data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +43 -15
- data/lib/rubocop/cop/style/redundant_conditional.rb +11 -11
- data/lib/rubocop/cop/style/redundant_exception.rb +21 -15
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +7 -9
- data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
- data/lib/rubocop/cop/style/redundant_parentheses.rb +53 -32
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +104 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +121 -0
- data/lib/rubocop/cop/style/redundant_return.rb +52 -44
- data/lib/rubocop/cop/style/redundant_self.rb +36 -21
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
- data/lib/rubocop/cop/style/redundant_sort_by.rb +6 -10
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +53 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +23 -19
- data/lib/rubocop/cop/style/return_nil.rb +7 -7
- data/lib/rubocop/cop/style/safe_navigation.rb +54 -20
- data/lib/rubocop/cop/style/sample.rb +14 -16
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +23 -12
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +26 -20
- data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +32 -7
- data/lib/rubocop/cop/style/single_line_methods.rb +26 -18
- data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +128 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +18 -41
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
- data/lib/rubocop/cop/style/static_class.rb +97 -0
- data/lib/rubocop/cop/style/stderr_puts.rb +7 -8
- data/lib/rubocop/cop/style/string_concatenation.rb +143 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +8 -9
- data/lib/rubocop/cop/style/string_literals.rb +14 -8
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +4 -3
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +10 -15
- data/lib/rubocop/cop/style/struct_inheritance.rb +23 -5
- data/lib/rubocop/cop/style/swap_values.rb +108 -0
- data/lib/rubocop/cop/style/symbol_array.rb +13 -24
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
- data/lib/rubocop/cop/style/symbol_proc.rb +22 -24
- data/lib/rubocop/cop/style/ternary_parentheses.rb +57 -31
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +39 -25
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -34
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +19 -22
- data/lib/rubocop/cop/style/trivial_accessors.rb +36 -39
- data/lib/rubocop/cop/style/unless_else.rb +6 -9
- data/lib/rubocop/cop/style/unpack_first.rb +5 -12
- data/lib/rubocop/cop/style/variable_interpolation.rb +11 -24
- data/lib/rubocop/cop/style/when_then.rb +5 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +17 -22
- data/lib/rubocop/cop/style/word_array.rb +8 -26
- data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
- data/lib/rubocop/cop/style/zero_length_predicate.rb +25 -27
- data/lib/rubocop/cop/team.rb +159 -87
- data/lib/rubocop/cop/util.rb +36 -19
- data/lib/rubocop/cop/utils/format_string.rb +135 -0
- data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
- data/lib/rubocop/cop/variable_force/branch.rb +2 -7
- data/lib/rubocop/cop/variable_force/scope.rb +2 -1
- data/lib/rubocop/cop/variable_force/variable.rb +20 -8
- data/lib/rubocop/cop/variable_force.rb +16 -17
- data/lib/rubocop/cops_documentation_generator.rb +284 -0
- data/lib/rubocop/core_ext/hash.rb +20 -0
- data/lib/rubocop/core_ext/string.rb +2 -26
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/error.rb +24 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +87 -0
- data/lib/rubocop/ext/regexp_parser.rb +95 -0
- data/lib/rubocop/file_finder.rb +13 -12
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +8 -5
- data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -22
- data/lib/rubocop/formatter/emacs_style_formatter.rb +24 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +20 -19
- data/lib/rubocop/formatter/git_hub_actions_formatter.rb +47 -0
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/json_formatter.rb +6 -5
- data/lib/rubocop/formatter/junit_formatter.rb +84 -0
- data/lib/rubocop/formatter/offense_count_formatter.rb +1 -1
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +54 -10
- data/lib/rubocop/formatter/tap_formatter.rb +19 -6
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -1
- data/lib/rubocop/lockfile.rb +40 -0
- data/lib/rubocop/magic_comment.rb +7 -3
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +131 -60
- data/lib/rubocop/path_util.rb +19 -19
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +10 -11
- data/lib/rubocop/remote_config.rb +2 -3
- data/lib/rubocop/result_cache.rb +69 -27
- data/lib/rubocop/rspec/cop_helper.rb +11 -32
- data/lib/rubocop/rspec/expect_offense.rb +107 -25
- data/lib/rubocop/rspec/shared_contexts.rb +89 -40
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +127 -73
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +61 -48
- data/lib/rubocop/target_ruby.rb +224 -0
- data/lib/rubocop/version.rb +65 -7
- data/lib/rubocop/yaml_duplication_checker.rb +9 -2
- data/lib/rubocop.rb +172 -145
- metadata +230 -184
- data/bin/console +0 -9
- data/bin/setup +0 -7
- data/lib/rubocop/ast/builder.rb +0 -79
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -29
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/node.rb +0 -646
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
- data/lib/rubocop/cop/layout/tab.rb +0 -87
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/unneeded_cop_enable_directive.rb +0 -116
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
- data/lib/rubocop/cop/rails/blank.rb +0 -164
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -161
- data/lib/rubocop/cop/rails/delegate.rb +0 -132
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -51
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -179
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -153
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
- data/lib/rubocop/cop/rails/time_zone.rb +0 -238
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -109
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -190
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -720
- data/lib/rubocop/processed_source.rb +0 -208
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
data/lib/rubocop/cop/team.rb
CHANGED
@@ -2,29 +2,52 @@
|
|
2
2
|
|
3
3
|
module RuboCop
|
4
4
|
module Cop
|
5
|
-
#
|
5
|
+
# A group of cops, ready to be called on duty to inspect files.
|
6
|
+
# Team is responsible for selecting only relevant cops to be sent on duty,
|
7
|
+
# as well as insuring that the needed forces are sent along with them.
|
8
|
+
#
|
9
|
+
# For performance reasons, Team will first dispatch cops & forces in two groups,
|
10
|
+
# first the ones needed for autocorrection (if any), then the rest
|
11
|
+
# (unless autocorrections happened).
|
6
12
|
class Team
|
7
|
-
|
8
|
-
auto_correct: false,
|
9
|
-
debug: false
|
10
|
-
}.freeze
|
11
|
-
|
12
|
-
Investigation = Struct.new(:offenses, :errors)
|
13
|
-
|
14
|
-
attr_reader :errors, :warnings, :updated_source_file
|
13
|
+
attr_reader :errors, :warnings, :updated_source_file, :cops
|
15
14
|
|
16
15
|
alias updated_source_file? updated_source_file
|
17
16
|
|
18
|
-
def initialize(
|
19
|
-
@
|
17
|
+
def initialize(cops, config = nil, options = {})
|
18
|
+
@cops = cops
|
20
19
|
@config = config
|
21
|
-
@options = options
|
22
|
-
|
23
|
-
@
|
20
|
+
@options = options
|
21
|
+
reset
|
22
|
+
@ready = true
|
24
23
|
|
25
24
|
validate_config
|
26
25
|
end
|
27
26
|
|
27
|
+
# @return [Team]
|
28
|
+
def self.new(cop_or_classes, config, options = {})
|
29
|
+
# Support v0 api:
|
30
|
+
return mobilize(cop_or_classes, config, options) if cop_or_classes.first.is_a?(Class)
|
31
|
+
|
32
|
+
super
|
33
|
+
end
|
34
|
+
|
35
|
+
# @return [Team] with cops assembled from the given `cop_classes`
|
36
|
+
def self.mobilize(cop_classes, config, options = {})
|
37
|
+
cops = mobilize_cops(cop_classes, config, options)
|
38
|
+
new(cops, config, options)
|
39
|
+
end
|
40
|
+
|
41
|
+
# @return [Array<Cop::Cop>]
|
42
|
+
def self.mobilize_cops(cop_classes, config, options = {})
|
43
|
+
cop_classes = Registry.new(cop_classes.to_a) unless cop_classes.is_a?(Registry)
|
44
|
+
only = options.fetch(:only, [])
|
45
|
+
safe = options.fetch(:safe, false)
|
46
|
+
cop_classes.enabled(config, only, only_safe: safe).map do |cop_class|
|
47
|
+
cop_class.new(config, options)
|
48
|
+
end
|
49
|
+
end
|
50
|
+
|
28
51
|
def autocorrect?
|
29
52
|
@options[:auto_correct]
|
30
53
|
end
|
@@ -33,135 +56,184 @@ module RuboCop
|
|
33
56
|
@options[:debug]
|
34
57
|
end
|
35
58
|
|
59
|
+
# @deprecated. Use investigate
|
60
|
+
# @return Array<offenses>
|
36
61
|
def inspect_file(processed_source)
|
37
|
-
|
38
|
-
unless processed_source.valid_syntax?
|
39
|
-
return Lint::Syntax.offenses_from_processed_source(
|
40
|
-
processed_source, @config, @options
|
41
|
-
)
|
42
|
-
end
|
43
|
-
|
44
|
-
offenses(processed_source)
|
62
|
+
investigate(processed_source).offenses
|
45
63
|
end
|
46
64
|
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
|
65
|
+
# @return [Commissioner::InvestigationReport]
|
66
|
+
def investigate(processed_source)
|
67
|
+
be_ready
|
68
|
+
|
69
|
+
# The autocorrection process may have to be repeated multiple times
|
70
|
+
# until there are no corrections left to perform
|
71
|
+
# To speed things up, run auto-correcting cops by themselves, and only
|
72
|
+
# run the other cops when no corrections are left
|
73
|
+
on_duty = roundup_relevant_cops(processed_source.file_path)
|
74
|
+
|
75
|
+
autocorrect_cops, other_cops = on_duty.partition(&:autocorrect?)
|
76
|
+
|
77
|
+
report = investigate_partial(autocorrect_cops, processed_source)
|
78
|
+
|
79
|
+
unless autocorrect(processed_source, report)
|
80
|
+
# If we corrected some errors, another round of inspection will be
|
81
|
+
# done, and any other offenses will be caught then, so only need
|
82
|
+
# to check other_cops if no correction was done
|
83
|
+
report = report.merge(investigate_partial(other_cops, processed_source))
|
52
84
|
end
|
85
|
+
|
86
|
+
process_errors(processed_source.path, report.errors)
|
87
|
+
|
88
|
+
report
|
89
|
+
ensure
|
90
|
+
@ready = false
|
53
91
|
end
|
54
92
|
|
93
|
+
# @deprecated
|
55
94
|
def forces
|
56
|
-
@forces ||= forces_for(cops)
|
95
|
+
@forces ||= self.class.forces_for(cops)
|
57
96
|
end
|
58
97
|
|
59
|
-
|
60
|
-
|
61
|
-
|
62
|
-
|
98
|
+
# @return [Array<Force>] needed for the given cops
|
99
|
+
def self.forces_for(cops)
|
100
|
+
needed = Hash.new { |h, k| h[k] = [] }
|
101
|
+
cops.each do |cop|
|
102
|
+
forces = cop.class.joining_forces
|
103
|
+
if forces.is_a?(Array)
|
104
|
+
forces.each { |force| needed[force] << cop }
|
105
|
+
elsif forces
|
106
|
+
needed[forces] << cop
|
107
|
+
end
|
108
|
+
end
|
63
109
|
|
64
|
-
|
110
|
+
needed.map do |force_class, joining_cops|
|
111
|
+
force_class.new(joining_cops)
|
65
112
|
end
|
66
113
|
end
|
67
114
|
|
68
|
-
def
|
115
|
+
def external_dependency_checksum
|
116
|
+
keys = cops.map(&:external_dependency_checksum).compact
|
117
|
+
Digest::SHA1.hexdigest(keys.join)
|
118
|
+
end
|
119
|
+
|
120
|
+
private
|
121
|
+
|
122
|
+
def autocorrect(processed_source, report)
|
69
123
|
@updated_source_file = false
|
70
124
|
return unless autocorrect?
|
125
|
+
return if report.processed_source.parser_error
|
71
126
|
|
72
|
-
new_source =
|
127
|
+
new_source = autocorrect_report(report)
|
73
128
|
|
74
|
-
return
|
129
|
+
return unless new_source
|
75
130
|
|
76
131
|
if @options[:stdin]
|
77
132
|
# holds source read in from stdin, when --stdin option is used
|
78
133
|
@options[:stdin] = new_source
|
79
134
|
else
|
80
|
-
filename = buffer.name
|
135
|
+
filename = processed_source.buffer.name
|
81
136
|
File.open(filename, 'w') { |f| f.write(new_source) }
|
82
137
|
end
|
83
138
|
@updated_source_file = true
|
84
139
|
end
|
85
140
|
|
86
|
-
|
141
|
+
def be_ready
|
142
|
+
return if @ready
|
87
143
|
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
# run the other cops when no corrections are left
|
93
|
-
autocorrect_cops, other_cops = cops.partition(&:autocorrect?)
|
94
|
-
|
95
|
-
autocorrect =
|
96
|
-
investigate(autocorrect_cops, processed_source) do |offenses|
|
97
|
-
# We corrected some errors. Another round of inspection will be
|
98
|
-
# done, and any other offenses will be caught then, so we don't
|
99
|
-
# need to continue.
|
100
|
-
return offenses if autocorrect(processed_source.buffer,
|
101
|
-
autocorrect_cops)
|
102
|
-
end
|
144
|
+
reset
|
145
|
+
@cops.map!(&:ready)
|
146
|
+
@ready = true
|
147
|
+
end
|
103
148
|
|
104
|
-
|
149
|
+
def reset
|
150
|
+
@errors = []
|
151
|
+
@warnings = []
|
152
|
+
end
|
105
153
|
|
106
|
-
|
107
|
-
|
154
|
+
# @return [Commissioner::InvestigationReport]
|
155
|
+
def investigate_partial(cops, processed_source)
|
156
|
+
commissioner = Commissioner.new(cops, self.class.forces_for(cops), @options)
|
157
|
+
commissioner.investigate(processed_source)
|
158
|
+
end
|
108
159
|
|
109
|
-
|
160
|
+
# @return [Array<cop>]
|
161
|
+
def roundup_relevant_cops(filename)
|
162
|
+
cops.reject do |cop|
|
163
|
+
cop.excluded_file?(filename) ||
|
164
|
+
!support_target_ruby_version?(cop) ||
|
165
|
+
!support_target_rails_version?(cop)
|
166
|
+
end
|
110
167
|
end
|
111
168
|
|
112
|
-
def
|
113
|
-
return
|
169
|
+
def support_target_ruby_version?(cop)
|
170
|
+
return true unless cop.class.respond_to?(:support_target_ruby_version?)
|
171
|
+
|
172
|
+
cop.class.support_target_ruby_version?(cop.target_ruby_version)
|
173
|
+
end
|
114
174
|
|
115
|
-
|
116
|
-
|
117
|
-
yield offenses if block_given?
|
175
|
+
def support_target_rails_version?(cop)
|
176
|
+
return true unless cop.class.respond_to?(:support_target_rails_version?)
|
118
177
|
|
119
|
-
|
178
|
+
cop.class.support_target_rails_version?(cop.target_rails_version)
|
120
179
|
end
|
121
180
|
|
122
|
-
def
|
123
|
-
corrector =
|
181
|
+
def autocorrect_report(report)
|
182
|
+
corrector = collate_corrections(report)
|
124
183
|
|
125
|
-
|
184
|
+
corrector.rewrite unless corrector.empty?
|
185
|
+
end
|
126
186
|
|
127
|
-
|
128
|
-
|
129
|
-
|
130
|
-
|
187
|
+
def collate_corrections(report)
|
188
|
+
corrector = Corrector.new(report.processed_source)
|
189
|
+
|
190
|
+
each_corrector(report) do |to_merge|
|
191
|
+
suppress_clobbering do
|
192
|
+
corrector.merge!(to_merge)
|
193
|
+
end
|
131
194
|
end
|
195
|
+
|
196
|
+
corrector
|
132
197
|
end
|
133
198
|
|
134
|
-
def
|
199
|
+
def each_corrector(report)
|
135
200
|
skips = Set.new
|
201
|
+
report.cop_reports.each do |cop_report|
|
202
|
+
cop = cop_report.cop
|
203
|
+
corrector = cop_report.corrector
|
136
204
|
|
137
|
-
|
138
|
-
next if cop.corrections.empty?
|
205
|
+
next if corrector.nil? || corrector.empty?
|
139
206
|
next if skips.include?(cop.class)
|
140
207
|
|
141
|
-
corrector
|
208
|
+
yield corrector
|
209
|
+
|
142
210
|
skips.merge(cop.class.autocorrect_incompatible_with)
|
143
211
|
end
|
144
212
|
end
|
145
213
|
|
214
|
+
def suppress_clobbering
|
215
|
+
yield
|
216
|
+
rescue ::Parser::ClobberingError
|
217
|
+
# ignore Clobbering errors
|
218
|
+
end
|
219
|
+
|
146
220
|
def validate_config
|
147
221
|
cops.each do |cop|
|
148
222
|
cop.validate_config if cop.respond_to?(:validate_config)
|
149
223
|
end
|
150
224
|
end
|
151
225
|
|
152
|
-
def
|
153
|
-
|
154
|
-
|
155
|
-
|
156
|
-
|
157
|
-
|
158
|
-
|
159
|
-
|
160
|
-
|
161
|
-
|
162
|
-
|
163
|
-
handle_error(e, location, cop)
|
164
|
-
end
|
226
|
+
def process_errors(file, errors)
|
227
|
+
errors.each do |error|
|
228
|
+
line = ":#{error.line}" if error.line
|
229
|
+
column = ":#{error.column}" if error.column
|
230
|
+
location = "#{file}#{line}#{column}"
|
231
|
+
cause = error.cause
|
232
|
+
|
233
|
+
if cause.is_a?(Warning)
|
234
|
+
handle_warning(cause, location)
|
235
|
+
else
|
236
|
+
handle_error(cause, location, error.cop)
|
165
237
|
end
|
166
238
|
end
|
167
239
|
end
|
data/lib/rubocop/cop/util.rb
CHANGED
@@ -9,12 +9,18 @@ module RuboCop
|
|
9
9
|
# Match literal regex characters, not including anchors, character
|
10
10
|
# classes, alternatives, groups, repetitions, references, etc
|
11
11
|
LITERAL_REGEX =
|
12
|
-
|
12
|
+
%r{[\w\s\-,"'!#%&<>=;:`~/]|\\[^AbBdDgGhHkpPRwWXsSzZ0-9]}.freeze
|
13
13
|
|
14
14
|
module_function
|
15
15
|
|
16
|
+
# This is a bad API
|
16
17
|
def comment_line?(line_source)
|
17
|
-
|
18
|
+
/^\s*#/.match?(line_source)
|
19
|
+
end
|
20
|
+
|
21
|
+
# @deprecated Use `ProcessedSource#line_with_comment?`, `contains_comment?` or similar
|
22
|
+
def comment_lines?(node)
|
23
|
+
processed_source[line_range(node)].any? { |line| comment_line?(line) }
|
18
24
|
end
|
19
25
|
|
20
26
|
def line_range(node)
|
@@ -26,8 +32,28 @@ module RuboCop
|
|
26
32
|
node.loc.end.is?(')')
|
27
33
|
end
|
28
34
|
|
35
|
+
def add_parentheses(node, corrector)
|
36
|
+
if node.arguments.empty?
|
37
|
+
corrector.insert_after(node, '()')
|
38
|
+
else
|
39
|
+
corrector.replace(args_begin(node), '(')
|
40
|
+
corrector.insert_after(args_end(node), ')')
|
41
|
+
end
|
42
|
+
end
|
43
|
+
|
44
|
+
def args_begin(node)
|
45
|
+
loc = node.loc
|
46
|
+
selector =
|
47
|
+
node.super_type? || node.yield_type? ? loc.keyword : loc.selector
|
48
|
+
selector.end.resize(1)
|
49
|
+
end
|
50
|
+
|
51
|
+
def args_end(node)
|
52
|
+
node.loc.expression.end
|
53
|
+
end
|
54
|
+
|
29
55
|
def on_node(syms, sexp, excludes = [], &block)
|
30
|
-
return to_enum(:on_node, syms, sexp, excludes) unless
|
56
|
+
return to_enum(:on_node, syms, sexp, excludes) unless block
|
31
57
|
|
32
58
|
yield sexp if Array(syms).include?(sexp.type)
|
33
59
|
return if Array(excludes).include?(sexp.type)
|
@@ -36,7 +62,7 @@ module RuboCop
|
|
36
62
|
end
|
37
63
|
|
38
64
|
def begins_its_line?(range)
|
39
|
-
|
65
|
+
range.source_line.index(/\S/) == range.column
|
40
66
|
end
|
41
67
|
|
42
68
|
# Returns, for example, a bare `if` node if the given node is an `if`
|
@@ -64,7 +90,7 @@ module RuboCop
|
|
64
90
|
|
65
91
|
# Regex matches IF there is a ' or there is a \\ in the string that is
|
66
92
|
# not preceded/followed by another \\ (e.g. "\\x34") but not "\\\\".
|
67
|
-
|
93
|
+
/'|(?<! \\) \\{2}* \\ (?![\\"])/x.match?(string)
|
68
94
|
end
|
69
95
|
|
70
96
|
def needs_escaping?(string)
|
@@ -84,7 +110,7 @@ module RuboCop
|
|
84
110
|
end
|
85
111
|
|
86
112
|
def trim_string_interporation_escape_character(str)
|
87
|
-
str.gsub(
|
113
|
+
str.gsub(/\\\#\{(.*?)\}/) { "\#{#{Regexp.last_match(1)}}" }
|
88
114
|
end
|
89
115
|
|
90
116
|
def interpret_string_escapes(string)
|
@@ -97,25 +123,16 @@ module RuboCop
|
|
97
123
|
node1.loc.line == node2.loc.line
|
98
124
|
end
|
99
125
|
|
126
|
+
def indent(node)
|
127
|
+
' ' * node.loc.column
|
128
|
+
end
|
129
|
+
|
100
130
|
def to_supported_styles(enforced_style)
|
101
131
|
enforced_style
|
102
132
|
.sub(/^Enforced/, 'Supported')
|
103
133
|
.sub('Style', 'Styles')
|
104
134
|
end
|
105
135
|
|
106
|
-
def tokens(node)
|
107
|
-
@tokens ||= {}
|
108
|
-
return @tokens[node.object_id] if @tokens[node.object_id]
|
109
|
-
|
110
|
-
source_range = node.source_range
|
111
|
-
begin_pos = source_range.begin_pos
|
112
|
-
end_pos = source_range.end_pos
|
113
|
-
|
114
|
-
@tokens[node.object_id] = processed_source.tokens.select do |token|
|
115
|
-
token.end_pos <= end_pos && token.begin_pos >= begin_pos
|
116
|
-
end
|
117
|
-
end
|
118
|
-
|
119
136
|
private
|
120
137
|
|
121
138
|
def compatible_external_encoding_for?(src)
|
@@ -0,0 +1,135 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Utils
|
6
|
+
# Parses {Kernel#sprintf} format strings.
|
7
|
+
class FormatString
|
8
|
+
DIGIT_DOLLAR = /(\d+)\$/.freeze
|
9
|
+
FLAG = /[ #0+-]|#{DIGIT_DOLLAR}/.freeze
|
10
|
+
NUMBER_ARG = /\*#{DIGIT_DOLLAR}?/.freeze
|
11
|
+
NUMBER = /\d+|#{NUMBER_ARG}/.freeze
|
12
|
+
WIDTH = /(?<width>#{NUMBER})/.freeze
|
13
|
+
PRECISION = /\.(?<precision>#{NUMBER})/.freeze
|
14
|
+
TYPE = /(?<type>[bBdiouxXeEfgGaAcps])/.freeze
|
15
|
+
NAME = /<(?<name>\w+)>/.freeze
|
16
|
+
TEMPLATE_NAME = /\{(?<name>\w+)\}/.freeze
|
17
|
+
|
18
|
+
SEQUENCE = /
|
19
|
+
% (?<type>%)
|
20
|
+
| % (?<flags>#{FLAG}*)
|
21
|
+
(?:
|
22
|
+
(?: #{WIDTH}? #{PRECISION}? #{NAME}?
|
23
|
+
| #{WIDTH}? #{NAME} #{PRECISION}?
|
24
|
+
| #{NAME} (?<more_flags>#{FLAG}*) #{WIDTH}? #{PRECISION}?
|
25
|
+
) #{TYPE}
|
26
|
+
| #{WIDTH}? #{PRECISION}? #{TEMPLATE_NAME}
|
27
|
+
)
|
28
|
+
/x.freeze
|
29
|
+
|
30
|
+
# The syntax of a format sequence is as follows.
|
31
|
+
#
|
32
|
+
# ```
|
33
|
+
# %[flags][width][.precision]type
|
34
|
+
# ```
|
35
|
+
#
|
36
|
+
# A format sequence consists of a percent sign, followed by optional
|
37
|
+
# flags, width, and precision indicators, then terminated with a field
|
38
|
+
# type character.
|
39
|
+
#
|
40
|
+
# For more complex formatting, Ruby supports a reference by name.
|
41
|
+
#
|
42
|
+
# @see https://ruby-doc.org/core-2.6.3/Kernel.html#method-i-format
|
43
|
+
class FormatSequence
|
44
|
+
attr_reader :begin_pos, :end_pos, :flags, :width, :precision, :name, :type
|
45
|
+
|
46
|
+
def initialize(match)
|
47
|
+
@source = match[0]
|
48
|
+
@begin_pos = match.begin(0)
|
49
|
+
@end_pos = match.end(0)
|
50
|
+
@flags = match[:flags].to_s + match[:more_flags].to_s
|
51
|
+
@width = match[:width]
|
52
|
+
@precision = match[:precision]
|
53
|
+
@name = match[:name]
|
54
|
+
@type = match[:type]
|
55
|
+
end
|
56
|
+
|
57
|
+
def percent?
|
58
|
+
type == '%'
|
59
|
+
end
|
60
|
+
|
61
|
+
def annotated?
|
62
|
+
name && @source.include?('<')
|
63
|
+
end
|
64
|
+
|
65
|
+
def template?
|
66
|
+
name && @source.include?('{')
|
67
|
+
end
|
68
|
+
|
69
|
+
# Number of arguments required for the format sequence
|
70
|
+
def arity
|
71
|
+
@source.scan('*').count + 1
|
72
|
+
end
|
73
|
+
|
74
|
+
def max_digit_dollar_num
|
75
|
+
@source.scan(DIGIT_DOLLAR).map do |(digit_dollar_num)|
|
76
|
+
digit_dollar_num.to_i
|
77
|
+
end.max
|
78
|
+
end
|
79
|
+
|
80
|
+
def style
|
81
|
+
if annotated?
|
82
|
+
:annotated
|
83
|
+
elsif template?
|
84
|
+
:template
|
85
|
+
else
|
86
|
+
:unannotated
|
87
|
+
end
|
88
|
+
end
|
89
|
+
end
|
90
|
+
|
91
|
+
def initialize(string)
|
92
|
+
@source = string
|
93
|
+
end
|
94
|
+
|
95
|
+
def format_sequences
|
96
|
+
@format_sequences ||= parse
|
97
|
+
end
|
98
|
+
|
99
|
+
def valid?
|
100
|
+
!mixed_formats?
|
101
|
+
end
|
102
|
+
|
103
|
+
def named_interpolation?
|
104
|
+
format_sequences.any?(&:name)
|
105
|
+
end
|
106
|
+
|
107
|
+
def max_digit_dollar_num
|
108
|
+
format_sequences.map(&:max_digit_dollar_num).max
|
109
|
+
end
|
110
|
+
|
111
|
+
private
|
112
|
+
|
113
|
+
def parse
|
114
|
+
matches = []
|
115
|
+
@source.scan(SEQUENCE) { matches << FormatSequence.new(Regexp.last_match) }
|
116
|
+
matches
|
117
|
+
end
|
118
|
+
|
119
|
+
def mixed_formats?
|
120
|
+
formats = format_sequences.reject(&:percent?).map do |seq|
|
121
|
+
if seq.name
|
122
|
+
:named
|
123
|
+
elsif seq.max_digit_dollar_num
|
124
|
+
:numbered
|
125
|
+
else
|
126
|
+
:unnumbered
|
127
|
+
end
|
128
|
+
end
|
129
|
+
|
130
|
+
formats.uniq.size > 1
|
131
|
+
end
|
132
|
+
end
|
133
|
+
end
|
134
|
+
end
|
135
|
+
end
|
@@ -20,8 +20,6 @@ module RuboCop
|
|
20
20
|
nil
|
21
21
|
end
|
22
22
|
|
23
|
-
# rubocop:disable Metrics/BlockLength
|
24
|
-
|
25
23
|
# Abstract base class for branch classes.
|
26
24
|
# A branch represents a conditional branch in a scope.
|
27
25
|
#
|
@@ -42,13 +40,12 @@ module RuboCop
|
|
42
40
|
# do_something # no branch
|
43
41
|
# end
|
44
42
|
Base = Struct.new(:child_node, :scope) do
|
45
|
-
# rubocop:enable Metrics/BlockLength
|
46
|
-
|
47
43
|
def self.classes
|
48
44
|
@classes ||= []
|
49
45
|
end
|
50
46
|
|
51
47
|
def self.inherited(subclass)
|
48
|
+
super
|
52
49
|
classes << subclass
|
53
50
|
end
|
54
51
|
|
@@ -81,9 +78,7 @@ module RuboCop
|
|
81
78
|
end
|
82
79
|
|
83
80
|
def each_ancestor(include_self: false, &block)
|
84
|
-
unless
|
85
|
-
return to_enum(__method__, include_self: include_self)
|
86
|
-
end
|
81
|
+
return to_enum(__method__, include_self: include_self) unless block
|
87
82
|
|
88
83
|
yield self if include_self
|
89
84
|
scan_ancestors(&block)
|
@@ -16,6 +16,7 @@ module RuboCop
|
|
16
16
|
}.freeze
|
17
17
|
|
18
18
|
attr_reader :node, :variables, :naked_top_level
|
19
|
+
|
19
20
|
alias naked_top_level? naked_top_level
|
20
21
|
|
21
22
|
def initialize(node)
|
@@ -60,7 +61,7 @@ module RuboCop
|
|
60
61
|
end
|
61
62
|
|
62
63
|
def each_node(&block)
|
63
|
-
return to_enum(__method__) unless
|
64
|
+
return to_enum(__method__) unless block
|
64
65
|
|
65
66
|
yield node if naked_top_level?
|
66
67
|
scan_node(node, &block)
|
@@ -11,6 +11,7 @@ module RuboCop
|
|
11
11
|
|
12
12
|
attr_reader :name, :declaration_node, :scope,
|
13
13
|
:assignments, :references, :captured_by_block
|
14
|
+
|
14
15
|
alias captured_by_block? captured_by_block
|
15
16
|
|
16
17
|
def initialize(name, declaration_node, scope)
|
@@ -37,27 +38,38 @@ module RuboCop
|
|
37
38
|
!@references.empty?
|
38
39
|
end
|
39
40
|
|
40
|
-
# rubocop:disable Metrics/AbcSize
|
41
|
+
# rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
|
41
42
|
def reference!(node)
|
42
43
|
reference = Reference.new(node, @scope)
|
43
44
|
@references << reference
|
44
|
-
consumed_branches =
|
45
|
+
consumed_branches = nil
|
45
46
|
|
46
47
|
@assignments.reverse_each do |assignment|
|
47
|
-
next if consumed_branches
|
48
|
+
next if consumed_branches&.include?(assignment.branch)
|
48
49
|
|
49
|
-
unless assignment.run_exclusively_with?(reference)
|
50
|
-
|
51
|
-
|
50
|
+
assignment.reference!(node) unless assignment.run_exclusively_with?(reference)
|
51
|
+
|
52
|
+
# Modifier if/unless conditions are special. Assignments made in
|
53
|
+
# them do not put the assigned variable in scope to the left of the
|
54
|
+
# if/unless keyword. A preceding assignment is needed to put the
|
55
|
+
# variable in scope. For this reason we skip to the next assignment
|
56
|
+
# here.
|
57
|
+
next if in_modifier_if?(assignment)
|
52
58
|
|
53
59
|
break if !assignment.branch || assignment.branch == reference.branch
|
54
60
|
|
55
61
|
unless assignment.branch.may_run_incompletely?
|
56
|
-
consumed_branches << assignment.branch
|
62
|
+
(consumed_branches ||= Set.new) << assignment.branch
|
57
63
|
end
|
58
64
|
end
|
59
65
|
end
|
60
|
-
# rubocop:enable Metrics/AbcSize
|
66
|
+
# rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
|
67
|
+
|
68
|
+
def in_modifier_if?(assignment)
|
69
|
+
parent = assignment.node.parent
|
70
|
+
parent = parent.parent if parent&.begin_type?
|
71
|
+
parent&.if_type? && parent&.modifier_form?
|
72
|
+
end
|
61
73
|
|
62
74
|
def capture_with_block!
|
63
75
|
@captured_by_block = true
|