rubocop 0.22.0 → 0.23.0

data/lib/rubocop/file_inspector.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # This class handles the processing of files, which includes dealing with
   # formatters and letting cops inspect the files.
   class FileInspector
@@ -43,7 +43,7 @@ module Rubocop
       warn 'Errors are usually caused by RuboCop bugs.'
       warn 'Please, report your problems to RuboCop\'s issue tracker.'
       warn 'Mention the following information in the issue report:'
-      warn Rubocop::Version.version(true)
+      warn RuboCop::Version.version(true)
     end
 
     private
@@ -149,7 +149,7 @@ module Rubocop
     end
 
     def fail_level
-      @fail_level ||= Rubocop::Cop::Severity.new(
+      @fail_level ||= RuboCop::Cop::Severity.new(
         @options[:fail_level] || :refactor)
     end
   end

data/lib/rubocop/formatter/base_formatter.rb

@@ -1,15 +1,15 @@
 # encoding: utf-8
 
-# rubocop:disable LineLength, UnusedMethodArgument
+# rubocop:disable Style/LineLength, Lint/UnusedMethodArgument
 
-module Rubocop
+module RuboCop
   module Formatter
     # Abstract base class for formatter, implements all public API methods.
     #
     # ## Creating Custom Formatter
     #
     # You can create a custom formatter by subclassing
-    # `Rubocop::Formatter::BaseFormatter` and overriding some methods,
+    # `RuboCop::Formatter::BaseFormatter` and overriding some methods,
     # or by implementing all the methods by duck typing.
     #
     # ## Using Custom Formatter in Command Line
@@ -41,7 +41,7 @@ module Rubocop
     # * `#finished`
     #
     class BaseFormatter
-      # rubocop:enable LineLength
+      # rubocop:enable Style/LineLength
 
       # @api public
       #
@@ -93,12 +93,12 @@ module Rubocop
       # @param file [String]
       #   the file path
       #
-      # @param offenses [Array(Rubocop::Cop::Offense)]
+      # @param offenses [Array(RuboCop::Cop::Offense)]
       #   all detected offenses for the file
       #
       # @return [void]
       #
-      # @see Rubocop::Cop::Offense
+      # @see RuboCop::Cop::Offense
       def file_finished(file, offenses)
       end
 

data/lib/rubocop/formatter/clang_style_formatter.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter formats report data in clang style.
     # The precise location of the problem is shown together with the

data/lib/rubocop/formatter/colorizable.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This mix-in module provides string coloring methods for terminals.
     # It automatically disables coloring if coloring is disabled in the process

data/lib/rubocop/formatter/disabled_config_formatter.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter displays a YAML configuration file where all cops that
     # detected any offenses are configured to not detect the offense.
@@ -52,7 +52,7 @@ module Rubocop
           output.puts '# Cop supports --auto-correct.'
         end
 
-        default_cfg = Rubocop::ConfigLoader.default_configuration[cop_name]
+        default_cfg = RuboCop::ConfigLoader.default_configuration[cop_name]
         return unless default_cfg
 
         params = default_cfg.keys - %w(Description Enabled) - cfg.keys

data/lib/rubocop/formatter/disabled_lines_formatter.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Formatter
     # A basic formatter that displays the lines disabled
     # inline comments.

data/lib/rubocop/formatter/emacs_style_formatter.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter displays the report data in format that's
     # easy to process in the Emacs text editor.

data/lib/rubocop/formatter/file_list_formatter.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter displays just a list of the files with offenses in them,
     # separated by newlines. The output is machine-parsable.

data/lib/rubocop/formatter/formatter_set.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This is a collection of formatters. A FormatterSet can hold multiple
     # formatter instances and provides transparent formatter API methods

data/lib/rubocop/formatter/fuubar_style_formatter.rb

@@ -2,7 +2,7 @@
 
 require 'ruby-progressbar'
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter displays a progress bar and shows details of offenses as
     # soon as they are detected.

data/lib/rubocop/formatter/json_formatter.rb

@@ -3,7 +3,7 @@
 require 'json'
 require 'pathname'
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter formats the report data in JSON format.
     class JSONFormatter < BaseFormatter
@@ -36,7 +36,7 @@ module Rubocop
 
       def metadata_hash
         {
-          rubocop_version: Rubocop::Version::STRING,
+          rubocop_version: RuboCop::Version::STRING,
           ruby_engine:     RUBY_ENGINE,
           ruby_version:    RUBY_VERSION,
           ruby_patchlevel: RUBY_PATCHLEVEL.to_s,

data/lib/rubocop/formatter/offense_count_formatter.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter displays the list of offended cops with a count of how
     # many offenses of their kind were found. Ordered by desc offense count

data/lib/rubocop/formatter/progress_formatter.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module Formatter
     # This formatter display dots for files with no offenses and
     # letters for files with problems in the them. In the end it

data/lib/rubocop/formatter/simple_text_formatter.rb

@@ -2,7 +2,7 @@
 
 require 'rubocop/formatter/colorizable'
 
-module Rubocop
+module RuboCop
   module Formatter
     # A basic formatter that displays only files with offenses.
     # Offenses are displayed at compact form - just the

data/lib/rubocop/options.rb

@@ -2,7 +2,7 @@
 
 require 'optparse'
 
-module Rubocop
+module RuboCop
   # This module contains help texts for command line options.
   module OptionsHelp
     TEXT = {
@@ -66,7 +66,9 @@ module Rubocop
         opts.banner = 'Usage: rubocop [options] [file1, file2, ...]'
 
         option(opts, '--only [COP1,COP2,...]') do |list|
-          @options[:only] = list.split(',')
+          @options[:only] = list.split(',').map do |c|
+            Cop::Cop.qualified_cop_name(c, '--only option')
+          end
           validate_only_option
         end
 
@@ -116,8 +118,8 @@ module Rubocop
 
     def add_severity_option(opts)
       option(opts, '--fail-level SEVERITY',
-             Rubocop::Cop::Severity::NAMES,
-             Rubocop::Cop::Severity::CODE_TABLE) do |severity|
+             RuboCop::Cop::Severity::NAMES,
+             RuboCop::Cop::Severity::CODE_TABLE) do |severity|
         @options[:fail_level] = severity
       end
     end

data/lib/rubocop/path_util.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # Common methods and behaviors for dealing with paths.
   module PathUtil
     module_function

data/lib/rubocop/processed_source.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # ProcessedSource contains objects which are generated by Parser
   # and other information such as disabled lines for cops.
   # It also provides a convenient way to access source lines.

data/lib/rubocop/rake_task.rb

@@ -3,11 +3,11 @@
 require 'rake'
 require 'rake/tasklib'
 
-module Rubocop
+module RuboCop
   # Provides a custom rake task.
   #
   # require 'rubocop/rake_task'
-  # Rubocop::RakeTask.new
+  # RuboCop::RakeTask.new
   class RakeTask < Rake::TaskLib
     attr_accessor :name
     attr_accessor :verbose
@@ -70,7 +70,7 @@ module Rubocop
       @patterns = []
       @requires = []
       @options = []
-      @formatters = [Rubocop::Options::DEFAULT_FORMATTER]
+      @formatters = [RuboCop::Options::DEFAULT_FORMATTER]
     end
 
     def setup_subtasks(name)

data/lib/rubocop/source_parser.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # SourceParser provides a way to parse Ruby source with Parser gem
   # and also parses comment directives which disable arbitrary cops.
   module SourceParser
@@ -22,7 +22,7 @@ module Rubocop
 
       begin
         ast, comments, tokens = parser.tokenize(source_buffer)
-      rescue Parser::SyntaxError # rubocop:disable HandleExceptions
+      rescue Parser::SyntaxError # rubocop:disable Lint/HandleExceptions
         # All errors are in diagnostics. No need to handle exception.
       end
 

data/lib/rubocop/target_finder.rb

@@ -1,16 +1,12 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # This class finds target files to inspect by scanning the directory tree
   # and picking ruby files.
   class TargetFinder
     def initialize(config_store, options = {})
       @config_store = config_store
-      @options = {
-        force_exclusion: false,
-        debug: false,
-        fail_level: false
-      }.merge(options)
+      @options = options
     end
 
     def force_exclusion?

data/lib/rubocop/token.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # A basic wrapper around Parser's tokens.
   class Token
     attr_reader :pos, :type, :text

data/lib/rubocop/version.rb

@@ -1,9 +1,9 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.22.0'
+    STRING = '0.23.0'
 
     MSG = '%s (using Parser %s, running on %s %s %s)'
 

data/relnotes/v0.21.0.md

@@ -34,7 +34,7 @@ Below is the list of all the gory details. Enjoy!
 * [#976](https://github.com/bbatsov/rubocop/issues/976): Fix `EndAlignment` not handling element assignment correctly. ([@tamird][])
 * [#976](https://github.com/bbatsov/rubocop/issues/976): Fix `IndentationWidth` not handling element assignment correctly. ([@tamird][])
 * [#800](https://github.com/bbatsov/rubocop/issues/800): Do not report `[Corrected]` in `--auto-correct` mode if correction wasn't done. ([@jonas054][])
-* [#968](https://github.com/bbatsov/rubocop/issues/968): Fix bug when running Rubocop with `-c .rubocop.yml`. ([@bquorning][])
+* [#968](https://github.com/bbatsov/rubocop/issues/968): Fix bug when running RuboCop with `-c .rubocop.yml`. ([@bquorning][])
 * [#975](https://github.com/bbatsov/rubocop/pull/975): Fix infinite correction in `IndentationWidth`. ([@jonas054][])
 * [#986](https://github.com/bbatsov/rubocop/issues/986): When `--lint` is used together with `--only`, all lint cops are run in addition to the given cops. ([@jonas054][])
 * [#997](https://github.com/bbatsov/rubocop/issues/997): Fix handling of file paths for matching against `Exclude` property when `rubocop .` is called. ([@jonas054][])

data/relnotes/v0.23.0.md

@@ -0,0 +1,79 @@
+This release is mostly about fixing bugs, but it also features a few prominent changes:
+
+* Cops are now namespace aware, which would it make it simpler to write RuboCop extensions without
+worrying about name collisions (e.g. you can now have `Style/Filename` and `RSpec/Filename` cops).
+* There's now logic which prevents auto-corrections from generated invalid Ruby code.
+* The `Rubocop` module was renamed to `RuboCop`, which will affect packages relying on RuboCop's public API.
+
+Below is the list of all the gory details. Enjoy!
+
+
+### New features
+
+* [#1117](https://github.com/bbatsov/rubocop/issues/1117): `BlockComments` cop does auto-correction. ([@jonas054][])
+* [#1124](https://github.com/bbatsov/rubocop/pull/1124): `TrivialAccessors` cop auto-corrects class-level accessors. ([@ggilder][])
+* [#1062](https://github.com/bbatsov/rubocop/pull/1062): New cop `InlineComment` checks for inline comments. ([@salbertson][])
+* [#1118](https://github.com/bbatsov/rubocop/issues/1118): Add checking and auto-correction of right brackets in `IndentArray` and `IndentHash`. ([@jonas054][])
+
+### Changes
+
+* [#1097](https://github.com/bbatsov/rubocop/issues/1097): Add optional namespace prefix to cop names: `Style/LineLength` instead of `LineLength` in config files, `--only` argument, `--show-cops` output, and `# rubocop:disable`. ([@jonas054][])
+* [#1075](https://github.com/bbatsov/rubocop/issues/1075): More strict limits on when to require trailing comma. ([@jonas054][])
+* Renamed `Rubocop` module to `RuboCop`. ([@bbatsov][])
+
+### Bugs fixed
+
+* [#1126](https://github.com/bbatsov/rubocop/pull/1126): Fix `--auto-gen-config` bug with `RegexpLiteral` where only the last file's results would be used. ([@ggilder][])
+* [#1104](https://github.com/bbatsov/rubocop/issues/1104): Fix `EachWithObject` with modifier if as body. ([@geniou][])
+* [#1106](https://github.com/bbatsov/rubocop/issues/1106): Fix `EachWithObject` with single method call as body. ([@geniou][])
+* Avoid the warning about ignoring syck YAML engine from JRuby. ([@jonas054][])
+* [#1111](https://github.com/bbatsov/rubocop/issues/1111): Fix problem in `EndOfLine` with reading non-UTF-8 encoded files. ([@jonas054][])
+* [#1115](https://github.com/bbatsov/rubocop/issues/1115): Fix `Next` to ignore super nodes. ([@geniou][])
+* [#1117](https://github.com/bbatsov/rubocop/issues/1117): Don't auto-correct indentation in scopes that contain block comments (`=begin`..`=end`). ([@jonas054][])
+* [#1123](https://github.com/bbatsov/rubocop/pull/1123): Support setter calls in safe assignment in `ParenthesesAroundCondition`. ([@jonas054][])
+* [#1090](https://github.com/bbatsov/rubocop/issues/1090): Correct handling of documentation vs annotation comment. ([@jonas054][])
+* [#1118](https://github.com/bbatsov/rubocop/issues/1118): Never write invalid ruby to a file in auto-correct. ([@jonas054][])
+* [#1120](https://github.com/bbatsov/rubocop/issues/1120): Don't change indentation of heredoc strings in auto-correct. ([@jonas054][])
+* [#1109](https://github.com/bbatsov/rubocop/issues/1109): Handle conditions with modifier ops in them in `ParenthesesAroundCondition`. ([@bbatsov][])
+
+[@bbatsov]: https://github.com/bbatsov
+[@jonas054]: https://github.com/jonas054
+[@yujinakayama]: https://github.com/yujinakayama
+[@dblock]: https://github.com/dblock
+[@nevir]: https://github.com/nevir
+[@daviddavis]: https://github.com/daviddavis
+[@sds]: https://github.com/sds
+[@fancyremarker]: https://github.com/fancyremarker
+[@sinisterchipmunk]: https://github.com/sinisterchipmunk
+[@vonTronje]: https://github.com/vonTronje
+[@agrimm]: https://github.com/agrimm
+[@pmenglund]: https://github.com/pmenglund
+[@chulkilee]: https://github.com/chulkilee
+[@codez]: https://github.com/codez
+[@emou]: https://github.com/emou
+[@skanev]: http://github.com/skanev
+[@claco]: http://github.com/claco
+[@rifraf]: http://github.com/rifraf
+[@scottmatthewman]: https://github.com/scottmatthewman
+[@ma2gedev]: http://github.com/ma2gedev
+[@jeremyolliver]: https://github.com/jeremyolliver
+[@hannestyden]: https://github.com/hannestyden
+[@geniou]: https://github.com/geniou
+[@jkogara]: https://github.com/jkogara
+[@tmorris-fiksu]: https://github.com/tmorris-fiksu
+[@mockdeep]: https://github.com/mockdeep
+[@hiroponz]: https://github.com/hiroponz
+[@tamird]: https://github.com/tamird
+[@fshowalter]: https://github.com/fshowalter
+[@cschramm]: https://github.com/cschramm
+[@bquorning]: https://github.com/bquorning
+[@bcobb]: https://github.com/bcobb
+[@irrationalfab]: https://github.com/irrationalfab
+[@tommeier]: https://github.com/tommeier
+[@sfeldon]: https://github.com/sfeldon
+[@biinari]: https://github.com/biinari
+[@barunio]: https://github.com/barunio
+[@molawson]: https://github.com/molawson
+[@wndhydrnt]: https://github.com/wndhydrnt
+[@ggilder]: https://github.com/ggilder
+[@salbertson]: https://github.com/salbertson

data/rubocop.gemspec

@@ -6,7 +6,7 @@ require 'English'
 
 Gem::Specification.new do |s|
   s.name = 'rubocop'
-  s.version = Rubocop::Version::STRING
+  s.version = RuboCop::Version::STRING
   s.platform = Gem::Platform::RUBY
   s.required_ruby_version = '>= 1.9.2'
   s.authors = ['Bozhidar Batsov']

data/spec/.rubocop.yml

@@ -1,5 +1,5 @@
 inherit_from: ../.rubocop.yml
 
 # The documentation check doesn't make sense for test code
-Documentation:
+Style/Documentation:
   Enabled: false

data/spec/isolated_environment_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe 'isolated environment', :isolated_environment do
   include FileHelper
 
-  let(:cli) { Rubocop::CLI.new }
+  let(:cli) { RuboCop::CLI.new }
 
   before(:each) { $stdout = StringIO.new }
   after(:each) { $stdout = STDOUT }

data/spec/project_spec.rb

@@ -4,10 +4,10 @@ require 'spec_helper'
 
 describe 'RuboCop Project' do
   describe 'default configuration file' do
-    let(:cop_names) { Rubocop::Cop::Cop.all.map(&:cop_name) }
+    let(:cop_names) { RuboCop::Cop::Cop.all.map(&:cop_name) }
 
     subject(:default_config) do
-      Rubocop::ConfigLoader.load_file('config/default.yml')
+      RuboCop::ConfigLoader.load_file('config/default.yml')
     end
 
     it 'has configuration for all cops' do
@@ -76,7 +76,7 @@ describe 'RuboCop Project' do
         it 'has a valid URL' do
           issues.each do |issue|
             number = issue[:number].gsub(/\D/, '')
-            pattern = %r{^https://github\.com/bbatsov/rubocop/(?:issues|pull)/#{number}$} # rubocop:disable LineLength
+            pattern = %r{^https://github\.com/bbatsov/rubocop/(?:issues|pull)/#{number}$} # rubocop:disable Style/LineLength
             expect(issue[:url]).to match(pattern)
           end
         end