RubyGems - rubocop - Versions diffs - 0.22.0 → 0.23.0 - Mend

rubocop 0.22.0 → 0.23.0

Potentially problematic release.

This version of rubocop might be problematic. Click here for more details.

Files changed (484) hide show

data/lib/rubocop/cop/style/method_def_parentheses.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cops checks for parentheses around the arguments in method

data/lib/rubocop/cop/style/method_length.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks if the length a method exceeds some maximum value.

data/lib/rubocop/cop/style/method_name.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop makes sure that all methods use the configured style,

data/lib/rubocop/cop/style/module_function.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cops checks for use of `extend self` in a module.

data/lib/rubocop/cop/style/multiline_block_chain.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for chaining of a block after another block that spans

data/lib/rubocop/cop/style/multiline_if_then.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for uses of the `then` keyword in multi-line if statements.

data/lib/rubocop/cop/style/multiline_ternary_operator.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for multi-line ternary op expressions.

data/lib/rubocop/cop/style/negated_if.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for uses of if with a negated condition. Only ifs

data/lib/rubocop/cop/style/negated_while.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for uses of while with a negated condition.

data/lib/rubocop/cop/style/nested_ternary_operator.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for nested ternary op expressions.

data/lib/rubocop/cop/style/next.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Use `next` to skip iteration instead of a condition at the end.
@@ -29,6 +29,7 @@ module Rubocop
         def on_block(node)
           method, _, body = *node
+          return unless method.type == :send
           return if body.nil?
           _, method_name = *method

data/lib/rubocop/cop/style/nil_comparison.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for comparison of something with nil using ==.

data/lib/rubocop/cop/style/non_nil_check.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for non-nil checks, which are usually redundant.

data/lib/rubocop/cop/style/not.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses if the keyword *not* instead of !.

data/lib/rubocop/cop/style/numeric_literals.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for big numeric literals without _ between groups

data/lib/rubocop/cop/style/one_line_conditional.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # TODO: Make configurable.

data/lib/rubocop/cop/style/op_method.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop makes sure that certain operator methods have their sole

data/lib/rubocop/cop/style/parameter_lists.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for methods with too many parameters.

data/lib/rubocop/cop/style/parentheses_around_condition.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for the presence of superfluous parentheses around the
@@ -28,6 +28,9 @@ module Rubocop
           cond, _body = *node
           return unless cond.type == :begin
+          # handle `if (something rescue something_else) ...`
+          return if modifier_op?(cond.children.first)
+          # check if there's any whitespace between the keyword and the cond
           return if parens_required?(node)
           # allow safe assignment
           return if safe_assignment?(cond) && safe_assignment_allowed?
@@ -35,6 +38,13 @@ module Rubocop
           add_offense(cond, :expression, message(node))
         end
+        def modifier_op?(node)
+          return true if node.type == :rescue
+          [:if, :while, :until].include?(node.type) &&
+            node.loc.end.nil?
+        end
         def parens_required?(node)
           exp = node.loc.expression
           kw = node.loc.keyword

data/lib/rubocop/cop/style/percent_literal_delimiters.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop enforces the consistent usage of `%`-literal delimiters.

data/lib/rubocop/cop/style/perl_backrefs.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop looks for uses of Perl-style regexp match

data/lib/rubocop/cop/style/predicate_name.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop makes sure that predicates are named properly.

data/lib/rubocop/cop/style/proc.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cops checks for uses of Proc.new where Kernel#proc

data/lib/rubocop/cop/style/raise_args.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks the args passed to `fail` and `raise`.

data/lib/rubocop/cop/style/redundant_begin.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for redundant `begin` blocks.

data/lib/rubocop/cop/style/redundant_exception.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for RuntimeError as the argument of raise/fail.

data/lib/rubocop/cop/style/redundant_return.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for redundant `return` expressions.

data/lib/rubocop/cop/style/redundant_self.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for redundant uses of `self`.

data/lib/rubocop/cop/style/regexp_literal.rb CHANGED

@@ -1,12 +1,16 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for regexp literals and reports offenses based
       # on how many escaped slashes there are in the regexp and on the
       # value of the configuration parameter MaxSlashes.
       class RegexpLiteral < Cop
+        class << self
+          attr_accessor :slash_count
+        end
         def on_regexp(node)
           string_parts = node.children.select { |child| child.type == :str }
           total_string = string_parts.map { |s| s.loc.expression.source }.join
@@ -35,15 +39,19 @@ module Rubocop
         end
         def configure_max(delimiter_start, value)
-          @slash_count ||= { '/' => Set.new([0]), '%' => Set.new([100_000]) }
-          @slash_count[delimiter_start].add(value)
+          self.class.slash_count ||= {
+            '/' => Set.new([0]),
+            '%' => Set.new([100_000])
+          }
+          self.class.slash_count[delimiter_start].add(value)
           # To avoid reports, MaxSlashes must be set equal to the highest
           # number of slashes used within //, and also one less than the
           # highest number of slashes used within %r{}. If no value can satisfy
           # both requirements, just disable.
-          max = @slash_count['/'].max
-          min = @slash_count['%'].min
+          max = self.class.slash_count['/'].max
+          min = self.class.slash_count['%'].min
           self.config_to_allow_offenses = if max > max_slashes
                                             if max < min

data/lib/rubocop/cop/style/rescue_modifier.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of rescue in its modifier form.

data/lib/rubocop/cop/style/self_assignment.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop enforces the use the shorthand for self-assignment.

data/lib/rubocop/cop/style/semicolon.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for multiple expressions placed on the same line.

data/lib/rubocop/cop/style/signal_exception.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of `fail` and `raise`.

data/lib/rubocop/cop/style/single_line_block_params.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks whether the block parameters of a single-line

data/lib/rubocop/cop/style/single_line_methods.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for single-line method definitions.

data/lib/rubocop/cop/style/single_space_before_first_arg.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks that exactly one space is used between a method name and the

data/lib/rubocop/cop/style/space_after_colon.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for colon (:) not followed by some kind of space.

data/lib/rubocop/cop/style/space_after_comma.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for comma (,) not followed by some kind of space.

data/lib/rubocop/cop/style/space_after_control_keyword.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for various control keywords missing a space after them.

data/lib/rubocop/cop/style/space_after_method_name.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for space between a method name and a left parenthesis in defs.

data/lib/rubocop/cop/style/space_after_not.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for space after `!`.

data/lib/rubocop/cop/style/space_after_semicolon.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for semicolon (;) not followed by some kind of space.

data/lib/rubocop/cop/style/space_around_equals_in_parameter_default.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks that the equals signs in parameter default assignments