RubyGems - rubocop - Versions diffs - 0.22.0 → 0.23.0 - Mend

rubocop 0.22.0 → 0.23.0

Potentially problematic release.

This version of rubocop might be problematic. Click here for more details.

Files changed (484) hide show

data/spec/rubocop/cop/lint/void_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Lint::Void do
+describe RuboCop::Cop::Lint::Void do
   subject(:cop) { described_class.new }
   described_class::OPS.each do |op|

data/spec/rubocop/cop/offense_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Offense do
+describe RuboCop::Cop::Offense do
   let(:location) do
     source_buffer = Parser::Source::Buffer.new('test', 1)
     source_buffer.source = "a\n"
@@ -108,7 +108,7 @@ describe Rubocop::Cop::Offense do
     end
     # We want a nice table layout, so we allow space inside empty hashes.
-    # rubocop:disable SpaceInsideHashLiteralBraces
+    # rubocop:disable Style/SpaceInsideHashLiteralBraces
     [
       [{                           }, {                           }, 0],

data/spec/rubocop/cop/rails/action_filter_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::ActionFilter, :config do
+describe RuboCop::Cop::Rails::ActionFilter, :config do
   subject(:cop) { described_class.new(config) }
   context 'when style is action' do

data/spec/rubocop/cop/rails/default_scope_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::DefaultScope do
+describe RuboCop::Cop::Rails::DefaultScope do
   subject(:cop) { described_class.new }
   it 'registers an offense for default scope with a lambda arg' do

data/spec/rubocop/cop/rails/delegate_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::Delegate do
+describe RuboCop::Cop::Rails::Delegate do
   subject(:cop) { described_class.new }
   it 'finds trivial delegate' do

data/spec/rubocop/cop/rails/has_and_belongs_to_many_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::HasAndBelongsToMany do
+describe RuboCop::Cop::Rails::HasAndBelongsToMany do
   subject(:cop) { described_class.new }
   it 'registers an offense for has_and_belongs_to_many' do

data/spec/rubocop/cop/rails/output_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::Output do
+describe RuboCop::Cop::Rails::Output do
   subject(:cop) { described_class.new }
   it 'records an offense for puts statements' do

data/spec/rubocop/cop/rails/read_write_attribute_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::ReadWriteAttribute do
+describe RuboCop::Cop::Rails::ReadWriteAttribute do
   subject(:cop) { described_class.new }
   it 'registers an offense for read_attribute' do

data/spec/rubocop/cop/rails/scope_args_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::ScopeArgs do
+describe RuboCop::Cop::Rails::ScopeArgs do
   subject(:cop) { described_class.new }
   it 'registers an offense a scope with a method arg' do

data/spec/rubocop/cop/rails/validation_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Rails::Validation do
+describe RuboCop::Cop::Rails::Validation do
   subject(:cop) { described_class.new }
   described_class::BLACKLIST.each do |validation|

data/spec/rubocop/cop/severity_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Severity do
+describe RuboCop::Cop::Severity do
   let(:refactor) { described_class.new(:refactor) }
   let(:convention) { described_class.new(:convention) }
   let(:warning) { described_class.new(:warning) }

data/spec/rubocop/cop/style/access_modifier_indentation_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AccessModifierIndentation, :config do
+describe RuboCop::Cop::Style::AccessModifierIndentation, :config do
   subject(:cop) { described_class.new(config) }
   context 'when EnforcedStyle is set to indent' do

data/spec/rubocop/cop/style/accessor_method_name_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AccessorMethodName do
+describe RuboCop::Cop::Style::AccessorMethodName do
   subject(:cop) { described_class.new }
   it 'registers an offense for method get_... with no args' do

data/spec/rubocop/cop/style/alias_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Alias do
+describe RuboCop::Cop::Style::Alias do
   subject(:cop) { described_class.new }
   it 'registers an offense for alias with symbol args' do

data/spec/rubocop/cop/style/align_array_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AlignArray do
+describe RuboCop::Cop::Style::AlignArray do
   subject(:cop) { described_class.new }
   it 'registers an offense for misaligned array elements' do
@@ -88,4 +88,36 @@ describe Rubocop::Cop::Style::AlignArray do
     new_source = autocorrect_source(cop, original_source)
     expect(new_source).to eq(original_source.join("\n"))
   end
+  it 'does not indent heredoc strings in autocorrect' do
+    original_source = ['var = [',
+                       "       { :type => 'something',",
+                       '         :sql => <<EOF',
+                       'Select something',
+                       'from atable',
+                       'EOF',
+                       '       },',
+                       "      { :type => 'something',",
+                       '        :sql => <<EOF',
+                       'Select something',
+                       'from atable',
+                       'EOF',
+                       '      }',
+                       ']']
+    new_source = autocorrect_source(cop, original_source)
+    expect(new_source).to eq(['var = [',
+                              "       { :type => 'something',",
+                              '         :sql => <<EOF',
+                              'Select something',
+                              'from atable',
+                              'EOF',
+                              '       },',
+                              "       { :type => 'something',",
+                              '         :sql => <<EOF',
+                              'Select something',
+                              'from atable',
+                              'EOF',
+                              '       }',
+                              ']'].join("\n"))
+  end
 end

data/spec/rubocop/cop/style/align_hash_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AlignHash, :config do
+describe RuboCop::Cop::Style::AlignHash, :config do
   subject(:cop) { described_class.new(config) }
   shared_examples 'not on separate lines' do

data/spec/rubocop/cop/style/align_parameters_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AlignParameters, :config do
+describe RuboCop::Cop::Style::AlignParameters, :config do
   subject(:cop) { described_class.new(config) }
   context 'aligned with first parameter' do

data/spec/rubocop/cop/style/and_or_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AndOr do
+describe RuboCop::Cop::Style::AndOr do
   subject(:cop) { described_class.new }
   it 'registers an offense for OR' do

data/spec/rubocop/cop/style/array_join_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ArrayJoin do
+describe RuboCop::Cop::Style::ArrayJoin do
   subject(:cop) { described_class.new }
   it 'registers an offense for an array followed by string' do

data/spec/rubocop/cop/style/ascii_comments_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AsciiComments do
+describe RuboCop::Cop::Style::AsciiComments do
   subject(:cop) { described_class.new }
   it 'registers an offense for a comment with non-ascii chars' do

data/spec/rubocop/cop/style/ascii_identifiers_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::AsciiIdentifiers do
+describe RuboCop::Cop::Style::AsciiIdentifiers do
   subject(:cop) { described_class.new }
   it 'registers an offense for a variable name with non-ascii chars' do

data/spec/rubocop/cop/style/attr_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Attr do
+describe RuboCop::Cop::Style::Attr do
   subject(:cop) { described_class.new }
   it 'registers an offense attr' do

data/spec/rubocop/cop/style/begin_block_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::BeginBlock do
+describe RuboCop::Cop::Style::BeginBlock do
   subject(:cop) { described_class.new }
   it 'reports an offense for a BEGIN block' do

data/spec/rubocop/cop/style/block_comments_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::BlockComments do
+describe RuboCop::Cop::Style::BlockComments do
   subject(:cop) { described_class.new }
   it 'registers an offense for block comments' do
@@ -18,4 +18,28 @@ describe Rubocop::Cop::Style::BlockComments do
                    ['# comment'])
     expect(cop.offenses).to be_empty
   end
+  it 'auto-corrects a block comment into a regular comment' do
+    new_source = autocorrect_source(cop, ['=begin',
+                                          'comment line 1',
+                                          '',
+                                          'comment line 2',
+                                          '=end',
+                                          'def foo',
+                                          'end'])
+    expect(new_source).to eq(['# comment line 1',
+                              '#',
+                              '# comment line 2',
+                              'def foo',
+                              'end'].join("\n"))
+  end
+  it 'auto-corrects an empty block comment by removing it' do
+    new_source = autocorrect_source(cop, ['=begin',
+                                          '=end',
+                                          'def foo',
+                                          'end'])
+    expect(new_source).to eq(['def foo',
+                              'end'].join("\n"))
+  end
 end

data/spec/rubocop/cop/style/block_nesting_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::BlockNesting, :config do
+describe RuboCop::Cop::Style::BlockNesting, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'Max' => 2 } }

data/spec/rubocop/cop/style/blocks_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Blocks do
+describe RuboCop::Cop::Style::Blocks do
   subject(:cop) { described_class.new }
   it 'accepts a multiline block with do-end' do

data/spec/rubocop/cop/style/braces_around_hash_parameters_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::BracesAroundHashParameters, :config do
+describe RuboCop::Cop::Style::BracesAroundHashParameters, :config do
   subject(:cop) { described_class.new(config) }
   context 'no_braces' do

data/spec/rubocop/cop/style/case_equality_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::CaseEquality do
+describe RuboCop::Cop::Style::CaseEquality do
   subject(:cop) { described_class.new }
   it 'registers an offense for ===' do

data/spec/rubocop/cop/style/case_indentation_spec.rb CHANGED

@@ -2,12 +2,12 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::CaseIndentation do
+describe RuboCop::Cop::Style::CaseIndentation do
   subject(:cop) { described_class.new(config) }
   let(:config) do
-    merged = Rubocop::ConfigLoader
-      .default_configuration['CaseIndentation'].merge(cop_config)
-    Rubocop::Config.new('CaseIndentation' => merged)
+    merged = RuboCop::ConfigLoader
+      .default_configuration['Style/CaseIndentation'].merge(cop_config)
+    RuboCop::Config.new('Style/CaseIndentation' => merged)
   end
   context 'with IndentWhenRelativeTo: case' do

data/spec/rubocop/cop/style/character_literal_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::CharacterLiteral do
+describe RuboCop::Cop::Style::CharacterLiteral do
   subject(:cop) { described_class.new }
   it 'registers an offense for character literals' do

data/spec/rubocop/cop/style/class_and_module_camel_case_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ClassAndModuleCamelCase do
+describe RuboCop::Cop::Style::ClassAndModuleCamelCase do
   subject(:cop) { described_class.new }
   it 'registers an offense for underscore in class and module name' do

data/spec/rubocop/cop/style/class_and_module_children_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ClassAndModuleChildren, :config do
+describe RuboCop::Cop::Style::ClassAndModuleChildren, :config do
   subject(:cop) { described_class.new(config) }
   context 'nested style' do

data/spec/rubocop/cop/style/class_length_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ClassLength, :config do
+describe RuboCop::Cop::Style::ClassLength, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'Max' => 5, 'CountComments' => false } }

data/spec/rubocop/cop/style/class_methods_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ClassMethods do
+describe RuboCop::Cop::Style::ClassMethods do
   subject(:cop) { described_class.new }
   it 'registers an offense for methods using a class name' do

data/spec/rubocop/cop/style/class_vars_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ClassVars do
+describe RuboCop::Cop::Style::ClassVars do
   subject(:cop) { described_class.new }
   it 'registers an offense for class variable declaration' do

data/spec/rubocop/cop/style/collection_methods_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::CollectionMethods, :config do
+describe RuboCop::Cop::Style::CollectionMethods, :config do
   cop_config = {
     'PreferredMethods' => {
       'collect' => 'map',

data/spec/rubocop/cop/style/colon_method_call_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ColonMethodCall do
+describe RuboCop::Cop::Style::ColonMethodCall do
   subject(:cop) { described_class.new }
   it 'registers an offense for instance method call' do