RubyGems - rubocop - Versions diffs - 0.22.0 → 0.23.0 - Mend

rubocop 0.22.0 → 0.23.0

Potentially problematic release.

This version of rubocop might be problematic. Click here for more details.

Files changed (484) hide show

data/spec/rubocop/cop/style/method_length_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::MethodLength, :config do
+describe RuboCop::Cop::Style::MethodLength, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'Max' => 5, 'CountComments' => false } }

data/spec/rubocop/cop/style/method_name_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::MethodName, :config do
+describe RuboCop::Cop::Style::MethodName, :config do
   subject(:cop) { described_class.new(config) }
   shared_examples 'never accepted' do

data/spec/rubocop/cop/style/module_function_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ModuleFunction do
+describe RuboCop::Cop::Style::ModuleFunction do
   subject(:cop) { described_class.new }
   it 'registers an offense for extend self in module' do

data/spec/rubocop/cop/style/multiline_block_chain_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::MultilineBlockChain do
+describe RuboCop::Cop::Style::MultilineBlockChain do
   subject(:cop) { described_class.new }
   context 'with multi-line block chaining' do

data/spec/rubocop/cop/style/multiline_if_then_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::MultilineIfThen do
+describe RuboCop::Cop::Style::MultilineIfThen do
   subject(:cop) { described_class.new }
   # if

data/spec/rubocop/cop/style/multiline_ternary_operator_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::MultilineTernaryOperator do
+describe RuboCop::Cop::Style::MultilineTernaryOperator do
   subject(:cop) { described_class.new }
   it 'registers offense for a multiline ternary operator expression' do

data/spec/rubocop/cop/style/negated_if_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::NegatedIf do
+describe RuboCop::Cop::Style::NegatedIf do
   subject(:cop) { described_class.new }
   it 'registers an offense for if with exclamation point condition' do

data/spec/rubocop/cop/style/negated_while_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::NegatedWhile do
+describe RuboCop::Cop::Style::NegatedWhile do
   subject(:cop) { described_class.new }
   it 'registers an offense for while with exclamation point condition' do

data/spec/rubocop/cop/style/nested_ternary_operator_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::NestedTernaryOperator do
+describe RuboCop::Cop::Style::NestedTernaryOperator do
   subject(:cop) { described_class.new }
   it 'registers an offense for a nested ternary operator expression' do

data/spec/rubocop/cop/style/next_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Next, :config do
+describe RuboCop::Cop::Style::Next, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { {} }
@@ -207,4 +207,13 @@ describe Rubocop::Cop::Style::Next, :config do
     expect(cop.offenses.size).to eq(0)
   end
+  # https://github.com/bbatsov/rubocop/issues/1115
+  it 'ignores super nodes' do
+    inspect_source(cop,
+                   ['def foo',
+                    '  super(a, a) { a }',
+                    'end'])
+    expect(cop.offenses.size).to eq(0)
+  end
 end

data/spec/rubocop/cop/style/nil_comparison_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::NilComparison do
+describe RuboCop::Cop::Style::NilComparison do
   subject(:cop) { described_class.new }
   it 'registers an offense for == nil' do

data/spec/rubocop/cop/style/non_nil_check_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::NonNilCheck, :config do
+describe RuboCop::Cop::Style::NonNilCheck, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) do

data/spec/rubocop/cop/style/not_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Not do
+describe RuboCop::Cop::Style::Not do
   subject(:cop) { described_class.new }
   it 'registers an offense for not' do

data/spec/rubocop/cop/style/numeric_literals_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::NumericLiterals, :config do
+describe RuboCop::Cop::Style::NumericLiterals, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'MinDigits' => 5 } }

data/spec/rubocop/cop/style/one_line_conditional_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::OneLineConditional do
+describe RuboCop::Cop::Style::OneLineConditional do
   subject(:cop) { described_class.new }
   it 'registers an offense for one line if/then/end' do

data/spec/rubocop/cop/style/op_method_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::OpMethod do
+describe RuboCop::Cop::Style::OpMethod do
   subject(:cop) { described_class.new }
   it 'registers an offense for arg not named other' do

data/spec/rubocop/cop/style/parameter_lists_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ParameterLists, :config do
+describe RuboCop::Cop::Style::ParameterLists, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) do
     {

data/spec/rubocop/cop/style/parentheses_around_condition_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::ParenthesesAroundCondition, :config do
+describe RuboCop::Cop::Style::ParenthesesAroundCondition, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'AllowSafeAssignment' => true } }
@@ -98,6 +98,14 @@ describe Rubocop::Cop::Style::ParenthesesAroundCondition, :config do
     expect(cop.offenses).to be_empty
   end
+  %w(rescue if unless while until).each do |op|
+    it "allows parens if the condition node is a modifier #{op} op" do
+      inspect_source(cop, ["if (something #{op} top)",
+                           'end'])
+      expect(cop.offenses).to be_empty
+    end
+  end
   context 'safe assignment is allowed' do
     it 'accepts = in condition surrounded with parentheses' do
       inspect_source(cop,
@@ -107,6 +115,13 @@ describe Rubocop::Cop::Style::ParenthesesAroundCondition, :config do
       expect(cop.offenses).to be_empty
     end
+    it 'accepts setter in condition surrounded with parentheses' do
+      inspect_source(cop,
+                     ['if (self.test = 10)',
+                      'end'
+                     ])
+      expect(cop.offenses).to be_empty
+    end
   end
   context 'safe assignment is not allowed' do

data/spec/rubocop/cop/style/percent_literal_delimiters_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::PercentLiteralDelimiters, :config do
+describe RuboCop::Cop::Style::PercentLiteralDelimiters, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) do

data/spec/rubocop/cop/style/perl_backrefs_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::PerlBackrefs do
+describe RuboCop::Cop::Style::PerlBackrefs do
   subject(:cop) { described_class.new }
   it 'registers an offense for $1' do

data/spec/rubocop/cop/style/predicate_name_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::PredicateName, :config do
+describe RuboCop::Cop::Style::PredicateName, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'NamePrefixBlacklist' => %w(has_ is_) } }

data/spec/rubocop/cop/style/proc_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Proc do
+describe RuboCop::Cop::Style::Proc do
   subject(:cop) { described_class.new }
   it 'registers an offense for a Proc.new call' do

data/spec/rubocop/cop/style/raise_args_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RaiseArgs, :config do
+describe RuboCop::Cop::Style::RaiseArgs, :config do
   subject(:cop) { described_class.new(config) }
   context 'when enforced style is compact' do

data/spec/rubocop/cop/style/redundant_begin_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RedundantBegin do
+describe RuboCop::Cop::Style::RedundantBegin do
   subject(:cop) { described_class.new }
   it 'reports an offense for single line def with redundant begin block' do

data/spec/rubocop/cop/style/redundant_exception_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RedundantException do
+describe RuboCop::Cop::Style::RedundantException do
   subject(:cop) { described_class.new }
   it 'reports an offense for a raise with RuntimeError' do

data/spec/rubocop/cop/style/redundant_return_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RedundantReturn, :config do
+describe RuboCop::Cop::Style::RedundantReturn, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'AllowMultipleReturnValues' => false } }

data/spec/rubocop/cop/style/redundant_self_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RedundantSelf do
+describe RuboCop::Cop::Style::RedundantSelf do
   subject(:cop) { described_class.new }
   it 'reports an offense a self receiver on an rvalue' do

data/spec/rubocop/cop/style/regexp_literal_spec.rb CHANGED

@@ -2,9 +2,11 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RegexpLiteral, :config do
+describe RuboCop::Cop::Style::RegexpLiteral, :config do
   subject(:cop) { described_class.new(config) }
+  before { described_class.slash_count = nil }
   context 'when MaxSlashes is -1' do
     let(:cop_config) { { 'MaxSlashes' => -1 } }
@@ -171,4 +173,16 @@ describe Rubocop::Cop::Style::RegexpLiteral, :config do
       end
     end
   end
+  context 'across multiple files (instances)' do
+    let(:cop_config) { { 'MaxSlashes' => 0 } }
+    it 'preserves slash count for --auto-gen-config' do
+      2.times do |i|
+        cop = described_class.new(config, auto_gen_config: true)
+        inspect_source(cop, "/http:#{'\/' * (i + 1)}/")
+      end
+      expect(described_class.slash_count['/']).to eq(Set.new([0, 1, 2]))
+    end
+  end
 end

data/spec/rubocop/cop/style/rescue_modifier_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::RescueModifier do
+describe RuboCop::Cop::Style::RescueModifier do
   subject(:cop) { described_class.new }
   it 'registers an offense for modifier rescue' do

data/spec/rubocop/cop/style/self_assignment_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SelfAssignment do
+describe RuboCop::Cop::Style::SelfAssignment do
   subject(:cop) { described_class.new }
   [:+, :-, :*, :**, :/, :|, :&].product(['x', '@x', '@@x']).each do |op, var|

data/spec/rubocop/cop/style/semicolon_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::Semicolon, :config do
+describe RuboCop::Cop::Style::Semicolon, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'AllowAsExpressionSeparator' => false } }

data/spec/rubocop/cop/style/signal_exception_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SignalException, :config do
+describe RuboCop::Cop::Style::SignalException, :config do
   subject(:cop) { described_class.new(config) }
   context 'when enforced style is `semantic`' do

data/spec/rubocop/cop/style/single_line_block_params_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SingleLineBlockParams, :config do
+describe RuboCop::Cop::Style::SingleLineBlockParams, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) do
     { 'Methods' =>

data/spec/rubocop/cop/style/single_line_methods_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SingleLineMethods, :config do
+describe RuboCop::Cop::Style::SingleLineMethods, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'AllowIfMethodIsEmpty' => true } }

data/spec/rubocop/cop/style/single_space_before_first_arg_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SingleSpaceBeforeFirstArg do
+describe RuboCop::Cop::Style::SingleSpaceBeforeFirstArg do
   subject(:cop) { described_class.new }
   context 'for method calls without parentheses' do

data/spec/rubocop/cop/style/space_after_colon_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SpaceAfterColon do
+describe RuboCop::Cop::Style::SpaceAfterColon do
   subject(:cop) { described_class.new }
   it 'registers an offense for colon without space after it' do

data/spec/rubocop/cop/style/space_after_comma_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SpaceAfterComma do
+describe RuboCop::Cop::Style::SpaceAfterComma do
   subject(:cop) { described_class.new }
   it 'registers an offense for block argument commas without space' do

data/spec/rubocop/cop/style/space_after_control_keyword_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SpaceAfterControlKeyword do
+describe RuboCop::Cop::Style::SpaceAfterControlKeyword do
   subject(:cop) { described_class.new }
   it 'registers an offense for normal if' do

data/spec/rubocop/cop/style/space_after_method_name_spec.rb CHANGED

@@ -2,7 +2,7 @@
 require 'spec_helper'
-describe Rubocop::Cop::Style::SpaceAfterMethodName do
+describe RuboCop::Cop::Style::SpaceAfterMethodName do
   subject(:cop) { described_class.new }
   it 'registers an offense for def with space before the parenthesis' do