RubyGems - rubocop - Versions diffs - 0.22.0 → 0.23.0 - Mend

rubocop 0.22.0 → 0.23.0

Potentially problematic release.

This version of rubocop might be problematic. Click here for more details.

Files changed (484) hide show

data/lib/rubocop/cop/rails/read_write_attribute.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Rails
       # This cop checks for the use of the read_attribute or

data/lib/rubocop/cop/rails/scope_args.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Rails
       # This cop checks for scope calls where it was passed

data/lib/rubocop/cop/rails/validation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Rails
       # This cop checks for the use of old-style attribute validation macros.

data/lib/rubocop/cop/severity.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     # Severity class is simple value object about severity
     class Severity

data/lib/rubocop/cop/style/access_modifier_indentation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Modifiers should be indented as deep as method definitions, or as deep

data/lib/rubocop/cop/style/accessor_method_name.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop makes sure that accessor methods are named properly.

data/lib/rubocop/cop/style/alias.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # The purpose of the this cop is advise the use of

data/lib/rubocop/cop/style/align_array.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Here we check if the elements of a multi-line array literal are

data/lib/rubocop/cop/style/align_hash.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Here we check if the keys, separators, and values of a multi-line hash

data/lib/rubocop/cop/style/align_parameters.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Here we check if the parameters on a multi-line method call are

data/lib/rubocop/cop/style/and_or.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of *and* and *or*.

data/lib/rubocop/cop/style/array_join.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of "*" as a substitute for *join*.

data/lib/rubocop/cop/style/ascii_comments.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for non-ascii (non-English) characters

data/lib/rubocop/cop/style/ascii_identifiers.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for non-ascii characters in indentifier names.

data/lib/rubocop/cop/style/attr.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of Module#attr.

data/lib/rubocop/cop/style/begin_block.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for BEGIN blocks.

data/lib/rubocop/cop/style/block_comments.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop looks for uses of block comments (=begin...=end).
@@ -9,8 +9,29 @@ module Rubocop
         def investigate(processed_source)
           processed_source.comments.each do |comment|
-            next unless comment.text.start_with?('=begin')
-            add_offense(comment, :expression)
+            add_offense(comment, :expression) if comment.document?
+          end
+        end
+        def autocorrect(comment)
+          expr = comment.loc.expression
+          eq_begin = expr.resize("=begin\n".length)
+          eq_end = Parser::Source::Range.new(expr.source_buffer,
+                                             expr.end_pos - "\n=end".length,
+                                             expr.end_pos)
+          contents = Parser::Source::Range.new(expr.source_buffer,
+                                               eq_begin.end_pos,
+                                               eq_end.begin_pos)
+          @corrections << lambda do |corrector|
+            corrector.remove(eq_begin)
+            unless contents.length == 0
+              corrector.replace(contents,
+                                contents.source
+                                  .gsub(/\A/, '# ')
+                                  .gsub(/\n\n/, "\n#\n")
+                                  .gsub(/\n(?=[^\z#])/, "\n# "))
+            end
+            corrector.remove(eq_end)
           end
         end
       end

data/lib/rubocop/cop/style/block_nesting.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for excessive nesting of conditional and looping

data/lib/rubocop/cop/style/blocks.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Check for uses of braces or do/end around single line or

data/lib/rubocop/cop/style/braces_around_hash_parameters.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for braces in method calls with hash parameters.

data/lib/rubocop/cop/style/case_equality.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of the case equality operator(===).

data/lib/rubocop/cop/style/case_indentation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks how the *when*s of a *case* expression

data/lib/rubocop/cop/style/character_literal.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # Checks for uses of the character literal ?x.

data/lib/rubocop/cop/style/class_and_module_camel_case.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cops checks for class and module names with

data/lib/rubocop/cop/style/class_and_module_children.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks the style of children definitions at classes and

data/lib/rubocop/cop/style/class_length.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks if the length a class exceeds some maximum value.

data/lib/rubocop/cop/style/class_methods.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of the class/module name instead of

data/lib/rubocop/cop/style/class_vars.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of class variables. Offenses

data/lib/rubocop/cop/style/collection_methods.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of unidiomatic method names

data/lib/rubocop/cop/style/colon_method_call.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for methods invoked via the :: operator instead

data/lib/rubocop/cop/style/comment_annotation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks that comment annotation keywords are written according

data/lib/rubocop/cop/style/comment_indentation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cops checks the indentation of comments.

data/lib/rubocop/cop/style/constant_name.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks whether constant names are written using

data/lib/rubocop/cop/style/cyclomatic_complexity.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks that the cyclomatic complexity of methods is not higher

data/lib/rubocop/cop/style/def_with_parentheses.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for parentheses in the definition of a method,

data/lib/rubocop/cop/style/deprecated_hash_methods.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of the deprecated methods Hash#has_key?

data/lib/rubocop/cop/style/documentation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for missing top-level documentation of
@@ -66,7 +66,9 @@ module Rubocop
           distance = node.loc.keyword.line - preceding_comment.loc.line
           return false if distance > 1
-          !annotation?(preceding_comment)
+          # As long as there's at least one comment line that isn't an
+          # annotation, it's OK.
+          ast_with_comments[node].any? { |comment| !annotation?(comment) }
         end
       end
     end

data/lib/rubocop/cop/style/dot_position.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks the . position in multi-line method calls.

data/lib/rubocop/cop/style/double_negation.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks for uses of double negation (!!) to convert something

data/lib/rubocop/cop/style/each_with_object.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop looks for inject / reduce calls where the passed in object is
@@ -23,14 +23,30 @@ module Rubocop
           return unless METHODS.include? method_name
           return if method_args.type == :sym
-          return_value = body.children.last
-          return unless return_value.type == :lvar
+          return_value = return_value(body)
+          return unless return_value
+          return unless first_argument_returned?(args, return_value)
+          add_offense(method, :selector, format(MSG, method_name))
+        end
+        private
+        def return_value(body)
+          return unless body
+          return_value = body.type == :begin ? body.children.last : body
+          return_value if return_value && return_value.type == :lvar
+        end
+        def first_argument_returned?(args, return_value)
           first_arg, = *args
           accumulator_var = *first_arg
           return_var = *return_value
-          return unless accumulator_var == return_var
-          add_offense(method, :selector, format(MSG, method_name))
+          accumulator_var == return_var
         end
       end
     end

data/lib/rubocop/cop/style/empty_line_between_defs.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cop checks whether method definitions are

data/lib/rubocop/cop/style/empty_lines.rb CHANGED

@@ -1,6 +1,6 @@
 # encoding: utf-8
-module Rubocop
+module RuboCop
   module Cop
     module Style
       # This cops checks for two or more consecutive blank lines.