rubocop-rspec 1.32.0 → 1.33.0

data/spec/rubocop/cop/rspec/return_from_stub_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
   subject(:cop) { described_class.new(config) }
 
@@ -15,6 +17,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                       ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(42)
+        end
+      RUBY
     end
 
     it 'finds empty values returned from block' do
@@ -24,6 +32,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                       ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(nil)
+        end
+      RUBY
     end
 
     it 'finds array with only static values returned from block' do
@@ -33,6 +47,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                       ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return([42, 43])
+        end
+      RUBY
     end
 
     it 'finds hash with only static values returned from block' do
@@ -42,6 +62,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                       ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return({a: 42, b: 43})
+        end
+      RUBY
     end
 
     it 'finds static values in a block when there are chained methods' do
@@ -51,6 +77,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                                                ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Question).to receive(:meaning).with(:universe).and_return(42)
+        end
+      RUBY
     end
 
     it 'finds constants returned from block' do
@@ -60,6 +92,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                       ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return(Life::MEANING)
+        end
+      RUBY
     end
 
     it 'finds nested constants returned from block' do
@@ -69,6 +107,12 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
                                       ^ Use `and_return` for static values.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return({Life::MEANING => 42})
+        end
+      RUBY
     end
 
     it 'ignores dynamic values returned from block' do
@@ -125,6 +169,13 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
           end
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar).and_return("You called" \
+            "me")
+        end
+      RUBY
     end
 
     it 'ignores stubs without return value' do
@@ -142,35 +193,6 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
         end
       RUBY
     end
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar) { 42 }',
-                     'allow(Foo).to receive(:bar).and_return(42)'
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar) { { foo: 42 } }',
-                     'allow(Foo).to receive(:bar).and_return({ foo: 42 })'
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar).with(1) { 42 }',
-                     'allow(Foo).to receive(:bar).with(1).and_return(42)'
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar) {}',
-                     'allow(Foo).to receive(:bar).and_return(nil)'
-
-    original = <<-RUBY
-      allow(Foo).to receive(:bar) do
-        'You called ' \\
-        'me'
-      end
-    RUBY
-    corrected = <<-RUBY
-      allow(Foo).to receive(:bar).and_return('You called ' \\
-        'me')
-    RUBY
-
-    include_examples 'autocorrect', original, corrected
   end
 
   context 'with EnforcedStyle `block`' do
@@ -219,48 +241,49 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
       RUBY
     end
 
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar).and_return(42)',
-                     'allow(Foo).to receive(:bar) { 42 }'
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar).with(1).and_return(foo: 42)',
-                     'allow(Foo).to receive(:bar).with(1) { { foo: 42 } }'
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar).and_return({ foo: 42 })',
-                     'allow(Foo).to receive(:bar) { { foo: 42 } }'
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar).and_return(foo: 42)',
-                     'allow(Foo).to receive(:bar) { { foo: 42 } }'
-
-    original = <<-RUBY
-      allow(Foo).to receive(:bar).and_return(
-        a: 42,
-        b: 43
-      )
-    RUBY
-    corrected = <<-RUBY # Not perfect, but good enough.
-      allow(Foo).to receive(:bar) { { a: 42,
-        b: 43 } }
-    RUBY
-
-    include_examples 'autocorrect', original, corrected
-
-    include_examples 'autocorrect',
-                     'allow(Foo).to receive(:bar).and_return(nil)',
-                     'allow(Foo).to receive(:bar) { nil }'
-
-    original = <<-RUBY
-      allow(Foo).to receive(:bar).and_return('You called ' \\
-        'me')
-    RUBY
-    corrected = <<-RUBY
-      allow(Foo).to receive(:bar) { 'You called ' \\
-        'me' }
-    RUBY
-
-    include_examples 'autocorrect', original, corrected
+    it 'finds hash with only static values returned from method' do
+      expect_offense(<<-RUBY)
+        allow(Foo).to receive(:bar).and_return({ foo: 42 })
+                                    ^^^^^^^^^^ Use block for static values.
+        allow(Foo).to receive(:bar).and_return(foo: 42)
+                                    ^^^^^^^^^^ Use block for static values.
+        allow(Foo).to receive(:bar).and_return(
+                                    ^^^^^^^^^^ Use block for static values.
+          a: 42,
+          b: 43
+        )
+      RUBY
+
+      expect_correction(<<-RUBY) # Not perfect, but good enough.
+        allow(Foo).to receive(:bar) { { foo: 42 } }
+        allow(Foo).to receive(:bar) { { foo: 42 } }
+        allow(Foo).to receive(:bar) { { a: 42,
+          b: 43 } }
+      RUBY
+    end
+
+    it 'finds nil returned from method' do
+      expect_offense(<<-RUBY)
+        allow(Foo).to receive(:bar).and_return(nil)
+                                    ^^^^^^^^^^ Use block for static values.
+      RUBY
+
+      expect_correction(<<-RUBY)
+        allow(Foo).to receive(:bar) { nil }
+      RUBY
+    end
+
+    it 'finds concatenated strings with no variables' do
+      expect_offense(<<-RUBY)
+        allow(Foo).to receive(:bar).and_return('You called ' \\
+                                    ^^^^^^^^^^ Use block for static values.
+          'me')
+      RUBY
+
+      expect_correction(<<-RUBY)
+        allow(Foo).to receive(:bar) { 'You called ' \\
+          'me' }
+      RUBY
+    end
   end
 end

data/spec/rubocop/cop/rspec/scattered_let_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/scattered_setup_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/shared_context_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::SharedContext do
   subject(:cop) { described_class.new }
 
@@ -17,6 +19,13 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
           end
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        shared_examples 'foo' do
+          it 'performs actions' do
+          end
+        end
+      RUBY
     end
 
     it 'does not register an offense for `shared_context` with let' do
@@ -70,6 +79,12 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
           let(:foo) { :bar }
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        shared_context 'foo' do
+          let(:foo) { :bar }
+        end
+      RUBY
     end
 
     it 'registers an offense for shared_examples with only subject' do
@@ -79,6 +94,12 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
           subject(:foo) { :bar }
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        shared_context 'foo' do
+          subject(:foo) { :bar }
+        end
+      RUBY
     end
 
     it 'registers an offense for shared_examples with only hooks' do
@@ -90,6 +111,14 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
           end
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        shared_context 'foo' do
+          before do
+            foo
+          end
+        end
+      RUBY
     end
 
     it 'does not register an offense for `shared_examples` with it' do
@@ -105,38 +134,4 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
       RUBY
     end
   end
-
-  bad_shared_context = <<-RUBY
-    shared_context 'foo' do
-      it 'performs actions' do
-      end
-    end
-  RUBY
-
-  good_shared_context = <<-RUBY
-    shared_examples 'foo' do
-      it 'performs actions' do
-      end
-    end
-  RUBY
-
-  include_examples 'autocorrect',
-                   bad_shared_context,
-                   good_shared_context
-
-  bad_shared_examples = <<-RUBY
-    shared_examples 'foo' do
-      let(:foo) { :bar }
-    end
-  RUBY
-
-  good_shared_examples = <<-RUBY
-    shared_context 'foo' do
-      let(:foo) { :bar }
-    end
-  RUBY
-
-  include_examples 'autocorrect',
-                   bad_shared_examples,
-                   good_shared_examples
 end

data/spec/rubocop/cop/rspec/shared_examples_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedExamples do
       include_examples :foo_bar_baz, 'foo', 'bar'
                        ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
 
-      shared_examples :foo_bar_baz do |param|
+      shared_examples :foo_bar_baz, 'foo', 'bar' do |param|
                       ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
         # ...
       end
@@ -26,6 +26,21 @@ RSpec.describe RuboCop::Cop::RSpec::SharedExamples do
       RSpec.shared_examples :foo_bar_baz
                             ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
     RUBY
+
+    expect_correction(<<-RUBY)
+      it_behaves_like 'foo bar baz'
+      it_should_behave_like 'foo bar baz'
+      shared_examples 'foo bar baz'
+      shared_examples_for 'foo bar baz'
+      include_examples 'foo bar baz'
+      include_examples 'foo bar baz', 'foo', 'bar'
+
+      shared_examples 'foo bar baz', 'foo', 'bar' do |param|
+        # ...
+      end
+
+      RSpec.shared_examples 'foo bar baz'
+    RUBY
   end
 
   it 'does not register an offense when using string title' do
@@ -57,37 +72,4 @@ RSpec.describe RuboCop::Cop::RSpec::SharedExamples do
       end
     RUBY
   end
-
-  include_examples 'autocorrect',
-                   'it_behaves_like :foo_bar_baz',
-                   "it_behaves_like 'foo bar baz'"
-  include_examples 'autocorrect',
-                   'it_should_behave_like :foo_bar_baz',
-                   "it_should_behave_like 'foo bar baz'"
-  include_examples 'autocorrect',
-                   'shared_examples :foo_bar_baz',
-                   "shared_examples 'foo bar baz'"
-  include_examples 'autocorrect',
-                   'shared_examples_for :foo_bar_baz',
-                   "shared_examples_for 'foo bar baz'"
-  include_examples 'autocorrect',
-                   'include_examples :foo_bar_baz',
-                   "include_examples 'foo bar baz'"
-  include_examples 'autocorrect',
-                   "include_examples :foo_bar_baz, 'foo', 'bar'",
-                   "include_examples 'foo bar baz', 'foo', 'bar'"
-
-  bad_code_with_block = <<-RUBY
-    shared_examples :foo_bar_baz, 'foo', 'bar' do |param|
-      # ...
-    end
-  RUBY
-
-  good_code_with_block = <<-RUBY
-    shared_examples 'foo bar baz', 'foo', 'bar' do |param|
-      # ...
-    end
-  RUBY
-
-  include_examples 'autocorrect', bad_code_with_block, good_code_with_block
 end

data/spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
   subject(:cop) { described_class.new }
 
@@ -9,13 +11,13 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
                         ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
         end
       RUBY
-    end
 
-    include_examples(
-      'autocorrect',
-      'before { allow(foo).to receive_message_chain(:one) { :two } }',
-      'before { allow(foo).to receive(:one) { :two } }'
-    )
+      expect_correction(<<-RUBY)
+        before do
+          allow(foo).to receive(:one) { :two }
+        end
+      RUBY
+    end
 
     it 'accepts multi-argument calls' do
       expect_no_offenses(<<-RUBY)
@@ -32,13 +34,13 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
                         ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
         end
       RUBY
-    end
 
-    include_examples(
-      'autocorrect',
-      'before { allow(foo).to receive_message_chain("one") { :two } }',
-      'before { allow(foo).to receive("one") { :two } }'
-    )
+      expect_correction(<<-RUBY)
+        before do
+          allow(foo).to receive("one") { :two }
+        end
+      RUBY
+    end
 
     it 'accepts multi-argument string calls' do
       expect_no_offenses(<<-RUBY)
@@ -73,13 +75,13 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
                           ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
           end
         RUBY
-      end
 
-      include_examples(
-        'autocorrect',
-        'before { allow(foo).to receive_message_chain([:one]) { :two } }',
-        'before { allow(foo).to receive(:one) { :two } }'
-      )
+        expect_correction(<<-RUBY)
+          before do
+            allow(foo).to receive(:one) { :two }
+          end
+        RUBY
+      end
     end
 
     context 'with multiple-element array argument' do
@@ -98,27 +100,21 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
           before do
             allow(foo).to receive_message_chain(bar: 42)
                           ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
+            allow(foo).to receive_message_chain("bar" => 42)
+                          ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
+            allow(foo).to receive_message_chain(:"\#{foo}" => 42)
+                          ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
           end
         RUBY
-      end
 
-      include_examples(
-        'autocorrect',
-        'before { allow(foo).to receive_message_chain(bar: 42) }',
-        'before { allow(foo).to receive(:bar).and_return(42) }'
-      )
-
-      include_examples(
-        'autocorrect',
-        'before { allow(foo).to receive_message_chain("bar" => 42) }',
-        'before { allow(foo).to receive("bar").and_return(42) }'
-      )
-
-      include_examples(
-        'autocorrect',
-        'before { allow(foo).to receive_message_chain(:"#{foo}" => 42) }',
-        'before { allow(foo).to receive(:"#{foo}").and_return(42) }'
-      )
+        expect_correction(<<-RUBY)
+          before do
+            allow(foo).to receive(:bar).and_return(42)
+            allow(foo).to receive("bar").and_return(42)
+            allow(foo).to receive(:"\#{foo}").and_return(42)
+          end
+        RUBY
+      end
     end
 
     context 'with multiple keys hash argument' do
@@ -140,13 +136,13 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
               ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
         end
       RUBY
-    end
 
-    include_examples(
-      'autocorrect',
-      'before { foo.stub_chain(:one) { :two } }',
-      'before { foo.stub(:one) { :two } }'
-    )
+      expect_correction(<<-RUBY)
+        before do
+          foo.stub(:one) { :two }
+        end
+      RUBY
+    end
 
     it 'accepts multi-argument calls' do
       expect_no_offenses(<<-RUBY)
@@ -163,13 +159,13 @@ RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
               ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
         end
       RUBY
-    end
 
-    include_examples(
-      'autocorrect',
-      'before { foo.stub_chain("one") { :two } }',
-      'before { foo.stub("one") { :two } }'
-    )
+      expect_correction(<<-RUBY)
+        before do
+          foo.stub("one") { :two }
+        end
+      RUBY
+    end
 
     it 'accepts multi-argument string calls' do
       expect_no_offenses(<<-RUBY)