rubocop-rspec 1.32.0 → 1.33.0

data/spec/rubocop/cop/rspec/let_before_examples_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
   subject(:cop) { described_class.new }
 
@@ -9,6 +11,13 @@ RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
         ^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        let(:foo) { bar }
+        it { is_expected.to be_after_let }
+      end
+    RUBY
   end
 
   it 'flags `let` after `context`' do
@@ -22,6 +31,16 @@ RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
         ^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        let(:foo) { bar }
+        context 'a context' do
+          it { is_expected.to be_after_let }
+        end
+
+      end
+    RUBY
   end
 
   it 'flags `let` after `include_examples`' do
@@ -33,6 +52,14 @@ RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
         ^^^^^^^^^^^^^^^^^ Move `let` before the examples in the group.
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        let(:foo) { bar }
+        include_examples('should be after let')
+
+      end
+    RUBY
   end
 
   it 'does not flag `let` before the examples' do
@@ -86,32 +113,6 @@ RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
     RUBY
   end
 
-  bad_code = <<-RUBY
-    RSpec.describe User do
-      include_examples('should be after let')
-      context 'another one' do
-        let(:foo) { baz }
-        include_examples('should be ok')
-      end
-
-      let(:foo) { bar }
-    end
-  RUBY
-
-  good_code = <<-RUBY
-    RSpec.describe User do
-      let(:foo) { bar }
-      include_examples('should be after let')
-      context 'another one' do
-        let(:foo) { baz }
-        include_examples('should be ok')
-      end
-
-    end
-  RUBY
-
-  include_examples 'autocorrect', bad_code, good_code
-
   bad_code = <<-RUBY
     RSpec.describe User do
       include_examples('should be after let')

data/spec/rubocop/cop/rspec/message_chain_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::MessageChain do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/missing_example_group_argument_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::MissingExampleGroupArgument do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/multiple_describes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::MultipleDescribes do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/multiple_subjects_spec.rb

@@ -19,17 +19,31 @@ RSpec.describe RuboCop::Cop::RSpec::MultipleSubjects do
         end
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      describe 'hello there' do
+        let(:foo) { 1 }
+        let(:bar) { 2 }
+        subject(:baz) { 4 }
+
+        describe 'baz' do
+          subject(:norf) { 1 }
+        end
+      end
+    RUBY
   end
 
   it 'does not try to autocorrect subject!' do
     source = <<-RUBY
       describe Foo do
         subject! { a }
+        ^^^^^^^^^^^^^^ Do not set more than one subject per example group
         subject! { b }
       end
     RUBY
 
-    expect(autocorrect_source(source, 'example_spec.rb')).to eql(source)
+    expect_offense(source)
+    expect_no_corrections
   end
 
   it 'does not flag shared example groups' do
@@ -50,47 +64,20 @@ RSpec.describe RuboCop::Cop::RSpec::MultipleSubjects do
     RUBY
   end
 
-  include_examples(
-    'autocorrect',
-    <<-RUBY,
-      describe 'hello there' do
-        subject(:foo) { 1 }
-        subject(:bar) { 2 }
-        subject(:baz) { 3 }
-
-        describe 'baz' do
-          subject(:norf) { 1 }
-        end
-      end
-    RUBY
-    <<-RUBY
+  it 'autocorrects' do
+    expect_offense(<<-RUBY)
       describe 'hello there' do
-        let(:foo) { 1 }
-        let(:bar) { 2 }
-        subject(:baz) { 3 }
-
-        describe 'baz' do
-          subject(:norf) { 1 }
-        end
+        subject { 1 }
+        ^^^^^^^^^^^^^ Do not set more than one subject per example group
+        subject { 2 }
+        ^^^^^^^^^^^^^ Do not set more than one subject per example group
+        subject { 3 }
       end
     RUBY
-  )
-
-  include_examples(
-    'autocorrect',
-    <<-RUBY.strip_indent.chomp,
+    expect_correction(<<-RUBY)
       describe 'hello there' do
-        subject { 1 }
-        subject { 2 }
         subject { 3 }
       end
     RUBY
-    [
-      "describe 'hello there' do",
-      '  ',
-      '  ',
-      '  subject { 3 }',
-      'end'
-    ].join("\n")
-  )
+  end
 end

data/spec/rubocop/cop/rspec/not_to_not_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
   subject(:cop) { described_class.new(config) }
 
@@ -9,6 +11,10 @@ RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
         it { expect(false).to_not be_true }
                            ^^^^^^ Prefer `not_to` over `to_not`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { expect(false).not_to be_true }
+      RUBY
     end
 
     it 'detects the `to_not` offense on an expect block' do
@@ -18,6 +24,12 @@ RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
         }.to_not raise_error
           ^^^^^^ Prefer `not_to` over `to_not`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        expect {
+          2 + 2
+        }.not_to raise_error
+      RUBY
     end
 
     it 'detects no offense when using `not_to`' do
@@ -25,22 +37,6 @@ RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
         it { expect(false).not_to be_true }
       RUBY
     end
-
-    include_examples 'autocorrect',
-                     'it { expect(0).to_not equal 1 }',
-                     'it { expect(0).not_to equal 1 }'
-
-    original = <<-RUBY
-      expect {
-        2 + 2
-      }.to_not raise_error
-    RUBY
-    corrected = <<-RUBY
-      expect {
-        2 + 2
-      }.not_to raise_error
-    RUBY
-    include_examples 'autocorrect', original, corrected
   end
 
   context 'when AcceptedMethod is `to_not`' do
@@ -51,6 +47,10 @@ RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
         it { expect(false).not_to be_true }
                            ^^^^^^ Prefer `to_not` over `not_to`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { expect(false).to_not be_true }
+      RUBY
     end
 
     it 'detects the `not_to` offense on an expect block' do
@@ -60,6 +60,12 @@ RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
         }.not_to raise_error
           ^^^^^^ Prefer `to_not` over `not_to`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        expect {
+          2 + 2
+        }.to_not raise_error
+      RUBY
     end
 
     it 'detects no offense when using `to_not`' do
@@ -67,21 +73,5 @@ RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
         it { expect(false).to_not be_true }
       RUBY
     end
-
-    include_examples 'autocorrect',
-                     'it { expect(0).not_to equal 1 }',
-                     'it { expect(0).to_not equal 1 }'
-
-    original = <<-RUBY
-      expect {
-        2 + 2
-      }.not_to raise_error
-    RUBY
-    corrected = <<-RUBY
-      expect {
-        2 + 2
-      }.to_not raise_error
-    RUBY
-    include_examples 'autocorrect', original, corrected
   end
 end

data/spec/rubocop/cop/rspec/overwriting_setup_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::OverwritingSetup do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/pending_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::Pending do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/predicate_matcher_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
   subject(:cop) { described_class.new(config) }
 

data/spec/rubocop/cop/rspec/receive_counts_spec.rb

@@ -8,6 +8,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).exactly(1).times
                                   ^^^^^^^^^^^^^^^^^ Use `.once` instead of `.exactly(1).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).once
+    RUBY
   end
 
   it 'flags usage of `exactly(2).times`' do
@@ -15,6 +19,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).exactly(2).times
                                   ^^^^^^^^^^^^^^^^^ Use `.twice` instead of `.exactly(2).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).twice
+    RUBY
   end
 
   it 'allows `exactly(3).times`' do
@@ -34,6 +42,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).with(baz).exactly(1).times
                                             ^^^^^^^^^^^^^^^^^ Use `.once` instead of `.exactly(1).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).with(baz).once
+    RUBY
   end
 
   it 'flags usage of `exactly(1).times` with return value' do
@@ -41,6 +53,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).exactly(1).times.and_return(true)
                                   ^^^^^^^^^^^^^^^^^ Use `.once` instead of `.exactly(1).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).once.and_return(true)
+    RUBY
   end
 
   it 'flags usage of `exactly(1).times` with a block' do
@@ -48,6 +64,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).exactly(1).times { true }
                                   ^^^^^^^^^^^^^^^^^ Use `.once` instead of `.exactly(1).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).once { true }
+    RUBY
   end
 
   it 'flags usage of `at_least(1).times`' do
@@ -55,6 +75,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).at_least(1).times
                                   ^^^^^^^^^^^^^^^^^^ Use `.at_least(:once)` instead of `.at_least(1).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).at_least(:once)
+    RUBY
   end
 
   it 'flags usage of `at_least(2).times`' do
@@ -62,6 +86,21 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).at_least(2).times
                                   ^^^^^^^^^^^^^^^^^^ Use `.at_least(:twice)` instead of `.at_least(2).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).at_least(:twice)
+    RUBY
+  end
+
+  it 'flags usage of `at_least(2).times` with a block' do
+    expect_offense(<<-RUBY)
+      expect(foo).to receive(:bar).at_least(2).times { true }
+                                  ^^^^^^^^^^^^^^^^^^ Use `.at_least(:twice)` instead of `.at_least(2).times`.
+    RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).at_least(:twice) { true }
+    RUBY
   end
 
   it 'flags usage of `at_most(1).times`' do
@@ -69,6 +108,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).at_most(1).times
                                   ^^^^^^^^^^^^^^^^^ Use `.at_most(:once)` instead of `.at_most(1).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).at_most(:once)
+    RUBY
   end
 
   it 'flags usage of `at_most(2).times`' do
@@ -76,6 +119,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
       expect(foo).to receive(:bar).at_most(2).times
                                   ^^^^^^^^^^^^^^^^^ Use `.at_most(:twice)` instead of `.at_most(2).times`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).to receive(:bar).at_most(:twice)
+    RUBY
   end
 
   it 'allows exactly(1).times when not called on `receive`' do
@@ -84,14 +131,6 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveCounts do
     RUBY
   end
 
-  include_examples 'autocorrect',
-                   'expect(foo).to receive(:bar).exactly(1).times { true }',
-                   'expect(foo).to receive(:bar).once { true }'
-
-  include_examples 'autocorrect',
-                   'expect(foo).to receive(:bar).at_least(2).times { true }',
-                   'expect(foo).to receive(:bar).at_least(:twice) { true }'
-
   # Does not auto-correct if not part of the RSpec API
   include_examples 'autocorrect',
                    'expect(foo).to have_published_event(:bar).exactly(2).times',

data/spec/rubocop/cop/rspec/receive_never_spec.rb

@@ -8,6 +8,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveNever do
       expect(foo).to receive(:bar).never
                                    ^^^^^ Use `not_to receive` instead of `never`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).not_to receive(:bar)
+    RUBY
   end
 
   it 'flags usage of `never` after `with`' do
@@ -15,6 +19,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveNever do
       expect(foo).to receive(:bar).with(baz).never
                                              ^^^^^ Use `not_to receive` instead of `never`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect(foo).not_to receive(:bar).with(baz)
+    RUBY
   end
 
   it 'flags usage of `never` with `is_expected`' do
@@ -22,6 +30,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveNever do
       is_expected.to receive(:bar).with(baz).never
                                              ^^^^^ Use `not_to receive` instead of `never`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      is_expected.not_to receive(:bar).with(baz)
+    RUBY
   end
 
   it 'flags usage of `never` with `expect_any_instance_of`' do
@@ -29,6 +41,10 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveNever do
       expect_any_instance_of(Foo).to receive(:bar).with(baz).never
                                                              ^^^^^ Use `not_to receive` instead of `never`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      expect_any_instance_of(Foo).not_to receive(:bar).with(baz)
+    RUBY
   end
 
   it 'allows method called `never`' do
@@ -38,8 +54,4 @@ RSpec.describe RuboCop::Cop::RSpec::ReceiveNever do
       is_expected.to be never
     RUBY
   end
-
-  include_examples 'autocorrect',
-                   'expect(foo).to receive(:bar).with(0).never',
-                   'expect(foo).not_to receive(:bar).with(0)'
 end