rubocop-rspec 1.32.0 → 1.33.0

data/lib/rubocop/cop/rspec/example_length.rb

@@ -28,7 +28,7 @@ module RuboCop
       class ExampleLength < Cop
         include CodeLength
 
-        MSG = 'Example has too many lines [%<total>d/%<max>d].'.freeze
+        MSG = 'Example has too many lines [%<total>d/%<max>d].'
 
         def on_block(node)
           return unless example?(node)

data/lib/rubocop/cop/rspec/example_without_description.rb

@@ -51,8 +51,8 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         MSG_DEFAULT_ARGUMENT = 'Omit the argument when you want to ' \
-                               'have auto-generated description.'.freeze
-        MSG_ADD_DESCRIPTION  = 'Add a description.'.freeze
+                               'have auto-generated description.'
+        MSG_ADD_DESCRIPTION  = 'Add a description.'
 
         def_node_matcher :example_description, '(send nil? _ $(str $_))'
 

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -30,8 +30,8 @@ module RuboCop
       #   it 'does things' do
       #   end
       class ExampleWording < Cop
-        MSG_SHOULD = 'Do not use should when describing your tests.'.freeze
-        MSG_IT     = "Do not repeat 'it' when describing your tests.".freeze
+        MSG_SHOULD = 'Do not use should when describing your tests.'
+        MSG_IT     = "Do not repeat 'it' when describing your tests."
 
         SHOULD_PREFIX = /\Ashould(?:n't)?\b/i.freeze
         IT_PREFIX     = /\Ait /i.freeze

data/lib/rubocop/cop/rspec/expect_actual.rb

@@ -17,7 +17,7 @@ module RuboCop
       #   expect(name).to eq("John")
       #
       class ExpectActual < Cop
-        MSG = 'Provide the actual you are testing to `expect(...)`.'.freeze
+        MSG = 'Provide the actual you are testing to `expect(...)`.'
 
         SIMPLE_LITERALS = %i[
           true

data/lib/rubocop/cop/rspec/expect_change.rb

@@ -32,8 +32,8 @@ module RuboCop
       class ExpectChange < Cop
         include ConfigurableEnforcedStyle
 
-        MSG_BLOCK = 'Prefer `change(%<obj>s, :%<attr>s)`.'.freeze
-        MSG_CALL = 'Prefer `change { %<obj>s.%<attr>s }`.'.freeze
+        MSG_BLOCK = 'Prefer `change(%<obj>s, :%<attr>s)`.'
+        MSG_CALL = 'Prefer `change { %<obj>s.%<attr>s }`.'
 
         def_node_matcher :expect_change_with_arguments, <<-PATTERN
           (send nil? :change ({const send} nil? $_) (sym $_))

data/lib/rubocop/cop/rspec/expect_in_hook.rb

@@ -21,7 +21,7 @@ module RuboCop
       #     expect(something).to eq 'foo'
       #   end
       class ExpectInHook < Cop
-        MSG = 'Do not use `%<expect>s` in `%<hook>s` hook'.freeze
+        MSG = 'Do not use `%<expect>s` in `%<hook>s` hook'
 
         def_node_search :expectation, Expectations::ALL.send_pattern
 

data/lib/rubocop/cop/rspec/expect_output.rb

@@ -16,7 +16,7 @@ module RuboCop
       #   expect { my_app.print_report }.to output('Hello World').to_stdout
       class ExpectOutput < Cop
         MSG = 'Use `expect { ... }.to output(...).to_%<name>s` '\
-              'instead of mutating $%<name>s.'.freeze
+              'instead of mutating $%<name>s.'
 
         def on_gvasgn(node)
           return unless inside_example_scope?(node)

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -25,53 +25,19 @@ module RuboCop
         #   # good
         #   count { 1 }
         class AttributeDefinedStatically < Cop
-          MSG = 'Use a block to declare attribute values.'.freeze
-
-          ATTRIBUTE_DEFINING_METHODS = %i[factory trait transient ignore].freeze
-
-          UNPROXIED_METHODS = %i[
-            __send__
-            __id__
-            nil?
-            send
-            object_id
-            extend
-            instance_eval
-            initialize
-            block_given?
-            raise
-            caller
-            method
-          ].freeze
-
-          DEFINITION_PROXY_METHODS = %i[
-            add_attribute
-            after
-            association
-            before
-            callback
-            ignore
-            initialize_with
-            sequence
-            skip_create
-            to_create
-          ].freeze
-
-          RESERVED_METHODS =
-            DEFINITION_PROXY_METHODS +
-            UNPROXIED_METHODS +
-            ATTRIBUTE_DEFINING_METHODS
+          MSG = 'Use a block to declare attribute values.'
 
           def_node_matcher :value_matcher, <<-PATTERN
-            (send {self nil?} !#reserved_method? $...)
+            (send _ !#reserved_method? $...)
           PATTERN
 
           def_node_search :factory_attributes, <<-PATTERN
-            (block (send nil? #attribute_defining_method? ...) _ { (begin $...) $(send ...) } )
+            (block (send _ #attribute_defining_method? ...) _ { (begin $...) $(send ...) } )
           PATTERN
 
           def on_block(node)
             factory_attributes(node).to_a.flatten.each do |attribute|
+              next unless offensive_receiver?(attribute.receiver, node)
               next if proc?(attribute) || association?(attribute)
 
               add_offense(attribute, location: :expression)
@@ -88,6 +54,20 @@ module RuboCop
 
           private
 
+          def offensive_receiver?(receiver, node)
+            receiver.nil? ||
+              receiver.self_type? ||
+              receiver_matches_first_block_argument?(receiver, node)
+          end
+
+          def receiver_matches_first_block_argument?(receiver, node)
+            first_block_argument = node.arguments.first
+
+            !first_block_argument.nil? &&
+              receiver.lvar_type? &&
+              receiver.node_parts == first_block_argument.node_parts
+          end
+
           def proc?(attribute)
             value_matcher(attribute).to_a.all?(&:block_pass_type?)
           end
@@ -134,11 +114,12 @@ module RuboCop
           end
 
           def reserved_method?(method_name)
-            RESERVED_METHODS.include?(method_name)
+            RuboCop::RSpec::FactoryBot.reserved_methods.include?(method_name)
           end
 
           def attribute_defining_method?(method_name)
-            ATTRIBUTE_DEFINING_METHODS.include?(method_name)
+            RuboCop::RSpec::FactoryBot.attribute_defining_methods
+              .include?(method_name)
           end
         end
       end

data/lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -27,8 +27,8 @@ module RuboCop
         class CreateList < Cop
           include ConfigurableEnforcedStyle
 
-          MSG_CREATE_LIST = 'Prefer create_list.'.freeze
-          MSG_N_TIMES = 'Prefer %<number>s.times.'.freeze
+          MSG_CREATE_LIST = 'Prefer create_list.'
+          MSG_N_TIMES = 'Prefer %<number>s.times.'
 
           def_node_matcher :n_times_block_without_arg?, <<-PATTERN
             (block

data/lib/rubocop/cop/rspec/file_path.rb

@@ -44,7 +44,7 @@ module RuboCop
       class FilePath < Cop
         include RuboCop::RSpec::TopLevelDescribe
 
-        MSG = 'Spec path should end with `%<suffix>s`.'.freeze
+        MSG = 'Spec path should end with `%<suffix>s`.'
 
         def_node_search :const_described?,  '(send _ :describe (const ...) ...)'
         def_node_search :routing_metadata?, '(pair (sym :type) (sym :routing))'
@@ -75,7 +75,7 @@ module RuboCop
         end
 
         def name_glob(name)
-          return unless name && name.str_type?
+          return unless name&.str_type?
 
           "*#{name.str_content.gsub(/\W/, '')}" unless ignore_methods?
         end

data/lib/rubocop/cop/rspec/focus.rb

@@ -20,7 +20,7 @@ module RuboCop
       #   describe MyClass do
       #   end
       class Focus < Cop
-        MSG = 'Focused spec found.'.freeze
+        MSG = 'Focused spec found.'
 
         focusable =
           ExampleGroups::GROUPS  +
@@ -36,8 +36,8 @@ module RuboCop
         FOCUS_TRUE   = s(:pair, FOCUS_SYMBOL, s(:true))
 
         def_node_matcher :metadata, <<-PATTERN
-          {(send {(const nil? :RSpec) nil?} #{FOCUSABLE_SELECTORS} ... (hash $...))
-           (send {(const nil? :RSpec) nil?} #{FOCUSABLE_SELECTORS} $...)}
+          {(send #{RSPEC} #{FOCUSABLE_SELECTORS} ... (hash $...))
+           (send #{RSPEC} #{FOCUSABLE_SELECTORS} $...)}
         PATTERN
 
         def_node_matcher :focused_block?, focused.send_pattern

data/lib/rubocop/cop/rspec/hook_argument.rb

@@ -59,11 +59,10 @@ module RuboCop
       #   end
       class HookArgument < Cop
         include ConfigurableEnforcedStyle
-        include RangeHelp
 
         IMPLICIT_MSG = 'Omit the default `%<scope>p` ' \
-                       'argument for RSpec hooks.'.freeze
-        EXPLICIT_MSG = 'Use `%<scope>p` for RSpec hooks.'.freeze
+                       'argument for RSpec hooks.'
+        EXPLICIT_MSG = 'Use `%<scope>p` for RSpec hooks.'
 
         HOOKS = Hooks::ALL.node_pattern_union.freeze
 
@@ -125,9 +124,8 @@ module RuboCop
         end
 
         def argument_range(send_node)
-          range_between(
-            send_node.loc.selector.end_pos,
-            send_node.loc.expression.end_pos
+          send_node.loc.selector.end.with(
+            end_pos: send_node.loc.expression.end_pos
           )
         end
       end

data/lib/rubocop/cop/rspec/hooks_before_examples.rb

@@ -27,7 +27,7 @@ module RuboCop
         include RangeHelp
         include RuboCop::RSpec::FinalEndLocation
 
-        MSG = 'Move `%<hook>s` above the examples in the group.'.freeze
+        MSG = 'Move `%<hook>s` above the examples in the group.'
 
         def_node_matcher :example_or_group?, <<-PATTERN
           {
@@ -88,10 +88,7 @@ module RuboCop
         end
 
         def node_range(node)
-          range_between(
-            node.loc.expression.begin_pos,
-            final_end_location(node).end_pos
-          )
+          node.loc.expression.with(end_pos: final_end_location(node).end_pos)
         end
       end
     end

data/lib/rubocop/cop/rspec/implicit_expect.rb

@@ -27,12 +27,12 @@ module RuboCop
       class ImplicitExpect < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Prefer `%<good>s` over `%<bad>s`.'.freeze
+        MSG = 'Prefer `%<good>s` over `%<bad>s`.'
 
         def_node_matcher :implicit_expect, <<-PATTERN
           {
             (send nil? ${:should :should_not} ...)
-            (send (send nil? $:is_expected) {:to :to_not :not_to} ...)
+            (send (send nil? $:is_expected) #{Runners::ALL.node_pattern_union} ...)
           }
         PATTERN
 

data/lib/rubocop/cop/rspec/implicit_subject.rb

@@ -29,7 +29,7 @@ module RuboCop
       class ImplicitSubject < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = "Don't use implicit subject.".freeze
+        MSG = "Don't use implicit subject."
 
         def_node_matcher :implicit_subject?, <<-PATTERN
           (send nil? {:should :should_not :is_expected} ...)

data/lib/rubocop/cop/rspec/instance_spy.rb

@@ -20,7 +20,7 @@ module RuboCop
       #
       class InstanceSpy < Cop
         MSG = 'Use `instance_spy` when you check your double '\
-              'with `have_received`.'.freeze
+              'with `have_received`.'
 
         def_node_search :null_double, <<-PATTERN
           (lvasgn $_

data/lib/rubocop/cop/rspec/instance_variable.rb

@@ -47,7 +47,7 @@ module RuboCop
       #   end
       #
       class InstanceVariable < Cop
-        MSG = 'Replace instance variable with local variable or `let`.'.freeze
+        MSG = 'Replace instance variable with local variable or `let`.'
 
         EXAMPLE_GROUP_METHODS = ExampleGroups::ALL + SharedGroups::ALL
 

data/lib/rubocop/cop/rspec/invalid_predicate_matcher.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module RSpec
@@ -14,10 +16,10 @@ module RuboCop
       #   # good
       #   expect(foo).to be_something
       class InvalidPredicateMatcher < Cop
-        MSG = 'Omit `?` from `%<matcher>s`.'.freeze
+        MSG = 'Omit `?` from `%<matcher>s`.'
 
         def_node_matcher :invalid_predicate_matcher?, <<-PATTERN
-          (send (send nil? :expect ...) {:to :not_to :to_not} $(send nil? #predicate?))
+          (send (send nil? :expect ...) #{Runners::ALL.node_pattern_union} $(send nil? #predicate?))
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/rspec/it_behaves_like.rb

@@ -22,7 +22,7 @@ module RuboCop
         include ConfigurableEnforcedStyle
 
         MSG = 'Prefer `%<replacement>s` over `%<original>s` when including '\
-              'examples in a nested context.'.freeze
+              'examples in a nested context.'
 
         def_node_matcher :example_inclusion_offense, '(send _ % ...)'
 

data/lib/rubocop/cop/rspec/iterated_expectation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module RSpec
@@ -15,7 +17,7 @@ module RuboCop
       #   end
       class IteratedExpectation < Cop
         MSG = 'Prefer using the `all` matcher instead ' \
-                  'of iterating over an array.'.freeze
+                  'of iterating over an array.'
 
         def_node_matcher :each?, <<-PATTERN
           (block

data/lib/rubocop/cop/rspec/leading_subject.rb

@@ -34,8 +34,7 @@ module RuboCop
       class LeadingSubject < Cop
         include RangeHelp
 
-        MSG = 'Declare `subject` above any other `%<offending>s` ' \
-          'declarations.'.freeze
+        MSG = 'Declare `subject` above any other `%<offending>s` declarations.'
 
         def on_block(node)
           return unless subject?(node) && !in_spec_block?(node)

data/lib/rubocop/cop/rspec/let_before_examples.rb

@@ -34,7 +34,7 @@ module RuboCop
         include RangeHelp
         include RuboCop::RSpec::FinalEndLocation
 
-        MSG = 'Move `let` before the examples in the group.'.freeze
+        MSG = 'Move `let` before the examples in the group.'
 
         def_node_matcher :example_or_group?, <<-PATTERN
           {
@@ -91,10 +91,7 @@ module RuboCop
         end
 
         def node_range(node)
-          range_between(
-            node.loc.expression.begin_pos,
-            final_end_location(node).end_pos
-          )
+          node.loc.expression.with(end_pos: final_end_location(node).end_pos)
         end
       end
     end

data/lib/rubocop/cop/rspec/let_setup.rb

@@ -28,7 +28,7 @@ module RuboCop
       class LetSetup < Cop
         include RuboCop::RSpec::TopLevelDescribe
 
-        MSG = 'Do not use `let!` for test setup.'.freeze
+        MSG = 'Do not use `let!` for test setup.'
 
         def_node_search :let_bang, <<-PATTERN
           (block $(send nil? :let! (sym $_)) args ...)

data/lib/rubocop/cop/rspec/message_chain.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RuboCop
   module Cop
     module RSpec
@@ -12,7 +14,7 @@ module RuboCop
       #   allow(foo).to receive(bar: thing)
       #
       class MessageChain < Cop
-        MSG = 'Avoid stubbing using `%<method>s`.'.freeze
+        MSG = 'Avoid stubbing using `%<method>s`.'
 
         def_node_matcher :message_chain, <<-PATTERN
           (send _ {:receive_message_chain :stub_chain} ...)

data/lib/rubocop/cop/rspec/message_expectation.rb

@@ -27,7 +27,7 @@ module RuboCop
       class MessageExpectation < Cop
         include ConfigurableEnforcedStyle
 
-        MSG = 'Prefer `%<style>s` for setting message expectations.'.freeze
+        MSG = 'Prefer `%<style>s` for setting message expectations.'
 
         SUPPORTED_STYLES = %w[allow expect].freeze
 

data/lib/rubocop/cop/rspec/message_spies.rb

@@ -27,17 +27,16 @@ module RuboCop
       class MessageSpies < Cop
         include ConfigurableEnforcedStyle
 
-        MSG_RECEIVE = 'Prefer `receive` for setting message '\
-                      'expectations.'.freeze
+        MSG_RECEIVE = 'Prefer `receive` for setting message expectations.'
 
         MSG_HAVE_RECEIVED = 'Prefer `have_received` for setting message '\
                             'expectations. Setup `%<source>s` as a spy using '\
-                            '`allow` or `instance_spy`.'.freeze
+                            '`allow` or `instance_spy`.'
 
         SUPPORTED_STYLES = %w[have_received receive].freeze
 
         def_node_matcher :message_expectation, %(
-          (send (send nil? :expect $_) {:to :to_not :not_to} ...)
+          (send (send nil? :expect $_) #{Runners::ALL.node_pattern_union} ...)
         )
 
         def_node_search :receive_message, %(