rubocop-rspec 1.32.0 → 1.33.0

data/spec/rubocop/cop/rspec/unspecified_exception_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::UnspecifiedException do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/verified_doubles_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
   subject(:cop) { described_class.new(config) }
 

data/spec/rubocop/cop/rspec/void_expect_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::VoidExpect do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/yield_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::Yield do
   subject(:cop) { described_class.new }
 
@@ -6,6 +8,10 @@ RSpec.describe RuboCop::Cop::RSpec::Yield do
       allow(foo).to receive(:bar) { |&block| block.call }
                                   ^^^^^^^^^^^^^^^^^^^^^^^ Use `.and_yield`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      allow(foo).to receive(:bar).and_yield
+    RUBY
   end
 
   it 'flags multiple `block.call`' do
@@ -16,6 +22,10 @@ RSpec.describe RuboCop::Cop::RSpec::Yield do
         block.call
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      allow(foo).to receive(:bar).and_yield.and_yield
+    RUBY
   end
 
   it 'flags `block.call` with arguments' do
@@ -23,6 +33,10 @@ RSpec.describe RuboCop::Cop::RSpec::Yield do
       allow(foo).to receive(:bar) { |&block| block.call(1, 2) }
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `.and_yield`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      allow(foo).to receive(:bar).and_yield(1, 2)
+    RUBY
   end
 
   it 'flags multiple `block.call` with arguments' do
@@ -33,6 +47,10 @@ RSpec.describe RuboCop::Cop::RSpec::Yield do
          block.call(2)
        end
     RUBY
+
+    expect_correction(<<-RUBY)
+      allow(foo).to receive(:bar).and_yield(1).and_yield(2)
+    RUBY
   end
 
   it 'flags `block.call` when `receive` is chained' do
@@ -40,6 +58,10 @@ RSpec.describe RuboCop::Cop::RSpec::Yield do
       allow(foo).to receive(:bar).with(anything) { |&block| block.call }
                                                  ^^^^^^^^^^^^^^^^^^^^^^^ Use `.and_yield`.
     RUBY
+
+    expect_correction(<<-RUBY)
+      allow(foo).to receive(:bar).with(anything).and_yield
+    RUBY
   end
 
   it 'ignores `receive` with no block arguments' do
@@ -56,25 +78,4 @@ RSpec.describe RuboCop::Cop::RSpec::Yield do
       end
     RUBY
   end
-
-  include_examples 'autocorrect',
-                   'allow(foo).to receive(:bar) { |&block| block.call }',
-                   'allow(foo).to receive(:bar).and_yield'
-
-  include_examples 'autocorrect',
-                   'allow(foo).to receive(:bar) { |&block| block.call(1, 2) }',
-                   'allow(foo).to receive(:bar).and_yield(1, 2)'
-
-  bad_code = <<-RUBY
-    allow(foo).to receive(:bar) do |&block|
-      block.call(1)
-      block.call(2)
-    end
-  RUBY
-
-  good_code = <<-RUBY
-    allow(foo).to receive(:bar).and_yield(1).and_yield(2)
-  RUBY
-
-  include_examples 'autocorrect', bad_code, good_code
 end

data/spec/rubocop/rspec/config_formatter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop/rspec/config_formatter'
 
 RSpec.describe RuboCop::RSpec::ConfigFormatter do

data/spec/rubocop/rspec/description_extractor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yard'
 
 require 'rubocop/rspec/description_extractor'

data/spec/rubocop/rspec/language/selector_set_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::RSpec::Language::SelectorSet do
   subject(:selector_set) { described_class.new(%i[foo bar]) }
 

data/spec/rubocop/rspec/util/one_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::RSpec::Util, '.one' do
   let(:first)  { instance_double(Object)                          }
   let(:array)  { instance_double(Array, one?: true, first: first) }

data/spec/rubocop/rspec/wording_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::RSpec::Wording do
   let(:replacements) { { 'have' => 'has' } }
   let(:ignores)      { %w[only really]     }

data/spec/shared/autocorrect_behavior.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'autocorrect' do |original, corrected|
   it "autocorrects `#{original}` to `#{corrected}`" do
     autocorrected = autocorrect_source(original, 'spec/foo_spec.rb')

data/spec/shared/detects_style_behavior.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'detects style' do |source, style, filename: 'x_spec.rb'|
   it 'generates a todo based on the detected style' do
     inspect_source(source, filename)

data/spec/shared/smoke_test_examples.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'smoke test', type: :cop_spec do
   context 'with default configuration' do
     # This is overridden to avoid a number of specs that define `cop_config`

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 
 require 'rubocop/rspec/support'

data/spec/support/expect_offense.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # rubocop-rspec gem extension of RuboCop's ExpectOffense module.
 #
 # This mixin is the same as rubocop's ExpectOffense except the default
@@ -5,7 +7,7 @@
 module ExpectOffense
   include RuboCop::RSpec::ExpectOffense
 
-  DEFAULT_FILENAME = 'example_spec.rb'.freeze
+  DEFAULT_FILENAME = 'example_spec.rb'
 
   def expect_offense(source, filename = DEFAULT_FILENAME)
     super

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.32.0
+  version: 1.33.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-27 00:00:00.000000000 Z
+date: 2019-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -131,6 +131,7 @@ files:
 - lib/rubocop/cop/rspec/describe_method.rb
 - lib/rubocop/cop/rspec/describe_symbol.rb
 - lib/rubocop/cop/rspec/described_class.rb
+- lib/rubocop/cop/rspec/dialect.rb
 - lib/rubocop/cop/rspec/empty_example_group.rb
 - lib/rubocop/cop/rspec/empty_line_after_example_group.rb
 - lib/rubocop/cop/rspec/empty_line_after_final_let.rb
@@ -197,6 +198,7 @@ files:
 - lib/rubocop/rspec/description_extractor.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
+- lib/rubocop/rspec/factory_bot.rb
 - lib/rubocop/rspec/final_end_location.rb
 - lib/rubocop/rspec/hook.rb
 - lib/rubocop/rspec/inject.rb
@@ -226,6 +228,7 @@ files:
 - spec/rubocop/cop/rspec/describe_method_spec.rb
 - spec/rubocop/cop/rspec/describe_symbol_spec.rb
 - spec/rubocop/cop/rspec/described_class_spec.rb
+- spec/rubocop/cop/rspec/dialect_spec.rb
 - spec/rubocop/cop/rspec/empty_example_group_spec.rb
 - spec/rubocop/cop/rspec/empty_line_after_example_group_spec.rb
 - spec/rubocop/cop/rspec/empty_line_after_final_let_spec.rb
@@ -314,14 +317,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.0
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files
@@ -344,6 +347,7 @@ test_files:
 - spec/rubocop/cop/rspec/describe_method_spec.rb
 - spec/rubocop/cop/rspec/describe_symbol_spec.rb
 - spec/rubocop/cop/rspec/described_class_spec.rb
+- spec/rubocop/cop/rspec/dialect_spec.rb
 - spec/rubocop/cop/rspec/empty_example_group_spec.rb
 - spec/rubocop/cop/rspec/empty_line_after_example_group_spec.rb
 - spec/rubocop/cop/rspec/empty_line_after_final_let_spec.rb