rubocop-rspec 1.32.0 → 1.33.0

data/spec/rubocop/cop/rspec/implicit_expect_spec.rb

@@ -13,6 +13,10 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
         it { should be_truthy }
              ^^^^^^ Prefer `is_expected.to` over `should`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { is_expected.to be_truthy }
+      RUBY
     end
 
     it 'flags it { should_not }' do
@@ -20,6 +24,10 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
         it { should_not be_truthy }
              ^^^^^^^^^^ Prefer `is_expected.to_not` over `should_not`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { is_expected.to_not be_truthy }
+      RUBY
     end
 
     it 'approves of is_expected.to' do
@@ -35,13 +43,6 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
     end
 
     include_examples 'detects style', 'it { should be_truthy }', 'should'
-    include_examples 'autocorrect',
-                     'it { should be_truthy }',
-                     'it { is_expected.to be_truthy }'
-
-    include_examples 'autocorrect',
-                     'it { should_not be_truthy }',
-                     'it { is_expected.to_not be_truthy }'
   end
 
   context 'when EnforcedStyle is should' do
@@ -54,6 +55,10 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
         it { is_expected.to be_truthy }
              ^^^^^^^^^^^^^^ Prefer `should` over `is_expected.to`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { should be_truthy }
+      RUBY
     end
 
     it 'flags it { is_expected.to_not }' do
@@ -61,6 +66,10 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
         it { is_expected.to_not be_truthy }
              ^^^^^^^^^^^^^^^^^^ Prefer `should_not` over `is_expected.to_not`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { should_not be_truthy }
+      RUBY
     end
 
     it 'flags it { is_expected.not_to }' do
@@ -68,6 +77,10 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
         it { is_expected.not_to be_truthy }
              ^^^^^^^^^^^^^^^^^^ Prefer `should_not` over `is_expected.not_to`.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { should_not be_truthy }
+      RUBY
     end
 
     it 'approves of should' do
@@ -85,17 +98,5 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
     include_examples 'detects style',
                      'it { should be_truthy }',
                      'should'
-
-    include_examples 'autocorrect',
-                     'it { is_expected.to be_truthy }',
-                     'it { should be_truthy }'
-
-    include_examples 'autocorrect',
-                     'it { is_expected.to_not be_truthy }',
-                     'it { should_not be_truthy }'
-
-    include_examples 'autocorrect',
-                     'it { is_expected.not_to be_truthy }',
-                     'it { should_not be_truthy }'
   end
 end

data/spec/rubocop/cop/rspec/implicit_subject_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
   subject(:cop) { described_class.new(config) }
 
@@ -15,6 +17,12 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
           ^^^^^^^^^^^ Don't use implicit subject.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it 'expect subject to be used' do
+          expect(subject).to be_good
+        end
+      RUBY
     end
 
     it 'allows `is_expected` inside `its` block, in multi-line examples' do
@@ -30,6 +38,15 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
         it 'expect subject to be used' do
           should be_good
           ^^^^^^^^^^^^^^ Don't use implicit subject.
+          should_not be_bad
+          ^^^^^^^^^^^^^^^^^ Don't use implicit subject.
+        end
+      RUBY
+
+      expect_correction(<<-RUBY)
+        it 'expect subject to be used' do
+          expect(subject).to be_good
+          expect(subject).not_to be_bad
         end
       RUBY
     end
@@ -63,41 +80,13 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
                                   ^^^^^^^^^^^ Don't use implicit subject.
         end
       RUBY
-    end
 
-    bad_code = <<-RUBY
-      it 'works' do
-        is_expected.to be_truthy
-      end
-    RUBY
-
-    good_code = <<-RUBY
-      it 'works' do
-        expect(subject).to be_truthy
-      end
-    RUBY
-
-    include_examples 'autocorrect',
-                     bad_code,
-                     good_code
-
-    bad_code = <<-RUBY
-      it 'works' do
-        should be_truthy
-        should_not be_falsy
-      end
-    RUBY
-
-    good_code = <<-RUBY
-      it 'works' do
-        expect(subject).to be_truthy
-        expect(subject).not_to be_falsy
-      end
-    RUBY
-
-    include_examples 'autocorrect',
-                     bad_code,
-                     good_code
+      expect_correction(<<-RUBY)
+        def permits(actions)
+          actions.each { |action| expect(subject).to permit_action(action) }
+        end
+      RUBY
+    end
   end
 
   context 'with EnforcedStyle `single_statement_only`' do
@@ -119,29 +108,14 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
           ^^^^^^^^^^^ Don't use implicit subject.
         end
       RUBY
-    end
 
-    bad_code = <<-RUBY
-      it 'is valid' do
-        subject.age = 18
-        is_expected.to be_valid
-      end
-    RUBY
-
-    good_code = <<-RUBY
-      it 'is valid' do
-        subject.age = 18
-        expect(subject).to be_valid
-      end
-    RUBY
-
-    include_examples 'autocorrect',
-                     bad_code,
-                     good_code
-
-    include_examples 'autocorrect',
-                     bad_code,
-                     good_code
+      expect_correction(<<-RUBY)
+        it 'expect subject to be used' do
+          subject.age = 18
+          expect(subject).to be_valid
+        end
+      RUBY
+    end
   end
 
   context 'with EnforcedStyle `disallow`' do
@@ -154,6 +128,12 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
           ^^^^^^^^^^^ Don't use implicit subject.
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it 'expect subject to be used' do
+          expect(subject).to be_good
+        end
+      RUBY
     end
 
     it 'flags `is_expected` in single-line examples' do
@@ -161,6 +141,10 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
         it { is_expected.to be_good }
              ^^^^^^^^^^^ Don't use implicit subject.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it { expect(subject).to be_good }
+      RUBY
     end
 
     it 'flags `should` in multi-line examples' do
@@ -168,6 +152,15 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
         it 'expect subject to be used' do
           should be_good
           ^^^^^^^^^^^^^^ Don't use implicit subject.
+          should_not be_bad
+          ^^^^^^^^^^^^^^^^^ Don't use implicit subject.
+        end
+      RUBY
+
+      expect_correction(<<-RUBY)
+        it 'expect subject to be used' do
+          expect(subject).to be_good
+          expect(subject).not_to be_bad
         end
       RUBY
     end
@@ -176,6 +169,13 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
       expect_offense(<<-RUBY)
         it { should be_good }
              ^^^^^^^^^^^^^^ Don't use implicit subject.
+        it { should_not be_bad }
+             ^^^^^^^^^^^^^^^^^ Don't use implicit subject.
+      RUBY
+
+      expect_correction(<<-RUBY)
+        it { expect(subject).to be_good }
+        it { expect(subject).not_to be_bad }
       RUBY
     end
 
@@ -184,17 +184,5 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
         its(:quality) { is_expected.to be :high }
       RUBY
     end
-
-    include_examples 'autocorrect',
-                     'it { is_expected.to be_truthy }',
-                     'it { expect(subject).to be_truthy }'
-
-    include_examples 'autocorrect',
-                     'it { should be_truthy }',
-                     'it { expect(subject).to be_truthy }'
-
-    include_examples 'autocorrect',
-                     'it { should_not be_truthy }',
-                     'it { expect(subject).not_to be_truthy }'
   end
 end

data/spec/rubocop/cop/rspec/instance_spy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
   subject(:cop) { described_class.new }
 
@@ -10,6 +12,13 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
           expect(foo).to have_received(:bar)
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          foo = instance_spy(Foo)
+          expect(foo).to have_received(:bar)
+        end
+      RUBY
     end
 
     it 'adds an offense for an instance_double with multiple arguments' do
@@ -20,6 +29,13 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
           expect(foo).to have_received(:bar)
         end
       RUBY
+
+      expect_correction(<<-RUBY)
+        it do
+          foo = instance_spy(Foo, :name)
+          expect(foo).to have_received(:bar)
+        end
+      RUBY
     end
 
     it 'ignores instance_double when it is not used with as_null_object' do
@@ -42,19 +58,4 @@ RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
       RUBY
     end
   end
-
-  original = <<-RUBY
-    it do
-      foo = instance_double(Foo, :name).as_null_object
-      expect(foo).to have_received(:bar)
-    end
-  RUBY
-  corrected = <<-RUBY
-    it do
-      foo = instance_spy(Foo, :name)
-      expect(foo).to have_received(:bar)
-    end
-  RUBY
-
-  include_examples 'autocorrect', original, corrected
 end

data/spec/rubocop/cop/rspec/instance_variable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/invalid_predicate_matcher_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::InvalidPredicateMatcher do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/it_behaves_like_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::ItBehavesLike, :config do
   subject(:cop) { described_class.new(config) }
 
@@ -13,17 +15,15 @@ RSpec.describe RuboCop::Cop::RSpec::ItBehavesLike, :config do
         it_should_behave_like 'a foo'
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `it_behaves_like` over `it_should_behave_like` when including examples in a nested context.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it_behaves_like 'a foo'
+      RUBY
     end
 
     it 'does not flag a violation for it_behaves_like' do
       expect_no_offenses("it_behaves_like 'a foo'")
     end
-
-    include_examples(
-      'autocorrect',
-      "foo(); it_should_behave_like 'a foo'",
-      "foo(); it_behaves_like 'a foo'"
-    )
   end
 
   context 'when the enforced style is `it_should_behave_like`' do
@@ -34,16 +34,14 @@ RSpec.describe RuboCop::Cop::RSpec::ItBehavesLike, :config do
         it_behaves_like 'a foo'
         ^^^^^^^^^^^^^^^^^^^^^^^ Prefer `it_should_behave_like` over `it_behaves_like` when including examples in a nested context.
       RUBY
+
+      expect_correction(<<-RUBY)
+        it_should_behave_like 'a foo'
+      RUBY
     end
 
     it 'does not flag a violation for it_behaves_like' do
       expect_no_offenses("it_should_behave_like 'a foo'")
     end
-
-    include_examples(
-      'autocorrect',
-      "foo(); it_behaves_like 'a foo'",
-      "foo(); it_should_behave_like 'a foo'"
-    )
   end
 end

data/spec/rubocop/cop/rspec/iterated_expectation_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe RuboCop::Cop::RSpec::IteratedExpectation do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/leading_subject_spec.rb

@@ -12,6 +12,14 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations.
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        subject { described_class.new }
+        let(:params) { foo }
+
+      end
+    RUBY
   end
 
   it 'checks subject below let!' do
@@ -23,6 +31,14 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let!` declarations.
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        subject { described_class.new }
+        let!(:params) { foo }
+
+      end
+    RUBY
   end
 
   it 'approves of subject above let' do
@@ -72,6 +88,14 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `before` declarations.
       end
     RUBY
+
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        subject { described_class.new }
+        before { allow(Foo).to receive(:bar) }
+
+      end
+    RUBY
   end
 
   it 'checks subject below example' do
@@ -83,53 +107,13 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `it` declarations.
       end
     RUBY
-  end
 
-  bad_code = <<-RUBY
-    RSpec.describe User do
-      before { allow(Foo).to receive(:bar) }
-      let(:params) { foo }
-      let(:bar) { baz }
-
-      subject { described_class.new }
-      it { is_expected.to do_something }
-    end
-  RUBY
-
-  good_code = <<-RUBY
-    RSpec.describe User do
-      subject { described_class.new }
-      before { allow(Foo).to receive(:bar) }
-      let(:params) { foo }
-      let(:bar) { baz }
-
-      it { is_expected.to do_something }
-    end
-  RUBY
-
-  include_examples 'autocorrect', bad_code, good_code
-
-  bad_code = <<-RUBY
-    RSpec.describe User do
-      let(:params) { foo }
-      let(:bar) { baz }
-      subject do
-        described_class.new
-      end
-      it { is_expected.to do_something }
-    end
-  RUBY
-
-  good_code = <<-RUBY
-    RSpec.describe User do
-      subject do
-        described_class.new
-      end
-      let(:params) { foo }
-      let(:bar) { baz }
-      it { is_expected.to do_something }
-    end
-  RUBY
+    expect_correction(<<-RUBY)
+      RSpec.describe User do
+        subject { described_class.new }
+        it { is_expected.to be_present }
 
-  include_examples 'autocorrect', bad_code, good_code
+      end
+    RUBY
+  end
 end