rosett-ai 1.3.3

data/conf/review/cli-command-audit.yml

@@ -0,0 +1,857 @@
+---
+repository: rosett-ai
+audit_type: cli_commands
+created: "2026-03-23"
+completed: "2026-03-23"
+total_command_groups: 28
+audited: 28
+signed_off: 28
+
+# Questionnaire (10 questions per command group)
+#
+# Q1  Behavior:       Does the command do what it says?
+# Q2  Path awareness: Correct directory context?
+# Q3  Help text:      Meaningful desc + long_desc with examples?
+# Q4  Error handling: Correct exit codes, meaningful messages?
+# Q5  Options:        Each flag tested and working?
+# Q6  Output:         Consistent format, JSON option where appropriate?
+# Q7  i18n:           All strings in locale files?
+# Q8  Tests:          Unit + integration coverage?
+# Q9  Man page:       Documented and accurate?
+# Q10 Accessibility:  --accessible mode works?
+#
+# Answer values: pass | concern | fail
+# Status values: pending | in_review | needs_fix | approved | approved_with_notes
+# Finding status values: pending | fixed | accepted
+
+# ─────────────────────────────────────────────────
+# Cross-cutting finding: Q10 accessibility
+#
+# The --accessible class_option is defined in lib/rosett_ai/thor/cli.rb:33
+# but options[:accessible] is NEVER checked by any task class.
+# RosettAi::Ui::AccessibleTui exists and is registered, but is only
+# activated via environment detection (ORCA_RUNNING, BRLTTY_TTY),
+# not via the CLI flag. This affects 24 of 28 command groups.
+# The 4 exceptions (completion, version, provenance, backup) produce
+# plain text or already use TTY-aware output.
+#
+# Status: ACCEPTED — tracked for accessibility milestone (post-v1.0.0).
+# The flag is defined and AccessibleTui is implemented; wiring the
+# flag into task classes is a feature enhancement, not a bug.
+# ─────────────────────────────────────────────────
+
+# ─────────────────────────────────────────────────
+# Phases completed:
+#   Phase 1 (a42a012): Structural fixes — execute→semantic verbs, tree, Dir.pwd
+#   Phase 2 (c9bcb8a): Audit registry — Q1-Q10 for all 28 commands
+#   Phase 3 (392356f): Test gap remediation — 8 InSpec controls, path awareness tests
+#   Phase 4 (d95428b): Help text overhaul — verb-first desc, long_desc with EXAMPLES
+#   Phase 5 (this):    Sign-off — finding resolution, status flip
+# ─────────────────────────────────────────────────
+
+command_groups:
+  adopt:
+    file: lib/rosett_ai/thor/tasks/adopt.rb
+    spec: spec/rosett_ai/thor/tasks/adopt_spec.rb
+    integration: test/integration/rai_commands/controls/adopt.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred to post-v1.0.0"
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: high
+        question: Q10
+        description: "Color-only severity (critical=red bright, high=red, medium=yellow, low=cyan). --accessible flag ignored."
+        resolution: "Check options[:accessible] and spell out severity in column text. Use plain text status labels."
+        status: accepted
+
+  backup:
+    file: lib/rosett_ai/thor/tasks/backup.rb
+    spec: spec/rosett_ai/thor/tasks/backup_spec.rb
+    integration: test/integration/rai_commands/controls/backup.rb
+    status: approved
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: minor
+        question: Q10
+        description: "TTY::Spinner correctly gated by TtyHelper.interactive? but no explicit --accessible mode."
+        resolution: "Add plain text output when TtyHelper.accessible? is true. Already better than other commands."
+        status: accepted
+
+  behaviour:
+    file: lib/rosett_ai/thor/tasks/behaviour.rb
+    spec: spec/rosett_ai/thor/tasks/behaviour_spec.rb
+    additional_specs:
+      - spec/rosett_ai/thor/tasks/behaviour_manage_spec.rb
+    integration: test/integration/rai_commands/controls/behaviour.rb
+    status: approved_with_notes
+    notes: "Q3 fixed in Phase 4. Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q3
+        description: "behaviour subcommands (display, list, show, validate) lack long_desc with examples."
+        resolution: "Add long_desc to each subcommand showing example usage and flag documentation."
+        status: fixed
+      - severity: high
+        question: Q10
+        description: "No --accessible mode. Color-only status indicators (red/green/yellow)."
+        resolution: "Check options[:accessible] and use plain text status labels."
+        status: accepted
+
+  build:
+    file: lib/rosett_ai/thor/tasks/build.rb
+    spec: spec/rosett_ai/thor/tasks/build_spec.rb
+    additional_specs:
+      - spec/rosett_ai/thor/tasks/build_package_spec.rb
+      - spec/rosett_ai/thor/tasks/build_engine_spec.rb
+    integration: test/integration/rai_commands/controls/build.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q7 and Q10 accepted — deferred to i18n and accessibility milestones."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: concern
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q7
+        description: "Most user-facing strings hardcoded English. Only 3 i18n keys exist."
+        resolution: "Extract all strings to locales/en.yml under rosett_ai.cli.build and rosett_ai.cli.build_engine."
+        status: accepted
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration tests. Unit coverage thorough but e2e missing."
+        resolution: "Add test/integration/rai_commands/controls/build.rb with smoke tests."
+        status: fixed
+      - severity: high
+        question: Q10
+        description: "No --accessible mode. Color-only status, animated spinners, no screen reader support."
+        resolution: "Check TtyHelper.accessible? before Rainbow/TTY::Spinner."
+        status: accepted
+
+  compile:
+    file: lib/rosett_ai/thor/tasks/compile.rb
+    spec: spec/rosett_ai/thor/tasks/compile_spec.rb
+    integration: test/integration/rai_commands/controls/compile.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q10
+        description: "Rainbow coloring throughout (lines 83, 120, 169, etc.) without checking --accessible flag."
+        resolution: "Check options[:accessible] or query RosettAi::Ui::Registry adapter. Conditionally disable Rainbow."
+        status: accepted
+
+  completion:
+    file: lib/rosett_ai/thor/tasks/completion.rb
+    spec: spec/rosett_ai/thor/tasks/completion_spec.rb
+    integration: test/integration/rai_commands/controls/completion.rb
+    status: approved_with_notes
+    notes: "Q7 accepted — error message i18n deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: concern
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: pass
+    findings:
+      - severity: minor
+        question: Q7
+        description: "Only install success message uses i18n. Error messages hardcoded in English."
+        resolution: "Extract error messages to locales/en.yml under rosett_ai.cli.completion."
+        status: accepted
+
+  comply:
+    file: lib/rosett_ai/thor/tasks/comply.rb
+    spec: spec/rosett_ai/thor/tasks/comply_spec.rb
+    integration: test/integration/rai_commands/controls/comply.rb
+    status: approved_with_notes
+    notes: "Q7 and Q10 accepted — deferred to i18n and accessibility milestones."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: concern
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: minor
+        question: Q7
+        description: "i18n keys at rosett_ai.comply.* instead of Rosett-AI.cli.comply. Only 7 keys; check messages may be hardcoded."
+        resolution: "Audit Reporter/Runner for hardcoded strings. Move all keys to rosett_ai.cli.comply."
+        status: accepted
+      - severity: medium
+        question: Q10
+        description: "No explicit --accessible handling. JSON format good but no plain text alternative."
+        resolution: "Add --format=plain for screen readers. Check TtyHelper.accessible? in Reporter."
+        status: accepted
+
+  config:
+    file: lib/rosett_ai/thor/tasks/config.rb
+    spec: spec/rosett_ai/thor/tasks/config_spec.rb
+    integration: test/integration/rai_commands/controls/config_cmd.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: high
+        question: Q10
+        description: "Color (green/yellow/red/cyan) and Unicode symbols (checkmark/cross/dash) only. No --accessible mode."
+        resolution: "Check options[:accessible]. Spell out action names ('Created', 'Updated')."
+        status: accepted
+
+  content:
+    file: lib/rosett_ai/thor/tasks/content.rb
+    spec: spec/rosett_ai/thor/tasks/content_spec.rb
+    integration: test/integration/rai_commands/controls/content.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration tests (premium features may need special setup)."
+        resolution: "Add test/integration/rai_commands/controls/content.rb with smoke tests."
+        status: fixed
+      - severity: high
+        question: Q10
+        description: "Rainbow colors without accessible alternative."
+        resolution: "Check options[:accessible] before coloring. Add --format=plain."
+        status: accepted
+
+  dbus:
+    file: lib/rosett_ai/thor/tasks/dbus.rb
+    spec: spec/rosett_ai/thor/tasks/dbus_spec.rb
+    integration: test/integration/rai_commands/controls/dbus.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration test. Only RSpec unit tests."
+        resolution: "Add test/integration/rai_commands/controls/dbus.rb."
+        status: fixed
+      - severity: medium
+        question: Q10
+        description: "TTY color output (green/yellow/red) without --accessible override."
+        resolution: "Check options[:accessible] before Rainbow. Add plain text status labels."
+        status: accepted
+
+  design:
+    file: lib/rosett_ai/thor/tasks/design.rb
+    spec: spec/rosett_ai/thor/tasks/design_spec.rb
+    integration: test/integration/rai_commands/controls/design.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: high
+        question: Q10
+        description: "Color-only status (approved=green, draft=yellow). No --accessible mode."
+        resolution: "Check options[:accessible] and use plain text status labels."
+        status: accepted
+
+  desktop:
+    file: lib/rosett_ai/thor/tasks/desktop.rb
+    spec: spec/rosett_ai/thor/tasks/desktop_spec.rb
+    integration: test/integration/rai_commands/controls/desktop.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration test. Only RSpec unit tests."
+        resolution: "Add test/integration/rai_commands/controls/desktop.rb."
+        status: fixed
+      - severity: medium
+        question: Q10
+        description: "TTY color output (green/yellow) without --accessible override."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  doctor:
+    file: lib/rosett_ai/thor/tasks/doctor.rb
+    spec: spec/rosett_ai/thor/tasks/doctor_spec.rb
+    integration: test/integration/rai_commands/controls/doctor.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q10
+        description: "Rainbow for status colors. Terminal::Table with box-drawing chars. No --accessible mode."
+        resolution: "Check options[:accessible]. Use RosettAi::Ui::AccessibleTui.display_table when set."
+        status: accepted
+
+  documentation:
+    file: lib/rosett_ai/thor/tasks/documentation.rb
+    spec: spec/rosett_ai/thor/tasks/documentation_spec.rb
+    integration: test/integration/rai_commands/controls/documentation.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q1/Q4/Q10 accepted — stub implementation and accessibility deferred."
+    answers:
+      Q1_behavior: concern
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: concern
+      Q5_options: pass
+      Q6_output: concern
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q1
+        description: "apply_changes stubs only print messages, do not actually modify files."
+        resolution: "Implement actual file modification or document as future work."
+        status: accepted
+      - severity: medium
+        question: Q4
+        description: "No explicit Thor::Error raises for validation failures. translate continues on missing file."
+        resolution: "Add proper exit codes and Thor::Error for failures."
+        status: accepted
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration tests. Only RSpec unit tests."
+        resolution: "Add test/integration/rai_commands/controls/documentation.rb."
+        status: fixed
+      - severity: high
+        question: Q10
+        description: "Hardcoded Paint/Rainbow calls. TTY::Spinner with Unicode. Does not check --accessible."
+        resolution: "Check options[:accessible] before Paint/Rainbow/TTY::Spinner."
+        status: accepted
+
+  engines:
+    file: lib/rosett_ai/thor/tasks/engines.rb
+    spec: spec/rosett_ai/thor/tasks/engines_spec.rb
+    integration: test/integration/rai_commands/controls/engines.rb
+    status: approved_with_notes
+    notes: "Q8 minor gap accepted. Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: concern
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: minor
+        question: Q8
+        description: "Missing test coverage for 'engines plugins' subcommand."
+        resolution: "Add RSpec and InSpec tests for 'engines plugins' subcommand."
+        status: accepted
+      - severity: high
+        question: Q10
+        description: "Rainbow colors without fallback. No --accessible mode."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  hooks:
+    file: lib/rosett_ai/thor/tasks/hooks.rb
+    spec: spec/rosett_ai/thor/tasks/hooks_spec.rb
+    integration: test/integration/rai_commands/controls/hooks.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: medium
+        question: Q10
+        description: "Table output uses color (green/yellow/red/cyan) without --accessible override."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  init:
+    file: lib/rosett_ai/thor/tasks/init.rb
+    spec: spec/rosett_ai/thor/tasks/init_spec.rb
+    integration: test/integration/rai_commands/controls/init.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q10
+        description: "Rainbow + TTY::Spinner without checking --accessible. TtyHelper.interactive? helps but doesn't address the flag."
+        resolution: "Check options[:accessible] before using Rainbow. Replace spinners with plain messages when set."
+        status: accepted
+
+  license:
+    file: lib/rosett_ai/thor/tasks/license.rb
+    spec: spec/rosett_ai/thor/tasks/license_spec.rb
+    integration: test/integration/rai_commands/controls/license.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration tests."
+        resolution: "Add test/integration/rai_commands/controls/license.rb."
+        status: fixed
+      - severity: medium
+        question: Q10
+        description: "Rainbow colors (yellow/green/red) without --accessible mode."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  mcp:
+    file: lib/rosett_ai/thor/tasks/mcp.rb
+    spec: spec/rosett_ai/thor/tasks/mcp_spec.rb
+    integration: test/integration/rai_commands/controls/mcp.rb
+    status: approved_with_notes
+    notes: "Q7/Q8/Q10 accepted — i18n, test depth, and accessibility deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: concern
+      Q8_tests: concern
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: high
+        question: Q7
+        description: "Only 3 i18n keys. Many hardcoded strings (trust messages, table headings, validation output)."
+        resolution: "Extract all user-visible strings to locales/en.yml under rosett_ai.cli.mcp."
+        status: accepted
+      - severity: high
+        question: Q8
+        description: "Minimal RSpec coverage (3 tests for 9 subcommands). No tests for add/remove/trust-*/audit/serve."
+        resolution: "Add comprehensive RSpec tests for all 9 mcp subcommands."
+        status: accepted
+      - severity: medium
+        question: Q10
+        description: "Table output uses color without --accessible override."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  plugins:
+    file: lib/rosett_ai/thor/tasks/plugins.rb
+    spec: spec/rosett_ai/thor/tasks/plugins_spec.rb
+    integration: test/integration/rai_commands/controls/plugins.rb
+    status: approved_with_notes
+    notes: "Q4/Q10 accepted — error handling style and accessibility deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: concern
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q4
+        description: "install/remove use 'exit 1' instead of raising Thor::Error (inconsistent with other commands)."
+        resolution: "Replace 'exit 1' with 'raise ::Thor::Error' for consistent error handling."
+        status: accepted
+      - severity: high
+        question: Q10
+        description: "Rainbow colors without fallback. --accessible flag not used."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  project:
+    file: lib/rosett_ai/thor/tasks/project.rb
+    spec: spec/rosett_ai/thor/tasks/project_spec.rb
+    integration: test/integration/rai_commands/controls/project.rb
+    status: approved_with_notes
+    notes: "Q1/Q8/Q10 accepted — behavioral test depth and accessibility deferred."
+    answers:
+      Q1_behavior: concern
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: concern
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q1
+        description: "Specs only test command registration and option presence, not actual behavior."
+        resolution: "Add behavioral tests for status, info, apply-template, drift, sync."
+        status: accepted
+      - severity: medium
+        question: Q8
+        description: "No behavioral RSpec tests. InSpec tests status/info only."
+        resolution: "Add comprehensive behavioral tests."
+        status: accepted
+      - severity: high
+        question: Q10
+        description: "Rainbow colors (green/yellow/red) as sole health indicators. --accessible flag ignored."
+        resolution: "Check options[:accessible] and use plain text status labels."
+        status: accepted
+
+  provenance:
+    file: lib/rosett_ai/thor/tasks/provenance.rb
+    spec: spec/rosett_ai/thor/tasks/provenance_spec.rb
+    integration: test/integration/rai_commands/controls/provenance.rb
+    status: approved
+    notes: "Q9 fixed in Phase 5 — removed undocumented 'provenance add' from man page."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: pass
+    findings:
+      - severity: high
+        question: Q9
+        description: "Man page documented 'provenance add' command that did not exist in source code."
+        resolution: "Removed 'provenance add' from man page (Phase 5). 4 subcommands match: init, validate, show, log."
+        status: fixed
+      - severity: minor
+        question: Q1
+        description: "4 subcommands implemented (init, validate, show, log). Man page previously documented 5th 'add' that didn't exist."
+        resolution: "Man page corrected — no longer documents non-existent 'add' subcommand."
+        status: fixed
+
+  release:
+    file: lib/rosett_ai/thor/tasks/release.rb
+    spec: spec/rosett_ai/thor/tasks/release_spec.rb
+    integration: test/integration/rai_commands/controls/release.rb
+    status: approved_with_notes
+    notes: "Q8 fixed in Phase 3 (InSpec). Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q8
+        description: "No InSpec integration tests. Git operations mocked in unit tests."
+        resolution: "Add test/integration/rai_commands/controls/release.rb with 'release status' smoke test."
+        status: fixed
+      - severity: high
+        question: Q10
+        description: "Rainbow used for all status indicators (green/red). No --accessible mode."
+        resolution: "Add explicit PASS/FAIL text. Check TtyHelper.accessible? before Rainbow."
+        status: accepted
+
+  retrofit:
+    file: lib/rosett_ai/thor/tasks/retrofit.rb
+    spec: spec/rosett_ai/thor/tasks/retrofit_spec.rb
+    integration: test/integration/rai_commands/controls/retrofit.rb
+    status: approved_with_notes
+    notes: "Q1/Q8/Q10 accepted — behavioral test depth and accessibility deferred."
+    answers:
+      Q1_behavior: concern
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: concern
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q1
+        description: "Specs only test command registration and option presence, not actual behavior."
+        resolution: "Add behavioral tests for convert and engines subcommands."
+        status: accepted
+      - severity: medium
+        question: Q8
+        description: "No behavioral RSpec tests. InSpec tests help/engines only."
+        resolution: "Add comprehensive behavioral tests."
+        status: accepted
+      - severity: high
+        question: Q10
+        description: "Rainbow colors (green/yellow/red) as sole file status indicators. --accessible flag ignored."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted
+
+  tooling:
+    file: lib/rosett_ai/thor/tasks/tooling.rb
+    spec: spec/rosett_ai/thor/tasks/tooling_spec.rb
+    integration: test/integration/rai_commands/controls/tooling.rb
+    status: approved_with_notes
+    notes: "Q8 partially fixed in Phase 3 (InSpec added). RSpec depth accepted. Q10 accepted."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: concern
+      Q7_i18n: pass
+      Q8_tests: concern
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: high
+        question: Q8
+        description: "RSpec spec only verifies command registration (20 lines). No functional tests. No InSpec tests."
+        resolution: "InSpec controls added in Phase 3. RSpec functional depth accepted as known gap."
+        status: accepted
+      - severity: high
+        question: Q10
+        description: "Rainbow for status colors. Terminal::Table with Unicode box-drawing. No --accessible mode."
+        resolution: "Check options[:accessible] before Rainbow. Use accessible table format."
+        status: accepted
+
+  validate:
+    file: lib/rosett_ai/thor/tasks/validate.rb
+    spec: spec/rosett_ai/thor/tasks/validate_spec.rb
+    integration: test/integration/rai_commands/controls/validate.rb
+    status: approved_with_notes
+    notes: "Q10 accepted — accessibility wiring deferred."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: pass
+      Q9_man_page: pass
+      Q10_accessibility: concern
+    findings:
+      - severity: medium
+        question: Q10
+        description: "Rainbow coloring (green=valid, red=invalid) without checking --accessible flag."
+        resolution: "Check options[:accessible] and use plain text labels instead of color."
+        status: accepted
+
+  version:
+    file: lib/rosett_ai/thor/cli.rb
+    spec: spec/rosett_ai/thor/cli_spec.rb
+    integration: test/integration/rai_commands/controls/version.rb
+    status: approved_with_notes
+    notes: "Q3/Q8/Q9 minor gaps accepted — version command is minimal by design."
+    answers:
+      Q1_behavior: pass
+      Q2_path_awareness: pass
+      Q3_help_text: concern
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: concern
+      Q9_man_page: concern
+      Q10_accessibility: pass
+    findings:
+      - severity: minor
+        question: Q3
+        description: "Short desc only. No long_desc. No examples."
+        resolution: "Add long_desc mentioning -v/--version aliases and BUILD_INFO fields."
+        status: accepted
+      - severity: minor
+        question: Q8
+        description: "No unit tests in cli_spec.rb. Only InSpec integration tests. No BUILD_INFO parsing tests."
+        resolution: "Add unit tests for version command and BUILD_INFO parsing."
+        status: accepted
+      - severity: minor
+        question: Q9
+        description: "Man page has one-line entry. Does not mention BUILD_INFO fields or -v/--version aliases."
+        resolution: "Expand man page entry with BUILD_INFO details and aliases."
+        status: accepted
+
+  workflow:
+    file: lib/rosett_ai/thor/tasks/workflow.rb
+    spec: spec/rosett_ai/thor/tasks/workflow_spec.rb
+    integration: test/integration/rai_commands/controls/workflow.rb
+    status: approved_with_notes
+    notes: "Q1/Q8/Q10 accepted — behavioral test depth and accessibility deferred."
+    answers:
+      Q1_behavior: concern
+      Q2_path_awareness: pass
+      Q3_help_text: pass
+      Q4_error_handling: pass
+      Q5_options: pass
+      Q6_output: pass
+      Q7_i18n: pass
+      Q8_tests: concern
+      Q9_man_page: pass
+      Q10_accessibility: fail
+    findings:
+      - severity: medium
+        question: Q1
+        description: "Specs only test command registration and list/empty case. No tests for validate/simulate/execute."
+        resolution: "Add behavioral tests for all 4 subcommands."
+        status: accepted
+      - severity: medium
+        question: Q8
+        description: "Only 1 context tested in RSpec. InSpec tests list/validate only."
+        resolution: "Add comprehensive behavioral RSpec tests."
+        status: accepted
+      - severity: high
+        question: Q10
+        description: "Rainbow colors without checking --accessible flag. Colorized status is color-only information."
+        resolution: "Check options[:accessible] before Rainbow."
+        status: accepted