reek 5.3.1 → 5.3.2

data/spec/reek/smell_detectors/too_many_methods_spec.rb

@@ -7,14 +7,14 @@ RSpec.describe Reek::SmellDetectors::TooManyMethods do
   end
 
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo; end
         def charlie; end
         def delta; end
         def echo; end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyMethods,
                            lines:   [1],
@@ -25,19 +25,19 @@ RSpec.describe Reek::SmellDetectors::TooManyMethods do
   end
 
   it 'does not report if we stay below max_methods' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo; end
         def charlie; end
         def delta; end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyMethods).with_config(config)
   end
 
   it 'stops at a nested module' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo; end
         def charlie; end
@@ -47,7 +47,7 @@ RSpec.describe Reek::SmellDetectors::TooManyMethods do
           def echo; end
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyMethods).with_config(config)
   end

data/spec/reek/smell_detectors/too_many_statements_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
   end
 
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           charlie = 1
@@ -15,7 +15,7 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
           echo    = 3
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyStatements,
                            lines:   [2],
@@ -26,7 +26,7 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           charlie = 1
@@ -40,7 +40,7 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
           india = 3
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:TooManyStatements, lines: [2], context: 'Alfa#bravo').with_config(config).
@@ -48,20 +48,20 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
   end
 
   it 'does not report short methods' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           charlie = 1
           delta   = 2
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyStatements).with_config(config)
   end
 
   it 'does not report initialize' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def initialize
           charlie = 1
@@ -69,13 +69,13 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
           echo    = 3
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyStatements).with_config(config)
   end
 
   it 'reports long inner block' do
-    src = <<-EOS
+    src = <<-RUBY
       def long
         self.each do |x|
           charlie = 1
@@ -83,7 +83,7 @@ RSpec.describe Reek::SmellDetectors::TooManyStatements do
           echo    = 3
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyStatements).with_config(config)
   end

data/spec/reek/smell_detectors/uncommunicative_method_name_spec.rb

@@ -3,9 +3,9 @@ require_lib 'reek/smell_detectors/uncommunicative_method_name'
 
 RSpec.describe Reek::SmellDetectors::UncommunicativeMethodName do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def m; end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UncommunicativeMethodName,
                            lines:   [1],

data/spec/reek/smell_detectors/uncommunicative_module_name_spec.rb

@@ -3,10 +3,10 @@ require_lib 'reek/smell_detectors/uncommunicative_module_name'
 
 RSpec.describe Reek::SmellDetectors::UncommunicativeModuleName do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class K
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UncommunicativeModuleName,
                            lines:   [1],

data/spec/reek/smell_detectors/uncommunicative_parameter_name_spec.rb

@@ -3,11 +3,11 @@ require_lib 'reek/smell_detectors/uncommunicative_parameter_name'
 
 RSpec.describe Reek::SmellDetectors::UncommunicativeParameterName do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(x)
         x
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UncommunicativeParameterName,
                            lines:   [1],
@@ -18,11 +18,11 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeParameterName do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(x, y)
         [x, y]
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:UncommunicativeParameterName, lines: [1], name: 'x').

data/spec/reek/smell_detectors/uncommunicative_variable_name_spec.rb

@@ -3,11 +3,11 @@ require_lib 'reek/smell_detectors/uncommunicative_variable_name'
 
 RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         x = 5
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UncommunicativeVariableName,
                            lines:   [2],
@@ -18,12 +18,12 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         x = 3
         y = 7
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UncommunicativeVariableName, lines: [2], name: 'x').
       and reek_of(:UncommunicativeVariableName, lines: [3], name: 'y')
@@ -80,64 +80,64 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
 
   context 'when examining block parameters' do
     it 'reports all relevant block parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           @bravo.map { |x, y| x + y }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'x').
         and reek_of(:UncommunicativeVariableName, name: 'y')
     end
 
     it 'reports block parameters used outside of methods' do
-      src = <<-EOS
+      src = <<-RUBY
         class Alfa
           @bravo.map { |x| x * 2 }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'x')
     end
 
     it 'reports splatted block parameters correctly' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           @bravo.map { |*y| y << 1 }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'y')
     end
 
     it 'reports nested block parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           @bravo.map { |(x, y)| x + y }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'x').
         and reek_of(:UncommunicativeVariableName, name: 'y')
     end
 
     it 'reports splatted nested block parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         def def alfa
           @bravo.map { |(x, *y)| x + y }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'x').
         and reek_of(:UncommunicativeVariableName, name: 'y')
     end
 
     it 'reports deeply nested block parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           @bravo.map { |(x, (y, z))| x + y + z }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'x').
         and reek_of(:UncommunicativeVariableName, name: 'y').
@@ -145,11 +145,11 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
     end
 
     it 'reports shadowed block parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           @bravo.map { |x; y| y = x * 2 }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:UncommunicativeVariableName, name: 'x').
         and reek_of(:UncommunicativeVariableName, name: 'y')

data/spec/reek/smell_detectors/unused_parameters_spec.rb

@@ -3,10 +3,10 @@ require_lib 'reek/smell_detectors/unused_parameters'
 
 RSpec.describe Reek::SmellDetectors::UnusedParameters do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UnusedParameters,
                            lines:   [1],
@@ -17,10 +17,10 @@ RSpec.describe Reek::SmellDetectors::UnusedParameters do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo, charlie)
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:UnusedParameters, lines: [1], name: 'bravo').

data/spec/reek/smell_detectors/unused_private_method_spec.rb

@@ -3,14 +3,14 @@ require_lib 'reek/smell_detectors/unused_private_method'
 
 RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         private
 
         def charlie
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:UnusedPrivateMethod,
                            lines:   [4],
@@ -21,7 +21,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         private
 
@@ -31,7 +31,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
         def charlie
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:UnusedPrivateMethod, lines: [4], name: 'charlie').
@@ -40,13 +40,13 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
 
   context 'when a class has unused private methods' do
     it 'reports instance methods' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           private
           def bravo; end
           def charlie; end
         end
-      EOF
+      RUBY
 
       expect(source).
         to reek_of(:UnusedPrivateMethod, name: 'bravo').
@@ -54,14 +54,14 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
 
     it 'reports instance methods in the correct class' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           class Bravo
             private
             def charlie; end
           end
         end
-      EOF
+      RUBY
 
       expect(source).
         to reek_of(:UnusedPrivateMethod, context: 'Alfa::Bravo', name: 'charlie').
@@ -69,7 +69,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
 
     it 'discounts calls to identically named methods in nested classes' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           class Bravo
             def bravo
@@ -83,7 +83,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
           private
           def charlie; end
         end
-      EOF
+      RUBY
 
       expect(source).
         to reek_of(:UnusedPrivateMethod, context: 'Alfa', name: 'charlie').
@@ -91,13 +91,13 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
 
     it 'creates warnings correctly' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           private
           def bravo; end
           def charlie; end
         end
-      EOF
+      RUBY
 
       expect(source).
         to reek_of(:UnusedPrivateMethod, name: 'bravo', lines: [3]).
@@ -105,11 +105,11 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
     end
 
     it 'reports instance methods defined as private with a modifier' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           private def bravo; end
         end
-      EOF
+      RUBY
 
       expect(source).
         to reek_of(:UnusedPrivateMethod, name: 'bravo')
@@ -118,14 +118,14 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
 
   context 'when the detector is configured via a source code comment' do
     it 'does not report methods we excluded' do
-      source = <<-EOF
+      source = <<-RUBY
         # :reek:UnusedPrivateMethod { exclude: [ bravo ] }
         class Alfa
           private
           def bravo; end
           def charlie; end
         end
-      EOF
+      RUBY
 
       expect(source).
         to reek_of(:UnusedPrivateMethod, name: 'charlie').
@@ -135,7 +135,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
 
   context 'when a class has only used private methods' do
     it 'reports nothing' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           def bravo
             charlie
@@ -144,7 +144,7 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
           private
           def charlie; end
         end
-      EOF
+      RUBY
 
       expect(source).not_to reek_of(:UnusedPrivateMethod)
     end
@@ -152,12 +152,12 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
 
   context 'when a class has unused protected methods' do
     it 'reports nothing' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           protected
           def bravo; end
         end
-      EOF
+      RUBY
 
       expect(source).not_to reek_of(:UnusedPrivateMethod)
     end
@@ -165,11 +165,11 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
 
   context 'when a class has unused public methods' do
     it 'reports nothing' do
-      source = <<-EOF
+      source = <<-RUBY
         class Alfa
           def bravo; end
         end
-      EOF
+      RUBY
 
       expect(source).not_to reek_of(:UnusedPrivateMethod)
     end
@@ -177,13 +177,13 @@ RSpec.describe Reek::SmellDetectors::UnusedPrivateMethod do
 
   describe 'preventing methods from being reported' do
     let(:source) do
-      <<-EOF
+      <<-RUBY
         class Alfa
           private
           def bravo; end
           def charlie; end
         end
-      EOF
+      RUBY
     end
 
     it 'excludes them via direct match in the app configuration' do