reek 5.3.1 → 5.3.2

data/spec/reek/smell_detectors/long_parameter_list_spec.rb

@@ -3,12 +3,12 @@ require_lib 'reek/smell_detectors/long_parameter_list'
 
 RSpec.describe Reek::SmellDetectors::LongParameterList do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie, delta, echo, foxtrot)
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:LongParameterList,
                            lines:   [2],
@@ -19,7 +19,7 @@ RSpec.describe Reek::SmellDetectors::LongParameterList do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie, delta, echo, foxtrot)
         end
@@ -27,7 +27,7 @@ RSpec.describe Reek::SmellDetectors::LongParameterList do
         def golf(hotel, india, juliett, kilo)
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:LongParameterList, lines: [2], context: 'Alfa#bravo').
@@ -45,11 +45,11 @@ RSpec.describe Reek::SmellDetectors::LongParameterList do
   end
 
   it 'does not report inner block with too many parameters' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.each { |charlie, delta, echo, foxtrot| }
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:LongParameterList)
   end

data/spec/reek/smell_detectors/long_yield_list_spec.rb

@@ -3,13 +3,13 @@ require_lib 'reek/smell_detectors/long_yield_list'
 
 RSpec.describe Reek::SmellDetectors::LongYieldList do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie, delta, echo, foxtrot)
           yield charlie, delta, echo, foxtrot
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:LongYieldList,
                            lines:   [3],
@@ -20,7 +20,7 @@ RSpec.describe Reek::SmellDetectors::LongYieldList do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie, delta, echo, foxtrot)
           yield charlie, delta, echo, foxtrot
@@ -30,7 +30,7 @@ RSpec.describe Reek::SmellDetectors::LongYieldList do
           yield hotel, india, juliett, kilo
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:LongYieldList, lines: [3], context: 'Alfa#bravo').
@@ -38,11 +38,11 @@ RSpec.describe Reek::SmellDetectors::LongYieldList do
   end
 
   it 'does not report yield with 3 parameters' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo, charlie, delta)
         yield bravo, charlie, delta
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:LongYieldList)
   end

data/spec/reek/smell_detectors/manual_dispatch_spec.rb

@@ -3,13 +3,13 @@ require_lib 'reek/smell_detectors/too_many_constants'
 
 RSpec.describe Reek::SmellDetectors::ManualDispatch do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie)
           true if charlie.respond_to?(:to_a)
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ManualDispatch,
                            lines:   [3],
@@ -19,7 +19,7 @@ RSpec.describe Reek::SmellDetectors::ManualDispatch do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie)
           true if charlie.respond_to?(:to_a)
@@ -29,7 +29,7 @@ RSpec.describe Reek::SmellDetectors::ManualDispatch do
           true if echo.respond_to?(:to_a)
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:ManualDispatch, lines: [3], context: 'Alfa#bravo').
@@ -37,38 +37,38 @@ RSpec.describe Reek::SmellDetectors::ManualDispatch do
   end
 
   it 'reports manual dispatch smell when using #respond_to? on implicit self' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           charlie if respond_to?(:delta)
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ManualDispatch)
   end
 
   it 'reports manual dispatch within a conditional' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           charlie.respond_to?(:delta) && charlie.echo
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ManualDispatch)
   end
 
   it 'reports occurences in a single method as one smell warning' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie, delta)
           return true if charlie.respond_to?(:to_a)
           true if delta.respond_to?(:to_a)
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ManualDispatch, lines: [3, 4], context: 'Alfa#bravo')
   end

data/spec/reek/smell_detectors/missing_safe_method_spec.rb

@@ -3,12 +3,12 @@ require_lib 'reek/smell_detectors/missing_safe_method'
 
 RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo!
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:MissingSafeMethod,
                            lines:   [2],
@@ -19,7 +19,7 @@ RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo!
         end
@@ -27,7 +27,7 @@ RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
         def charlie!
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:MissingSafeMethod, lines: [2], name: 'bravo!').
@@ -35,7 +35,7 @@ RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
   end
 
   it 'reports nothing when method and bang counterpart exist' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
         end
@@ -43,19 +43,19 @@ RSpec.describe Reek::SmellDetectors::MissingSafeMethod do
         def bravo!
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:MissingSafeMethod)
   end
 
   it 'does not report methods we excluded via comment' do
-    source = <<-EOF
+    source = <<-RUBY
       # :reek:MissingSafeMethod: { exclude: [ bravo! ] }
       class Alfa
         def bravo!
         end
       end
-    EOF
+    RUBY
 
     expect(source).not_to reek_of(:MissingSafeMethod)
   end

data/spec/reek/smell_detectors/module_initialize_spec.rb

@@ -3,11 +3,11 @@ require_lib 'reek/smell_detectors/module_initialize'
 
 RSpec.describe Reek::SmellDetectors::ModuleInitialize do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       module Alfa
         def initialize; end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ModuleInitialize,
                            lines:   [1],
@@ -17,41 +17,41 @@ RSpec.describe Reek::SmellDetectors::ModuleInitialize do
   end
 
   it 'reports nothing for a method with a different name' do
-    src = <<-EOF
+    src = <<-RUBY
       module Alfa
         def bravo; end
       end
-    EOF
+    RUBY
 
     expect(src).not_to reek_of(:ModuleInitialize)
   end
 
   it 'reports nothing for a method named initialize in a nested class' do
-    src = <<-EOF
+    src = <<-RUBY
       module Alfa
         class Bravo
           def initialize; end
         end
       end
-    EOF
+    RUBY
 
     expect(src).not_to reek_of(:ModuleInitialize)
   end
 
   it 'reports nothing for a method named initialize in a nested struct' do
-    src = <<-EOF
+    src = <<-RUBY
       module Alfa
         Bravo = Struct.new(:charlie) do
           def initialize; end
         end
       end
-    EOF
+    RUBY
 
     expect(src).not_to reek_of(:ModuleInitialize)
   end
 
   it 'reports nothing for a method named initialize in a nested dynamic class' do
-    src = <<-EOF
+    src = <<-RUBY
       module Alfa
         def self.bravo
           Class.new do
@@ -59,18 +59,18 @@ RSpec.describe Reek::SmellDetectors::ModuleInitialize do
           end
         end
       end
-    EOF
+    RUBY
 
     expect(src).not_to reek_of(:ModuleInitialize)
   end
 
   it 'can be disabled via comment' do
-    src = <<-EOS
+    src = <<-RUBY
       # :reek:ModuleInitialize
       module Alfa
         def initialize; end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:ModuleInitialize)
   end

data/spec/reek/smell_detectors/nested_iterators_spec.rb

@@ -3,13 +3,13 @@ require_lib 'reek/smell_detectors/nested_iterators'
 
 RSpec.describe Reek::SmellDetectors::NestedIterators do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.each do |charlie|
           charlie.each { |delta| delta }
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NestedIterators,
                            lines:   [3],
@@ -20,7 +20,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo.each do |charlie|
           charlie.each { |delta| delta }
@@ -32,7 +32,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
           end
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:NestedIterators, lines: [3], depth: 2).
@@ -45,62 +45,62 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
   end
 
   it 'reports no smells with one iterator' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.each { |charlie| charlie }
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:NestedIterators)
   end
 
   it 'does not report nested iterators for Object#tap' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.tap do |charlie|
           charlie.each { |delta| delta }
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:NestedIterators)
   end
 
   it 'does not report method with successive iterators' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         @bravo.each   { |charlie| charlie }
         @charlie.each { |delta| delta }
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:NestedIterators)
   end
 
   it 'does not report method with chained iterators' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo.sort_by { |charlie| charlie }.each { |delta| delta }
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:NestedIterators)
   end
 
   it 'detects an iterator with an empty block' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo do |charlie|
           charlie { |delta| }
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NestedIterators)
   end
 
   it 'reports nesting inside iterator arguments' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo(
           charlie.each do |delta|
@@ -108,13 +108,13 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
           end
         )
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NestedIterators, depth: 2)
   end
 
   it 'reports the deepest level of nesting only' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.each do |charlie|
           charlie.each do |delta|
@@ -122,7 +122,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
           end
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to not_reek_of(:NestedIterators, depth: 2).
@@ -130,95 +130,95 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
   end
 
   it 'reports all lines on which nested iterators occur' do
-    source = <<-EOS
+    source = <<-RUBY
       def alfa
         @bravo.each { |charlie| charlie.each { |delta| @echo.send } }
         @foxtrot.each { |golf| golf.each { |hotel| @india.send } }
       end
-    EOS
+    RUBY
 
     expect(source).to reek_of(:NestedIterators, lines: [2, 3])
   end
 
   it 'handles the case where super receives a block' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         super do |bravo|
           bravo.each { |charlie| charlie }
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NestedIterators)
   end
 
   it 'handles the case where super receives a block and arguments' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         super(delta) do |bravo|
           bravo.each { |charlie| charlie }
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NestedIterators)
   end
 
   it 'does not count iterators without block arguments' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo do
           charlie.each { |delta| delta }
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:NestedIterators)
   end
 
   context 'when blocks are specified as lambdas' do
     it 'does not report blocks that are not nested' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo ->(charlie) { delta }
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:NestedIterators)
     end
 
     it 'reports blocks that are nested' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo ->(charlie) do
             delta ->(echo) { echo }
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:NestedIterators)
     end
   end
 
   it 'reports nested iterators called via safe navigation' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo&.each do |charlie|
           charlie&.each { |delta| delta }
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NestedIterators)
   end
 
   it 'does not report unnested iterators called via safe navigation' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo&.each { |charlie| charlie }
         delta&.each { |echo| echo }
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:NestedIterators)
   end
@@ -229,7 +229,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
     end
 
     it 'does not report nested iterators 3 levels deep' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.each do |charlie|
             charlie.each do |delta|
@@ -237,13 +237,13 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:NestedIterators).with_config(config)
     end
 
     it 'reports nested iterators 4 levels deep' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.each do |charlie|
             charlie.each do |delta|
@@ -253,7 +253,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:NestedIterators).with_config(config)
     end
@@ -265,31 +265,31 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
     end
 
     it 'does not report when nesting the ignored iterator inside another' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.each do |charlie|
             charlie.ignore_me { |delta| delta }
           end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:NestedIterators).with_config(config)
     end
 
     it 'does not report a nested iterator inside the ignored iterator' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.ignore_me do |charlie|
             charlie.each { |delta| delta }
           end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:NestedIterators).with_config(config)
     end
 
     it 'reports nested iterators inside the ignored iterator' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.ignore_me do |charlie|
             charlie.each do |delta|
@@ -297,13 +297,13 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:NestedIterators, depth: 2).with_config(config)
     end
 
     it 'reports nested iterators outside the ignored iterator' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.each do |charlie|
             charlie.each do |delta|
@@ -311,13 +311,13 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:NestedIterators, depth: 2).with_config(config)
     end
 
     it 'reports nested iterators with the ignored iterator between them' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           bravo.each do |charlie|
             charlie.ignore_me do |delta|
@@ -325,7 +325,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:NestedIterators, depth: 2).with_config(config)
     end