reek 5.3.1 → 5.3.2

data/spec/reek/smell_detectors/boolean_parameter_spec.rb

@@ -3,10 +3,10 @@ require_lib 'reek/smell_detectors/boolean_parameter'
 
 RSpec.describe Reek::SmellDetectors::BooleanParameter do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo = true)
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:BooleanParameter,
                            lines: [1],
@@ -17,10 +17,10 @@ RSpec.describe Reek::SmellDetectors::BooleanParameter do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo = true, charlie = true)
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:BooleanParameter, lines: [1], context: 'alfa', parameter: 'bravo').

data/spec/reek/smell_detectors/class_variable_spec.rb

@@ -3,11 +3,11 @@ require_lib 'reek/smell_detectors/class_variable'
 
 RSpec.describe Reek::SmellDetectors::ClassVariable do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         @@bravo = 5
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ClassVariable,
                            lines:   [2],
@@ -18,12 +18,12 @@ RSpec.describe Reek::SmellDetectors::ClassVariable do
   end
 
   it 'does count all class variables' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         @@bravo = 42
         @@charlie = 99
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:ClassVariable, name: '@@bravo').
@@ -31,32 +31,32 @@ RSpec.describe Reek::SmellDetectors::ClassVariable do
   end
 
   it 'does not report class instance variables' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         @bravo = 42
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:ClassVariable)
   end
 
   context 'with no class variables' do
     it 'records nothing in the class' do
-      src = <<-EOS
+      src = <<-RUBY
         class Alfa
           def bravo; end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:ClassVariable)
     end
 
     it 'records nothing in the module' do
-      src = <<-EOS
+      src = <<-RUBY
         module Alfa
           def bravo; end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:ClassVariable)
     end
@@ -65,31 +65,31 @@ RSpec.describe Reek::SmellDetectors::ClassVariable do
   ['class', 'module'].each do |scope|
     context "when examining a #{scope}" do
       it 'reports a class variable set in a method' do
-        src = <<-EOS
+        src = <<-RUBY
           #{scope} Alfa
             def bravo
               @@charlie = {}
             end
           end
-        EOS
+        RUBY
 
         expect(src).to reek_of(:ClassVariable, name: '@@charlie')
       end
 
       it 'reports a class variable used in a method' do
-        src = <<-EOS
+        src = <<-RUBY
           #{scope} Alfa
             def bravo
               puts @@charlie
             end
           end
-        EOS
+        RUBY
 
         expect(src).to reek_of(:ClassVariable, name: '@@charlie')
       end
 
       it "reports a class variable set in the #{scope} body and used in a method" do
-        src = <<-EOS
+        src = <<-RUBY
           #{scope} Alfa
             @@bravo = 42
 
@@ -97,7 +97,7 @@ RSpec.describe Reek::SmellDetectors::ClassVariable do
               puts @@bravo
             end
           end
-        EOS
+        RUBY
 
         expect(src).to reek_of(:ClassVariable, name: '@@bravo')
       end

data/spec/reek/smell_detectors/control_parameter_spec.rb

@@ -3,11 +3,11 @@ require_lib 'reek/smell_detectors/control_parameter'
 
 RSpec.describe Reek::SmellDetectors::ControlParameter do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo ? true : false
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:ControlParameter,
                            lines:    [2],
@@ -18,12 +18,12 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo, charlie)
         bravo ? true : false
         charlie ? true : false
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:ControlParameter, lines: [2], argument: 'bravo').
@@ -31,7 +31,7 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
   end
 
   it 'does count multiple occurences of the same parameter' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo, charlie)
         if bravo
           delta if charlie
@@ -40,7 +40,7 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
           delta if bravo
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:ControlParameter, lines: [2, 6], argument: 'bravo').
@@ -136,46 +136,46 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
     end
 
     it 'reports on case statement' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           case bravo
           when nil then nil
           else false
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:ControlParameter)
     end
 
     it 'reports on nested if statements that are both using control parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         def nested(bravo)
           if bravo
             charlie
             charlie if bravo
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:ControlParameter)
     end
 
     it 'reports on nested suffix if statements where the inner if is a control parameter' do
-      src = <<-EOS
+      src = <<-RUBY
         def nested(bravo)
           if true
             charlie
             charlie if bravo
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:ControlParameter)
     end
 
     it 'reports on nested full if statements where the inner if is a control parameter' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           if true
             charlie
@@ -185,13 +185,13 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:ControlParameter)
     end
 
     it 'reports on elsif statements' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           if true
             charlie
@@ -199,7 +199,7 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
             delta
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:ControlParameter)
     end
@@ -282,7 +282,7 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
     end
 
     it 'does not report when used in body of control flow operator' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           case bravo
           when :charlie
@@ -292,7 +292,7 @@ RSpec.describe Reek::SmellDetectors::ControlParameter do
           end
           echo or foxtrot(bravo)
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:ControlParameter)
     end

data/spec/reek/smell_detectors/data_clump_spec.rb

@@ -3,13 +3,13 @@ require_lib 'reek/smell_detectors/data_clump'
 
 RSpec.describe Reek::SmellDetectors::DataClump do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo  (echo, foxtrot); end
         def charlie(echo, foxtrot); end
         def delta  (echo, foxtrot); end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:DataClump,
                            lines:      [2, 3, 4],
@@ -21,7 +21,7 @@ RSpec.describe Reek::SmellDetectors::DataClump do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo  (echo, foxtrot); end
         def charlie(echo, foxtrot); end
@@ -31,7 +31,7 @@ RSpec.describe Reek::SmellDetectors::DataClump do
         def hotel(juliett, kilo); end
         def india(juliett, kilo); end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:DataClump, lines: [2, 3, 4], parameters: ['echo', 'foxtrot']).
@@ -40,36 +40,36 @@ RSpec.describe Reek::SmellDetectors::DataClump do
 
   %w(class module).each do |scope|
     it "does not report parameter sets < 2 for #{scope}" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def bravo  (echo); end
           def charlie(echo); end
           def delta  (echo); end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:DataClump)
     end
 
     it "does not report less than 3 methods for #{scope}" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def bravo  (echo, foxtrot); end
           def charlie(echo, foxtrot); end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:DataClump)
     end
 
     it 'does not care about the order of arguments' do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def bravo  (echo, foxtrot); end
           def charlie(foxtrot, echo); end # <- This is the swapped one!
           def delta  (echo, foxtrot); end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DataClump,
                              count: 3,
@@ -77,13 +77,13 @@ RSpec.describe Reek::SmellDetectors::DataClump do
     end
 
     it 'reports parameter sets that are > 2' do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def bravo  (echo, foxtrot, golf); end
           def charlie(echo, foxtrot, golf); end
           def delta  (echo, foxtrot, golf); end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DataClump,
                              count: 3,
@@ -91,27 +91,27 @@ RSpec.describe Reek::SmellDetectors::DataClump do
     end
 
     it 'detects clumps smaller than the total number of parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         # Total number of parameters is 3 but the clump size is 2.
         #{scope} Alfa
           def bravo  (echo,  foxtrot, golf);    end
           def charlie(echo,  golf,    foxtrot); end
           def delta  (hotel, echo,    foxtrot); end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DataClump,
                              parameters: ['echo', 'foxtrot'])
     end
 
     it 'ignores anonymous parameters' do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def bravo  (echo, foxtrot, *); end
           def charlie(echo, foxtrot, *); end
           def delta  (echo, foxtrot, *); end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DataClump,
                              parameters: ['echo', 'foxtrot'])

data/spec/reek/smell_detectors/duplicate_method_call_spec.rb

@@ -3,14 +3,14 @@ require_lib 'reek/smell_detectors/duplicate_method_call'
 
 RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie)
           charlie.delta
           charlie.delta
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:DuplicateMethodCall,
                            lines:   [3, 4],
@@ -22,7 +22,7 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie)
           charlie.delta
@@ -34,7 +34,7 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
           foxtrot.golf
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:DuplicateMethodCall, lines: [3, 4], name: 'charlie.delta', count: 2).
@@ -67,12 +67,12 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
 
   context 'with repeated simple method calls' do
     it 'reports no smell' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo
           bravo
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:DuplicateMethodCall)
     end
@@ -80,23 +80,23 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
 
   context 'with repeated simple method calls with blocks' do
     it 'reports a smell if the blocks are identical' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo { charlie }
           bravo { charlie }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DuplicateMethodCall)
     end
 
     it 'reports no smell if the blocks are different' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo { charlie }
           bravo { delta }
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:DuplicateMethodCall)
     end
@@ -104,23 +104,23 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
 
   context 'with repeated method calls with receivers with blocks' do
     it 'reports a smell if the blocks are identical' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo.charlie { delta }
           bravo.charlie { delta }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DuplicateMethodCall)
     end
 
     it 'reports a smell if the blocks are different' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo.charlie { delta }
           bravo.charlie { echo }
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DuplicateMethodCall)
     end
@@ -128,23 +128,23 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
 
   context 'with repeated attribute assignment' do
     it 'reports repeated assignment' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa(bravo)
           @charlie[bravo] = true
           @charlie[bravo] = true
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DuplicateMethodCall)
     end
 
     it 'does not report multi-assignments' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo, charlie = delta, echo
           charlie, bravo = delta, echo
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:DuplicateMethodCall)
     end
@@ -178,11 +178,11 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
     end
 
     it 'reports quadruple calls' do
-      src = <<-EOS
+      src = <<-RUBY
         def alfa
           bravo.charlie + bravo.charlie + bravo.charlie + bravo.charlie
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:DuplicateMethodCall,
                              count: 4).with_config(config)