reek 5.3.1 → 5.3.2

data/spec/reek/smell_detectors/feature_envy_spec.rb

@@ -3,13 +3,13 @@ require_lib 'reek/smell_detectors/feature_envy'
 
 RSpec.describe Reek::SmellDetectors::FeatureEnvy do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie)
           (charlie.delta - charlie.echo) * foxtrot
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:FeatureEnvy,
                            lines:   [3, 3],
@@ -20,7 +20,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo(charlie)
           (charlie.delta - charlie.echo) * foxtrot
@@ -30,7 +30,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
           (hotel.india + hotel.juliett) * kilo
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:FeatureEnvy, lines: [3, 3], name: 'charlie').
@@ -108,7 +108,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
   end
 
   it 'ignores multiple ivars' do
-    src = <<-EOS
+    src = <<-RUBY
       def func
         @alfa.charlie
         @alfa.delta
@@ -116,13 +116,13 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
         @bravo.echo
         @bravo.foxtrot
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end
 
   it 'report highest affinity' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo = @charlie
         delta = 0
@@ -130,7 +130,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
         delta += bravo.foxtrot
         delta *= 1.15
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:FeatureEnvy, name: 'delta').
@@ -138,14 +138,14 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
   end
 
   it 'reports multiple affinities' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo = @charlie
         delta = 0
         delta += bravo.echo
         delta += bravo.foxtrot
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:FeatureEnvy, name: 'delta').
@@ -153,75 +153,75 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
   end
 
   it 'is not fooled by duplication' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         @charlie.delta(bravo.echo)
         @foxtrot.delta(bravo.echo)
       end
-    EOS
+    RUBY
 
     expect(src).to reek_only_of(:DuplicateMethodCall, name: 'bravo.echo')
   end
 
   it 'counts local calls' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         charlie.delta(bravo.echo)
         foxtrot.delta(bravo.echo)
       end
-    EOS
+    RUBY
 
     expect(src).to reek_only_of(:DuplicateMethodCall, name: 'bravo.echo')
   end
 
   it 'reports many calls to lvar' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa
         bravo = @charlie
         bravo.delta + bravo.echo
       end
-    EOS
+    RUBY
 
     expect(src).to reek_only_of(:FeatureEnvy)
   end
 
   it 'counts =~ as a call' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         charlie(bravo.delta)
         bravo =~ /charlie/
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of :FeatureEnvy
   end
 
   it 'counts += as a call' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         charlie(bravo.delta)
         bravo += 1
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of :FeatureEnvy
   end
 
   it 'counts ivar assignment as call to self' do
-    src = <<-EOS
+    src = <<-RUBY
       def foo
         bravo = charlie(1, 2)
 
         @delta = bravo.echo
         @foxtrot = bravo.golf
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of :FeatureEnvy
   end
 
   it 'counts self references correctly' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.keys.each do |charlie|
           self[charlie] += 3
@@ -229,13 +229,13 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
         end
         self
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end
 
   it 'interprets << correctly' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         if @charlie
           bravo.delta(self)
@@ -243,13 +243,13 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
           bravo << self
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end
 
   it 'does not report on class methods defined by opening the metaclass' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         class << self
           def bravo(charlie)
@@ -259,13 +259,13 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
           end
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end
 
   it 'does not report on class methods defined with an explicit receiver' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def self.bravo(charlie)
           delta = new(charlie)
@@ -273,13 +273,13 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
           delta.echo
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end
 
   it 'does not report module functions' do
-    src = <<-EOF
+    src = <<-RUBY
       module Alfa
         module_function
         def bravo(charlie)
@@ -288,7 +288,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
           echo.foxtrot
         end
       end
-    EOF
+    RUBY
 
     expect(src).not_to reek_of(:FeatureEnvy)
   end

data/spec/reek/smell_detectors/instance_variable_assumption_spec.rb

@@ -4,13 +4,13 @@ require_lib 'reek/smell_detectors/instance_variable_assumption'
 
 RSpec.describe Reek::SmellDetectors::InstanceVariableAssumption do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:InstanceVariableAssumption,
                            lines:      [1],
@@ -21,7 +21,7 @@ RSpec.describe Reek::SmellDetectors::InstanceVariableAssumption do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie
@@ -32,7 +32,7 @@ RSpec.describe Reek::SmellDetectors::InstanceVariableAssumption do
         end
       end
 
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:InstanceVariableAssumption, lines: [1], assumption: '@charlie').
@@ -40,28 +40,28 @@ RSpec.describe Reek::SmellDetectors::InstanceVariableAssumption do
   end
 
   it 'does not report an empty class' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:InstanceVariableAssumption)
   end
 
   it 'does not report when lazy initializing' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie ||= 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:InstanceVariableAssumption)
   end
 
   it 'reports variable even if others are initialized' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def initialize
           @bravo = 1
@@ -71,13 +71,13 @@ RSpec.describe Reek::SmellDetectors::InstanceVariableAssumption do
           [@bravo, @delta]
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:InstanceVariableAssumption, assumption: '@delta')
   end
 
   it 'reports inner class even if outer class initializes the variable' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def initialize
           @bravo = 1
@@ -89,7 +89,7 @@ RSpec.describe Reek::SmellDetectors::InstanceVariableAssumption do
           end
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:InstanceVariableAssumption, context: 'Alfa::Charlie')
   end

data/spec/reek/smell_detectors/irresponsible_module_spec.rb

@@ -3,10 +3,10 @@ require_lib 'reek/smell_detectors/irresponsible_module'
 
 RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:IrresponsibleModule,
                            lines:   [1],
@@ -16,14 +16,14 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         # Method is necessary because we don't count namespace classes.
         def bravo; end
         class Charlie
         end
       end
-    EOS
+    RUBY
 
     expect(src).
       to reek_of(:IrresponsibleModule, lines: [1], context: 'Alfa').
@@ -32,58 +32,58 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
 
   %w(class module).each do |scope|
     it "reports a #{scope} without a comment" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule)
     end
 
     it "does not report a #{scope} having a comment" do
-      src = <<-EOS
+      src = <<-RUBY
         # Do not report me, I'm responsible!
         #{scope} Alfa; end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:IrresponsibleModule)
     end
 
     it "reports a #{scope} with an empty comment" do
-      src = <<-EOS
+      src = <<-RUBY
         #
         #
         #
         #{scope} Alfa; end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule)
     end
 
     it "reports a #{scope} with a preceding comment with intermittent material" do
-      src = <<-EOS
+      src = <<-RUBY
         # This is a comment that should not be related to Bravo
 
         require 'alfa'
 
         #{scope} Bravo
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule)
     end
 
     it "reports a #{scope} with only a trailing comment" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
         end # This belongs to Alfa but doesn't count
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule)
     end
 
     it "does not report #{scope} used only as a namespace" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           # Describes Bravo
           #{scope} Bravo
@@ -91,13 +91,13 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
             end
           end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "does not report #{scope} used only as a namespace for several nested moduless" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           # Describes Bravo
           class Bravo
@@ -109,13 +109,13 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
           module Delta
           end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "reports #{scope} that is used as a namespace but also has methods" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def bravo
           end
@@ -124,13 +124,13 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
           #{scope} Charlie
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "reports #{scope} that is used as a namespace but also has singleton methods" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           def self.bravo
           end
@@ -139,78 +139,78 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
           #{scope} Charlie
           end
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "does not report a namespace #{scope} that has a nested class through assignment" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           # Bravo is responsible
           Bravo = Class.new Charlie do
             def delta; end
           end
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "does not report #{scope} only containing constants" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           Bravo = 23
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "reports #{scope} that contains method calls" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           bravo :charlie
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "reports #{scope} that contains non-constant assignments" do
-      src = <<-EOS
+      src = <<-RUBY
         #{scope} Alfa
           bravo = charlie
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule, context: 'Alfa')
     end
 
     it "reports an irresponsible #{scope} defined through assignment" do
-      src = <<-EOS
+      src = <<-RUBY
         # Alfa is responsible, but Bravo is not
         #{scope} Alfa
           Bravo = Class.new Charlie # Only "class" is supposed to reek here.
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule, context: 'Alfa::Bravo')
     end
 
     it 'reports structs defined through assignment' do
-      src = <<-EOS
+      src = <<-RUBY
         # Alfa is responsible, but Bravo is not
         #{scope} Alfa
           Bravo = Struct.new(:charlie)
         end
-      EOS
+      RUBY
 
       expect(src).to reek_of(:IrresponsibleModule, context: 'Alfa::Bravo')
     end
 
     it 'does not report constants that are not classes' do
-      src = <<-EOS
+      src = <<-RUBY
         # Alfa is responsible
         #{scope} Alfa
           Bravo = 23
@@ -218,7 +218,7 @@ RSpec.describe Reek::SmellDetectors::IrresponsibleModule do
           Delta = ''.freeze
           Echo = Class.new.new
         end
-      EOS
+      RUBY
 
       expect(src).not_to reek_of(:IrresponsibleModule)
     end