reek 5.3.1 → 5.3.2

data/spec/reek/smell_detectors/nil_check_spec.rb

@@ -3,11 +3,11 @@ require_lib 'reek/smell_detectors/nil_check'
 
 RSpec.describe Reek::SmellDetectors::NilCheck do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.nil?
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck,
                            lines:   [2],
@@ -17,12 +17,12 @@ RSpec.describe Reek::SmellDetectors::NilCheck do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo, charlie)
         bravo.nil?
         charlie.nil?
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck,
                            lines:   [2, 3],
@@ -35,65 +35,65 @@ RSpec.describe Reek::SmellDetectors::NilCheck do
   end
 
   it 'reports when scope uses == nil' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo == nil
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck)
   end
 
   it 'reports when scope uses === nil' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo === nil
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck)
   end
 
   it 'reports when scope uses nil ==' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         nil == bravo
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck)
   end
 
   it 'reports when scope uses a case-clause checking nil' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         case bravo
         when nil then puts "Nil"
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck)
   end
 
   it 'reports when scope uses &.' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo&.charlie
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck)
   end
 
   it 'reports all lines when scope uses multiple nilchecks' do
-    src = <<-EOS
+    src = <<-RUBY
       def alfa(bravo)
         bravo.nil?
         @charlie === nil
         delta&.echo
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:NilCheck, lines: [2, 3, 4])
   end

data/spec/reek/smell_detectors/repeated_conditional_spec.rb

@@ -3,7 +3,7 @@ require_lib 'reek/smell_detectors/repeated_conditional'
 
 RSpec.describe Reek::SmellDetectors::RepeatedConditional do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         attr_accessor :bravo
 
@@ -19,7 +19,7 @@ RSpec.describe Reek::SmellDetectors::RepeatedConditional do
           puts "Repeat 3!" if bravo
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:RepeatedConditional,
                            lines:   [5, 9, 13],
@@ -31,7 +31,7 @@ RSpec.describe Reek::SmellDetectors::RepeatedConditional do
   end
 
   it 'does count all occurences' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         attr_accessor :bravo
 
@@ -48,7 +48,7 @@ RSpec.describe Reek::SmellDetectors::RepeatedConditional do
           puts "Repeat 3!" if bravo
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:RepeatedConditional,
                            lines: [5, 6, 10, 14],
@@ -56,7 +56,7 @@ RSpec.describe Reek::SmellDetectors::RepeatedConditional do
   end
 
   it 'does not report two repeated conditionals' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         attr_accessor :bravo
 
@@ -68,13 +68,13 @@ RSpec.describe Reek::SmellDetectors::RepeatedConditional do
           puts "Repeat 2!" if bravo
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:RepeatedConditional)
   end
 
   it 'reports repeated conditionals regardless of `if` or `case` statements' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         attr_accessor :bravo
 
@@ -93,7 +93,7 @@ RSpec.describe Reek::SmellDetectors::RepeatedConditional do
           puts "Repeat 3!" if bravo
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:RepeatedConditional)
   end

data/spec/reek/smell_detectors/subclassed_from_core_class_spec.rb

@@ -3,10 +3,10 @@ require_lib 'reek/smell_detectors/subclassed_from_core_class'
 
 RSpec.describe Reek::SmellDetectors::SubclassedFromCoreClass do
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa < Hash
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:SubclassedFromCoreClass,
                            lines:    [1],
@@ -17,40 +17,40 @@ RSpec.describe Reek::SmellDetectors::SubclassedFromCoreClass do
   end
 
   it 'reports when inheriting from a core class inside a module' do
-    src = <<-EOS
+    src = <<-RUBY
       module Alfa
         class Bravo < Hash
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:SubclassedFromCoreClass, context: 'Alfa::Bravo')
   end
 
   it 'does not report when not inheriting from a core class' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:SubclassedFromCoreClass)
   end
 
   it 'does not report on coincidental core class names in other namespaces' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa < Bravo::Array
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:SubclassedFromCoreClass)
   end
 
   it 'reports if inner class inherit from a core class' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         Bravo = Class.new(Array)
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:SubclassedFromCoreClass, context: 'Alfa::Bravo')
   end

data/spec/reek/smell_detectors/too_many_constants_spec.rb

@@ -7,11 +7,11 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
   end
 
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         Bravo = Charlie = Delta = 1
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyConstants,
                            lines:   [1],
@@ -22,61 +22,61 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
   end
 
   it 'does not report for non-excessive constants' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         Bravo = Charlie = 1
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'does not report when increasing default' do
-    src = <<-EOS
+    src = <<-RUBY
       # :reek:TooManyConstants { max_constants: 3 }
       class Alfa
         Bravo = Charlie = Delta = 1
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'does not report when disabled' do
-    src = <<-EOS
+    src = <<-RUBY
       # :reek:TooManyConstants { enabled: false }
       class Alfa
         Bravo = Charlie = Delta = 1
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'does not account class definition' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         Bravo = Charlie = 1
         Delta = Class.new(StandardError)
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'does not account struct definition' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         Bravo = Charlie = 1
         Delta = Struct.new
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'counts each constant only once' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         Bravo = Charlie = 1
       end
@@ -88,26 +88,26 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
       class Golf
         Hotel = India = 1
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'does not report outer module when inner module suppressed' do
-    src = <<-EOS
+    src = <<-RUBY
       module Alfa
         # ignore :reek:TooManyConstants
         module Bravo
           Charlie = Delta = Echo = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'counts each constant only once for each namespace' do
-    src = <<-EOS
+    src = <<-RUBY
       module Alfa
         Bravo = Charlie = 1
 
@@ -115,29 +115,29 @@ RSpec.describe Reek::SmellDetectors::TooManyConstants do
           Echo = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyConstants).with_config(config)
   end
 
   it 'reports for excessive constants inside a module' do
-    src = <<-EOS
+    src = <<-RUBY
       module Alfa
         Bravo = Charlie = Delta = 1
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyConstants, context: 'Alfa').with_config(config)
   end
 
   it 'reports the full class name' do
-    src = <<-EOS
+    src = <<-RUBY
       module Alfa
         class Bravo
           Charlie = Delta = Echo = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyConstants, context: 'Alfa::Bravo').with_config(config)
   end

data/spec/reek/smell_detectors/too_many_instance_variables_spec.rb

@@ -7,13 +7,13 @@ RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
   end
 
   it 'reports the right values' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie = @delta = @echo = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyInstanceVariables,
                            lines:   [1],
@@ -24,58 +24,58 @@ RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
   end
 
   it 'does not report for non-excessive ivars' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie = @delta = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
   end
 
   it 'has a configurable maximum' do
-    src = <<-EOS
+    src = <<-RUBY
       # :reek:TooManyInstanceVariables { max_instance_variables: 3 }
       class Alfa
         def bravo
           @charlie = @delta = @echo = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
   end
 
   it 'counts each ivar only once' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie = @delta = 1
           @charlie = @delta = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
   end
 
   it 'does not report memoized bravo' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie = @delta = 1
           @echo ||= 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
   end
 
   it 'does not count ivars across inner classes' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         class Bravo
           def charlie
@@ -89,13 +89,13 @@ RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
           end
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
   end
 
   it 'does not count ivars across inner modules and classes' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         class Bravo
           def charlie
@@ -109,13 +109,13 @@ RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
           end
         end
       end
-    EOS
+    RUBY
 
     expect(src).not_to reek_of(:TooManyInstanceVariables).with_config(config)
   end
 
   it 'reports excessive ivars across different methods' do
-    src = <<-EOS
+    src = <<-RUBY
       class Alfa
         def bravo
           @charlie = @delta = 1
@@ -125,7 +125,7 @@ RSpec.describe Reek::SmellDetectors::TooManyInstanceVariables do
           @hotel = 1
         end
       end
-    EOS
+    RUBY
 
     expect(src).to reek_of(:TooManyInstanceVariables).with_config(config)
   end