rails_best_practices 1.14.4 → 1.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bae1e38364b51e6d840e048b2e0576f4743ae2fe
-  data.tar.gz: 744f069382fc07105d5d947d54af8222e67dcb35
+  metadata.gz: aad6be6297629a1706250552dd2dc67a88d088f4
+  data.tar.gz: 7416b40f8860088f0ef6734f44fb7dc68531a226
 SHA512:
-  metadata.gz: 6c15c03cd8ee2fe69488eb5cf49b298eb61b90d660cd023c96d9cd6b1858b5f71412628b26139ca83f692bc1dc7cce121b271a68809bd0b0aeabace30bb76cc4
-  data.tar.gz: 3d9ade5bd5fc2490d4b72becc751481e87d91ad1cf5a790a3d20b52dcaccc1ab57f93f2919c2f3cd2d31f71d2e2c4391131c8878ed2dc63b663d7b26ea6d6614
+  metadata.gz: d3ccfe6ee0f2164b49c2d00db11505d858b0750c9167d39e7e9e3da251d3d7e4a122e7601dc158efc462bcc5a422c94c65e6e02ccce95fa68ac2a787fd30eaad
+  data.tar.gz: 1be5179a45ca10b0b5ebb3436bf56af16fcca01a35ff93d8846365eb8390bda417750945ea2c21eec659b68cbde1cfd17e67dbdbecbddb1ad2f2d4c5a337d93d

data/.ruby-version

@@ -1 +1 @@
-ruby-2.0.0
+ruby-2.1.0

data/.travis.yml

@@ -2,3 +2,4 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.0

data/README.md

@@ -3,10 +3,9 @@
 [![Gem Version](https://badge.fury.io/rb/rails_best_practices.png)](http://badge.fury.io/rb/rails_best_practices)
 [![Build Status](https://secure.travis-ci.org/railsbp/rails_best_practices.png)](http://travis-ci.org/railsbp/rails_best_practices)
 [![Coverage Status](https://coveralls.io/repos/railsbp/rails_best_practices/badge.png?branch=master)](https://coveralls.io/r/railsbp/rails_best_practices)
-[![Code Climate](https://codeclimate.com/repos/51eb7073f3ea00179b00db0b/badges/095127e7bb641dbc825b/gpa.png)](https://codeclimate.com/repos/51eb7073f3ea00179b00db0b/feed)
 
 [![Coderwall Endorse](http://api.coderwall.com/flyerhzm/endorsecount.png)](http://coderwall.com/flyerhzm)
-[![Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !](http://www.pledgie.com/campaigns/12057.png?skin_name=chrome)](http://www.pledgie.com/campaigns/12057)
+[![Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !](https://pledgie.com/campaigns/12057.png?skin_name=chrome)](https://pledgie.com/campaigns/12057)
 
 rails_best_practices is a code metric tool to check the quality of rails codes.
 
@@ -23,12 +22,13 @@ following template engines:
 * slim
 * rabl
 
-rails_best_practices works well only in ruby 1.9.2 and ruby 1.9.3 so far.  It is incompatible with ruby 1.8.
+rails_best_practices works well only in ruby 1.9.3, 2.0.0, and 2.1.0 so far.  It is incompatible with ruby 1.8.
 
 ## External Introduction
 
-<http://ruby5.envylabs.com/episodes/257-episode-253-march-9th-2012/stories/2253-rails_best_practices>
-<http://railscasts.com/episodes/252-metrics-metrics-metrics>
+[Ruby5 - Episode #253](http://ruby5.envylabs.com/episodes/257-episode-253-march-9th-2012/stories/2253-rails_best_practices)
+
+[Railscasts - #252 Metrics Metrics Metrics](http://railscasts.com/episodes/252-metrics-metrics-metrics)
 
 ## Usage
 
@@ -40,9 +40,24 @@ or html output
 
     rails_best_practices -f html .
 
-By default rails_best_practices will do parse codes in vendor, spec, test and features directories. If you need, see the command options:
+By default rails_best_practices will do parse codes in vendor, spec, test and features directories. 
+
+### Excluding folders
+
+To exclude folder simply call it with -e or --exclude
+
+    rails_best_practices -e "db/migrate" .
+    
+To exclude multiple folders, separate them with comma
+
+    rails_best_practices -e "db/migrate,vendor" .
+
+### Other command line options
+
+To see full list of commandline options call:
 
     $ rails_best_practices -h
+    
     Usage: rails_best_practices [options]
         -d, --debug                      Debug mode
         -f, --format FORMAT              output format
@@ -166,6 +181,11 @@ Now you can customize this configuration file, the default configuration is as f
 
 You can remove or comment one review to disable it, and you can change the options.
 
+You can apply the `ignored_files` option on any rule by giving a regexp or array of regexps describing the path of the files you don't want to be checked:
+
+	DefaultScopeIsEvilCheck: { ignored_files: 'user\.rb' }
+	LongLineCheck: { max_line_length: 80, ignored_files: ['db/migrate', 'config/initializers'] }
+
 ## Implementation
 
 Move code from Controller to Model

data/lib/rails_best_practices/core/check.rb

@@ -32,6 +32,10 @@ module RailsBestPractices
       # @param [String] the file name of node.
       # @return [Boolean] true if the check will need to parse the file.
       def parse_file?(node_file)
+        is_interesting_file?(node_file) and !is_ignored?(node_file)
+      end
+
+      def is_interesting_file?(node_file)
         interesting_files.any? do |pattern|
           if pattern == ALL_FILES
             node_file =~ pattern && node_file !~ SKIP_FILES
@@ -41,6 +45,14 @@ module RailsBestPractices
         end
       end
 
+      def is_ignored?(node_file)
+        regex_ignored_files.map{ |r| !!r.match(node_file) }.inject(:|)
+      end
+
+      def regex_ignored_files
+        @regex_ignored_files ||= Array(@ignored_files).map{ |pattern| Regexp.new(pattern) }
+      end
+
       # add error if source code violates rails best practice.
       #
       # @param [String] message, is the string message for violation of the rails best practice
@@ -56,7 +68,7 @@ module RailsBestPractices
         )
       end
 
-      # errors that vialote the rails best practices.
+      # errors that violate the rails best practices.
       def errors
         @errors ||= []
       end
@@ -116,7 +128,7 @@ module RailsBestPractices
               classable_modules.pop
             end
 
-            # remember the class anem
+            # remember the class name
             add_callback :start_class do |node|
               @klass = Core::Klass.new(node.class_name.to_s, node.base_class.to_s, classable_modules)
               klasses << @klass
@@ -334,6 +346,7 @@ module RailsBestPractices
 
             # check if the method is in the except methods list.
             def excepted?(method)
+              is_ignored?(method.file) ||
               except_methods.any? do |except_method|
                 class_name, method_name = except_method.split('#')
                 (class_name == '*' && method_name == method.method_name) ||

data/lib/rails_best_practices/core/klasses.rb

@@ -14,21 +14,31 @@ module RailsBestPractices
 
     # Class info includes class name, extend class name and module names.
     class Klass
-      attr_reader :class_name, :extend_class_name
-
       def initialize(class_name, extend_class_name, modules)
         @class_name = class_name
         @extend_class_name = extend_class_name
         @modules = modules.dup
       end
 
-      def to_s
+      def class_name
         if @modules.empty?
           @class_name
         else
           @modules.map { |modu| "#{modu}::" }.join("") + @class_name
         end
       end
+
+      def extend_class_name
+        if @modules.empty?
+          @extend_class_name
+        else
+          @modules.map { |modu| "#{modu}::" }.join("") + @extend_class_name
+        end
+      end
+
+      def to_s
+        class_name
+      end
     end
   end
 end

data/lib/rails_best_practices/core/model_associations.rb

@@ -34,7 +34,7 @@ module RailsBestPractices
       # @return [Boolean] true if it is the model's association
       def is_association?(model_name, association_name)
         associations = @associations[model_name]
-        associations && associations[association_name]
+        !!(associations && associations[association_name])
       end
 
       # delegate each to @associations.

data/lib/rails_best_practices/core/runner.rb

@@ -138,6 +138,7 @@ module RailsBestPractices
             begin
               check_name, options = *check
               klass = RailsBestPractices::Lexicals.const_get(check_name)
+              options = Hash(options)
               active_checks << (options.empty? ? klass.new : klass.new(options))
             rescue
               # the check does not exist in the Lexicals namepace.
@@ -157,6 +158,7 @@ module RailsBestPractices
             begin
               check_name, options = *check
               klass = RailsBestPractices::Reviews.const_get(check_name.gsub(/Check$/, 'Review'))
+              options = Hash(options)
               active_checks << (options.empty? ? klass.new : klass.new(options))
             rescue
               # the check does not exist in the Reviews namepace.

data/lib/rails_best_practices/lexicals/long_line_check.rb

@@ -6,7 +6,7 @@ module RailsBestPractices
       interesting_files ALL_FILES
 
       def initialize(options = {})
-        super()
+        super(options)
         @max_line_length = options['max_line_length'] || 80
       end
 

data/lib/rails_best_practices/prepares/route_prepare.rb

@@ -30,6 +30,9 @@ module RailsBestPractices
               action_names = [first_argument.hash_values.first.to_s]
             elsif :array == first_argument.sexp_type
               action_names = first_argument.array_values.map(&:to_s)
+            elsif :bare_assoc_hash == second_argument.try(:sexp_type) && second_argument.hash_value("to").present?
+              controller_name, action_name = second_argument.hash_value("to").to_s.split('#')
+              action_names = [action_name]
             else
               action_names = [first_argument.to_s]
             end
@@ -61,7 +64,7 @@ module RailsBestPractices
               @routes.add_route(current_namespaces, controller_name.underscore, action_name)
             end
           end
-        when "match", "root"
+        when "match"
           options = node.arguments.all.last
           case options.sexp_type
           when :bare_assoc_hash
@@ -84,6 +87,19 @@ module RailsBestPractices
           else
             # do nothing
           end
+        when "root"
+          options = node.arguments.all.last
+          case options.sexp_type
+          when :bare_assoc_hash
+            route_node = options.hash_values.find { |value_node| :string_literal == value_node.sexp_type && value_node.to_s.include?('#') }
+            if route_node.present?
+              controller_name, action_name = route_node.to_s.split('#')
+              @routes.add_route(current_namespaces, controller_name.underscore, action_name)
+            end
+          when :string_literal
+            controller_name, action_name = options.to_s.split('#')
+            @routes.add_route(current_namespaces, controller_name.underscore, action_name)
+          end
         else
           # nothing to do
         end

data/lib/rails_best_practices/reviews/always_add_db_index_review.rb

@@ -26,8 +26,8 @@ module RailsBestPractices
       interesting_files SCHEMA_FILE
       url "http://rails-bestpractices.com/posts/21-always-add-db-index"
 
-      def initialize
-        super
+      def initialize(options={})
+        super(options)
         @index_columns = {}
         @foreign_keys = {}
         @table_nodes = {}

data/lib/rails_best_practices/reviews/isolate_seed_data_review.rb

@@ -23,8 +23,8 @@ module RailsBestPractices
       interesting_files MIGRATION_FILES
       url "http://rails-bestpractices.com/posts/20-isolating-seed-data"
 
-      def initialize
-        super
+      def initialize(options={})
+        super(options)
         @new_variables = []
       end
 

data/lib/rails_best_practices/reviews/keep_finders_on_their_own_model_review.rb

@@ -1,7 +1,7 @@
 # encoding: utf-8
 module RailsBestPractices
   module Reviews
-    # Review model files to ake sure finders are on their own model.
+    # Review model files to make sure finders are on their own model.
     #
     # See the best practice details here http://rails-bestpractices.com/posts/13-keep-finders-on-their-own-model.
     #

data/lib/rails_best_practices/reviews/move_code_into_helper_review.rb

@@ -22,7 +22,7 @@ module RailsBestPractices
       url "http://rails-bestpractices.com/posts/26-move-code-into-helper"
 
       def initialize(options = {})
-        super()
+        super(options)
         @array_count = options['array_count'] || 3
       end
 

data/lib/rails_best_practices/reviews/move_code_into_model_review.rb

@@ -16,7 +16,7 @@ module RailsBestPractices
       url "http://rails-bestpractices.com/posts/25-move-code-into-model"
 
       def initialize(options={})
-        super()
+        super(options)
         @use_count = options['use_count'] || 2
       end
 

data/lib/rails_best_practices/reviews/move_model_logic_into_model_review.rb

@@ -18,7 +18,7 @@ module RailsBestPractices
       url "http://rails-bestpractices.com/posts/7-move-model-logic-into-the-model"
 
       def initialize(options = {})
-        super()
+        super(options)
         @use_count = options['use_count'] || 4
       end
 

data/lib/rails_best_practices/reviews/needless_deep_nesting_review.rb

@@ -27,7 +27,7 @@ module RailsBestPractices
       url "http://rails-bestpractices.com/posts/11-needless-deep-nesting"
 
       def initialize(options = {})
-        super()
+        super(options)
         @counter = 0
         @nested_count = options['nested_count'] || 2
         @shallow_nodes = []

data/lib/rails_best_practices/reviews/overuse_route_customizations_review.rb

@@ -33,7 +33,7 @@ module RailsBestPractices
       VERBS = %w(get post update delete)
 
       def initialize(options = {})
-        super()
+        super(options)
         @customize_count = options['customize_count'] || 3
       end
 

data/lib/rails_best_practices/reviews/remove_unused_methods_in_models_review.rb

@@ -94,8 +94,7 @@ module RailsBestPractices
           %w(
             initialize
             validate validate_each validate_on_create validate_on_update
-            human_attribute_name
-            assign_attributes
+            human_attribute_name assign_attributes attributes attribute
             to_xml to_json as_json to_param
             before_save before_create before_update before_destroy after_save after_create
             after_update after_destroy after_find after_initialize

data/lib/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review.rb

@@ -21,7 +21,7 @@ module RailsBestPractices
       url "http://rails-bestpractices.com/posts/6-replace-complex-creation-with-factory-method"
 
       def initialize(options = {})
-        super()
+        super(options)
         @assigns_count = options['attribute_assignment_count'] || 2
       end
 

data/lib/rails_best_practices/reviews/restrict_auto_generated_routes_review.rb

@@ -20,7 +20,8 @@ module RailsBestPractices
       RESOURCE_METHODS = ["show", "new", "create", "edit", "update", "destroy"]
       RESOURCES_METHODS = RESOURCE_METHODS + ["index"]
 
-      def initialize
+      def initialize(options={})
+        super(options)
         @namespaces = []
         @resource_controllers = []
       end

data/lib/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review.rb

@@ -24,7 +24,7 @@ module RailsBestPractices
       # check def node and find if the corresponding views exist or not?
       add_callback :start_def do |node|
         name = node.method_name.to_s
-        if deliver_method?(name) && rails_canonical_mailer_views?(name)
+        if !rails_canonical_mailer_views?(name)
           add_error("use multipart/alternative as content_type of email")
         end
       end
@@ -34,45 +34,34 @@ module RailsBestPractices
         #
         # @param [String] name method name in action_mailer
         def rails_canonical_mailer_views?(name)
-          rails2_canonical_mailer_views?(name) || rails3_canonical_mailer_views?(name)
+          if Prepares.gems.gem_version("rails").to_i > 2
+            rails3_canonical_mailer_views?(name)
+          else
+            rails2_canonical_mailer_views?(name)
+          end
         end
 
         # check if rails2's syntax mailer views are canonical.
         #
         # @param [String] name method name in action_mailer
         def rails2_canonical_mailer_views?(name)
-          (exist?("#{name}.text.html.erb") && !exist?("#{name}.text.plain.erb")) ||
-          (exist?("#{name}.text.html.haml") && !exist?("#{name}.text.plain.haml")) ||
-          (exist?("#{name}.text.html.slim") && !exist?("#{name}.text.plain.slim")) ||
-          (exist?("#{name}.text.html.rhtml") && !exist?("#{name}.text.plain.rhtml"))
+          return true if mailer_files(name).length == 0
+          mailer_files(name).any? { |filename| filename.index 'text.html' } &&
+            mailer_files(name).any? { |filename| filename.index 'text.plain' }
         end
 
         # check if rails3's syntax mailer views are canonical.
         #
         # @param [String] name method name in action_mailer
         def rails3_canonical_mailer_views?(name)
-          (exist?("#{name}.html.erb") && !html_tempalte_exists?("#{name}.text")) ||
-          (exist?("#{name}.html.haml") && !html_tempalte_exists?("#{name}.text")) ||
-          (exist?("#{name}.html.slim") && !html_tempalte_exists?("#{name}.text"))
+          return true if mailer_files(name).length == 0
+          mailer_files(name).any? { |filename| filename.index 'html' } &&
+            mailer_files(name).any? { |filename| filename.index 'text' }
         end
 
-        # check if the filename existed in the mailer directory.
-        def exist?(filename)
-          File.exist? File.join(mailer_directory, filename)
-        end
-
-        # check if erb, haml or slim exists
-        def html_tempalte_exists?(filename)
-          exist?("#{filename}.erb") || exist?("#{filename}.haml") || exist?("#{filename}.slim")
-        end
-
-        # check if the method is a deliver_method.
-        #
-        # @param [String] name the name of the method
-        def deliver_method?(name)
-          Dir.entries(mailer_directory).find { |filename| filename.index name.to_s }
-        rescue
-          false
+        # all mail view files for a method name.
+        def mailer_files(name)
+          Dir.entries(mailer_directory) { |filename| filename.index name.to_s }
         end
 
         # the view directory of mailer.

data/lib/rails_best_practices/reviews/use_turbo_sprockets_rails3_review.rb

@@ -16,8 +16,10 @@ module RailsBestPractices
 
       # check command node to see if load 'deploy/assets'
       add_callback :start_command do |node|
-        if !Prepares.gems.has_gem?("turbo-sprockets-rails3") && "load" == node.message.to_s && "deploy/assets" == node.arguments.to_s
-          add_error "speed up assets precompile with turbo-sprockets-rails3"
+        if Prepares.gems.gem_version("rails").to_i == 3
+          if !Prepares.gems.has_gem?("turbo-sprockets-rails3") && "load" == node.message.to_s && "deploy/assets" == node.arguments.to_s
+            add_error "speed up assets precompile with turbo-sprockets-rails3"
+          end
         end
       end
     end

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.14.4"
+  VERSION = "1.15.1"
 end

data/spec/rails_best_practices/analyzer_spec.rb

@@ -7,21 +7,21 @@ module RailsBestPractices
 
     describe '::new' do
       it 'should expand a relative path to an absolute' do
-        subject.path.should eq File.expand_path('.')
+        expect(subject.path).to eq File.expand_path('.')
       end
     end
 
     describe "expand_dirs_to_files" do
       it "should expand all files in spec directory" do
         dir = File.dirname(__FILE__)
-        subject.expand_dirs_to_files(dir).should be_include(dir + '/analyzer_spec.rb')
+        expect(subject.expand_dirs_to_files(dir)).to be_include(dir + '/analyzer_spec.rb')
       end
     end
 
     describe "file_sort" do
       it "should get models first, mailers, helpers and then others" do
         files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/helpers/users_helper.rb", "app/models/user.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim", "lib/user.rb"]
-        subject.file_sort(files).should == ["app/models/user.rb", "app/mailers/user_mailer.rb", "app/helpers/users_helper.rb", "app/controllers/users_controller.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim", "lib/user.rb"]
+        expect(subject.file_sort(files)).to eq(["app/models/user.rb", "app/mailers/user_mailer.rb", "app/helpers/users_helper.rb", "app/controllers/users_controller.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim", "lib/user.rb"])
       end
     end
 
@@ -32,11 +32,11 @@ module RailsBestPractices
       end
 
       it "should ignore lib" do
-        subject.file_ignore(@all, 'lib/').should == @filtered
+        expect(subject.file_ignore(@all, 'lib/')).to eq(@filtered)
       end
 
       it "should ignore regexp patterns" do
-        subject.file_ignore(@all, /lib/).should == @filtered
+        expect(subject.file_ignore(@all, /lib/)).to eq(@filtered)
       end
     end
 
@@ -55,7 +55,7 @@ module RailsBestPractices
         subject.output_terminal_errors
         result = $stdout.string
         $stdout = $origin_stdout
-        result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 warnings.".red].join("\n") + "\n"
+        expect(result).to eq(["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 warnings.".red].join("\n") + "\n")
       end
     end
 
@@ -67,7 +67,7 @@ module RailsBestPractices
           Dir.mkdir(File.join(random_dir, 'vendor', 'my_project'))
           File.open(File.join(random_dir, 'vendor', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
           analyzer = Analyzer.new(File.join(random_dir, 'vendor', 'my_project'))
-          analyzer.parse_files.should be_include File.join(random_dir, 'vendor', 'my_project', 'my_file.rb')
+          expect(analyzer.parse_files).to be_include File.join(random_dir, 'vendor', 'my_project', 'my_file.rb')
         }
       end
 
@@ -77,7 +77,7 @@ module RailsBestPractices
           Dir.mkdir(File.join(random_dir, 'spec', 'my_project'))
           File.open(File.join(random_dir, 'spec', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
           analyzer = Analyzer.new(File.join(random_dir, 'spec', 'my_project'))
-          analyzer.parse_files.should be_include File.join(random_dir, 'spec', 'my_project', 'my_file.rb')
+          expect(analyzer.parse_files).to be_include File.join(random_dir, 'spec', 'my_project', 'my_file.rb')
         }
       end
 
@@ -87,7 +87,7 @@ module RailsBestPractices
           Dir.mkdir(File.join(random_dir, 'test', 'my_project'))
           File.open(File.join(random_dir, 'test', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
           analyzer = Analyzer.new(File.join(random_dir, 'test', 'my_project'))
-          analyzer.parse_files.should be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
+          expect(analyzer.parse_files).to be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
         }
       end
 
@@ -97,7 +97,7 @@ module RailsBestPractices
           Dir.mkdir(File.join(random_dir, 'test', 'my_project'))
           File.open(File.join(random_dir, 'test', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
           analyzer = Analyzer.new(File.join(random_dir, 'test', 'my_project'))
-          analyzer.parse_files.should be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
+          expect(analyzer.parse_files).to be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
         }
       end
 
@@ -107,7 +107,7 @@ module RailsBestPractices
           Dir.mkdir(File.join(random_dir, 'tmp', 'my_project'))
           File.open(File.join(random_dir, 'tmp', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
           analyzer = Analyzer.new(File.join(random_dir, 'tmp', 'my_project'))
-          analyzer.parse_files.should be_include File.join(random_dir, 'tmp', 'my_project', 'my_file.rb')
+          expect(analyzer.parse_files).to be_include File.join(random_dir, 'tmp', 'my_project', 'my_file.rb')
         }
       end
 

data/spec/rails_best_practices/core/check_spec.rb

@@ -7,7 +7,7 @@ module RailsBestPractices::Core
     context "debug" do
       it "should be debug mode" do
         Check.debug
-        Check.should be_debug
+        expect(Check).to be_debug
         Check.class_eval { @debug = false }
       end
     end

data/spec/rails_best_practices/core/error_spec.rb

@@ -3,28 +3,28 @@ require 'spec_helper'
 module RailsBestPractices::Core
   describe Error do
     it "should return error with filename, line number and message" do
-      Error.new(
+      expect(Error.new(
         filename: "app/models/user.rb",
         line_number: "100",
         message: "not good",
-        type: "BogusReview").to_s.should == "app/models/user.rb:100 - not good"
+        type: "BogusReview").to_s).to eq("app/models/user.rb:100 - not good")
     end
 
     it "should return short filename" do
       Runner.base_path = "../rails-bestpractices.com"
-      Error.new(
+      expect(Error.new(
         filename: "../rails-bestpractices.com/app/models/user.rb",
         line_number: "100",
         message: "not good",
-        type: "BogusReview").short_filename.should == "app/models/user.rb"
+        type: "BogusReview").short_filename).to eq("app/models/user.rb")
     end
 
     it "should return first line number" do
-      Error.new(
+      expect(Error.new(
         filename: "app/models/user.rb",
         line_number: "50,70,100",
         message: "not good",
-        type: "BogusReview").first_line_number.should == "50"
+        type: "BogusReview").first_line_number).to eq("50")
     end
   end
 end

data/spec/rails_best_practices/core/klasses_spec.rb

@@ -5,9 +5,33 @@ module RailsBestPractices::Core
     it { should be_a_kind_of Array }
 
     context "Klass" do
-      it "should get to_s" do
+      context "#class_name" do
+        it "gets class name without module" do
+          klass = Klass.new("BlogPost", "Post", [])
+          expect(klass.class_name).to eq("BlogPost")
+        end
+
+        it "gets class name with moduel" do
+          klass = Klass.new("BlogPost", "Post", ["Admin"])
+          expect(klass.class_name).to eq("Admin::BlogPost")
+        end
+      end
+
+      context "#extend_class_name" do
+        it "gets extend class name without module" do
+          klass = Klass.new("BlogPost", "Post", [])
+          expect(klass.extend_class_name).to eq("Post")
+        end
+
+        it "gets extend class name with module" do
+          klass = Klass.new("BlogPost", "Post", ["Admin"])
+          expect(klass.extend_class_name).to eq("Admin::Post")
+        end
+      end
+
+      it "gets to_s equal to class_name" do
         klass = Klass.new("BlogPost", "Post", ["Admin"])
-        klass.to_s.should == "Admin::BlogPost"
+        expect(klass.to_s).to eq(klass.class_name)
       end
     end
   end