rails_best_practices 1.14.4 → 1.15.1

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -3,29 +3,32 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseMultipartAlternativeAsContentTypeOfEmailReview do
-      let(:runner) { Core::Runner.new(reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new) }
-
-      before(:each) { Core::Runner.stub!(:base_path).and_return(".") }
-
-      def mock_email_files(entry_files, options={})
-        Dir.stub!(:entries).with("./app/views/project_mailer").and_return(entry_files)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.erb").and_return(options["text.plain.erb"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.erb").and_return(options["text.html.erb"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.erb").and_return(options["text.erb"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.erb").and_return(options["html.erb"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.haml").and_return(options["text.plain.haml"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.haml").and_return(options["text.html.haml"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.haml").and_return(options["text.haml"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.haml").and_return(options["html.haml"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.slim").and_return(options["text.plain.slim"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.slim").and_return(options["text.html.slim"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.slim").and_return(options["text.slim"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.html.slim").and_return(options["html.slim"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.plain.rhtml").and_return(options["text.plain.rhtml"] || false)
-        File.stub!(:exist?).with("./app/views/project_mailer/send_email.text.html.rhtml").and_return(options["text.html.rhtml"] || false)
+      let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new) }
+
+      before(:each) { allow(Core::Runner).to receive(:base_path).and_return(".") }
+
+      def mock_email_files(entry_files)
+        allow(Dir).to receive(:entries).with("./app/views/project_mailer").and_return(entry_files)
       end
 
       context "rails2" do
+        before do
+        content = <<-EOF
+GEM
+  remote: http://rubygems.org
+  specs:
+    rails (2.3.14)
+      actionmailer (= 2.3.14)
+      actionpack (= 2.3.14)
+      activerecord (= 2.3.14)
+      activeresource (= 2.3.14)
+      activesupport (= 2.3.14)
+      bundler (~> 1.0)
+      railties (= 2.3.14)
+        EOF
+        runner.prepare('Gemfile.lock', content)
+        end
+
         context "project_mailer" do
           let(:content) {
             <<-EOF
@@ -43,85 +46,89 @@ module RailsBestPractices
 
           context "erb" do
             it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.erb"], "text.html.erb" => true)
+              mock_email_files(["send_email.text.html.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.erb"], "text.plain.erb" => true, "text.html.erb" => true)
+            it "should use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.erb"], "text.plain.erb" => true)
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.plain.erb", "send_email.text.html.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
 
           context "haml" do
             it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.haml"], "text.html.haml" => true)
+              mock_email_files(["send_email.text.html.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.haml"], "text.plain.haml" => true, "text.html.haml" => true)
+            it "should use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.haml"], "text.plain.haml" => true)
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.plain.haml", "send_email.text.html.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
 
           context "slim" do
             it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.slim"], "text.html.slim" => true)
+              mock_email_files(["send_email.text.html.slim"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.slim"], "text.plain.slim" => true, "text.html.slim" => true)
+            it "should use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.slim"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.slim"], "text.plain.slim" => true)
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.plain.slim", "send_email.text.html.slim"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
 
           context "rhtml" do
             it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.rhtml"], "text.html.rhtml" => true)
+              mock_email_files(["send_email.text.html.rhtml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.text.html.rhtml"], "text.plain.rhtml" => true, "text.html.rhtml" => true)
+            it "should use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.plain.rhtml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.plain.rhtml"], "text.plain.rhtml" => true)
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.plain.rhtml", "send_email.text.html.rhtml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
         end
@@ -133,13 +140,30 @@ module RailsBestPractices
             end
           end
           EOF
-          mock_email_files(["send_email.text.html.erb"])
+          mock_email_files([])
           runner.review('app/mailers/project_mailer.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
       end
 
       context "rails3" do
+        before do
+        content = <<-EOF
+GEM
+  remote: http://rubygems.org
+  specs:
+    rails (3.2.13)
+      actionmailer (= 3.2.13)
+      actionpack (= 3.2.13)
+      activerecord (= 3.2.13)
+      activeresource (= 3.2.13)
+      activesupport (= 3.2.13)
+      bundler (~> 1.0)
+      railties (= 3.2.13)
+        EOF
+        runner.prepare('Gemfile.lock', content)
+        end
+
         context "project_mailer" do
           let(:content) {
             <<-EOF
@@ -157,57 +181,78 @@ module RailsBestPractices
 
           context "erb" do
             it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.erb"], "html.erb" => true)
+              mock_email_files(["send_email.html.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.erb"], "text.erb" => true, "html.erb" => true)
+            it "should use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.erb"], "text.erb" => true)
+            it "should not use multipart/alternative as content_type of email" do
+              mock_email_files(["send_email.text.erb", "send_email.html.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
 
           context "haml" do
             it "should use mulipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.haml"], "html.haml" => true)
+              mock_email_files(["send_email.html.haml"])
+              runner.review('app/mailers/project_mailer.rb', content)
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
+            end
+
+            it "should use multiple/alternative as content_type of email when only plain text" do
+              mock_email_files(["send_email.text.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
             end
 
             it "should not use multipart/alternative as content_type of email" do
-              mock_email_files(["send_email.html.haml", "send_email.text.haml"], "html.haml" => true, "text.haml" => true)
+              mock_email_files(["send_email.html.haml", "send_email.text.haml"])
+              runner.review('app/mailers/project_mailer.rb', content)
+              expect(runner.errors.size).to eq(0)
+            end
+
+            it "should not use multipart/alternative as content_type of email with text locale" do
+              mock_email_files(["send_email.html.haml", "send_email.de.text.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
 
-            it "should not use multiple/alternative as content_type of email when only plain text" do
-              mock_email_files(["send_email.text.haml"], "text.haml" => true)
+            it "should not use multipart/alternative as content_type of email with html locale" do
+              mock_email_files(["send_email.de.html.haml", "send_email.text.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
 
           context "haml/erb mix" do
             it "should not suggest using multipart/alternative when mixing html.haml and text.erb" do
-              mock_email_files(["send_email.html.haml", "send_email.text.erb"], "html.haml" => true, "text.erb" => true)
+              mock_email_files(["send_email.html.haml", "send_email.text.erb"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
 
-              mock_email_files(["send_email.html.erb", "send_email.text.haml"], "html.erb" => true, "text.haml" => true)
+              mock_email_files(["send_email.html.erb", "send_email.text.haml"])
               runner.review('app/mailers/project_mailer.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
+
+          it "should not check ignored files" do
+            runner = Core::Runner.new(reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new(ignored_files: /project_mailer/))
+            mock_email_files(["send_email.html.haml"])
+            runner.review('app/mailers/project_mailer.rb', content)
+            expect(runner.errors.size).to eq(0)
+          end
         end
       end
     end

data/spec/rails_best_practices/reviews/use_observer_review_spec.rb

@@ -28,8 +28,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/models/project.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/models/project.rb:5 - use observer"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
         end
 
         it "should not use observer without callback" do
@@ -44,7 +44,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/models/project.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should use observer with two after_create" do
@@ -64,8 +64,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/models/project.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/models/project.rb:5 - use observer"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
         end
 
         it "should not raise when initiate an object in callback" do
@@ -74,7 +74,7 @@ module RailsBestPractices
             after_create ProjectMailer.new
           end
           EOF
-          lambda { runner.review('app/models/project.rb', content) }.should_not raise_error
+          expect { runner.review('app/models/project.rb', content) }.not_to raise_error
         end
       end
 
@@ -93,8 +93,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/models/project.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/models/project.rb:5 - use observer"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
         end
 
         it "should not use observer without callback" do
@@ -109,7 +109,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/models/project.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should use observer with two after_create" do
@@ -129,8 +129,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/models/project.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/models/project.rb:5 - use observer"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
         end
 
         it "should not raise when initiate an object in callback" do
@@ -139,7 +139,7 @@ module RailsBestPractices
             after_create ProjectMailer.new
           end
           EOF
-          lambda { runner.review('app/models/project.rb', content) }.should_not raise_error
+          expect { runner.review('app/models/project.rb', content) }.not_to raise_error
         end
       end
     end

data/spec/rails_best_practices/reviews/use_parenthesis_in_method_def_spec.rb

@@ -13,8 +13,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - use parentheses around parameters in method definitions"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - use parentheses around parameters in method definitions")
       end
       it "should find parentheses with no error" do
         content = <<-EOF
@@ -24,7 +24,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
       it "should not throw an error without parameters" do
         content = <<-EOF
@@ -34,7 +34,19 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: UseParenthesesInMethodDefReview.new(ignored_files: /posts_controller/))
+                content = <<-EOF
+        class PostsController < ApplicationController
+          def edit foo, bar
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -35,8 +35,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute by blank call with if in one line" do
@@ -44,8 +44,8 @@ module RailsBestPractices
         <%= link_to 'login', new_session_path if @user.login.blank? %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute by blank call with '? :'" do
@@ -53,8 +53,8 @@ module RailsBestPractices
         <%= @user.login.blank? ? link_to('login', new_session_path) : '' %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute by comparing empty string" do
@@ -64,8 +64,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute by nil call" do
@@ -75,8 +75,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute by present call" do
@@ -86,8 +86,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute within and conditions" do
@@ -97,8 +97,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should use query attribute within or conditions" do
@@ -108,8 +108,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/users/show.html.erb:1 - use query attribute (@user.login?)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
       end
 
       it "should not use query attribute" do
@@ -119,7 +119,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use query attribute for number" do
@@ -129,7 +129,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not review for pluralize attribute" do
@@ -139,7 +139,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not review non model class" do
@@ -149,7 +149,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       context "association" do
@@ -160,7 +160,7 @@ module RailsBestPractices
           <% end %>
           EOF
           runner.review('app/views/users/show.html.erb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should not review belongs_to category" do
@@ -170,7 +170,7 @@ module RailsBestPractices
           <% end %>
           EOF
           runner.review('app/views/users/show.html.erb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should not review has_one association" do
@@ -180,7 +180,7 @@ module RailsBestPractices
           <% end %>
           EOF
           runner.review('app/views/users/show.html.erb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should not review has_many association" do
@@ -190,7 +190,7 @@ module RailsBestPractices
           <% end %>
           EOF
           runner.review('app/views/users/show.html.erb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
       end
 
@@ -201,7 +201,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not review for non attribute call" do
@@ -211,7 +211,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/models/users_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not raise error for common conditional statement" do
@@ -220,7 +220,19 @@ module RailsBestPractices
           puts voteable.title
         end
         EOF
-        lambda { runner.review('app/models/users_controller.rb', content) }.should_not raise_error
+        expect { runner.review('app/models/users_controller.rb', content) }.not_to raise_error
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
+                                  reviews: UseQueryAttributeReview.new(ignored_files: /users\/show/))
+        content = <<-EOF
+        <% if @user.login.blank? %>
+          <%= link_to 'login', new_session_path %>
+        <% end %>
+        EOF
+        runner.review('app/views/users/show.html.erb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end