rails_best_practices 1.14.4 → 1.15.1

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -15,8 +15,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 7
-            routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+            expect(routes.size).to eq(7)
+            expect(routes.map(&:to_s)).to eq(["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"])
           end
 
           it "should add multiple resources route" do
@@ -27,7 +27,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 14
+            expect(routes.size).to eq(14)
           end
 
           it "should add resources route with explict controller" do
@@ -38,8 +38,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 7
-            routes.map(&:to_s).should == ["BlogPostsController#index", "BlogPostsController#show", "BlogPostsController#new", "BlogPostsController#create", "BlogPostsController#edit", "BlogPostsController#update", "BlogPostsController#destroy"]
+            expect(routes.size).to eq(7)
+            expect(routes.map(&:to_s)).to eq(["BlogPostsController#index", "BlogPostsController#show", "BlogPostsController#new", "BlogPostsController#create", "BlogPostsController#edit", "BlogPostsController#update", "BlogPostsController#destroy"])
           end
 
           it "should add resources route with only option" do
@@ -50,8 +50,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 4
-            routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(4)
+            expect(routes.map(&:to_s)).to eq(["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should add resources route with except option" do
@@ -62,8 +62,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 4
-            routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(4)
+            expect(routes.map(&:to_s)).to eq(["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should not add resources routes with only: :none" do
@@ -74,7 +74,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should not add resources routes with except: :all" do
@@ -85,7 +85,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should add resource routes with hash collection/member routes" do
@@ -96,8 +96,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 5
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "PostsController#list"]
+            expect(routes.size).to eq(5)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "PostsController#list"])
           end
 
           it "should add resource routes with array collection/member routes" do
@@ -108,8 +108,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 5
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "PostsController#list"]
+            expect(routes.size).to eq(5)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "PostsController#list"])
           end
 
           it "should add route with nested routes" do
@@ -122,7 +122,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 14
+            expect(routes.size).to eq(14)
           end
 
           it "should add route with namespace" do
@@ -137,7 +137,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == ["Admin::Test::PostsController#index"]
+            expect(routes.map(&:to_s)).to eq(["Admin::Test::PostsController#index"])
           end
         end
 
@@ -150,8 +150,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 6
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+            expect(routes.size).to eq(6)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"])
           end
 
           it "should add multiple resource route" do
@@ -162,7 +162,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 12
+            expect(routes.size).to eq(12)
           end
 
           it "should add resource route with only option" do
@@ -173,8 +173,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 3
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(3)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should add resource route with except option" do
@@ -185,8 +185,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 3
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(3)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should not add resource routes with only: :none" do
@@ -197,7 +197,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should not add resource routes with except: :all" do
@@ -208,7 +208,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
         end
 
@@ -220,7 +220,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["VotesController#create"]
+          expect(routes.map(&:to_s)).to eq(["VotesController#create"])
         end
 
         it "should add connect route with all actions" do
@@ -231,7 +231,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["InternalController#*"]
+          expect(routes.map(&:to_s)).to eq(["InternalController#*"])
         end
 
         it "should add named route" do
@@ -242,7 +242,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["SessionsController#new"]
+          expect(routes.map(&:to_s)).to eq(["SessionsController#new"])
         end
 
         it "should add named route with with_options" do
@@ -255,7 +255,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["AdminSessionController#new"]
+          expect(routes.map(&:to_s)).to eq(["AdminSessionController#new"])
         end
 
         it "should not take former resources for direct get/post" do
@@ -267,7 +267,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.last.to_s.should == "SprintsController#stop"
+          expect(routes.last.to_s).to eq("SprintsController#stop")
         end
       end
 
@@ -281,8 +281,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 7
-            routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+            expect(routes.size).to eq(7)
+            expect(routes.map(&:to_s)).to eq(["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"])
           end
 
           it "should add multiple resources route" do
@@ -293,7 +293,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 14
+            expect(routes.size).to eq(14)
           end
 
           it "should add resources route with explict controller" do
@@ -304,8 +304,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 7
-            routes.map(&:to_s).should == ["BlogPostsController#index", "BlogPostsController#show", "BlogPostsController#new", "BlogPostsController#create", "BlogPostsController#edit", "BlogPostsController#update", "BlogPostsController#destroy"]
+            expect(routes.size).to eq(7)
+            expect(routes.map(&:to_s)).to eq(["BlogPostsController#index", "BlogPostsController#show", "BlogPostsController#new", "BlogPostsController#create", "BlogPostsController#edit", "BlogPostsController#update", "BlogPostsController#destroy"])
           end
 
           it "should add resources route with only option" do
@@ -316,8 +316,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 4
-            routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(4)
+            expect(routes.map(&:to_s)).to eq(["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should add resources route with except option" do
@@ -328,8 +328,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 4
-            routes.map(&:to_s).should == ["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(4)
+            expect(routes.map(&:to_s)).to eq(["PostsController#index", "PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should not add resources routes with only: :none" do
@@ -340,7 +340,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should not add resources routes with except: :all" do
@@ -351,7 +351,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should add resources routes with members" do
@@ -369,11 +369,11 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == [
+            expect(routes.map(&:to_s)).to eq([
               "Admin::PostsController#edit",
               "Admin::PostsController#update",
               "Admin::PostsController#link_to_post",
-              "Admin::PostsController#extra_update"]
+              "Admin::PostsController#extra_update"])
           end
 
           it "should add connect route" do
@@ -384,7 +384,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == ["VotesController#create"]
+            expect(routes.map(&:to_s)).to eq(["VotesController#create"])
           end
 
           it "should add named route" do
@@ -395,7 +395,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == ["SessionsController#new"]
+            expect(routes.map(&:to_s)).to eq(["SessionsController#new"])
           end
         end
 
@@ -408,8 +408,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 6
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"]
+            expect(routes.size).to eq(6)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#new", "PostsController#create", "PostsController#edit", "PostsController#update", "PostsController#destroy"])
           end
 
           it "should add multiple resource route" do
@@ -420,7 +420,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 12
+            expect(routes.size).to eq(12)
           end
 
           it "should add resource route with only option" do
@@ -431,8 +431,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 3
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(3)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should add resource route with except option" do
@@ -443,8 +443,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 3
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#new", "PostsController#create"]
+            expect(routes.size).to eq(3)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#new", "PostsController#create"])
           end
 
           it "should not add resource routes with only: :none" do
@@ -455,7 +455,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should not add resource routes with except: :all" do
@@ -466,7 +466,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 0
+            expect(routes.size).to eq(0)
           end
 
           it "should add resource routes with get/post/put/delete routes" do
@@ -487,8 +487,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 6
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#list", "PostsController#search", "PostsController#available", "PostsController#create", "PostsController#update"]
+            expect(routes.size).to eq(6)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#list", "PostsController#search", "PostsController#available", "PostsController#create", "PostsController#update"])
           end
 
           it "should add custom resources routes with {}" do
@@ -499,8 +499,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 2
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#inactive"]
+            expect(routes.size).to eq(2)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#inactive"])
           end
 
           it "should add resources routes with get %w() routes" do
@@ -515,8 +515,8 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 3
-            routes.map(&:to_s).should == ["PostsController#show", "PostsController#latest", "PostsController#popular"]
+            expect(routes.size).to eq(3)
+            expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#latest", "PostsController#popular"])
           end
 
           it "should add route with nested routes" do
@@ -529,7 +529,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.size.should == 14
+            expect(routes.size).to eq(14)
           end
 
           it "should add route with namespace" do
@@ -544,7 +544,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == ["Admin::Test::PostsController#index"]
+            expect(routes.map(&:to_s)).to eq(["Admin::Test::PostsController#index"])
           end
 
           it "should add route with namespace, but without resources" do
@@ -558,7 +558,7 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == ["SomethingController#route_one", "SomethingController#route_two", "SomethingController#custom_action"]
+            expect(routes.map(&:to_s)).to eq(["SomethingController#route_one", "SomethingController#route_two", "SomethingController#custom_action"])
           end
 
           it "should add route with scope" do
@@ -581,13 +581,13 @@ module RailsBestPractices
             EOF
             runner.prepare('config/routes.rb', content)
             routes = Prepares.routes
-            routes.map(&:to_s).should == [
+            expect(routes.map(&:to_s)).to eq([
                                            "Admin::PostsController#index",
                                            "Admin::DiscussionsController#index",
                                            "CommentsController#index",
                                            "UsersController#show",
                                            "UsersController#preview"
-                                         ]
+                                         ])
           end
         end
 
@@ -603,8 +603,8 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.size.should == 5
-          routes.map(&:to_s).should == ["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "HighVoltage::PagesController#show"]
+          expect(routes.size).to eq(5)
+          expect(routes.map(&:to_s)).to eq(["PostsController#show", "PostsController#create", "PostsController#update", "PostsController#destroy", "HighVoltage::PagesController#show"])
         end
 
         it "should add routes for another get/post" do
@@ -615,8 +615,8 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.size.should == 1
-          routes.first.to_s.should == "SessionsController#new"
+          expect(routes.size).to eq(1)
+          expect(routes.first.to_s).to eq("SessionsController#new")
         end
 
         it "should add match route" do
@@ -627,7 +627,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["AuthenticationsController#create"]
+          expect(routes.map(&:to_s)).to eq(["AuthenticationsController#create"])
         end
 
         it "should add match route with all actions" do
@@ -638,7 +638,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["InternalController#*"]
+          expect(routes.map(&:to_s)).to eq(["InternalController#*"])
         end
 
         it "should add root route" do
@@ -649,7 +649,18 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.map(&:to_s).should == ["HomeController#index"]
+          expect(routes.map(&:to_s)).to eq(["HomeController#index"])
+        end
+
+        it "should add root shortcut route" do
+          content =<<-EOF
+          RailsBestPracticesCom::Application.routes.draw do
+            root 'home#index'
+          end
+          EOF
+          runner.prepare('config/routes.rb', content)
+          routes = Prepares.routes
+          expect(routes.map(&:to_s)).to eq(["HomeController#index"])
         end
 
         it "should do nothing for default route" do
@@ -660,7 +671,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.size.should == 0
+          expect(routes.size).to eq(0)
         end
 
         it "should do nothing for redirect" do
@@ -672,7 +683,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.size.should == 0
+          expect(routes.size).to eq(0)
         end
 
         it "should parse customize route in nested resources" do
@@ -686,7 +697,20 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.last.to_s.should == "PostsController#stop"
+          expect(routes.last.to_s).to eq("PostsController#stop")
+        end
+
+        it "should parse custom route for resource with explicit to and different action name" do
+          content =<<-EOF
+          RailsBestPracticesCom::Application.routes.draw do
+            resources :posts do
+              get :halt, to: 'posts#stop'
+            end
+          end
+          EOF
+          runner.prepare('config/routes.rb', content)
+          routes = Prepares.routes
+          expect(routes.last.to_s).to eq("PostsController#stop")
         end
 
         it "should not take former resources for direct get/post" do
@@ -698,7 +722,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.last.to_s.should == "SprintsController#stop"
+          expect(routes.last.to_s).to eq("SprintsController#stop")
         end
 
         it "should not parse wrong route" do
@@ -709,7 +733,7 @@ module RailsBestPractices
           EOF
           runner.prepare('config/routes.rb', content)
           routes = Prepares.routes
-          routes.size.should == 0
+          expect(routes.size).to eq(0)
         end
       end
     end

data/spec/rails_best_practices/prepares/schema_prepare_spec.rb

@@ -20,12 +20,12 @@ module RailsBestPractices
         EOF
         runner.prepare("db/schema.rb", content)
         model_attributes = Prepares.model_attributes
-        model_attributes.get_attribute_type("Post", "title").should == "string"
-        model_attributes.get_attribute_type("Post", "body").should == "text"
-        model_attributes.get_attribute_type("Post", "created_at").should == "datetime"
-        model_attributes.get_attribute_type("Post", "user_id").should == "integer"
-        model_attributes.get_attribute_type("Post", "comments_count").should == "integer"
-        model_attributes.get_attribute_type("Post", "published").should == "boolean"
+        expect(model_attributes.get_attribute_type("Post", "title")).to eq("string")
+        expect(model_attributes.get_attribute_type("Post", "body")).to eq("text")
+        expect(model_attributes.get_attribute_type("Post", "created_at")).to eq("datetime")
+        expect(model_attributes.get_attribute_type("Post", "user_id")).to eq("integer")
+        expect(model_attributes.get_attribute_type("Post", "comments_count")).to eq("integer")
+        expect(model_attributes.get_attribute_type("Post", "published")).to eq("boolean")
       end
     end
   end

data/spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb

@@ -17,8 +17,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/users_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/users_controller.rb:2 - add model virtual attribute (for @user)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/users_controller.rb:2 - add model virtual attribute (for @user)")
       end
 
       it "should add model virtual attribute with local assignment" do
@@ -33,8 +33,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/users_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/users_controller.rb:2 - add model virtual attribute (for user)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/users_controller.rb:2 - add model virtual attribute (for user)")
       end
 
       it "should not add model virtual attribute with differen param" do
@@ -49,7 +49,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/users_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not add model virtual attribute with read" do
@@ -65,7 +65,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/users_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should add model virtual attribute with two dimension params" do
@@ -80,8 +80,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/users_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/users_controller.rb:2 - add model virtual attribute (for @user)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/users_controller.rb:2 - add model virtual attribute (for @user)")
       end
 
       it "should no add model virtual attribute with two dimension params" do
@@ -96,7 +96,23 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/users_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: AddModelVirtualAttributeReview.new(ignored_files: /user/))
+        content = <<-EOF
+        class UsersController < ApplicationController
+          def create
+            @user = User.new(params[:user])
+            @user.first_name = params[:full_name].split(' ', 2).first
+            @user.last_name = params[:full_name].split(' ', 2).last
+            @user.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/users_controller.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end