rails_best_practices 1.14.4 → 1.15.1

data/spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb

@@ -15,8 +15,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations")
       end
 
       it "should use say with time in migrations with create_table" do
@@ -34,8 +34,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations")
       end
 
       it "should not use say with time in migrations" do
@@ -51,7 +51,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use say with time in migrations when not first code line" do
@@ -65,7 +65,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use say with time when default migration message" do
@@ -79,7 +79,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('db/migrate/20101010080658_create_users.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not raise an error" do
@@ -115,7 +115,21 @@ module RailsBestPractices
         end
         EOF
         runner.review('db/migrate/20101010080658_create_users.rb', content)
-        runner.should have(3).errors
+        expect(runner.errors.size).to eq(3)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new(ignored_files: /20101010080658_update_users/))
+        content =<<-EOF
+        def self.up
+          User.find_each do |user|
+            user.first_name, user.last_name = user.full_name.split(' ')
+            user.save
+          end
+        end
+        EOF
+        runner.review('db/migrate/20101010080658_update_users.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/use_scope_access_review_spec.rb

@@ -20,8 +20,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access with if in one line" do
@@ -35,8 +35,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access with '? :'" do
@@ -50,8 +50,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access by comparing with id" do
@@ -68,8 +68,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access with current_user ==" do
@@ -86,8 +86,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access by current_user.id ==" do
@@ -104,8 +104,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
       end
 
@@ -124,8 +124,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access by comparing with id" do
@@ -142,8 +142,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access with current_user ==" do
@@ -160,8 +160,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "shoud use scope access by current_user.id ==" do
@@ -178,8 +178,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:5 - use scope access"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
         end
 
         it "should no error in use_scope_access_review" do
@@ -201,7 +201,25 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/controllers/comments_controller.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
+        end
+
+        it "should not check ignored files" do
+          runner = Core::Runner.new(reviews: UseScopeAccessReview.new(ignored_files: /posts_controller/))
+          content = <<-EOF
+          class PostsController < ApplicationController
+            def edit
+              @post = Post.find(params[:id])
+
+              unless @post.user == current_user
+                flash[:warning] = 'Access Denied'
+                redirect_to posts_url
+              end
+            end
+          end
+          EOF
+          runner.review('app/controllers/posts_controller.rb', content)
+          expect(runner.errors.size).to eq(0)
         end
       end
     end

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -7,18 +7,27 @@ module RailsBestPractices
 
       it "should use turbo-sprockets-rails3" do
         content = <<-EOF
-        source "http://rubygems.org"
-        gem "rails"
+GEM
+  remote: http://rubygems.org
+  specs:
+    rails (3.2.13)
+      actionmailer (= 3.2.13)
+      actionpack (= 3.2.13)
+      activerecord (= 3.2.13)
+      activeresource (= 3.2.13)
+      activesupport (= 3.2.13)
+      bundler (~> 1.0)
+      railties (= 3.2.13)
         EOF
-        runner.prepare('Gemfile', content)
+        runner.prepare('Gemfile.lock', content)
         content = <<-EOF
         load 'deploy' if respond_to?(:namespace)
         load 'deploy/assets'
         load 'config/deploy'
         EOF
         runner.review('Capfile', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "Capfile:2 - speed up assets precompile with turbo-sprockets-rails3"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("Capfile:2 - speed up assets precompile with turbo-sprockets-rails3")
       end
 
       it "should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem" do
@@ -45,7 +54,7 @@ GEM
         load 'config/deploy'
         EOF
         runner.review('Capfile', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use turbo-sprockets-rails3 without deploy/assets" do
@@ -55,7 +64,57 @@ GEM
         load 'config/deploy'
         EOF
         runner.review('Capfile', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not use turbo-sprockets-rails3 with rails4 gem" do
+        content = <<-EOF
+GEM
+  remote: http://rubygems.org
+  specs:
+    rails (4.0.0)
+      actionmailer (= 4.0.0)
+      actionpack (= 4.0.0)
+      activerecord (= 4.0.0)
+      activeresource (= 4.0.0)
+      activesupport (= 4.0.0)
+      bundler (~> 1.0)
+      railties (= 3.2.13)
+        EOF
+        runner.prepare('Gemfile.lock', content)
+        content = <<-EOF
+        load 'deploy' if respond_to?(:namespace)
+        load 'deploy/assets'
+        load 'config/deploy'
+        EOF
+        runner.review('Capfile', content)
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(prepares: Prepares::GemfilePrepare.new,
+                                  reviews: UseTurboSprocketsRails3Review.new(ignored_files: /Capfile/))
+        content = <<-EOF
+GEM
+  remote: http://rubygems.org
+  specs:
+    rails (3.2.13)
+      actionmailer (= 3.2.13)
+      actionpack (= 3.2.13)
+      activerecord (= 3.2.13)
+      activeresource (= 3.2.13)
+      activesupport (= 3.2.13)
+      bundler (~> 1.0)
+      railties (= 3.2.13)
+        EOF
+        runner.prepare('Gemfile.lock', content)
+        content = <<-EOF
+        load 'deploy' if respond_to?(:namespace)
+        load 'deploy/assets'
+        load 'config/deploy'
+        EOF
+        runner.review('Capfile', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

metadata

@@ -1,195 +1,195 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.14.4
+  version: 1.15.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-26 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: code_analyzer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.4.3
 - !ruby/object:Gem::Dependency
   name: colored
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: require_all
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: slim
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: a code metric tool for rails codes, written in Ruby.
@@ -200,12 +200,11 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gemtest
-- .gitignore
-- .rspec
-- .ruby-gemset
-- .ruby-version
-- .travis.yml
+- ".gemtest"
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - MIT_LICENSE
@@ -389,17 +388,17 @@ require_paths:
 - assets
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.2.0.rc.1
 signing_key: 
 specification_version: 4
 summary: a code metric tool for rails codes.

data/.ruby-gemset

@@ -1 +0,0 @@
-rails_best_practices