rails_best_practices 1.14.4 → 1.15.1

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -33,8 +33,8 @@ module RailsBestPractices
           <%= @invoice.user.cellphone %>
           EOF
           runner.review('app/views/invoices/show.html.erb', content)
-          runner.should have(3).errors
-          runner.errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
+          expect(runner.errors.size).to eq(3)
+          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.erb:1 - law of demeter")
         end
 
         it "should law of demeter with haml" do
@@ -44,8 +44,8 @@ module RailsBestPractices
 = @invoice.user.cellphone
           EOF
           runner.review('app/views/invoices/show.html.haml', content)
-          runner.should have(3).errors
-          runner.errors[0].to_s.should == "app/views/invoices/show.html.haml:1 - law of demeter"
+          expect(runner.errors.size).to eq(3)
+          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.haml:1 - law of demeter")
         end
 
         it "should law of demeter with slim" do
@@ -55,8 +55,8 @@ module RailsBestPractices
 = @invoice.user.cellphone
           EOF
           runner.review('app/views/invoices/show.html.slim', content)
-          runner.should have(3).errors
-          runner.errors[0].to_s.should == "app/views/invoices/show.html.slim:1 - law of demeter"
+          expect(runner.errors.size).to eq(3)
+          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.slim:1 - law of demeter")
         end
 
         it "should no law of demeter" do
@@ -66,7 +66,7 @@ module RailsBestPractices
           <%= @invoice.user_cellphone %>
           EOF
           runner.review('app/views/invoices/show.html.erb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
       end
 
@@ -96,8 +96,8 @@ module RailsBestPractices
           <%= @invoice.price.number %>
           EOF
           runner.review('app/views/invoices/show.html.erb', content)
-          runner.should have(2).errors
-          runner.errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
+          expect(runner.errors.size).to eq(2)
+          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.erb:1 - law of demeter")
         end
       end
 
@@ -132,8 +132,8 @@ module RailsBestPractices
           <%= @comment.commentable.title %>
           EOF
           runner.review('app/views/comments/index.html.erb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/views/comments/index.html.erb:1 - law of demeter"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/views/comments/index.html.erb:1 - law of demeter")
         end
       end
 
@@ -158,7 +158,19 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/comments_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
+                                  reviews: LawOfDemeterReview.new(ignored_files: /app\/views\/invoices/))
+        content = <<-EOF
+          <%= @invoice.user.name %>
+          <%= @invoice.user.address %>
+          <%= @invoice.user.cellphone %>
+        EOF
+        runner.review('app/views/invoices/show.html.erb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -13,8 +13,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - move code into controller")
       end
 
       it "should move code into controller for assign" do
@@ -26,8 +26,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - move code into controller")
       end
 
       it "should not move code into controller" do
@@ -38,7 +38,19 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new(ignored_files: /app\/views\/post/))
+        content = <<-EOF
+        <% Post.find(:all).each do |post| %>
+          <%=h post.title %>
+          <%=h post.content %>
+        <% end %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -12,8 +12,8 @@ module RailsBestPractices
                                                    params[:default_state] ) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)")
       end
 
       it "should not move code into helper with simple arguments" do
@@ -21,7 +21,18 @@ module RailsBestPractices
         <%= select_tag :state, options_for_select( Post.STATES ) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => /app\/views\/post/))
+        content = <<-EOF
+        <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
+                                                    [t(:published), "published"]],
+                                                   params[:default_state] ) %>
+        EOF
+        runner.review('app/views/posts/show.html.erb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -12,8 +12,8 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)")
       end
 
       it "should move code into model with haml" do
@@ -22,8 +22,8 @@ module RailsBestPractices
   = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.haml', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)")
       end
 
       it "should move code into model with slim" do
@@ -32,8 +32,8 @@ module RailsBestPractices
   = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.slim', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)")
       end
 
       it "should move code into model with if in one line" do
@@ -41,8 +41,8 @@ module RailsBestPractices
         <%= link_to 'Edit this post', edit_post_url(@post) if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)")
       end
 
       it "should move code into model with '? :'" do
@@ -50,8 +50,8 @@ module RailsBestPractices
         <%= current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) ? link_to('Edit this post', edit_post_url(@post)) : '' %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)")
       end
 
       it "should move code into model only review for current if conditional statement" do
@@ -64,7 +64,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not move code into model" do
@@ -74,7 +74,7 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not move code into model for multiple calls on same variable node" do
@@ -83,7 +83,18 @@ module RailsBestPractices
         <% end %>
         EOF
         runner.review('app/views/jobs/show.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: MoveCodeIntoModelReview.new(ignored_files: /app\/views\/post/))
+        content =<<-EOF
+        <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
+          <%= link_to 'Edit this post', edit_post_url(@post) %>
+        <% end %>
+        EOF
+        runner.review('app/views/posts/show.html.erb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb

@@ -20,9 +20,9 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(2).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - move finder to named_scope"
-        runner.errors[1].to_s.should == "app/controllers/posts_controller.rb:7 - move finder to named_scope"
+        expect(runner.errors.size).to eq(2)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:3 - move finder to named_scope")
+        expect(runner.errors[1].to_s).to eq("app/controllers/posts_controller.rb:7 - move finder to named_scope")
       end
 
       it "should not move simple finder" do
@@ -39,7 +39,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not move namd_scope" do
@@ -52,7 +52,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not review model file" do
@@ -70,7 +70,26 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/model/post.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new(ignored_files: /app\/controllers\/posts/))
+        content = <<-EOF
+        class PostsController < ActionController::Base
+          def index
+            @public_posts = Post.find(:all, conditions: { state: 'public' },
+                                            limit: 10,
+                                            order: 'created_at desc')
+
+            @draft_posts  = Post.find(:all, conditions: { state: 'draft' },
+                                            limit: 10,
+                                            order: 'created_at desc')
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb

@@ -23,8 +23,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)")
       end
 
       it "should not move model logic into model with simple model calling" do
@@ -40,7 +40,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not move model logic into model with self calling" do
@@ -56,7 +56,29 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new(ignored_files: /app\/controllers\/posts/))
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def publish
+            @post = Post.find(params[:id])
+            @post.update_attributes(:is_published, true)
+            @post.approved_by = current_user
+            if @post.created_at > Time.now - 7.days
+              @post.popular = 100
+            else
+              @post.popular = 0
+            end
+
+            redirect_to post_url(@post)
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -15,8 +15,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
 
         it "should not needless deep nesting for shallow" do
@@ -28,7 +28,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should needless deep nesting with resource" do
@@ -40,8 +40,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
 
         it "should needless deep nesting with block node" do
@@ -54,8 +54,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
 
         it "should no needless deep nesting" do
@@ -69,7 +69,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should no needless deep nesting with block node" do
@@ -80,7 +80,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
       end
 
@@ -94,8 +94,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
 
         it "should not needless deep nesting for shallow" do
@@ -107,7 +107,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should not needless deep nesting for shallow 4 levels" do
@@ -121,7 +121,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should needless deep nesting with resource" do
@@ -133,8 +133,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
 
         it "should needless deep nesting with block node" do
@@ -147,8 +147,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:3 - needless deep nesting (nested_count > 2)"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
         end
 
         it "should no needless deep nesting" do
@@ -163,9 +163,22 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
       end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: NeedlessDeepNestingReview.new(ignored_files: /config\/routes/))
+        content = <<-EOF
+          map.resources :posts do |post|
+            post.resources :comments do |comment|
+              comment.resources :favorites
+            end
+          end
+        EOF
+        runner.review('config/routes.rb', content)
+        expect(runner.errors.size).to eq(0)
+      end
     end
   end
 end

data/spec/rails_best_practices/reviews/not_rescue_exception_spec.rb

@@ -15,8 +15,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:3 - not rescue Exception"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - not rescue Exception")
         end
 
         it "should not rescue exception in method rescue without named var" do
@@ -28,8 +28,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:3 - not rescue Exception"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - not rescue Exception")
         end
 
         it "should not rescue exception in block rescue with named var" do
@@ -43,8 +43,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:4 - not rescue Exception"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - not rescue Exception")
         end
 
         it "should not rescue exception in block rescue without named var" do
@@ -58,8 +58,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "app/helpers/posts_helper.rb:4 - not rescue Exception"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - not rescue Exception")
         end
 
         it "should allow rescue implicit StandardError in block rescue without named var" do
@@ -73,7 +73,7 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
         end
 
         it "should allow rescue explicit StandardError in block rescue without named var" do
@@ -87,7 +87,20 @@ module RailsBestPractices
           end
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
+        end
+
+        it "should not check ignored files" do
+          runner = Core::Runner.new(reviews: NotRescueExceptionReview.new(ignored_files: /posts_helper/))
+          content =<<-EOF
+          def my_method
+            do_something
+          rescue Exception => e
+            logger.error e
+          end
+          EOF
+          runner.review('app/helpers/posts_helper.rb', content)
+          expect(runner.errors.size).to eq(0)
         end
       end
     end

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -16,9 +16,9 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(2).errors
-          runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
-          runner.errors[1].to_s.should == "config/routes.rb:5 - not use default route"
+          expect(runner.errors.size).to eq(2)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:4 - not use default route")
+          expect(runner.errors[1].to_s).to eq("config/routes.rb:5 - not use default route")
         end
 
         it "should no not use default route" do
@@ -28,7 +28,21 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
+        end
+
+        it "should not check ignored files" do
+          runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
+          content = <<-EOF
+          ActionController::Routing::Routes.draw do |map|
+            map.resources :posts, member: { push: :post }
+
+            map.connect ':controller/:action/:id'
+            map.connect ':controller/:action/:id.:format'
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          expect(runner.errors.size).to eq(0)
         end
       end
 
@@ -42,8 +56,8 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(1).errors
-          runner.errors[0].to_s.should == "config/routes.rb:4 - not use default route"
+          expect(runner.errors.size).to eq(1)
+          expect(runner.errors[0].to_s).to eq("config/routes.rb:4 - not use default route")
         end
 
         it "should no not use default route" do
@@ -53,7 +67,20 @@ module RailsBestPractices
           end
           EOF
           runner.review('config/routes.rb', content)
-          runner.should have(0).errors
+          expect(runner.errors.size).to eq(0)
+        end
+
+        it "should not check ignored files" do
+          runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
+          content = <<-EOF
+          RailsBestpracticesCom::Application.routes.draw do |map|
+            resources :posts
+
+            match ':controller(/:action(/:id(.:format)))'
+          end
+          EOF
+          runner.review('config/routes.rb', content)
+          expect(runner.errors.size).to eq(0)
         end
       end
     end