rails_best_practices 1.14.4 → 1.15.1

data/spec/rails_best_practices/reviews/restrict_auto_generated_routes_review_spec.rb

@@ -28,8 +28,8 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
+            expect(runner.errors.size).to eq(1)
+            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -39,7 +39,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           it "should not restrict auto-generated routes with except" do
@@ -49,7 +49,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           it "should not restrict auto-generated routes with only: :none" do
@@ -59,7 +59,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           it "should not restrict auto-generated routes with except: :all" do
@@ -69,7 +69,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           describe "specify a controller" do
@@ -80,8 +80,8 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])")
             end
           end
 
@@ -110,8 +110,8 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
             end
 
             it "should not restrict auto-generated routes with only" do
@@ -123,7 +123,7 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
 
             it "should not restrict auto-generated routes with except" do
@@ -135,7 +135,7 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
         end
@@ -148,8 +148,8 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
+            expect(runner.errors.size).to eq(1)
+            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -159,7 +159,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           it "should not restrict auto-generated routes with except" do
@@ -169,7 +169,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           describe "specify a controller" do
@@ -180,8 +180,8 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])")
             end
           end
 
@@ -207,8 +207,8 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])")
             end
           end
 
@@ -237,8 +237,8 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(1).errors
-              runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])"
+              expect(runner.errors.size).to eq(1)
+              expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
             end
 
             it "should not restrict auto-generated routes with only" do
@@ -250,7 +250,7 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
 
             it "should not restrict auto-generated routes with except" do
@@ -262,7 +262,7 @@ module RailsBestPractices
               end
               EOF
               runner.review('config/routes.rb', content)
-              runner.should have(0).errors
+              expect(runner.errors.size).to eq(0)
             end
           end
         end
@@ -290,8 +290,8 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])"
+            expect(runner.errors.size).to eq(1)
+            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])")
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -301,7 +301,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           it "should not restrict auto-generated routes with except" do
@@ -311,7 +311,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
         end
 
@@ -323,8 +323,8 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(1).errors
-            runner.errors[0].to_s.should == "config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])"
+            expect(runner.errors.size).to eq(1)
+            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])")
           end
 
           it "should not restrict auto-generated routes with only" do
@@ -334,7 +334,7 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
           end
 
           it "should not restrict auto-generated routes with except" do
@@ -344,7 +344,20 @@ module RailsBestPractices
             end
             EOF
             runner.review('config/routes.rb', content)
-            runner.should have(0).errors
+            expect(runner.errors.size).to eq(0)
+          end
+
+          it "should not check ignored files" do
+            runner = Core::Runner.new(prepares: Prepares::ControllerPrepare.new,
+                                      reviews: RestrictAutoGeneratedRoutesReview.new(ignored_files: /config\/routes\.rb/))
+
+            content =<<-EOF
+            ActionController::Routing::Routes.draw do |map|
+              map.resource :account
+            end
+            EOF
+            runner.review('config/routes.rb', content)
+            expect(runner.errors.size).to eq(0)
           end
         end
       end

data/spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb

@@ -12,8 +12,8 @@ module RailsBestPractices
         end
         EOF
         runner.review("app/controllers/posts_controller.rb", content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - simplify render in controllers")
       end
 
       it "should simplify render actions's template" do
@@ -23,8 +23,8 @@ module RailsBestPractices
         end
         EOF
         runner.review("app/controllers/posts_controller.rb", content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - simplify render in controllers")
       end
 
       it "should simplify render an arbitrary file" do
@@ -34,8 +34,8 @@ module RailsBestPractices
         end
         EOF
         runner.review("app/controllers/posts_controller.rb", content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - simplify render in controllers"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - simplify render in controllers")
       end
 
       it "should not simplify render action view" do
@@ -43,7 +43,7 @@ module RailsBestPractices
         render :edit
         EOF
         runner.review("app/controllers/posts_controller", content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render actions's template" do
@@ -53,7 +53,7 @@ module RailsBestPractices
         end
         EOF
         runner.review("app/controllers/posts_controller.rb", content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render an arbitrary file" do
@@ -63,7 +63,18 @@ module RailsBestPractices
         end
         EOF
         runner.review("app/controllers/posts_controller.rb", content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: SimplifyRenderInControllersReview.new(ignored_files: /posts_controller/))
+        content =<<-EOF
+        def edit
+          render action: :edit
+        end
+        EOF
+        runner.review("app/controllers/posts_controller.rb", content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/simplify_render_in_views_review_spec.rb

@@ -10,8 +10,8 @@ module RailsBestPractices
         <%= render partial: 'sidebar' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
       end
 
       it "should simplify render partial with object" do
@@ -19,8 +19,8 @@ module RailsBestPractices
         <%= render partial: 'post', object: @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
       end
 
       it "should simplify render partial with collection" do
@@ -28,8 +28,8 @@ module RailsBestPractices
         <%= render partial: 'posts', collection: @posts %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
       end
 
       it "should simplify render partial with local variables" do
@@ -37,8 +37,8 @@ module RailsBestPractices
         <%= render partial: 'comment', locals: { parent: post } %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/views/posts/index.html.erb:1 - simplify render in views"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
       end
 
       it "should not simplify render simple partial" do
@@ -47,7 +47,7 @@ module RailsBestPractices
         <%= render 'shared/sidebar' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render partial with object" do
@@ -55,7 +55,7 @@ module RailsBestPractices
         <%= render @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render partial with collection" do
@@ -63,7 +63,7 @@ module RailsBestPractices
         <%= render @posts %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render partial with local variables" do
@@ -71,7 +71,7 @@ module RailsBestPractices
         <%= render 'comment', parent: post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render partial with complex partial" do
@@ -79,7 +79,7 @@ module RailsBestPractices
         <%= render partial: 'shared/post', object: @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not simplify render partial with layout option" do
@@ -87,7 +87,16 @@ module RailsBestPractices
         <%= render partial: 'post', layout: 'post' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: SimplifyRenderInViewsReview.new(ignored_files: /views\/posts\/index/))
+        content =<<-EOF
+        <%= render partial: 'sidebar' %>
+        EOF
+        runner.review('app/views/posts/index.html.erb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end

data/spec/rails_best_practices/reviews/use_before_filter_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseBeforeFilterReview do
-      let(:runner) { Core::Runner.new(reviews: UseBeforeFilterReview.new('customize_count' => 2)) }
+      let(:runner) { Core::Runner.new(reviews: UseBeforeFilterReview.new(customize_count: 2)) }
 
       it "should use before_filter" do
         content = <<-EOF
@@ -28,8 +28,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2,6,10,15 - use before_filter for show,edit,update,destroy"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2,6,10,15 - use before_filter for show,edit,update,destroy")
       end
 
       it "should not use before_filter when equal to customize count" do
@@ -45,7 +45,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use before_filter" do
@@ -68,7 +68,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use before_filter by nil" do
@@ -81,7 +81,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should not use before_filter for protected/private methods" do
@@ -100,7 +100,34 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: UseBeforeFilterReview.new(customize_count: 2, ignored_files: /posts_controller/))
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def show
+            @post = current_user.posts.find(params[:id])
+          end
+
+          def edit
+            @post = current_user.posts.find(params[:id])
+          end
+
+          def update
+            @post = current_user.posts.find(params[:id])
+            @post.update_attributes(params[:post])
+          end
+
+          def destroy
+            @post = current_user.posts.find(params[:id])
+            @post.destroy
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        expect(runner.errors.size).to eq(1)
       end
     end
   end

data/spec/rails_best_practices/reviews/use_model_association_review_spec.rb

@@ -16,8 +16,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - use model association (for @post)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - use model association (for @post)")
       end
 
       it "should not use model association without association assign" do
@@ -30,7 +30,7 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
       end
 
       it "should use model association for local variable" do
@@ -44,8 +44,8 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(1).errors
-        runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:2 - use model association (for post)"
+        expect(runner.errors.size).to eq(1)
+        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - use model association (for post)")
       end
 
       it "should not use model association" do
@@ -58,7 +58,22 @@ module RailsBestPractices
         end
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
-        runner.should have(0).errors
+        expect(runner.errors.size).to eq(0)
+      end
+
+      it "should not check ignored files" do
+        runner = Core::Runner.new(reviews: UseModelAssociationReview.new(ignored_files: /posts_controller/))
+        content = <<-EOF
+        class PostsController < ApplicationController
+          def create
+            @post = Post.new(params[:post])
+            @post.user_id = current_user.id
+            @post.save
+          end
+        end
+        EOF
+        runner.review('app/controllers/posts_controller.rb', content)
+        expect(runner.errors.size).to eq(0)
       end
     end
   end