rails_best_practices 1.20.0 → 1.20.1

data/spec/rails_best_practices/core/check_spec.rb

@@ -4,13 +4,13 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Check do
-    let(:check) { Check.new }
+    let(:check) { described_class.new }
 
     context 'debug' do
-      it 'should be debug mode' do
-        Check.debug
-        expect(Check).to be_debug
-        Check.class_eval { @debug = false }
+      it 'is debug mode' do
+        described_class.debug
+        expect(described_class).to be_debug
+        described_class.class_eval { @debug = false }
       end
     end
   end

data/spec/rails_best_practices/core/checks_loader_spec.rb

@@ -4,17 +4,17 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe ChecksLoader do
-    let(:checks_loader) { ChecksLoader.new(RailsBestPractices::Analyzer::DEFAULT_CONFIG) }
+    let(:checks_loader) { described_class.new(RailsBestPractices::Analyzer::DEFAULT_CONFIG) }
 
     describe 'load_lexicals' do
-      it 'should load lexical checks from the default configuration' do
+      it 'loads lexical checks from the default configuration' do
         lexicals = checks_loader.load_lexicals
         expect(lexicals.map(&:class)).to include(RailsBestPractices::Lexicals::RemoveTrailingWhitespaceCheck)
       end
     end
 
     describe 'load_reviews' do
-      it 'should load the reviews from the default the configuration' do
+      it 'loads the reviews from the default the configuration' do
         reviews = checks_loader.load_reviews
         expect(reviews.map(&:class)).to include(RailsBestPractices::Reviews::AlwaysAddDbIndexReview)
       end

data/spec/rails_best_practices/core/configs_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Configs do
-    it { should be_a_kind_of Hash }
+    it { is_expected.to be_a_kind_of Hash }
   end
 end

data/spec/rails_best_practices/core/controllers_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Controllers do
-    it { should be_a_kind_of Klasses }
+    it { is_expected.to be_a_kind_of Klasses }
   end
 end

data/spec/rails_best_practices/core/error_spec.rb

@@ -4,32 +4,32 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Error do
-    it 'should return error with filename, line number and message' do
-      expect(Error.new(
-        filename: 'app/models/user.rb',
-        line_number: '100',
-        message: 'not good',
-        type: 'BogusReview'
-      ).to_s).to eq('app/models/user.rb:100 - not good')
+    it 'returns error with filename, line number and message' do
+      expect(
+        described_class.new(
+          filename: 'app/models/user.rb', line_number: '100', message: 'not good', type: 'BogusReview'
+        ).to_s
+      ).to eq('app/models/user.rb:100 - not good')
     end
 
-    it 'should return short filename' do
+    it 'returns short filename' do
       Runner.base_path = '../rails-bestpractices.com'
-      expect(Error.new(
-        filename: '../rails-bestpractices.com/app/models/user.rb',
-        line_number: '100',
-        message: 'not good',
-        type: 'BogusReview'
-      ).short_filename).to eq('app/models/user.rb')
+      expect(
+        described_class.new(
+          filename: '../rails-bestpractices.com/app/models/user.rb',
+          line_number: '100',
+          message: 'not good',
+          type: 'BogusReview'
+        ).short_filename
+      ).to eq('app/models/user.rb')
     end
 
-    it 'should return first line number' do
-      expect(Error.new(
-        filename: 'app/models/user.rb',
-        line_number: '50,70,100',
-        message: 'not good',
-        type: 'BogusReview'
-      ).first_line_number).to eq('50')
+    it 'returns first line number' do
+      expect(
+        described_class.new(
+          filename: 'app/models/user.rb', line_number: '50,70,100', message: 'not good', type: 'BogusReview'
+        ).first_line_number
+      ).to eq('50')
     end
   end
 end

data/spec/rails_best_practices/core/except_methods_spec.rb

@@ -10,7 +10,7 @@ module RailsBestPractices::Core
       let(:except_method) { '*#*' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -18,7 +18,7 @@ module RailsBestPractices::Core
       let(:except_method) { '*#approve' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -26,7 +26,7 @@ module RailsBestPractices::Core
       let(:except_method) { '*#disapprove' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql false
+        expect(described_class.matches(method, except_method)).to eql false
       end
     end
 
@@ -34,7 +34,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'BlogPost#*' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -42,7 +42,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'User#*' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql false
+        expect(described_class.matches(method, except_method)).to eql false
       end
     end
 
@@ -50,7 +50,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'BlogPost#approve' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql true
+        expect(described_class.matches(method, except_method)).to eql true
       end
     end
 
@@ -58,7 +58,7 @@ module RailsBestPractices::Core
       let(:except_method) { 'User#disapprove' }
 
       it 'matches' do
-        expect(Check::Exceptable.matches(method, except_method)).to eql false
+        expect(described_class.matches(method, except_method)).to eql false
       end
     end
   end

data/spec/rails_best_practices/core/gems_spec.rb

@@ -4,15 +4,15 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Gems do
-    it { should be_a_kind_of Array }
+    it { is_expected.to be_a_kind_of Array }
 
-    let(:gems) { Gems.new }
+    let(:gems) { described_class.new }
     before do
       gems << Gem.new('rails', '4.0.0')
       gems << Gem.new('mysql2', '0.2.0')
     end
 
-    context '#has_gem?' do
+    describe '#has_gem?' do
       it 'has rails gem' do
         expect(gems).to be_has_gem 'rails'
       end
@@ -22,7 +22,7 @@ module RailsBestPractices::Core
       end
     end
 
-    context '#gem_version' do
+    describe '#gem_version' do
       it 'gets rails version' do
         expect(gems.gem_version('rails')).to eq '4.0.0'
       end

data/spec/rails_best_practices/core/helpers_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Helpers do
-    it { should be_a_kind_of Modules }
+    it { is_expected.to be_a_kind_of Modules }
   end
 end

data/spec/rails_best_practices/core/klasses_spec.rb

@@ -4,10 +4,10 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Klasses do
-    it { should be_a_kind_of Array }
+    it { is_expected.to be_a_kind_of Array }
 
     context 'Klass' do
-      context '#class_name' do
+      describe '#class_name' do
         it 'gets class name without module' do
           klass = Klass.new('BlogPost', 'Post', [])
           expect(klass.class_name).to eq('BlogPost')
@@ -19,7 +19,7 @@ module RailsBestPractices::Core
         end
       end
 
-      context '#extend_class_name' do
+      describe '#extend_class_name' do
         it 'gets extend class name without module' do
           klass = Klass.new('BlogPost', 'Post', [])
           expect(klass.extend_class_name).to eq('Post')

data/spec/rails_best_practices/core/mailers_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Mailers do
-    it { should be_a_kind_of Klasses }
+    it { is_expected.to be_a_kind_of Klasses }
   end
 end

data/spec/rails_best_practices/core/methods_spec.rb

@@ -4,9 +4,9 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Methods do
-    let(:methods) { Methods.new }
+    let(:methods) { described_class.new }
 
-    before :each do
+    before do
       methods.add_method('Post', 'create')
       methods.add_method('Post', 'destroy')
       methods.add_method('Post', 'save_or_update', {}, 'protected')
@@ -14,7 +14,7 @@ module RailsBestPractices::Core
       methods.add_method('Comment', 'create')
     end
 
-    it 'should get_methods' do
+    it 'get_methodses' do
       expect(methods.get_methods('Post').map(&:method_name)).to eq(%w[create destroy save_or_update find_by_sql])
       expect(methods.get_methods('Post', 'public').map(&:method_name)).to eq(%w[create destroy])
       expect(methods.get_methods('Post', 'protected').map(&:method_name)).to eq(['save_or_update'])
@@ -22,7 +22,7 @@ module RailsBestPractices::Core
       expect(methods.get_methods('Comment').map(&:method_name)).to eq(['create'])
     end
 
-    it 'should has_method?' do
+    it 'has_method?s' do
       expect(methods).to be_has_method('Post', 'create', 'public')
       expect(methods).to be_has_method('Post', 'destroy', 'public')
       expect(methods).not_to be_has_method('Post', 'save_or_update', 'public')
@@ -32,12 +32,12 @@ module RailsBestPractices::Core
       expect(methods).not_to be_has_method('Comment', 'destroy')
     end
 
-    it 'should get_method' do
+    it 'get_methods' do
       expect(methods.get_method('Post', 'create', 'public')).not_to be_nil
       expect(methods.get_method('Post', 'create', 'protected')).to be_nil
     end
 
-    it 'should get_all_unused_methods' do
+    it 'get_all_unused_methodses' do
       methods.get_method('Comment', 'create').mark_used
       expect(methods.get_all_unused_methods('public').map(&:method_name)).to eq(%w[create destroy])
       expect(methods.get_all_unused_methods('protected').map(&:method_name)).to eq(['save_or_update'])

data/spec/rails_best_practices/core/model_associations_spec.rb

@@ -4,20 +4,24 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe ModelAssociations do
-    let(:model_associations) { ModelAssociations.new }
+    let(:model_associations) { described_class.new }
 
-    before :each do
+    before do
       model_associations.add_association('Project', 'project_manager', 'belongs_to')
       model_associations.add_association('Project', 'people', 'has_many', 'Person')
     end
 
-    it 'should get model associations' do
-      expect(model_associations.get_association('Project', 'project_manager')).to eq('meta' => 'belongs_to', 'class_name' => 'ProjectManager')
-      expect(model_associations.get_association('Project', 'people')).to eq('meta' => 'has_many', 'class_name' => 'Person')
+    it 'gets model associations' do
+      expect(model_associations.get_association('Project', 'project_manager')).to eq(
+        'meta' => 'belongs_to', 'class_name' => 'ProjectManager'
+      )
+      expect(model_associations.get_association('Project', 'people')).to eq(
+        'meta' => 'has_many', 'class_name' => 'Person'
+      )
       expect(model_associations.get_association('Project', 'unknown')).to be_nil
     end
 
-    it 'should check is model associatiosn' do
+    it 'checks is model associatiosn' do
       expect(model_associations.is_association?('Project', 'project_manager')).to eq true
       expect(model_associations.is_association?('Project', 'people')).to eq true
       expect(model_associations.is_association?('Project', 'unknown')).to eq false

data/spec/rails_best_practices/core/model_attributes_spec.rb

@@ -4,20 +4,20 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe ModelAttributes do
-    let(:model_attributes) { ModelAttributes.new }
+    let(:model_attributes) { described_class.new }
 
-    before :each do
+    before do
       model_attributes.add_attribute('Post', 'title', :string)
       model_attributes.add_attribute('Post', 'user_id', :integer)
     end
 
-    it 'should get model attributes' do
+    it 'gets model attributes' do
       expect(model_attributes.get_attribute_type('Post', 'title')).to eq(:string)
       expect(model_attributes.get_attribute_type('Post', 'user_id')).to eq(:integer)
       expect(model_attributes.get_attribute_type('Post', 'unknonw')).to be_nil
     end
 
-    it 'should check is model attributes' do
+    it 'checks is model attributes' do
       expect(model_attributes.is_attribute?('Post', 'title')).to be true
       expect(model_attributes.is_attribute?('Post', 'user_id')).to be true
       expect(model_attributes.is_attribute?('Post', 'unknonw')).to be false

data/spec/rails_best_practices/core/models_spec.rb

@@ -4,6 +4,6 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Models do
-    it { should be_a_kind_of Klasses }
+    it { is_expected.to be_a_kind_of Klasses }
   end
 end

data/spec/rails_best_practices/core/modules_spec.rb

@@ -4,25 +4,25 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Modules do
-    it { should be_a_kind_of Array }
+    it { is_expected.to be_a_kind_of Array }
 
     context 'Modules' do
       before do
         @mod = Mod.new('PostsHelper', [])
       end
-      subject { Modules.new.tap { |modules| modules << @mod } }
-      it 'should add descendant to the corresponding module' do
+      subject { described_class.new.tap { |modules| modules << @mod } }
+      it 'adds descendant to the corresponding module' do
         expect(@mod).to receive(:add_descendant).with('PostsController')
         subject.add_module_descendant('PostsHelper', 'PostsController')
       end
     end
 
     context 'Mod' do
-      subject {
+      subject do
         Mod.new('UsersHelper', ['Admin']).tap do |mod|
           mod.add_descendant('Admin::UsersController')
         end
-      }
+      end
       it { expect(subject.to_s).to eq('Admin::UsersHelper') }
       it { expect(subject.descendants).to eq(['Admin::UsersController']) }
     end

data/spec/rails_best_practices/core/routes_spec.rb

@@ -4,25 +4,25 @@ require 'spec_helper'
 
 module RailsBestPractices::Core
   describe Routes do
-    let(:routes) { Routes.new }
+    let(:routes) { described_class.new }
 
-    it 'should add route' do
+    it 'adds route' do
       routes.add_route(%w[admin test], 'posts', 'new')
       expect(routes.map(&:to_s)).to eq(['Admin::Test::PostsController#new'])
     end
 
     context 'route' do
-      it 'should add namesapces, controller name and action name' do
+      it 'adds namesapces, controller name and action name' do
         route = Route.new(%w[admin test], 'posts', 'new')
         expect(route.to_s).to eq('Admin::Test::PostsController#new')
       end
 
-      it 'should add controller name with namespace' do
+      it 'adds controller name with namespace' do
         route = Route.new(['admin'], 'test/posts', 'new')
         expect(route.to_s).to eq('Admin::Test::PostsController#new')
       end
 
-      it 'should add routes without controller' do
+      it 'adds routes without controller' do
         route = Route.new(['posts'], nil, 'new')
         expect(route.to_s).to eq('PostsController#new')
       end

data/spec/rails_best_practices/core/runner_spec.rb

@@ -6,20 +6,22 @@ module RailsBestPractices::Core
   describe Runner do
     describe 'load_plugin_reviews' do
       shared_examples_for 'load_plugin_reviews' do
-        it 'should load plugins in lib/rails_best_practices/plugins/reviews' do
-          runner = Runner.new
-          expect(runner.instance_variable_get('@reviews').map(&:class)).to include(RailsBestPractices::Plugins::Reviews::NotUseRailsRootReview)
+        it 'loads plugins in lib/rails_best_practices/plugins/reviews' do
+          runner = described_class.new
+          expect(runner.instance_variable_get('@reviews').map(&:class)).to include(
+            RailsBestPractices::Plugins::Reviews::NotUseRailsRootReview
+          )
         end
       end
 
       context 'given a path that ends with a slash' do
-        before { Runner.base_path = 'spec/fixtures/' }
-        it_should_behave_like 'load_plugin_reviews'
+        before { described_class.base_path = 'spec/fixtures/' }
+        it_behaves_like 'load_plugin_reviews'
       end
 
       context 'given a path that does not end with a slash' do
-        before { Runner.base_path = 'spec/fixtures' }
-        it_should_behave_like 'load_plugin_reviews'
+        before { described_class.base_path = 'spec/fixtures' }
+        it_behaves_like 'load_plugin_reviews'
       end
     end
   end