rails_best_practices 1.20.0 → 1.20.1

data/spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveFinderToNamedScopeReview do
-      let(:runner) { Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move finder to named_scope' do
+      it 'moves finder to named_scope' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -27,7 +27,7 @@ module RailsBestPractices
         expect(runner.errors[1].to_s).to eq('app/controllers/posts_controller.rb:7 - move finder to named_scope')
       end
 
-      it 'should not move simple finder' do
+      it 'does not move simple finder' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -44,7 +44,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move namd_scope' do
+      it 'does not move namd_scope' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -57,7 +57,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not review model file' do
+      it 'does not review model file' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           def published
@@ -75,8 +75,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new(ignored_files: /app\/controllers\/posts/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/controllers/posts}))
         content = <<-EOF
         class PostsController < ActionController::Base
           def index

data/spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveModelLogicIntoModelReview do
-      let(:runner) { Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move model logic into model' do
+      it 'moves model logic into model' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -26,10 +26,12 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)'
+        )
       end
 
-      it 'should not move model logic into model with simple model calling' do
+      it 'does not move model logic into model with simple model calling' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -45,7 +47,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move model logic into model with self calling' do
+      it 'does not move model logic into model with self calling' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -61,8 +63,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new(ignored_files: /app\/controllers\/posts/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/controllers/posts}))
         content = <<-EOF
         class PostsController < ApplicationController
           def publish

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NeedlessDeepNestingReview do
-      let(:runner) { Core::Runner.new(reviews: NeedlessDeepNestingReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should needless deep nesting' do
+      it 'needlesses deep nesting' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -20,7 +20,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it 'should not needless deep nesting for shallow' do
+      it 'does not needless deep nesting for shallow' do
         content = <<-EOF
         resources :posts, shallow: true do
           resources :comments do
@@ -32,7 +32,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not needless deep nesting for shallow 4 levels' do
+      it 'does not needless deep nesting for shallow 4 levels' do
         content = <<-EOF
         resources :applications, shallow: true, only: [:index, :show, :create] do
           resources :events, only: [:index, :show, :create, :subscribe, :push] do
@@ -46,7 +46,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should needless deep nesting with resource' do
+      it 'needlesses deep nesting with resource' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -59,7 +59,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it 'should needless deep nesting with block node' do
+      it 'needlesses deep nesting with block node' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -73,7 +73,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it 'should no needless deep nesting' do
+      it 'noes needless deep nesting' do
         content = <<-EOF
         resources :posts do
           resources :comments
@@ -88,8 +88,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: NeedlessDeepNestingReview.new(ignored_files: /config\/routes/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{config/routes}))
         content = <<-EOF
           map.resources :posts do |post|
             post.resources :comments do |comment|

data/spec/rails_best_practices/reviews/not_rescue_exception_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotRescueExceptionReview do
-      let(:runner) { Core::Runner.new(reviews: NotRescueExceptionReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       describe 'not_rescue_exception' do
-        it 'should not rescue exception in method rescue with named var' do
+        it 'does not rescue exception in method rescue with named var' do
           content = <<-EOF
           def my_method
             do_something
@@ -21,7 +21,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
-        it 'should not rescue exception in method rescue without named var' do
+        it 'does not rescue exception in method rescue without named var' do
           content = <<-EOF
           def my_method
             do_something
@@ -34,7 +34,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
-        it 'should not rescue exception in block rescue with named var' do
+        it 'does not rescue exception in block rescue with named var' do
           content = <<-EOF
           def my_method
             begin
@@ -49,7 +49,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
-        it 'should not rescue exception in block rescue without named var' do
+        it 'does not rescue exception in block rescue without named var' do
           content = <<-EOF
           def my_method
             begin
@@ -64,7 +64,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
-        it 'should allow rescue implicit StandardError in block rescue without named var' do
+        it 'allows rescue implicit StandardError in block rescue without named var' do
           content = <<-EOF
           def my_method
             begin
@@ -78,7 +78,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should allow rescue explicit StandardError in block rescue without named var' do
+        it 'allows rescue explicit StandardError in block rescue without named var' do
           content = <<-EOF
           def my_method
             begin
@@ -92,8 +92,8 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not check ignored files' do
-          runner = Core::Runner.new(reviews: NotRescueExceptionReview.new(ignored_files: /posts_helper/))
+        it 'does not check ignored files' do
+          runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_helper/))
           content = <<-EOF
           def my_method
             do_something

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotUseDefaultRouteReview do
-      let(:runner) { Core::Runner.new(reviews: NotUseDefaultRouteReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should not use default route' do
+      it 'does not use default route' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts
@@ -20,7 +20,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:4 - not use default route')
       end
 
-      it 'should no not use default route' do
+      it 'noes not use default route' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts
@@ -30,8 +30,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{config/routes\.rb}))
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts

data/spec/rails_best_practices/reviews/not_use_time_ago_in_words_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe NotUseTimeAgoInWordsReview do
-      let(:runner) { Core::Runner.new(reviews: NotUseTimeAgoInWordsReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       describe 'time_ago_in_words' do
-        it 'should not use in views' do
+        it 'does not use in views' do
           content = <<-EOF
           <%= time_ago_in_words(post.created_at) %>
           EOF
@@ -17,7 +17,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - not use time_ago_in_words')
         end
 
-        it 'should not use in helpers' do
+        it 'does not use in helpers' do
           content = <<-EOF
           def timeago
             content_tag(:p, time_ago_in_words(post.created_at))
@@ -30,7 +30,7 @@ module RailsBestPractices
       end
 
       describe 'distance_of_time_in_words_to_now' do
-        it 'should not use in views' do
+        it 'does not use in views' do
           content = <<-EOF
           <%= distance_of_time_in_words_to_now(post.created_at) %>
           EOF
@@ -39,7 +39,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - not use time_ago_in_words')
         end
 
-        it 'should not use in helpers' do
+        it 'does not use in helpers' do
           content = <<-EOF
           def timeago
             content_tag(:p, distance_of_time_in_words_to_now(post.created_at))
@@ -51,8 +51,8 @@ module RailsBestPractices
         end
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: NotUseTimeAgoInWordsReview.new(ignored_files: /posts_helper/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_helper/))
         content = <<-EOF
           def timeago
             content_tag(:p, time_ago_in_words(post.created_at))

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe OveruseRouteCustomizationsReview do
-      let(:runner) { Core::Runner.new(reviews: OveruseRouteCustomizationsReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should overuse route customizations' do
+      it 'overuses route customizations' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts do
@@ -28,7 +28,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - overuse route customizations (customize_count > 3)')
       end
 
-      it 'should overuse route customizations another way' do
+      it 'overuses route customizations another way' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts do
@@ -44,7 +44,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - overuse route customizations (customize_count > 3)')
       end
 
-      it 'should not overuse route customizations without customization' do
+      it 'does not overuse route customizations without customization' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts
@@ -54,7 +54,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not overuse route customizations when customize route is only one' do
+      it 'does not overuse route customizations when customize route is only one' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts do
@@ -68,8 +68,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: OveruseRouteCustomizationsReview.new(ignored_files: /config\/routes\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{config/routes\.rb}))
         content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resources :posts, member: { comments: :get,

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -5,12 +5,14 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe ProtectMassAssignmentReview do
-      let(:runner) {
-        Core::Runner.new(prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
-                         reviews: ProtectMassAssignmentReview.new)
-      }
+      let(:runner) do
+        Core::Runner.new(
+          prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
+          reviews: described_class.new
+        )
+      end
 
-      it 'should protect mass assignment' do
+      it 'protects mass assignment' do
         content = <<-EOF
         class User < ActiveRecord::Base
         end
@@ -20,7 +22,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:1 - protect mass assignment')
       end
 
-      it 'should not protect mass assignment if attr_accessible is used with arguments and user set config.active_record.whitelist_attributes' do
+      it 'does not protect mass assignment if attr_accessible is used with arguments and user set config.active_record.whitelist_attributes' do
         content = <<-EOF
         module RailsBestPracticesCom
           class Application < Rails::Application
@@ -38,7 +40,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not protect mass assignment if attr_accessible is used without arguments and user set config.active_record.whitelist_attributes' do
+      it 'does not protect mass assignment if attr_accessible is used without arguments and user set config.active_record.whitelist_attributes' do
         content = <<-EOF
         module RailsBestPracticesCom
           class Application < Rails::Application
@@ -56,7 +58,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not protect mass assignment with attr_protected if user set config.active_record.whitelist_attributes' do
+      it 'does not protect mass assignment with attr_protected if user set config.active_record.whitelist_attributes' do
         content = <<-EOF
         module RailsBestPracticesCom
           class Application < Rails::Application
@@ -74,7 +76,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not protect mass assignment if using devise' do
+      it 'does not protect mass assignment if using devise' do
         content = <<-EOF
         class User < ActiveRecord::Base
           devise :database_authenticatable, :registerable, :confirmable, :recoverable, stretches: 20
@@ -84,7 +86,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not protect mass assignment if using authlogic with configuration' do
+      it 'does not protect mass assignment if using authlogic with configuration' do
         content = <<-EOF
         class User < ActiveRecord::Base
           acts_as_authentic do |c|
@@ -96,7 +98,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not protect mass assignment if using authlogic without configuration' do
+      it 'does not protect mass assignment if using authlogic without configuration' do
         content = <<-EOF
         class User < ActiveRecord::Base
           acts_as_authentic
@@ -106,7 +108,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not protect mass assignment if checking non ActiveRecord::Base inherited model' do
+      it 'does not protect mass assignment if checking non ActiveRecord::Base inherited model' do
         content = <<-EOF
         class User < Person
         end
@@ -116,7 +118,7 @@ module RailsBestPractices
       end
 
       context 'strong_parameters' do
-        it 'should not protect mass assignment for strong_parameters' do
+        it 'does not protect mass assignment for strong_parameters' do
           content = <<-EOF
           class User < ActiveRecord::Base
             include ActiveModel::ForbiddenAttributesProtection
@@ -126,7 +128,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not protect mass assignment for strong_parameters' do
+        it 'does not protect mass assignment for strong_parameters' do
           content = <<-EOF
           class AR
             ActiveRecord::Base.send(:include, ActiveModel::ForbiddenAttributesProtection)
@@ -143,7 +145,7 @@ module RailsBestPractices
       end
 
       context 'activerecord 4' do
-        it 'should not protect mass assignment for activerecord 4' do
+        it 'does not protect mass assignment for activerecord 4' do
           content = <<-EOF
   GEM
     remote: https://rubygems.org
@@ -159,7 +161,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should protect mass assignment for activerecord 3' do
+        it 'protects mass assignment for activerecord 3' do
           content = <<-EOF
   GEM
     remote: https://rubygems.org
@@ -176,9 +178,12 @@ module RailsBestPractices
         end
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
-                                  reviews: ProtectMassAssignmentReview.new(ignored_files: /app\/models\/user\.rb/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: [Prepares::GemfilePrepare.new, Prepares::ConfigPrepare.new, Prepares::InitializerPrepare.new],
+            reviews: described_class.new(ignored_files: %r{app/models/user\.rb})
+          )
         content = <<-EOF
         class User < ActiveRecord::Base
         end