rails_best_practices 1.20.0 → 1.20.1

data/spec/rails_best_practices/reviews/remove_empty_helpers_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveEmptyHelpersReview do
-      let(:runner) { Core::Runner.new(reviews: RemoveEmptyHelpersReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should remove empty helpers' do
+      it 'removes empty helpers' do
         content = <<-EOF
         module PostsHelper
         end
@@ -17,7 +17,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/helpers/posts_helper.rb:1 - remove empty helpers')
       end
 
-      it 'should not remove empty helpers' do
+      it 'does not remove empty helpers' do
         content = <<-EOF
         module PostsHelper
           def post_link(post)
@@ -29,7 +29,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not remove empty application_helper' do
+      it 'does not remove empty application_helper' do
         content = <<-EOF
         module ApplicationHelper
         end
@@ -38,8 +38,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: RemoveEmptyHelpersReview.new(ignored_files: /posts_helper/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_helper/))
         content = <<-EOF
         module PostsHelper
         end

data/spec/rails_best_practices/reviews/remove_unused_methods_in_controllers_review_spec.rb

@@ -5,15 +5,15 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInControllersReview do
-      let(:runner) {
+      let(:runner) do
         Core::Runner.new(
           prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
-          reviews: RemoveUnusedMethodsInControllersReview.new('except_methods' => ['ExceptableController#*'])
+          reviews: described_class.new('except_methods' => ['ExceptableController#*'])
         )
-      }
+      end
 
       context 'private/protected' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts do
@@ -40,11 +40,15 @@ module RailsBestPractices
           runner.review('app/controllers/posts_controller.rb', content)
           runner.after_review
           expect(runner.errors.size).to eq(2)
-          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:6 - remove unused methods (PostsController#load_post)')
-          expect(runner.errors[1].to_s).to eq('app/controllers/posts_controller.rb:8 - remove unused methods (PostsController#load_user)')
+          expect(runner.errors[0].to_s).to eq(
+            'app/controllers/posts_controller.rb:6 - remove unused methods (PostsController#load_post)'
+          )
+          expect(runner.errors[1].to_s).to eq(
+            'app/controllers/posts_controller.rb:8 - remove unused methods (PostsController#load_user)'
+          )
         end
 
-        it 'should not remove unused methods for before_filter' do
+        it 'does not remove unused methods for before_filter' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -66,7 +70,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for around_filter' do
+        it 'does not remove unused methods for around_filter' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -91,7 +95,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for around_action (new syntax)' do
+        it 'does not remove unused methods for around_action (new syntax)' do
           content = <<-EOF
           class PostsController < ActiveRecord::Base
             around_action :use_time_zone
@@ -109,7 +113,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for layout' do
+        it 'does not remove unused methods for layout' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -131,7 +135,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove inherited_resources methods' do
+        it 'does not remove inherited_resources methods' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -155,7 +159,7 @@ module RailsBestPractices
       end
 
       context 'public' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -172,10 +176,12 @@ module RailsBestPractices
           runner.review('app/controllers/posts_controller.rb', content)
           runner.after_review
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:3 - remove unused methods (PostsController#list)')
+          expect(runner.errors[0].to_s).to eq(
+            'app/controllers/posts_controller.rb:3 - remove unused methods (PostsController#list)'
+          )
         end
 
-        it 'should not remove inline routes' do
+        it 'does not remove inline routes' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: :none do
@@ -196,7 +202,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods if all actions are used in route' do
+        it 'does not remove unused methods if all actions are used in route' do
           content = <<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.connect 'internal/:action/*whatever', controller: "internal"
@@ -216,7 +222,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods if they are except_methods' do
+        it 'does not remove unused methods if they are except_methods' do
           content = <<-EOF
           class ExceptableController < ApplicationController
             def list; end
@@ -230,7 +236,7 @@ module RailsBestPractices
       end
 
       context 'assignment' do
-        it 'should not remove unused methods if call in base class' do
+        it 'does not remove unused methods if call in base class' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :user, only: :show do; end
@@ -259,7 +265,7 @@ module RailsBestPractices
       end
 
       context 'helper_method' do
-        it 'should remove unused methods if helper method is not called' do
+        it 'removes unused methods if helper method is not called' do
           content = <<-EOF
           class PostsController < ApplicationController
             helper_method :helper_post
@@ -271,10 +277,12 @@ module RailsBestPractices
           runner.review('app/controllers/posts_controller.rb', content)
           runner.after_review
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:4 - remove unused methods (PostsController#helper_post)')
+          expect(runner.errors[0].to_s).to eq(
+            'app/controllers/posts_controller.rb:4 - remove unused methods (PostsController#helper_post)'
+          )
         end
 
-        it 'should not remove unused methods if call helper method in views' do
+        it 'does not remove unused methods if call helper method in views' do
           content = <<-EOF
           class PostsController < ApplicationController
             helper_method :helper_post
@@ -292,7 +300,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods if call helper method in helpers' do
+        it 'does not remove unused methods if call helper method in helpers' do
           content = <<-EOF
           class PostsController < ApplicationController
             helper_method :helper_post
@@ -316,7 +324,7 @@ module RailsBestPractices
       end
 
       context 'delegate to: :controller' do
-        it 'should remove unused methods if delegate method is not called' do
+        it 'removes unused methods if delegate method is not called' do
           content = <<-EOF
           class PostsController < ApplicationController
             protected
@@ -333,10 +341,12 @@ module RailsBestPractices
           runner.review('app/helpers/posts_helper.rb', content)
           runner.after_review
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:3 - remove unused methods (PostsController#helper_post)')
+          expect(runner.errors[0].to_s).to eq(
+            'app/controllers/posts_controller.rb:3 - remove unused methods (PostsController#helper_post)'
+          )
         end
 
-        it 'should remove unused methods if delegate method is called' do
+        it 'removes unused methods if delegate method is called' do
           content = <<-EOF
           class PostsController < ApplicationController
             protected
@@ -361,7 +371,7 @@ module RailsBestPractices
       end
 
       context 'cells' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           class PostsCell < Cell::Rails
             def list; end
@@ -374,7 +384,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/cells/posts_cell.rb:2 - remove unused methods (PostsCell#list)')
         end
 
-        it 'should not remove unused methods if render_cell' do
+        it 'does not remove unused methods if render_cell' do
           content = <<-EOF
           class PostsCell < Cell::Rails
             def list; end
@@ -392,7 +402,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods if render with state' do
+        it 'does not remove unused methods if render with state' do
           content = <<-EOF
           class PostsCell < Cell::Rails
             def list
@@ -415,7 +425,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should not remove unused methods' do
+      it 'does not remove unused methods' do
         route_content = <<-EOF
         RailsBestPracticesCom::Application.routes.draw do
           namespace :admin do
@@ -452,9 +462,12 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
-                                  reviews: RemoveUnusedMethodsInControllersReview.new(ignored_files: /posts_controller/, except_methods: []))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: [Prepares::ControllerPrepare.new, Prepares::RoutePrepare.new],
+            reviews: described_class.new(ignored_files: /posts_controller/, except_methods: [])
+          )
         content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts do

data/spec/rails_best_practices/reviews/remove_unused_methods_in_helpers_review_spec.rb

@@ -5,14 +5,14 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInHelpersReview do
-      let(:runner) {
+      let(:runner) do
         Core::Runner.new(
           prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
-          reviews: RemoveUnusedMethodsInHelpersReview.new(except_methods: [])
+          reviews: described_class.new(except_methods: [])
         )
-      }
+      end
 
-      it 'should remove unused methods' do
+      it 'removes unused methods' do
         content = <<-EOF
         module PostsHelper
           def unused; end
@@ -22,10 +22,12 @@ module RailsBestPractices
         runner.review('app/helpers/posts_helper.rb', content)
         runner.after_review
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/helpers/posts_helper.rb:2 - remove unused methods (PostsHelper#unused)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/helpers/posts_helper.rb:2 - remove unused methods (PostsHelper#unused)'
+        )
       end
 
-      it 'should not remove unused methods if called on views' do
+      it 'does not remove unused methods if called on views' do
         content = <<-EOF
         module PostsHelper
           def used?(post); end
@@ -42,7 +44,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not remove unused methods if called on helpers' do
+      it 'does not remove unused methods if called on helpers' do
         content = <<-EOF
         module PostsHelper
           def used?(post)
@@ -63,7 +65,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not remove unused methods if called on controllers' do
+      it 'does not remove unused methods if called on controllers' do
         helper_content = <<-EOF
         module PostsHelper
           def used?(post); end
@@ -88,7 +90,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not remove unused methods if called in descendant controllers' do
+      it 'does not remove unused methods if called in descendant controllers' do
         application_helper_content = <<-EOF
         module ApplicationHelper
           def admin?; end
@@ -118,9 +120,12 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
-                                  reviews: RemoveUnusedMethodsInHelpersReview.new(ignored_files: /posts_helper/, except_methods: []))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: [Prepares::ControllerPrepare.new, Prepares::HelperPrepare.new],
+            reviews: described_class.new(ignored_files: /posts_helper/, except_methods: [])
+          )
 
         content = <<-EOF
         module PostsHelper

data/spec/rails_best_practices/reviews/remove_unused_methods_in_models_review_spec.rb

@@ -5,15 +5,14 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe RemoveUnusedMethodsInModelsReview do
-      let(:runner) {
+      let(:runner) do
         Core::Runner.new(
-          prepares: Prepares::ModelPrepare.new,
-          reviews: RemoveUnusedMethodsInModelsReview.new('except_methods' => ['*#set_cache'])
+          prepares: Prepares::ModelPrepare.new, reviews: described_class.new('except_methods' => ['*#set_cache'])
         )
-      }
+      end
 
       context 'private' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find; end
@@ -36,7 +35,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/models/post.rb:4 - remove unused methods (Post#find_by_sql)')
         end
 
-        it 'should not remove unused methods with except_methods' do
+        it 'does not remove unused methods with except_methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def set_cache; end
@@ -48,7 +47,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods with var_ref' do
+        it 'does not remove unused methods with var_ref' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find
@@ -72,7 +71,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods with callback' do
+        it 'does not remove unused methods with callback' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             after_save :expire_cache
@@ -86,7 +85,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with command' do
+        it 'does not remove unused method with command' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch
@@ -110,7 +109,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with call' do
+        it 'does not remove unused method with call' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def conditions
@@ -134,7 +133,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with message' do
+        it 'does not remove unused method with message' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def save
@@ -160,7 +159,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with validation condition' do
+        it 'does not remove unused method with validation condition' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             validates_uniqueness_of :login, if: :email_blank?
@@ -174,7 +173,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with aasm' do
+        it 'does not remove unused method with aasm' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             aasm_state :accepted, enter: [:update_datetime]
@@ -188,7 +187,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with initialize' do
+        it 'does not remove unused method with initialize' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             private
@@ -203,7 +202,7 @@ module RailsBestPractices
       end
 
       context 'public' do
-        it 'should remove unused methods' do
+        it 'removes unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch; end
@@ -215,7 +214,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/models/post.rb:2 - remove unused methods (Post#fetch)')
         end
 
-        it 'should not remove unused methods' do
+        it 'does not remove unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def fetch; end
@@ -234,7 +233,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for attribute assignment' do
+        it 'does not remove unused methods for attribute assignment' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def user=(user); end
@@ -246,7 +245,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for try' do
+        it 'does not remove unused methods for try' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find(user_id); end
@@ -266,7 +265,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for send' do
+        it 'does not remove unused methods for send' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find(user_id); end
@@ -286,7 +285,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should remove unused methods for send string_embexpre' do
+        it 'removes unused methods for send string_embexpre' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def find_first; end
@@ -307,7 +306,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(1)
         end
 
-        it 'should remove unused methods for send variable' do
+        it 'removes unused methods for send variable' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def first; end
@@ -330,7 +329,7 @@ module RailsBestPractices
       end
 
       context 'protected' do
-        it 'should not remove unused methods' do
+        it 'does not remove unused methods' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             protected
@@ -352,7 +351,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/models/post.rb:3 - remove unused methods (Post#test)')
         end
 
-        it 'should not remove unused methods' do
+        it 'does not remove unused methods' do
           post_content = <<-EOF
           class Post < ActiveRecord::Base
             protected
@@ -384,7 +383,7 @@ module RailsBestPractices
       end
 
       context 'named_scope' do
-        it 'should not remove unused named_scope' do
+        it 'does not remove unused named_scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
@@ -404,7 +403,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should remove unused named_scope' do
+        it 'removes unused named_scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             named_scope :active, conditions: {active: true}
@@ -419,7 +418,7 @@ module RailsBestPractices
       end
 
       context 'scope' do
-        it 'should not remove unused scope' do
+        it 'does not remove unused scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
@@ -439,7 +438,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should remove unused named_scope' do
+        it 'removes unused named_scope' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             scope :active, where(active: true)
@@ -454,7 +453,7 @@ module RailsBestPractices
       end
 
       context 'alias' do
-        it 'should not remove unused method with alias' do
+        it 'does not remove unused method with alias' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -475,7 +474,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with symbol alias' do
+        it 'does not remove unused method with symbol alias' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -496,7 +495,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with alias_method' do
+        it 'does not remove unused method with alias_method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def old; end
@@ -517,7 +516,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method with alias_method_chain' do
+        it 'does not remove unused method with alias_method_chain' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def method_with_feature; end
@@ -540,7 +539,7 @@ module RailsBestPractices
       end
 
       context 'methods hash' do
-        it 'should not remove unused method with methods hash' do
+        it 'does not remove unused method with methods hash' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def to_xml(options = {})
@@ -558,7 +557,7 @@ module RailsBestPractices
       end
 
       context 'callbacks' do
-        it 'should not remove unused method' do
+        it 'does not remove unused method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             before_save :init_columns
@@ -577,7 +576,7 @@ module RailsBestPractices
       end
 
       context 'validates' do
-        it 'should not remove unused method' do
+        it 'does not remove unused method' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             validate :valid_birth_date
@@ -592,7 +591,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method for validate_on_create and validate_on_update' do
+        it 'does not remove unused method for validate_on_create and validate_on_update' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             validate_on_create :valid_email
@@ -609,7 +608,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused methods for to_param' do
+        it 'does not remove unused methods for to_param' do
           content = <<-EOF
           class Post < ActiveRecord::Base
             def to_param
@@ -625,7 +624,7 @@ module RailsBestPractices
       end
 
       context 'helper method' do
-        it 'should not remove unused method for coommand_call collection_select' do
+        it 'does not remove unused method for coommand_call collection_select' do
           content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
@@ -641,7 +640,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method for command collection_select' do
+        it 'does not remove unused method for command collection_select' do
           content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
@@ -657,7 +656,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not remove unused method for options_from_collection_for_select' do
+        it 'does not remove unused method for options_from_collection_for_select' do
           content = <<-EOF
           class Category < ActiveRecord::Base
             def indented_name; end
@@ -674,7 +673,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should not remove unused methods for rabl view' do
+      it 'does not remove unused methods for rabl view' do
         content = <<-EOF
         class User
           def first_name; end
@@ -693,7 +692,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not skip :call as call message' do
+      it 'does not skip :call as call message' do
         content = <<-EOF
         module DateRange
           RANGES = lambda {
@@ -708,9 +707,12 @@ module RailsBestPractices
         runner.review('app/mixins/date_range.rb', content)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: Prepares::ModelPrepare.new,
-                                  reviews: RemoveUnusedMethodsInModelsReview.new(except_methods: [], ignored_files: /post/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: Prepares::ModelPrepare.new,
+            reviews: described_class.new(except_methods: [], ignored_files: /post/)
+          )
 
         content = <<-EOF
           class Post < ActiveRecord::Base