rails_best_practices 1.20.0 → 1.20.1

data/spec/rails_best_practices/reviews/use_before_filter_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseBeforeFilterReview do
-      let(:runner) { Core::Runner.new(reviews: UseBeforeFilterReview.new(customize_count: 2)) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new(customize_count: 2)) }
 
-      it 'should use before_filter' do
+      it 'uses before_filter' do
         content = <<-EOF
         class PostsController < ApplicationController
           def show
@@ -31,10 +31,12 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2,6,10,15 - use before_filter for show,edit,update,destroy')
+        expect(runner.errors[0].to_s).to eq(
+          'app/controllers/posts_controller.rb:2,6,10,15 - use before_filter for show,edit,update,destroy'
+        )
       end
 
-      it 'should not use before_filter when equal to customize count' do
+      it 'does not use before_filter when equal to customize count' do
         content = <<-EOF
         class PostsController < ApplicationController
           def show
@@ -50,7 +52,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use before_filter' do
+      it 'does not use before_filter' do
         content = <<-EOF
         class PostsController < ApplicationController
           before_filter :find_post, only: [:show, :edit, :update, :destroy]
@@ -73,7 +75,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use before_filter by nil' do
+      it 'does not use before_filter by nil' do
         content = <<-EOF
         class PostsController < ApplicationController
           def show; end
@@ -86,7 +88,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use before_filter for protected/private methods' do
+      it 'does not use before_filter for protected/private methods' do
         content = <<-EOF
         class PostsController < ApplicationController
           protected
@@ -105,8 +107,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: UseBeforeFilterReview.new(customize_count: 2, ignored_files: /posts_controller/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(customize_count: 2, ignored_files: /posts_controller/))
         content = <<-EOF
         class PostsController < ApplicationController
           def show

data/spec/rails_best_practices/reviews/use_model_association_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseModelAssociationReview do
-      let(:runner) { Core::Runner.new(reviews: UseModelAssociationReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should use model association for instance variable' do
+      it 'uses model association for instance variable' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -22,7 +22,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - use model association (for @post)')
       end
 
-      it 'should not use model association without association assign' do
+      it 'does not use model association without association assign' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -35,7 +35,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should use model association for local variable' do
+      it 'uses model association for local variable' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -50,7 +50,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - use model association (for post)')
       end
 
-      it 'should not use model association' do
+      it 'does not use model association' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -63,8 +63,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: UseModelAssociationReview.new(ignored_files: /posts_controller/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_controller/))
         content = <<-EOF
         class PostsController < ApplicationController
           def create

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseMultipartAlternativeAsContentTypeOfEmailReview do
-      let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new) }
+      let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: described_class.new) }
 
-      before(:each) { allow(Core::Runner).to receive(:base_path).and_return('.') }
+      before { allow(Core::Runner).to receive(:base_path).and_return('.') }
 
       def mock_email_files(entry_files)
         allow(Dir).to receive(:entries).with('./app/views/project_mailer').and_return(entry_files)
@@ -31,7 +31,7 @@ module RailsBestPractices
       end
 
       context 'project_mailer' do
-        let(:content) {
+        let(:content) do
           <<-EOF
           class ProjectMailer < ActionMailer::Base
             def send_email(email)
@@ -43,23 +43,25 @@ module RailsBestPractices
             end
           end
           EOF
-        }
+        end
 
         context 'erb' do
-          it 'should use mulipart/alternative as content_type of email' do
+          it 'uses mulipart/alternative as content_type of email' do
             mock_email_files(['send_email.html.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq('app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email')
+            expect(runner.errors[0].to_s).to eq(
+              'app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email'
+            )
           end
 
-          it 'should not use multiple/alternative as content_type of email when only plain text' do
+          it 'does not use multiple/alternative as content_type of email when only plain text' do
             mock_email_files(['send_email.text.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it 'should not use multipart/alternative as content_type of email' do
+          it 'does not use multipart/alternative as content_type of email' do
             mock_email_files(['send_email.text.erb', 'send_email.html.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
@@ -67,32 +69,34 @@ module RailsBestPractices
         end
 
         context 'haml' do
-          it 'should use mulipart/alternative as content_type of email' do
+          it 'uses mulipart/alternative as content_type of email' do
             mock_email_files(['send_email.html.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq('app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email')
+            expect(runner.errors[0].to_s).to eq(
+              'app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email'
+            )
           end
 
-          it 'should not use multiple/alternative as content_type of email when only plain text' do
+          it 'does not use multiple/alternative as content_type of email when only plain text' do
             mock_email_files(['send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it 'should not use multipart/alternative as content_type of email' do
+          it 'does not use multipart/alternative as content_type of email' do
             mock_email_files(['send_email.html.haml', 'send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it 'should not use multipart/alternative as content_type of email with text locale' do
+          it 'does not use multipart/alternative as content_type of email with text locale' do
             mock_email_files(['send_email.html.haml', 'send_email.de.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it 'should not use multipart/alternative as content_type of email with html locale' do
+          it 'does not use multipart/alternative as content_type of email with html locale' do
             mock_email_files(['send_email.de.html.haml', 'send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
@@ -100,7 +104,7 @@ module RailsBestPractices
         end
 
         context 'haml/erb mix' do
-          it 'should not suggest using multipart/alternative when mixing html.haml and text.erb' do
+          it 'does not suggest using multipart/alternative when mixing html.haml and text.erb' do
             mock_email_files(['send_email.html.haml', 'send_email.text.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
@@ -111,8 +115,8 @@ module RailsBestPractices
           end
         end
 
-        it 'should not check ignored files' do
-          runner = Core::Runner.new(reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new(ignored_files: /project_mailer/))
+        it 'does not check ignored files' do
+          runner = Core::Runner.new(reviews: described_class.new(ignored_files: /project_mailer/))
           mock_email_files(['send_email.html.haml'])
           runner.review('app/mailers/project_mailer.rb', content)
           expect(runner.errors.size).to eq(0)

data/spec/rails_best_practices/reviews/use_observer_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseObserverReview do
-      let(:runner) { Core::Runner.new(prepares: Prepares::MailerPrepare.new, reviews: UseObserverReview.new) }
+      let(:runner) { Core::Runner.new(prepares: Prepares::MailerPrepare.new, reviews: described_class.new) }
 
-      before :each do
+      before do
         content = <<-EOF
         class ProjectMailer < ActionMailer::Base
         end
@@ -15,7 +15,7 @@ module RailsBestPractices
         runner.prepare('app/models/project_mailer.rb', content)
       end
 
-      it 'should use observer' do
+      it 'uses observer' do
         content = <<-EOF
         class Project < ActiveRecord::Base
           after_create :send_create_notification
@@ -33,7 +33,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/project.rb:5 - use observer')
       end
 
-      it 'should not use observer without callback' do
+      it 'does not use observer without callback' do
         content = <<-EOF
         class Project < ActiveRecord::Base
           private
@@ -48,7 +48,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should use observer with two after_create' do
+      it 'uses observer with two after_create' do
         content = <<-EOF
         class Project < ActiveRecord::Base
           after_create :send_create_notification, :update_author
@@ -69,7 +69,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/project.rb:5 - use observer')
       end
 
-      it 'should not raise when initiate an object in callback' do
+      it 'does not raise when initiate an object in callback' do
         content = <<-EOF
         class Project < ActiveRecord::Base
           after_create ProjectMailer.new

data/spec/rails_best_practices/reviews/use_parentheses_in_method_def_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseParenthesesInMethodDefReview do
-      let(:runner) { Core::Runner.new(reviews: UseParenthesesInMethodDefReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should find missing parentheses' do
+      it 'finds missing parentheses' do
         content = <<-EOF
         class PostsController < ApplicationController
           def edit foo, bar
@@ -16,9 +16,11 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - use parentheses around parameters in method definitions')
+        expect(runner.errors[0].to_s).to eq(
+          'app/controllers/posts_controller.rb:2 - use parentheses around parameters in method definitions'
+        )
       end
-      it 'should find parentheses with no error' do
+      it 'finds parentheses with no error' do
         content = <<-EOF
         class PostsController < ApplicationController
           def edit(foo, bar)
@@ -28,7 +30,7 @@ module RailsBestPractices
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(0)
       end
-      it 'should not throw an error without parameters' do
+      it 'does not throw an error without parameters' do
         content = <<-EOF
         class PostsController < ApplicationController
           def edit
@@ -39,8 +41,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: UseParenthesesInMethodDefReview.new(ignored_files: /posts_controller/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /posts_controller/))
         content = <<-EOF
         class PostsController < ApplicationController
           def edit foo, bar

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -5,9 +5,13 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe UseQueryAttributeReview do
-      let(:runner) { Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: UseQueryAttributeReview.new) }
+      let(:runner) do
+        Core::Runner.new(
+          prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: described_class.new
+        )
+      end
 
-      before :each do
+      before do
         content = <<-EOF
         class User < ActiveRecord::Base
           has_many :projects
@@ -30,7 +34,7 @@ module RailsBestPractices
         runner.prepare('db/schema.rb', content)
       end
 
-      it 'should use query attribute by blank call' do
+      it 'uses query attribute by blank call' do
         content = <<-EOF
         <% if @user.login.blank? %>
           <%= link_to 'login', new_session_path %>
@@ -41,7 +45,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should use query attribute by blank call with if in one line' do
+      it 'uses query attribute by blank call with if in one line' do
         content = <<-EOF
         <%= link_to 'login', new_session_path if @user.login.blank? %>
         EOF
@@ -50,7 +54,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute by blank call with '? :'" do
+      it "uses query attribute by blank call with '? :'" do
         content = <<-EOF
         <%= @user.login.blank? ? link_to('login', new_session_path) : '' %>
         EOF
@@ -59,7 +63,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should use query attribute by comparing empty string' do
+      it 'uses query attribute by comparing empty string' do
         content = <<-EOF
         <% if @user.login == "" %>
           <%= link_to 'login', new_session_path %>
@@ -70,7 +74,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should use query attribute by nil call' do
+      it 'uses query attribute by nil call' do
         content = <<-EOF
         <% if @user.login.nil? %>
           <%= link_to 'login', new_session_path %>
@@ -81,7 +85,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should use query attribute by present call' do
+      it 'uses query attribute by present call' do
         content = <<-EOF
         <% if @user.login.present? %>
           <%= @user.login %>
@@ -92,7 +96,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should use query attribute within and conditions' do
+      it 'uses query attribute within and conditions' do
         content = <<-EOF
         <% if @user.active? && @user.login.present? %>
           <%= @user.login %>
@@ -103,7 +107,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should use query attribute within or conditions' do
+      it 'uses query attribute within or conditions' do
         content = <<-EOF
         <% if @user.active? or @user.login != "" %>
           <%= @user.login %>
@@ -114,7 +118,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it 'should not use query attribute' do
+      it 'does not use query attribute' do
         content = <<-EOF
         <% if @user.login? %>
           <%= @user.login %>
@@ -124,7 +128,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not use query attribute for number' do
+      it 'does not use query attribute for number' do
         content = <<-EOF
         <% unless @user.age.blank? %>
           <%= @user.age %>
@@ -134,7 +138,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not review for pluralize attribute' do
+      it 'does not review for pluralize attribute' do
         content = <<-EOF
         <% if @user.roles.blank? %>
           <%= @user.login %>
@@ -144,7 +148,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not review non model class' do
+      it 'does not review non model class' do
         content = <<-EOF
         <% if @person.login.present? %>
           <%= @person.login %>
@@ -155,7 +159,7 @@ module RailsBestPractices
       end
 
       context 'association' do
-        it 'should not review belongs_to association' do
+        it 'does not review belongs_to association' do
           content = <<-EOF
           <% if @user.location.present? %>
             <%= @user.location.name %>
@@ -165,7 +169,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not review belongs_to category' do
+        it 'does not review belongs_to category' do
           content = <<-EOF
           <% if @user.category.present? %>
             <%= @user.category.name %>
@@ -175,7 +179,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not review has_one association' do
+        it 'does not review has_one association' do
           content = <<-EOF
           <% if @user.phone.present? %>
             <%= @user.phone.number %>
@@ -185,7 +189,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it 'should not review has_many association' do
+        it 'does not review has_many association' do
           content = <<-EOF
           <% if @user.projects.present? %>
             <%= @user.projects.first.name %>
@@ -196,7 +200,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should not review for class method' do
+      it 'does not review for class method' do
         content = <<-EOF
         <% if User.name.present? %>
           <%= User.name %>
@@ -206,7 +210,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not review for non attribute call' do
+      it 'does not review for non attribute call' do
         content = <<-EOF
         if @user.login(false).nil?
           puts @user.login(false)
@@ -216,7 +220,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not raise error for common conditional statement' do
+      it 'does not raise error for common conditional statement' do
         content = <<-EOF
         if voteable.is_a? Answer
           puts voteable.title
@@ -225,9 +229,12 @@ module RailsBestPractices
         expect { runner.review('app/models/users_controller.rb', content) }.not_to raise_error
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
-                                  reviews: UseQueryAttributeReview.new(ignored_files: /users\/show/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
+            reviews: described_class.new(ignored_files: %r{users/show})
+          )
         content = <<-EOF
         <% if @user.login.blank? %>
           <%= link_to 'login', new_session_path %>