rails_best_practices 1.20.0 → 1.20.1

data/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe DefaultScopeIsEvilReview do
-      let(:runner) { Core::Runner.new(reviews: DefaultScopeIsEvilReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should detect default_scope with -> syntax' do
+      it 'detects default_scope with -> syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope -> { order('created_at desc') }
@@ -18,7 +18,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - default_scope is evil')
       end
 
-      it 'should detect default_scope with old syntax' do
+      it 'detects default_scope with old syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope order('created_at desc')
@@ -29,7 +29,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - default_scope is evil')
       end
 
-      it 'should not detect default_scope' do
+      it 'does not detect default_scope' do
         content = <<-EOF
         class User < ActiveRecord::Base
           scope :default, -> { order('created_at desc') }
@@ -39,8 +39,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: DefaultScopeIsEvilReview.new(ignored_files: /user/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /user/))
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope -> { order('created_at desc') }

data/spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe DryBundlerInCapistranoReview do
-      let(:runner) { Core::Runner.new(reviews: DryBundlerInCapistranoReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should dry bundler in capistrno' do
+      it 'dries bundler in capistrno' do
         content = <<-EOF
         namespace :bundler do
           task :create_symlink, roles: :app do
@@ -29,7 +29,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('config/deploy.rb:1 - dry bundler in capistrano')
       end
 
-      it 'should not dry bundler in capistrano' do
+      it 'does not dry bundler in capistrano' do
         content = <<-EOF
           require 'bundler/capistrano'
         EOF
@@ -37,8 +37,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: DryBundlerInCapistranoReview.new(ignored_files: /deploy\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /deploy\.rb/))
         content = <<-EOF
         namespace :bundler do
           task :create_symlink, roles: :app do

data/spec/rails_best_practices/reviews/hash_syntax_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe HashSyntaxReview do
-      let(:runner) { Core::Runner.new(reviews: HashSyntaxReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should find 1.8 Hash with symbol' do
+      it 'finds 1.8 Hash with symbol' do
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }
@@ -18,7 +18,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - change Hash Syntax to 1.9')
       end
 
-      it 'should not find 1.8 Hash with string' do
+      it 'does not find 1.8 Hash with string' do
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { "foo" => "bar" }
@@ -28,7 +28,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not alert on 1.9 Syntax' do
+      it 'does not alert on 1.9 Syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { foo: :bar }
@@ -38,7 +38,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should ignore haml_out' do
+      it 'ignores haml_out' do
         content = <<~EOF
           %div{ class: "foo1" }
           .div{ class: "foo2" }
@@ -48,7 +48,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not consider hash with array key' do
+      it 'does not consider hash with array key' do
         content = <<-EOF
         transition [:unverified, :verified] => :deleted
         EOF
@@ -56,7 +56,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not consider hash with charaters not valid for symbol' do
+      it 'does not consider hash with charaters not valid for symbol' do
         content = <<-EOF
         receiver.stub(:` => 'Error')
         EOF
@@ -64,8 +64,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: HashSyntaxReview.new(ignored_files: /user/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /user/))
         content = <<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }

data/spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb

@@ -5,10 +5,10 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe IsolateSeedDataReview do
-      let(:runner) { Core::Runner.new(reviews: IsolateSeedDataReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
       context 'create' do
-        it 'should isolate seed data' do
+        it 'isolates seed data' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -33,7 +33,7 @@ module RailsBestPractices
       end
 
       context 'new and save' do
-        it 'should isolate seed data for local variable' do
+        it 'isolates seed data for local variable' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -57,7 +57,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('db/migrate/20090818130258_create_roles.rb:9 - isolate seed data')
         end
 
-        it 'should isolate seed data for instance variable' do
+        it 'isolates seed data for instance variable' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -82,7 +82,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should not isolate seed data without data insert' do
+      it 'does not isolate seed data without data insert' do
         content = <<-EOF
         class CreateRoles < ActiveRecord::Migration
           def self.up
@@ -100,8 +100,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: IsolateSeedDataReview.new(ignored_files: /create_roles/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: /create_roles/))
         content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up

data/spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe KeepFindersOnTheirOwnModelReview do
-      let(:runner) { Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should keep finders on thier own model' do
+      it 'keeps finders on thier own model' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -23,7 +23,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/post.rb:5 - keep finders on their own model')
       end
 
-      it 'should keep finders on thier own model with all method' do
+      it 'keeps finders on thier own model with all method' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -39,7 +39,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/models/post.rb:5 - keep finders on their own model')
       end
 
-      it 'should not keep finders on thier own model with self finder' do
+      it 'does not keep finders on thier own model with self finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -54,7 +54,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not keep finders on thier own model with own finder' do
+      it 'does not keep finders on thier own model with own finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -69,7 +69,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not keep finders on their own model without finder' do
+      it 'does not keep finders on their own model without finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -83,7 +83,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not keep finders on their own model with ruby Array#find' do
+      it 'does not keep finders on their own model with ruby Array#find' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -97,8 +97,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new(ignored_files: /app\/models\/post\.rb/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/models/post\.rb}))
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -5,10 +5,14 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe LawOfDemeterReview do
-      let(:runner) { Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: LawOfDemeterReview.new) }
+      let(:runner) do
+        Core::Runner.new(
+          prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: described_class.new
+        )
+      end
 
       describe 'belongs_to' do
-        before(:each) do
+        before do
           content = <<-EOF
           class Invoice < ActiveRecord::Base
             belongs_to :user
@@ -28,7 +32,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it 'should law of demeter with erb' do
+        it 'laws of demeter with erb' do
           content = <<-EOF
           <%= @invoice.user.name %>
           <%= @invoice.user.address %>
@@ -39,7 +43,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.erb:1 - law of demeter')
         end
 
-        it 'should law of demeter with haml' do
+        it 'laws of demeter with haml' do
           content = <<~EOF
             = @invoice.user.name
             = @invoice.user.address
@@ -50,7 +54,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.haml:1 - law of demeter')
         end
 
-        it 'should law of demeter with slim' do
+        it 'laws of demeter with slim' do
           content = <<~EOF
             = @invoice.user.name
             = @invoice.user.address
@@ -61,7 +65,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.slim:1 - law of demeter')
         end
 
-        it 'should no law of demeter' do
+        it 'noes law of demeter' do
           content = <<-EOF
           <%= @invoice.user_name %>
           <%= @invoice.user_address %>
@@ -73,7 +77,7 @@ module RailsBestPractices
       end
 
       describe 'has_one' do
-        before(:each) do
+        before do
           content = <<-EOF
           class Invoice < ActiveRecord::Base
             has_one :price
@@ -92,7 +96,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it 'should law of demeter' do
+        it 'laws of demeter' do
           content = <<-EOF
           <%= @invoice.price.currency %>
           <%= @invoice.price.number %>
@@ -104,7 +108,7 @@ module RailsBestPractices
       end
 
       context 'polymorphic association' do
-        before :each do
+        before do
           content = <<-EOF
           class Comment < ActiveRecord::Base
             belongs_to :commentable, polymorphic: true
@@ -129,7 +133,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it 'should law of demeter' do
+        it 'laws of demeter' do
           content = <<-EOF
           <%= @comment.commentable.title %>
           EOF
@@ -139,7 +143,7 @@ module RailsBestPractices
         end
       end
 
-      it 'should no law of demeter with method call' do
+      it 'noes law of demeter with method call' do
         content = <<-EOF
         class Question < ActiveRecord::Base
           has_many :answers, dependent: :destroy
@@ -163,9 +167,12 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
-                                  reviews: LawOfDemeterReview.new(ignored_files: /app\/views\/invoices/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
+            reviews: described_class.new(ignored_files: %r{app/views/invoices})
+          )
         content = <<-EOF
           <%= @invoice.user.name %>
           <%= @invoice.user.address %>

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoControllerReview do
-      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoControllerReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move code into controller for method call' do
+      it 'moves code into controller for method call' do
         content = <<-EOF
         <% Post.find(:all).each do |post| %>
           <%=h post.title %>
@@ -19,7 +19,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
       end
 
-      it 'should move code into controller for assign' do
+      it 'moves code into controller for assign' do
         content = <<-EOF
         <% @posts = Post.all %>
         <% @posts.each do |post| %>
@@ -32,7 +32,7 @@ module RailsBestPractices
         expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
       end
 
-      it 'should not move code into controller' do
+      it 'does not move code into controller' do
         content = <<-EOF
         <% @posts.each do |post| %>
           <%=h post.title %>
@@ -43,8 +43,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new(ignored_files: /app\/views\/post/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/views/post}))
         content = <<-EOF
         <% Post.find(:all).each do |post| %>
           <%=h post.title %>

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoHelperReview do
-      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoHelperReview.new('array_count' => 2)) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new('array_count' => 2)) }
 
-      it 'should move code into helper' do
+      it 'moves code into helper' do
         content = <<-EOF
         <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
                                                     [t(:published), "published"]],
@@ -15,10 +15,12 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)'
+        )
       end
 
-      it 'should not move code into helper with simple arguments' do
+      it 'does not move code into helper with simple arguments' do
         content = <<-EOF
         <%= select_tag :state, options_for_select( Post.STATES ) %>
         EOF
@@ -26,8 +28,11 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => /app\/views\/post/))
+      it 'does not check ignored files' do
+        runner =
+          Core::Runner.new(
+            reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => %r{app/views/post})
+          )
         content = <<-EOF
         <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
                                                     [t(:published), "published"]],

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -5,9 +5,9 @@ require 'spec_helper'
 module RailsBestPractices
   module Reviews
     describe MoveCodeIntoModelReview do
-      let(:runner) { Core::Runner.new(reviews: MoveCodeIntoModelReview.new) }
+      let(:runner) { Core::Runner.new(reviews: described_class.new) }
 
-      it 'should move code into model' do
+      it 'moves code into model' do
         content = <<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
@@ -15,48 +15,58 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model with haml' do
+      it 'moves code into model with haml' do
         content = <<~EOF
           - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
             = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.haml', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model with slim' do
+      it 'moves code into model with slim' do
         content = <<~EOF
           - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
             = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.slim', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model with if in one line' do
+      it 'moves code into model with if in one line' do
         content = <<-EOF
         <%= link_to 'Edit this post', edit_post_url(@post) if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it "should move code into model with '? :'" do
+      it "moves code into model with '? :'" do
         content = <<-EOF
         <%= current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) ? link_to('Edit this post', edit_post_url(@post)) : '' %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
+        expect(runner.errors[0].to_s).to eq(
+          'app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)'
+        )
       end
 
-      it 'should move code into model only review for current if conditional statement' do
+      it 'moves code into model only review for current if conditional statement' do
         content = <<-EOF
         <% if @post.title %>
           <% if @post.user %>
@@ -69,7 +79,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move code into model' do
+      it 'does not move code into model' do
         content = <<-EOF
         <% if @post.editable_by?(current_user) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
@@ -79,7 +89,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not move code into model for multiple calls on same variable node' do
+      it 'does not move code into model for multiple calls on same variable node' do
         content = <<-EOF
         <% if !job.company.blank? && job.company.title? %>
         <% end %>
@@ -88,8 +98,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it 'should not check ignored files' do
-        runner = Core::Runner.new(reviews: MoveCodeIntoModelReview.new(ignored_files: /app\/views\/post/))
+      it 'does not check ignored files' do
+        runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/views/post}))
         content = <<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>