rails_best_practices 1.19.0 → 1.19.1

data/spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe UseSayWithTimeInMigrationsReview do
       let(:runner) { Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new) }
 
-      it "should use say with time in migrations" do
+      it 'should use say with time in migrations' do
         content =<<-EOF
         def self.up
           User.find_each do |user|
@@ -16,10 +16,10 @@ module RailsBestPractices
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations")
+        expect(runner.errors[0].to_s).to eq('db/migrate/20101010080658_update_users.rb:2 - use say with time in migrations')
       end
 
-      it "should use say with time in migrations with create_table" do
+      it 'should use say with time in migrations with create_table' do
         content =<<-EOF
         def self.up
           create_table :users do |t|
@@ -35,10 +35,10 @@ module RailsBestPractices
         EOF
         runner.review('db/migrate/20101010080658_update_users.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations")
+        expect(runner.errors[0].to_s).to eq('db/migrate/20101010080658_update_users.rb:7 - use say with time in migrations')
       end
 
-      it "should not use say with time in migrations" do
+      it 'should not use say with time in migrations' do
         content =<<-EOF
         def self.up
           say_with_time("Initialize first_name and last_name for users") do
@@ -54,7 +54,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use say with time in migrations when not first code line" do
+      it 'should not use say with time in migrations when not first code line' do
         content =<<-EOF
         def self.up
           User.find_each do |user|
@@ -68,7 +68,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use say with time when default migration message" do
+      it 'should not use say with time when default migration message' do
         content =<<-EOF
         def self.up
           create_table :users do |t|
@@ -82,7 +82,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not raise an error" do
+      it 'should not raise an error' do
         content =<<-EOF
         class AddAdmin < ActiveRecord::Migration
 
@@ -118,7 +118,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(3)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: UseSayWithTimeInMigrationsReview.new(ignored_files: /20101010080658_update_users/))
         content =<<-EOF
         def self.up

data/spec/rails_best_practices/reviews/use_scope_access_review_spec.rb

@@ -5,8 +5,8 @@ module RailsBestPractices
     describe UseScopeAccessReview do
       let(:runner) { Core::Runner.new(reviews: UseScopeAccessReview.new) }
 
-      context "if" do
-        it "should use scope access" do
+      context 'if' do
+        it 'should use scope access' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -21,10 +21,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access with if in one line" do
+        it 'should use scope access with if in one line' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -36,7 +36,7 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
         it "should use scope access with '? :'" do
@@ -51,10 +51,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access by comparing with id" do
+        it 'should use scope access by comparing with id' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -69,10 +69,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access with current_user ==" do
+        it 'should use scope access with current_user ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -87,10 +87,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access by current_user.id ==" do
+        it 'should use scope access by current_user.id ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -105,12 +105,12 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
       end
 
-      context "unless" do
-        it "should use scope access" do
+      context 'unless' do
+        it 'should use scope access' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -125,10 +125,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access by comparing with id" do
+        it 'should use scope access by comparing with id' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -143,10 +143,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access with current_user ==" do
+        it 'should use scope access with current_user ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -161,10 +161,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should use scope access by current_user.id ==" do
+        it 'should use scope access by current_user.id ==' do
           content = <<-EOF
           class PostsController < ApplicationController
             def edit
@@ -179,10 +179,10 @@ module RailsBestPractices
           EOF
           runner.review('app/controllers/posts_controller.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:5 - use scope access")
+          expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:5 - use scope access')
         end
 
-        it "should no error in use_scope_access_review" do
+        it 'should no error in use_scope_access_review' do
           content = <<-EOF
           class CommentsController < ApplicationController
             def add_comment
@@ -204,7 +204,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not check ignored files" do
+        it 'should not check ignored files' do
           runner = Core::Runner.new(reviews: UseScopeAccessReview.new(ignored_files: /posts_controller/))
           content = <<-EOF
           class PostsController < ApplicationController

data/spec/rails_best_practices/reviews/use_turbo_sprockets_rails3_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe UseTurboSprocketsRails3Review do
       let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseTurboSprocketsRails3Review.new) }
 
-      it "should use turbo-sprockets-rails3" do
+      it 'should use turbo-sprockets-rails3' do
         content = <<-EOF
 GEM
   remote: https://rubygems.org
@@ -27,10 +27,10 @@ GEM
         EOF
         runner.review('Capfile', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("Capfile:2 - speed up assets precompile with turbo-sprockets-rails3")
+        expect(runner.errors[0].to_s).to eq('Capfile:2 - speed up assets precompile with turbo-sprockets-rails3')
       end
 
-      it "should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem" do
+      it 'should not use turbo-sprockets-rails3 with turbo-sprockets-rails3 gem' do
         content = <<-EOF
 GEM
   remote: https://rubygems.org
@@ -57,7 +57,7 @@ GEM
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use turbo-sprockets-rails3 without deploy/assets" do
+      it 'should not use turbo-sprockets-rails3 without deploy/assets' do
         content = <<-EOF
         load 'deploy' if respond_to?(:namespace)
         #load 'deploy/assets'
@@ -67,7 +67,7 @@ GEM
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use turbo-sprockets-rails3 with rails4 gem" do
+      it 'should not use turbo-sprockets-rails3 with rails4 gem' do
         content = <<-EOF
 GEM
   remote: https://rubygems.org
@@ -91,7 +91,7 @@ GEM
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: Prepares::GemfilePrepare.new,
                                   reviews: UseTurboSprocketsRails3Review.new(ignored_files: /Capfile/))
         content = <<-EOF

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
 require 'rspec'
 require 'rails_best_practices'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.19.0
+  version: 1.19.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-26 00:00:00.000000000 Z
+date: 2018-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -70,16 +70,16 @@ dependencies:
   name: require_all
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.5.0
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -401,7 +401,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: a code metric tool for rails codes.