rails_best_practices 1.19.0 → 1.19.1

data/spec/rails_best_practices/reviews/use_before_filter_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe UseBeforeFilterReview do
       let(:runner) { Core::Runner.new(reviews: UseBeforeFilterReview.new(customize_count: 2)) }
 
-      it "should use before_filter" do
+      it 'should use before_filter' do
         content = <<-EOF
         class PostsController < ApplicationController
           def show
@@ -29,10 +29,10 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2,6,10,15 - use before_filter for show,edit,update,destroy")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2,6,10,15 - use before_filter for show,edit,update,destroy')
       end
 
-      it "should not use before_filter when equal to customize count" do
+      it 'should not use before_filter when equal to customize count' do
         content = <<-EOF
         class PostsController < ApplicationController
           def show
@@ -48,7 +48,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use before_filter" do
+      it 'should not use before_filter' do
         content = <<-EOF
         class PostsController < ApplicationController
           before_filter :find_post, only: [:show, :edit, :update, :destroy]
@@ -71,7 +71,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use before_filter by nil" do
+      it 'should not use before_filter by nil' do
         content = <<-EOF
         class PostsController < ApplicationController
           def show; end
@@ -84,7 +84,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use before_filter for protected/private methods" do
+      it 'should not use before_filter for protected/private methods' do
         content =<<-EOF
         class PostsController < ApplicationController
           protected
@@ -103,7 +103,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: UseBeforeFilterReview.new(customize_count: 2, ignored_files: /posts_controller/))
         content = <<-EOF
         class PostsController < ApplicationController

data/spec/rails_best_practices/reviews/use_model_association_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe UseModelAssociationReview do
       let(:runner) { Core::Runner.new(reviews: UseModelAssociationReview.new) }
 
-      it "should use model association for instance variable" do
+      it 'should use model association for instance variable' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -17,10 +17,10 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - use model association (for @post)")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - use model association (for @post)')
       end
 
-      it "should not use model association without association assign" do
+      it 'should not use model association without association assign' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -33,7 +33,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should use model association for local variable" do
+      it 'should use model association for local variable' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -45,10 +45,10 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - use model association (for post)")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - use model association (for post)')
       end
 
-      it "should not use model association" do
+      it 'should not use model association' do
         content = <<-EOF
         class PostsController < ApplicationController
           def create
@@ -61,7 +61,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: UseModelAssociationReview.new(ignored_files: /posts_controller/))
         content = <<-EOF
         class PostsController < ApplicationController

data/spec/rails_best_practices/reviews/use_multipart_alternative_as_content_type_of_email_review_spec.rb

@@ -5,10 +5,10 @@ module RailsBestPractices
     describe UseMultipartAlternativeAsContentTypeOfEmailReview do
       let(:runner) { Core::Runner.new(prepares: Prepares::GemfilePrepare.new, reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new) }
 
-      before(:each) { allow(Core::Runner).to receive(:base_path).and_return(".") }
+      before(:each) { allow(Core::Runner).to receive(:base_path).and_return('.') }
 
       def mock_email_files(entry_files)
-        allow(Dir).to receive(:entries).with("./app/views/project_mailer").and_return(entry_files)
+        allow(Dir).to receive(:entries).with('./app/views/project_mailer').and_return(entry_files)
       end
 
       before do
@@ -28,7 +28,7 @@ GEM
       runner.prepare('Gemfile.lock', content)
       end
 
-      context "project_mailer" do
+      context 'project_mailer' do
         let(:content) {
           <<-EOF
           class ProjectMailer < ActionMailer::Base
@@ -43,75 +43,75 @@ GEM
           EOF
         }
 
-        context "erb" do
-          it "should use mulipart/alternative as content_type of email" do
-            mock_email_files(["send_email.html.erb"])
+        context 'erb' do
+          it 'should use mulipart/alternative as content_type of email' do
+            mock_email_files(['send_email.html.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
+            expect(runner.errors[0].to_s).to eq('app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email')
           end
 
-          it "should not use multiple/alternative as content_type of email when only plain text" do
-            mock_email_files(["send_email.text.erb"])
+          it 'should not use multiple/alternative as content_type of email when only plain text' do
+            mock_email_files(['send_email.text.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it "should not use multipart/alternative as content_type of email" do
-            mock_email_files(["send_email.text.erb", "send_email.html.erb"])
+          it 'should not use multipart/alternative as content_type of email' do
+            mock_email_files(['send_email.text.erb', 'send_email.html.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
         end
 
-        context "haml" do
-          it "should use mulipart/alternative as content_type of email" do
-            mock_email_files(["send_email.html.haml"])
+        context 'haml' do
+          it 'should use mulipart/alternative as content_type of email' do
+            mock_email_files(['send_email.html.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email")
+            expect(runner.errors[0].to_s).to eq('app/mailers/project_mailer.rb:2 - use multipart/alternative as content_type of email')
           end
 
-          it "should not use multiple/alternative as content_type of email when only plain text" do
-            mock_email_files(["send_email.text.haml"])
+          it 'should not use multiple/alternative as content_type of email when only plain text' do
+            mock_email_files(['send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it "should not use multipart/alternative as content_type of email" do
-            mock_email_files(["send_email.html.haml", "send_email.text.haml"])
+          it 'should not use multipart/alternative as content_type of email' do
+            mock_email_files(['send_email.html.haml', 'send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it "should not use multipart/alternative as content_type of email with text locale" do
-            mock_email_files(["send_email.html.haml", "send_email.de.text.haml"])
+          it 'should not use multipart/alternative as content_type of email with text locale' do
+            mock_email_files(['send_email.html.haml', 'send_email.de.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
 
-          it "should not use multipart/alternative as content_type of email with html locale" do
-            mock_email_files(["send_email.de.html.haml", "send_email.text.haml"])
+          it 'should not use multipart/alternative as content_type of email with html locale' do
+            mock_email_files(['send_email.de.html.haml', 'send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
         end
 
-        context "haml/erb mix" do
-          it "should not suggest using multipart/alternative when mixing html.haml and text.erb" do
-            mock_email_files(["send_email.html.haml", "send_email.text.erb"])
+        context 'haml/erb mix' do
+          it 'should not suggest using multipart/alternative when mixing html.haml and text.erb' do
+            mock_email_files(['send_email.html.haml', 'send_email.text.erb'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
 
-            mock_email_files(["send_email.html.erb", "send_email.text.haml"])
+            mock_email_files(['send_email.html.erb', 'send_email.text.haml'])
             runner.review('app/mailers/project_mailer.rb', content)
             expect(runner.errors.size).to eq(0)
           end
         end
 
-        it "should not check ignored files" do
+        it 'should not check ignored files' do
           runner = Core::Runner.new(reviews: UseMultipartAlternativeAsContentTypeOfEmailReview.new(ignored_files: /project_mailer/))
-          mock_email_files(["send_email.html.haml"])
+          mock_email_files(['send_email.html.haml'])
           runner.review('app/mailers/project_mailer.rb', content)
           expect(runner.errors.size).to eq(0)
         end

data/spec/rails_best_practices/reviews/use_observer_review_spec.rb

@@ -13,7 +13,7 @@ module RailsBestPractices
         runner.prepare('app/models/project_mailer.rb', content)
       end
 
-      it "should use observer" do
+      it 'should use observer' do
         content =<<-EOF
         class Project < ActiveRecord::Base
           after_create :send_create_notification
@@ -28,10 +28,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/project.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
+        expect(runner.errors[0].to_s).to eq('app/models/project.rb:5 - use observer')
       end
 
-      it "should not use observer without callback" do
+      it 'should not use observer without callback' do
         content =<<-EOF
         class Project < ActiveRecord::Base
           private
@@ -46,7 +46,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should use observer with two after_create" do
+      it 'should use observer with two after_create' do
         content =<<-EOF
         class Project < ActiveRecord::Base
           after_create :send_create_notification, :update_author
@@ -64,10 +64,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/project.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/project.rb:5 - use observer")
+        expect(runner.errors[0].to_s).to eq('app/models/project.rb:5 - use observer')
       end
 
-      it "should not raise when initiate an object in callback" do
+      it 'should not raise when initiate an object in callback' do
         content =<<-EOF
         class Project < ActiveRecord::Base
           after_create ProjectMailer.new

data/spec/rails_best_practices/reviews/use_parentheses_in_method_def_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe UseParenthesesInMethodDefReview do
       let(:runner) { Core::Runner.new(reviews: UseParenthesesInMethodDefReview.new) }
 
-      it "should find missing parentheses" do
+      it 'should find missing parentheses' do
         content = <<-EOF
         class PostsController < ApplicationController
           def edit foo, bar
@@ -14,9 +14,9 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - use parentheses around parameters in method definitions")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - use parentheses around parameters in method definitions')
       end
-      it "should find parentheses with no error" do
+      it 'should find parentheses with no error' do
         content = <<-EOF
         class PostsController < ApplicationController
           def edit(foo, bar)
@@ -26,7 +26,7 @@ module RailsBestPractices
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(0)
       end
-      it "should not throw an error without parameters" do
+      it 'should not throw an error without parameters' do
         content = <<-EOF
         class PostsController < ApplicationController
           def edit
@@ -37,7 +37,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: UseParenthesesInMethodDefReview.new(ignored_files: /posts_controller/))
                 content = <<-EOF
         class PostsController < ApplicationController

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -28,7 +28,7 @@ module RailsBestPractices
         runner.prepare('db/schema.rb', content)
       end
 
-      it "should use query attribute by blank call" do
+      it 'should use query attribute by blank call' do
         content = <<-EOF
         <% if @user.login.blank? %>
           <%= link_to 'login', new_session_path %>
@@ -36,16 +36,16 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute by blank call with if in one line" do
+      it 'should use query attribute by blank call with if in one line' do
         content = <<-EOF
         <%= link_to 'login', new_session_path if @user.login.blank? %>
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
       it "should use query attribute by blank call with '? :'" do
@@ -54,10 +54,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute by comparing empty string" do
+      it 'should use query attribute by comparing empty string' do
         content = <<-EOF
         <% if @user.login == "" %>
           <%= link_to 'login', new_session_path %>
@@ -65,10 +65,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute by nil call" do
+      it 'should use query attribute by nil call' do
         content = <<-EOF
         <% if @user.login.nil? %>
           <%= link_to 'login', new_session_path %>
@@ -76,10 +76,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute by present call" do
+      it 'should use query attribute by present call' do
         content = <<-EOF
         <% if @user.login.present? %>
           <%= @user.login %>
@@ -87,10 +87,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute within and conditions" do
+      it 'should use query attribute within and conditions' do
         content = <<-EOF
         <% if @user.active? && @user.login.present? %>
           <%= @user.login %>
@@ -98,10 +98,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should use query attribute within or conditions" do
+      it 'should use query attribute within or conditions' do
         content = <<-EOF
         <% if @user.active? or @user.login != "" %>
           <%= @user.login %>
@@ -109,10 +109,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/users/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/users/show.html.erb:1 - use query attribute (@user.login?)")
+        expect(runner.errors[0].to_s).to eq('app/views/users/show.html.erb:1 - use query attribute (@user.login?)')
       end
 
-      it "should not use query attribute" do
+      it 'should not use query attribute' do
         content = <<-EOF
         <% if @user.login? %>
           <%= @user.login %>
@@ -122,7 +122,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not use query attribute for number" do
+      it 'should not use query attribute for number' do
         content =<<-EOF
         <% unless @user.age.blank? %>
           <%= @user.age %>
@@ -132,7 +132,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not review for pluralize attribute" do
+      it 'should not review for pluralize attribute' do
         content = <<-EOF
         <% if @user.roles.blank? %>
           <%= @user.login %>
@@ -142,7 +142,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not review non model class" do
+      it 'should not review non model class' do
         content = <<-EOF
         <% if @person.login.present? %>
           <%= @person.login %>
@@ -152,8 +152,8 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      context "association" do
-        it "should not review belongs_to association" do
+      context 'association' do
+        it 'should not review belongs_to association' do
           content = <<-EOF
           <% if @user.location.present? %>
             <%= @user.location.name %>
@@ -163,7 +163,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not review belongs_to category" do
+        it 'should not review belongs_to category' do
           content = <<-EOF
           <% if @user.category.present? %>
             <%= @user.category.name %>
@@ -173,7 +173,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not review has_one association" do
+        it 'should not review has_one association' do
           content = <<-EOF
           <% if @user.phone.present? %>
             <%= @user.phone.number %>
@@ -183,7 +183,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not review has_many association" do
+        it 'should not review has_many association' do
           content = <<-EOF
           <% if @user.projects.present? %>
             <%= @user.projects.first.name %>
@@ -194,7 +194,7 @@ module RailsBestPractices
         end
       end
 
-      it "should not review for class method" do
+      it 'should not review for class method' do
         content = <<-EOF
         <% if User.name.present? %>
           <%= User.name %>
@@ -204,7 +204,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not review for non attribute call" do
+      it 'should not review for non attribute call' do
         content = <<-EOF
         if @user.login(false).nil?
           puts @user.login(false)
@@ -214,7 +214,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not raise error for common conditional statement" do
+      it 'should not raise error for common conditional statement' do
         content = <<-EOF
         if voteable.is_a? Answer
           puts voteable.title
@@ -223,7 +223,7 @@ module RailsBestPractices
         expect { runner.review('app/models/users_controller.rb', content) }.not_to raise_error
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
                                   reviews: UseQueryAttributeReview.new(ignored_files: /users\/show/))
         content = <<-EOF