rails_best_practices 1.19.0 → 1.19.1

data/spec/rails_best_practices/reviews/default_scope_is_evil_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe DefaultScopeIsEvilReview do
       let(:runner) { Core::Runner.new(reviews: DefaultScopeIsEvilReview.new) }
 
-      it "should detect default_scope with -> syntax" do
+      it 'should detect default_scope with -> syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope -> { order('created_at desc') }
@@ -13,10 +13,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/user.rb:2 - default_scope is evil")
+        expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - default_scope is evil')
       end
 
-      it "should detect default_scope with old syntax" do
+      it 'should detect default_scope with old syntax' do
         content = <<-EOF
         class User < ActiveRecord::Base
           default_scope order('created_at desc')
@@ -24,10 +24,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/user.rb:2 - default_scope is evil")
+        expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - default_scope is evil')
       end
 
-      it "should not detect default_scope" do
+      it 'should not detect default_scope' do
         content = <<-EOF
         class User < ActiveRecord::Base
           scope :default, -> { order('created_at desc') }
@@ -37,7 +37,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: DefaultScopeIsEvilReview.new(ignored_files: /user/))
         content = <<-EOF
         class User < ActiveRecord::Base

data/spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe DryBundlerInCapistranoReview do
       let(:runner) { Core::Runner.new(reviews: DryBundlerInCapistranoReview.new) }
 
-      it "should dry bundler in capistrno" do
+      it 'should dry bundler in capistrno' do
         content = <<-EOF
         namespace :bundler do
           task :create_symlink, roles: :app do
@@ -24,10 +24,10 @@ module RailsBestPractices
         EOF
         runner.review('config/deploy.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/deploy.rb:1 - dry bundler in capistrano")
+        expect(runner.errors[0].to_s).to eq('config/deploy.rb:1 - dry bundler in capistrano')
       end
 
-      it "should not dry bundler in capistrano" do
+      it 'should not dry bundler in capistrano' do
         content = <<-EOF
           require 'bundler/capistrano'
         EOF
@@ -35,7 +35,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: DryBundlerInCapistranoReview.new(ignored_files: /deploy\.rb/))
         content = <<-EOF
         namespace :bundler do

data/spec/rails_best_practices/reviews/hash_syntax_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe HashSyntaxReview do
       let(:runner) { Core::Runner.new(reviews: HashSyntaxReview.new) }
 
-      it "should find 1.8 Hash with symbol" do
+      it 'should find 1.8 Hash with symbol' do
         content =<<-EOF
         class User < ActiveRecord::Base
           CONST = { :foo => :bar }
@@ -13,10 +13,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/user.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/user.rb:2 - change Hash Syntax to 1.9")
+        expect(runner.errors[0].to_s).to eq('app/models/user.rb:2 - change Hash Syntax to 1.9')
       end
 
-      it "should not find 1.8 Hash with string" do
+      it 'should not find 1.8 Hash with string' do
         content =<<-EOF
         class User < ActiveRecord::Base
           CONST = { "foo" => "bar" }
@@ -26,7 +26,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not alert on 1.9 Syntax" do
+      it 'should not alert on 1.9 Syntax' do
         content =<<-EOF
         class User < ActiveRecord::Base
           CONST = { foo: :bar }
@@ -36,7 +36,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should ignore haml_out" do
+      it 'should ignore haml_out' do
         content =<<-EOF
 %div{ class: "foo1" }
 .div{ class: "foo2" }
@@ -46,7 +46,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not consider hash with array key" do
+      it 'should not consider hash with array key' do
         content =<<-EOF
         transition [:unverified, :verified] => :deleted
         EOF
@@ -54,7 +54,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not consider hash with charaters not valid for symbol" do
+      it 'should not consider hash with charaters not valid for symbol' do
         content =<<-EOF
         receiver.stub(:` => 'Error')
         EOF
@@ -62,7 +62,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: HashSyntaxReview.new(ignored_files: /user/))
         content =<<-EOF
         class User < ActiveRecord::Base

data/spec/rails_best_practices/reviews/isolate_seed_data_review_spec.rb

@@ -5,8 +5,8 @@ module RailsBestPractices
     describe IsolateSeedDataReview do
       let(:runner) { Core::Runner.new(reviews: IsolateSeedDataReview.new) }
 
-      context "create" do
-        it "should isolate seed data" do
+      context 'create' do
+        it 'should isolate seed data' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -26,12 +26,12 @@ module RailsBestPractices
           EOF
           runner.review('db/migrate/20090818130258_create_roles.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("db/migrate/20090818130258_create_roles.rb:8 - isolate seed data")
+          expect(runner.errors[0].to_s).to eq('db/migrate/20090818130258_create_roles.rb:8 - isolate seed data')
         end
       end
 
-      context "new and save" do
-        it "should isolate seed data for local variable" do
+      context 'new and save' do
+        it 'should isolate seed data for local variable' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -52,10 +52,10 @@ module RailsBestPractices
           EOF
           runner.review('db/migrate/20090818130258_create_roles.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("db/migrate/20090818130258_create_roles.rb:9 - isolate seed data")
+          expect(runner.errors[0].to_s).to eq('db/migrate/20090818130258_create_roles.rb:9 - isolate seed data')
         end
 
-        it "should isolate seed data for instance variable" do
+        it 'should isolate seed data for instance variable' do
           content = <<-EOF
           class CreateRoles < ActiveRecord::Migration
             def self.up
@@ -76,11 +76,11 @@ module RailsBestPractices
           EOF
           runner.review('db/migrate/20090818130258_create_roles.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("db/migrate/20090818130258_create_roles.rb:9 - isolate seed data")
+          expect(runner.errors[0].to_s).to eq('db/migrate/20090818130258_create_roles.rb:9 - isolate seed data')
         end
       end
 
-      it "should not isolate seed data without data insert" do
+      it 'should not isolate seed data without data insert' do
         content = <<-EOF
         class CreateRoles < ActiveRecord::Migration
           def self.up
@@ -98,7 +98,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: IsolateSeedDataReview.new(ignored_files: /create_roles/))
         content = <<-EOF
           class CreateRoles < ActiveRecord::Migration

data/spec/rails_best_practices/reviews/keep_finders_on_their_own_model_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe KeepFindersOnTheirOwnModelReview do
       let(:runner) { Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new) }
 
-      it "should keep finders on thier own model" do
+      it 'should keep finders on thier own model' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -18,10 +18,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/post.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/post.rb:5 - keep finders on their own model")
+        expect(runner.errors[0].to_s).to eq('app/models/post.rb:5 - keep finders on their own model')
       end
 
-      it "should keep finders on thier own model with all method" do
+      it 'should keep finders on thier own model with all method' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -34,10 +34,10 @@ module RailsBestPractices
         EOF
         runner.review('app/models/post.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/models/post.rb:5 - keep finders on their own model")
+        expect(runner.errors[0].to_s).to eq('app/models/post.rb:5 - keep finders on their own model')
       end
 
-      it "should not keep finders on thier own model with self finder" do
+      it 'should not keep finders on thier own model with self finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -52,7 +52,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not keep finders on thier own model with own finder" do
+      it 'should not keep finders on thier own model with own finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -67,7 +67,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not keep finders on their own model without finder" do
+      it 'should not keep finders on their own model without finder' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -81,7 +81,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not keep finders on their own model with ruby Array#find" do
+      it 'should not keep finders on their own model with ruby Array#find' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           has_many :comments
@@ -95,7 +95,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: KeepFindersOnTheirOwnModelReview.new(ignored_files: /app\/models\/post\.rb/))
         content = <<-EOF
         class Post < ActiveRecord::Base

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe LawOfDemeterReview do
       let(:runner) { Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new], reviews: LawOfDemeterReview.new) }
 
-      describe "belongs_to" do
+      describe 'belongs_to' do
         before(:each) do
           content = <<-EOF
           class Invoice < ActiveRecord::Base
@@ -26,7 +26,7 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it "should law of demeter with erb" do
+        it 'should law of demeter with erb' do
           content = <<-EOF
           <%= @invoice.user.name %>
           <%= @invoice.user.address %>
@@ -34,10 +34,10 @@ module RailsBestPractices
           EOF
           runner.review('app/views/invoices/show.html.erb', content)
           expect(runner.errors.size).to eq(3)
-          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.erb:1 - law of demeter")
+          expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.erb:1 - law of demeter')
         end
 
-        it "should law of demeter with haml" do
+        it 'should law of demeter with haml' do
           content = <<-EOF
 = @invoice.user.name
 = @invoice.user.address
@@ -45,10 +45,10 @@ module RailsBestPractices
           EOF
           runner.review('app/views/invoices/show.html.haml', content)
           expect(runner.errors.size).to eq(3)
-          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.haml:1 - law of demeter")
+          expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.haml:1 - law of demeter')
         end
 
-        it "should law of demeter with slim" do
+        it 'should law of demeter with slim' do
           content = <<-EOF
 = @invoice.user.name
 = @invoice.user.address
@@ -56,10 +56,10 @@ module RailsBestPractices
           EOF
           runner.review('app/views/invoices/show.html.slim', content)
           expect(runner.errors.size).to eq(3)
-          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.slim:1 - law of demeter")
+          expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.slim:1 - law of demeter')
         end
 
-        it "should no law of demeter" do
+        it 'should no law of demeter' do
           content = <<-EOF
           <%= @invoice.user_name %>
           <%= @invoice.user_address %>
@@ -70,7 +70,7 @@ module RailsBestPractices
         end
       end
 
-      describe "has_one" do
+      describe 'has_one' do
         before(:each) do
           content = <<-EOF
           class Invoice < ActiveRecord::Base
@@ -90,18 +90,18 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it "should law of demeter" do
+        it 'should law of demeter' do
           content = <<-EOF
           <%= @invoice.price.currency %>
           <%= @invoice.price.number %>
           EOF
           runner.review('app/views/invoices/show.html.erb', content)
           expect(runner.errors.size).to eq(2)
-          expect(runner.errors[0].to_s).to eq("app/views/invoices/show.html.erb:1 - law of demeter")
+          expect(runner.errors[0].to_s).to eq('app/views/invoices/show.html.erb:1 - law of demeter')
         end
       end
 
-      context "polymorphic association" do
+      context 'polymorphic association' do
         before :each do
           content = <<-EOF
           class Comment < ActiveRecord::Base
@@ -127,17 +127,17 @@ module RailsBestPractices
           runner.prepare('db/schema.rb', content)
         end
 
-        it "should law of demeter" do
+        it 'should law of demeter' do
           content = <<-EOF
           <%= @comment.commentable.title %>
           EOF
           runner.review('app/views/comments/index.html.erb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/views/comments/index.html.erb:1 - law of demeter")
+          expect(runner.errors[0].to_s).to eq('app/views/comments/index.html.erb:1 - law of demeter')
         end
       end
 
-      it "should no law of demeter with method call" do
+      it 'should no law of demeter with method call' do
         content = <<-EOF
         class Question < ActiveRecord::Base
           has_many :answers, dependent: :destroy
@@ -161,7 +161,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(prepares: [Prepares::ModelPrepare.new, Prepares::SchemaPrepare.new],
                                   reviews: LawOfDemeterReview.new(ignored_files: /app\/views\/invoices/))
         content = <<-EOF

data/spec/rails_best_practices/reviews/move_code_into_controller_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe MoveCodeIntoControllerReview do
       let(:runner) { Core::Runner.new(reviews: MoveCodeIntoControllerReview.new) }
 
-      it "should move code into controller for method call" do
+      it 'should move code into controller for method call' do
         content = <<-EOF
         <% Post.find(:all).each do |post| %>
           <%=h post.title %>
@@ -14,10 +14,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/index.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - move code into controller")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
       end
 
-      it "should move code into controller for assign" do
+      it 'should move code into controller for assign' do
         content = <<-EOF
         <% @posts = Post.all %>
         <% @posts.each do |post| %>
@@ -27,10 +27,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/index.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - move code into controller")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
       end
 
-      it "should not move code into controller" do
+      it 'should not move code into controller' do
         content = <<-EOF
         <% @posts.each do |post| %>
           <%=h post.title %>
@@ -41,7 +41,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new(ignored_files: /app\/views\/post/))
         content = <<-EOF
         <% Post.find(:all).each do |post| %>

data/spec/rails_best_practices/reviews/move_code_into_helper_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe MoveCodeIntoHelperReview do
       let(:runner) { Core::Runner.new(reviews: MoveCodeIntoHelperReview.new('array_count' => 2)) }
 
-      it "should move code into helper" do
+      it 'should move code into helper' do
         content = <<-EOF
         <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
                                                     [t(:published), "published"]],
@@ -13,10 +13,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)')
       end
 
-      it "should not move code into helper with simple arguments" do
+      it 'should not move code into helper with simple arguments' do
         content = <<-EOF
         <%= select_tag :state, options_for_select( Post.STATES ) %>
         EOF
@@ -24,7 +24,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: MoveCodeIntoControllerReview.new('array_count' => 2, 'ignored_files' => /app\/views\/post/))
         content = <<-EOF
         <%= select_tag :state, options_for_select( [[t(:draft), "draft"],