rails_best_practices 1.19.0 → 1.19.1

data/spec/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe ReplaceComplexCreationWithFactoryMethodReview do
       let(:runner) { Core::Runner.new(reviews: ReplaceComplexCreationWithFactoryMethodReview.new) }
 
-      it "should replace complex creation with factory method" do
+      it 'should replace complex creation with factory method' do
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create
@@ -26,10 +26,10 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/invoices_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/invoices_controller.rb:2 - replace complex creation with factory method (@invoice attribute_assignment_count > 2)")
+        expect(runner.errors[0].to_s).to eq('app/controllers/invoices_controller.rb:2 - replace complex creation with factory method (@invoice attribute_assignment_count > 2)')
       end
 
-      it "should not replace complex creation with factory method with simple creation" do
+      it 'should not replace complex creation with factory method with simple creation' do
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create
@@ -44,7 +44,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not replace complex creation with factory method when attrasgn_count is 5" do
+      it 'should not replace complex creation with factory method when attrasgn_count is 5' do
         content = <<-EOF
         class InvoiceController < ApplicationController
           def create
@@ -68,7 +68,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: ReplaceComplexCreationWithFactoryMethodReview.new(ignored_files: /invoices_controller/))
         content = <<-EOF
         class InvoiceController < ApplicationController

data/spec/rails_best_practices/reviews/replace_instance_variable_with_local_variable_review_spec.rb

@@ -5,34 +5,34 @@ module RailsBestPractices
     describe ReplaceInstanceVariableWithLocalVariableReview do
       let(:runner) { Core::Runner.new(reviews: ReplaceInstanceVariableWithLocalVariableReview.new) }
 
-      it "should replace instance variable with local varialbe" do
+      it 'should replace instance variable with local varialbe' do
         content = <<-EOF
         <%= @post.title %>
         EOF
         runner.review('app/views/posts/_post.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/_post.html.erb:1 - replace instance variable with local variable")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/_post.html.erb:1 - replace instance variable with local variable')
       end
 
-      it "should replace instance variable with local varialbe in haml file" do
+      it 'should replace instance variable with local varialbe in haml file' do
         content = <<-EOF
 = @post.title
         EOF
         runner.review('app/views/posts/_post.html.haml', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/_post.html.haml:1 - replace instance variable with local variable")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/_post.html.haml:1 - replace instance variable with local variable')
       end
 
-      it "should replace instance variable with local varialbe in slim file" do
+      it 'should replace instance variable with local varialbe in slim file' do
         content = <<-EOF
 = @post.title
         EOF
         runner.review('app/views/posts/_post.html.slim', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/_post.html.slim:1 - replace instance variable with local variable")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/_post.html.slim:1 - replace instance variable with local variable')
       end
 
-      it "should not replace instance variable with local varialbe" do
+      it 'should not replace instance variable with local varialbe' do
         content = <<-EOF
         <%= post.title %>
         EOF
@@ -40,7 +40,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: ReplaceInstanceVariableWithLocalVariableReview.new(ignored_files: /views\/posts/))
         content = <<-EOF
         <%= @post.title %>

data/spec/rails_best_practices/reviews/restrict_auto_generated_routes_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe RestrictAutoGeneratedRoutesReview do
       let(:runner) { Core::Runner.new(prepares: Prepares::ControllerPrepare.new, reviews: RestrictAutoGeneratedRoutesReview.new) }
 
-      describe "resources" do
+      describe 'resources' do
         before :each do
           content =<<-EOF
           class PostsController < ApplicationController
@@ -20,7 +20,7 @@ module RailsBestPractices
           runner.prepare('app/controllers/posts_controller.rb', content)
         end
 
-        it "should restrict auto-generated routes" do
+        it 'should restrict auto-generated routes' do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -28,10 +28,10 @@ module RailsBestPractices
           EOF
           runner.review('config/routes.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
+          expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])')
         end
 
-        it "should not restrict auto-generated routes with only" do
+        it 'should not restrict auto-generated routes with only' do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: %w(show new create edit update destroy)
@@ -41,7 +41,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not restrict auto-generated routes with except" do
+        it 'should not restrict auto-generated routes with except' do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, except: :index
@@ -51,8 +51,8 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        describe "specify a controller" do
-          it "should restrict auto-generated routes" do
+        describe 'specify a controller' do
+          it 'should restrict auto-generated routes' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :articles, controller: "posts"
@@ -60,11 +60,11 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])")
+            expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - restrict auto-generated routes articles (except: [:index])')
           end
         end
 
-        describe "namespace" do
+        describe 'namespace' do
           before do
             content =<<-EOF
             class Admin::CommentsController < ApplicationController
@@ -79,7 +79,7 @@ module RailsBestPractices
             runner.prepare('app/controllers/admin/comments_controller.rb', content)
           end
 
-          it "should restrict auto-generated routes" do
+          it 'should restrict auto-generated routes' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               namespace :admin do
@@ -89,10 +89,10 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])")
+            expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])')
           end
 
-          it "should restrict auto-generated routes with scope :module" do
+          it 'should restrict auto-generated routes with scope :module' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               scope module: :admin do
@@ -102,10 +102,10 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])")
+            expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - restrict auto-generated routes admin/comments (except: [:index])')
           end
 
-          it "should restrict auto-generated routes with resources :module" do
+          it 'should restrict auto-generated routes with resources :module' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :comments, module: :admin
@@ -113,11 +113,11 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes admin/comments (except: [:index])")
+            expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - restrict auto-generated routes admin/comments (except: [:index])')
           end
         end
 
-        describe "nested routes" do
+        describe 'nested routes' do
           before :each do
             content =<<-EOF
             class CommentsController < ApplicationController
@@ -133,7 +133,7 @@ module RailsBestPractices
             runner.prepare('app/controllers/comments_controller.rb', content)
           end
 
-          it "should restrict auto-generated routes" do
+          it 'should restrict auto-generated routes' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :posts do
@@ -143,10 +143,10 @@ module RailsBestPractices
             EOF
             runner.review('config/routes.rb', content)
             expect(runner.errors.size).to eq(1)
-            expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
+            expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])')
           end
 
-          it "should not restrict auto-generated routes with only" do
+          it 'should not restrict auto-generated routes with only' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :posts, only: %w(show new create edit update destroy) do
@@ -158,7 +158,7 @@ module RailsBestPractices
             expect(runner.errors.size).to eq(0)
           end
 
-          it "should not restrict auto-generated routes with except" do
+          it 'should not restrict auto-generated routes with except' do
             content =<<-EOF
             RailsBestPracticesCom::Application.routes.draw do
               resources :posts, except: :index do
@@ -172,7 +172,7 @@ module RailsBestPractices
         end
       end
 
-      describe "resource" do
+      describe 'resource' do
         before :each do
           content =<<-EOF
           class AccountsController < ApplicationController
@@ -186,7 +186,7 @@ module RailsBestPractices
           runner.prepare('app/controllers/accounts_controller.rb', content)
         end
 
-        it "should restrict auto-generated routes" do
+        it 'should restrict auto-generated routes' do
           content =<<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account
@@ -194,10 +194,10 @@ module RailsBestPractices
           EOF
           runner.review('config/routes.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])")
+          expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - restrict auto-generated routes account (except: [:destroy])')
         end
 
-        it "should not restrict auto-generated routes with only" do
+        it 'should not restrict auto-generated routes with only' do
           content =<<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account, only: %w(show new create edit update)
@@ -207,7 +207,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not restrict auto-generated routes with except" do
+        it 'should not restrict auto-generated routes with except' do
           content =<<-EOF
           ActionController::Routing::Routes.draw do |map|
             map.resource :account, except: :destroy
@@ -217,7 +217,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not check ignored files" do
+        it 'should not check ignored files' do
           runner = Core::Runner.new(prepares: Prepares::ControllerPrepare.new,
                                     reviews: RestrictAutoGeneratedRoutesReview.new(ignored_files: /config\/routes\.rb/))
 
@@ -254,7 +254,7 @@ module RailsBestPractices
           runner.prepare('app/controllers/posts_controller.rb', content)
         end
 
-        it "should restrict auto-generated routes" do
+        it 'should restrict auto-generated routes' do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts
@@ -262,10 +262,10 @@ module RailsBestPractices
           EOF
           runner.review('config/routes.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])")
+          expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - restrict auto-generated routes posts (except: [:index])')
         end
 
-        it "should not restrict auto-generated routes with only" do
+        it 'should not restrict auto-generated routes with only' do
           content =<<-EOF
           RailsBestPracticesCom::Application.routes.draw do
             resources :posts, only: %w(show create update destroy)

data/spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb

@@ -5,15 +5,15 @@ module RailsBestPractices
     describe SimplifyRenderInControllersReview do
       let(:runner) { Core::Runner.new(reviews: SimplifyRenderInControllersReview.new) }
 
-      it "should simplify render action view" do
+      it 'should simplify render action view' do
         content =<<-EOF
         def edit
           render action: :edit
         end
         EOF
-        runner.review("app/controllers/posts_controller.rb", content)
+        runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - simplify render in controllers")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - simplify render in controllers')
       end
 
       it "should simplify render actions's template" do
@@ -22,27 +22,27 @@ module RailsBestPractices
           render template: 'books/edit'
         end
         EOF
-        runner.review("app/controllers/posts_controller.rb", content)
+        runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - simplify render in controllers")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - simplify render in controllers')
       end
 
-      it "should simplify render an arbitrary file" do
+      it 'should simplify render an arbitrary file' do
         content =<<-EOF
         def edit
           render file: '/path/to/rails/app/views/books/edit'
         end
         EOF
-        runner.review("app/controllers/posts_controller.rb", content)
+        runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - simplify render in controllers")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - simplify render in controllers')
       end
 
-      it "should not simplify render action view" do
+      it 'should not simplify render action view' do
         content =<<-EOF
         render :edit
         EOF
-        runner.review("app/controllers/posts_controller", content)
+        runner.review('app/controllers/posts_controller', content)
         expect(runner.errors.size).to eq(0)
       end
 
@@ -52,28 +52,28 @@ module RailsBestPractices
           render 'books/edit'
         end
         EOF
-        runner.review("app/controllers/posts_controller.rb", content)
+        runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not simplify render an arbitrary file" do
+      it 'should not simplify render an arbitrary file' do
         content =<<-EOF
         def edit
           render '/path/to/rails/app/views/books/edit'
         end
         EOF
-        runner.review("app/controllers/posts_controller.rb", content)
+        runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: SimplifyRenderInControllersReview.new(ignored_files: /posts_controller/))
         content =<<-EOF
         def edit
           render action: :edit
         end
         EOF
-        runner.review("app/controllers/posts_controller.rb", content)
+        runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(0)
       end
     end

data/spec/rails_best_practices/reviews/simplify_render_in_views_review_spec.rb

@@ -5,43 +5,43 @@ module RailsBestPractices
     describe SimplifyRenderInViewsReview do
       let(:runner) { Core::Runner.new(reviews: SimplifyRenderInViewsReview.new) }
 
-      it "should simplify render simple partial" do
+      it 'should simplify render simple partial' do
         content =<<-EOF
         <%= render partial: 'sidebar' %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - simplify render in views')
       end
 
-      it "should simplify render partial with object" do
+      it 'should simplify render partial with object' do
         content =<<-EOF
         <%= render partial: 'post', object: @post %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - simplify render in views')
       end
 
-      it "should simplify render partial with collection" do
+      it 'should simplify render partial with collection' do
         content =<<-EOF
         <%= render partial: 'posts', collection: @posts %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - simplify render in views')
       end
 
-      it "should simplify render partial with local variables" do
+      it 'should simplify render partial with local variables' do
         content =<<-EOF
         <%= render partial: 'comment', locals: { parent: post } %>
         EOF
         runner.review('app/views/posts/index.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/index.html.erb:1 - simplify render in views")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - simplify render in views')
       end
 
-      it "should not simplify render simple partial" do
+      it 'should not simplify render simple partial' do
         content =<<-EOF
         <%= render 'sidebar' %>
         <%= render 'shared/sidebar' %>
@@ -50,7 +50,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not simplify render partial with object" do
+      it 'should not simplify render partial with object' do
         content =<<-EOF
         <%= render @post %>
         EOF
@@ -58,7 +58,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not simplify render partial with collection" do
+      it 'should not simplify render partial with collection' do
         content =<<-EOF
         <%= render @posts %>
         EOF
@@ -66,7 +66,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not simplify render partial with local variables" do
+      it 'should not simplify render partial with local variables' do
         content =<<-EOF
         <%= render 'comment', parent: post %>
         EOF
@@ -74,7 +74,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not simplify render partial with complex partial" do
+      it 'should not simplify render partial with complex partial' do
         content =<<-EOF
         <%= render partial: 'shared/post', object: @post %>
         EOF
@@ -82,7 +82,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not simplify render partial with layout option" do
+      it 'should not simplify render partial with layout option' do
         content =<<-EOF
         <%= render partial: 'post', layout: 'post' %>
         EOF
@@ -90,7 +90,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: SimplifyRenderInViewsReview.new(ignored_files: /views\/posts\/index/))
         content =<<-EOF
         <%= render partial: 'sidebar' %>