rails_best_practices 1.19.0 → 1.19.1

data/spec/rails_best_practices/reviews/move_code_into_model_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe MoveCodeIntoModelReview do
       let(:runner) { Core::Runner.new(reviews: MoveCodeIntoModelReview.new) }
 
-      it "should move code into model" do
+      it 'should move code into model' do
         content =<<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
@@ -13,36 +13,36 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
       end
 
-      it "should move code into model with haml" do
+      it 'should move code into model with haml' do
         content =<<-EOF
 - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
   = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.haml', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.haml:1 - move code into model (@post use_count > 2)')
       end
 
-      it "should move code into model with slim" do
+      it 'should move code into model with slim' do
         content =<<-EOF
 - if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user))
   = link_to 'Edit this post', edit_post_url(@post)
         EOF
         runner.review('app/views/posts/show.html.slim', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.slim:1 - move code into model (@post use_count > 2)')
       end
 
-      it "should move code into model with if in one line" do
+      it 'should move code into model with if in one line' do
         content =<<-EOF
         <%= link_to 'Edit this post', edit_post_url(@post) if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
       end
 
       it "should move code into model with '? :'" do
@@ -51,10 +51,10 @@ module RailsBestPractices
         EOF
         runner.review('app/views/posts/show.html.erb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)")
+        expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - move code into model (@post use_count > 2)')
       end
 
-      it "should move code into model only review for current if conditional statement" do
+      it 'should move code into model only review for current if conditional statement' do
         content =<<-EOF
         <% if @post.title %>
           <% if @post.user %>
@@ -67,7 +67,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not move code into model" do
+      it 'should not move code into model' do
         content =<<-EOF
         <% if @post.editable_by?(current_user) %>
           <%= link_to 'Edit this post', edit_post_url(@post) %>
@@ -77,7 +77,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not move code into model for multiple calls on same variable node" do
+      it 'should not move code into model for multiple calls on same variable node' do
         content =<<-EOF
         <% if !job.company.blank? && job.company.title? %>
         <% end %>
@@ -86,7 +86,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: MoveCodeIntoModelReview.new(ignored_files: /app\/views\/post/))
         content =<<-EOF
         <% if current_user && @post.user && (current_user == @post.user || @post.editors.include?(current_user)) %>

data/spec/rails_best_practices/reviews/move_finder_to_named_scope_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe MoveFinderToNamedScopeReview do
       let(:runner) { Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new) }
 
-      it "should move finder to named_scope" do
+      it 'should move finder to named_scope' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -21,11 +21,11 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(2)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:3 - move finder to named_scope")
-        expect(runner.errors[1].to_s).to eq("app/controllers/posts_controller.rb:7 - move finder to named_scope")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:3 - move finder to named_scope')
+        expect(runner.errors[1].to_s).to eq('app/controllers/posts_controller.rb:7 - move finder to named_scope')
       end
 
-      it "should not move simple finder" do
+      it 'should not move simple finder' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -42,7 +42,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not move namd_scope" do
+      it 'should not move namd_scope' do
         content = <<-EOF
         class PostsController < ActionController::Base
           def index
@@ -55,7 +55,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not review model file" do
+      it 'should not review model file' do
         content = <<-EOF
         class Post < ActiveRecord::Base
           def published
@@ -73,7 +73,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: MoveFinderToNamedScopeReview.new(ignored_files: /app\/controllers\/posts/))
         content = <<-EOF
         class PostsController < ActionController::Base

data/spec/rails_best_practices/reviews/move_model_logic_into_model_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe MoveModelLogicIntoModelReview do
       let(:runner) { Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new) }
 
-      it "should move model logic into model" do
+      it 'should move model logic into model' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -24,10 +24,10 @@ module RailsBestPractices
         EOF
         runner.review('app/controllers/posts_controller.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)")
+        expect(runner.errors[0].to_s).to eq('app/controllers/posts_controller.rb:2 - move model logic into model (@post use_count > 4)')
       end
 
-      it "should not move model logic into model with simple model calling" do
+      it 'should not move model logic into model with simple model calling' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -43,7 +43,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not move model logic into model with self calling" do
+      it 'should not move model logic into model with self calling' do
         content = <<-EOF
         class PostsController < ApplicationController
           def publish
@@ -59,7 +59,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: MoveModelLogicIntoModelReview.new(ignored_files: /app\/controllers\/posts/))
         content = <<-EOF
         class PostsController < ApplicationController

data/spec/rails_best_practices/reviews/needless_deep_nesting_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe NeedlessDeepNestingReview do
       let(:runner) { Core::Runner.new(reviews: NeedlessDeepNestingReview.new) }
 
-      it "should needless deep nesting" do
+      it 'should needless deep nesting' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -15,10 +15,10 @@ module RailsBestPractices
         EOF
         runner.review('config/routes.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+        expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it "should not needless deep nesting for shallow" do
+      it 'should not needless deep nesting for shallow' do
         content = <<-EOF
         resources :posts, shallow: true do
           resources :comments do
@@ -30,7 +30,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not needless deep nesting for shallow 4 levels" do
+      it 'should not needless deep nesting for shallow 4 levels' do
         content = <<-EOF
         resources :applications, shallow: true, only: [:index, :show, :create] do
           resources :events, only: [:index, :show, :create, :subscribe, :push] do
@@ -44,7 +44,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should needless deep nesting with resource" do
+      it 'should needless deep nesting with resource' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -54,10 +54,10 @@ module RailsBestPractices
         EOF
         runner.review('config/routes.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+        expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it "should needless deep nesting with block node" do
+      it 'should needless deep nesting with block node' do
         content = <<-EOF
         resources :posts do
           resources :comments do
@@ -68,10 +68,10 @@ module RailsBestPractices
         EOF
         runner.review('config/routes.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/routes.rb:3 - needless deep nesting (nested_count > 2)")
+        expect(runner.errors[0].to_s).to eq('config/routes.rb:3 - needless deep nesting (nested_count > 2)')
       end
 
-      it "should no needless deep nesting" do
+      it 'should no needless deep nesting' do
         content = <<-EOF
         resources :posts do
           resources :comments
@@ -86,7 +86,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: NeedlessDeepNestingReview.new(ignored_files: /config\/routes/))
         content = <<-EOF
           map.resources :posts do |post|

data/spec/rails_best_practices/reviews/not_rescue_exception_review_spec.rb

@@ -5,8 +5,8 @@ module RailsBestPractices
     describe NotRescueExceptionReview do
       let(:runner) { Core::Runner.new(reviews: NotRescueExceptionReview.new) }
 
-      describe "not_rescue_exception" do
-        it "should not rescue exception in method rescue with named var" do
+      describe 'not_rescue_exception' do
+        it 'should not rescue exception in method rescue with named var' do
           content =<<-EOF
           def my_method
             do_something
@@ -19,7 +19,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
-        it "should not rescue exception in method rescue without named var" do
+        it 'should not rescue exception in method rescue without named var' do
           content =<<-EOF
           def my_method
             do_something
@@ -32,7 +32,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
-        it "should not rescue exception in block rescue with named var" do
+        it 'should not rescue exception in block rescue with named var' do
           content =<<-EOF
           def my_method
             begin
@@ -47,7 +47,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
-        it "should not rescue exception in block rescue without named var" do
+        it 'should not rescue exception in block rescue without named var' do
           content =<<-EOF
           def my_method
             begin
@@ -62,7 +62,7 @@ module RailsBestPractices
           expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
-        it "should allow rescue implicit StandardError in block rescue without named var" do
+        it 'should allow rescue implicit StandardError in block rescue without named var' do
           content =<<-EOF
           def my_method
             begin
@@ -76,7 +76,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should allow rescue explicit StandardError in block rescue without named var" do
+        it 'should allow rescue explicit StandardError in block rescue without named var' do
           content =<<-EOF
           def my_method
             begin
@@ -90,7 +90,7 @@ module RailsBestPractices
           expect(runner.errors.size).to eq(0)
         end
 
-        it "should not check ignored files" do
+        it 'should not check ignored files' do
           runner = Core::Runner.new(reviews: NotRescueExceptionReview.new(ignored_files: /posts_helper/))
           content =<<-EOF
           def my_method

data/spec/rails_best_practices/reviews/not_use_default_route_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe NotUseDefaultRouteReview do
       let(:runner) { Core::Runner.new(reviews: NotUseDefaultRouteReview.new) }
 
-      it "should not use default route" do
+      it 'should not use default route' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts
@@ -15,10 +15,10 @@ module RailsBestPractices
         EOF
         runner.review('config/routes.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/routes.rb:4 - not use default route")
+        expect(runner.errors[0].to_s).to eq('config/routes.rb:4 - not use default route')
       end
 
-      it "should no not use default route" do
+      it 'should no not use default route' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|
           resources :posts
@@ -28,7 +28,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: NotUseDefaultRouteReview.new(ignored_files: /config\/routes\.rb/))
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do |map|

data/spec/rails_best_practices/reviews/not_use_time_ago_in_words_review_spec.rb

@@ -5,17 +5,17 @@ module RailsBestPractices
     describe NotUseTimeAgoInWordsReview do
       let(:runner) { Core::Runner.new(reviews: NotUseTimeAgoInWordsReview.new) }
 
-      describe "time_ago_in_words" do
-        it "should not use in views" do
+      describe 'time_ago_in_words' do
+        it 'should not use in views' do
           content =<<-EOF
           <%= time_ago_in_words(post.created_at) %>
           EOF
           runner.review('app/views/posts/show.html.erb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - not use time_ago_in_words")
+          expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - not use time_ago_in_words')
         end
 
-        it "should not use in helpers" do
+        it 'should not use in helpers' do
           content =<<-EOF
           def timeago
             content_tag(:p, time_ago_in_words(post.created_at))
@@ -23,21 +23,21 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:2 - not use time_ago_in_words")
+          expect(runner.errors[0].to_s).to eq('app/helpers/posts_helper.rb:2 - not use time_ago_in_words')
         end
       end
 
-      describe "distance_of_time_in_words_to_now" do
-        it "should not use in views" do
+      describe 'distance_of_time_in_words_to_now' do
+        it 'should not use in views' do
           content =<<-EOF
           <%= distance_of_time_in_words_to_now(post.created_at) %>
           EOF
           runner.review('app/views/posts/show.html.erb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/views/posts/show.html.erb:1 - not use time_ago_in_words")
+          expect(runner.errors[0].to_s).to eq('app/views/posts/show.html.erb:1 - not use time_ago_in_words')
         end
 
-        it "should not use in helpers" do
+        it 'should not use in helpers' do
           content =<<-EOF
           def timeago
             content_tag(:p, distance_of_time_in_words_to_now(post.created_at))
@@ -45,11 +45,11 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:2 - not use time_ago_in_words")
+          expect(runner.errors[0].to_s).to eq('app/helpers/posts_helper.rb:2 - not use time_ago_in_words')
         end
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: NotUseTimeAgoInWordsReview.new(ignored_files: /posts_helper/))
         content =<<-EOF
           def timeago

data/spec/rails_best_practices/reviews/overuse_route_customizations_review_spec.rb

@@ -5,7 +5,7 @@ module RailsBestPractices
     describe OveruseRouteCustomizationsReview do
       let(:runner) { Core::Runner.new(reviews: OveruseRouteCustomizationsReview.new) }
 
-      it "should overuse route customizations" do
+      it 'should overuse route customizations' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts do
@@ -23,10 +23,10 @@ module RailsBestPractices
         EOF
         runner.review('config/routes.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
+        expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - overuse route customizations (customize_count > 3)')
       end
 
-      it "should overuse route customizations another way" do
+      it 'should overuse route customizations another way' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts do
@@ -39,10 +39,10 @@ module RailsBestPractices
         EOF
         runner.review('config/routes.rb', content)
         expect(runner.errors.size).to eq(1)
-        expect(runner.errors[0].to_s).to eq("config/routes.rb:2 - overuse route customizations (customize_count > 3)")
+        expect(runner.errors[0].to_s).to eq('config/routes.rb:2 - overuse route customizations (customize_count > 3)')
       end
 
-      it "should not overuse route customizations without customization" do
+      it 'should not overuse route customizations without customization' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts
@@ -52,7 +52,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not overuse route customizations when customize route is only one" do
+      it 'should not overuse route customizations when customize route is only one' do
         content = <<-EOF
         RailsBestpracticesCom::Application.routes.draw do
           resources :posts do
@@ -66,7 +66,7 @@ module RailsBestPractices
         expect(runner.errors.size).to eq(0)
       end
 
-      it "should not check ignored files" do
+      it 'should not check ignored files' do
         runner = Core::Runner.new(reviews: OveruseRouteCustomizationsReview.new(ignored_files: /config\/routes\.rb/))
         content = <<-EOF
           ActionController::Routing::Routes.draw do |map|