rails_admin 0.1.2 → 0.2.0

data/spec/integration/config/list/rails_admin_config_list_spec.rb

@@ -5,7 +5,7 @@ describe "RailsAdmin Config DSL List Section" do
   subject { page }
 
   describe "css hooks" do
-    it "should be present" do
+    it "is present" do
       RailsAdmin.config Team do
         list do
           field :name
@@ -28,7 +28,7 @@ describe "RailsAdmin Config DSL List Section" do
       end
     end
 
-    it "should be configurable per model" do
+    it "is configurable per model" do
       RailsAdmin.config League do
         list do
           items_per_page 1
@@ -43,13 +43,13 @@ describe "RailsAdmin Config DSL List Section" do
 
   describe "items' fields" do
 
-    it "should show all by default" do
+    it "shows all by default" do
       visit index_path(:model_name => "fan")
       expect(all("th").map(&:text).delete_if{|t| /^\n*$/ =~ t }).
         to match_array ["Id", "Created at", "Updated at", "His Name", "Teams"]
     end
 
-    it "should hide some fields on demand with a block" do
+    it "hides some fields on demand with a block" do
       RailsAdmin.config Fan do
         list do
           exclude_fields_if do
@@ -62,7 +62,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "His Name", "Teams"]
     end
 
-    it "should hide some fields on demand with fields list" do
+    it "hides some fields on demand with fields list" do
       RailsAdmin.config Fan do
         list do
           exclude_fields :created_at, :updated_at
@@ -73,7 +73,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "His Name", "Teams"]
     end
 
-    it "should add some fields on demand with a block" do
+    it "adds some fields on demand with a block" do
       RailsAdmin.config Fan do
         list do
           include_fields_if do
@@ -86,7 +86,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "His Name", "Teams"]
     end
 
-    it "should show some fields on demand with fields list, respect ordering and configure them" do
+    it "shows some fields on demand with fields list, respect ordering and configure them" do
       RailsAdmin.config Fan do
         list do
           fields :name, PK_COLUMN do
@@ -101,7 +101,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Modified Id", "Modified His Name"]
     end
 
-    it "should show all fields if asked" do
+    it "shows all fields if asked" do
       RailsAdmin.config Fan do
         list do
           include_all_fields
@@ -114,7 +114,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "Created at", "Updated at", "His Name", "Teams"]
     end
 
-    it "should appear in order defined" do
+    it "appears in order defined" do
       RailsAdmin.config Fan do
         list do
           field :updated_at
@@ -128,7 +128,7 @@ describe "RailsAdmin Config DSL List Section" do
         to eq(["Updated at", "His Name", "Id", "Created at"])
     end
 
-    it "should only list the defined fields if some fields are defined" do
+    it "only lists the defined fields if some fields are defined" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN
@@ -141,7 +141,7 @@ describe "RailsAdmin Config DSL List Section" do
       should have_no_selector("th:nth-child(4).header")
     end
 
-    it "should delegate the label option to the ActiveModel API" do
+    it "delegates the label option to the ActiveModel API" do
       RailsAdmin.config Fan do
         list do
           field :name
@@ -151,7 +151,7 @@ describe "RailsAdmin Config DSL List Section" do
       expect(find("th:nth-child(2)")).to have_content("His Name")
     end
 
-    it "should be renameable" do
+    it "is renameable" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN do
@@ -165,7 +165,7 @@ describe "RailsAdmin Config DSL List Section" do
       expect(find("th:nth-child(3)")).to have_content("His Name")
     end
 
-    it "should be renameable by type" do
+    it "is renameable by type" do
       RailsAdmin.config Fan do
         list do
           fields_of_type :datetime do
@@ -178,8 +178,8 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "Created at (datetime)", "Updated at (datetime)", "His Name", "Teams"]
     end
 
-    it "should be globally renameable by type" do
-      RailsAdmin.config 'Fan' do
+    it "is globally renameable by type" do
+      RailsAdmin.config Fan do
         list do
           fields_of_type :datetime do
             label { "#{label} (datetime)" }
@@ -191,7 +191,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "Created at (datetime)", "Updated at (datetime)", "His Name", "Teams"]
     end
 
-    it "should be sortable by default" do
+    it "is sortable by default" do
       visit index_path(:model_name => "fan")
       should have_selector("th:nth-child(2).header")
       should have_selector("th:nth-child(3).header")
@@ -199,7 +199,7 @@ describe "RailsAdmin Config DSL List Section" do
       should have_selector("th:nth-child(5).header")
     end
 
-    it "should have option to disable sortability" do
+    it "has option to disable sortability" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN do
@@ -213,7 +213,7 @@ describe "RailsAdmin Config DSL List Section" do
       should have_selector("th:nth-child(3).header")
     end
 
-    it "should have option to disable sortability by type" do
+    it "has option to disable sortability by type" do
       RailsAdmin.config Fan do
         list do
           fields_of_type :datetime do
@@ -232,8 +232,8 @@ describe "RailsAdmin Config DSL List Section" do
       should have_no_selector("th:nth-child(5).header")
     end
 
-    it "should have option to disable sortability by type globally" do
-      RailsAdmin.config 'Fan' do
+    it "has option to disable sortability by type globally" do
+      RailsAdmin.config Fan do
         list do
           fields_of_type :datetime do
             sortable false
@@ -251,7 +251,7 @@ describe "RailsAdmin Config DSL List Section" do
       should have_no_selector("th:nth-child(5).header")
     end
 
-    it "should have option to hide fields by type" do
+    it "has option to hide fields by type" do
       RailsAdmin.config Fan do
         list do
           fields_of_type :datetime do
@@ -264,8 +264,8 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "His Name", "Teams"]
     end
 
-    it "should have option to hide fields by type globally" do
-      RailsAdmin.config 'Fan' do
+    it "has option to hide fields by type globally" do
+      RailsAdmin.config Fan do
         list do
           fields_of_type :datetime do
             hide
@@ -277,7 +277,7 @@ describe "RailsAdmin Config DSL List Section" do
         to match_array ["Id", "His Name", "Teams"]
     end
 
-    it "should have option to customize column width" do
+    it "has option to customize column width" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN do
@@ -294,7 +294,7 @@ describe "RailsAdmin Config DSL List Section" do
       expect(find('style')).to have_content("#list td.#{PK_COLUMN}_field")
     end
 
-    it "should have option to customize output formatting" do
+    it "has option to customize output formatting" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN
@@ -313,7 +313,7 @@ describe "RailsAdmin Config DSL List Section" do
       expect(find('tbody tr:nth-child(2) td:nth-child(3)')).to have_content(@fans[0].name.upcase)
     end
 
-    it "should have a simple option to customize output formatting of date fields" do
+    it "has a simple option to customize output formatting of date fields" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN
@@ -329,7 +329,7 @@ describe "RailsAdmin Config DSL List Section" do
       should have_selector("tbody tr:nth-child(1) td:nth-child(4)", :text => /\d{2} \w{3} \d{1,2}:\d{1,2}/)
     end
 
-    it "should have option to customize output formatting of date fields" do
+    it "has option to customize output formatting of date fields" do
       RailsAdmin.config Fan do
         list do
           field PK_COLUMN
@@ -345,7 +345,7 @@ describe "RailsAdmin Config DSL List Section" do
       should have_selector("tbody tr:nth-child(1) td:nth-child(4)", :text => /\d{4}-\d{2}-\d{2}/)
     end
 
-    it "should allow addition of virtual fields (object methods)" do
+    it "allows addition of virtual fields (object methods)" do
       RailsAdmin.config Team do
         list do
           field PK_COLUMN
@@ -397,7 +397,7 @@ describe "RailsAdmin Config DSL List Section" do
       end
     end
 
-    it "should have reverse direction by default" do
+    it "has reverse direction by default" do
       RailsAdmin.config Player do
         list do
           sort_by :created_at
@@ -409,7 +409,7 @@ describe "RailsAdmin Config DSL List Section" do
       end
     end
 
-    it "should allow change default direction" do
+    it "allows change default direction" do
       RailsAdmin.config Player do
         list do
           sort_by :created_at
@@ -423,8 +423,8 @@ describe "RailsAdmin Config DSL List Section" do
     end
   end
 
-  describe 'embedded model', :mongoid => true do
-    it "should not show link to individual object's page" do
+  describe "embedded model", :mongoid => true do
+    it "does not show link to individual object's page" do
       RailsAdmin.config FieldTest do
         list do
           field :embeds

data/spec/integration/config/show/rails_admin_config_show_spec.rb

@@ -22,25 +22,25 @@ describe "RailsAdmin Config DSL Show Section" do
     let(:uri) { show_path(:model_name => 'player', :id => @player.id, :format => :json) }
     let(:body) { page.body }
 
-    it 'should create a JSON uri' do
+    it "creates a JSON uri" do
       expect(uri).to eq("/admin/player/#{@player.id}.json")
     end
 
-    it 'should contain the JSONified object' do
+    it "contains the JSONified object" do
       expect(body).to include(@player.to_json)
     end
   end
 
   describe "compact_show_view" do
 
-    it 'should hide empty fields in show view by default' do
+    it "hides empty fields in show view by default" do
       @player = FactoryGirl.create :player
       visit show_path(:model_name => "league", :id => @player.id)
       should_not have_css(".born_on_field")
     end
 
 
-    it 'should be disactivable' do
+    it "is disactivable" do
       RailsAdmin.config do |c|
         c.compact_show_view = false
       end
@@ -52,14 +52,14 @@ describe "RailsAdmin Config DSL Show Section" do
   end
 
   describe "css hooks" do
-    it "should be present" do
+    it "is present" do
       do_request
       should have_selector("dt.name_field.string_type")
     end
   end
 
   describe "field groupings" do
-    it "should be hideable" do
+    it "is hideable" do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -80,7 +80,7 @@ describe "RailsAdmin Config DSL Show Section" do
       end
     end
 
-    it "should hide association groupings by the name of the association" do
+    it "hides association groupings by the name of the association" do
       RailsAdmin.config Team do
         show do
           group :players do
@@ -94,7 +94,7 @@ describe "RailsAdmin Config DSL Show Section" do
       should_not have_selector("h4", :text => "Players")
     end
 
-    it "should be renameable" do
+    it "is renameable" do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -108,7 +108,7 @@ describe "RailsAdmin Config DSL Show Section" do
       should have_selector("h4", :text => "Renamed group")
     end
 
-    it "should have accessor for its fields" do
+    it "has accessor for its fields" do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -132,7 +132,7 @@ describe "RailsAdmin Config DSL Show Section" do
       should have_selector(".division_field")
     end
 
-    it "should have accessor for its fields by type" do
+    it "has accessor for its fields by type" do
       RailsAdmin.config Team do
         show do
           group :default do
@@ -162,7 +162,7 @@ describe "RailsAdmin Config DSL Show Section" do
 
   describe "items' fields" do
 
-    it "should show all by default" do
+    it "shows all by default" do
       do_request
 
       %w[division name logo_url manager
@@ -173,7 +173,7 @@ describe "RailsAdmin Config DSL Show Section" do
       end
     end
 
-    it "should only show the defined fields and appear in order defined" do
+    it "only shows the defined fields and appear in order defined" do
       RailsAdmin.config Team do
         show do
           field :manager
@@ -190,7 +190,7 @@ describe "RailsAdmin Config DSL Show Section" do
     end
 
 
-    it "should delegates the label option to the ActiveModel API" do
+    it "delegates the label option to the ActiveModel API" do
       RailsAdmin.config Team do
         show do
           field :manager
@@ -204,7 +204,7 @@ describe "RailsAdmin Config DSL Show Section" do
       should have_selector(".label", :text => "Some Fans")
     end
 
-    it "should be renameable" do
+    it "is renameable" do
       RailsAdmin.config Team do
         show do
           field :manager do
@@ -222,7 +222,7 @@ describe "RailsAdmin Config DSL Show Section" do
       should have_selector(".label", :text => "Name")
     end
 
-    it "should be renameable by type" do
+    it "is renameable by type" do
       RailsAdmin.config Team do
         show do
           fields_of_type :string do
@@ -241,8 +241,8 @@ describe "RailsAdmin Config DSL Show Section" do
       end
     end
 
-    it "should be globally renameable by type" do
-      RailsAdmin.config 'Team' do
+    it "is globally renameable by type" do
+      RailsAdmin.config Team do
         show do
           fields_of_type :string do
             label { "#{label} (STRING)" }
@@ -260,7 +260,7 @@ describe "RailsAdmin Config DSL Show Section" do
       end
     end
 
-    it "should be hideable" do
+    it "is hideable" do
       RailsAdmin.config Team do
         show do
           field :manager do
@@ -277,7 +277,7 @@ describe "RailsAdmin Config DSL Show Section" do
       should have_selector(".name_field")
     end
 
-    it "should be hideable by type" do
+    it "is hideable by type" do
       RailsAdmin.config Team do
         show do
           fields_of_type :string do
@@ -297,8 +297,8 @@ describe "RailsAdmin Config DSL Show Section" do
       end
     end
 
-    it "should be globally hideable by type" do
-      RailsAdmin.config 'Team' do
+    it "is globally hideable by type" do
+      RailsAdmin.config Team do
         show do
           fields_of_type :string do
             hide
@@ -318,8 +318,8 @@ describe "RailsAdmin Config DSL Show Section" do
     end
   end
 
-  describe 'embedded model', :mongoid => true do
-    it "should not show link to individual object's page" do
+  describe "embedded model", :mongoid => true do
+    it "does not show link to individual object's page" do
       @record = FactoryGirl.create :field_test
       2.times.each{|i| @record.embeds.create :name => "embed #{i}"}
       visit show_path(:model_name => "field_test", :id => @record.id)

data/spec/integration/history/rails_admin_history_spec.rb

@@ -12,13 +12,13 @@ describe "RailsAdmin History", :active_record => true do
       end
     end
 
-    it "should fetch one page of history" do
+    it "fetches on page of history" do
       histories = RailsAdmin::History.history_for_model @model, nil, false, false, false, nil, 20
       expect(histories.total_count).to eq(30)
       expect(histories.count).to eq(20)
     end
 
-    it "should respect RailsAdmin::Config.default_items_per_page" do
+    it "respects RailsAdmin::Config.default_items_per_page" do
       RailsAdmin.config.default_items_per_page = 15
       histories = RailsAdmin::History.history_for_model @model, nil, false, false, false, nil
       expect(histories.total_count).to eq(30)
@@ -54,7 +54,7 @@ describe "RailsAdmin History", :active_record => true do
       # https://github.com/sferik/rails_admin/issues/362
       # test that no link uses the "wildcard route" with the history
       # controller and for_model method
-      it "should not use the 'wildcard route'" do
+      it "does not use the 'wildcard route'" do
         expect(page).to have_selector("a[href*='all=true']") # make sure we're fully testing pagination
         expect(page).to have_no_selector("a[href^='/rails_admin/history/for_model']")
       end
@@ -68,17 +68,17 @@ describe "RailsAdmin History", :active_record => true do
           end
         end
 
-        it 'should get latest ones' do
+        it "gets latest ones" do
           expect(RailsAdmin::History.latest.count).to eq(100)
         end
 
-        it 'should get latest ones orderly' do
+        it "gets latest ones orderly" do
           latest = RailsAdmin::History.latest
           expect(latest.first.message).to eq("change 100")
           expect(latest.last.message).to eq("change 1")
         end
 
-        it "should render a XHR request successfully" do
+        it "renders a XHR request successfully" do
           xhr :get, history_index_path(@model, :page => 2)
         end
       end