rails_admin 0.1.2 → 0.2.0

data/spec/integration/rails_admin_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
-describe "RailsAdmin" do
+describe RailsAdmin do
 
   subject { page }
 
   describe "authentication" do
-    it "should be disableable" do
+    it "is disableable" do
       logout
       RailsAdmin.config do |config|
         config.authenticate_with {}
@@ -18,7 +18,7 @@ describe "RailsAdmin" do
   # root key from en to their own locale (as people tend to use the English
   # file as template for a new translation).
   describe "localization" do
-    it "should default to English" do
+    it "defaults to English" do
       visit dashboard_path
 
       should have_content("Site administration")
@@ -31,16 +31,16 @@ describe "RailsAdmin" do
 
     # Note: the [href^="/asset... syntax matches the start of a value. The reason
     # we just do that is to avoid being confused by rails' asset_ids.
-    it "should load stylesheets in header" do
+    it "loads stylesheets in header" do
       should have_selector('head link[href^="/assets/rails_admin/rails_admin.css"]')
     end
 
-    it "should load javascript files in body" do
+    it "loads javascript files in body" do
       should have_selector('head script[src^="/assets/rails_admin/rails_admin.js"]')
     end
   end
 
-  describe 'hidden fields with default values' do
+  describe "hidden fields with default values" do
 
     before (:each) do
       RailsAdmin.config Player do
@@ -55,24 +55,24 @@ describe "RailsAdmin" do
       end
     end
 
-    it "should show up with default value, hidden" do
+    it "shows up with default value, hidden" do
       visit new_path(:model_name => "player")
       should have_selector("#player_name[type=hidden][value='username@example.com']")
       should_not have_selector("#player_name[type=hidden][value='toto@example.com']")
     end
 
-    it "should not show label" do
+    it "does not show label" do
       should_not have_selector("label", :text => "Name")
     end
 
-    it "should not show help block" do
+    it "does not show help block" do
       should_not have_xpath("id('player_name')/../p[@class='help-block']")
     end
   end
 
-  describe '_current_user' do # https://github.com/sferik/rails_admin/issues/549
+  describe "_current_user" do # https://github.com/sferik/rails_admin/issues/549
 
-    it 'should be accessible from the list view' do
+    it "is accessible from the list view" do
       RailsAdmin.config Player do
         list do
           field :name do
@@ -101,20 +101,20 @@ describe "RailsAdmin" do
       @comment = FactoryGirl.create :comment, :commentable => @team
     end
 
-    it "should work like belongs to associations in the list view" do
+    it "works like belongs to associations in the list view" do
       visit index_path(:model_name => "comment")
 
       should have_content(@team.name)
     end
 
-    it "should be editable" do
+    it "is editable" do
       visit edit_path(:model_name => "comment", :id => @comment.id)
 
       should have_selector("select#comment_commentable_type")
       should have_selector("select#comment_commentable_id")
     end
 
-    it "should be visible in the owning end" do
+    it "is visible in the owning end" do
       visit edit_path(:model_name => "team", :id => @team.id)
 
       should have_selector("select#team_comment_ids")
@@ -122,18 +122,18 @@ describe "RailsAdmin" do
   end
 
   describe "secondary navigation" do
-    it "should have Gravatar image" do
+    it "has Gravatar image" do
       visit dashboard_path
       should have_selector("ul.nav.pull-right li img")
     end
 
-    it "should not show Gravatar when user doesn't have email method" do
+    it "does not show Gravatar when user doesn't have email method" do
       User.any_instance.stub(:respond_to?).with(:email).and_return(false)
       visit dashboard_path
       should_not have_selector("ul.nav.pull-right li img")
     end
 
-    it "should not cause error when email is nil" do
+    it "does not cause error when email is nil" do
       User.any_instance.stub(:email).and_return(nil)
       visit dashboard_path
       should have_selector("body.rails_admin")

data/spec/integration/relation_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'table relations' do
+describe "table relations" do
 
   before(:each) do
     class RelTest < Tableless
@@ -15,20 +15,20 @@ describe 'table relations' do
     @fields = RailsAdmin.config(RelTest).create.fields
   end
 
-  describe 'column with nullable fk and no model validations' do
-    it 'should be optional' do
+  describe "column with nullable fk and no model validations" do
+    it "is optional" do
       expect(@fields.find{ |f| f.name == :league }.required?).to be_false
     end
   end
 
-  describe 'column with non-nullable fk and no model validations' do
-    it 'should not be required' do
+  describe "column with non-nullable fk and no model validations" do
+    it "is not required" do
       expect(@fields.find{ |f| f.name == :division }.required?).to be_false
     end
   end
 
-  describe 'column with nullable fk and a numericality model validation' do
-    it 'should be required' do
+  describe "column with nullable fk and a numericality model validation" do
+    it "is required" do
       expect(@fields.find{ |f| f.name == :player }.required?).to be_true
     end
   end

data/spec/unit/abstract_model_spec.rb

@@ -1,13 +1,19 @@
 require 'spec_helper'
 
 describe RailsAdmin::AbstractModel do
-  describe 'filters' do
+  describe "filters" do
     before do
       @abstract_model = RailsAdmin::AbstractModel.new('FieldTest')
     end
+    
+    context "ActiveModel::ForbiddenAttributesProtection" do
+      it "is present" do
+        @abstract_model.model.ancestors.map(&:to_s).include?('ActiveModel::ForbiddenAttributesProtection')
+      end
+    end
 
-    context 'on dates' do
-      it 'lists elements within outbound limits' do
+    context "on dates" do
+      it "lists elements within outbound limits" do
         date_format = I18n.t("admin.misc.filter_date_format", :default => I18n.t("admin.misc.filter_date_format", :locale => :en)).gsub('dd', '%d').gsub('mm', '%m').gsub('yy', '%Y')
 
         FactoryGirl.create(:field_test, :date_field => Date.strptime("01/01/2012", date_format))
@@ -23,8 +29,8 @@ describe RailsAdmin::AbstractModel do
       end
     end
 
-    context 'on datetimes' do
-      it 'lists elements within outbound limits' do
+    context "on datetimes" do
+      it "lists elements within outbound limits" do
         FactoryGirl.create(:field_test, :datetime_field => Time.local(2012, 1, 1, 23, 59, 59))
         FactoryGirl.create(:field_test, :datetime_field => Time.local(2012, 1, 2, 0, 0, 0))
         FactoryGirl.create(:field_test, :datetime_field => Time.local(2012, 1, 3, 23, 59, 59))

data/spec/unit/active_record_extension_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 require File.expand_path('../../../config/initializers/active_record_extensions', __FILE__)
 
-describe 'ActiveRecord::Base', :active_record => true do
-  describe '#safe_send' do
+describe "ActiveRecord::Base", :active_record => true do
+  describe "#safe_send" do
     it "only calls #read_attribute once" do
       @player = Player.new
       @player.number = 23

data/spec/unit/adapters/active_record/abstract_object_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
-describe "AbstractObject", :active_record => true do
+describe "RailsAdmin::Adapters::ActiveRecord::AbstractObject", :active_record => true do
   describe "proxy" do
     let(:object) { mock("object") }
     let(:abstract_object) { RailsAdmin::Adapters::ActiveRecord::AbstractObject.new(object) }
 
-    it "should act like a proxy" do
+    it "acts like a proxy" do
       object.should_receive(:method_call)
       abstract_object.method_call
     end
@@ -24,7 +24,7 @@ describe "AbstractObject", :active_record => true do
         object.set_attributes({ :name => name, :number => number, :position => position, :suspended => suspended, :team_id => nil })
       end
 
-      it "should create a Player with given attributes" do
+      it "creates a Player with given attributes" do
         expect(object.save).to be_true
 
         player.reload
@@ -45,7 +45,7 @@ describe "AbstractObject", :active_record => true do
         object.set_attributes({ :name => name, :number => number, :position => position, :suspended => suspended, :team_id => nil, :draft_id => draft.id })
       end
 
-      it "should create a Player with given attributes" do
+      it "creates a Player with given attributes" do
         expect(object.save).to be_true
 
         player.reload
@@ -69,7 +69,7 @@ describe "AbstractObject", :active_record => true do
         object.set_attributes({ :name  => name, :division_ids => divisions.map(&:id) })
       end
 
-      it "should create a League with given attributes and associations" do
+      it "creates a League with given attributes and associations" do
         expect(object.save).to be_true
         league.reload
         expect(league.name).to eq(name)
@@ -94,7 +94,7 @@ describe "AbstractObject", :active_record => true do
         object.save
       end
 
-      it "should update a record and associations" do
+      it "updates a record and associations" do
         object.reload
         expect(object.number).to eq(new_number)
         expect(object.name).to eq(name)
@@ -113,13 +113,13 @@ describe "AbstractObject", :active_record => true do
       object.destroy
     end
 
-    it "should delete the record" do
+    it "deletes the record" do
       expect(Player.exists?(player.id)).to be_false
     end
   end
 
   describe "object_label_method" do
-    it 'should be configurable' do
+    it "is configurable" do
       RailsAdmin.config League do
         object_label_method { :custom_name }
       end

data/spec/unit/adapters/active_record_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 require 'timecop'
 
-describe 'RailsAdmin::Adapters::ActiveRecord', :active_record => true do
+describe "RailsAdmin::Adapters::ActiveRecord", :active_record => true do
   before do
     @like = ::ActiveRecord::Base.configurations[Rails.env]['adapter'] == "postgresql" ? 'ILIKE' : 'LIKE'
   end
 
-  describe '#associations' do
+  describe "#associations" do
     before :all do
       RailsAdmin::AbstractModel.reset_polymorphic_parents
 
@@ -49,11 +49,11 @@ describe 'RailsAdmin::Adapters::ActiveRecord', :active_record => true do
       RailsAdmin::AbstractModel.reset_polymorphic_parents
     end
 
-    it 'lists associations' do
+    it "lists associations" do
       expect(@post.associations.map{|a|a[:name].to_s}).to match_array ['a_r_blog', 'a_r_categories', 'a_r_comments']
     end
 
-    it 'list associations types in supported [:belongs_to, :has_and_belongs_to_many, :has_many, :has_one]' do
+    it "list associations types in supported [:belongs_to, :has_and_belongs_to_many, :has_many, :has_one]" do
       expect((@post.associations + @blog.associations + @user.associations).map{|a|a[:type]}.uniq.map(&:to_s)).to match_array ['belongs_to', 'has_and_belongs_to_many', 'has_many', 'has_one']
     end
 
@@ -339,14 +339,14 @@ describe 'RailsAdmin::Adapters::ActiveRecord', :active_record => true do
     end
 
 
-    it 'supports date type query' do
+    it "supports date type query" do
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["", "01/02/2012", "01/03/2012"], :o => 'between' } } })).to eq(["((field_tests.date_field BETWEEN ? AND ?))", Date.new(2012,1,2), Date.new(2012,1,3)])
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["", "01/03/2012", ""], :o => 'between' } } } )).to eq(["((field_tests.date_field >= ?))", Date.new(2012,1,3)])
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["", "", "01/02/2012"], :o => 'between' } } } )).to eq(["((field_tests.date_field <= ?))", Date.new(2012,1,2)])
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["01/02/2012"], :o => 'default' } } } )).to eq(["((field_tests.date_field BETWEEN ? AND ?))", Date.new(2012,1,2), Date.new(2012,1,2)])
     end
 
-    it 'supports datetime type query' do
+    it "supports datetime type query" do
       expect(@abstract_model.send(:filter_conditions, { "datetime_field" => { "1" => { :v => ["", "01/02/2012", "01/03/2012"], :o => 'between' } } } )).to eq(["((field_tests.datetime_field BETWEEN ? AND ?))", Time.local(2012,1,2), Time.local(2012,1,3).end_of_day])
       expect(@abstract_model.send(:filter_conditions, { "datetime_field" => { "1" => { :v => ["", "01/03/2012", ""], :o => 'between' } } } )).to eq(["((field_tests.datetime_field >= ?))", Time.local(2012,1,3)])
       expect(@abstract_model.send(:filter_conditions, { "datetime_field" => { "1" => { :v => ["", "", "01/02/2012"], :o => 'between' } } } )).to eq(["((field_tests.datetime_field <= ?))", Time.local(2012,1,2).end_of_day])

data/spec/unit/adapters/mongoid/abstract_object_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'rails_admin/adapters/mongoid/abstract_object'
 
-describe "Mongoid::AbstractObject", :mongoid => true do
+describe "RailsAdmin::Adapters::Mongoid::AbstractObject", :mongoid => true do
   before(:each) do
     @players = FactoryGirl.create_list :player, 3
     @team = RailsAdmin::Adapters::Mongoid::AbstractObject.new FactoryGirl.create :team

data/spec/unit/adapters/mongoid_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 require 'timecop'
 
-describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
-  describe '#associations' do
+describe "RailsAdmin::Adapters::Mongoid", :mongoid => true do
+  describe "#associations" do
     before :all do
       RailsAdmin::AbstractModel.reset_polymorphic_parents
 
@@ -67,11 +67,11 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
       RailsAdmin::AbstractModel.reset_polymorphic_parents
     end
 
-    it 'lists associations' do
+    it "lists associations" do
       expect(@post.associations.map{|a| a[:name]}).to match_array [:mongo_blog, :mongo_categories, :mongo_comments, :mongo_note]
     end
 
-    it 'reads correct and know types in [:belongs_to, :has_and_belongs_to_many, :has_many, :has_one]' do
+    it "reads correct and know types in [:belongs_to, :has_and_belongs_to_many, :has_many, :has_one]" do
       expect((@post.associations + @blog.associations + @user.associations).map{|a|a[:type].to_s}.uniq).to match_array ['belongs_to', 'has_and_belongs_to_many', 'has_many', 'has_one']
     end
 
@@ -114,7 +114,7 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
       expect(@post.properties.find{|f| f[:name] == :mongo_blog_id}[:type]).to eq(:bson_object_id)
     end
 
-    it "should not confuse foreign_key column which belongs to associated model" do
+    it "does not confuse foreign_key column which belongs to associated model" do
       expect(@blog.properties.find{|f| f[:name] == :mongo_blog_id}[:type]).to eq(:string)
     end
 
@@ -215,7 +215,7 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
       expect(param[:model_proc].call).to eq(MongoNote)
     end
 
-    it "should raise error when embeds_* is used without accepts_nested_attributes_for" do
+    it "raises error when embeds_* is used without accepts_nested_attributes_for" do
       class MongoEmbedsOne
         include Mongoid::Document
         embeds_one :mongo_embedded
@@ -240,7 +240,7 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
       )
     end
 
-    it "should work with inherited embeds_many model" do
+    it "works with inherited embeds_many model" do
       class MongoEmbedsParent
         include Mongoid::Document
         embeds_many :mongo_embeddeds
@@ -407,7 +407,7 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
       expect(RailsAdmin::AbstractModel.new('LengthValiated').send(:length_validation_lookup, :text)).to eq(50)
     end
 
-    it "should not cause problem with custom validators" do
+    it "does not cause problem with custom validators" do
       class MyCustomValidator < ActiveModel::Validator
         def validate(r); end
       end
@@ -693,14 +693,14 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
       expect(@abstract_model.send(:build_statement, :field, :string, "foo", "is")).to eq({:field => 'foo'})
     end
 
-    it 'supports date type query' do
+    it "supports date type query" do
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["", "01/02/2012", "01/03/2012"], :o => 'between' } } })).to eq({"$and" => [{"date_field" => {"$gte" => Date.new(2012,1,2), "$lte" => Date.new(2012,1,3)}}]})
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["", "01/03/2012", ""], :o => 'between' } } } )).to eq({"$and" => [{"date_field" => {"$gte" => Date.new(2012,1,3)}}]})
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["", "", "01/02/2012"], :o => 'between' } } } )).to eq({"$and" => [{"date_field" => {"$lte" => Date.new(2012,1,2)}}]})
       expect(@abstract_model.send(:filter_conditions, { "date_field" => { "1" => { :v => ["01/02/2012"], :o => 'default' } } } )).to eq({"$and" => [{"date_field" => {"$gte" => Date.new(2012,1,2), "$lte" => Date.new(2012,1,2)}}]})
     end
 
-    it 'supports datetime type query' do
+    it "supports datetime type query" do
       expect(@abstract_model.send(:filter_conditions, { "datetime_field" => { "1" => { :v => ["", "01/02/2012", "01/03/2012"], :o => 'between' } } } )).to eq({"$and" => [{"datetime_field" => {"$gte" => Time.local(2012,1,2), "$lte" => Time.local(2012,1,3).end_of_day}}]})
       expect(@abstract_model.send(:filter_conditions, { "datetime_field" => { "1" => { :v => ["", "01/03/2012", ""], :o => 'between' } } } )).to eq({"$and" => [{"datetime_field" => {"$gte" => Time.local(2012,1,3)}}]})
       expect(@abstract_model.send(:filter_conditions, { "datetime_field" => { "1" => { :v => ["", "", "01/02/2012"], :o => 'between' } } } )).to eq({"$and" => [{"datetime_field" => {"$lte" => Time.local(2012,1,2).end_of_day}}]})
@@ -733,13 +733,13 @@ describe 'RailsAdmin::Adapters::Mongoid', :mongoid => true do
     end
 
     it "accepts array value" do
-      params = {:array_field => '[1, 3]'}
+      params = HashWithIndifferentAccess.new({:array_field => '[1, 3]'})
       @controller.send(:sanitize_params_for!, 'create', @abstract_model.config, params)
       expect(params[:array_field]).to eq([1, 3])
     end
 
     it "accepts hash value" do
-      params = {:hash_field => '{a: 1, b: 3}'}
+      params = HashWithIndifferentAccess.new({:hash_field => '{a: 1, b: 3}'})
       @controller.send(:sanitize_params_for!, 'create', @abstract_model.config, params)
       expect(params[:hash_field]).to eq({"a" => 1, "b" => 3})
     end

data/spec/unit/config/actions/base_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe RailsAdmin::Config::Actions::Base do
 
   describe "#visible?" do
-    it 'should exclude models not referenced in the only array' do
+    it "excludes models not referenced in the only array" do
       RailsAdmin.config do |config|
         config.actions do
           index do
@@ -16,7 +16,7 @@ describe RailsAdmin::Config::Actions::Base do
       expect(RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Cms::BasicPage)})).to be_visible
     end
     
-    it 'should exclude models referenced in the except array' do
+    it "excludes models referenced in the except array" do
       RailsAdmin.config do |config|
         config.actions do
           index do

data/spec/unit/config/actions_spec.rb

@@ -3,13 +3,13 @@ require 'spec_helper'
 describe RailsAdmin::Config::Actions do
 
   describe "default" do
-    it 'should be as before' do
+    it "is as before" do
       expect(RailsAdmin::Config::Actions.all.map(&:key)).to eq([:dashboard, :index, :show, :new, :edit, :export, :delete, :bulk_delete, :history_show, :history_index, :show_in_app])
     end
   end
 
-  describe 'find' do
-    it 'should find by custom key' do
+  describe "find" do
+    it "finds by custom key" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard do
@@ -27,11 +27,11 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.find(:show)).to be_a(RailsAdmin::Config::Actions::Show)
     end
 
-    it 'should return nil when no action is found by the custom key' do
+    it "returns nil when no action is found by the custom key" do
       expect(RailsAdmin::Config::Actions.find(:non_existent_action_key)).to be_nil
     end
 
-    it 'should return visible action passing binding if controller binding is given, and pass action visible or not if no' do
+    it "returns visible action passing binding if controller binding is given, and pass action visible or not if no" do
       RailsAdmin.config do |config|
         config.actions do
           root :custom_root do
@@ -46,7 +46,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.find(:custom_root, {:controller => "controller"})).to be_a(RailsAdmin::Config::Actions::Base)
     end
 
-    it 'should check bindings[:abstract_model] visibility while checking action\'s visibility' do
+    it "checks bindings[:abstract_model] visibility while checking action\'s visibility" do
       RailsAdmin.config Team do
         hide
       end
@@ -55,7 +55,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.find(:index, {:controller => double(:authorized? => true), :abstract_model => RailsAdmin::AbstractModel.new(Team)})).to be_nil
     end
 
-    it 'should check bindings[:abstract_model] presence while checking action\'s visibility' do
+    it "checks bindings[:abstract_model] presence while checking action\'s visibility" do
       RailsAdmin.config do |config|
         config.excluded_models << Team
       end
@@ -64,8 +64,8 @@ describe RailsAdmin::Config::Actions do
     end
   end
 
-  describe 'all' do
-    it 'should return all defined actions' do
+  describe "all" do
+    it "returns all defined actions" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard
@@ -76,7 +76,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.all.map(&:key)).to eq([:dashboard, :index])
     end
 
-    it 'should restrict by scope' do
+    it "restricts by scope" do
       RailsAdmin.config do |config|
         config.actions do
           root :custom_root
@@ -89,7 +89,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.all(:member).map(&:key)).to eq([:custom_member])
     end
 
-    it 'should return all visible actions passing binding if controller binding is given, and pass all actions if no' do
+    it "returns all visible actions passing binding if controller binding is given, and pass all actions if no" do
       RailsAdmin.config do |config|
         config.actions do
           root :custom_root do
@@ -106,7 +106,7 @@ describe RailsAdmin::Config::Actions do
   end
 
   describe "customized through DSL" do
-    it 'should add the one asked' do
+    it "adds the one asked" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard
@@ -118,7 +118,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.all.map(&:key)).to eq([:dashboard, :index, :show])
     end
 
-    it 'should allow to customize the custom_key when customizing an existing action' do
+    it "allows to customize the custom_key when customizing an existing action" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard do
@@ -130,7 +130,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.all.map(&:key)).to eq([:dashboard])
     end
 
-    it 'should allow to change the key and the custom_key when "subclassing" an existing action' do
+    it "allows to change the key and the custom_key when subclassing an existing action" do
       RailsAdmin.config do |config|
         config.actions do
           root :my_dashboard_key, :dashboard do
@@ -143,7 +143,7 @@ describe RailsAdmin::Config::Actions do
       expect(RailsAdmin::Config::Actions.all.map(&:class)).to eq([RailsAdmin::Config::Actions::Dashboard])
     end
 
-    it 'should not add the same custom_key twice' do
+    it "does not add the same custom_key twice" do
       expect do
         RailsAdmin.config do |config|
           config.actions do
@@ -163,7 +163,7 @@ describe RailsAdmin::Config::Actions do
       end.to raise_error("Action index already exist. Please change its custom key")
     end
 
-    it 'should add the same key with different custom key' do
+    it "adds the same key with different custom key" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard