rails_admin 0.1.2 → 0.2.0

data/spec/unit/config/fields/base_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe RailsAdmin::Config::Fields::Base do
 
   describe "#required" do
-    it "should read the :on => :create/:update validate option" do
+    it "reads the :on => :create/:update validate option" do
       RailsAdmin.config Ball do
         field 'color'
       end
@@ -14,7 +14,7 @@ describe RailsAdmin::Config::Fields::Base do
   end
 
   describe "#name" do
-    it 'should be normalized to Symbol' do
+    it "is normalized to Symbol" do
       RailsAdmin.config Team do
         field 'name'
       end
@@ -30,19 +30,19 @@ describe RailsAdmin::Config::Fields::Base do
         [:commentable_id, :commentable_type]
       end
 
-    it 'should be empty by default' do
+    it "is empty by default" do
       expect(RailsAdmin.config(Team).fields.find{ |f| f.name == :name }.children_fields).to eq([])
     end
 
-    it 'should contain child key for belongs to associations' do
+    it "contains child key for belongs to associations" do
       expect(RailsAdmin.config(Team).fields.find{ |f| f.name == :division }.children_fields).to eq([:division_id])
     end
 
-    it 'should contain child keys for polymorphic belongs to associations' do
+    it "contains child keys for polymorphic belongs to associations" do
       expect(RailsAdmin.config(Comment).fields.find{ |f| f.name == :commentable }.children_fields).to match_array POLYMORPHIC_CHILDREN
     end
 
-    it "should have correct fields when polymorphic_type column comes ahead of polymorphic foreign_key column" do
+    it "has correct fields when polymorphic_type column comes ahead of polymorphic foreign_key column" do
       class CommentReversed < Tableless
         column :commentable_type, :string
         column :commentable_id, :integer
@@ -51,26 +51,26 @@ describe RailsAdmin::Config::Fields::Base do
       expect(RailsAdmin.config(CommentReversed).fields.map{|f| f.name.to_s}.select{|f| /^comment/ =~ f}).to match_array ['commentable'].concat(POLYMORPHIC_CHILDREN.map(&:to_s))
     end
 
-    context 'of a Paperclip installation' do
-      it 'should be a _file_name field' do
+    context "of a Paperclip installation" do
+      it "is a _file_name field" do
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :paperclip_asset }.children_fields.include?(:paperclip_asset_file_name)).to be_true
       end
 
-      it 'should be hidden, not filterable' do
+      it "is hidden, not filterable" do
         f = RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :paperclip_asset_file_name }
         expect(f.hidden?).to be_true
         expect(f.filterable?).to be_false
       end
     end
 
-    context 'of a Dragonfly installation' do
-      it 'should be a _name field and _uid field' do
+    context "of a Dragonfly installation" do
+      it "is a _name field and _uid field" do
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :dragonfly_asset }.children_fields).to eq([:dragonfly_asset_name, :dragonfly_asset_uid])
       end
     end
 
-    context 'of a Carrierwave installation' do
-      it 'should be the parent field itself' do
+    context "of a Carrierwave installation" do
+      it "is the parent field itself" do
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :carrierwave_asset }.children_fields).to eq([:carrierwave_asset])
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :carrierwave_asset }.hidden?).to be_false
       end
@@ -78,7 +78,7 @@ describe RailsAdmin::Config::Fields::Base do
   end
 
   describe "#html_default_value" do
-    it 'should be default_value for new records when value is nil' do
+    it "is default_value for new records when value is nil" do
       RailsAdmin.config Team do
         list do
           field :name do
@@ -97,13 +97,13 @@ describe RailsAdmin::Config::Fields::Base do
   end
 
   describe "#default_value" do
-    it 'should be nil by default' do
+    it "is nil by default" do
       expect(RailsAdmin.config('Team').list.fields.find{|f| f.name == :name}.default_value).to be_nil
     end
   end
 
   describe "#hint" do
-    it "should be user customizable" do
+    it "is user customizable" do
       RailsAdmin.config Team do
         list do
           field :division do
@@ -118,7 +118,7 @@ describe RailsAdmin::Config::Fields::Base do
   end
 
   describe "#css_class" do
-    it "should have a default and be user customizable" do
+    it "has a default and be user customizable" do
       RailsAdmin.config Team do
         list do
           field :division do
@@ -134,11 +134,11 @@ describe RailsAdmin::Config::Fields::Base do
   end
 
   describe "#associated_collection_cache_all" do
-    it "should default to true if associated collection count < 100" do
+    it "defaults to true if associated collection count < 100" do
       expect(RailsAdmin.config(Team).edit.fields.find{|f| f.name == :players}.associated_collection_cache_all).to be_true
     end
 
-    it "should default to false if associated collection count >= 100" do
+    it "defaults to false if associated collection count >= 100" do
       @players = 100.times.map do
         FactoryGirl.create :player
       end
@@ -146,13 +146,13 @@ describe RailsAdmin::Config::Fields::Base do
     end
   end
 
-  describe '#searchable_columns' do
-    describe 'for belongs_to fields' do
-      it "should find label method on the opposite side for belongs_to associations by default" do
+  describe "#searchable_columns" do
+    describe "for belongs_to fields" do
+      it "finds label method on the opposite side for belongs_to associations by default" do
         expect(RailsAdmin.config(Team).fields.find{|f| f.name == :division}.searchable_columns.map{|c| c[:column]}).to eq(["divisions.name", "teams.division_id"])
       end
 
-      it "should search on opposite table for belongs_to" do
+      it "searches on opposite table for belongs_to" do
         RailsAdmin.config(Team) do
           field :division do
             searchable :custom_id
@@ -161,7 +161,7 @@ describe RailsAdmin::Config::Fields::Base do
         expect(RailsAdmin.config(Team).fields.find{|f| f.name == :division}.searchable_columns.map{|c| c[:column]}).to eq(["divisions.custom_id"])
       end
 
-      it "should search on asked table with model name" do
+      it "searches on asked table with model name" do
         RailsAdmin.config(Team) do
           field :division do
             searchable League => :name
@@ -170,7 +170,7 @@ describe RailsAdmin::Config::Fields::Base do
         expect(RailsAdmin.config(Team).fields.find{|f| f.name == :division}.searchable_columns).to eq([{:column=>"leagues.name", :type=>:string}])
       end
 
-      it "should search on asked table with table name" do
+      it "searches on asked table with table name" do
         RailsAdmin.config(Team) do
           field :division do
             searchable :leagues => :name
@@ -180,14 +180,14 @@ describe RailsAdmin::Config::Fields::Base do
       end
     end
 
-    describe 'for basic type fields' do
+    describe "for basic type fields" do
 
-      it 'should use base table and find correct column type' do
+      it "uses base table and find correct column type" do
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :text_field}.searchable_columns).to eq([{:column=>"field_tests.text_field", :type=>:text}])
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :integer_field}.searchable_columns).to eq([{:column=>"field_tests.integer_field", :type=>:integer}])
       end
 
-      it 'should be customizable to another field on the same table' do
+      it "is customizable to another field on the same table" do
         RailsAdmin.config(FieldTest) do
           field :time_field do
             searchable :date_field
@@ -196,7 +196,7 @@ describe RailsAdmin::Config::Fields::Base do
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :time_field}.searchable_columns).to eq([{:column=>"field_tests.date_field", :type=>:date}])
       end
 
-      it 'should be customizable to another field on another table with :table_name' do
+      it "is customizable to another field on another table with :table_name" do
         RailsAdmin.config(FieldTest) do
           field :string_field do
             searchable :nested_field_tests => :title
@@ -205,7 +205,7 @@ describe RailsAdmin::Config::Fields::Base do
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :string_field}.searchable_columns).to eq([{:column=>"nested_field_tests.title", :type=>:string}])
       end
 
-      it 'should be customizable to another field on another model with ModelClass' do
+      it "is customizable to another field on another model with ModelClass" do
         RailsAdmin.config(FieldTest) do
           field :string_field do
             searchable NestedFieldTest => :title
@@ -215,16 +215,16 @@ describe RailsAdmin::Config::Fields::Base do
       end
     end
 
-    describe 'for mapped fields' do
-      it 'of paperclip should find the underlying column on the base table' do
+    describe "for mapped fields" do
+      it "of paperclip should find the underlying column on the base table" do
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :paperclip_asset}.searchable_columns.map{|c| c[:column]}).to eq(["field_tests.paperclip_asset_file_name"])
       end
 
-      it 'of dragonfly should find the underlying column on the base table' do
+      it "of dragonfly should find the underlying column on the base table" do
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :dragonfly_asset}.searchable_columns.map{|c| c[:column]}).to eq(["field_tests.dragonfly_asset_name"])
       end
 
-      it 'of carrierwave should find the underlying column on the base table' do
+      it "of carrierwave should find the underlying column on the base table" do
         expect(RailsAdmin.config(FieldTest).fields.find{|f| f.name == :carrierwave_asset}.searchable_columns.map{|c| c[:column]}).to eq(["field_tests.carrierwave_asset"])
       end
     end
@@ -232,7 +232,7 @@ describe RailsAdmin::Config::Fields::Base do
 
 
   describe "#searchable and #sortable" do
-    it 'should be false if column is virtual, true otherwise' do
+    it "is false if column is virtual, true otherwise" do
       RailsAdmin.config League do
         field :virtual_column
         field :name
@@ -244,18 +244,18 @@ describe RailsAdmin::Config::Fields::Base do
       expect(RailsAdmin.config('League').export.fields.find{ |f| f.name == :name }.searchable).to be_true
     end
 
-    context 'of a virtual field with children fields' do
-      it 'of paperclip should target the first children field' do
+    context "of a virtual field with children fields" do
+      it "of paperclip should target the first children field" do
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :paperclip_asset }.searchable).to eq(:paperclip_asset_file_name)
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :paperclip_asset }.sortable).to eq(:paperclip_asset_file_name)
       end
 
-      it 'of dragonfly should target the first children field' do
+      it "of dragonfly should target the first children field" do
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :dragonfly_asset }.searchable).to eq(:dragonfly_asset_name)
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :dragonfly_asset }.sortable).to eq(:dragonfly_asset_name)
       end
 
-      it 'of carrierwave should target the first children field' do
+      it "of carrierwave should target the first children field" do
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :carrierwave_asset }.searchable).to eq(:carrierwave_asset)
         expect(RailsAdmin.config(FieldTest).fields.find{ |f| f.name == :carrierwave_asset }.sortable).to eq(:carrierwave_asset)
       end
@@ -263,7 +263,7 @@ describe RailsAdmin::Config::Fields::Base do
   end
 
   describe "#virtual?" do
-    it 'should be true if column has no properties, false otherwise' do
+    it "is true if column has no properties, false otherwise" do
       RailsAdmin.config League do
         field :virtual_column
         field :name
@@ -338,20 +338,20 @@ describe RailsAdmin::Config::Fields::Base do
     end
   end
 
-  describe '#active' do
-    it 'is false by default' do
+  describe "#active" do
+    it "is false by default" do
       expect(RailsAdmin.config(Team).field(:division).active?).to be_false
     end
   end
 
-  describe '#associated_collection' do
-    it 'returns [] when type is blank?' do
+  describe "#associated_collection" do
+    it "returns [] when type is blank?" do
       expect(RailsAdmin.config(Comment).fields.find{|f|f.name == :commentable}.associated_collection('')).to be_empty
     end
   end
 
-  describe '#visible?' do
-    it "should be false when fields have specific name " do
+  describe "#visible?" do
+    it "is false when fields have specific name " do
       class FieldVisibilityTest < Tableless
         column :id, :integer
         column :_id, :integer
@@ -371,12 +371,12 @@ describe RailsAdmin::Config::Fields::Base do
     end
   end
 
-  describe '#editable?' do
+  describe "#editable?" do
     before do
       Moped.logger.stub!(:debug) if defined?(Moped)
     end
 
-    it 'should yell for non attr_accessible fields if config.yell_for_non_accessible_fields is true' do
+    it "yells for non attr_accessible fields if config.yell_for_non_accessible_fields is true" do
       RailsAdmin.config do |config|
         config.yell_for_non_accessible_fields = true
         config.model FieldTest do
@@ -388,7 +388,7 @@ describe RailsAdmin::Config::Fields::Base do
       expect(editable).to be_false
     end
 
-    it 'should not yell for non attr_accessible fields if config.yell_for_non_accessible_fields is false' do
+    it "does not yell for non attr_accessible fields if config.yell_for_non_accessible_fields is false" do
       RailsAdmin.config do |config|
         config.yell_for_non_accessible_fields = false
         config.model FieldTest do
@@ -400,4 +400,16 @@ describe RailsAdmin::Config::Fields::Base do
       expect(editable).to be_false
     end
   end
+  
+  describe "#allowed_methods" do
+    it 'includes method_name' do
+      RailsAdmin.config do |config|
+        config.model Team do
+          field :name
+        end
+      end
+
+      expect(RailsAdmin.config(Team).field(:name).allowed_methods).to eq [:name]
+    end
+  end
 end

data/spec/unit/config/fields/date_spec.rb

@@ -12,19 +12,19 @@ describe RailsAdmin::Config::Fields::Types::Date do
       Time.zone = 'UTC'
     end
 
-    it "should read %B %d, %Y by default" do
+    it "reads %B %d, %Y by default" do
       @object.date_field = @field.parse_input({ :date_field => @time.strftime("%B %d, %Y") })
       expect(@object.date_field).to eq(::Date.parse(@time.to_s))
     end
 
-    it "should cover a timezone lag even if in UTC+n:00 timezone." do
+    it "covers a timezone lag even if in UTC+n:00 timezone." do
       Time.zone = 'Tokyo' # +09:00
 
       @object.date_field = @field.parse_input({ :date_field => @time.strftime("%B %d, %Y") })
       expect(@object.date_field).to eq(::Date.parse(@time.to_s))
     end
 
-    it "should have a simple customization option" do
+    it "has a simple customization option" do
       RailsAdmin.config FieldTest do
         edit do
           field :date_field do
@@ -37,7 +37,7 @@ describe RailsAdmin::Config::Fields::Types::Date do
       expect(@object.date_field).to eq(::Date.parse(@time.to_s))
     end
 
-    it "should have a customization option" do
+    it "has a customization option" do
       RailsAdmin.config FieldTest do
         edit do
           field :date_field do

data/spec/unit/config/fields/datetime_spec.rb

@@ -12,13 +12,13 @@ describe RailsAdmin::Config::Fields::Types::Datetime do
       Time.zone = 'UTC'
     end
 
-    it "should be able to read %B %d, %Y %H:%M" do
+    it "is able to read %B %d, %Y %H:%M" do
       @object = FactoryGirl.create(:field_test)
       @object.datetime_field = @field.parse_input({ :datetime_field => @time.strftime("%B %d, %Y %H:%M") })
       expect(@object.datetime_field.strftime("%Y-%m-%d %H:%M")).to eq(@time.strftime("%Y-%m-%d %H:%M"))
     end
 
-    it "should be able to read %a, %d %b %Y %H:%M:%S" do
+    it "is able to read %a, %d %b %Y %H:%M:%S" do
       RailsAdmin.config FieldTest do
         edit do
           field :datetime_field do
@@ -31,7 +31,7 @@ describe RailsAdmin::Config::Fields::Types::Datetime do
       expect(@object.datetime_field.to_s(:rfc822)).to eq(@time.to_s(:rfc822))
     end
 
-    it "should have a customization option" do
+    it "has a customization option" do
       RailsAdmin.config FieldTest do
         list do
           field :datetime_field do
@@ -44,7 +44,7 @@ describe RailsAdmin::Config::Fields::Types::Datetime do
       expect(@object.datetime_field.to_s(:rfc822)).to eq(@time.to_s(:rfc822))
     end
 
-    it "should do round-trip saving properly with non-UTC timezones" do
+    it "does round-trip saving properly with non-UTC timezones" do
       Time.zone = 'Vienna'
       @object = FactoryGirl.create(:field_test)
       @object.datetime_field = @field.parse_input({ :datetime_field => '2012-09-01 12:00:00 +02:00' })

data/spec/unit/config/fields/file_upload_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe RailsAdmin::Config::Fields::Types::FileUpload do
+  describe "#allowed_methods" do
+    it 'includes delete_method and cache_method' do
+      RailsAdmin.config do |config|
+        config.model FieldTest do
+          field :carrierwave_asset
+          field :dragonfly_asset
+          field :paperclip_asset do
+            delete_method :delete_paperclip_asset
+          end
+        end
+      end
+      expect(RailsAdmin.config(FieldTest).field(:carrierwave_asset).allowed_methods.map(&:to_s)).to eq ["carrierwave_asset", "remove_carrierwave_asset", "carrierwave_asset_cache"]
+      expect(RailsAdmin.config(FieldTest).field(:dragonfly_asset).allowed_methods.map(&:to_s)).to eq ["dragonfly_asset", "remove_dragonfly_asset", "retained_dragonfly_asset"]
+      expect(RailsAdmin.config(FieldTest).field(:paperclip_asset).allowed_methods.map(&:to_s)).to eq ["paperclip_asset", "delete_paperclip_asset"]
+    end
+  end
+end
+

data/spec/unit/config/fields/time_spec.rb

@@ -12,18 +12,18 @@ describe RailsAdmin::Config::Fields::Types::Time do
       Time.zone = 'UTC'
     end
 
-    it "should read %H:%M" do
+    it "reads %H:%M" do
       @object.time_field = @field.parse_input({ :time_field => @time.strftime("%H:%M") })
       expect(@object.time_field.strftime("%H:%M")).to eq(@time.strftime("%H:%M"))
     end
 
-    it "should interpret time value as UTC when timezone is specified" do
+    it "interprets time value as UTC when timezone is specified" do
       Time.zone = 'Eastern Time (US & Canada)' # -05:00
       @object.time_field = @field.parse_input({ :time_field => @time.strftime("%H:%M") })
       expect(@object.time_field.strftime("%H:%M")).to eq(@time.strftime("%H:%M"))
     end
 
-    it "should have a customization option" do
+    it "has a customization option" do
       RailsAdmin.config FieldTest do
         edit do
           field :time_field do

data/spec/unit/config/fields/timestamp_spec.rb

@@ -12,7 +12,7 @@ describe RailsAdmin::Config::Fields::Types::Timestamp do
       Time.zone = 'UTC'
     end
 
-    it "should read %B %d, %Y %H:%M" do
+    it "reads %B %d, %Y %H:%M" do
       @object.timestamp_field = @field.parse_input({ :timestamp_field => @time.strftime("%B %d, %Y %H:%M") })
       expect(@object.timestamp_field.strftime("%Y-%m-%d %H:%M")).to eq(@time.strftime("%Y-%m-%d %H:%M"))
     end

data/spec/unit/config/model_spec.rb

@@ -9,7 +9,7 @@ describe RailsAdmin::Config::Model do
       end
     end
 
-    it "should say false when included, true otherwise" do
+    it "returns false when included, true otherwise" do
       expect(RailsAdmin.config(Player).excluded?).to be_true
       expect(RailsAdmin.config(Comment).excluded?).to be_false
     end
@@ -22,53 +22,53 @@ describe RailsAdmin::Config::Model do
       end
     end
 
-    it "should send object_label_method to binding[:object]" do
+    it "sends object_label_method to binding[:object]" do
       c = Comment.new(:content => 'test')
       expect(RailsAdmin.config(Comment).with(:object => c).object_label).to eq('test')
     end
   end
 
   describe "#object_label_method" do
-    it "should be first of Config.label_methods if found as a column on model, or :rails_admin_default_object_label_method" do
+    it "is first of Config.label_methods if found as a column on model, or :rails_admin_default_object_label_method" do
       expect(RailsAdmin.config(Comment).object_label_method).to eq(:rails_admin_default_object_label_method)
       expect(RailsAdmin.config(Division).object_label_method).to eq(:name)
     end
   end
 
   describe "#label" do
-    it "should be pretty" do
+    it "is pretty" do
       expect(RailsAdmin.config(Comment).label).to eq('Comment')
     end
   end
 
   describe "#label_plural" do
-    it "should be pretty" do
+    it "is pretty" do
       expect(RailsAdmin.config(Comment).label_plural).to eq('Comments')
     end
   end
 
   describe "#weight" do
-    it "should be 0" do
+    it "is 0" do
       expect(RailsAdmin.config(Comment).weight).to eq(0)
     end
   end
 
   describe "#parent" do
-    it "should be nil for ActiveRecord::Base inherited models" do
+    it "is nil for ActiveRecord::Base inherited models" do
       expect(RailsAdmin.config(Comment).parent).to be_nil
     end
 
-    it "should be parent model otherwise" do
+    it "is parent model otherwise" do
       expect(RailsAdmin.config(Hardball).parent).to eq(Ball)
     end
   end
 
   describe "#navigation_label" do
-    it "should be nil if parent module is Object" do
+    it "is nil if parent module is Object" do
       expect(RailsAdmin.config(Comment).navigation_label).to be_nil
     end
 
-    it "should be parent module otherwise" do
+    it "is parent module otherwise" do
       expect(RailsAdmin.config(Cms::BasicPage).navigation_label).to eq("Cms")
     end
   end