rails_admin 0.1.2 → 0.2.0

data/spec/integration/basic/export/rails_admin_basic_export_spec.rb

@@ -30,7 +30,7 @@ describe "RailsAdmin Export" do
 
   describe "POST /admin/players/export (prompt)" do
 
-    it "should allow to export to CSV with associations and default schema, containing properly translated header and follow configuration" do
+    it "allows to export to CSV with associations and default schema, containing properly translated header and follow configuration" do
       RailsAdmin.config do |c|
         c.model Player do
           include_all_fields
@@ -63,13 +63,13 @@ describe "RailsAdmin Export" do
       expect(csv.flatten.join(' ')).to include(@player.comments.second.content.split("\n").first.strip)
     end
 
-    it "should allow to export to JSON" do
+    it "allows to export to JSON" do
       visit export_path(:model_name => 'player')
       click_button 'Export to json'
       should have_content @player.team.name
     end
 
-    it "should allow to export to XML" do
+    it "allows to export to XML" do
       visit export_path(:model_name => 'player')
       click_button 'Export to xml'
 
@@ -83,7 +83,7 @@ describe "RailsAdmin Export" do
       end
     end
 
-    it "should export polymorphic fields the easy way for now" do
+    it "exports polymorphic fields the easy way for now" do
       visit export_path(:model_name => 'comment')
       select "<comma> ','", :from => "csv_options_generator_col_sep"
       click_button 'Export to csv'
@@ -97,7 +97,7 @@ describe "RailsAdmin Export" do
   end
 
   describe "POST /admin/players/export :format => :csv" do
-    it "should export with modified schema" do
+    it "exports with modified schema" do
       page.driver.post(export_path(:model_name => 'player', :schema => @non_default_schema, :csv => true, :all => true, :csv_options => { :generator => { :col_sep => "," } }))
       csv = CSV.parse find('body').text
       expect(csv[0]).not_to include('Created at')

data/spec/integration/basic/list/rails_admin_basic_list_spec.rb

@@ -7,13 +7,13 @@ describe "RailsAdmin Basic List" do
   subject { page }
 
   describe "GET /admin" do
-    it "should respond successfully" do
+    it "responds successfully" do
       visit dashboard_path
     end
   end
 
   describe "GET /admin/typo" do
-    it "should redirect to dashboard and inform the user the model wasn't found" do
+    it "redirects to dashboard and inform the user the model wasn't found" do
       visit '/admin/whatever'
       expect(page.driver.status_code).to eq(404)
       expect(find('.alert-error')).to have_content("Model 'Whatever' could not be found")
@@ -21,7 +21,7 @@ describe "RailsAdmin Basic List" do
   end
 
   describe "GET /admin/balls/545-typo" do
-    it "should redirect to balls index and inform the user the id wasn't found" do
+    it "redirects to balls index and inform the user the id wasn't found" do
       visit '/admin/ball/545-typo'
       expect(page.driver.status_code).to eq(404)
       expect(find('.alert-error')).to have_content("Ball with id '545-typo' could not be found")
@@ -29,7 +29,7 @@ describe "RailsAdmin Basic List" do
   end
 
   describe "GET /admin/player as list" do
-    it "should show \"List of Models\", should show filters and should show column headers" do
+    it "shows \"List of Models\", should show filters and should show column headers" do
       21.times { FactoryGirl.create :player } # two pages of players
       visit index_path(:model_name => "player")
       should have_content("List of Players")
@@ -47,7 +47,7 @@ describe "RailsAdmin Basic List" do
       # https://github.com/sferik/rails_admin/issues/362
       # test that no link uses the "wildcard route" with the main
       # controller and list method
-      # it "should not use the 'wildcard route'" do
+      # it "does not use the 'wildcard route'" do
       should have_selector("a[href*='all=true']") # make sure we're fully testing pagination
       should have_no_selector("a[href^='/rails_admin/main/list']")
     end
@@ -74,7 +74,7 @@ describe "RailsAdmin Basic List" do
       ]
     end
 
-    it "should allow to query on any attribute" do
+    it "allows to query on any attribute" do
       visit index_path(:model_name => "player", :query => @players[0].name)
       should have_content(@players[0].name)
       (1..3).each do |i|
@@ -82,7 +82,7 @@ describe "RailsAdmin Basic List" do
       end
     end
 
-    it "should allow to filter on one attribute" do
+    it "allows to filter on one attribute" do
       visit index_path(:model_name => "player", :f => {:injured => {"1" => {:v => "true"}}})
       should have_content(@players[0].name)
       should have_no_content(@players[1].name)
@@ -90,7 +90,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to combine filters on two different attributes" do
+    it "allows to combine filters on two different attributes" do
       visit index_path(:model_name => "player", :f => {:retired => {"1" => {:v => "true"}}, :injured => {"1" => {:v => "true"}}})
       should have_content(@players[0].name)
       (1..3).each do |i|
@@ -98,7 +98,7 @@ describe "RailsAdmin Basic List" do
       end
     end
 
-    it "should allow to filter on belongs_to relationships" do
+    it "allows to filter on belongs_to relationships" do
       visit index_path(:model_name => "player", :f => {:team => {"1" => { :v => @teams[0].name }}})
       should have_content(@players[0].name)
       should have_content(@players[1].name)
@@ -106,7 +106,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to disable search on attributes" do
+    it "allows to disable search on attributes" do
       RailsAdmin.config Player do
         list do
           field :position
@@ -119,7 +119,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[0].name)
     end
 
-    it "should allow to search a belongs_to attribute over the base table" do
+    it "allows to search a belongs_to attribute over the base table" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -137,7 +137,7 @@ describe "RailsAdmin Basic List" do
     end
 
 
-    it "should allow to search a belongs_to attribute over the target table" do
+    it "allows to search a belongs_to attribute over the target table" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -154,7 +154,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to search a belongs_to attribute over the target table with a table name specified as a hash" do
+    it "allows to search a belongs_to attribute over the target table with a table name specified as a hash" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -171,7 +171,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to search a belongs_to attribute over the target table with a table name specified as a string" do
+    it "allows to search a belongs_to attribute over the target table with a table name specified as a string" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -188,7 +188,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to search a belongs_to attribute over the label method by default" do
+    it "allows to search a belongs_to attribute over the label method by default" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -203,7 +203,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to search a belongs_to attribute over the target table when an attribute is specified" do
+    it "allows to search a belongs_to attribute over the target table when an attribute is specified" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -220,7 +220,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should allow to search over more than one attribute" do
+    it "allows to search over more than one attribute" do
       RailsAdmin.config Player do
         list do
           field PK_COLUMN
@@ -243,7 +243,7 @@ describe "RailsAdmin Basic List" do
       should have_no_content(@players[3].name)
     end
 
-    it "should display base filters when no filters are present in the params" do
+    it "displays base filters when no filters are present in the params" do
       RailsAdmin.config Player do
         list do
           filters [:name, :team]
@@ -262,7 +262,7 @@ describe "RailsAdmin Basic List" do
       visit index_path(:model_name => "player")
     end
 
-    it "should show \"2 results\"" do
+    it "shows \"2 results\"" do
       should have_content("2 players")
     end
   end
@@ -273,7 +273,7 @@ describe "RailsAdmin Basic List" do
       visit index_path(:model_name => "player")
     end
 
-    it "should show \"20 results\"" do
+    it "shows \"20 results\"" do
       should have_content("20 players")
     end
   end
@@ -285,7 +285,7 @@ describe "RailsAdmin Basic List" do
       visit index_path(:model_name => "player", :page => 2)
     end
 
-    it "should paginate correctly" do
+    it "paginates correctly" do
       expect(find('.pagination ul li:first')).to have_content("« Prev")
       expect(find('.pagination ul li:last')).to have_content("Next »")
       expect(find('.pagination ul li.active')).to have_content("2")
@@ -299,7 +299,7 @@ describe "RailsAdmin Basic List" do
       visit index_path(:model_name => "player", :page => 3)
     end
 
-    it "should paginate correctly and contain the right item" do
+    it "paginates correctly and contain the right item" do
       expect(find('.pagination ul li:first')).to have_content("« Prev")
       expect(find('.pagination ul li:last')).to have_content("Next »")
       expect(find('.pagination ul li.active')).to have_content("3")
@@ -307,7 +307,14 @@ describe "RailsAdmin Basic List" do
   end
 
   describe "GET /admin/player show all" do
-    it "should respond successfully" do
+    it "responds successfully with a single model" do
+      FactoryGirl.create :player
+      visit index_path(:model_name => "player", :all => true)
+      expect(find('div.total-count')).to have_content("1 player")
+      expect(find('div.total-count')).not_to have_content("1 players")
+    end
+
+    it "responds successfully with multiple models" do
       2.times.map { FactoryGirl.create :player }
       visit index_path(:model_name => "player", :all => true)
       expect(find('div.total-count')).to have_content("2 players")
@@ -315,7 +322,7 @@ describe "RailsAdmin Basic List" do
   end
 
   describe "GET /admin/player show with pagination disabled by :associated_collection" do
-    it "should respond successfully" do
+    it "responds successfully" do
       @team = FactoryGirl.create :team
       2.times.map { FactoryGirl.create :player, :team => @team }
       visit index_path(:model_name => "player", :associated_collection => "players", :compact => true, :current_action => 'update', :source_abstract_model => 'team', :source_object_id => @team.id)
@@ -324,7 +331,7 @@ describe "RailsAdmin Basic List" do
   end
 
   describe "list as compact json" do
-    it "should have_content an array with 2 elements and contain an array of elements with keys id and label" do
+    it "has_content an array with 2 elements and contain an array of elements with keys id and label" do
       2.times.map { FactoryGirl.create :player }
       response = page.driver.get(index_path(:model_name => "player", :compact => true, :format => :json))
       expect(ActiveSupport::JSON.decode(response.body).length).to eq(2)

data/spec/integration/basic/new/rails_admin_basic_new_spec.rb

@@ -9,16 +9,16 @@ describe "RailsAdmin Basic New" do
       visit new_path(:model_name => "player")
     end
 
-    it "should show \"New Model\"" do
+    it "shows \"New Model\"" do
       should have_content("New Player")
     end
 
-    it "should show required fields as \"Required\"" do
+    it "shows required fields as \"Required\"" do
       should have_selector("div", :text => /Name\s*Required/)
       should have_selector("div", :text => /Number\s*Required/)
     end
 
-    it "should show non-required fields as \"Optional\"" do
+    it "shows non-required fields as \"Optional\"" do
       should have_selector("#player_position_field .help-block", :text => "Optional")
       should have_selector("#player_born_on_field .help-block", :text => "Optional")
       should have_selector("#player_notes_field .help-block", :text => "Optional")
@@ -27,7 +27,7 @@ describe "RailsAdmin Basic New" do
     # https://github.com/sferik/rails_admin/issues/362
     # test that no link uses the "wildcard route" with the main
     # controller and new method
-    it "should not use the 'wildcard route'" do
+    it "does not use the 'wildcard route'" do
       should have_no_selector("a[href^='/rails_admin/main/new']")
     end
   end
@@ -38,7 +38,7 @@ describe "RailsAdmin Basic New" do
       visit new_path(:model_name => "player")
     end
 
-    it "should show selects" do
+    it "shows selects" do
       should have_selector("select#player_draft_id")
       should have_selector("select#player_team_id")
       should have_selector("select#player_comment_ids")
@@ -53,18 +53,18 @@ describe "RailsAdmin Basic New" do
   end
 
   describe "GET /admin/player/new with parameters for pre-population" do
-    it "should populate form field when corresponding parameters are passed in" do
+    it "populates form field when corresponding parameters are passed in" do
       visit new_path(:model_name => 'player', :player => {:name => 'Sam'})
       expect(page).to have_css('input[value=Sam]')
     end
 
-    it "should prepropulate belongs to relationships" do
+    it "prepropulates belongs to relationships" do
       @team = FactoryGirl.create :team, :name => "belongs_to association prepopulated"
       visit new_path(:model_name => 'player', :associations => { :team => @team.id } )
       expect(page).to have_css("select#player_team_id option[selected='selected'][value='#{@team.id}']")
     end
 
-    it "should prepropulate has_many relationships" do
+    it "prepropulates has_many relationships" do
       @player = FactoryGirl.create :player, :name => "has_many association prepopulated"
       visit new_path(:model_name => 'team', :associations => { :players => @player.id } )
       expect(page).to have_css("select#team_player_ids option[selected='selected'][value='#{@player.id}']")

data/spec/integration/basic/new/rails_admin_namespaced_model_new_spec.rb

@@ -5,13 +5,13 @@ describe "RailsAdmin Namespaced Model New" do
   subject { page }
 
   describe "AbstractModel#to_param" do
-    it 'turns namespaces into prefixes with ~' do
+    it "turns namespaces into prefixes with ~" do
       expect(RailsAdmin::AbstractModel.new("Cms::BasicPage").to_param).to eq('cms~basic_page')
     end
   end
 
   describe "ApplicationController#to_model_name" do
-    it 'turns cms~basic_page into Cms::BasicPage' do
+    it "turns cms~basic_page into Cms::BasicPage" do
       expect(RailsAdmin::ApplicationController.new.to_model_name('cms~basic_page')).to eq('Cms::BasicPage')
     end
   end
@@ -21,7 +21,7 @@ describe "RailsAdmin Namespaced Model New" do
       visit new_path(:model_name => "cms~basic_page")
     end
 
-    it 'should have correct input field names' do
+    it "has correct input field names" do
       should have_selector("label[for=cms_basic_page_title]")
       should have_selector("input#cms_basic_page_title[name='cms_basic_page[title]']")
       should have_selector("label[for=cms_basic_page_content]")

data/spec/integration/basic/show/rails_admin_basic_show_spec.rb

@@ -4,7 +4,7 @@ describe "RailsAdmin Basic Show" do
   subject { page }
 
   describe "show" do
-    it "should have History, Edit, Delete, Details and attributes" do
+    it "has History, Edit, Delete, Details and attributes" do
       @player = FactoryGirl.create :player
       visit show_path(:model_name => "player", :id => @player.id)
 
@@ -20,7 +20,7 @@ describe "RailsAdmin Basic Show" do
   end
 
   describe "GET /admin/players/123this-id-doesnt-exist" do
-    it "should raise NotFound" do
+    it "raises NotFound" do
       visit '/admin/players/123this-id-doesnt-exist'
       expect(page.driver.status_code).to eq(404)
     end
@@ -34,7 +34,7 @@ describe "RailsAdmin Basic Show" do
       visit show_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should show associated objects" do
+    it "shows associated objects" do
       should have_css("a[href='/admin/team/#{@team.id}']")
     end
   end
@@ -46,7 +46,7 @@ describe "RailsAdmin Basic Show" do
       visit show_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should show associated objects" do
+    it "shows associated objects" do
       should have_css("a[href='/admin/draft/#{@draft.id}']")
     end
   end
@@ -61,7 +61,7 @@ describe "RailsAdmin Basic Show" do
       visit show_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should show associated objects" do
+    it "shows associated objects" do
       should have_css("a[href='/admin/comment/#{@comment1.id}']")
       should have_css("a[href='/admin/comment/#{@comment2.id}']")
       should_not have_css("a[href='/admin/comment/#{@comment3.id}']")
@@ -75,7 +75,7 @@ describe "RailsAdmin Basic Show" do
       visit show_path(:model_name => "comment", :id => @comment.id)
     end
 
-    it "should show associated object" do
+    it "shows associated object" do
       should have_css("a[href='/admin/player/#{@player.id}']")
     end
   end

data/spec/integration/basic/update/rails_admin_basic_update_spec.rb

@@ -10,7 +10,7 @@ describe "RailsAdmin Basic Update" do
       visit edit_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should return to edit page" do
+    it "returns to edit page" do
       fill_in "player[name]", :with => ""
       click_button "Save"
       expect(page.driver.status_code).to eq(406)
@@ -32,7 +32,7 @@ describe "RailsAdmin Basic Update" do
       @player = RailsAdmin::AbstractModel.new("Player").first
     end
 
-    it "should update an object with correct attributes" do
+    it "updates an object with correct attributes" do
       expect(@player.name).to eq("Jackie Robinson")
       expect(@player.number).to eq(42)
       expect(@player.position).to eq("Second baseman")
@@ -53,7 +53,7 @@ describe "RailsAdmin Basic Update" do
       @player.reload
     end
 
-    it "should update an object with correct attributes" do
+    it "updates an object with correct attributes" do
       expect(@player.name).to eq("Jackie Robinson")
       expect(@player.number).to eq(42)
       expect(@player.position).to eq("Second baseman")
@@ -69,20 +69,20 @@ describe "RailsAdmin Basic Update" do
       @player.reload
     end
 
-    it "should update an object with correct attributes" do
+    it "updates an object with correct attributes" do
       expect(@player.name).to eq("Jackie Robinson")
       expect(@player.number).to eq(@number)
       expect(@player.position).to eq("Second baseman")
     end
 
-    it "should update an object with correct associations" do
+    it "updates an object with correct associations" do
       @draft.reload
       expect(@player.draft).to eq(@draft)
     end
   end
 
   describe "update with has-many association" do
-    it "should be fillable and emptyable", :active_record => true do
+    it "is fillable and emptyable", :active_record => true do
       RailsAdmin.config do |c|
         c.audit_with :history
       end
@@ -114,7 +114,7 @@ describe "RailsAdmin Basic Update" do
       page.driver.put(edit_path(:model_name => "player", :id => 1), :params => {:player => {:name => "Jackie Robinson", :number => 42, :position => "Second baseman"}})
     end
 
-    it "should raise NotFound" do
+    it "raises NotFound" do
       expect(page.driver.status_code).to eq(404)
     end
   end
@@ -133,7 +133,7 @@ describe "RailsAdmin Basic Update" do
       @player.reload
     end
 
-    it "should show an error message" do
+    it "shows an error message" do
       # TODO: Mongoid 3.0.0 lacks ability of numericality validation on Integer field.
       # This is caused by change in https://github.com/mongoid/mongoid/pull/1698
       # I believe this should be a bug in Mongoid.
@@ -159,7 +159,7 @@ describe "RailsAdmin Basic Update" do
       @user.reload
     end
 
-    it "should save the serialized data" do
+    it "saves the serialized data" do
       expect(@user.roles).to eq(['admin','user'])
     end
   end
@@ -171,7 +171,7 @@ describe "RailsAdmin Basic Update" do
       visit edit_path(:model_name => "field_test", :id => @field_test.id)
     end
 
-    it "should save the serialized data" do
+    it "saves the serialized data" do
       fill_in "field_test[array_field]", :with => "[4, 2]"
       fill_in "field_test[hash_field]", :with => "{ a: 6, b: 2 }"
       click_button "Save"
@@ -181,7 +181,7 @@ describe "RailsAdmin Basic Update" do
       expect(@field_test.hash_field).to eq({ "a" => 6, "b" => 2 })
     end
 
-    it "should clear data when empty string is passed" do
+    it "clears data when empty string is passed" do
       fill_in "field_test[array_field]", :with => ""
       fill_in "field_test[hash_field]", :with => ""
       click_button "Save"
@@ -204,7 +204,7 @@ describe "RailsAdmin Basic Update" do
       @ball.reload
     end
 
-    it "should update an object with correct attributes" do
+    it "updates an object with correct attributes" do
       expect(@ball.color).to eq("gray")
     end
   end
@@ -221,7 +221,7 @@ describe "RailsAdmin Basic Update" do
       @hardball.reload
     end
 
-    it "should update an object with correct attributes" do
+    it "updates an object with correct attributes" do
       expect(@hardball.color).to eq("cyan")
     end
   end