rails_admin 0.1.2 → 0.2.0

data/spec/helpers/application_helper_spec.rb

@@ -6,8 +6,8 @@ describe RailsAdmin::ApplicationHelper do
     controller.stub(:authorized?).and_return(true)
   end
 
-  describe '#current_action?' do
-    it 'should return true if current_action, false otherwise' do
+  describe "#current_action?" do
+    it "returns true if current_action, false otherwise" do
       @action = RailsAdmin::Config::Actions.find(:index)
 
       expect(helper.current_action?(RailsAdmin::Config::Actions.find(:index))).to be_true
@@ -15,8 +15,8 @@ describe RailsAdmin::ApplicationHelper do
     end
   end
 
-  describe '#action' do
-    it 'should return action by :custom_key' do
+  describe "#action" do
+    it "returns action by :custom_key" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard do
@@ -27,7 +27,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.action(:my_custom_dashboard_key)).to be
     end
 
-    it 'should return only visible actions' do
+    it "returns only visible actions" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard do
@@ -39,7 +39,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.action(:dashboard)).to be_nil
     end
 
-    it 'should return only visible actions, passing all bindings' do
+    it "returns only visible actions, passing all bindings" do
       RailsAdmin.config do |config|
         config.actions do
           member :test_bindings do
@@ -58,7 +58,7 @@ describe RailsAdmin::ApplicationHelper do
   end
 
   describe "#actions" do
-    it 'should return actions by type' do
+    it "returns actions by type" do
       abstract_model = RailsAdmin::AbstractModel.new(Player)
       object = FactoryGirl.create :player
       expect(helper.actions(:all, abstract_model, object).map(&:custom_key)).to eq([:dashboard, :index, :show, :new, :edit, :export, :delete, :bulk_delete, :history_show, :history_index, :show_in_app])
@@ -67,7 +67,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.actions(:member, abstract_model, object).map(&:custom_key)).to eq([:show, :edit, :delete, :history_show, :show_in_app])
     end
 
-    it 'should only return visible actions, passing bindings correctly' do
+    it "only returns visible actions, passing bindings correctly" do
       RailsAdmin.config do |config|
         config.actions do
           member :test_bindings do
@@ -131,7 +131,7 @@ describe RailsAdmin::ApplicationHelper do
   end
 
   describe "#menu_for" do
-    it 'passes model and object as bindings and generates a menu, excluding non-get actions' do
+    it "passes model and object as bindings and generates a menu, excluding non-get actions" do
       RailsAdmin.config do |config|
         config.actions do
           dashboard
@@ -180,14 +180,14 @@ describe RailsAdmin::ApplicationHelper do
   end
 
   describe "#main_navigation" do
-    it 'should show included models' do
+    it "shows included models" do
       RailsAdmin.config do |config|
         config.included_models = [Ball, Comment]
       end
       expect(helper.main_navigation).to match /(nav\-header).*(Navigation).*(Balls).*(Comments)/m
     end
 
-    it 'should not draw empty navigation labels' do
+    it "does not draw empty navigation labels" do
       RailsAdmin.config do |config|
         config.included_models = [Ball, Comment, Comment::Confirmed]
         config.model Comment do
@@ -201,7 +201,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.main_navigation).not_to match /(nav\-header).*(Navigation).*(Balls).*(Commentz).*(Confirmed).*(Comment)/m
     end
 
-    it 'should not show unvisible models' do
+    it "does not show unvisible models" do
       RailsAdmin.config do |config|
         config.included_models = [Ball, Comment]
         config.model Comment do
@@ -213,7 +213,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(result).not_to match "Comments"
     end
 
-    it "should show children of hidden models" do # https://github.com/sferik/rails_admin/issues/978
+    it "shows children of hidden models" do # https://github.com/sferik/rails_admin/issues/978
       RailsAdmin.config do |config|
         config.included_models = [Ball, Hardball]
         config.model Ball do
@@ -223,14 +223,14 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.main_navigation).to match /(nav\-header).*(Navigation).*(Hardballs)/m
     end
 
-    it "should show children of excluded models" do
+    it "shows children of excluded models" do
       RailsAdmin.config do |config|
         config.included_models = [Hardball]
       end
       expect(helper.main_navigation).to match /(nav\-header).*(Navigation).*(Hardballs)/m
     end
 
-    it 'should "nest" in navigation label' do
+    it "nests in navigation label" do
       RailsAdmin.config do |config|
         config.included_models = [Comment]
         config.model Comment do
@@ -240,17 +240,17 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.main_navigation).to match /(nav\-header).*(commentable).*(Comments)/m
     end
 
-    it 'should "nest" in parent model' do
+    it "nests in parent model" do
       RailsAdmin.config do |config|
         config.included_models = [Player, Comment]
         config.model Comment do
           parent Player
         end
       end
-      expect(helper.main_navigation).to match /(Players).*(nav\-level\-1).*(Comments)/m
+      expect(helper.main_navigation).to match /(Players).* (nav\-level\-1).*(Comments)/m
     end
 
-    it 'should order' do
+    it "orders" do
       RailsAdmin.config do |config|
         config.included_models = [Player, Comment]
       end
@@ -263,15 +263,15 @@ describe RailsAdmin::ApplicationHelper do
     end
   end
 
-  describe '#static_navigation' do
-    it 'should show not show static nav if no static links defined' do
+  describe "#static_navigation" do
+    it "shows not show static nav if no static links defined" do
       RailsAdmin.config do |config|
         config.navigation_static_links = {}
       end
       expect(helper.static_navigation).to be_empty
     end
 
-    it 'should show links if defined' do
+    it "shows links if defined" do
       RailsAdmin.config do |config|
         config.navigation_static_links = {
           'Test Link' => 'http://www.google.com'
@@ -280,7 +280,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.static_navigation).to match /Test Link/
     end
 
-    it 'should show default header if navigation_static_label not defined in config' do
+    it "shows default header if navigation_static_label not defined in config" do
       RailsAdmin.config do |config|
         config.navigation_static_links = {
           'Test Link' => 'http://www.google.com'
@@ -289,7 +289,7 @@ describe RailsAdmin::ApplicationHelper do
       expect(helper.static_navigation).to match I18n.t('admin.misc.navigation_static_label')
     end
 
-    it 'should show custom header if defined' do
+    it "shows custom header if defined" do
       RailsAdmin.config do |config|
         config.navigation_static_label = "Test Header"
         config.navigation_static_links = {
@@ -301,7 +301,7 @@ describe RailsAdmin::ApplicationHelper do
   end
 
   describe "#bulk_menu" do
-    it 'should include all visible bulkable actions' do
+    it "includes all visible bulkable actions" do
       RailsAdmin.config do |config|
         config.actions do
           index

data/spec/helpers/form_builder_spec.rb

@@ -1,17 +1,17 @@
 require 'spec_helper'
 
 describe "RailsAdmin::FormBuilder" do
-  describe '#generate' do
+  describe "#generate" do
     before do
       helper.stub(:authorized?).and_return(true)
       (@object = Player.new).save
       @builder = RailsAdmin::FormBuilder.new(:player, @object, helper, {}, nil)
       @builder.stub(:field_for).and_return("field")
     end
-    
-    it 'should not add additional error div from default ActionView::Base.field_error_proc' do
+
+    it "does not add additional error div from default ActionView::Base.field_error_proc" do
       expect(@builder.generate({ :action => :create, :model_config => RailsAdmin.config(Player) })).not_to have_css(".field_with_errors")
       expect(@builder.generate({ :action => :create, :model_config => RailsAdmin.config(Player) })).to have_css(".control-group.error")
     end
   end
-end
+end

data/spec/integration/authorization/cancan_spec.rb

@@ -185,7 +185,7 @@ describe "RailsAdmin CanCan Authorization" do
   end
 
   describe "with history role" do
-    it 'shows links to history action' do
+    it "shows links to history action" do
 
       @user.update_attributes(:roles => [:admin, :read_player, :history_player])
       @player = FactoryGirl.create :player
@@ -206,7 +206,7 @@ describe "RailsAdmin CanCan Authorization" do
   end
 
   describe "with show in app role" do
-    it 'shows links to show in app action' do
+    it "shows links to show in app action" do
 
       @user.update_attributes(:roles => [:admin, :read_player, :show_in_app_player])
       @player = FactoryGirl.create :player
@@ -229,7 +229,7 @@ describe "RailsAdmin CanCan Authorization" do
   end
 
   describe "with all roles" do
-    it 'shows links to all actions' do
+    it "shows links to all actions" do
 
       @user.update_attributes(:roles => [:admin, :manage_player])
       @player = FactoryGirl.create :player

data/spec/integration/basic/bulk_action/rails_admin_basic_bulk_action_spec.rb

@@ -9,14 +9,14 @@ describe "RailsAdmin Basic Bulk Action" do
   end
 
   describe "bulk_delete" do
-    it 'should show names of to-be-deleted players' do
+    it "shows names of to-be-deleted players" do
       page.driver.post(bulk_action_path(:bulk_action => 'bulk_delete', :model_name => "player", :bulk_ids => @players.map(&:id)))
       @players.each { |player| should have_content(player.name) }
     end
   end
 
   describe "bulk_export" do
-    it 'should show form for export' do
+    it "shows form for export" do
       visit index_path(:model_name => "player")
       click_link "Export found Players"
       @players.each { |player| should have_content("Select fields to export") }

data/spec/integration/basic/bulk_destroy/rails_admin_basic_bulk_destroy_spec.rb

@@ -14,7 +14,7 @@ describe "RailsAdmin Basic Bulk Destroy" do
       click_button "Yes, I'm sure"
     end
 
-    it "should not contain deleted records" do
+    it "does not contain deleted records" do
       expect(RailsAdmin::AbstractModel.new("Player").count).to eq(1)
       expect(RailsAdmin::History.count).to eq(@delete_ids.count)
       RailsAdmin::History.all.each do |history|
@@ -35,7 +35,7 @@ describe "RailsAdmin Basic Bulk Destroy" do
       click_button "Cancel"
     end
 
-    it "should not delete records" do
+    it "does not delete records" do
       expect(RailsAdmin::AbstractModel.new("Player").count).to eq(3)
     end
   end

data/spec/integration/basic/create/rails_admin_basic_create_spec.rb

@@ -13,7 +13,7 @@ describe "RailsAdmin Basic Create" do
       @player = RailsAdmin::AbstractModel.new("Player").first
     end
 
-    it "should create an object with correct attributes" do
+    it "creates an object with correct attributes" do
       expect(@player.name).to eq("Jackie Robinson")
       expect(@player.number).to eq(42)
       expect(@player.position).to eq("Second baseman")
@@ -32,7 +32,7 @@ describe "RailsAdmin Basic Create" do
       @player = RailsAdmin::AbstractModel.new("Player").first
     end
 
-    it "should create an object with correct attributes" do
+    it "creates an object with correct attributes" do
       expect(@player.name).to eq("Jackie Robinson")
       expect(@player.number).to eq(42)
       expect(@player.position).to eq("Second baseman")
@@ -51,7 +51,7 @@ describe "RailsAdmin Basic Create" do
       @player = RailsAdmin::AbstractModel.new("Player").first
     end
 
-    it "should create an object with correct attributes" do
+    it "creates an object with correct attributes" do
       expect(@player.name).to eq("Jackie Robinson")
       expect(@player.number).to eq(42)
       expect(@player.position).to eq("Second baseman")
@@ -67,7 +67,7 @@ describe "RailsAdmin Basic Create" do
       @player = RailsAdmin::AbstractModel.new("Player").all.last # first is created by FactoryGirl
     end
 
-    it "should create an object with correct associations" do
+    it "creates an object with correct associations" do
       @draft.reload
       expect(@player.draft).to eq(@draft)
     end
@@ -80,7 +80,7 @@ describe "RailsAdmin Basic Create" do
       @league = RailsAdmin::AbstractModel.new("League").all.last
     end
 
-    it "should create an object with correct associations" do
+    it "creates an object with correct associations" do
       @divisions[0].reload
       expect(@league.divisions).to include(@divisions[0])
       expect(@league.divisions).not_to include(@divisions[1])
@@ -95,7 +95,7 @@ describe "RailsAdmin Basic Create" do
       @fan = RailsAdmin::AbstractModel.new("Fan").first
     end
 
-    it "should create an object with correct associations" do
+    it "creates an object with correct associations" do
       @teams[0].reload
       expect(@fan.teams).to include(@teams[0])
       expect(@fan.teams).not_to include(@teams[1])
@@ -111,7 +111,7 @@ describe "RailsAdmin Basic Create" do
       page.driver.post new_path(:model_name => "player", :player => {:name => @player.name, :number => @player.number.to_s, :position => @player.position, :team_id => @team.id})
     end
 
-    it "should show an error message" do
+    it "shows an error message" do
       should have_content("There is already a player with that number on this team")
     end
   end
@@ -121,7 +121,7 @@ describe "RailsAdmin Basic Create" do
       page.driver.post(new_path(:model_name => "player", :id => 1), :params => {:player => {}})
     end
 
-    it "should show an error message" do
+    it "shows an error message" do
       should have_content("Player failed to be created")
       should have_selector "form", :action => "/admin/players"
     end
@@ -134,7 +134,7 @@ describe "RailsAdmin Basic Create" do
       click_button "Save and add another"
     end
 
-    it "should show error base error message in flash" do
+    it "shows error base error message in flash" do
       should have_content("Player failed to be created. Player is cheating")
     end
   end

data/spec/integration/basic/create/rails_admin_namespaced_model_create_spec.rb

@@ -4,7 +4,7 @@ describe "RailsAdmin Namespaced Model Create" do
 
   subject { page }
 
-  it 'should create object with correct attributes' do
+  it "creates object with correct attributes" do
     visit new_path(:model_name => "cms~basic_page")
 
     fill_in "cms_basic_page[title]", :with => "Hello"

data/spec/integration/basic/delete/rails_admin_basic_delete_spec.rb

@@ -5,7 +5,7 @@ describe "RailsAdmin Basic Delete" do
   subject { page }
 
   describe "delete" do
-    it "should show \"Delete model\"" do
+    it "shows \"Delete model\"" do
       @draft = FactoryGirl.create :draft
       @player = @draft.player
       @comment = @player.comments.create
@@ -22,7 +22,7 @@ describe "RailsAdmin Basic Delete" do
       visit delete_path(:model_name => "player", :id => 1)
     end
 
-    it "should raise NotFound" do
+    it "raises NotFound" do
       expect(page.driver.status_code).to eq(404)
     end
   end
@@ -40,7 +40,7 @@ describe "RailsAdmin Basic Delete" do
       visit delete_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should show \"Delete model\"" do
+    it "shows \"Delete model\"" do
       should have_content("delete this player")
       should_not have_selector("a[href=\"/admin/player/#{@player.id}\"]")
       should_not have_selector("a[href=\"/admin/draft/#{@draft.id}\"]")
@@ -55,7 +55,7 @@ describe "RailsAdmin Basic Delete" do
       visit delete_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should show \"Delete model\"" do
+    it "shows \"Delete model\"" do
       should_not have_content("Routing Error")
       should have_content("delete this player")
       should have_link(@player.name, :href => "/admin/player/#{@player.id}")

data/spec/integration/basic/destroy/rails_admin_basic_destroy_spec.rb

@@ -12,11 +12,11 @@ describe "RailsAdmin Basic Destroy" do
       @player = RailsAdmin::AbstractModel.new("Player").first
     end
 
-    it "should destroy an object" do
+    it "destroys an object" do
       expect(@player).to be_nil
     end
 
-    it "should show success message" do
+    it "shows success message" do
       should have_content('Player successfully deleted')
     end
   end
@@ -29,11 +29,11 @@ describe "RailsAdmin Basic Destroy" do
       click_button "Yes, I'm sure"
     end
 
-    it "should not destroy an object" do
+    it "does not destroy an object" do
       expect(@player.reload).to be
     end
 
-    it "should show error message" do
+    it "shows error message" do
       should have_content('Player failed to be deleted')
     end
   end
@@ -46,7 +46,7 @@ describe "RailsAdmin Basic Destroy" do
       @player = RailsAdmin::AbstractModel.new("Player").first
     end
 
-    it "should not destroy an object" do
+    it "does not destroy an object" do
       expect(@player).to be
     end
   end
@@ -56,13 +56,13 @@ describe "RailsAdmin Basic Destroy" do
       page.driver.delete(delete_path(:model_name => "player", :id => 1))
     end
 
-    it "should raise NotFound" do
+    it "raises NotFound" do
       expect(page.driver.status_code).to eq(404)
     end
   end
 
-  describe 'destroy from show page' do
-    it 'should redirect to the index instead of trying to show the deleted object' do
+  describe "destroy from show page" do
+    it "redirects to the index instead of trying to show the deleted object" do
       @player = FactoryGirl.create :player
       visit show_path(:model_name => 'player', :id => @player.id)
       visit delete_path(:model_name => "player", :id => @player.id)
@@ -71,7 +71,7 @@ describe "RailsAdmin Basic Destroy" do
       expect(URI.parse(page.current_url).path).to eq(index_path(:model_name => 'player'))
     end
 
-    it 'should redirect back to the object on error' do
+    it "redirects back to the object on error" do
       Player.any_instance.stub(:destroy_hook).and_return false
       @player = FactoryGirl.create :player
       visit show_path(:model_name => 'player', :id => @player.id)

data/spec/integration/basic/edit/rails_admin_basic_edit_spec.rb

@@ -10,16 +10,16 @@ describe "RailsAdmin Basic Edit" do
       visit edit_path(:model_name => "player", :id => @player.id)
     end
 
-    it "should show \"Edit model\"" do
+    it "shows \"Edit model\"" do
       should have_content("Edit Player")
     end
 
-    it "should show required fields as \"Required\"" do
+    it "shows required fields as \"Required\"" do
       should have_selector("div", :text => /Name\s*Required/)
       should have_selector("div", :text => /Number\s*Required/)
     end
 
-    it "should show non-required fields as \"Optional\"" do
+    it "shows non-required fields as \"Optional\"" do
       expect(find("#player_position_field .help-block")).to have_content("Optional")
       expect(find("#player_born_on_field .help-block")).to have_content("Optional")
       expect(find("#player_notes_field .help-block")).to have_content("Optional")
@@ -27,13 +27,13 @@ describe "RailsAdmin Basic Edit" do
   end
 
   describe "association with inverse_of option" do
-    it "should add a related id to the belongs_to create team link" do
+    it "adds a related id to the belongs_to create team link" do
       @player = FactoryGirl.create :player
       visit edit_path(:model_name => "player", :id => @player.id)
       should have_selector("a", :href => 'admin/teams/new?associations[players]=' + @player.id.to_s)
     end
 
-    it "should add a related id to the has_many create team link" do
+    it "adds a related id to the has_many create team link" do
       @team = FactoryGirl.create :team
       visit edit_path(:model_name => "team", :id => @team.id)
       should have_selector("a", :href => 'admin/players/new?associations[team]=' + @team.id.to_s)
@@ -42,7 +42,7 @@ describe "RailsAdmin Basic Edit" do
 
   describe "readonly associations" do
 
-    it 'should not be editable' do
+    it "is not editable" do
       @league = FactoryGirl.create :league
       visit edit_path(:model_name => "league", :id => @league.id)
       should_not have_selector('select#league_team_ids')
@@ -57,7 +57,7 @@ describe "RailsAdmin Basic Edit" do
       visit edit_path(:model_name => "fan", :id => @fan.id)
     end
 
-    it "should show associated objects" do
+    it "shows associated objects" do
       should have_selector "#fan_team_ids" do |select|
         expect(select[0]).to have_selector 'option[selected="selected"]'
         expect(select[1]).not_to have_selector 'option[selected="selected"]'
@@ -71,7 +71,7 @@ describe "RailsAdmin Basic Edit" do
       visit edit_path(:model_name => "player", :id => 1)
     end
 
-    it "should raise NotFound" do
+    it "raises NotFound" do
       expect(page.driver.status_code).to eq(404)
     end
   end
@@ -90,7 +90,7 @@ describe "RailsAdmin Basic Edit" do
       visit edit_path(:model_name => "ball", :id => @ball.id)
     end
 
-    it "should display a link to the delete page" do
+    it "displays a link to the delete page" do
       should have_selector "a[href='/admin/ball/#{@ball.id}/delete']"
     end
 
@@ -98,7 +98,7 @@ describe "RailsAdmin Basic Edit" do
 
   describe "clicking cancel when editing an object" do
 
-    it "should send back to previous URL" do
+    it "sends back to previous URL" do
       @ball = FactoryGirl.create :ball
       visit '/admin/ball?sort=color'
       click_link 'Edit'