puppet 6.0.7-x64-mingw32 → 6.0.8-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,20 +1,24 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.microsoft_windows? do
5
- let (:name) { 'mysql-5.1.58-win-x64' }
6
- let (:source) { 'E:\Rando\Directory\mysql-5.1.58-win-x64.msi' }
7
- let (:resource) { Puppet::Type.type(:package).new(:name => name, :provider => :windows, :source => source) }
8
- let (:provider) { resource.provider }
9
- let (:execute_options) do {:failonfail => false, :combine => true, :suppress_window => true} end
4
+ let(:name) { 'mysql-5.1.58-win-x64' }
5
+ let(:source) { 'E:\Rando\Directory\mysql-5.1.58-win-x64.msi' }
6
+ let(:resource) { Puppet::Type.type(:package).new(:name => name, :provider => :windows, :source => source) }
7
+ let(:provider) { resource.provider }
8
+ let(:execute_options) do {:failonfail => false, :combine => true, :suppress_window => true} end
10
9
 
11
- before :each do
10
+ before(:each) do
12
11
  # make sure we never try to execute anything
13
- provider.expects(:execute).never
12
+ @times_execute_called = 0
13
+ allow(provider).to receive(:execute) { @times_execute_called += 1}
14
+ end
15
+
16
+ after(:each) do
17
+ expect(@times_execute_called).to eq(0)
14
18
  end
15
19
 
16
20
  def expect_execute(command, status)
17
- provider.expects(:execute).with(command, execute_options).returns(Puppet::Util::Execution::ProcessOutput.new('',status))
21
+ expect(provider).to receive(:execute).with(command, execute_options).and_return(Puppet::Util::Execution::ProcessOutput.new('',status))
18
22
  end
19
23
 
20
24
  describe 'provider features' do
@@ -33,13 +37,13 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
33
37
 
34
38
  context '::instances' do
35
39
  it 'should return an array of provider instances' do
36
- pkg1 = stub('pkg1')
37
- pkg2 = stub('pkg2')
40
+ pkg1 = double('pkg1')
41
+ pkg2 = double('pkg2')
38
42
 
39
- prov1 = stub('prov1', :name => 'pkg1', :version => '1.0.0', :package => pkg1)
40
- prov2 = stub('prov2', :name => 'pkg2', :version => nil, :package => pkg2)
43
+ prov1 = double('prov1', :name => 'pkg1', :version => '1.0.0', :package => pkg1)
44
+ prov2 = double('prov2', :name => 'pkg2', :version => nil, :package => pkg2)
41
45
 
42
- Puppet::Provider::Package::Windows::Package.expects(:map).multiple_yields([prov1], [prov2]).returns([prov1, prov2])
46
+ expect(Puppet::Provider::Package::Windows::Package).to receive(:map).and_yield(prov1).and_yield(prov2).and_return([prov1, prov2])
43
47
 
44
48
  providers = provider.class.instances
45
49
  expect(providers.count).to eq(2)
@@ -53,7 +57,7 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
53
57
  end
54
58
 
55
59
  it 'should return an empty array if none found' do
56
- Puppet::Provider::Package::Windows::Package.expects(:map).returns([])
60
+ expect(Puppet::Provider::Package::Windows::Package).to receive(:map).and_return([])
57
61
 
58
62
  expect(provider.class.instances).to eq([])
59
63
  end
@@ -61,23 +65,23 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
61
65
 
62
66
  context '#query' do
63
67
  it 'should return the hash of the matched packaged' do
64
- pkg = mock(:name => 'pkg1', :version => nil)
65
- pkg.expects(:match?).returns(true)
66
- Puppet::Provider::Package::Windows::Package.expects(:find).yields(pkg)
68
+ pkg = double(:name => 'pkg1', :version => nil)
69
+ expect(pkg).to receive(:match?).and_return(true)
70
+ expect(Puppet::Provider::Package::Windows::Package).to receive(:find).and_yield(pkg)
67
71
 
68
72
  expect(provider.query).to eq({ :name => 'pkg1', :ensure => :installed, :provider => :windows })
69
73
  end
70
74
 
71
75
  it 'should include the version string when present' do
72
- pkg = mock(:name => 'pkg1', :version => '1.0.0')
73
- pkg.expects(:match?).returns(true)
74
- Puppet::Provider::Package::Windows::Package.expects(:find).yields(pkg)
76
+ pkg = double(:name => 'pkg1', :version => '1.0.0')
77
+ expect(pkg).to receive(:match?).and_return(true)
78
+ expect(Puppet::Provider::Package::Windows::Package).to receive(:find).and_yield(pkg)
75
79
 
76
80
  expect(provider.query).to eq({ :name => 'pkg1', :ensure => '1.0.0', :provider => :windows })
77
81
  end
78
82
 
79
83
  it 'should return nil if no package was found' do
80
- Puppet::Provider::Package::Windows::Package.expects(:find)
84
+ expect(Puppet::Provider::Package::Windows::Package).to receive(:find)
81
85
 
82
86
  expect(provider.query).to be_nil
83
87
  end
@@ -85,10 +89,10 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
85
89
 
86
90
  context '#install' do
87
91
  let(:command) { 'blarg.exe /S' }
88
- let(:klass) { mock('installer', :install_command => ['blarg.exe', '/S'] ) }
92
+ let(:klass) { double('installer', :install_command => ['blarg.exe', '/S'] ) }
89
93
  let(:execute_options) do {:failonfail => false, :combine => true, :cwd => nil, :suppress_window => true} end
90
94
  before :each do
91
- Puppet::Provider::Package::Windows::Package.expects(:installer_class).returns(klass)
95
+ expect(Puppet::Provider::Package::Windows::Package).to receive(:installer_class).and_return(klass)
92
96
  end
93
97
 
94
98
  it 'should join the install command and options' do
@@ -107,21 +111,21 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
107
111
 
108
112
  it 'should not warn if the package install succeeds' do
109
113
  expect_execute(command, 0)
110
- provider.expects(:warning).never
114
+ expect(provider).not_to receive(:warning)
111
115
 
112
116
  provider.install
113
117
  end
114
118
 
115
119
  it 'should warn if reboot initiated' do
116
120
  expect_execute(command, 1641)
117
- provider.expects(:warning).with('The package installed successfully and the system is rebooting now.')
121
+ expect(provider).to receive(:warning).with('The package installed successfully and the system is rebooting now.')
118
122
 
119
123
  provider.install
120
124
  end
121
125
 
122
126
  it 'should warn if reboot required' do
123
127
  expect_execute(command, 3010)
124
- provider.expects(:warning).with('The package installed successfully, but the system must be rebooted.')
128
+ expect(provider).to receive(:warning).with('The package installed successfully, but the system must be rebooted.')
125
129
 
126
130
  provider.install
127
131
  end
@@ -141,7 +145,7 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
141
145
  let(:execute_options) do {:failonfail => false, :combine => true, :cwd => 'E:\Rando\Directory', :suppress_window => true} end
142
146
 
143
147
  it 'should not try to set the working directory' do
144
- Puppet::FileSystem.expects(:exist?).with('E:\Rando\Directory').returns(true)
148
+ expect(Puppet::FileSystem).to receive(:exist?).with('E:\Rando\Directory').and_return(true)
145
149
  expect_execute(command, 0)
146
150
 
147
151
  provider.install
@@ -151,7 +155,7 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
151
155
 
152
156
  context '#uninstall' do
153
157
  let(:command) { 'unblarg.exe /Q' }
154
- let(:package) { mock('package', :uninstall_command => ['unblarg.exe', '/Q'] ) }
158
+ let(:package) { double('package', :uninstall_command => ['unblarg.exe', '/Q'] ) }
155
159
 
156
160
  before :each do
157
161
  resource[:ensure] = :absent
@@ -173,21 +177,21 @@ describe Puppet::Type.type(:package).provider(:windows), :if => Puppet.features.
173
177
 
174
178
  it 'should not warn if the package install succeeds' do
175
179
  expect_execute(command, 0)
176
- provider.expects(:warning).never
180
+ expect(provider).not_to receive(:warning)
177
181
 
178
182
  provider.uninstall
179
183
  end
180
184
 
181
185
  it 'should warn if reboot initiated' do
182
186
  expect_execute(command, 1641)
183
- provider.expects(:warning).with('The package uninstalled successfully and the system is rebooting now.')
187
+ expect(provider).to receive(:warning).with('The package uninstalled successfully and the system is rebooting now.')
184
188
 
185
189
  provider.uninstall
186
190
  end
187
191
 
188
192
  it 'should warn if reboot required' do
189
193
  expect_execute(command, 3010)
190
- provider.expects(:warning).with('The package uninstalled successfully, but the system must be rebooted.')
194
+ expect(provider).to receive(:warning).with('The package uninstalled successfully, but the system must be rebooted.')
191
195
 
192
196
  provider.uninstall
193
197
  end
@@ -6,9 +6,9 @@ describe Puppet::Type.type(:package).provider(:yum) do
6
6
  it_behaves_like 'RHEL package provider', described_class, 'yum'
7
7
 
8
8
  it "should have lower specificity" do
9
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
10
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
11
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("22")
9
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
10
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
11
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("22")
12
12
  expect(described_class.specificity).to be < 200
13
13
  end
14
14
 
@@ -28,13 +28,13 @@ describe Puppet::Type.type(:package).provider(:yum) do
28
28
  provider
29
29
  end
30
30
 
31
- before { described_class.stubs(:command).with(:cmd).returns("/usr/bin/yum") }
31
+ before { allow(described_class).to receive(:command).with(:cmd).and_return("/usr/bin/yum") }
32
32
 
33
33
  context "when installing" do
34
34
  it "should use the supplied source as the explicit path to a package to install" do
35
35
  resource[:ensure] = :present
36
36
  resource[:source] = "/foo/bar/baz-1.1.0.rpm"
37
- provider.expects(:execute).with do |arr|
37
+ expect(provider).to receive(:execute) do |arr|
38
38
  expect(arr[-2..-1]).to eq([:install, "/foo/bar/baz-1.1.0.rpm"])
39
39
  end
40
40
  provider.install
@@ -45,10 +45,10 @@ describe Puppet::Type.type(:package).provider(:yum) do
45
45
  it "should use the suppplied source as the explicit path to the package to update" do
46
46
  # The first query response informs yum provider that package 1.1.0 is
47
47
  # already installed, and the second that it's been upgraded
48
- provider.expects(:query).twice.returns({:ensure => "1.1.0"}, {:ensure => "1.2.0"})
48
+ expect(provider).to receive(:query).twice.and_return({:ensure => "1.1.0"}, {:ensure => "1.2.0"})
49
49
  resource[:ensure] = "1.2.0"
50
50
  resource[:source] = "http://foo.repo.com/baz-1.2.0.rpm"
51
- provider.expects(:execute).with do |arr|
51
+ expect(provider).to receive(:execute) do |arr|
52
52
  expect(arr[-2..-1]).to eq(['update', "http://foo.repo.com/baz-1.2.0.rpm"])
53
53
  end
54
54
  provider.install
@@ -3,15 +3,15 @@ require 'spec_helper'
3
3
  describe Puppet::Type.type(:package).provider(:zypper) do
4
4
  before(:each) do
5
5
  # Create a mock resource
6
- @resource = stub 'resource'
6
+ @resource = double('resource')
7
7
 
8
8
  # A catch all; no parameters set
9
- @resource.stubs(:[]).returns(nil)
9
+ allow(@resource).to receive(:[]).and_return(nil)
10
10
 
11
11
  # But set name and source
12
- @resource.stubs(:[]).with(:name).returns "mypackage"
13
- @resource.stubs(:[]).with(:ensure).returns :installed
14
- @resource.stubs(:command).with(:zypper).returns "/usr/bin/zypper"
12
+ allow(@resource).to receive(:[]).with(:name).and_return("mypackage")
13
+ allow(@resource).to receive(:[]).with(:ensure).and_return(:installed)
14
+ allow(@resource).to receive(:command).with(:zypper).and_return("/usr/bin/zypper")
15
15
 
16
16
  @provider = described_class.new(@resource)
17
17
  end
@@ -43,70 +43,70 @@ describe Puppet::Type.type(:package).provider(:zypper) do
43
43
 
44
44
  context "when installing with zypper version >= 1.0" do
45
45
  it "should use a command-line with versioned package'" do
46
- @resource.stubs(:should).with(:ensure).returns "1.2.3-4.5.6"
47
- @resource.stubs(:allow_virtual?).returns false
48
- @provider.stubs(:zypper_version).returns "1.2.8"
46
+ allow(@resource).to receive(:should).with(:ensure).and_return("1.2.3-4.5.6")
47
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
48
+ allow(@provider).to receive(:zypper_version).and_return("1.2.8")
49
49
 
50
- @provider.expects(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage-1.2.3-4.5.6')
51
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
50
+ expect(@provider).to receive(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage-1.2.3-4.5.6')
51
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
52
52
  @provider.install
53
53
  end
54
54
 
55
55
  it "should use a command-line without versioned package" do
56
- @resource.stubs(:should).with(:ensure).returns :latest
57
- @resource.stubs(:allow_virtual?).returns false
58
- @provider.stubs(:zypper_version).returns "1.2.8"
59
- @provider.expects(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--name', 'mypackage')
60
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
56
+ allow(@resource).to receive(:should).with(:ensure).and_return(:latest)
57
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
58
+ allow(@provider).to receive(:zypper_version).and_return("1.2.8")
59
+ expect(@provider).to receive(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--name', 'mypackage')
60
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
61
61
  @provider.install
62
62
  end
63
63
  end
64
64
 
65
65
  context "when installing with zypper version = 0.6.104" do
66
66
  it "should use a command-line with versioned package'" do
67
- @resource.stubs(:should).with(:ensure).returns "1.2.3-4.5.6"
68
- @resource.stubs(:allow_virtual?).returns false
69
- @provider.stubs(:zypper_version).returns "0.6.104"
67
+ allow(@resource).to receive(:should).with(:ensure).and_return("1.2.3-4.5.6")
68
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
69
+ allow(@provider).to receive(:zypper_version).and_return("0.6.104")
70
70
 
71
- @provider.expects(:zypper).with('--terse', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage-1.2.3-4.5.6')
72
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
71
+ expect(@provider).to receive(:zypper).with('--terse', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage-1.2.3-4.5.6')
72
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
73
73
  @provider.install
74
74
  end
75
75
 
76
76
  it "should use a command-line without versioned package" do
77
- @resource.stubs(:should).with(:ensure).returns :latest
78
- @resource.stubs(:allow_virtual?).returns false
79
- @provider.stubs(:zypper_version).returns "0.6.104"
80
- @provider.expects(:zypper).with('--terse', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage')
81
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
77
+ allow(@resource).to receive(:should).with(:ensure).and_return(:latest)
78
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
79
+ allow(@provider).to receive(:zypper_version).and_return("0.6.104")
80
+ expect(@provider).to receive(:zypper).with('--terse', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage')
81
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
82
82
  @provider.install
83
83
  end
84
84
  end
85
85
 
86
86
  context "when installing with zypper version = 0.6.13" do
87
87
  it "should use a command-line with versioned package'" do
88
- @resource.stubs(:should).with(:ensure).returns "1.2.3-4.5.6"
89
- @resource.stubs(:allow_virtual?).returns false
90
- @provider.stubs(:zypper_version).returns "0.6.13"
88
+ allow(@resource).to receive(:should).with(:ensure).and_return("1.2.3-4.5.6")
89
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
90
+ allow(@provider).to receive(:zypper_version).and_return("0.6.13")
91
91
 
92
- @provider.expects(:zypper).with('--terse', :install, '--no-confirm', 'mypackage-1.2.3-4.5.6')
93
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
92
+ expect(@provider).to receive(:zypper).with('--terse', :install, '--no-confirm', 'mypackage-1.2.3-4.5.6')
93
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
94
94
  @provider.install
95
95
  end
96
96
 
97
97
  it "should use a command-line without versioned package" do
98
- @resource.stubs(:should).with(:ensure).returns :latest
99
- @resource.stubs(:allow_virtual?).returns false
100
- @provider.stubs(:zypper_version).returns "0.6.13"
101
- @provider.expects(:zypper).with('--terse', :install, '--no-confirm', 'mypackage')
102
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
98
+ allow(@resource).to receive(:should).with(:ensure).and_return(:latest)
99
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
100
+ allow(@provider).to receive(:zypper_version).and_return("0.6.13")
101
+ expect(@provider).to receive(:zypper).with('--terse', :install, '--no-confirm', 'mypackage')
102
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
103
103
  @provider.install
104
104
  end
105
105
  end
106
106
 
107
107
  context "when updating" do
108
108
  it "should call install method of instance" do
109
- @provider.expects(:install)
109
+ expect(@provider).to receive(:install)
110
110
  @provider.update
111
111
  end
112
112
  end
@@ -117,8 +117,8 @@ describe Puppet::Type.type(:package).provider(:zypper) do
117
117
  context "when the package has available update" do
118
118
  it "should return a version string with valid list-updates data from SLES11sp1" do
119
119
  fake_data = File.read(my_fixture('zypper-list-updates-SLES11sp1.out'))
120
- @resource.stubs(:[]).with(:name).returns "at"
121
- described_class.expects(:zypper).with("list-updates").returns fake_data
120
+ allow(@resource).to receive(:[]).with(:name).and_return("at")
121
+ expect(described_class).to receive(:zypper).with("list-updates").and_return(fake_data)
122
122
  expect(@provider.latest).to eq("3.1.8-1069.18.2")
123
123
  end
124
124
  end
@@ -126,8 +126,8 @@ describe Puppet::Type.type(:package).provider(:zypper) do
126
126
  context "when the package is in the latest version" do
127
127
  it "should return nil with valid list-updates data from SLES11sp1" do
128
128
  fake_data = File.read(my_fixture('zypper-list-updates-SLES11sp1.out'))
129
- @resource.stubs(:[]).with(:name).returns "zypper-log"
130
- described_class.expects(:zypper).with("list-updates").returns fake_data
129
+ allow(@resource).to receive(:[]).with(:name).and_return("zypper-log")
130
+ expect(described_class).to receive(:zypper).with("list-updates").and_return(fake_data)
131
131
  expect(@provider.latest).to eq(nil)
132
132
  end
133
133
  end
@@ -135,8 +135,8 @@ describe Puppet::Type.type(:package).provider(:zypper) do
135
135
  context "when there are no updates available" do
136
136
  it "should return nil" do
137
137
  fake_data_empty = File.read(my_fixture('zypper-list-updates-empty.out'))
138
- @resource.stubs(:[]).with(:name).returns "at"
139
- described_class.expects(:zypper).with("list-updates").returns fake_data_empty
138
+ allow(@resource).to receive(:[]).with(:name).and_return("at")
139
+ expect(described_class).to receive(:zypper).with("list-updates").and_return(fake_data_empty)
140
140
  expect(@provider.latest).to eq(nil)
141
141
  end
142
142
  end
@@ -144,85 +144,85 @@ describe Puppet::Type.type(:package).provider(:zypper) do
144
144
 
145
145
  context "should install a virtual package" do
146
146
  it "when zypper version = 0.6.13" do
147
- @resource.stubs(:should).with(:ensure).returns :installed
148
- @resource.stubs(:allow_virtual?).returns true
149
- @provider.stubs(:zypper_version).returns "0.6.13"
150
- @provider.expects(:zypper).with('--terse', :install, '--no-confirm', 'mypackage')
151
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
147
+ allow(@resource).to receive(:should).with(:ensure).and_return(:installed)
148
+ allow(@resource).to receive(:allow_virtual?).and_return(true)
149
+ allow(@provider).to receive(:zypper_version).and_return("0.6.13")
150
+ expect(@provider).to receive(:zypper).with('--terse', :install, '--no-confirm', 'mypackage')
151
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
152
152
  @provider.install
153
153
  end
154
154
 
155
155
  it "when zypper version >= 1.0.0" do
156
- @resource.stubs(:should).with(:ensure).returns :installed
157
- @resource.stubs(:allow_virtual?).returns true
158
- @provider.stubs(:zypper_version).returns "1.2.8"
159
- @provider.expects(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage')
160
- @provider.expects(:query).returns "mypackage 0 1.2.3 4.5.6 x86_64"
156
+ allow(@resource).to receive(:should).with(:ensure).and_return(:installed)
157
+ allow(@resource).to receive(:allow_virtual?).and_return(true)
158
+ allow(@provider).to receive(:zypper_version).and_return("1.2.8")
159
+ expect(@provider).to receive(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', 'mypackage')
160
+ expect(@provider).to receive(:query).and_return("mypackage 0 1.2.3 4.5.6 x86_64")
161
161
  @provider.install
162
162
  end
163
163
  end
164
164
 
165
165
  context "when installing with zypper install options" do
166
166
  it "should install the package without checking keys" do
167
- @resource.stubs(:[]).with(:name).returns "php5"
168
- @resource.stubs(:[]).with(:install_options).returns ['--no-gpg-check', {'-p' => '/vagrant/files/localrepo/'}]
169
- @resource.stubs(:should).with(:ensure).returns "5.4.10-4.5.6"
170
- @resource.stubs(:allow_virtual?).returns false
171
- @provider.stubs(:zypper_version).returns "1.2.8"
167
+ allow(@resource).to receive(:[]).with(:name).and_return("php5")
168
+ allow(@resource).to receive(:[]).with(:install_options).and_return(['--no-gpg-check', {'-p' => '/vagrant/files/localrepo/'}])
169
+ allow(@resource).to receive(:should).with(:ensure).and_return("5.4.10-4.5.6")
170
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
171
+ allow(@provider).to receive(:zypper_version).and_return("1.2.8")
172
172
 
173
- @provider.expects(:zypper).with('--quiet', '--no-gpg-check', :install,
173
+ expect(@provider).to receive(:zypper).with('--quiet', '--no-gpg-check', :install,
174
174
  '--auto-agree-with-licenses', '--no-confirm', '-p=/vagrant/files/localrepo/', 'php5-5.4.10-4.5.6')
175
- @provider.expects(:query).returns "php5 0 5.4.10 4.5.6 x86_64"
175
+ expect(@provider).to receive(:query).and_return("php5 0 5.4.10 4.5.6 x86_64")
176
176
  @provider.install
177
177
  end
178
178
 
179
179
  it "should install package with hash install options" do
180
- @resource.stubs(:[]).with(:name).returns 'vim'
181
- @resource.stubs(:[]).with(:install_options).returns([{ '--a' => 'foo', '--b' => '"quoted bar"' }])
182
- @resource.stubs(:should).with(:ensure).returns :present
183
- @resource.stubs(:allow_virtual?).returns false
184
-
185
- @provider.stubs(:zypper_version).returns '1.2.8'
186
- @provider.expects(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--a=foo', '--b="quoted bar"', '--name', 'vim')
187
- @provider.expects(:query).returns 'package vim is not installed'
180
+ allow(@resource).to receive(:[]).with(:name).and_return('vim')
181
+ allow(@resource).to receive(:[]).with(:install_options).and_return([{ '--a' => 'foo', '--b' => '"quoted bar"' }])
182
+ allow(@resource).to receive(:should).with(:ensure).and_return(:present)
183
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
184
+
185
+ allow(@provider).to receive(:zypper_version).and_return('1.2.8')
186
+ expect(@provider).to receive(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--a=foo', '--b="quoted bar"', '--name', 'vim')
187
+ expect(@provider).to receive(:query).and_return('package vim is not installed')
188
188
  @provider.install
189
189
  end
190
190
 
191
191
  it "should install package with array install options" do
192
- @resource.stubs(:[]).with(:name).returns 'vim'
193
- @resource.stubs(:[]).with(:install_options).returns([['--a', '--b', '--c']])
194
- @resource.stubs(:should).with(:ensure).returns :present
195
- @resource.stubs(:allow_virtual?).returns false
196
-
197
- @provider.stubs(:zypper_version).returns '1.2.8'
198
- @provider.expects(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--a', '--b', '--c', '--name', 'vim')
199
- @provider.expects(:query).returns 'package vim is not installed'
192
+ allow(@resource).to receive(:[]).with(:name).and_return('vim')
193
+ allow(@resource).to receive(:[]).with(:install_options).and_return([['--a', '--b', '--c']])
194
+ allow(@resource).to receive(:should).with(:ensure).and_return(:present)
195
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
196
+
197
+ allow(@provider).to receive(:zypper_version).and_return('1.2.8')
198
+ expect(@provider).to receive(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--a', '--b', '--c', '--name', 'vim')
199
+ expect(@provider).to receive(:query).and_return('package vim is not installed')
200
200
  @provider.install
201
201
  end
202
202
 
203
203
  it "should install package with string install options" do
204
- @resource.stubs(:[]).with(:name).returns 'vim'
205
- @resource.stubs(:[]).with(:install_options).returns(['--a --b --c'])
206
- @resource.stubs(:should).with(:ensure).returns :present
207
- @resource.stubs(:allow_virtual?).returns false
208
-
209
- @provider.stubs(:zypper_version).returns '1.2.8'
210
- @provider.expects(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--a --b --c', '--name', 'vim')
211
- @provider.expects(:query).returns 'package vim is not installed'
204
+ allow(@resource).to receive(:[]).with(:name).and_return('vim')
205
+ allow(@resource).to receive(:[]).with(:install_options).and_return(['--a --b --c'])
206
+ allow(@resource).to receive(:should).with(:ensure).and_return(:present)
207
+ allow(@resource).to receive(:allow_virtual?).and_return(false)
208
+
209
+ allow(@provider).to receive(:zypper_version).and_return('1.2.8')
210
+ expect(@provider).to receive(:zypper).with('--quiet', :install, '--auto-agree-with-licenses', '--no-confirm', '--a --b --c', '--name', 'vim')
211
+ expect(@provider).to receive(:query).and_return('package vim is not installed')
212
212
  @provider.install
213
213
  end
214
214
  end
215
215
 
216
216
  context 'when uninstalling' do
217
217
  it 'should use remove to uninstall on zypper version 1.6 and above' do
218
- @provider.stubs(:zypper_version).returns '1.6.308'
219
- @provider.expects(:zypper).with(:remove, '--no-confirm', 'mypackage')
218
+ allow(@provider).to receive(:zypper_version).and_return('1.6.308')
219
+ expect(@provider).to receive(:zypper).with(:remove, '--no-confirm', 'mypackage')
220
220
  @provider.uninstall
221
221
  end
222
222
 
223
223
  it 'should use remove --force-solution to uninstall on zypper versions between 1.0 and 1.6' do
224
- @provider.stubs(:zypper_version).returns '1.0.2'
225
- @provider.expects(:zypper).with(:remove, '--no-confirm', '--force-resolution', 'mypackage')
224
+ allow(@provider).to receive(:zypper_version).and_return('1.0.2')
225
+ expect(@provider).to receive(:zypper).with(:remove, '--no-confirm', '--force-resolution', 'mypackage')
226
226
  @provider.uninstall
227
227
  end
228
228
  end