puppet 6.0.7-x64-mingw32 → 6.0.8-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -3,14 +3,14 @@ require 'spec_helper'
3
3
  describe Puppet::Type.type(:package).provider(:freebsd) do
4
4
  before :each do
5
5
  # Create a mock resource
6
- @resource = stub 'resource'
6
+ @resource = double('resource')
7
7
 
8
8
  # A catch all; no parameters set
9
- @resource.stubs(:[]).returns(nil)
9
+ allow(@resource).to receive(:[]).and_return(nil)
10
10
 
11
11
  # But set name and source
12
- @resource.stubs(:[]).with(:name).returns "mypackage"
13
- @resource.stubs(:[]).with(:ensure).returns :installed
12
+ allow(@resource).to receive(:[]).with(:name).and_return("mypackage")
13
+ allow(@resource).to receive(:[]).with(:ensure).and_return(:installed)
14
14
 
15
15
  @provider = subject()
16
16
  @provider.resource = @resource
@@ -23,15 +23,15 @@ describe Puppet::Type.type(:package).provider(:freebsd) do
23
23
 
24
24
  context "when installing" do
25
25
  before :each do
26
- @resource.stubs(:should).with(:ensure).returns(:installed)
26
+ allow(@resource).to receive(:should).with(:ensure).and_return(:installed)
27
27
  end
28
28
 
29
29
  it "should install a package from a path to a directory" do
30
30
  # For better or worse, trailing '/' is needed. --daniel 2011-01-26
31
31
  path = '/path/to/directory/'
32
- @resource.stubs(:[]).with(:source).returns(path)
33
- Puppet::Util.expects(:withenv).once.with({:PKG_PATH => path}).yields
34
- @provider.expects(:pkgadd).once.with("mypackage")
32
+ allow(@resource).to receive(:[]).with(:source).and_return(path)
33
+ expect(Puppet::Util).to receive(:withenv).once.with({:PKG_PATH => path}).and_yield
34
+ expect(@provider).to receive(:pkgadd).once.with("mypackage")
35
35
 
36
36
  expect { @provider.install }.to_not raise_error
37
37
  end
@@ -40,9 +40,9 @@ describe Puppet::Type.type(:package).provider(:freebsd) do
40
40
  it "should install a package via #{protocol}" do
41
41
  # For better or worse, trailing '/' is needed. --daniel 2011-01-26
42
42
  path = "#{protocol}://localhost/"
43
- @resource.stubs(:[]).with(:source).returns(path)
44
- Puppet::Util.expects(:withenv).once.with({:PACKAGESITE => path}).yields
45
- @provider.expects(:pkgadd).once.with('-r', "mypackage")
43
+ allow(@resource).to receive(:[]).with(:source).and_return(path)
44
+ expect(Puppet::Util).to receive(:withenv).once.with({:PACKAGESITE => path}).and_yield
45
+ expect(@provider).to receive(:pkgadd).once.with('-r', "mypackage")
46
46
 
47
47
  expect { @provider.install }.to_not raise_error
48
48
  end
@@ -21,39 +21,43 @@ context Puppet::Type.type(:package).provider(:gem) do
21
21
 
22
22
  context "when installing" do
23
23
  it "should use the path to the gem" do
24
- described_class.stubs(:command).with(:gemcmd).returns "/my/gem"
25
- provider.expects(:execute).with { |args| args[0] == "/my/gem" }.returns ""
24
+ allow(described_class).to receive(:command).with(:gemcmd).and_return("/my/gem")
25
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[0]).to eq("/my/gem") }.and_return("")
26
26
  provider.install
27
27
  end
28
28
 
29
29
  it "should specify that the gem is being installed" do
30
- provider.expects(:execute).with { |args| args[1] == "install" }.returns ""
30
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[1]).to eq("install") }.and_return("")
31
31
  provider.install
32
32
  end
33
33
 
34
34
  it "should specify that documentation should not be included" do
35
- provider.expects(:execute).with { |args| args[2] == "--no-rdoc" }.returns ""
35
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("--no-rdoc") }.and_return("")
36
36
  provider.install
37
37
  end
38
38
 
39
39
  it "should specify that RI should not be included" do
40
- provider.expects(:execute).with { |args| args[3] == "--no-ri" }.returns ""
40
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[3]).to eq("--no-ri") }.and_return("")
41
41
  provider.install
42
42
  end
43
43
 
44
44
  it "should specify the package name" do
45
- provider.expects(:execute).with { |args| args[4] == "myresource" }.returns ""
45
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[4]).to eq("myresource") }.and_return("")
46
46
  provider.install
47
47
  end
48
48
 
49
49
  it "should not append install_options by default" do
50
- provider.expects(:execute).with { |args| args.length == 5 }.returns ""
50
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args.length).to eq(5) }.and_return("")
51
51
  provider.install
52
52
  end
53
53
 
54
54
  it "should allow setting an install_options parameter" do
55
55
  resource[:install_options] = [ '--force', {'--bindir' => '/usr/bin' } ]
56
- provider.expects(:execute).with { |args| args[2] == '--force' && args[3] == '--bindir=/usr/bin' }.returns ''
56
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) do |args|
57
+ expect(args[2]).to eq('--force')
58
+ expect(args[3]).to eq('--bindir=/usr/bin')
59
+ end.and_return('')
60
+
57
61
  provider.install
58
62
  end
59
63
 
@@ -61,7 +65,7 @@ context Puppet::Type.type(:package).provider(:gem) do
61
65
  context "as a normal file" do
62
66
  it "should use the file name instead of the gem name" do
63
67
  resource[:source] = "/my/file"
64
- provider.expects(:execute).with { |args| args[2] == "/my/file" }.returns ""
68
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("/my/file") }.and_return("")
65
69
  provider.install
66
70
  end
67
71
  end
@@ -69,7 +73,7 @@ context Puppet::Type.type(:package).provider(:gem) do
69
73
  context "as a file url" do
70
74
  it "should use the file name instead of the gem name" do
71
75
  resource[:source] = "file:///my/file"
72
- provider.expects(:execute).with { |args| args[2] == "/my/file" }.returns ""
76
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("/my/file") }.and_return("")
73
77
  provider.install
74
78
  end
75
79
  end
@@ -84,7 +88,7 @@ context Puppet::Type.type(:package).provider(:gem) do
84
88
  context "as a non-file and non-puppet url" do
85
89
  it "should treat the source as a gem repository" do
86
90
  resource[:source] = "http://host/my/file"
87
- provider.expects(:execute).with { |args| args[2..4] == ["--source", "http://host/my/file", "myresource"] }.returns ""
91
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2..4]).to eq(["--source", "http://host/my/file", "myresource"]) }.and_return("")
88
92
  provider.install
89
93
  end
90
94
  end
@@ -92,14 +96,14 @@ context Puppet::Type.type(:package).provider(:gem) do
92
96
  context "as a windows path on windows", :if => Puppet::Util::Platform.windows? do
93
97
  it "should treat the source as a local path" do
94
98
  resource[:source] = "c:/this/is/a/path/to/a/gem.gem"
95
- provider.expects(:execute).with { |args| args[2] == "c:/this/is/a/path/to/a/gem.gem" }.returns ""
99
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("c:/this/is/a/path/to/a/gem.gem") }.and_return("")
96
100
  provider.install
97
101
  end
98
102
  end
99
103
 
100
104
  context "with an invalid uri" do
101
105
  it "should fail" do
102
- URI.expects(:parse).raises(ArgumentError)
106
+ expect(URI).to receive(:parse).and_raise(ArgumentError)
103
107
  resource[:source] = "http:::::uppet:/:/my/file"
104
108
  expect { provider.install }.to raise_error(Puppet::Error)
105
109
  end
@@ -112,7 +116,7 @@ context Puppet::Type.type(:package).provider(:gem) do
112
116
  #gemlist is used for retrieving both local and remote version numbers, and there are cases
113
117
  # (particularly local) where it makes sense for it to return an array. That doesn't make
114
118
  # sense for '#latest', though.
115
- provider.class.expects(:gemlist).with({ :justme => 'myresource'}).returns({
119
+ expect(provider.class).to receive(:gemlist).with({:justme => 'myresource'}).and_return({
116
120
  :name => 'myresource',
117
121
  :ensure => ["3.0"],
118
122
  :provider => :gem,
@@ -122,29 +126,29 @@ context Puppet::Type.type(:package).provider(:gem) do
122
126
 
123
127
  it "should list from the specified source repository" do
124
128
  resource[:source] = "http://foo.bar.baz/gems"
125
- provider.class.expects(:gemlist).
129
+ expect(provider.class).to receive(:gemlist).
126
130
  with({:justme => 'myresource', :source => "http://foo.bar.baz/gems"}).
127
- returns({
131
+ and_return({
128
132
  :name => 'myresource',
129
133
  :ensure => ["3.0"],
130
134
  :provider => :gem,
131
135
  })
132
- expect(provider.latest).to eq("3.0")
136
+ expect(provider.latest).to eq("3.0")
133
137
  end
134
138
  end
135
139
 
136
140
  context "#instances" do
137
141
  before do
138
- described_class.stubs(:command).with(:gemcmd).returns "/my/gem"
142
+ allow(described_class).to receive(:command).with(:gemcmd).and_return("/my/gem")
139
143
  end
140
144
 
141
145
  it "should return an empty array when no gems installed" do
142
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns("\n")
146
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return("\n")
143
147
  expect(described_class.instances).to eq([])
144
148
  end
145
149
 
146
150
  it "should return ensure values as an array of installed versions" do
147
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns <<-HEREDOC.gsub(/ /, '')
151
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return(<<-HEREDOC.gsub(/ /, ''))
148
152
  systemu (1.2.0)
149
153
  vagrant (0.8.7, 0.6.9)
150
154
  HEREDOC
@@ -156,7 +160,7 @@ context Puppet::Type.type(:package).provider(:gem) do
156
160
  end
157
161
 
158
162
  it "should ignore platform specifications" do
159
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns <<-HEREDOC.gsub(/ /, '')
163
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return(<<-HEREDOC.gsub(/ /, ''))
160
164
  systemu (1.2.0)
161
165
  nokogiri (1.6.1 ruby java x86-mingw32 x86-mswin32-60, 1.4.4.1 x86-mswin32)
162
166
  HEREDOC
@@ -168,7 +172,7 @@ context Puppet::Type.type(:package).provider(:gem) do
168
172
  end
169
173
 
170
174
  it "should not list 'default: ' text from rubygems''" do
171
- described_class.expects(:execute).with(%w{/my/gem list --local}, anything).returns <<-HEREDOC.gsub(/ /, '')
175
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, anything).and_return(<<-HEREDOC.gsub(/ /, ''))
172
176
  bundler (1.16.1, default: 1.16.0, 1.15.1)
173
177
  HEREDOC
174
178
 
@@ -178,27 +182,27 @@ context Puppet::Type.type(:package).provider(:gem) do
178
182
  end
179
183
 
180
184
  it "should not fail when an unmatched line is returned" do
181
- described_class.expects(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).
182
- returns(File.read(my_fixture('line-with-1.8.5-warning')))
185
+ expect(described_class).to receive(:execute).with(%w{/my/gem list --local}, {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).
186
+ and_return(File.read(my_fixture('line-with-1.8.5-warning')))
183
187
 
184
188
  expect(described_class.instances.map {|p| p.properties}).
185
- to eq([{:provider=>:gem, :ensure=>["0.3.2"], :name=>"columnize"},
186
- {:provider=>:gem, :ensure=>["1.1.3"], :name=>"diff-lcs"},
187
- {:provider=>:gem, :ensure=>["0.0.1"], :name=>"metaclass"},
188
- {:provider=>:gem, :ensure=>["0.10.5"], :name=>"mocha"},
189
- {:provider=>:gem, :ensure=>["0.8.7"], :name=>"rake"},
190
- {:provider=>:gem, :ensure=>["2.9.0"], :name=>"rspec-core"},
191
- {:provider=>:gem, :ensure=>["2.9.1"], :name=>"rspec-expectations"},
192
- {:provider=>:gem, :ensure=>["2.9.0"], :name=>"rspec-mocks"},
193
- {:provider=>:gem, :ensure=>["0.9.0"], :name=>"rubygems-bundler"},
194
- {:provider=>:gem, :ensure=>["1.11.3.3"], :name=>"rvm"}])
189
+ to eq([{provider: :gem, ensure: ["0.3.2"], name: "columnize"},
190
+ {provider: :gem, ensure: ["1.1.3"], name: "diff-lcs"},
191
+ {provider: :gem, ensure: ["0.0.1"], name: "metaclass"},
192
+ {provider: :gem, ensure: ["0.10.5"], name: "mocha"},
193
+ {provider: :gem, ensure: ["0.8.7"], name: "rake"},
194
+ {provider: :gem, ensure: ["2.9.0"], name: "rspec-core"},
195
+ {provider: :gem, ensure: ["2.9.1"], name: "rspec-expectations"},
196
+ {provider: :gem, ensure: ["2.9.0"], name: "rspec-mocks"},
197
+ {provider: :gem, ensure: ["0.9.0"], name: "rubygems-bundler"},
198
+ {provider: :gem, ensure: ["1.11.3.3"], name: "rvm"}])
195
199
  end
196
200
  end
197
201
 
198
202
  context "listing gems" do
199
203
  context "searching for a single package" do
200
204
  it "searches for an exact match" do
201
- described_class.expects(:execute).with(includes('\Abundler\z'), {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).returns(File.read(my_fixture('gem-list-single-package')))
205
+ expect(described_class).to receive(:execute).with(include('\Abundler\z'), {:failonfail => true, :combine => true, :custom_environment => {"HOME"=>ENV["HOME"]}}).and_return(File.read(my_fixture('gem-list-single-package')))
202
206
  expected = {:name => 'bundler', :ensure => %w[1.6.2], :provider => :gem}
203
207
  expect(described_class.gemlist({:justme => 'bundler'})).to eq(expected)
204
208
  end
@@ -296,39 +300,43 @@ context Puppet::Type.type(:package).provider(:gem) do
296
300
 
297
301
  context "when uninstalling" do
298
302
  it "should use the path to the gem" do
299
- described_class.stubs(:command).with(:gemcmd).returns "/my/gem"
300
- provider.expects(:execute).with { |args| args[0] == "/my/gem" }.returns ""
303
+ allow(described_class).to receive(:command).with(:gemcmd).and_return("/my/gem")
304
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[0]).to eq("/my/gem") }.and_return("")
301
305
  provider.uninstall
302
306
  end
303
307
 
304
308
  it "should specify that the gem is being uninstalled" do
305
- provider.expects(:execute).with { |args| args[1] == "uninstall" }.returns ""
309
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[1]).to eq("uninstall") }.and_return("")
306
310
  provider.uninstall
307
311
  end
308
312
 
309
313
  it "should specify that the relevant executables should be removed without confirmation" do
310
- provider.expects(:execute).with { |args| args[2] == "--executables" }.returns ""
314
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[2]).to eq("--executables") }.and_return("")
311
315
  provider.uninstall
312
316
  end
313
317
 
314
318
  it "should specify that all the matching versions should be removed" do
315
- provider.expects(:execute).with { |args| args[3] == "--all" }.returns ""
319
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[3]).to eq("--all") }.and_return("")
316
320
  provider.uninstall
317
321
  end
318
322
 
319
323
  it "should specify the package name" do
320
- provider.expects(:execute).with { |args| args[4] == "myresource" }.returns ""
324
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args[4]).to eq("myresource") }.and_return("")
321
325
  provider.uninstall
322
326
  end
323
327
 
324
328
  it "should not append uninstall_options by default" do
325
- provider.expects(:execute).with { |args| args.length == 5 }.returns ""
329
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) { |args| expect(args.length).to eq(5) }.and_return("")
326
330
  provider.uninstall
327
331
  end
328
332
 
329
333
  it "should allow setting an uninstall_options parameter" do
330
334
  resource[:uninstall_options] = [ '--ignore-dependencies', {'--version' => '0.1.1' } ]
331
- provider.expects(:execute).with { |args| args[5] == '--ignore-dependencies' && args[6] == '--version=0.1.1' }.returns ''
335
+ expect(provider).to receive(:execute).with(be_a(Array), be_a(Hash)) do |args|
336
+ expect(args[5]).to eq('--ignore-dependencies')
337
+ expect(args[6]).to eq('--version=0.1.1')
338
+ end.and_return('')
339
+
332
340
  provider.uninstall
333
341
  end
334
342
  end
@@ -3,18 +3,18 @@ require 'spec_helper'
3
3
  describe Puppet::Type.type(:package).provider(:hpux) do
4
4
  before(:each) do
5
5
  # Create a mock resource
6
- @resource = stub 'resource'
6
+ @resource = double('resource')
7
7
 
8
8
  # A catch all; no parameters set
9
- @resource.stubs(:[]).returns(nil)
9
+ allow(@resource).to receive(:[]).and_return(nil)
10
10
 
11
11
  # But set name and source
12
- @resource.stubs(:[]).with(:name).returns "mypackage"
13
- @resource.stubs(:[]).with(:source).returns "mysource"
14
- @resource.stubs(:[]).with(:ensure).returns :installed
12
+ allow(@resource).to receive(:[]).with(:name).and_return("mypackage")
13
+ allow(@resource).to receive(:[]).with(:source).and_return("mysource")
14
+ allow(@resource).to receive(:[]).with(:ensure).and_return(:installed)
15
15
 
16
16
  @provider = subject()
17
- @provider.stubs(:resource).returns @resource
17
+ allow(@provider).to receive(:resource).and_return(@resource)
18
18
  end
19
19
 
20
20
  it "should have an install method" do
@@ -34,14 +34,14 @@ describe Puppet::Type.type(:package).provider(:hpux) do
34
34
 
35
35
  context "when installing" do
36
36
  it "should use a command-line like 'swinstall -x mount_all_filesystems=false -s SOURCE PACKAGE-NAME'" do
37
- @provider.expects(:swinstall).with('-x', 'mount_all_filesystems=false', '-s', 'mysource', 'mypackage')
37
+ expect(@provider).to receive(:swinstall).with('-x', 'mount_all_filesystems=false', '-s', 'mysource', 'mypackage')
38
38
  @provider.install
39
39
  end
40
40
  end
41
41
 
42
42
  context "when uninstalling" do
43
43
  it "should use a command-line like 'swremove -x mount_all_filesystems=false PACKAGE-NAME'" do
44
- @provider.expects(:swremove).with('-x', 'mount_all_filesystems=false', 'mypackage')
44
+ expect(@provider).to receive(:swremove).with('-x', 'mount_all_filesystems=false', 'mypackage')
45
45
  @provider.uninstall
46
46
  end
47
47
  end
@@ -11,7 +11,7 @@ describe Puppet::Type.type(:package).provider(:macports) do
11
11
 
12
12
  let :provider do
13
13
  prov = resource.provider
14
- prov.expects(:execute).never
14
+ expect(prov).not_to receive(:execute)
15
15
  prov
16
16
  end
17
17
 
@@ -30,17 +30,17 @@ describe Puppet::Type.type(:package).provider(:macports) do
30
30
 
31
31
  context "when listing all instances" do
32
32
  it "should call port -q installed" do
33
- described_class.expects(:port).with("-q", :installed).returns("")
33
+ expect(described_class).to receive(:port).with("-q", :installed).and_return("")
34
34
  described_class.instances
35
35
  end
36
36
 
37
37
  it "should create instances from active ports" do
38
- described_class.expects(:port).returns("foo @1.234.5_2 (active)")
38
+ expect(described_class).to receive(:port).and_return("foo @1.234.5_2 (active)")
39
39
  expect(described_class.instances.size).to eq(1)
40
40
  end
41
41
 
42
42
  it "should ignore ports that aren't activated" do
43
- described_class.expects(:port).returns("foo @1.234.5_2")
43
+ expect(described_class).to receive(:port).and_return("foo @1.234.5_2")
44
44
  expect(described_class.instances.size).to eq(0)
45
45
  end
46
46
 
@@ -52,68 +52,72 @@ describe Puppet::Type.type(:package).provider(:macports) do
52
52
  end
53
53
 
54
54
  context "when installing" do
55
- it "should not specify a version when ensure is set to latest" do
56
- resource[:ensure] = :latest
57
- provider.expects(:port).with { |flag, method, name, version|
58
- expect(version).to be_nil
59
- }
60
- provider.install
61
- end
62
-
63
- it "should not specify a version when ensure is set to present" do
64
- resource[:ensure] = :present
65
- provider.expects(:port).with { |flag, method, name, version|
66
- expect(version).to be_nil
67
- }
68
- provider.install
69
- end
70
-
71
- it "should specify a version when ensure is set to a version" do
72
- resource[:ensure] = "1.2.3"
73
- provider.expects(:port).with { |flag, method, name, version|
74
- expect(version).to be
75
- }
76
- provider.install
77
- end
55
+ it "should not specify a version when ensure is set to latest" do
56
+ resource[:ensure] = :latest
57
+ # version would be the 4th argument, if provided.
58
+ expect(provider).to receive(:port).with(anything, anything, anything)
59
+
60
+ provider.install
61
+ end
62
+
63
+ it "should not specify a version when ensure is set to present" do
64
+ resource[:ensure] = :present
65
+ # version would be the 4th argument, if provided.
66
+ expect(provider).to receive(:port).with(anything, anything, anything)
67
+
68
+ provider.install
69
+ end
70
+
71
+ it "should specify a version when ensure is set to a version" do
72
+ resource[:ensure] = "1.2.3"
73
+ expect(provider).to receive(:port).with(anything, anything, anything, '@1.2.3')
74
+
75
+ provider.install
76
+ end
78
77
  end
79
78
 
80
79
  context "when querying for the latest version" do
81
- let :new_info_line do
80
+ # Redefine provider to avoid the "expect(prov).not_to receive(:execute)"
81
+ # that was set in the original definition.
82
+ let(:provider) { resource.provider }
83
+ let(:new_info_line) do
82
84
  "1.2.3 2"
83
85
  end
84
- let :infoargs do
86
+ let(:infoargs) do
85
87
  ["/opt/local/bin/port", "-q", :info, "--line", "--version", "--revision", resource_name]
86
88
  end
87
- let(:arguments) do {:failonfail => false, :combine => false} end
89
+ let(:arguments) do
90
+ {:failonfail => false, :combine => false}
91
+ end
88
92
 
89
93
  before :each do
90
- provider.stubs(:command).with(:port).returns("/opt/local/bin/port")
94
+ allow(provider).to receive(:command).with(:port).and_return("/opt/local/bin/port")
91
95
  end
92
96
 
93
97
  it "should return nil when the package cannot be found" do
94
98
  resource[:name] = resource_name
95
- provider.expects(:execute).with(infoargs, arguments).returns("")
99
+ expect(provider).to receive(:execute).with(infoargs, arguments).and_return("")
96
100
  expect(provider.latest).to eq(nil)
97
101
  end
98
102
 
99
103
  it "should return the current version if the installed port has the same revision" do
100
104
  current_hash[:revision] = "2"
101
- provider.expects(:execute).with(infoargs, arguments).returns(new_info_line)
102
- provider.expects(:query).returns(current_hash)
105
+ expect(provider).to receive(:execute).with(infoargs, arguments).and_return(new_info_line)
106
+ expect(provider).to receive(:query).and_return(current_hash)
103
107
  expect(provider.latest).to eq(current_hash[:ensure])
104
108
  end
105
109
 
106
110
  it "should return the new version_revision if the installed port has a lower revision" do
107
111
  current_hash[:revision] = "1"
108
- provider.expects(:execute).with(infoargs, arguments).returns(new_info_line)
109
- provider.expects(:query).returns(current_hash)
112
+ expect(provider).to receive(:execute).with(infoargs, arguments).and_return(new_info_line)
113
+ expect(provider).to receive(:query).and_return(current_hash)
110
114
  expect(provider.latest).to eq("1.2.3_2")
111
115
  end
112
116
 
113
117
  it "should return the newest version if the port is not installed" do
114
118
  resource[:name] = resource_name
115
- provider.expects(:execute).with(infoargs, arguments).returns(new_info_line)
116
- provider.expects(:execute).with(["/opt/local/bin/port", "-q", :installed, resource[:name]], arguments).returns("")
119
+ expect(provider).to receive(:execute).with(infoargs, arguments).and_return(new_info_line)
120
+ expect(provider).to receive(:execute).with(["/opt/local/bin/port", "-q", :installed, resource[:name]], arguments).and_return("")
117
121
  expect(provider.latest).to eq("1.2.3_2")
118
122
  end
119
123
  end
@@ -122,16 +126,16 @@ describe Puppet::Type.type(:package).provider(:macports) do
122
126
  it "should execute port install if the port is installed" do
123
127
  resource[:name] = resource_name
124
128
  resource[:ensure] = :present
125
- provider.stubs(:query).returns(current_hash)
126
- provider.expects(:port).with("-q", :install, resource_name)
129
+ allow(provider).to receive(:query).and_return(current_hash)
130
+ expect(provider).to receive(:port).with("-q", :install, resource_name)
127
131
  provider.update
128
132
  end
129
133
 
130
134
  it "should execute port install if the port is not installed" do
131
135
  resource[:name] = resource_name
132
136
  resource[:ensure] = :present
133
- provider.stubs(:query).returns("")
134
- provider.expects(:port).with("-q", :install, resource_name)
137
+ allow(provider).to receive(:query).and_return("")
138
+ expect(provider).to receive(:port).with("-q", :install, resource_name)
135
139
  provider.update
136
140
  end
137
141
  end