puppet 6.0.7-x64-mingw32 → 6.0.8-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -9,8 +9,8 @@ describe Puppet::Provider::Command do
9
9
  let(:executable) { "foo" }
10
10
  let(:executable_absolute_path) { "/foo/bar" }
11
11
 
12
- let(:executor) { mock('executor') }
13
- let(:resolver) { mock('resolver') }
12
+ let(:executor) { double('executor') }
13
+ let(:resolver) { double('resolver') }
14
14
 
15
15
  let(:path_resolves_to_itself) do
16
16
  resolves = Object.new
@@ -23,37 +23,37 @@ describe Puppet::Provider::Command do
23
23
  end
24
24
 
25
25
  it "executes a simple command" do
26
- executor.expects(:execute).with([executable], no_options)
26
+ expect(executor).to receive(:execute).with([executable], no_options)
27
27
 
28
28
  command = Puppet::Provider::Command.new(name, executable, path_resolves_to_itself, executor)
29
29
  command.execute()
30
30
  end
31
31
 
32
32
  it "executes a command with extra options" do
33
- executor.expects(:execute).with([executable], the_options)
33
+ expect(executor).to receive(:execute).with([executable], the_options)
34
34
 
35
35
  command = Puppet::Provider::Command.new(name, executable, path_resolves_to_itself, executor, the_options)
36
36
  command.execute()
37
37
  end
38
38
 
39
39
  it "executes a command with arguments" do
40
- executor.expects(:execute).with([executable, "arg1", "arg2"], no_options)
40
+ expect(executor).to receive(:execute).with([executable, "arg1", "arg2"], no_options)
41
41
 
42
42
  command = Puppet::Provider::Command.new(name, executable, path_resolves_to_itself, executor)
43
43
  command.execute("arg1", "arg2")
44
44
  end
45
45
 
46
46
  it "resolves to an absolute path for better execution" do
47
- resolver.expects(:which).with(executable).returns(executable_absolute_path)
48
- executor.expects(:execute).with([executable_absolute_path], no_options)
47
+ expect(resolver).to receive(:which).with(executable).and_return(executable_absolute_path)
48
+ expect(executor).to receive(:execute).with([executable_absolute_path], no_options)
49
49
 
50
50
  command = Puppet::Provider::Command.new(name, executable, resolver, executor)
51
51
  command.execute()
52
52
  end
53
53
 
54
54
  it "errors when the executable resolves to nothing" do
55
- resolver.expects(:which).with(executable).returns(nil)
56
- executor.expects(:execute).never
55
+ expect(resolver).to receive(:which).with(executable).and_return(nil)
56
+ expect(executor).not_to receive(:execute)
57
57
 
58
58
  command = Puppet::Provider::Command.new(name, executable, resolver, executor)
59
59
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix? do
@@ -51,7 +50,7 @@ describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix
51
50
 
52
51
  it "should fail if the command isn't executable" do
53
52
  FileUtils.touch(command)
54
- File.stubs(:executable?).with(command).returns(false)
53
+ allow(File).to receive(:executable?).with(command).and_return(false)
55
54
 
56
55
  expect { provider.run(command) }.to raise_error(ArgumentError, "'#{command}' is not executable")
57
56
  end
@@ -63,7 +62,7 @@ describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix
63
62
  provider.resource[:path] = [File.dirname(command)]
64
63
  filename = File.basename(command)
65
64
 
66
- Puppet::Util::Execution.expects(:execute).with(filename, instance_of(Hash)).returns(Puppet::Util::Execution::ProcessOutput.new('', 0))
65
+ expect(Puppet::Util::Execution).to receive(:execute).with(filename, instance_of(Hash)).and_return(Puppet::Util::Execution::ProcessOutput.new('', 0))
67
66
 
68
67
  provider.run(filename)
69
68
  end
@@ -77,7 +76,7 @@ describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix
77
76
  it "should fail if the command is in the path but not executable" do
78
77
  command = make_exe
79
78
  File.chmod(0644, command)
80
- FileTest.stubs(:executable?).with(command).returns(false)
79
+ allow(FileTest).to receive(:executable?).with(command).and_return(false)
81
80
  resource[:path] = [File.dirname(command)]
82
81
  filename = File.basename(command)
83
82
 
@@ -94,7 +93,7 @@ describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix
94
93
  provider.resource[:path] = ['/bogus/bin']
95
94
  command = make_exe
96
95
 
97
- Puppet::Util::Execution.expects(:execute).with("#{command} bar --sillyarg=true --blah", instance_of(Hash)).returns(Puppet::Util::Execution::ProcessOutput.new('', 0))
96
+ expect(Puppet::Util::Execution).to receive(:execute).with("#{command} bar --sillyarg=true --blah", instance_of(Hash)).and_return(Puppet::Util::Execution::ProcessOutput.new('', 0))
98
97
 
99
98
  provider.run("#{command} bar --sillyarg=true --blah")
100
99
  end
@@ -110,7 +109,7 @@ describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix
110
109
  provider.resource[:environment] = ['WHATEVER=/something/else', 'WHATEVER=/foo']
111
110
  command = make_exe
112
111
 
113
- Puppet::Util::Execution.expects(:execute).with(command, instance_of(Hash)).returns(Puppet::Util::Execution::ProcessOutput.new('', 0))
112
+ expect(Puppet::Util::Execution).to receive(:execute).with(command, instance_of(Hash)).and_return(Puppet::Util::Execution::ProcessOutput.new('', 0))
114
113
 
115
114
  provider.run(command)
116
115
 
@@ -119,7 +118,7 @@ describe Puppet::Type.type(:exec).provider(:posix), :if => Puppet.features.posix
119
118
 
120
119
  it "should set umask before execution if umask parameter is in use" do
121
120
  provider.resource[:umask] = '0027'
122
- Puppet::Util.expects(:withumask).with(0027)
121
+ expect(Puppet::Util).to receive(:withumask).with(0027)
123
122
  provider.run(provider.resource[:command])
124
123
  end
125
124
 
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:exec).provider(:shell),
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
 
5
3
  describe Puppet::Type.type(:exec).provider(:windows), :if => Puppet::Util::Platform.windows? do
@@ -68,12 +66,12 @@ describe Puppet::Type.type(:exec).provider(:windows), :if => Puppet::Util::Platf
68
66
  describe "when the command is relative" do
69
67
  describe "and a path is specified" do
70
68
  before :each do
71
- provider.stubs(:which)
69
+ allow(provider).to receive(:which)
72
70
  end
73
71
 
74
72
  it "should search for executables with no extension" do
75
73
  provider.resource[:path] = [File.expand_path('/bogus/bin')]
76
- provider.expects(:which).with('foo').returns('foo')
74
+ expect(provider).to receive(:which).with('foo').and_return('foo')
77
75
 
78
76
  provider.checkexe('foo')
79
77
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
  require 'puppet/provider/exec'
4
3
 
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
 
5
3
  describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix? do
@@ -41,7 +39,7 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
41
39
 
42
40
  describe "#uid2name" do
43
41
  it "should return the name of the user identified by the id" do
44
- Etc.stubs(:getpwuid).with(501).returns(Struct::Passwd.new('jilluser', nil, 501))
42
+ allow(Etc).to receive(:getpwuid).with(501).and_return(Struct::Passwd.new('jilluser', nil, 501))
45
43
 
46
44
  expect(provider.uid2name(501)).to eq('jilluser')
47
45
  end
@@ -55,7 +53,7 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
55
53
  end
56
54
 
57
55
  it "should return nil if the user doesn't exist" do
58
- Etc.expects(:getpwuid).raises(ArgumentError, "can't find user for 999")
56
+ expect(Etc).to receive(:getpwuid).and_raise(ArgumentError, "can't find user for 999")
59
57
 
60
58
  expect(provider.uid2name(999)).to eq(nil)
61
59
  end
@@ -65,8 +63,8 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
65
63
  it "should return the id of the user if it exists" do
66
64
  passwd = Struct::Passwd.new('bobbo', nil, 502)
67
65
 
68
- Etc.stubs(:getpwnam).with('bobbo').returns(passwd)
69
- Etc.stubs(:getpwuid).with(502).returns(passwd)
66
+ allow(Etc).to receive(:getpwnam).with('bobbo').and_return(passwd)
67
+ allow(Etc).to receive(:getpwuid).with(502).and_return(passwd)
70
68
 
71
69
  expect(provider.name2uid('bobbo')).to eq(502)
72
70
  end
@@ -76,7 +74,7 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
76
74
  end
77
75
 
78
76
  it "should return false if the user doesn't exist" do
79
- Etc.stubs(:getpwnam).with('chuck').raises(ArgumentError, "can't find user for chuck")
77
+ allow(Etc).to receive(:getpwnam).with('chuck').and_raise(ArgumentError, "can't find user for chuck")
80
78
 
81
79
  expect(provider.name2uid('chuck')).to eq(false)
82
80
  end
@@ -95,8 +93,8 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
95
93
  end
96
94
 
97
95
  it "should warn and return :silly if the value is beyond the maximum uid" do
98
- stat = stub('stat', :uid => Puppet[:maximum_uid] + 1)
99
- resource.stubs(:stat).returns(stat)
96
+ stat = double('stat', :uid => Puppet[:maximum_uid] + 1)
97
+ allow(resource).to receive(:stat).and_return(stat)
100
98
 
101
99
  expect(provider.owner).to eq(:silly)
102
100
  expect(@logs).to be_any {|log| log.level == :warning and log.message =~ /Apparently using negative UID/}
@@ -105,27 +103,27 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
105
103
 
106
104
  describe "#owner=" do
107
105
  it "should set the owner but not the group of the file" do
108
- File.expects(:lchown).with(15, nil, resource[:path])
106
+ expect(File).to receive(:lchown).with(15, nil, resource[:path])
109
107
 
110
108
  provider.owner = 15
111
109
  end
112
110
 
113
111
  it "should chown a link if managing links" do
114
112
  resource[:links] = :manage
115
- File.expects(:lchown).with(20, nil, resource[:path])
113
+ expect(File).to receive(:lchown).with(20, nil, resource[:path])
116
114
 
117
115
  provider.owner = 20
118
116
  end
119
117
 
120
118
  it "should chown a link target if following links" do
121
119
  resource[:links] = :follow
122
- File.expects(:chown).with(20, nil, resource[:path])
120
+ expect(File).to receive(:chown).with(20, nil, resource[:path])
123
121
 
124
122
  provider.owner = 20
125
123
  end
126
124
 
127
125
  it "should pass along any error encountered setting the owner" do
128
- File.expects(:lchown).raises(ArgumentError)
126
+ expect(File).to receive(:lchown).and_raise(ArgumentError)
129
127
 
130
128
  expect { provider.owner = 25 }.to raise_error(Puppet::Error, /Failed to set owner to '25'/)
131
129
  end
@@ -133,7 +131,7 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
133
131
 
134
132
  describe "#gid2name" do
135
133
  it "should return the name of the group identified by the id" do
136
- Etc.stubs(:getgrgid).with(501).returns(Struct::Passwd.new('unicorns', nil, nil, 501))
134
+ allow(Etc).to receive(:getgrgid).with(501).and_return(Struct::Passwd.new('unicorns', nil, nil, 501))
137
135
 
138
136
  expect(provider.gid2name(501)).to eq('unicorns')
139
137
  end
@@ -147,7 +145,7 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
147
145
  end
148
146
 
149
147
  it "should return nil if the group doesn't exist" do
150
- Etc.expects(:getgrgid).raises(ArgumentError, "can't find group for 999")
148
+ expect(Etc).to receive(:getgrgid).and_raise(ArgumentError, "can't find group for 999")
151
149
 
152
150
  expect(provider.gid2name(999)).to eq(nil)
153
151
  end
@@ -157,8 +155,8 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
157
155
  it "should return the id of the group if it exists" do
158
156
  passwd = Struct::Passwd.new('penguins', nil, nil, 502)
159
157
 
160
- Etc.stubs(:getgrnam).with('penguins').returns(passwd)
161
- Etc.stubs(:getgrgid).with(502).returns(passwd)
158
+ allow(Etc).to receive(:getgrnam).with('penguins').and_return(passwd)
159
+ allow(Etc).to receive(:getgrgid).with(502).and_return(passwd)
162
160
 
163
161
  expect(provider.name2gid('penguins')).to eq(502)
164
162
  end
@@ -168,7 +166,7 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
168
166
  end
169
167
 
170
168
  it "should return false if the group doesn't exist" do
171
- Etc.stubs(:getgrnam).with('wombats').raises(ArgumentError, "can't find group for wombats")
169
+ allow(Etc).to receive(:getgrnam).with('wombats').and_raise(ArgumentError, "can't find group for wombats")
172
170
 
173
171
  expect(provider.name2gid('wombats')).to eq(false)
174
172
  end
@@ -188,8 +186,8 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
188
186
  end
189
187
 
190
188
  it "should warn and return :silly if the value is beyond the maximum gid" do
191
- stat = stub('stat', :gid => Puppet[:maximum_uid] + 1)
192
- resource.stubs(:stat).returns(stat)
189
+ stat = double('stat', :gid => Puppet[:maximum_uid] + 1)
190
+ allow(resource).to receive(:stat).and_return(stat)
193
191
 
194
192
  expect(provider.group).to eq(:silly)
195
193
  expect(@logs).to be_any {|log| log.level == :warning and log.message =~ /Apparently using negative GID/}
@@ -198,27 +196,27 @@ describe Puppet::Type.type(:file).provider(:posix), :if => Puppet.features.posix
198
196
 
199
197
  describe "#group=" do
200
198
  it "should set the group but not the owner of the file" do
201
- File.expects(:lchown).with(nil, 15, resource[:path])
199
+ expect(File).to receive(:lchown).with(nil, 15, resource[:path])
202
200
 
203
201
  provider.group = 15
204
202
  end
205
203
 
206
204
  it "should change the group for a link if managing links" do
207
205
  resource[:links] = :manage
208
- File.expects(:lchown).with(nil, 20, resource[:path])
206
+ expect(File).to receive(:lchown).with(nil, 20, resource[:path])
209
207
 
210
208
  provider.group = 20
211
209
  end
212
210
 
213
211
  it "should change the group for a link target if following links" do
214
212
  resource[:links] = :follow
215
- File.expects(:chown).with(nil, 20, resource[:path])
213
+ expect(File).to receive(:chown).with(nil, 20, resource[:path])
216
214
 
217
215
  provider.group = 20
218
216
  end
219
217
 
220
218
  it "should pass along any error encountered setting the group" do
221
- File.expects(:lchown).raises(ArgumentError)
219
+ expect(File).to receive(:lchown).and_raise(ArgumentError)
222
220
 
223
221
  expect { provider.group = 25 }.to raise_error(Puppet::Error, /Failed to set group to '25'/)
224
222
  end
@@ -1,5 +1,3 @@
1
- #! /usr/bin/env ruby
2
-
3
1
  require 'spec_helper'
4
2
  if Puppet::Util::Platform.windows?
5
3
  require 'puppet/util/windows'
@@ -49,22 +47,22 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
49
47
 
50
48
  describe "#id2name" do
51
49
  it "should return the name of the user identified by the sid" do
52
- Puppet::Util::Windows::SID.expects(:valid_sid?).with(sid).returns(true)
53
- Puppet::Util::Windows::SID.expects(:sid_to_name).with(sid).returns(account)
50
+ expect(Puppet::Util::Windows::SID).to receive(:valid_sid?).with(sid).and_return(true)
51
+ expect(Puppet::Util::Windows::SID).to receive(:sid_to_name).with(sid).and_return(account)
54
52
 
55
53
  expect(provider.id2name(sid)).to eq(account)
56
54
  end
57
55
 
58
56
  it "should return the argument if it's already a name" do
59
- Puppet::Util::Windows::SID.expects(:valid_sid?).with(account).returns(false)
60
- Puppet::Util::Windows::SID.expects(:sid_to_name).never
57
+ expect(Puppet::Util::Windows::SID).to receive(:valid_sid?).with(account).and_return(false)
58
+ expect(Puppet::Util::Windows::SID).not_to receive(:sid_to_name)
61
59
 
62
60
  expect(provider.id2name(account)).to eq(account)
63
61
  end
64
62
 
65
63
  it "should return nil if the user doesn't exist" do
66
- Puppet::Util::Windows::SID.expects(:valid_sid?).with(sid).returns(true)
67
- Puppet::Util::Windows::SID.expects(:sid_to_name).with(sid).returns(nil)
64
+ expect(Puppet::Util::Windows::SID).to receive(:valid_sid?).with(sid).and_return(true)
65
+ expect(Puppet::Util::Windows::SID).to receive(:sid_to_name).with(sid).and_return(nil)
68
66
 
69
67
  expect(provider.id2name(sid)).to eq(nil)
70
68
  end
@@ -72,7 +70,7 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
72
70
 
73
71
  describe "#name2id" do
74
72
  it "should delegate to name_to_sid" do
75
- Puppet::Util::Windows::SID.expects(:name_to_sid).with(account).returns(sid)
73
+ expect(Puppet::Util::Windows::SID).to receive(:name_to_sid).with(account).and_return(sid)
76
74
 
77
75
  expect(provider.name2id(account)).to eq(sid)
78
76
  end
@@ -81,7 +79,7 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
81
79
  describe "#owner" do
82
80
  it "should return the sid of the owner if the file does exist" do
83
81
  FileUtils.touch(resource[:path])
84
- provider.stubs(:get_owner).with(resource[:path]).returns(sid)
82
+ allow(provider).to receive(:get_owner).with(resource[:path]).and_return(sid)
85
83
 
86
84
  expect(provider.owner).to eq(sid)
87
85
  end
@@ -93,12 +91,12 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
93
91
 
94
92
  describe "#owner=" do
95
93
  it "should set the owner to the specified value" do
96
- provider.expects(:set_owner).with(sid, resource[:path])
94
+ expect(provider).to receive(:set_owner).with(sid, resource[:path])
97
95
  provider.owner = sid
98
96
  end
99
97
 
100
98
  it "should propagate any errors encountered when setting the owner" do
101
- provider.stubs(:set_owner).raises(ArgumentError)
99
+ allow(provider).to receive(:set_owner).and_raise(ArgumentError)
102
100
 
103
101
  expect {
104
102
  provider.owner = sid
@@ -109,7 +107,7 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
109
107
  describe "#group" do
110
108
  it "should return the sid of the group if the file does exist" do
111
109
  FileUtils.touch(resource[:path])
112
- provider.stubs(:get_group).with(resource[:path]).returns(sid)
110
+ allow(provider).to receive(:get_group).with(resource[:path]).and_return(sid)
113
111
 
114
112
  expect(provider.group).to eq(sid)
115
113
  end
@@ -121,12 +119,12 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
121
119
 
122
120
  describe "#group=" do
123
121
  it "should set the group to the specified value" do
124
- provider.expects(:set_group).with(sid, resource[:path])
122
+ expect(provider).to receive(:set_group).with(sid, resource[:path])
125
123
  provider.group = sid
126
124
  end
127
125
 
128
126
  it "should propagate any errors encountered when setting the group" do
129
- provider.stubs(:set_group).raises(ArgumentError)
127
+ allow(provider).to receive(:set_group).and_raise(ArgumentError)
130
128
 
131
129
  expect {
132
130
  provider.group = sid
@@ -137,7 +135,7 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
137
135
  describe "when validating" do
138
136
  {:owner => 'foo', :group => 'foo', :mode => '0777'}.each do |k,v|
139
137
  it "should fail if the filesystem doesn't support ACLs and we're managing #{k}" do
140
- described_class.any_instance.stubs(:supports_acl?).returns false
138
+ allow_any_instance_of(described_class).to receive(:supports_acl?).and_return(false)
141
139
 
142
140
  expect {
143
141
  Puppet::Type.type(:file).new :path => path, k => v
@@ -146,7 +144,7 @@ describe Puppet::Type.type(:file).provider(:windows), :if => Puppet::Util::Platf
146
144
  end
147
145
 
148
146
  it "should not fail if the filesystem doesn't support ACLs and we're not managing permissions" do
149
- described_class.any_instance.stubs(:supports_acl?).returns false
147
+ allow_any_instance_of(described_class).to receive(:supports_acl?).and_return(false)
150
148
 
151
149
  Puppet::Type.type(:file).new :path => path
152
150
  end
@@ -9,6 +9,7 @@ describe 'Puppet::Type::Group::Provider::Aix' do
9
9
  :ensure => :present
10
10
  )
11
11
  end
12
+
12
13
  let(:provider) do
13
14
  provider_class.new(resource)
14
15
  end
@@ -33,7 +34,7 @@ describe 'Puppet::Type::Group::Provider::Aix' do
33
34
  end
34
35
 
35
36
  before(:each) do
36
- provider_class.stubs(:list_all).with(ia_module_args).returns(groups)
37
+ allow(provider_class).to receive(:list_all).with(ia_module_args).and_return(groups)
37
38
  end
38
39
 
39
40
  it 'raises an ArgumentError if the group does not exist' do
@@ -78,7 +79,7 @@ describe 'Puppet::Type::Group::Provider::Aix' do
78
79
  before(:each) do
79
80
  resource[:auth_membership] = false
80
81
 
81
- provider.stubs(:members).returns(['user3', 'user1'])
82
+ allow(provider).to receive(:members).and_return(['user3', 'user1'])
82
83
  end
83
84
 
84
85
  it 'adds the passed-in members to the current list of members, filtering out any duplicates' do
@@ -1,14 +1,15 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
3
+ RSpec::Matchers.define_negated_matcher :excluding, :include
4
+
4
5
  describe Puppet::Type.type(:group).provider(:groupadd) do
5
6
  before do
6
- described_class.stubs(:command).with(:add).returns '/usr/sbin/groupadd'
7
- described_class.stubs(:command).with(:delete).returns '/usr/sbin/groupdel'
8
- described_class.stubs(:command).with(:modify).returns '/usr/sbin/groupmod'
9
- described_class.stubs(:command).with(:localadd).returns '/usr/sbin/lgroupadd'
10
- described_class.stubs(:command).with(:localdelete).returns '/usr/sbin/lgroupdel'
11
- described_class.stubs(:command).with(:localmodify).returns '/usr/sbin/lgroupmod'
7
+ allow(described_class).to receive(:command).with(:add).and_return('/usr/sbin/groupadd')
8
+ allow(described_class).to receive(:command).with(:delete).and_return('/usr/sbin/groupdel')
9
+ allow(described_class).to receive(:command).with(:modify).and_return('/usr/sbin/groupmod')
10
+ allow(described_class).to receive(:command).with(:localadd).and_return('/usr/sbin/lgroupadd')
11
+ allow(described_class).to receive(:command).with(:localdelete).and_return('/usr/sbin/lgroupdel')
12
+ allow(described_class).to receive(:command).with(:localmodify).and_return('/usr/sbin/lgroupmod')
12
13
  end
13
14
 
14
15
  let(:resource) { Puppet::Type.type(:group).new(:name => 'mygroup', :provider => provider) }
@@ -16,19 +17,19 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
16
17
 
17
18
  describe "#create" do
18
19
  before do
19
- provider.stubs(:exists?).returns(false)
20
+ allow(provider).to receive(:exists?).and_return(false)
20
21
  end
21
22
 
22
23
  it "should add -o when allowdupe is enabled and the group is being created" do
23
24
  resource[:allowdupe] = :true
24
- provider.expects(:execute).with(['/usr/sbin/groupadd', '-o', 'mygroup'], kind_of(Hash))
25
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupadd', '-o', 'mygroup'], kind_of(Hash))
25
26
  provider.create
26
27
  end
27
28
 
28
29
  describe "on system that feature system_groups", :if => described_class.system_groups? do
29
30
  it "should add -r when system is enabled and the group is being created" do
30
31
  resource[:system] = :true
31
- provider.expects(:execute).with(['/usr/sbin/groupadd', '-r', 'mygroup'], kind_of(Hash))
32
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupadd', '-r', 'mygroup'], kind_of(Hash))
32
33
  provider.create
33
34
  end
34
35
  end
@@ -36,7 +37,7 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
36
37
  describe "on system that do not feature system_groups", :unless => described_class.system_groups? do
37
38
  it "should not add -r when system is enabled and the group is being created" do
38
39
  resource[:system] = :true
39
- provider.expects(:execute).with(['/usr/sbin/groupadd', 'mygroup'], kind_of(Hash))
40
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupadd', 'mygroup'], kind_of(Hash))
40
41
  provider.create
41
42
  end
42
43
  end
@@ -48,29 +49,29 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
48
49
  end
49
50
 
50
51
  it "should use lgroupadd instead of groupadd" do
51
- provider.expects(:execute).with(includes('/usr/sbin/lgroupadd'), has_entry(:custom_environment, has_key('LIBUSER_CONF')))
52
+ expect(provider).to receive(:execute).with(including('/usr/sbin/lgroupadd'), hash_including(:custom_environment => hash_including('LIBUSER_CONF')))
52
53
  provider.create
53
54
  end
54
55
 
55
56
  it "should NOT pass -o to lgroupadd" do
56
57
  resource[:allowdupe] = :true
57
- provider.expects(:execute).with(Not(includes('-o')), has_entry(:custom_environment, has_key('LIBUSER_CONF')))
58
+ expect(provider).to receive(:execute).with(excluding('-o'), hash_including(:custom_environment => hash_including('LIBUSER_CONF')))
58
59
  provider.create
59
60
  end
60
61
 
61
62
  it "should raise an exception for duplicate GID if allowdupe is not set and duplicate GIDs exist" do
62
63
  resource[:gid] = 505
63
- provider.stubs(:findgroup).returns(true)
64
+ allow(provider).to receive(:findgroup).and_return(true)
64
65
  expect { provider.create }.to raise_error(Puppet::Error, "GID 505 already exists, use allowdupe to force group creation")
65
66
  end
66
67
  end
67
-
68
68
  end
69
69
 
70
70
  describe "#modify" do
71
71
  before do
72
- provider.stubs(:exists?).returns(true)
72
+ allow(provider).to receive(:exists?).and_return(true)
73
73
  end
74
+
74
75
  describe "on systems with the libuser and forcelocal=false" do
75
76
  before do
76
77
  described_class.has_feature(:libuser)
@@ -78,16 +79,17 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
78
79
  end
79
80
 
80
81
  it "should use groupmod" do
81
- provider.expects(:execute).with(['/usr/sbin/groupmod', '-g', 150, 'mygroup'], has_entries({:failonfail => true, :combine => true, :custom_environment => {}}))
82
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupmod', '-g', 150, 'mygroup'], hash_including({:failonfail => true, :combine => true, :custom_environment => {}}))
82
83
  provider.gid = 150
83
84
  end
84
85
 
85
86
  it "should pass -o to groupmod" do
86
87
  resource[:allowdupe] = :true
87
- provider.expects(:execute).with(['/usr/sbin/groupmod', '-g', 150, '-o', 'mygroup'], has_entries({:failonfail => true, :combine => true, :custom_environment => {}}))
88
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupmod', '-g', 150, '-o', 'mygroup'], hash_including({:failonfail => true, :combine => true, :custom_environment => {}}))
88
89
  provider.gid = 150
89
90
  end
90
91
  end
92
+
91
93
  describe "on systems with the libuser and forcelocal=true" do
92
94
  before do
93
95
  described_class.has_feature(:libuser)
@@ -95,19 +97,20 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
95
97
  end
96
98
 
97
99
  it "should use lgroupmod instead of groupmod" do
98
- provider.expects(:execute).with(['/usr/sbin/lgroupmod', '-g', 150, 'mygroup'], has_entry(:custom_environment, has_key('LIBUSER_CONF')))
100
+ expect(provider).to receive(:execute).with(['/usr/sbin/lgroupmod', '-g', 150, 'mygroup'], hash_including(:custom_environment => hash_including('LIBUSER_CONF')))
99
101
  provider.gid = 150
100
102
  end
101
103
 
102
104
  it "should NOT pass -o to lgroupmod" do
103
105
  resource[:allowdupe] = :true
104
- provider.expects(:execute).with(['/usr/sbin/lgroupmod', '-g', 150, 'mygroup'], has_entry(:custom_environment, has_key('LIBUSER_CONF')))
106
+ expect(provider).to receive(:execute).with(['/usr/sbin/lgroupmod', '-g', 150, 'mygroup'], hash_including(:custom_environment => hash_including('LIBUSER_CONF')))
105
107
  provider.gid = 150
106
108
  end
109
+
107
110
  it "should raise an exception for duplicate GID if allowdupe is not set and duplicate GIDs exist" do
108
111
  resource[:gid] = 150
109
112
  resource[:allowdupe] = :false
110
- provider.stubs(:findgroup).returns(true)
113
+ allow(provider).to receive(:findgroup).and_return(true)
111
114
  expect { provider.gid = 150 }.to raise_error(Puppet::Error, "GID 150 already exists, use allowdupe to force group creation")
112
115
  end
113
116
  end
@@ -116,15 +119,16 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
116
119
  describe "#gid=" do
117
120
  it "should add -o when allowdupe is enabled and the gid is being modified" do
118
121
  resource[:allowdupe] = :true
119
- provider.expects(:execute).with(['/usr/sbin/groupmod', '-g', 150, '-o', 'mygroup'], has_entries({:failonfail => true, :combine => true, :custom_environment => {}}))
122
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupmod', '-g', 150, '-o', 'mygroup'], hash_including({:failonfail => true, :combine => true, :custom_environment => {}}))
120
123
  provider.gid = 150
121
124
  end
122
125
  end
123
126
 
124
127
  describe "#delete" do
125
128
  before do
126
- provider.stubs(:exists?).returns(true)
129
+ allow(provider).to receive(:exists?).and_return(true)
127
130
  end
131
+
128
132
  describe "on systems with the libuser and forcelocal=false" do
129
133
  before do
130
134
  described_class.has_feature(:libuser)
@@ -132,10 +136,11 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
132
136
  end
133
137
 
134
138
  it "should use groupdel" do
135
- provider.expects(:execute).with(['/usr/sbin/groupdel', 'mygroup'], has_entries({:failonfail => true, :combine => true, :custom_environment => {}}))
139
+ expect(provider).to receive(:execute).with(['/usr/sbin/groupdel', 'mygroup'], hash_including({:failonfail => true, :combine => true, :custom_environment => {}}))
136
140
  provider.delete
137
141
  end
138
142
  end
143
+
139
144
  describe "on systems with the libuser and forcelocal=true" do
140
145
  before do
141
146
  described_class.has_feature(:libuser)
@@ -143,10 +148,9 @@ describe Puppet::Type.type(:group).provider(:groupadd) do
143
148
  end
144
149
 
145
150
  it "should use lgroupdel instead of groupdel" do
146
- provider.expects(:execute).with(['/usr/sbin/lgroupdel', 'mygroup'], has_entry(:custom_environment, has_key('LIBUSER_CONF')))
151
+ expect(provider).to receive(:execute).with(['/usr/sbin/lgroupdel', 'mygroup'], hash_including(:custom_environment => hash_including('LIBUSER_CONF')))
147
152
  provider.delete
148
153
  end
149
154
  end
150
155
  end
151
156
  end
152
-