puppet 6.0.7-x64-mingw32 → 6.0.8-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -17,7 +17,7 @@ describe Puppet::Type.type(:package).provider(:apt) do
17
17
  end
18
18
 
19
19
  it "should be the default provider on :osfamily => Debian" do
20
- Facter.expects(:value).with(:osfamily).returns("Debian")
20
+ expect(Facter).to receive(:value).with(:osfamily).and_return("Debian")
21
21
  expect(described_class.default?).to be_truthy
22
22
  end
23
23
 
@@ -26,38 +26,40 @@ describe Puppet::Type.type(:package).provider(:apt) do
26
26
  end
27
27
 
28
28
  it "should use :install to update" do
29
- provider.expects(:install)
29
+ expect(provider).to receive(:install)
30
30
  provider.update
31
31
  end
32
32
 
33
33
  it "should use 'apt-get remove' to uninstall" do
34
- provider.expects(:aptget).with("-y", "-q", :remove, name)
34
+ expect(provider).to receive(:aptget).with("-y", "-q", :remove, name)
35
35
  provider.uninstall
36
36
  end
37
37
 
38
38
  it "should use 'apt-get purge' and 'dpkg purge' to purge" do
39
- provider.expects(:aptget).with("-y", "-q", :remove, "--purge", name)
40
- provider.expects(:dpkg).with("--purge", name)
39
+ expect(provider).to receive(:aptget).with("-y", "-q", :remove, "--purge", name)
40
+ expect(provider).to receive(:dpkg).with("--purge", name)
41
41
  provider.purge
42
42
  end
43
43
 
44
44
  it "should use 'apt-cache policy' to determine the latest version of a package" do
45
- provider.expects(:aptcache).with(:policy, name).returns "#{name}:
45
+ expect(provider).to receive(:aptcache).with(:policy, name).and_return(<<-HERE)
46
+ #{name}:
46
47
  Installed: 1:1.0
47
48
  Candidate: 1:1.1
48
49
  Version table:
49
50
  1:1.0
50
51
  650 http://ftp.osuosl.org testing/main Packages
51
52
  *** 1:1.1
52
- 100 /var/lib/dpkg/status"
53
+ 100 /var/lib/dpkg/status
54
+ HERE
53
55
 
54
56
  expect(provider.latest).to eq("1:1.1")
55
57
  end
56
58
 
57
59
  it "should print and error and return nil if no policy is found" do
58
- provider.expects(:aptcache).with(:policy, name).returns "#{name}:"
60
+ expect(provider).to receive(:aptcache).with(:policy, name).and_return("#{name}:")
59
61
 
60
- provider.expects(:err)
62
+ expect(provider).to receive(:err)
61
63
  expect(provider.latest).to be_nil
62
64
  end
63
65
 
@@ -67,17 +69,17 @@ Version table:
67
69
 
68
70
  it "should preseed with the provided responsefile when preseeding is called for" do
69
71
  resource[:responsefile] = '/my/file'
70
- Puppet::FileSystem.expects(:exist?).with('/my/file').returns true
72
+ expect(Puppet::FileSystem).to receive(:exist?).with('/my/file').and_return(true)
71
73
 
72
- provider.expects(:info)
73
- provider.expects(:preseed).with('/my/file')
74
+ expect(provider).to receive(:info)
75
+ expect(provider).to receive(:preseed).with('/my/file')
74
76
 
75
77
  provider.run_preseed
76
78
  end
77
79
 
78
80
  it "should not preseed if no responsefile is provided" do
79
- provider.expects(:info)
80
- provider.expects(:preseed).never
81
+ expect(provider).to receive(:info)
82
+ expect(provider).not_to receive(:preseed)
81
83
 
82
84
  provider.run_preseed
83
85
  end
@@ -85,76 +87,91 @@ Version table:
85
87
  describe "when installing" do
86
88
  it "should preseed if a responsefile is provided" do
87
89
  resource[:responsefile] = "/my/file"
88
- provider.expects(:run_preseed)
90
+ expect(provider).to receive(:run_preseed)
89
91
 
90
- provider.stubs(:aptget)
92
+ allow(provider).to receive(:aptget)
91
93
  provider.install
92
94
  end
93
95
 
94
96
  it "should check for a cdrom" do
95
- provider.expects(:checkforcdrom)
97
+ expect(provider).to receive(:checkforcdrom)
96
98
 
97
- provider.stubs(:aptget)
99
+ allow(provider).to receive(:aptget)
98
100
  provider.install
99
101
  end
100
102
 
101
103
  it "should use 'apt-get install' with the package name if no version is asked for" do
102
104
  resource[:ensure] = :installed
103
- provider.expects(:aptget).with { |*command| command[-1] == name and command[-2] == :install }
105
+ expect(provider).to receive(:aptget) do |*command|
106
+ expect(command[-1]).to eq(name)
107
+ expect(command[-2]).to eq(:install)
108
+ end
104
109
 
105
110
  provider.install
106
111
  end
107
112
 
108
113
  it "should specify the package version if one is asked for" do
109
114
  resource[:ensure] = '1.0'
110
- provider.expects(:aptget).with { |*command| command[-1] == "#{name}=1.0" }
115
+ expect(provider).to receive(:aptget) do |*command|
116
+ expect(command[-1]).to eq("#{name}=1.0")
117
+ end
111
118
 
112
119
  provider.install
113
120
  end
114
121
 
115
122
  it "should use --force-yes if a package version is specified" do
116
123
  resource[:ensure] = '1.0'
117
- provider.expects(:aptget).with { |*command| command.include?("--force-yes") }
124
+ expect(provider).to receive(:aptget) do |*command|
125
+ expect(command).to include("--force-yes")
126
+ end
118
127
 
119
128
  provider.install
120
129
  end
121
130
 
122
131
  it "should do a quiet install" do
123
- provider.expects(:aptget).with { |*command| command.include?("-q") }
132
+ expect(provider).to receive(:aptget) do |*command|
133
+ expect(command).to include("-q")
134
+ end
124
135
 
125
136
  provider.install
126
137
  end
127
138
 
128
139
  it "should default to 'yes' for all questions" do
129
- provider.expects(:aptget).with { |*command| command.include?("-y") }
140
+ expect(provider).to receive(:aptget) do |*command|
141
+ expect(command).to include("-y")
142
+ end
130
143
 
131
144
  provider.install
132
145
  end
133
146
 
134
147
  it "should keep config files if asked" do
135
148
  resource[:configfiles] = :keep
136
- provider.expects(:aptget).with { |*command| command.include?("DPkg::Options::=--force-confold") }
149
+ expect(provider).to receive(:aptget) do |*command|
150
+ expect(command).to include("DPkg::Options::=--force-confold")
151
+ end
137
152
 
138
153
  provider.install
139
154
  end
140
155
 
141
156
  it "should replace config files if asked" do
142
157
  resource[:configfiles] = :replace
143
- provider.expects(:aptget).with { |*command| command.include?("DPkg::Options::=--force-confnew") }
158
+ expect(provider).to receive(:aptget) do |*command|
159
+ expect(command).to include("DPkg::Options::=--force-confnew")
160
+ end
144
161
 
145
162
  provider.install
146
163
  end
147
164
 
148
165
  it 'should support string install options' do
149
166
  resource[:install_options] = ['--foo', '--bar']
150
- provider.expects(:aptget).with('-q', '-y', '-o', 'DPkg::Options::=--force-confold', '--foo', '--bar', :install, name)
167
+ expect(provider).to receive(:aptget).with('-q', '-y', '-o', 'DPkg::Options::=--force-confold', '--foo', '--bar', :install, name)
151
168
 
152
169
  provider.install
153
170
  end
154
171
 
155
172
  it 'should support hash install options' do
156
173
  resource[:install_options] = ['--foo', { '--bar' => 'baz', '--baz' => 'foo' }]
157
- provider.expects(:aptget).with('-q', '-y', '-o', 'DPkg::Options::=--force-confold', '--foo', '--bar=baz', '--baz=foo', :install, name)
174
+ expect(provider).to receive(:aptget).with('-q', '-y', '-o', 'DPkg::Options::=--force-confold', '--foo', '--bar=baz', '--baz=foo', :install, name)
158
175
 
159
176
  provider.install
160
177
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:package).provider(:aptitude) do
@@ -13,17 +12,17 @@ describe Puppet::Type.type(:package).provider(:aptitude) do
13
12
  let(:dpkgquery_path) { '/bin/dpkg-query' }
14
13
 
15
14
  before do
16
- Puppet::Util.stubs(:which).with('/usr/bin/dpkg-query').returns(dpkgquery_path)
15
+ allow(Puppet::Util).to receive(:which).with('/usr/bin/dpkg-query').and_return(dpkgquery_path)
17
16
  end
18
17
 
19
18
  { :absent => "deinstall ok config-files faff 1.2.3-1\n",
20
19
  "1.2.3-1" => "install ok installed faff 1.2.3-1\n",
21
20
  }.each do |expect, output|
22
21
  it "detects #{expect} packages" do
23
- Puppet::Util::Execution.expects(:execute).with(
22
+ expect(Puppet::Util::Execution).to receive(:execute).with(
24
23
  [dpkgquery_path, '-W', '--showformat', "'${Status} ${Package} ${Version}\\n'", 'faff'],
25
24
  {:failonfail => true, :combine => true, :custom_environment => {}}
26
- ).returns(Puppet::Util::Execution::ProcessOutput.new(output, 0))
25
+ ).and_return(Puppet::Util::Execution::ProcessOutput.new(output, 0))
27
26
 
28
27
  expect(pkg.property(:ensure).retrieve).to eq(expect)
29
28
  end
@@ -31,15 +30,15 @@ describe Puppet::Type.type(:package).provider(:aptitude) do
31
30
  end
32
31
 
33
32
  it "installs when asked" do
34
- pkg.provider.expects(:aptitude).
33
+ expect(pkg.provider).to receive(:aptitude).
35
34
  with('-y', '-o', 'DPkg::Options::=--force-confold', :install, 'faff').
36
- returns(0)
35
+ and_return(0)
37
36
 
38
37
  pkg.provider.install
39
38
  end
40
39
 
41
40
  it "purges when asked" do
42
- pkg.provider.expects(:aptitude).with('-y', 'purge', 'faff').returns(0)
41
+ expect(pkg.provider).to receive(:aptitude).with('-y', 'purge', 'faff').and_return(0)
43
42
  pkg.provider.purge
44
43
  end
45
44
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  describe Puppet::Type.type(:package).provider(:aptrpm) do
@@ -11,37 +10,33 @@ describe Puppet::Type.type(:package).provider(:aptrpm) do
11
10
 
12
11
  context "when retrieving ensure" do
13
12
  before(:each) do
14
- Puppet::Util.stubs(:which).with("rpm").returns("/bin/rpm")
15
- pkg.provider.stubs(:which).with("rpm").returns("/bin/rpm")
16
- Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "--version"], {:combine => true, :custom_environment => {}, :failonfail => true}).returns(Puppet::Util::Execution::ProcessOutput.new("4.10.1\n", 0)).at_most_once
13
+ allow(Puppet::Util).to receive(:which).with("rpm").and_return("/bin/rpm")
14
+ allow(pkg.provider).to receive(:which).with("rpm").and_return("/bin/rpm")
15
+ expect(Puppet::Util::Execution).to receive(:execute).with(["/bin/rpm", "--version"], {:combine => true, :custom_environment => {}, :failonfail => true}).and_return(Puppet::Util::Execution::ProcessOutput.new("4.10.1\n", 0)).at_most(:once)
17
16
  end
18
17
 
19
18
  def rpm_args
20
19
  ['-q', 'faff', '--nosignature', '--nodigest', '--qf', "'%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n'"]
21
20
  end
22
21
 
23
- def rpm(args = rpm_args)
24
- pkg.provider.expects(:rpm).with(*args)
25
- end
26
-
27
22
  it "should report purged packages" do
28
- rpm.raises(Puppet::ExecutionFailure, "couldn't find rpm")
23
+ expect(pkg.provider).to receive(:rpm).and_raise(Puppet::ExecutionFailure, "couldn't find rpm")
29
24
  expect(pkg.property(:ensure).retrieve).to eq(:purged)
30
25
  end
31
26
 
32
27
  it "should report present packages correctly" do
33
- rpm.returns("faff-1.2.3-1 0 1.2.3-1 5 i686\n")
28
+ expect(pkg.provider).to receive(:rpm).and_return("faff-1.2.3-1 0 1.2.3-1 5 i686\n")
34
29
  expect(pkg.property(:ensure).retrieve).to eq("1.2.3-1-5")
35
30
  end
36
31
  end
37
32
 
38
33
  it "should try and install when asked" do
39
- pkg.provider.expects(:aptget). with('-q', '-y', 'install', 'faff'). returns(0)
34
+ expect(pkg.provider).to receive(:aptget).with('-q', '-y', 'install', 'faff').and_return(0)
40
35
  pkg.provider.install
41
36
  end
42
37
 
43
38
  it "should try and purge when asked" do
44
- pkg.provider.expects(:aptget).with('-y', '-q', 'remove', '--purge', 'faff').returns(0)
39
+ expect(pkg.provider).to receive(:aptget).with('-y', '-q', 'remove', '--purge', 'faff').and_return(0)
45
40
  pkg.provider.purge
46
41
  end
47
42
  end
@@ -4,15 +4,15 @@ require 'puppet/provider/package'
4
4
  describe Puppet::Provider::Package do
5
5
  it 'returns absent for uninstalled packages when not purgeable' do
6
6
  provider = Puppet::Provider::Package.new
7
- provider.expects(:query).returns nil
8
- provider.class.expects(:feature?).with(:purgeable).returns false
7
+ expect(provider).to receive(:query).and_return(nil)
8
+ expect(provider.class).to receive(:feature?).with(:purgeable).and_return(false)
9
9
  expect(provider.properties[:ensure]).to eq(:absent)
10
10
  end
11
11
 
12
12
  it 'returns purged for uninstalled packages when purgeable' do
13
13
  provider = Puppet::Provider::Package.new
14
- provider.expects(:query).returns nil
15
- provider.class.expects(:feature?).with(:purgeable).returns true
14
+ expect(provider).to receive(:query).and_return(nil)
15
+ expect(provider.class).to receive(:feature?).with(:purgeable).and_return(true)
16
16
  expect(provider.properties[:ensure]).to eq(:purged)
17
17
  end
18
18
  end
@@ -2,48 +2,46 @@ require 'spec_helper'
2
2
 
3
3
  # Note that much of the functionality of the dnf provider is already tested with yum provider tests,
4
4
  # as yum is the parent provider.
5
-
6
5
  describe Puppet::Type.type(:package).provider(:dnf) do
7
6
  context 'default' do
8
7
  (19..21).each do |ver|
9
8
  it "should not be the default provider on fedora#{ver}" do
10
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
11
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
12
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("#{ver}")
9
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
10
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
11
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("#{ver}")
13
12
  expect(described_class).to_not be_default
14
13
  end
15
14
  end
16
15
 
17
16
  (22..26).each do |ver|
18
17
  it "should be the default provider on fedora#{ver}" do
19
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
20
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
21
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("#{ver}")
18
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
19
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
20
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("#{ver}")
22
21
  expect(described_class).to be_default
23
22
  end
24
23
  end
25
24
 
26
25
  it "should not be the default provider on rhel7" do
27
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
28
- Facter.stubs(:value).with(:operatingsystem).returns(:redhat)
29
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("7")
30
- expect(described_class).to_not be_default
26
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
27
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:redhat)
28
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("7")
29
+ expect(described_class).to_not be_default
31
30
  end
32
31
 
33
32
  it "should be the default provider on some random future fedora" do
34
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
35
- Facter.stubs(:value).with(:operatingsystem).returns(:fedora)
36
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("8675")
37
- expect(described_class).to be_default
33
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
34
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:fedora)
35
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("8675")
36
+ expect(described_class).to be_default
38
37
  end
39
38
 
40
39
  it "should be the default provider on rhel8" do
41
- Facter.stubs(:value).with(:osfamily).returns(:redhat)
42
- Facter.stubs(:value).with(:operatingsystem).returns(:redhat)
43
- Facter.stubs(:value).with(:operatingsystemmajrelease).returns("8")
44
- expect(described_class).to be_default
40
+ allow(Facter).to receive(:value).with(:osfamily).and_return(:redhat)
41
+ allow(Facter).to receive(:value).with(:operatingsystem).and_return(:redhat)
42
+ allow(Facter).to receive(:value).with(:operatingsystemmajrelease).and_return("8")
43
+ expect(described_class).to be_default
45
44
  end
46
-
47
45
  end
48
46
 
49
47
  it_behaves_like 'RHEL package provider', described_class, 'dnf'
@@ -12,7 +12,7 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
12
12
  {:failonfail => true, :combine => true, :custom_environment => {}}
13
13
  end
14
14
  let(:resource_name) { 'package' }
15
- let(:resource) { stub 'resource', :[] => resource_name }
15
+ let(:resource) { double('resource', :[] => resource_name) }
16
16
  let(:provider) { described_class.new(resource) }
17
17
 
18
18
  it "has documentation" do
@@ -23,35 +23,35 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
23
23
  let(:execpipe_args) { args.unshift('myquery') }
24
24
 
25
25
  before do
26
- described_class.stubs(:command).with(:dpkgquery).returns 'myquery'
26
+ allow(described_class).to receive(:command).with(:dpkgquery).and_return('myquery')
27
27
  end
28
28
 
29
29
  it "creates and return an instance for a single dpkg-query entry" do
30
- Puppet::Util::Execution.expects(:execpipe).with(execpipe_args).yields bash_installed_io
30
+ expect(Puppet::Util::Execution).to receive(:execpipe).with(execpipe_args).and_yield(bash_installed_io)
31
31
 
32
- installed = mock 'bash'
33
- described_class.expects(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).returns installed
32
+ installed = double('bash')
33
+ expect(described_class).to receive(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).and_return(installed)
34
34
 
35
35
  expect(described_class.instances).to eq([installed])
36
36
  end
37
37
 
38
38
  it "parses multiple dpkg-query multi-line entries in the output" do
39
- Puppet::Util::Execution.expects(:execpipe).with(execpipe_args).yields all_installed_io
39
+ expect(Puppet::Util::Execution).to receive(:execpipe).with(execpipe_args).and_yield(all_installed_io)
40
40
 
41
- bash = mock 'bash'
42
- described_class.expects(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).returns bash
43
- vim = mock 'vim'
44
- described_class.expects(:new).with(:ensure => "2:7.3.547-6ubuntu5", :error => "ok", :desired => "install", :name => "vim", :status => "installed", :provider => :dpkg).returns vim
41
+ bash = double('bash')
42
+ expect(described_class).to receive(:new).with(:ensure => "4.2-5ubuntu3", :error => "ok", :desired => "install", :name => "bash", :status => "installed", :provider => :dpkg).and_return(bash)
43
+ vim = double('vim')
44
+ expect(described_class).to receive(:new).with(:ensure => "2:7.3.547-6ubuntu5", :error => "ok", :desired => "install", :name => "vim", :status => "installed", :provider => :dpkg).and_return(vim)
45
45
 
46
46
  expect(described_class.instances).to eq([bash, vim])
47
47
  end
48
48
 
49
49
  it "continues without failing if it encounters bad lines between good entries" do
50
- Puppet::Util::Execution.expects(:execpipe).with(execpipe_args).yields StringIO.new([bash_installed_output, "foobar\n", vim_installed_output].join)
50
+ expect(Puppet::Util::Execution).to receive(:execpipe).with(execpipe_args).and_yield(StringIO.new([bash_installed_output, "foobar\n", vim_installed_output].join))
51
51
 
52
- bash = mock 'bash'
53
- vim = mock 'vim'
54
- described_class.expects(:new).twice.returns(bash, vim)
52
+ bash = double('bash')
53
+ vim = double('vim')
54
+ expect(described_class).to receive(:new).twice.and_return(bash, vim)
55
55
 
56
56
  expect(described_class.instances).to eq([bash, vim])
57
57
  end
@@ -65,15 +65,15 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
65
65
  end
66
66
 
67
67
  def dpkg_query_execution_returns(output)
68
- Puppet::Util::Execution.expects(:execute).with(query_args, execute_options).returns(Puppet::Util::Execution::ProcessOutput.new(output, 0))
68
+ expect(Puppet::Util::Execution).to receive(:execute).with(query_args, execute_options).and_return(Puppet::Util::Execution::ProcessOutput.new(output, 0))
69
69
  end
70
70
 
71
71
  before do
72
- Puppet::Util.stubs(:which).with('/usr/bin/dpkg-query').returns(dpkgquery_path)
72
+ allow(Puppet::Util).to receive(:which).with('/usr/bin/dpkg-query').and_return(dpkgquery_path)
73
73
  end
74
74
 
75
75
  it "considers the package purged if dpkg-query fails" do
76
- Puppet::Util::Execution.expects(:execute).with(query_args, execute_options).raises Puppet::ExecutionFailure.new("eh")
76
+ allow(Puppet::Util::Execution).to receive(:execute).with(query_args, execute_options).and_raise(Puppet::ExecutionFailure.new("eh"))
77
77
 
78
78
  expect(provider.query[:ensure]).to eq(:purged)
79
79
  end
@@ -147,8 +147,8 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
147
147
 
148
148
  def parser_test(dpkg_output_string, gold_hash, number_of_debug_logs = 0)
149
149
  dpkg_query_execution_returns(dpkg_output_string)
150
- Puppet.expects(:warning).never
151
- Puppet.expects(:debug).times(number_of_debug_logs)
150
+ expect(Puppet).not_to receive(:warning)
151
+ expect(Puppet).to receive(:debug).exactly(number_of_debug_logs).times
152
152
 
153
153
  expect(provider.query).to eq(gold_hash)
154
154
  end
@@ -163,8 +163,8 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
163
163
  end
164
164
 
165
165
  it "does not log if execution returns with non-zero exit code" do
166
- Puppet::Util::Execution.expects(:execute).with(query_args, execute_options).raises Puppet::ExecutionFailure.new("failed")
167
- Puppet::expects(:debug).never
166
+ expect(Puppet::Util::Execution).to receive(:execute).with(query_args, execute_options).and_raise(Puppet::ExecutionFailure.new("failed"))
167
+ expect(Puppet).not_to receive(:debug)
168
168
 
169
169
  expect(provider.query).to eq(package_not_found_hash)
170
170
  end
@@ -173,106 +173,106 @@ describe Puppet::Type.type(:package).provider(:dpkg) do
173
173
 
174
174
  context "when installing" do
175
175
  before do
176
- resource.stubs(:[]).with(:source).returns "mypkg"
176
+ allow(resource).to receive(:[]).with(:source).and_return("mypkg")
177
177
  end
178
178
 
179
179
  it "fails to install if no source is specified in the resource" do
180
- resource.expects(:[]).with(:source).returns nil
180
+ expect(resource).to receive(:[]).with(:source).and_return(nil)
181
181
 
182
182
  expect { provider.install }.to raise_error(ArgumentError)
183
183
  end
184
184
 
185
185
  it "uses 'dpkg -i' to install the package" do
186
- resource.expects(:[]).with(:source).returns "mypackagefile"
187
- provider.expects(:unhold)
188
- provider.expects(:dpkg).with { |*command| command[-1] == "mypackagefile" and command[-2] == "-i" }
186
+ expect(resource).to receive(:[]).with(:source).and_return("mypackagefile")
187
+ expect(provider).to receive(:unhold)
188
+ expect(provider).to receive(:dpkg).with(any_args, "-i", "mypackagefile")
189
189
 
190
190
  provider.install
191
191
  end
192
192
 
193
193
  it "keeps old config files if told to do so" do
194
- resource.expects(:[]).with(:configfiles).returns :keep
195
- provider.expects(:unhold)
196
- provider.expects(:dpkg).with { |*command| command[0] == "--force-confold" }
194
+ expect(resource).to receive(:[]).with(:configfiles).and_return(:keep)
195
+ expect(provider).to receive(:unhold)
196
+ expect(provider).to receive(:dpkg).with("--force-confold", any_args)
197
197
 
198
198
  provider.install
199
199
  end
200
200
 
201
201
  it "replaces old config files if told to do so" do
202
- resource.expects(:[]).with(:configfiles).returns :replace
203
- provider.expects(:unhold)
204
- provider.expects(:dpkg).with { |*command| command[0] == "--force-confnew" }
202
+ expect(resource).to receive(:[]).with(:configfiles).and_return(:replace)
203
+ expect(provider).to receive(:unhold)
204
+ expect(provider).to receive(:dpkg).with("--force-confnew", any_args)
205
205
 
206
206
  provider.install
207
207
  end
208
208
 
209
209
  it "ensures any hold is removed" do
210
- provider.expects(:unhold).once
211
- provider.expects(:dpkg)
210
+ expect(provider).to receive(:unhold).once
211
+ expect(provider).to receive(:dpkg)
212
212
  provider.install
213
213
  end
214
214
  end
215
215
 
216
216
  context "when holding or unholding" do
217
- let(:tempfile) { stub 'tempfile', :print => nil, :close => nil, :flush => nil, :path => "/other/file" }
217
+ let(:tempfile) { double('tempfile', :print => nil, :close => nil, :flush => nil, :path => "/other/file") }
218
218
 
219
219
  before do
220
- tempfile.stubs(:write)
221
- Tempfile.stubs(:open).yields tempfile
220
+ allow(tempfile).to receive(:write)
221
+ allow(Tempfile).to receive(:open).and_yield(tempfile)
222
222
  end
223
223
 
224
224
  it "installs first if holding" do
225
- provider.stubs(:execute)
226
- provider.expects(:install).once
225
+ allow(provider).to receive(:execute)
226
+ expect(provider).to receive(:install).once
227
227
  provider.hold
228
228
  end
229
229
 
230
230
  it "executes dpkg --set-selections when holding" do
231
- provider.stubs(:install)
232
- provider.expects(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
231
+ allow(provider).to receive(:install)
232
+ expect(provider).to receive(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
233
233
  provider.hold
234
234
  end
235
235
 
236
236
  it "executes dpkg --set-selections when unholding" do
237
- provider.stubs(:install)
238
- provider.expects(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
237
+ allow(provider).to receive(:install)
238
+ expect(provider).to receive(:execute).with([:dpkg, '--set-selections'], {:failonfail => false, :combine => false, :stdinfile => tempfile.path}).once
239
239
  provider.hold
240
240
  end
241
241
  end
242
242
 
243
243
  it "uses :install to update" do
244
- provider.expects(:install)
244
+ expect(provider).to receive(:install)
245
245
  provider.update
246
246
  end
247
247
 
248
248
  context "when determining latest available version" do
249
249
  it "returns the version found by dpkg-deb" do
250
- resource.expects(:[]).with(:source).returns "myfile"
251
- provider.expects(:dpkg_deb).with { |*command| command[-1] == "myfile" }.returns "package\t1.0"
250
+ expect(resource).to receive(:[]).with(:source).and_return("myfile")
251
+ expect(provider).to receive(:dpkg_deb).with(any_args, "myfile").and_return("package\t1.0")
252
252
  expect(provider.latest).to eq("1.0")
253
253
  end
254
254
 
255
255
  it "warns if the package file contains a different package" do
256
- provider.expects(:dpkg_deb).returns("foo\tversion")
257
- provider.expects(:warning)
256
+ expect(provider).to receive(:dpkg_deb).and_return("foo\tversion")
257
+ expect(provider).to receive(:warning)
258
258
  provider.latest
259
259
  end
260
260
 
261
261
  it "copes with names containing ++" do
262
- resource = stub 'resource', :[] => "package++"
262
+ resource = double('resource', :[] => "package++")
263
263
  provider = described_class.new(resource)
264
- provider.expects(:dpkg_deb).returns "package++\t1.0"
264
+ expect(provider).to receive(:dpkg_deb).and_return("package++\t1.0")
265
265
  expect(provider.latest).to eq("1.0")
266
266
  end
267
267
  end
268
268
 
269
269
  it "uses 'dpkg -r' to uninstall" do
270
- provider.expects(:dpkg).with("-r", resource_name)
270
+ expect(provider).to receive(:dpkg).with("-r", resource_name)
271
271
  provider.uninstall
272
272
  end
273
273
 
274
274
  it "uses 'dpkg --purge' to purge" do
275
- provider.expects(:dpkg).with("--purge", resource_name)
275
+ expect(provider).to receive(:dpkg).with("--purge", resource_name)
276
276
  provider.purge
277
277
  end
278
278
  end