puppet 6.0.7-x64-mingw32 → 6.0.8-x64-mingw32

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of puppet might be problematic. Click here for more details.

Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +0 -1
  3. data/Gemfile.lock +4 -8
  4. data/lib/puppet/application/device.rb +99 -83
  5. data/lib/puppet/application/filebucket.rb +4 -0
  6. data/lib/puppet/configurer.rb +5 -4
  7. data/lib/puppet/defaults.rb +31 -11
  8. data/lib/puppet/indirector/request.rb +26 -15
  9. data/lib/puppet/network/http/connection.rb +15 -7
  10. data/lib/puppet/transaction/event_manager.rb +1 -5
  11. data/lib/puppet/type/file/source.rb +0 -1
  12. data/lib/puppet/util/connection.rb +15 -6
  13. data/lib/puppet/util/http_proxy.rb +3 -2
  14. data/lib/puppet/version.rb +1 -1
  15. data/locales/puppet.pot +99 -40
  16. data/man/man5/puppet.conf.5 +8 -8
  17. data/man/man8/puppet-agent.8 +1 -1
  18. data/man/man8/puppet-apply.8 +1 -1
  19. data/man/man8/puppet-catalog.8 +1 -1
  20. data/man/man8/puppet-config.8 +1 -1
  21. data/man/man8/puppet-describe.8 +1 -1
  22. data/man/man8/puppet-device.8 +1 -1
  23. data/man/man8/puppet-doc.8 +1 -1
  24. data/man/man8/puppet-epp.8 +1 -1
  25. data/man/man8/puppet-facts.8 +1 -1
  26. data/man/man8/puppet-filebucket.8 +1 -1
  27. data/man/man8/puppet-generate.8 +1 -1
  28. data/man/man8/puppet-help.8 +1 -1
  29. data/man/man8/puppet-key.8 +1 -1
  30. data/man/man8/puppet-lookup.8 +1 -1
  31. data/man/man8/puppet-man.8 +1 -1
  32. data/man/man8/puppet-module.8 +1 -1
  33. data/man/man8/puppet-node.8 +1 -1
  34. data/man/man8/puppet-parser.8 +1 -1
  35. data/man/man8/puppet-plugin.8 +1 -1
  36. data/man/man8/puppet-report.8 +1 -1
  37. data/man/man8/puppet-resource.8 +1 -1
  38. data/man/man8/puppet-script.8 +1 -1
  39. data/man/man8/puppet-ssl.8 +1 -1
  40. data/man/man8/puppet-status.8 +1 -1
  41. data/man/man8/puppet.8 +2 -2
  42. data/spec/integration/agent/logging_spec.rb +5 -7
  43. data/spec/integration/application/apply_spec.rb +18 -16
  44. data/spec/integration/application/doc_spec.rb +1 -2
  45. data/spec/integration/application/lookup_spec.rb +5 -5
  46. data/spec/integration/configurer_spec.rb +5 -6
  47. data/spec/integration/defaults_spec.rb +5 -6
  48. data/spec/integration/directory_environments_spec.rb +1 -1
  49. data/spec/integration/faces/config_spec.rb +3 -4
  50. data/spec/integration/faces/documentation_spec.rb +0 -1
  51. data/spec/integration/faces/plugin_spec.rb +1 -1
  52. data/spec/integration/file_bucket/file_spec.rb +2 -4
  53. data/spec/integration/file_serving/content_spec.rb +0 -1
  54. data/spec/integration/file_serving/fileset_spec.rb +0 -1
  55. data/spec/integration/file_serving/metadata_spec.rb +0 -1
  56. data/spec/integration/file_serving/terminus_helper_spec.rb +0 -1
  57. data/spec/integration/indirector/catalog/compiler_spec.rb +10 -11
  58. data/spec/integration/indirector/direct_file_server_spec.rb +1 -1
  59. data/spec/integration/indirector/facts/facter_spec.rb +4 -5
  60. data/spec/integration/indirector/file_content/file_server_spec.rb +7 -8
  61. data/spec/integration/indirector/file_metadata/file_server_spec.rb +7 -8
  62. data/spec/integration/network/authconfig_spec.rb +23 -24
  63. data/spec/integration/network/formats_spec.rb +0 -1
  64. data/spec/integration/node/environment_spec.rb +0 -1
  65. data/spec/integration/node/facts_spec.rb +9 -10
  66. data/spec/integration/node_spec.rb +6 -7
  67. data/spec/integration/parser/catalog_spec.rb +1 -5
  68. data/spec/integration/parser/collection_spec.rb +1 -2
  69. data/spec/integration/parser/compiler_spec.rb +6 -6
  70. data/spec/integration/parser/scope_spec.rb +1 -1
  71. data/spec/integration/parser/undef_param_spec.rb +1 -1
  72. data/spec/integration/provider/service/init_spec.rb +4 -5
  73. data/spec/integration/provider/service/systemd_spec.rb +0 -2
  74. data/spec/integration/provider/service/windows_spec.rb +1 -2
  75. data/spec/integration/reference/providers_spec.rb +1 -2
  76. data/spec/integration/reports_spec.rb +1 -2
  77. data/spec/integration/resource/catalog_spec.rb +14 -17
  78. data/spec/integration/resource/type_collection_spec.rb +4 -5
  79. data/spec/integration/ssl/certificate_request_spec.rb +0 -1
  80. data/spec/integration/ssl/host_spec.rb +1 -2
  81. data/spec/integration/ssl/key_spec.rb +0 -1
  82. data/spec/integration/test/test_helper_spec.rb +0 -1
  83. data/spec/integration/transaction/report_spec.rb +6 -11
  84. data/spec/integration/transaction_spec.rb +18 -19
  85. data/spec/integration/type/exec_spec.rb +0 -1
  86. data/spec/integration/type/file_spec.rb +13 -14
  87. data/spec/integration/type/package_spec.rb +19 -23
  88. data/spec/integration/type/tidy_spec.rb +1 -2
  89. data/spec/integration/type_spec.rb +0 -1
  90. data/spec/integration/util/autoload_spec.rb +1 -2
  91. data/spec/integration/util/rdoc/parser_spec.rb +0 -1
  92. data/spec/integration/util/settings_spec.rb +0 -1
  93. data/spec/integration/util/windows/adsi_spec.rb +3 -5
  94. data/spec/integration/util/windows/principal_spec.rb +0 -1
  95. data/spec/integration/util/windows/process_spec.rb +4 -6
  96. data/spec/integration/util/windows/registry_spec.rb +41 -51
  97. data/spec/integration/util/windows/security_spec.rb +2 -4
  98. data/spec/integration/util/windows/user_spec.rb +18 -20
  99. data/spec/integration/util_spec.rb +4 -7
  100. data/spec/lib/puppet_spec/compiler.rb +1 -1
  101. data/spec/lib/puppet_spec/files.rb +0 -1
  102. data/spec/lib/puppet_spec/module_tool/shared_functions.rb +1 -1
  103. data/spec/lib/puppet_spec/scope.rb +1 -2
  104. data/spec/shared_behaviours/all_parsedfile_providers.rb +1 -1
  105. data/spec/shared_behaviours/file_server_terminus.rb +8 -9
  106. data/spec/shared_behaviours/file_serving.rb +6 -8
  107. data/spec/shared_behaviours/file_serving_model.rb +3 -5
  108. data/spec/shared_behaviours/hiera_indirections.rb +3 -4
  109. data/spec/shared_behaviours/iterative_functions.rb +0 -1
  110. data/spec/shared_behaviours/memory_terminus.rb +2 -2
  111. data/spec/shared_examples/rhel_package_provider.rb +112 -70
  112. data/spec/spec_helper.rb +10 -1
  113. data/spec/unit/agent/disabler_spec.rb +4 -5
  114. data/spec/unit/agent/locker_spec.rb +12 -13
  115. data/spec/unit/agent_spec.rb +80 -85
  116. data/spec/unit/application/agent_spec.rb +88 -93
  117. data/spec/unit/application/apply_spec.rb +82 -83
  118. data/spec/unit/application/config_spec.rb +0 -1
  119. data/spec/unit/application/describe_spec.rb +6 -7
  120. data/spec/unit/application/device_spec.rb +395 -419
  121. data/spec/unit/application/doc_spec.rb +44 -46
  122. data/spec/unit/application/face_base_spec.rb +61 -62
  123. data/spec/unit/application/facts_spec.rb +3 -4
  124. data/spec/unit/application/filebucket_spec.rb +66 -74
  125. data/spec/unit/application/indirection_base_spec.rb +8 -6
  126. data/spec/unit/application/lookup_spec.rb +26 -26
  127. data/spec/unit/application/resource_spec.rb +42 -48
  128. data/spec/unit/application/ssl_spec.rb +3 -3
  129. data/spec/unit/application_spec.rb +82 -92
  130. data/spec/unit/capability_spec.rb +6 -6
  131. data/spec/unit/certificate_factory_spec.rb +3 -5
  132. data/spec/unit/configurer/downloader_spec.rb +20 -21
  133. data/spec/unit/configurer/fact_handler_spec.rb +2 -3
  134. data/spec/unit/configurer/plugin_handler_spec.rb +41 -8
  135. data/spec/unit/configurer_spec.rb +189 -192
  136. data/spec/unit/confine/exists_spec.rb +17 -15
  137. data/spec/unit/confine/false_spec.rb +5 -6
  138. data/spec/unit/confine/feature_spec.rb +7 -5
  139. data/spec/unit/confine/true_spec.rb +5 -6
  140. data/spec/unit/confine/variable_spec.rb +14 -15
  141. data/spec/unit/confine_collection_spec.rb +28 -29
  142. data/spec/unit/confine_spec.rb +13 -14
  143. data/spec/unit/confiner_spec.rb +10 -11
  144. data/spec/unit/context/trusted_information_spec.rb +1 -1
  145. data/spec/unit/daemon_spec.rb +35 -36
  146. data/spec/unit/data_providers/function_data_provider_spec.rb +0 -1
  147. data/spec/unit/data_providers/hiera_data_provider_spec.rb +0 -1
  148. data/spec/unit/datatypes_spec.rb +3 -4
  149. data/spec/unit/defaults_spec.rb +18 -13
  150. data/spec/unit/environments_spec.rb +7 -7
  151. data/spec/unit/etc_spec.rb +30 -32
  152. data/spec/unit/external/pson_spec.rb +0 -1
  153. data/spec/unit/face/catalog_spec.rb +0 -1
  154. data/spec/unit/face/config_spec.rb +31 -35
  155. data/spec/unit/face/epp_face_spec.rb +3 -4
  156. data/spec/unit/face/facts_spec.rb +5 -6
  157. data/spec/unit/face/generate_spec.rb +4 -5
  158. data/spec/unit/face/help_spec.rb +7 -8
  159. data/spec/unit/face/key_spec.rb +0 -1
  160. data/spec/unit/face/man_spec.rb +1 -2
  161. data/spec/unit/face/module/install_spec.rb +3 -5
  162. data/spec/unit/face/module/list_spec.rb +2 -12
  163. data/spec/unit/face/module/search_spec.rb +11 -9
  164. data/spec/unit/face/module/uninstall_spec.rb +4 -8
  165. data/spec/unit/face/node_spec.rb +23 -24
  166. data/spec/unit/face/parser_spec.rb +3 -3
  167. data/spec/unit/face/plugin_spec.rb +36 -9
  168. data/spec/unit/face/status_spec.rb +0 -1
  169. data/spec/unit/file_bucket/dipper_spec.rb +24 -20
  170. data/spec/unit/file_bucket/file_spec.rb +0 -2
  171. data/spec/unit/file_serving/base_spec.rb +14 -15
  172. data/spec/unit/file_serving/configuration/parser_spec.rb +27 -28
  173. data/spec/unit/file_serving/configuration_spec.rb +63 -66
  174. data/spec/unit/file_serving/content_spec.rb +10 -11
  175. data/spec/unit/file_serving/fileset_spec.rb +63 -58
  176. data/spec/unit/file_serving/http_metadata_spec.rb +8 -7
  177. data/spec/unit/file_serving/metadata_spec.rb +36 -36
  178. data/spec/unit/file_serving/mount/file_spec.rb +31 -32
  179. data/spec/unit/file_serving/mount/locales_spec.rb +23 -24
  180. data/spec/unit/file_serving/mount/modules_spec.rb +14 -15
  181. data/spec/unit/file_serving/mount/pluginfacts_spec.rb +23 -24
  182. data/spec/unit/file_serving/mount/plugins_spec.rb +23 -24
  183. data/spec/unit/file_serving/mount/tasks_spec.rb +14 -15
  184. data/spec/unit/file_serving/mount_spec.rb +0 -1
  185. data/spec/unit/file_serving/terminus_helper_spec.rb +37 -42
  186. data/spec/unit/file_serving/terminus_selector_spec.rb +12 -13
  187. data/spec/unit/file_system/uniquefile_spec.rb +4 -4
  188. data/spec/unit/file_system_spec.rb +2 -2
  189. data/spec/unit/forge/errors_spec.rb +1 -1
  190. data/spec/unit/forge/forge_spec.rb +13 -14
  191. data/spec/unit/forge/module_release_spec.rb +18 -18
  192. data/spec/unit/forge/repository_spec.rb +29 -30
  193. data/spec/unit/forge_spec.rb +15 -11
  194. data/spec/unit/functions/binary_file_spec.rb +3 -3
  195. data/spec/unit/functions/contain_spec.rb +0 -2
  196. data/spec/unit/functions/defined_spec.rb +0 -1
  197. data/spec/unit/functions/epp_spec.rb +2 -2
  198. data/spec/unit/functions/find_file_spec.rb +7 -7
  199. data/spec/unit/functions/include_spec.rb +0 -4
  200. data/spec/unit/functions/lookup_fixture_spec.rb +0 -1
  201. data/spec/unit/functions/lookup_spec.rb +1 -2
  202. data/spec/unit/functions/module_directory_spec.rb +12 -12
  203. data/spec/unit/functions/require_spec.rb +0 -3
  204. data/spec/unit/functions/shared.rb +5 -8
  205. data/spec/unit/functions/versioncmp_spec.rb +1 -2
  206. data/spec/unit/functions4_spec.rb +9 -10
  207. data/spec/unit/gettext/config_spec.rb +4 -4
  208. data/spec/unit/gettext/module_loading_spec.rb +7 -7
  209. data/spec/unit/graph/rb_tree_map_spec.rb +0 -2
  210. data/spec/unit/graph/relationship_graph_spec.rb +1 -2
  211. data/spec/unit/graph/simple_graph_spec.rb +9 -10
  212. data/spec/unit/hiera_puppet_spec.rb +20 -20
  213. data/spec/unit/indirector/catalog/compiler_spec.rb +147 -149
  214. data/spec/unit/indirector/catalog/json_spec.rb +1 -2
  215. data/spec/unit/indirector/catalog/msgpack_spec.rb +0 -1
  216. data/spec/unit/indirector/catalog/rest_spec.rb +0 -1
  217. data/spec/unit/indirector/catalog/store_configs_spec.rb +0 -1
  218. data/spec/unit/indirector/catalog/yaml_spec.rb +0 -1
  219. data/spec/unit/indirector/certificate/file_spec.rb +0 -1
  220. data/spec/unit/indirector/certificate/rest_spec.rb +8 -10
  221. data/spec/unit/indirector/certificate_request/file_spec.rb +0 -1
  222. data/spec/unit/indirector/certificate_request/rest_spec.rb +0 -1
  223. data/spec/unit/indirector/direct_file_server_spec.rb +17 -18
  224. data/spec/unit/indirector/envelope_spec.rb +1 -2
  225. data/spec/unit/indirector/exec_spec.rb +4 -5
  226. data/spec/unit/indirector/face_spec.rb +9 -9
  227. data/spec/unit/indirector/facts/facter_spec.rb +37 -43
  228. data/spec/unit/indirector/facts/network_device_spec.rb +8 -9
  229. data/spec/unit/indirector/facts/rest_spec.rb +7 -8
  230. data/spec/unit/indirector/facts/store_configs_spec.rb +0 -1
  231. data/spec/unit/indirector/facts/yaml_spec.rb +0 -1
  232. data/spec/unit/indirector/file_bucket_file/file_spec.rb +3 -4
  233. data/spec/unit/indirector/file_bucket_file/rest_spec.rb +0 -1
  234. data/spec/unit/indirector/file_bucket_file/selector_spec.rb +4 -5
  235. data/spec/unit/indirector/file_content/file_server_spec.rb +0 -1
  236. data/spec/unit/indirector/file_content/file_spec.rb +0 -1
  237. data/spec/unit/indirector/file_content/rest_spec.rb +0 -1
  238. data/spec/unit/indirector/file_content/selector_spec.rb +0 -1
  239. data/spec/unit/indirector/file_metadata/file_server_spec.rb +0 -1
  240. data/spec/unit/indirector/file_metadata/file_spec.rb +12 -13
  241. data/spec/unit/indirector/file_metadata/rest_spec.rb +0 -1
  242. data/spec/unit/indirector/file_metadata/selector_spec.rb +0 -1
  243. data/spec/unit/indirector/file_server_spec.rb +87 -87
  244. data/spec/unit/indirector/indirection_spec.rb +242 -226
  245. data/spec/unit/indirector/json_spec.rb +7 -9
  246. data/spec/unit/indirector/key/file_spec.rb +21 -22
  247. data/spec/unit/indirector/memory_spec.rb +6 -7
  248. data/spec/unit/indirector/msgpack_spec.rb +7 -9
  249. data/spec/unit/indirector/node/exec_spec.rb +2 -3
  250. data/spec/unit/indirector/node/memory_spec.rb +2 -4
  251. data/spec/unit/indirector/node/msgpack_spec.rb +0 -1
  252. data/spec/unit/indirector/node/plain_spec.rb +2 -4
  253. data/spec/unit/indirector/node/rest_spec.rb +0 -1
  254. data/spec/unit/indirector/node/store_configs_spec.rb +0 -1
  255. data/spec/unit/indirector/node/yaml_spec.rb +0 -1
  256. data/spec/unit/indirector/none_spec.rb +5 -5
  257. data/spec/unit/indirector/plain_spec.rb +7 -8
  258. data/spec/unit/indirector/report/msgpack_spec.rb +0 -1
  259. data/spec/unit/indirector/report/processor_spec.rb +21 -22
  260. data/spec/unit/indirector/report/rest_spec.rb +11 -12
  261. data/spec/unit/indirector/report/yaml_spec.rb +0 -1
  262. data/spec/unit/indirector/request_spec.rb +11 -12
  263. data/spec/unit/indirector/resource/ral_spec.rb +46 -54
  264. data/spec/unit/indirector/resource/store_configs_spec.rb +0 -1
  265. data/spec/unit/indirector/rest_spec.rb +113 -110
  266. data/spec/unit/indirector/ssl_file_spec.rb +64 -65
  267. data/spec/unit/indirector/status/local_spec.rb +0 -1
  268. data/spec/unit/indirector/status/rest_spec.rb +0 -1
  269. data/spec/unit/indirector/store_configs_spec.rb +0 -1
  270. data/spec/unit/indirector/terminus_spec.rb +27 -27
  271. data/spec/unit/indirector/yaml_spec.rb +5 -6
  272. data/spec/unit/indirector_spec.rb +1 -2
  273. data/spec/unit/info_service_spec.rb +1 -1
  274. data/spec/unit/interface/action_builder_spec.rb +0 -1
  275. data/spec/unit/interface/action_manager_spec.rb +0 -1
  276. data/spec/unit/interface/action_spec.rb +2 -3
  277. data/spec/unit/interface/documentation_spec.rb +0 -1
  278. data/spec/unit/interface/face_collection_spec.rb +19 -12
  279. data/spec/unit/interface_spec.rb +3 -3
  280. data/spec/unit/man_spec.rb +3 -4
  281. data/spec/unit/module_spec.rb +46 -51
  282. data/spec/unit/module_tool/applications/installer_spec.rb +10 -11
  283. data/spec/unit/module_tool/applications/searcher_spec.rb +3 -3
  284. data/spec/unit/module_tool/applications/uninstaller_spec.rb +1 -2
  285. data/spec/unit/module_tool/applications/unpacker_spec.rb +13 -13
  286. data/spec/unit/module_tool/applications/upgrader_spec.rb +5 -5
  287. data/spec/unit/module_tool/install_directory_spec.rb +8 -8
  288. data/spec/unit/module_tool/installed_modules_spec.rb +3 -3
  289. data/spec/unit/module_tool/tar/gnu_spec.rb +6 -6
  290. data/spec/unit/module_tool/tar/mini_spec.rb +12 -12
  291. data/spec/unit/module_tool/tar_spec.rb +12 -13
  292. data/spec/unit/module_tool_spec.rb +7 -12
  293. data/spec/unit/network/auth_config_parser_spec.rb +11 -13
  294. data/spec/unit/network/authconfig_spec.rb +17 -18
  295. data/spec/unit/network/authorization_spec.rb +4 -5
  296. data/spec/unit/network/authstore_spec.rb +0 -1
  297. data/spec/unit/network/format_handler_spec.rb +0 -1
  298. data/spec/unit/network/format_spec.rb +9 -10
  299. data/spec/unit/network/format_support_spec.rb +28 -29
  300. data/spec/unit/network/formats_spec.rb +4 -5
  301. data/spec/unit/network/http/api/indirected_routes_spec.rb +24 -29
  302. data/spec/unit/network/http/api/master/v3/authorization_spec.rb +2 -2
  303. data/spec/unit/network/http/api/master/v3/environment_spec.rb +1 -1
  304. data/spec/unit/network/http/api/master/v3/environments_spec.rb +6 -7
  305. data/spec/unit/network/http/api_spec.rb +0 -2
  306. data/spec/unit/network/http/compression_spec.rb +21 -22
  307. data/spec/unit/network/http/connection_spec.rb +41 -36
  308. data/spec/unit/network/http/factory_spec.rb +5 -6
  309. data/spec/unit/network/http/handler_spec.rb +9 -18
  310. data/spec/unit/network/http/nocache_pool_spec.rb +6 -7
  311. data/spec/unit/network/http/pool_spec.rb +28 -29
  312. data/spec/unit/network/http/request_spec.rb +0 -2
  313. data/spec/unit/network/http/response_spec.rb +11 -13
  314. data/spec/unit/network/http/route_spec.rb +0 -1
  315. data/spec/unit/network/http/session_spec.rb +1 -2
  316. data/spec/unit/network/http/site_spec.rb +0 -1
  317. data/spec/unit/network/http_pool_spec.rb +18 -9
  318. data/spec/unit/network/http_spec.rb +0 -1
  319. data/spec/unit/network/resolver_spec.rb +25 -26
  320. data/spec/unit/network/rights_spec.rb +52 -53
  321. data/spec/unit/node/environment_spec.rb +14 -15
  322. data/spec/unit/node/facts_spec.rb +5 -7
  323. data/spec/unit/node_spec.rb +4 -10
  324. data/spec/unit/other/selinux_spec.rb +0 -1
  325. data/spec/unit/parameter/boolean_spec.rb +1 -2
  326. data/spec/unit/parameter/package_options_spec.rb +1 -2
  327. data/spec/unit/parameter/path_spec.rb +0 -1
  328. data/spec/unit/parameter/value_collection_spec.rb +0 -1
  329. data/spec/unit/parameter/value_spec.rb +0 -1
  330. data/spec/unit/parameter_spec.rb +9 -9
  331. data/spec/unit/parser/ast/block_expression_spec.rb +6 -8
  332. data/spec/unit/parser/ast/leaf_spec.rb +20 -21
  333. data/spec/unit/parser/compiler_spec.rb +84 -96
  334. data/spec/unit/parser/environment_compiler_spec.rb +7 -8
  335. data/spec/unit/parser/files_spec.rb +0 -1
  336. data/spec/unit/parser/functions/create_resources_spec.rb +1 -1
  337. data/spec/unit/parser/functions/digest_spec.rb +0 -1
  338. data/spec/unit/parser/functions/fail_spec.rb +1 -2
  339. data/spec/unit/parser/functions/file_spec.rb +13 -14
  340. data/spec/unit/parser/functions/fqdn_rand_spec.rb +5 -6
  341. data/spec/unit/parser/functions/generate_spec.rb +7 -8
  342. data/spec/unit/parser/functions/inline_template_spec.rb +0 -1
  343. data/spec/unit/parser/functions/regsubst_spec.rb +0 -1
  344. data/spec/unit/parser/functions/scanf_spec.rb +0 -1
  345. data/spec/unit/parser/functions/shellquote_spec.rb +0 -1
  346. data/spec/unit/parser/functions/split_spec.rb +0 -1
  347. data/spec/unit/parser/functions/sprintf_spec.rb +0 -1
  348. data/spec/unit/parser/functions/tag_spec.rb +1 -2
  349. data/spec/unit/parser/functions/tagged_spec.rb +2 -3
  350. data/spec/unit/parser/functions/template_spec.rb +13 -13
  351. data/spec/unit/parser/functions/versioncmp_spec.rb +1 -2
  352. data/spec/unit/parser/functions_spec.rb +6 -7
  353. data/spec/unit/parser/relationship_spec.rb +0 -1
  354. data/spec/unit/parser/resource_spec.rb +42 -42
  355. data/spec/unit/parser/scope_spec.rb +39 -35
  356. data/spec/unit/parser/templatewrapper_spec.rb +11 -12
  357. data/spec/unit/parser/type_loader_spec.rb +17 -19
  358. data/spec/unit/pops/adaptable_spec.rb +0 -1
  359. data/spec/unit/pops/benchmark_spec.rb +0 -1
  360. data/spec/unit/pops/evaluator/access_ops_spec.rb +0 -1
  361. data/spec/unit/pops/evaluator/arithmetic_ops_spec.rb +0 -1
  362. data/spec/unit/pops/evaluator/basic_expressions_spec.rb +0 -1
  363. data/spec/unit/pops/evaluator/collections_ops_spec.rb +0 -1
  364. data/spec/unit/pops/evaluator/comparison_ops_spec.rb +0 -1
  365. data/spec/unit/pops/evaluator/conditionals_spec.rb +0 -1
  366. data/spec/unit/pops/evaluator/evaluating_parser_spec.rb +10 -11
  367. data/spec/unit/pops/evaluator/logical_ops_spec.rb +0 -1
  368. data/spec/unit/pops/evaluator/runtime3_converter_spec.rb +0 -1
  369. data/spec/unit/pops/evaluator/string_interpolation_spec.rb +0 -1
  370. data/spec/unit/pops/evaluator/variables_spec.rb +0 -1
  371. data/spec/unit/pops/factory_spec.rb +3 -4
  372. data/spec/unit/pops/issues_spec.rb +19 -20
  373. data/spec/unit/pops/loaders/loader_spec.rb +8 -4
  374. data/spec/unit/pops/loaders/loaders_spec.rb +31 -28
  375. data/spec/unit/pops/lookup/context_spec.rb +0 -1
  376. data/spec/unit/pops/lookup/interpolation_spec.rb +2 -3
  377. data/spec/unit/pops/merge_strategy_spec.rb +0 -1
  378. data/spec/unit/pops/migration_spec.rb +3 -5
  379. data/spec/unit/pops/model/model_spec.rb +0 -1
  380. data/spec/unit/pops/model/pn_transformer_spec.rb +0 -1
  381. data/spec/unit/pops/parser/locator_spec.rb +3 -6
  382. data/spec/unit/pops/parser/parse_application_spec.rb +0 -1
  383. data/spec/unit/pops/parser/parse_basic_expressions_spec.rb +0 -1
  384. data/spec/unit/pops/parser/parse_calls_spec.rb +0 -1
  385. data/spec/unit/pops/parser/parse_capabilities_spec.rb +0 -1
  386. data/spec/unit/pops/parser/parse_conditionals_spec.rb +0 -1
  387. data/spec/unit/pops/parser/parse_containers_spec.rb +0 -1
  388. data/spec/unit/pops/parser/parse_plan_spec.rb +0 -1
  389. data/spec/unit/pops/parser/parse_resource_spec.rb +0 -1
  390. data/spec/unit/pops/parser/parse_site_spec.rb +0 -1
  391. data/spec/unit/pops/parser/pn_parser_spec.rb +0 -1
  392. data/spec/unit/pops/pn_spec.rb +0 -1
  393. data/spec/unit/pops/resource/resource_type_impl_spec.rb +0 -1
  394. data/spec/unit/pops/serialization/serialization_spec.rb +1 -1
  395. data/spec/unit/pops/serialization/to_from_hr_spec.rb +1 -1
  396. data/spec/unit/pops/types/recursion_guard_spec.rb +10 -10
  397. data/spec/unit/pops/types/ruby_generator_spec.rb +2 -2
  398. data/spec/unit/pops/types/type_asserter_spec.rb +2 -2
  399. data/spec/unit/pops/types/type_calculator_spec.rb +30 -30
  400. data/spec/unit/pops/types/type_parser_spec.rb +13 -13
  401. data/spec/unit/pops/validator/validator_spec.rb +1 -2
  402. data/spec/unit/pops/visitor_spec.rb +0 -1
  403. data/spec/unit/property/boolean_spec.rb +1 -1
  404. data/spec/unit/property/ensure_spec.rb +0 -1
  405. data/spec/unit/property/keyvalue_spec.rb +32 -34
  406. data/spec/unit/property/list_spec.rb +26 -27
  407. data/spec/unit/property/ordered_list_spec.rb +10 -14
  408. data/spec/unit/property_spec.rb +42 -43
  409. data/spec/unit/provider/aix_object_spec.rb +47 -45
  410. data/spec/unit/provider/command_spec.rb +9 -9
  411. data/spec/unit/provider/exec/posix_spec.rb +6 -7
  412. data/spec/unit/provider/exec/shell_spec.rb +0 -1
  413. data/spec/unit/provider/exec/windows_spec.rb +2 -4
  414. data/spec/unit/provider/exec_spec.rb +0 -1
  415. data/spec/unit/provider/file/posix_spec.rb +22 -24
  416. data/spec/unit/provider/file/windows_spec.rb +15 -17
  417. data/spec/unit/provider/group/aix_spec.rb +3 -2
  418. data/spec/unit/provider/group/groupadd_spec.rb +30 -26
  419. data/spec/unit/provider/group/ldap_spec.rb +18 -18
  420. data/spec/unit/provider/group/pw_spec.rb +11 -11
  421. data/spec/unit/provider/group/windows_adsi_spec.rb +54 -54
  422. data/spec/unit/provider/ldap_spec.rb +61 -62
  423. data/spec/unit/provider/nameservice/directoryservice_spec.rb +35 -36
  424. data/spec/unit/provider/nameservice_spec.rb +38 -40
  425. data/spec/unit/provider/package/aix_spec.rb +15 -15
  426. data/spec/unit/provider/package/appdmg_spec.rb +13 -13
  427. data/spec/unit/provider/package/apt_spec.rb +44 -27
  428. data/spec/unit/provider/package/aptitude_spec.rb +6 -7
  429. data/spec/unit/provider/package/aptrpm_spec.rb +7 -12
  430. data/spec/unit/provider/package/base_spec.rb +4 -4
  431. data/spec/unit/provider/package/dnf_spec.rb +18 -20
  432. data/spec/unit/provider/package/dpkg_spec.rb +52 -52
  433. data/spec/unit/provider/package/freebsd_spec.rb +11 -11
  434. data/spec/unit/provider/package/gem_spec.rb +51 -43
  435. data/spec/unit/provider/package/hpux_spec.rb +8 -8
  436. data/spec/unit/provider/package/macports_spec.rb +46 -42
  437. data/spec/unit/provider/package/nim_spec.rb +30 -39
  438. data/spec/unit/provider/package/openbsd_spec.rb +36 -39
  439. data/spec/unit/provider/package/opkg_spec.rb +23 -26
  440. data/spec/unit/provider/package/pacman_spec.rb +97 -118
  441. data/spec/unit/provider/package/pip_spec.rb +71 -72
  442. data/spec/unit/provider/package/pkg_spec.rb +109 -109
  443. data/spec/unit/provider/package/pkgdmg_spec.rb +65 -63
  444. data/spec/unit/provider/package/pkgin_spec.rb +10 -8
  445. data/spec/unit/provider/package/pkgng_spec.rb +17 -18
  446. data/spec/unit/provider/package/pkgutil_spec.rb +45 -49
  447. data/spec/unit/provider/package/portage_spec.rb +70 -74
  448. data/spec/unit/provider/package/puppet_gem_spec.rb +28 -8
  449. data/spec/unit/provider/package/rpm_spec.rb +53 -64
  450. data/spec/unit/provider/package/sun_spec.rb +16 -18
  451. data/spec/unit/provider/package/tdnf_spec.rb +2 -2
  452. data/spec/unit/provider/package/up2date_spec.rb +2 -4
  453. data/spec/unit/provider/package/urpmi_spec.rb +15 -17
  454. data/spec/unit/provider/package/windows/exe_package_spec.rb +12 -15
  455. data/spec/unit/provider/package/windows/msi_package_spec.rb +19 -22
  456. data/spec/unit/provider/package/windows/package_spec.rb +37 -42
  457. data/spec/unit/provider/package/windows_spec.rb +36 -32
  458. data/spec/unit/provider/package/yum_spec.rb +7 -7
  459. data/spec/unit/provider/package/zypper_spec.rb +87 -87
  460. data/spec/unit/provider/parsedfile_spec.rb +44 -45
  461. data/spec/unit/provider/service/base_spec.rb +4 -5
  462. data/spec/unit/provider/service/bsd_spec.rb +27 -29
  463. data/spec/unit/provider/service/daemontools_spec.rb +35 -35
  464. data/spec/unit/provider/service/debian_spec.rb +38 -38
  465. data/spec/unit/provider/service/freebsd_spec.rb +18 -18
  466. data/spec/unit/provider/service/gentoo_spec.rb +50 -55
  467. data/spec/unit/provider/service/init_spec.rb +53 -52
  468. data/spec/unit/provider/service/launchd_spec.rb +138 -116
  469. data/spec/unit/provider/service/openbsd_spec.rb +50 -50
  470. data/spec/unit/provider/service/openrc_spec.rb +43 -45
  471. data/spec/unit/provider/service/openwrt_spec.rb +26 -31
  472. data/spec/unit/provider/service/rcng_spec.rb +14 -14
  473. data/spec/unit/provider/service/redhat_spec.rb +45 -43
  474. data/spec/unit/provider/service/runit_spec.rb +29 -27
  475. data/spec/unit/provider/service/smf_spec.rb +74 -66
  476. data/spec/unit/provider/service/src_spec.rb +46 -47
  477. data/spec/unit/provider/service/systemd_spec.rb +104 -113
  478. data/spec/unit/provider/service/upstart_spec.rb +74 -71
  479. data/spec/unit/provider/service/windows_spec.rb +33 -41
  480. data/spec/unit/provider/user/aix_spec.rb +31 -31
  481. data/spec/unit/provider/user/directoryservice_spec.rb +109 -114
  482. data/spec/unit/provider/user/hpux_spec.rb +16 -16
  483. data/spec/unit/provider/user/ldap_spec.rb +57 -57
  484. data/spec/unit/provider/user/openbsd_spec.rb +10 -12
  485. data/spec/unit/provider/user/pw_spec.rb +37 -35
  486. data/spec/unit/provider/user/user_role_add_spec.rb +93 -93
  487. data/spec/unit/provider/user/useradd_spec.rb +93 -92
  488. data/spec/unit/provider/user/windows_adsi_spec.rb +59 -60
  489. data/spec/unit/provider_spec.rb +35 -35
  490. data/spec/unit/puppet_pal_2pec.rb +4 -5
  491. data/spec/unit/puppet_pal_spec.rb +0 -1
  492. data/spec/unit/puppet_spec.rb +6 -7
  493. data/spec/unit/relationship_spec.rb +0 -1
  494. data/spec/unit/reports/http_spec.rb +21 -23
  495. data/spec/unit/reports/store_spec.rb +3 -4
  496. data/spec/unit/reports_spec.rb +12 -14
  497. data/spec/unit/resource/capability_finder_spec.rb +15 -17
  498. data/spec/unit/resource/catalog_spec.rb +72 -68
  499. data/spec/unit/resource/status_spec.rb +6 -8
  500. data/spec/unit/resource/type_collection_spec.rb +17 -18
  501. data/spec/unit/resource/type_spec.rb +34 -35
  502. data/spec/unit/resource_spec.rb +36 -32
  503. data/spec/unit/rest/client_spec.rb +58 -27
  504. data/spec/unit/rest/route_spec.rb +5 -5
  505. data/spec/unit/scheduler/job_spec.rb +0 -1
  506. data/spec/unit/scheduler/scheduler_spec.rb +0 -1
  507. data/spec/unit/scheduler/splay_job_spec.rb +1 -2
  508. data/spec/unit/settings/array_setting_spec.rb +1 -1
  509. data/spec/unit/settings/autosign_setting_spec.rb +9 -9
  510. data/spec/unit/settings/certificate_revocation_setting_spec.rb +1 -1
  511. data/spec/unit/settings/config_file_spec.rb +0 -1
  512. data/spec/unit/settings/directory_setting_spec.rb +2 -7
  513. data/spec/unit/settings/duration_setting_spec.rb +1 -2
  514. data/spec/unit/settings/enum_setting_spec.rb +1 -1
  515. data/spec/unit/settings/environment_conf_spec.rb +4 -6
  516. data/spec/unit/settings/file_setting_spec.rb +44 -46
  517. data/spec/unit/settings/path_setting_spec.rb +1 -2
  518. data/spec/unit/settings/priority_setting_spec.rb +1 -2
  519. data/spec/unit/settings/string_setting_spec.rb +14 -15
  520. data/spec/unit/settings/terminus_setting_spec.rb +1 -2
  521. data/spec/unit/settings/value_translator_spec.rb +0 -1
  522. data/spec/unit/settings_spec.rb +228 -235
  523. data/spec/unit/ssl/base_spec.rb +14 -15
  524. data/spec/unit/ssl/certificate_request_spec.rb +62 -58
  525. data/spec/unit/ssl/certificate_spec.rb +23 -25
  526. data/spec/unit/ssl/digest_spec.rb +0 -1
  527. data/spec/unit/ssl/host_spec.rb +166 -149
  528. data/spec/unit/ssl/key_spec.rb +30 -31
  529. data/spec/unit/ssl/validator_spec.rb +38 -39
  530. data/spec/unit/task_spec.rb +44 -45
  531. data/spec/unit/transaction/additional_resource_generator_spec.rb +3 -5
  532. data/spec/unit/transaction/event_manager_spec.rb +87 -88
  533. data/spec/unit/transaction/event_spec.rb +16 -15
  534. data/spec/unit/transaction/persistence_spec.rb +16 -17
  535. data/spec/unit/transaction/report_spec.rb +11 -12
  536. data/spec/unit/transaction/resource_harness_spec.rb +28 -33
  537. data/spec/unit/transaction_spec.rb +100 -101
  538. data/spec/unit/type/component_spec.rb +0 -1
  539. data/spec/unit/type/exec_spec.rb +60 -56
  540. data/spec/unit/type/file/checksum_spec.rb +9 -10
  541. data/spec/unit/type/file/checksum_value_spec.rb +31 -32
  542. data/spec/unit/type/file/content_spec.rb +58 -61
  543. data/spec/unit/type/file/ctime_spec.rb +0 -1
  544. data/spec/unit/type/file/ensure_spec.rb +12 -13
  545. data/spec/unit/type/file/group_spec.rb +5 -7
  546. data/spec/unit/type/file/mode_spec.rb +4 -6
  547. data/spec/unit/type/file/mtime_spec.rb +0 -1
  548. data/spec/unit/type/file/owner_spec.rb +6 -8
  549. data/spec/unit/type/file/selinux_spec.rb +17 -19
  550. data/spec/unit/type/file/source_spec.rb +104 -101
  551. data/spec/unit/type/file/type_spec.rb +0 -1
  552. data/spec/unit/type/file_spec.rb +195 -185
  553. data/spec/unit/type/filebucket_spec.rb +4 -5
  554. data/spec/unit/type/group_spec.rb +6 -8
  555. data/spec/unit/type/noop_metaparam_spec.rb +1 -2
  556. data/spec/unit/type/package/package_settings_spec.rb +44 -23
  557. data/spec/unit/type/package_spec.rb +56 -57
  558. data/spec/unit/type/resources_spec.rb +72 -74
  559. data/spec/unit/type/schedule_spec.rb +24 -26
  560. data/spec/unit/type/service_spec.rb +48 -48
  561. data/spec/unit/type/stage_spec.rb +0 -1
  562. data/spec/unit/type/tidy_spec.rb +61 -62
  563. data/spec/unit/type/user_spec.rb +24 -25
  564. data/spec/unit/type/whit_spec.rb +0 -1
  565. data/spec/unit/type_spec.rb +55 -54
  566. data/spec/unit/util/at_fork_spec.rb +18 -19
  567. data/spec/unit/util/autoload_spec.rb +55 -56
  568. data/spec/unit/util/backups_spec.rb +34 -35
  569. data/spec/unit/util/character_encoding_spec.rb +5 -5
  570. data/spec/unit/util/checksums_spec.rb +38 -39
  571. data/spec/unit/util/colors_spec.rb +1 -2
  572. data/spec/unit/util/command_line_spec.rb +24 -25
  573. data/spec/unit/util/constant_inflector_spec.rb +0 -1
  574. data/spec/unit/util/diff_spec.rb +7 -8
  575. data/spec/unit/util/errors_spec.rb +0 -1
  576. data/spec/unit/util/execution_spec.rb +185 -161
  577. data/spec/unit/util/execution_stub_spec.rb +0 -1
  578. data/spec/unit/util/feature_spec.rb +21 -14
  579. data/spec/unit/util/filetype_spec.rb +49 -49
  580. data/spec/unit/util/http_proxy_spec.rb +12 -12
  581. data/spec/unit/util/inifile_spec.rb +26 -31
  582. data/spec/unit/util/json_lockfile_spec.rb +3 -5
  583. data/spec/unit/util/ldap/connection_spec.rb +26 -25
  584. data/spec/unit/util/ldap/generator_spec.rb +0 -1
  585. data/spec/unit/util/ldap/manager_spec.rb +102 -101
  586. data/spec/unit/util/lockfile_spec.rb +0 -1
  587. data/spec/unit/util/log/destinations_spec.rb +30 -33
  588. data/spec/unit/util/log_spec.rb +35 -36
  589. data/spec/unit/util/logging_spec.rb +58 -72
  590. data/spec/unit/util/metric_spec.rb +0 -1
  591. data/spec/unit/util/monkey_patches_spec.rb +7 -9
  592. data/spec/unit/util/multi_match_spec.rb +0 -1
  593. data/spec/unit/util/network_device/config_spec.rb +0 -1
  594. data/spec/unit/util/network_device/transport/base_spec.rb +5 -6
  595. data/spec/unit/util/network_device_spec.rb +7 -9
  596. data/spec/unit/util/package_spec.rb +0 -1
  597. data/spec/unit/util/pidlock_spec.rb +21 -22
  598. data/spec/unit/util/plist_spec.rb +40 -33
  599. data/spec/unit/util/posix_spec.rb +54 -51
  600. data/spec/unit/util/rdoc_spec.rb +9 -10
  601. data/spec/unit/util/reference_spec.rb +0 -1
  602. data/spec/unit/util/resource_template_spec.rb +20 -20
  603. data/spec/unit/util/retry_action_spec.rb +7 -8
  604. data/spec/unit/util/rubygems_spec.rb +7 -8
  605. data/spec/unit/util/run_mode_spec.rb +3 -4
  606. data/spec/unit/util/selinux_spec.rb +79 -72
  607. data/spec/unit/util/splayer_spec.rb +8 -9
  608. data/spec/unit/util/ssl_spec.rb +0 -1
  609. data/spec/unit/util/storage_spec.rb +3 -4
  610. data/spec/unit/util/suidmanager_spec.rb +45 -54
  611. data/spec/unit/util/symbolic_file_mode_spec.rb +0 -1
  612. data/spec/unit/util/tag_set_spec.rb +0 -1
  613. data/spec/unit/util/tagging_spec.rb +0 -1
  614. data/spec/unit/util/terminal_spec.rb +9 -10
  615. data/spec/unit/util/user_attr_spec.rb +1 -2
  616. data/spec/unit/util/warnings_spec.rb +3 -4
  617. data/spec/unit/util/watcher/periodic_watcher_spec.rb +2 -2
  618. data/spec/unit/util/watcher_spec.rb +51 -21
  619. data/spec/unit/util/windows/access_control_entry_spec.rb +0 -1
  620. data/spec/unit/util/windows/access_control_list_spec.rb +0 -1
  621. data/spec/unit/util/windows/adsi_spec.rb +136 -138
  622. data/spec/unit/util/windows/api_types_spec.rb +0 -1
  623. data/spec/unit/util/windows/eventlog_spec.rb +9 -12
  624. data/spec/unit/util/windows/file_spec.rb +0 -1
  625. data/spec/unit/util/windows/root_certs_spec.rb +0 -1
  626. data/spec/unit/util/windows/security_descriptor_spec.rb +0 -2
  627. data/spec/unit/util/windows/service_spec.rb +66 -68
  628. data/spec/unit/util/windows/sid_spec.rb +11 -13
  629. data/spec/unit/util/windows/string_spec.rb +0 -1
  630. data/spec/unit/util_spec.rb +55 -57
  631. data/spec/unit/version_spec.rb +6 -6
  632. metadata +2 -2
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine/exists'
@@ -16,12 +15,12 @@ describe Puppet::Confine::Exists do
16
15
  it "should not pass if exists is nil" do
17
16
  confine = Puppet::Confine::Exists.new(nil)
18
17
  confine.label = ":exists => nil"
19
- confine.expects(:pass?).with(nil)
18
+ expect(confine).to receive(:pass?).with(nil)
20
19
  expect(confine).not_to be_valid
21
20
  end
22
21
 
23
22
  it "should use the 'pass?' method to test validity" do
24
- @confine.expects(:pass?).with("/my/file")
23
+ expect(@confine).to receive(:pass?).with("/my/file")
25
24
  @confine.valid?
26
25
  end
27
26
 
@@ -30,12 +29,12 @@ describe Puppet::Confine::Exists do
30
29
  end
31
30
 
32
31
  it "should return false if the value does not point to a file" do
33
- Puppet::FileSystem.expects(:exist?).with("/my/file").returns false
32
+ expect(Puppet::FileSystem).to receive(:exist?).with("/my/file").and_return(false)
34
33
  expect(@confine.pass?("/my/file")).to be_falsey
35
34
  end
36
35
 
37
36
  it "should return true if the value points to a file" do
38
- Puppet::FileSystem.expects(:exist?).with("/my/file").returns true
37
+ expect(Puppet::FileSystem).to receive(:exist?).with("/my/file").and_return(true)
39
38
  expect(@confine.pass?("/my/file")).to be_truthy
40
39
  end
41
40
 
@@ -44,36 +43,39 @@ describe Puppet::Confine::Exists do
44
43
  end
45
44
 
46
45
  describe "and the confine is for binaries" do
47
- before { @confine.stubs(:for_binary).returns true }
46
+ before do
47
+ allow(@confine).to receive(:for_binary).and_return(true)
48
+ end
49
+
48
50
  it "should use its 'which' method to look up the full path of the file" do
49
- @confine.expects(:which).returns nil
51
+ expect(@confine).to receive(:which).and_return(nil)
50
52
  @confine.pass?("/my/file")
51
53
  end
52
54
 
53
55
  it "should return false if no executable can be found" do
54
- @confine.expects(:which).with("/my/file").returns nil
56
+ expect(@confine).to receive(:which).with("/my/file").and_return(nil)
55
57
  expect(@confine.pass?("/my/file")).to be_falsey
56
58
  end
57
59
 
58
60
  it "should return true if the executable can be found" do
59
- @confine.expects(:which).with("/my/file").returns "/my/file"
61
+ expect(@confine).to receive(:which).with("/my/file").and_return("/my/file")
60
62
  expect(@confine.pass?("/my/file")).to be_truthy
61
63
  end
62
64
  end
63
65
 
64
66
  it "should produce a summary containing all missing files" do
65
- Puppet::FileSystem.stubs(:exist?).returns true
66
- Puppet::FileSystem.expects(:exist?).with("/two").returns false
67
- Puppet::FileSystem.expects(:exist?).with("/four").returns false
67
+ allow(Puppet::FileSystem).to receive(:exist?).and_return(true)
68
+ expect(Puppet::FileSystem).to receive(:exist?).with("/two").and_return(false)
69
+ expect(Puppet::FileSystem).to receive(:exist?).with("/four").and_return(false)
68
70
 
69
71
  confine = Puppet::Confine::Exists.new %w{/one /two /three /four}
70
72
  expect(confine.summary).to eq(%w{/two /four})
71
73
  end
72
74
 
73
75
  it "should summarize multiple instances by returning a flattened array of their summaries" do
74
- c1 = mock '1', :summary => %w{one}
75
- c2 = mock '2', :summary => %w{two}
76
- c3 = mock '3', :summary => %w{three}
76
+ c1 = double('1', :summary => %w{one})
77
+ c2 = double('2', :summary => %w{two})
78
+ c3 = double('3', :summary => %w{three})
77
79
 
78
80
  expect(Puppet::Confine::Exists.summarize([c1, c2, c3])).to eq(%w{one two three})
79
81
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine/false'
@@ -45,7 +44,7 @@ describe Puppet::Confine::False do
45
44
  it "should use the 'pass?' method to test validity" do
46
45
  @confine = Puppet::Confine::False.new("foo")
47
46
  @confine.label = "eh"
48
- @confine.expects(:pass?).with("foo")
47
+ expect(@confine).to receive(:pass?).with("foo")
49
48
  @confine.valid?
50
49
  end
51
50
 
@@ -65,14 +64,14 @@ describe Puppet::Confine::False do
65
64
 
66
65
  it "should be able to produce a summary with the number of incorrectly true values" do
67
66
  confine = Puppet::Confine::False.new %w{one two three four}
68
- confine.expects(:pass?).times(4).returns(true).returns(false).returns(true).returns(false)
67
+ expect(confine).to receive(:pass?).exactly(4).times.and_return(true, false, true, false)
69
68
  expect(confine.summary).to eq(2)
70
69
  end
71
70
 
72
71
  it "should summarize multiple instances by summing their summaries" do
73
- c1 = mock '1', :summary => 1
74
- c2 = mock '2', :summary => 2
75
- c3 = mock '3', :summary => 3
72
+ c1 = double('1', :summary => 1)
73
+ c2 = double('2', :summary => 2)
74
+ c3 = double('3', :summary => 3)
76
75
 
77
76
  expect(Puppet::Confine::False.summarize([c1, c2, c3])).to eq(6)
78
77
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine/feature'
@@ -23,7 +22,7 @@ describe Puppet::Confine::Feature do
23
22
  end
24
23
 
25
24
  it "should use the Puppet features instance to test validity" do
26
- Puppet.features.expects(:myfeature?)
25
+ expect(Puppet.features).to receive(:myfeature?)
27
26
  @confine.valid?
28
27
  end
29
28
 
@@ -48,9 +47,12 @@ describe Puppet::Confine::Feature do
48
47
  confines << Puppet::Confine::Feature.new(%w{two})
49
48
  confines << Puppet::Confine::Feature.new(%w{three four})
50
49
 
51
- features = mock 'feature'
52
- features.stub_everything
53
- Puppet.stubs(:features).returns features
50
+ features = double('feature')
51
+ allow(features).to receive(:one?)
52
+ allow(features).to receive(:two?)
53
+ allow(features).to receive(:three?)
54
+ allow(features).to receive(:four?)
55
+ allow(Puppet).to receive(:features).and_return(features)
54
56
 
55
57
  expect(Puppet::Confine::Feature.summarize(confines).sort).to eq(%w{one two three four}.sort)
56
58
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine/true'
@@ -46,7 +45,7 @@ describe Puppet::Confine::True do
46
45
  end
47
46
 
48
47
  it "should use the 'pass?' method to test validity" do
49
- @confine.expects(:pass?).with("foo")
48
+ expect(@confine).to receive(:pass?).with("foo")
50
49
  @confine.valid?
51
50
  end
52
51
 
@@ -65,14 +64,14 @@ describe Puppet::Confine::True do
65
64
 
66
65
  it "should produce the number of false values when asked for a summary" do
67
66
  @confine = Puppet::Confine::True.new %w{one two three four}
68
- @confine.expects(:pass?).times(4).returns(true).returns(false).returns(true).returns(false)
67
+ expect(@confine).to receive(:pass?).exactly(4).times.and_return(true, false, true, false)
69
68
  expect(@confine.summary).to eq(2)
70
69
  end
71
70
 
72
71
  it "should summarize multiple instances by summing their summaries" do
73
- c1 = mock '1', :summary => 1
74
- c2 = mock '2', :summary => 2
75
- c3 = mock '3', :summary => 3
72
+ c1 = double('1', :summary => 1)
73
+ c2 = double('2', :summary => 2)
74
+ c3 = double('3', :summary => 3)
76
75
 
77
76
  expect(Puppet::Confine::True.summarize([c1, c2, c3])).to eq(6)
78
77
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine/variable'
@@ -27,37 +26,37 @@ describe Puppet::Confine::Variable do
27
26
  end
28
27
 
29
28
  it "should use settings if the variable name is a valid setting" do
30
- Puppet.settings.expects(:valid?).with(:myvar).returns true
31
- Puppet.settings.expects(:value).with(:myvar).returns "foo"
29
+ expect(Puppet.settings).to receive(:valid?).with(:myvar).and_return(true)
30
+ expect(Puppet.settings).to receive(:value).with(:myvar).and_return("foo")
32
31
  @confine.valid?
33
32
  end
34
33
 
35
34
  it "should use Facter if the variable name is not a valid setting" do
36
- Puppet.settings.expects(:valid?).with(:myvar).returns false
37
- Facter.expects(:value).with(:myvar).returns "foo"
35
+ expect(Puppet.settings).to receive(:valid?).with(:myvar).and_return(false)
36
+ expect(Facter).to receive(:value).with(:myvar).and_return("foo")
38
37
  @confine.valid?
39
38
  end
40
39
 
41
40
  it "should be valid if the value matches the facter value" do
42
- @confine.expects(:test_value).returns "foo"
41
+ expect(@confine).to receive(:test_value).and_return("foo")
43
42
 
44
43
  expect(@confine).to be_valid
45
44
  end
46
45
 
47
46
  it "should return false if the value does not match the facter value" do
48
- @confine.expects(:test_value).returns "fee"
47
+ expect(@confine).to receive(:test_value).and_return("fee")
49
48
 
50
49
  expect(@confine).not_to be_valid
51
50
  end
52
51
 
53
52
  it "should be case insensitive" do
54
- @confine.expects(:test_value).returns "FOO"
53
+ expect(@confine).to receive(:test_value).and_return("FOO")
55
54
 
56
55
  expect(@confine).to be_valid
57
56
  end
58
57
 
59
58
  it "should not care whether the value is a string or symbol" do
60
- @confine.expects(:test_value).returns "FOO"
59
+ expect(@confine).to receive(:test_value).and_return("FOO")
61
60
 
62
61
  expect(@confine).to be_valid
63
62
  end
@@ -72,7 +71,7 @@ describe Puppet::Confine::Variable do
72
71
 
73
72
  it "should be valid if the test value matches any of the provided values" do
74
73
  @confine = Puppet::Confine::Variable.new(%w{bar bee})
75
- @confine.expects(:test_value).returns "bee"
74
+ expect(@confine).to receive(:test_value).and_return("bee")
76
75
  expect(@confine).to be_valid
77
76
  end
78
77
  end
@@ -81,13 +80,13 @@ describe Puppet::Confine::Variable do
81
80
  it "should return a hash of failing variables and their values" do
82
81
  c1 = Puppet::Confine::Variable.new("one")
83
82
  c1.name = "uno"
84
- c1.expects(:valid?).returns false
83
+ expect(c1).to receive(:valid?).and_return(false)
85
84
  c2 = Puppet::Confine::Variable.new("two")
86
85
  c2.name = "dos"
87
- c2.expects(:valid?).returns true
86
+ expect(c2).to receive(:valid?).and_return(true)
88
87
  c3 = Puppet::Confine::Variable.new("three")
89
88
  c3.name = "tres"
90
- c3.expects(:valid?).returns false
89
+ expect(c3).to receive(:valid?).and_return(false)
91
90
 
92
91
  expect(Puppet::Confine::Variable.summarize([c1, c2, c3])).to eq({"uno" => %w{one}, "tres" => %w{three}})
93
92
  end
@@ -95,10 +94,10 @@ describe Puppet::Confine::Variable do
95
94
  it "should combine the values of multiple confines with the same fact" do
96
95
  c1 = Puppet::Confine::Variable.new("one")
97
96
  c1.name = "uno"
98
- c1.expects(:valid?).returns false
97
+ expect(c1).to receive(:valid?).and_return(false)
99
98
  c2 = Puppet::Confine::Variable.new("two")
100
99
  c2.name = "uno"
101
- c2.expects(:valid?).returns false
100
+ expect(c2).to receive(:valid?).and_return(false)
102
101
 
103
102
  expect(Puppet::Confine::Variable.summarize([c1, c2])).to eq({"uno" => %w{one two}})
104
103
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine_collection'
@@ -18,20 +17,20 @@ describe Puppet::ConfineCollection do
18
17
 
19
18
  describe "when creating confine instances" do
20
19
  it "should create an instance of the named test with the provided values" do
21
- test_class = mock 'test_class'
22
- test_class.expects(:new).with(%w{my values}).returns(stub('confine', :label= => nil))
23
- Puppet::Confine.expects(:test).with(:foo).returns test_class
20
+ test_class = double('test_class')
21
+ expect(test_class).to receive(:new).with(%w{my values}).and_return(double('confine', :label= => nil))
22
+ expect(Puppet::Confine).to receive(:test).with(:foo).and_return(test_class)
24
23
 
25
24
  Puppet::ConfineCollection.new("label").confine :foo => %w{my values}
26
25
  end
27
26
 
28
27
  it "should copy its label to the confine instance" do
29
- confine = mock 'confine'
30
- test_class = mock 'test_class'
31
- test_class.expects(:new).returns confine
32
- Puppet::Confine.expects(:test).returns test_class
28
+ confine = double('confine')
29
+ test_class = double('test_class')
30
+ expect(test_class).to receive(:new).and_return(confine)
31
+ expect(Puppet::Confine).to receive(:test).and_return(test_class)
33
32
 
34
- confine.expects(:label=).with("label")
33
+ expect(confine).to receive(:label=).with("label")
35
34
 
36
35
  Puppet::ConfineCollection.new("label").confine :foo => %w{my values}
37
36
  end
@@ -39,8 +38,8 @@ describe Puppet::ConfineCollection do
39
38
  describe "and the test cannot be found" do
40
39
  it "should create a Facter test with the provided values and set the name to the test name" do
41
40
  confine = Puppet::Confine.test(:variable).new(%w{my values})
42
- confine.expects(:name=).with(:foo)
43
- confine.class.expects(:new).with(%w{my values}).returns confine
41
+ expect(confine).to receive(:name=).with(:foo)
42
+ expect(confine.class).to receive(:new).with(%w{my values}).and_return(confine)
44
43
  Puppet::ConfineCollection.new("label").confine(:foo => %w{my values})
45
44
  end
46
45
  end
@@ -48,8 +47,8 @@ describe Puppet::ConfineCollection do
48
47
  describe "and the 'for_binary' option was provided" do
49
48
  it "should mark the test as a binary confine" do
50
49
  confine = Puppet::Confine.test(:exists).new(:bar)
51
- confine.expects(:for_binary=).with true
52
- Puppet::Confine.test(:exists).expects(:new).with(:bar).returns confine
50
+ expect(confine).to receive(:for_binary=).with(true)
51
+ expect(Puppet::Confine.test(:exists)).to receive(:new).with(:bar).and_return(confine)
53
52
  Puppet::ConfineCollection.new("label").confine :exists => :bar, :for_binary => true
54
53
  end
55
54
  end
@@ -60,11 +59,11 @@ describe Puppet::ConfineCollection do
60
59
  end
61
60
 
62
61
  it "should be valid if all confines pass" do
63
- c1 = stub 'c1', :valid? => true, :label= => nil
64
- c2 = stub 'c2', :valid? => true, :label= => nil
62
+ c1 = double('c1', :valid? => true, :label= => nil)
63
+ c2 = double('c2', :valid? => true, :label= => nil)
65
64
 
66
- Puppet::Confine.test(:true).expects(:new).returns(c1)
67
- Puppet::Confine.test(:false).expects(:new).returns(c2)
65
+ expect(Puppet::Confine.test(:true)).to receive(:new).and_return(c1)
66
+ expect(Puppet::Confine.test(:false)).to receive(:new).and_return(c2)
68
67
 
69
68
  confiner = Puppet::ConfineCollection.new("label")
70
69
  confiner.confine :true => :bar, :false => :bee
@@ -73,11 +72,11 @@ describe Puppet::ConfineCollection do
73
72
  end
74
73
 
75
74
  it "should not be valid if any confines fail" do
76
- c1 = stub 'c1', :valid? => true, :label= => nil
77
- c2 = stub 'c2', :valid? => false, :label= => nil
75
+ c1 = double('c1', :valid? => true, :label= => nil)
76
+ c2 = double('c2', :valid? => false, :label= => nil)
78
77
 
79
- Puppet::Confine.test(:true).expects(:new).returns(c1)
80
- Puppet::Confine.test(:false).expects(:new).returns(c2)
78
+ expect(Puppet::Confine.test(:true)).to receive(:new).and_return(c1)
79
+ expect(Puppet::Confine.test(:false)).to receive(:new).and_return(c2)
81
80
 
82
81
  confiner = Puppet::ConfineCollection.new("label")
83
82
  confiner.confine :true => :bar, :false => :bee
@@ -100,32 +99,32 @@ describe Puppet::ConfineCollection do
100
99
 
101
100
  it "should add each test type's summary to the hash" do
102
101
  @confiner.confine :true => :bar, :false => :bee
103
- Puppet::Confine.test(:true).expects(:summarize).returns :tsumm
104
- Puppet::Confine.test(:false).expects(:summarize).returns :fsumm
102
+ expect(Puppet::Confine.test(:true)).to receive(:summarize).and_return(:tsumm)
103
+ expect(Puppet::Confine.test(:false)).to receive(:summarize).and_return(:fsumm)
105
104
 
106
105
  expect(@confiner.summary).to eq({:true => :tsumm, :false => :fsumm})
107
106
  end
108
107
 
109
108
  it "should not include tests that return 0" do
110
109
  @confiner.confine :true => :bar, :false => :bee
111
- Puppet::Confine.test(:true).expects(:summarize).returns 0
112
- Puppet::Confine.test(:false).expects(:summarize).returns :fsumm
110
+ expect(Puppet::Confine.test(:true)).to receive(:summarize).and_return(0)
111
+ expect(Puppet::Confine.test(:false)).to receive(:summarize).and_return(:fsumm)
113
112
 
114
113
  expect(@confiner.summary).to eq({:false => :fsumm})
115
114
  end
116
115
 
117
116
  it "should not include tests that return empty arrays" do
118
117
  @confiner.confine :true => :bar, :false => :bee
119
- Puppet::Confine.test(:true).expects(:summarize).returns []
120
- Puppet::Confine.test(:false).expects(:summarize).returns :fsumm
118
+ expect(Puppet::Confine.test(:true)).to receive(:summarize).and_return([])
119
+ expect(Puppet::Confine.test(:false)).to receive(:summarize).and_return(:fsumm)
121
120
 
122
121
  expect(@confiner.summary).to eq({:false => :fsumm})
123
122
  end
124
123
 
125
124
  it "should not include tests that return empty hashes" do
126
125
  @confiner.confine :true => :bar, :false => :bee
127
- Puppet::Confine.test(:true).expects(:summarize).returns({})
128
- Puppet::Confine.test(:false).expects(:summarize).returns :fsumm
126
+ expect(Puppet::Confine.test(:true)).to receive(:summarize).and_return({})
127
+ expect(Puppet::Confine.test(:false)).to receive(:summarize).and_return(:fsumm)
129
128
 
130
129
  expect(@confiner.summary).to eq({:false => :fsumm})
131
130
  end
@@ -1,4 +1,3 @@
1
- #! /usr/bin/env ruby
2
1
  require 'spec_helper'
3
2
 
4
3
  require 'puppet/confine'
@@ -39,26 +38,26 @@ describe Puppet::Confine do
39
38
  end
40
39
 
41
40
  it "should be invalid if any values fail" do
42
- @confine.stubs(:pass?).returns true
43
- @confine.expects(:pass?).with("b").returns false
41
+ allow(@confine).to receive(:pass?).and_return(true)
42
+ expect(@confine).to receive(:pass?).with("b").and_return(false)
44
43
  expect(@confine).not_to be_valid
45
44
  end
46
45
 
47
46
  it "should be valid if all values pass" do
48
- @confine.stubs(:pass?).returns true
47
+ allow(@confine).to receive(:pass?).and_return(true)
49
48
  expect(@confine).to be_valid
50
49
  end
51
50
 
52
51
  it "should short-cut at the first failing value" do
53
- @confine.expects(:pass?).once.returns false
52
+ expect(@confine).to receive(:pass?).once.and_return(false)
54
53
  @confine.valid?
55
54
  end
56
55
 
57
56
  it "should log failing confines with the label and message" do
58
- @confine.stubs(:pass?).returns false
59
- @confine.expects(:message).returns "My message"
60
- @confine.expects(:label).returns "Mylabel"
61
- Puppet.expects(:debug).with("Mylabel: My message")
57
+ allow(@confine).to receive(:pass?).and_return(false)
58
+ expect(@confine).to receive(:message).and_return("My message")
59
+ expect(@confine).to receive(:label).and_return("Mylabel")
60
+ expect(Puppet).to receive(:debug).with("Mylabel: My message")
62
61
  @confine.valid?
63
62
  end
64
63
  end
@@ -67,9 +66,9 @@ describe Puppet::Confine do
67
66
  before { @confine = Puppet::Confine.new(%w{a b c d}) }
68
67
 
69
68
  it "should return an array with the result of the test for each value" do
70
- @confine.stubs(:pass?).returns true
71
- @confine.expects(:pass?).with("b").returns false
72
- @confine.expects(:pass?).with("d").returns false
69
+ allow(@confine).to receive(:pass?).and_return(true)
70
+ expect(@confine).to receive(:pass?).with("b").and_return(false)
71
+ expect(@confine).to receive(:pass?).with("d").and_return(false)
73
72
 
74
73
  expect(@confine.result).to eq([true, false, true, false])
75
74
  end
@@ -78,14 +77,14 @@ describe Puppet::Confine do
78
77
  describe "when requiring" do
79
78
  it "does not cache failed requires when always_retry_plugins is true" do
80
79
  Puppet[:always_retry_plugins] = true
81
- Puppet::Confine.expects(:require).with('puppet/confine/osfamily').twice.raises(LoadError)
80
+ expect(Puppet::Confine).to receive(:require).with('puppet/confine/osfamily').twice.and_raise(LoadError)
82
81
  Puppet::Confine.test(:osfamily)
83
82
  Puppet::Confine.test(:osfamily)
84
83
  end
85
84
 
86
85
  it "caches failed requires when always_retry_plugins is false" do
87
86
  Puppet[:always_retry_plugins] = false
88
- Puppet::Confine.expects(:require).with('puppet/confine/osfamily').once.raises(LoadError)
87
+ expect(Puppet::Confine).to receive(:require).with('puppet/confine/osfamily').once.and_raise(LoadError)
89
88
  Puppet::Confine.test(:osfamily)
90
89
  Puppet::Confine.test(:osfamily)
91
90
  end