polishgeeks-dev-tools 1.3.2 → 1.4.0

data/spec/lib/polish_geeks/dev_tools/output_storer_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::OutputStorer do
-  subject { described_class.new }
+  subject(:output_storer) { described_class.new }
 
   describe '#initialize' do
     context 'when we execute the command' do
@@ -13,7 +13,7 @@ RSpec.describe PolishGeeks::DevTools::OutputStorer do
       end
 
       it 'stores an output' do
-        expect(subject.send(:initialize)).to eq result
+        expect(output_storer.send(:initialize)).to eq result
       end
     end
   end

data/spec/lib/polish_geeks/dev_tools/runner_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Runner do
-  subject { described_class.new }
+  subject(:runner) { described_class.new }
 
   describe '#execute' do
     let(:logger) { double }
@@ -55,6 +55,6 @@ RSpec.describe PolishGeeks::DevTools::Runner do
       end
     end
 
-    it { subject.execute(logger) }
+    it { runner.execute(logger) }
   end
 end

data/spec/lib/polish_geeks/dev_tools/shell_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Shell do
-  subject { described_class.new }
+  subject(:shell) { described_class.new }
 
   describe '#execute' do
     context 'when we run a command' do
       it 'executes the command' do
-        expect(subject.execute('ls')).to include('Gemfile')
+        expect(shell.execute('ls')).to include('Gemfile')
       end
     end
   end

data/spec/lib/polish_geeks/dev_tools/validators/base_spec.rb

@@ -1,31 +1,31 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Validators::Base do
+  subject(:base) { described_class.new(output) }
   let(:output) { :output }
-  subject { described_class.new(output) }
 
   describe '#new' do
-    it { expect(subject.instance_variable_get(:@stored_output)).to eq output }
+    it { expect(base.instance_variable_get(:@stored_output)).to eq output }
   end
 
   describe '#valid?' do
     it do
-      expect { subject.valid? }.to raise_error(PolishGeeks::DevTools::Errors::NotImplementedError)
+      expect { base.valid? }.to raise_error(PolishGeeks::DevTools::Errors::NotImplementedError)
     end
   end
 
   describe '#validate!' do
     context 'valid? true' do
-      before { expect(subject).to receive(:valid?) { true } }
+      before { expect(base).to receive(:valid?) { true } }
 
-      it { expect { subject.validate! }.not_to raise_error }
+      it { expect { base.validate! }.not_to raise_error }
     end
 
     context 'valid? false' do
-      before { expect(subject).to receive(:valid?) { false } }
+      before { expect(base).to receive(:valid?) { false } }
 
       it do
-        expect { subject.validate! }.to raise_error(
+        expect { base.validate! }.to raise_error(
           PolishGeeks::DevTools::Errors::PreCommandValidationError
         )
       end

data/spec/lib/polish_geeks/dev_tools/validators/rails_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Validators::Rails do
-  subject { described_class.new(double) }
+  subject(:rails) { described_class.new(double) }
 
   describe '#valid?' do
     context 'false' do
       context 'when Rails not defined' do
         before { allow(Object).to receive(:const_defined?) { false } }
-        it { expect(subject.valid?).to be false }
+        it { expect(rails.valid?).to be false }
       end
     end
 
     context 'true' do
       context 'when Rails defined' do
         before { allow(Object).to receive(:const_defined?) { true } }
-        it { expect(subject.valid?).to be true }
+        it { expect(rails.valid?).to be true }
       end
     end
   end

data/spec/lib/polish_geeks/dev_tools/validators/rubocop_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Validators::Rubocop do
-  subject { described_class.new(double) }
+  subject(:rubocop) { described_class.new(double) }
 
   describe '#valid?' do
     context 'false' do
@@ -11,7 +11,7 @@ RSpec.describe PolishGeeks::DevTools::Validators::Rubocop do
             instance_double(PolishGeeks::DevTools::Config, rubocop: false)
           )
         end
-        it { expect(subject.valid?).to be false }
+        it { expect(rubocop.valid?).to be false }
       end
     end
 
@@ -22,7 +22,7 @@ RSpec.describe PolishGeeks::DevTools::Validators::Rubocop do
             instance_double(PolishGeeks::DevTools::Config, rubocop: true)
           )
         end
-        it { expect(subject.valid?).to be true }
+        it { expect(rubocop.valid?).to be true }
       end
     end
   end

data/spec/lib/polish_geeks/dev_tools/validators/simplecov_spec.rb

@@ -1,15 +1,15 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Validators::Simplecov do
+  subject(:simplecov) { described_class.new(output) }
   let(:output) do
     OpenStruct.new(
       rspec: '370 / 669 LOC (95.00%) covered'
     )
   end
-  subject { described_class.new(output) }
 
   describe '#valid?' do
-    subject do
+    subject(:simplecov) do
       described_class.new(
         OpenStruct.new(
           rspec: 'output'
@@ -19,26 +19,27 @@ RSpec.describe PolishGeeks::DevTools::Validators::Simplecov do
 
     context 'false' do
       context 'when SimpleCov not defined' do
-        before { allow(Object).to receive(:const_defined?) { false } }
-        it do
-          expect(subject).to receive(:output)
-          expect(subject.valid?).to be false
+        before do
+          allow(Object).to receive(:const_defined?) { false }
+          expect(simplecov).to receive(:output)
         end
+        it { expect(simplecov.valid?).to be false }
       end
     end
 
     context 'true' do
       context 'when SimpleCov defined' do
-        before { allow(Object).to receive(:const_defined?) { true } }
-        it do
-          expect(subject).not_to receive(:output)
-          expect(subject.valid?).to be true
+        before do
+          allow(Object).to receive(:const_defined?) { true }
+          expect(simplecov).not_to receive(:output)
         end
+
+        it { expect(simplecov.valid?).to be true }
       end
     end
   end
 
   describe '#output' do
-    it { expect(subject.output).to eq('(95.00%) covered') }
+    it { expect(simplecov.output).to eq('(95.00%) covered') }
   end
 end

data/spec/lib/polish_geeks/dev_tools/version_spec.rb

@@ -1,7 +1,5 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools do
-  subject { described_class }
-
-  it { should be_const_defined(:VERSION) }
+  it { is_expected.to be_const_defined(:VERSION) }
 end

data/spec/lib/polish_geeks/dev_tools_spec.rb

@@ -1,35 +1,29 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools do
-  subject { described_class }
+  subject(:dev_tools) { described_class }
 
   describe '.gem_root' do
     context 'when we want to get gem root path' do
       let(:path) { Dir.pwd }
-      it do
-        expect(subject.gem_root).to eq path
-      end
+      it { expect(dev_tools.gem_root).to eq path }
     end
   end
 
   describe '.app_root' do
     context 'when we want to get app root path' do
-      before do
-        expect(ENV).to receive(:[]).with('BUNDLE_GEMFILE').and_return('/')
-      end
-
-      it { expect(subject.app_root).to eq '/' }
+      before { expect(ENV).to receive(:[]).with('BUNDLE_GEMFILE').and_return('/') }
+      it { expect(dev_tools.app_root).to eq '/' }
     end
   end
 
   describe '.setup' do
     let(:config_block) { -> {} }
 
-    it 'passes it to Config setup method' do
-      expect(described_class::Config)
-        .to receive(:setup)
+    before { expect(described_class::Config).to receive(:setup) }
 
-      subject.setup(&config_block)
+    it 'passes it to Config setup method' do
+      dev_tools.setup(&config_block)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: polishgeeks-dev-tools
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.0
 platform: ruby
 authors:
 - Maciej Mensfeld
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-27 00:00:00.000000000 Z
+date: 2016-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -336,7 +322,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Set of tools used when developing Ruby based apps
@@ -378,4 +364,3 @@ test_files:
 - spec/lib/polish_geeks/dev_tools/version_spec.rb
 - spec/lib/polish_geeks/dev_tools_spec.rb
 - spec/spec_helper.rb
-has_rdoc: