polishgeeks-dev-tools 1.3.2 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea68396ef20461f7c319bf534b51004343fa0223
-  data.tar.gz: 683ada98afdca85a2328d1da750a5e804ba4c37f
+  metadata.gz: 77dfaf8b2a1c6aded4c745df325b75f3837e12c8
+  data.tar.gz: bbfe2c3b28c160a3d25a543f7884166c6c687240
 SHA512:
-  metadata.gz: a8f5d62c2bb3c8896c7badc10e40450879faf9076d7e32ab156907b82db247c12d01cfe58a1c16b1e262c1b429f3ead38bc084c093950aeccfd751916931dbfd
-  data.tar.gz: 4e81520a2babbe0b80dbad48c0c97752b8af6951576167496af7e593e91f81bfbf342dd78650c48699a1ed83ae1285e809e26590ee6d9029ecbdf32c4f2eda59
+  metadata.gz: 03bdc56af329edef9639d8dc7bc514fe10520afbd6a5dfe7b882c6480fc52abac3df3cc560a05aaf4bd3e75309f179d688c849659405d88f6f841ba0a312c154
+  data.tar.gz: b0b42078437d4b16e123982d0fb7efddd462be091879aa8b8c1a95059ae795deea5e7d86e7088f3971b9377b425e78ed8a71d31c3e8649c0d638a03e4426e77b

data/.ruby-version

@@ -1 +1 @@
-ruby-2.3.0
+ruby-2.3.3

data/.travis.yml

@@ -1,7 +1,6 @@
 language: ruby
 rvm:
-  - 2.1.10
-  - 2.2.4
-  - 2.3.0
+  - 2.2.6
+  - 2.3.3
 script:
   - bundle exec rake

data/CHANGELOG.md

@@ -2,6 +2,19 @@
 
 ## master (unreleased)
 
+## 1.4.0 (26/11/2016)
+
+- bump to ruby 2.3.3
+- drop support for ruby 2.1.x
+- haml_lint 0.18.4
+- yard 0.9.5
+- rubycritic 3.1.0
+- brakeman 3.4.1
+- rubocop 0.45.0
+- rubocop-rspec 1.8.0
+- replace pry with byebug
+- [#63](https://github.com/polishgeeks/polishgeeks-dev-tools/issues/63) ignore vim swap files in FinalBlankLine validator
+
 ## 1.3.2 (27/06/2016)
 
 - Bump rubycritic dependency to 2.9.1

data/Gemfile

@@ -1,2 +1,4 @@
 source 'https://rubygems.org'
 gemspec
+
+gem 'byebug'

data/Gemfile.lock

@@ -1,12 +1,11 @@
 PATH
   remote: .
   specs:
-    polishgeeks-dev-tools (1.3.2)
+    polishgeeks-dev-tools (1.4.0)
       brakeman
       bundler-audit
       faker
       haml_lint
-      pry
       rspec
       rubocop
       rubocop-rspec
@@ -19,116 +18,114 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.2.6)
+    activesupport (5.0.0.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.4.0)
+    addressable (2.5.0)
+      public_suffix (~> 2.0, >= 2.0.2)
     ast (2.3.0)
     axiom-types (0.1.1)
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
-    brakeman (3.3.2)
+    brakeman (3.4.1)
     bundler-audit (0.5.0)
       bundler (~> 1.2)
       thor (~> 0.18)
-    codeclimate-engine-rb (0.3.1)
+    byebug (9.0.6)
+    codeclimate-engine-rb (0.4.0)
       virtus (~> 1.0)
-    coderay (1.1.1)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
-    colorize (0.8.0)
+    concurrent-ruby (1.0.2)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
     docile (1.1.5)
     equalizer (0.0.11)
     erubis (2.7.0)
-    faker (1.6.3)
+    faker (1.6.6)
       i18n (~> 0.5)
-    flay (2.7.0)
+    flay (2.8.1)
       erubis (~> 2.7.0)
+      path_expander (~> 1.0)
       ruby_parser (~> 3.0)
       sexp_processor (~> 4.0)
-    flog (4.3.2)
+    flog (4.4.0)
+      path_expander (~> 1.0)
       ruby_parser (~> 3.1, > 3.1.0)
       sexp_processor (~> 4.4)
     haml (4.0.7)
       tilt
-    haml_lint (0.17.1)
+    haml_lint (0.18.4)
       haml (~> 4.0)
       rake (>= 10, < 12)
       rubocop (>= 0.36.0)
       sysexits (~> 1.1)
     i18n (0.7.0)
     ice_nine (0.11.2)
-    json (1.8.3)
+    json (2.0.2)
     launchy (2.4.3)
       addressable (~> 2.3)
-    method_source (0.8.2)
-    minitest (5.9.0)
-    parser (2.3.1.0)
+    minitest (5.9.1)
+    parser (2.3.1.4)
       ast (~> 2.2)
+    path_expander (1.0.0)
     powerpack (0.1.1)
-    pry (0.10.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
+    public_suffix (2.0.4)
     rainbow (2.1.0)
-    rake (11.1.2)
-    reek (4.0.2)
-      codeclimate-engine-rb (~> 0.3.1)
-      parser (~> 2.3, >= 2.3.0.6)
+    rake (11.3.0)
+    reek (4.5.2)
+      codeclimate-engine-rb (~> 0.4.0)
+      parser (~> 2.3.1, >= 2.3.1.2)
       rainbow (~> 2.0)
-    rspec (3.4.0)
-      rspec-core (~> 3.4.0)
-      rspec-expectations (~> 3.4.0)
-      rspec-mocks (~> 3.4.0)
-    rspec-core (3.4.4)
-      rspec-support (~> 3.4.0)
-    rspec-expectations (3.4.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-mocks (3.4.1)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.4.0)
-    rspec-support (3.4.1)
-    rubocop (0.40.0)
-      parser (>= 2.3.1.0, < 3.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    rubocop (0.45.0)
+      parser (>= 2.3.1.1, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    rubocop-rspec (1.5.0)
-      rubocop (>= 0.40.0)
+    rubocop-rspec (1.8.0)
+      rubocop (>= 0.42.0)
     ruby-progressbar (1.8.1)
-    ruby_parser (3.8.2)
+    ruby_parser (3.8.3)
       sexp_processor (~> 4.1)
-    rubycritic (2.9.1)
-      colorize
-      flay (= 2.7.0)
-      flog (= 4.3.2)
+    rubycritic (3.1.0)
+      flay (~> 2.8)
+      flog (~> 4.4)
       launchy (= 2.4.3)
-      parser (= 2.3.1.0)
-      reek (= 4.0.2)
+      parser (= 2.3.1.4)
+      rainbow
+      reek (~> 4.4)
       ruby_parser (~> 3.8)
       virtus (~> 1.0)
     sexp_processor (4.7.0)
     shoulda (3.5.0)
       shoulda-context (~> 1.0, >= 1.0.1)
       shoulda-matchers (>= 1.4.1, < 3.0)
-    shoulda-context (1.2.1)
+    shoulda-context (1.2.2)
     shoulda-matchers (2.8.0)
       activesupport (>= 3.0.0)
-    simplecov (0.11.2)
+    simplecov (0.12.0)
       docile (~> 1.1.0)
-      json (~> 1.8)
+      json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.0)
-    slop (3.6.0)
     sysexits (1.2.0)
     thor (0.19.1)
     thread_safe (0.3.5)
@@ -136,21 +133,22 @@ GEM
     timecop (0.8.1)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
-    unicode-display_width (1.1.0)
+    unicode-display_width (1.1.1)
     virtus (1.0.5)
       axiom-types (~> 0.1)
       coercible (~> 1.0)
       descendants_tracker (~> 0.0, >= 0.0.3)
       equalizer (~> 0.0, >= 0.0.9)
-    yard (0.8.7.6)
+    yard (0.9.5)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler
+  byebug
   polishgeeks-dev-tools!
   rake
 
 BUNDLED WITH
-   1.11.2
+   1.13.6

data/config/rubocop_rspec.yml

@@ -1,2 +1,8 @@
 RSpec/ExampleLength:
   Max: 10
+RSpec/SubjectStub:
+  Enabled: false
+RSpec/NestedGroups:
+  MaxNesting: 4
+RSpec/MessageChain:
+  Enabled: false

data/lib/polish_geeks/dev_tools/commands/base.rb

@@ -14,7 +14,7 @@ module PolishGeeks
         # Available command types. We have validators that check something
         # and that should have a 'valid?' method and that check for errors, etc
         # and generators that are executed to generate some stats, docs, etc
-        TYPES = %i( validator generator ).freeze
+        TYPES = %i(validator generator).freeze
 
         class << self
           # ConfigManager instance can be provided, which allows us to find a
@@ -23,10 +23,10 @@ module PolishGeeks
           attr_accessor :type
           attr_accessor :validators
 
-          TYPES.each do |type|
+          TYPES.each do |command_type|
             # @return [Boolean] if it is a given type command
-            define_method :"#{type}?" do
-              self.type == type
+            define_method :"#{command_type}?" do
+              type == command_type
             end
           end
         end

data/lib/polish_geeks/dev_tools/commands/brakeman.rb

@@ -29,7 +29,7 @@ module PolishGeeks
 
         # @return [Boolean] true if we didn't have any vulnerabilities detected
         def valid?
-          warnings == 0 && errors == 0
+          warnings.zero? && errors.zero?
         end
 
         # @return [String] label with details bout brakeman scan

data/lib/polish_geeks/dev_tools/commands/empty_methods/file_parser.rb

@@ -55,7 +55,7 @@ module PolishGeeks
           # @param [Array<String>] method_body
           # @return [Boolean] whether method is empty or not
           def method_is_empty?(method_body)
-            !method_body.inject(false) { |a, e| a || e.not_commented_or_empty? }
+            !method_body.inject(false) { |acc, elem| acc || elem.not_commented_or_empty? }
           end
 
           # Adds line number of empty method to empty_methods.

data/lib/polish_geeks/dev_tools/commands/final_blank_line.rb

@@ -19,6 +19,8 @@ module PolishGeeks
           app/assets/fonts
           .DS_Store
           .gem
+          .swp
+          .swo
         ).freeze
 
         # Executes this command and set output and counter variables
@@ -94,7 +96,7 @@ module PolishGeeks
         # @return [Boolean] true if file is empty or has final blank line.
         #   Otherwise return false.
         def file_valid?(file)
-          File.size(file) == 0 || IO.readlines(file).last[-1] == "\n"
+          File.size(file).zero? || IO.readlines(file).last[-1] == "\n"
         end
       end
     end

data/lib/polish_geeks/dev_tools/commands/rubocop.rb

@@ -24,7 +24,7 @@ module PolishGeeks
 
         # @return [Boolean] true if there were no Rubocop offenses detected
         def valid?
-          offenses_count == 0
+          offenses_count.zero?
         end
 
         # @return [String] default label for this command

data/lib/polish_geeks/dev_tools/version.rb

@@ -3,6 +3,6 @@ module PolishGeeks
   # Dev Tools for PolishGeeks developers
   module DevTools
     # Current version of dev tools
-    VERSION = '1.3.2'.freeze
+    VERSION = '1.4.0'.freeze
   end
 end

data/lib/polishgeeks-dev-tools.rb

@@ -1,7 +1,6 @@
 %w(
   yaml
   yard
-  pry
   fileutils
   timecop
   faker

data/polishgeeks_dev_tools.gemspec

@@ -18,7 +18,6 @@ Gem::Specification.new do |s|
   s.add_dependency 'bundler-audit'
   s.add_dependency 'simplecov'
   s.add_dependency 'rubycritic'
-  s.add_dependency 'pry'
   s.add_dependency 'yard'
   s.add_dependency 'faker'
   s.add_dependency 'shoulda'

data/spec/lib/polish_geeks/dev_tools/commands/allowed_extensions_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::AllowedExtensions do
-  subject { described_class.new }
+  subject(:allowed_extensions) { described_class.new }
 
   describe '#execute' do
     let(:file_name) { 'file.rb' }
@@ -9,22 +9,22 @@ RSpec.describe PolishGeeks::DevTools::Commands::AllowedExtensions do
 
     before do
       expect(Dir).to receive(:[]) { files }
-      subject.execute
+      allowed_extensions.execute
     end
 
     context 'when we dont have invalid files' do
-      it { expect(subject.output).to eq [] }
+      it { expect(allowed_extensions.output).to eq [] }
     end
 
     context 'when we have invalid files' do
       let(:file_name) { 'file.py' }
-      it { expect(subject.output).to eq [file_name] }
+      it { expect(allowed_extensions.output).to eq [file_name] }
     end
   end
 
   describe '#label' do
     let(:expected) { 'Allowed Extensions' }
-    it { expect(subject.label).to eq expected }
+    it { expect(allowed_extensions.label).to eq expected }
   end
 
   describe '#error_message' do
@@ -34,21 +34,21 @@ RSpec.describe PolishGeeks::DevTools::Commands::AllowedExtensions do
       "\n\n#{output.join("\n")}\n"
     end
 
-    before { subject.instance_variable_set('@output', output) }
-    it { expect(subject.error_message).to eq expected }
+    before { allowed_extensions.instance_variable_set('@output', output) }
+    it { expect(allowed_extensions.error_message).to eq expected }
   end
 
   describe do
-    before { subject.instance_variable_set('@output', output) }
+    before { allowed_extensions.instance_variable_set('@output', output) }
 
     context 'when output is empty' do
       let(:output) { '' }
-      it { expect(subject.valid?).to eq true }
+      it { expect(allowed_extensions.valid?).to eq true }
     end
 
     context 'when output is empty' do
       let(:output) { rand.to_s }
-      it { expect(subject.valid?).to eq false }
+      it { expect(allowed_extensions.valid?).to eq false }
     end
   end
 end

data/spec/lib/polish_geeks/dev_tools/commands/base_spec.rb

@@ -1,27 +1,27 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::Base do
-  subject { described_class.new }
+  subject(:base) { described_class.new }
 
   describe '#execute' do
     let(:error) { PolishGeeks::DevTools::Errors::NotImplementedError }
-    it { expect { subject.execute }. to raise_error(error) }
+    it { expect { base.execute }. to raise_error(error) }
   end
 
   describe '#valid?' do
     let(:error) { PolishGeeks::DevTools::Errors::NotImplementedError }
-    it { expect { subject.valid? }. to raise_error(error) }
+    it { expect { base.valid? }. to raise_error(error) }
   end
 
   describe '#error_message' do
     let(:output) { rand.to_s }
 
     before do
-      subject.instance_variable_set('@output', output)
+      base.instance_variable_set('@output', output)
     end
 
     it 'by default should equal raw output' do
-      expect(subject.error_message).to eq output
+      expect(base.error_message).to eq output
     end
   end
 
@@ -36,12 +36,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::Base do
         expect(instance).to receive(:validate!) { true }
       end
 
-      it { expect { subject.ensure_executable! }.not_to raise_error }
+      it { expect { base.ensure_executable! }.not_to raise_error }
     end
 
     context 'when we dont require any validators' do
       before { expect(described_class).to receive(:validators) { [] } }
-      it { expect { subject.ensure_executable! }.not_to raise_error }
+      it { expect { base.ensure_executable! }.not_to raise_error }
     end
   end
 
@@ -73,7 +73,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::Base do
           .with(dir_in_path)
           .and_return(false)
       end
-      it { expect(subject.send(:files_from_path, path)).to eq [file_in_path] }
+      it { expect(base.send(:files_from_path, path)).to eq [file_in_path] }
     end
 
     context 'path is a file' do
@@ -84,7 +84,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::Base do
           .with("#{app_root}/#{path}")
           .and_return(true)
       end
-      it { expect(subject.send(:files_from_path, path)).to eq ["#{app_root}/#{path}"] }
+      it { expect(base.send(:files_from_path, path)).to eq ["#{app_root}/#{path}"] }
     end
   end
 end