polishgeeks-dev-tools 1.3.2 → 1.4.0

data/spec/lib/polish_geeks/dev_tools/commands/brakeman_spec.rb

@@ -2,17 +2,17 @@ require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::Brakeman do
   context 'class' do
-    subject { described_class }
+    subject(:brakeman) { described_class }
 
     describe '#validators' do
       it 'works only when we have Rails framework' do
-        expect(subject.validators).to eq [PolishGeeks::DevTools::Validators::Rails]
+        expect(brakeman.validators).to eq [PolishGeeks::DevTools::Validators::Rails]
       end
     end
   end
 
   context 'instance' do
-    subject { described_class.new }
+    subject(:brakeman) { described_class.new }
 
     describe '#execute' do
       context 'when we run brakeman' do
@@ -23,42 +23,36 @@ RSpec.describe PolishGeeks::DevTools::Commands::Brakeman do
           expect(instance).to receive(:execute).with('bundle exec brakeman -q')
         end
 
-        it 'executes the command' do
-          subject.execute
-        end
+        it { brakeman.execute }
       end
     end
 
     describe '#valid?' do
       context 'when warnings are equal 0' do
         before do
-          expect(subject)
+          expect(brakeman)
             .to receive(:warnings)
             .and_return(0)
         end
 
         context 'and errors are equal 0' do
           before do
-            expect(subject)
+            expect(brakeman)
               .to receive(:errors)
               .and_return(0)
           end
 
-          it 'returns true' do
-            expect(subject.valid?).to eq true
-          end
+          it { expect(brakeman.valid?).to eq true }
         end
 
         context 'and errors are not equal 0' do
           before do
-            expect(subject)
+            expect(brakeman)
               .to receive(:errors)
               .and_return(1)
           end
 
-          it 'returns true' do
-            expect(subject.valid?).to eq false
-          end
+          it { expect(brakeman.valid?).to eq false }
         end
       end
     end
@@ -69,14 +63,14 @@ RSpec.describe PolishGeeks::DevTools::Commands::Brakeman do
       let(:templates) { rand(1000) }
 
       before do
-        expect(subject).to receive(:models).and_return(models)
-        expect(subject).to receive(:controllers).and_return(controllers)
-        expect(subject).to receive(:templates).and_return(templates)
+        expect(brakeman).to receive(:models).and_return(models)
+        expect(brakeman).to receive(:controllers).and_return(controllers)
+        expect(brakeman).to receive(:templates).and_return(templates)
       end
 
       it 'uses details' do
         label = "Brakeman (#{controllers} con, #{models} mod, #{templates} temp)"
-        expect(subject.label).to eq label
+        expect(brakeman.label).to eq label
       end
     end
 
@@ -86,11 +80,11 @@ RSpec.describe PolishGeeks::DevTools::Commands::Brakeman do
           let(:amount) { rand(1000) }
 
           before do
-            subject.instance_variable_set(:@output, "#{name.to_s.capitalize} #{amount}")
+            brakeman.instance_variable_set(:@output, "#{name.to_s.capitalize} #{amount}")
           end
 
           it 'returns a proper value' do
-            expect(subject.send(name)).to eq amount
+            expect(brakeman.send(name)).to eq amount
           end
         end
       end

data/spec/lib/polish_geeks/dev_tools/commands/bundler_audit_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::BundlerAudit do
-  subject { described_class.new }
+  subject(:bundler_audit) { described_class.new }
 
   describe '#execute' do
     let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
@@ -12,7 +12,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::BundlerAudit do
         .with('bundle-audit update 2>&1 > /dev/null; bundle-audit check')
     end
 
-    it { subject.execute }
+    it { bundler_audit.execute }
   end
 
   describe '#valid?' do
@@ -29,16 +29,16 @@ RSpec.describe PolishGeeks::DevTools::Commands::BundlerAudit do
 
           Unpatched versions found!
         EOS
-        subject.instance_variable_set('@output', output)
+        bundler_audit.instance_variable_set('@output', output)
       end
 
-      it { expect(subject.valid?).to eq false }
+      it { expect(bundler_audit.valid?).to eq false }
     end
 
     context 'when there are no vulnerabilities' do
-      before { subject.instance_variable_set('@output', 'No vulnerabilities found') }
+      before { bundler_audit.instance_variable_set('@output', 'No vulnerabilities found') }
 
-      it { expect(subject.valid?).to eq true }
+      it { expect(bundler_audit.valid?).to eq true }
     end
   end
 

data/spec/lib/polish_geeks/dev_tools/commands/empty_methods/file_parser_spec.rb

@@ -1,6 +1,6 @@
 RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
+  subject(:file_parser) { described_class.new(file) }
   let(:file) { Tempfile.new('foo') }
-  subject { described_class.new(file) }
 
   describe '#find_empty_methods' do
     context 'empty define_singleton_methods' do
@@ -20,7 +20,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([2, 4, 5, 10]) }
+      it { expect(file_parser.find_empty_methods).to eq([2, 4, 5, 10]) }
     end
 
     context 'empty define_methods with comments' do
@@ -36,7 +36,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([2, 4, 5]) }
+      it { expect(file_parser.find_empty_methods).to eq([2, 4, 5]) }
     end
 
     context 'empty define_methods' do
@@ -52,7 +52,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([2, 4, 5]) }
+      it { expect(file_parser.find_empty_methods).to eq([2, 4, 5]) }
     end
 
     context 'singleton_methods and methods are defined' do
@@ -75,7 +75,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to be_empty }
+      it { expect(file_parser.find_empty_methods).to be_empty }
     end
 
     context 'empty one line method' do
@@ -84,7 +84,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([1]) }
+      it { expect(file_parser.find_empty_methods).to eq([1]) }
     end
 
     context 'empty one line method with comment' do
@@ -93,7 +93,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([1]) }
+      it { expect(file_parser.find_empty_methods).to eq([1]) }
     end
 
     context 'empty body method' do
@@ -103,7 +103,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([1]) }
+      it { expect(file_parser.find_empty_methods).to eq([1]) }
     end
 
     context 'empty body method with comment' do
@@ -113,7 +113,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([1]) }
+      it { expect(file_parser.find_empty_methods).to eq([1]) }
     end
 
     context 'empty method' do
@@ -126,7 +126,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([1]) }
+      it { expect(file_parser.find_empty_methods).to eq([1]) }
     end
 
     context 'method with comments inside' do
@@ -140,7 +140,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to be_empty }
+      it { expect(file_parser.find_empty_methods).to be_empty }
     end
 
     context 'method which defines empty define_method inside' do
@@ -151,7 +151,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([2]) }
+      it { expect(file_parser.find_empty_methods).to eq([2]) }
     end
 
     context 'method which defines empty define_singleton_method inside' do
@@ -164,7 +164,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to eq([2]) }
+      it { expect(file_parser.find_empty_methods).to eq([2]) }
     end
 
     context 'method which defines define_method inside' do
@@ -175,20 +175,20 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods::FileParser do
         file.read
       end
 
-      it { expect(subject.find_empty_methods).to be_empty }
+      it { expect(file_parser.find_empty_methods).to be_empty }
     end
   end
 
   describe '#method_has_no_lines?' do
-    it { expect(subject.send(:method_has_no_lines?, 2, 4)).to be_falsey }
-    it { expect(subject.send(:method_has_no_lines?, 2, 3)).to be_truthy }
+    it { expect(file_parser.send(:method_has_no_lines?, 2, 4)).to be_falsey }
+    it { expect(file_parser.send(:method_has_no_lines?, 2, 3)).to be_truthy }
   end
 
   describe '#add_empty_method' do
-    it { expect(subject.send(:add_empty_method, 2)).to eq [3] }
+    it { expect(file_parser.send(:add_empty_method, 2)).to eq [3] }
   end
 
   describe '#add_empty_method' do
-    it { expect(subject.send(:add_empty_method, 2)).to eq [3] }
+    it { expect(file_parser.send(:add_empty_method, 2)).to eq [3] }
   end
 end

data/spec/lib/polish_geeks/dev_tools/commands/empty_methods_spec.rb

@@ -2,63 +2,57 @@ require 'spec_helper'
 require 'tempfile'
 
 RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
-  subject { described_class.new }
+  subject(:empty_methods) { described_class.new }
   describe '#execute' do
     let(:file) { [rand.to_s] }
+    let(:empty_methods_output) { [] }
 
     before do
-      expect(subject)
+      expect(empty_methods)
         .to receive(:files_to_analyze)
         .and_return(file)
       allow(described_class::FileParser)
         .to receive_message_chain(:new, :find_empty_methods)
-        .and_return(empty_methods)
+        .and_return(empty_methods_output)
     end
 
     context 'when all files are valid' do
-      let(:empty_methods) { [] }
-      before do
-        subject.execute
-      end
+      before { empty_methods.execute }
 
-      it 'sets appropriate variables' do
-        expect(subject.output).to eq []
-        expect(subject.counter).to eq(file.count)
-      end
+      it { expect(empty_methods.output).to eq [] }
+      it { expect(empty_methods.counter).to eq(file.count) }
     end
 
     context 'when exist not valid file' do
-      let(:empty_methods) { [rand.to_s, rand.to_s] }
+      let(:empty_methods_output) { [rand.to_s, rand.to_s] }
       before do
-        expect(subject)
+        expect(empty_methods)
           .to receive(:sanitize)
           .with(file.first)
           .and_return(file.first)
-        subject.execute
+        empty_methods.execute
       end
 
-      it 'sets appropriate variables' do
-        expect(subject.output.first).to eq "#{file.first} lines #{empty_methods}"
-        expect(subject.counter).to eq(file.count)
-      end
+      it { expect(empty_methods.output.first).to eq "#{file.first} lines #{empty_methods_output}" }
+      it { expect(empty_methods.counter).to eq(file.count) }
     end
   end
 
   describe '#valid?' do
     before do
-      subject.instance_variable_set('@output', output)
+      empty_methods.instance_variable_set('@output', output)
     end
 
     context 'when output is empty' do
       let(:output) { [] }
 
-      it { expect(subject.valid?).to eq true }
+      it { expect(empty_methods.valid?).to eq true }
     end
 
     context 'when output have some files' do
       let(:output) { ['file_name'] }
 
-      it { expect(subject.valid?).to eq false }
+      it { expect(empty_methods.valid?).to eq false }
     end
   end
 
@@ -67,10 +61,10 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
     let(:expected) { "Empty methods: #{counter} files checked" }
 
     before do
-      subject.instance_variable_set('@counter', counter)
+      empty_methods.instance_variable_set('@counter', counter)
     end
 
-    it { expect(subject.label).to eq expected }
+    it { expect(empty_methods.label).to eq expected }
   end
 
   describe '#error_message' do
@@ -78,28 +72,28 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
     let(:expected) { "Following files contains blank methods: \n#{output.join("\n")}\n" }
 
     before do
-      subject.instance_variable_set('@output', output)
+      empty_methods.instance_variable_set('@output', output)
     end
 
-    it { expect(subject.error_message).to eq expected }
+    it { expect(empty_methods.error_message).to eq expected }
   end
 
   describe '#files_to_analyze' do
     let(:files) { [rand.to_s, rand.to_s] }
 
     before do
-      expect(subject)
+      expect(empty_methods)
         .to receive(:files_from_path)
         .with('**/*.rb')
         .and_return(files)
 
-      expect(subject)
+      expect(empty_methods)
         .to receive(:remove_excludes)
         .with(files)
         .and_return(files)
     end
 
-    it { expect(subject.send(:files_to_analyze)).to eq files }
+    it { expect(empty_methods.send(:files_to_analyze)).to eq files }
   end
 
   describe '#remove_excludes' do
@@ -107,12 +101,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
     let(:excludes) { %w(lib exclude.txt) }
 
     before do
-      expect(subject)
+      expect(empty_methods)
         .to receive(:excludes)
         .and_return(excludes)
     end
 
-    it { expect(subject.send(:remove_excludes, files)).to eq ['file.rb'] }
+    it { expect(empty_methods.send(:remove_excludes, files)).to eq ['file.rb'] }
   end
 
   describe '#excludes' do
@@ -120,12 +114,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
     let(:expected) { configs + described_class::DEFAULT_PATHS_TO_EXCLUDE }
 
     before do
-      expect(subject)
+      expect(empty_methods)
         .to receive(:config_excludes)
         .and_return(configs)
     end
 
-    it { expect(subject.send(:excludes)).to eq expected }
+    it { expect(empty_methods.send(:excludes)).to eq expected }
   end
 
   describe '#config_excludes' do
@@ -142,7 +136,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:config_excludes)).to eq(paths) }
+      it { expect(empty_methods.send(:config_excludes)).to eq(paths) }
     end
 
     context 'empty_methods_ignored is not set' do
@@ -157,7 +151,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:config_excludes)).to eq [] }
+      it { expect(empty_methods.send(:config_excludes)).to eq [] }
     end
   end
 
@@ -166,6 +160,6 @@ RSpec.describe PolishGeeks::DevTools::Commands::EmptyMethods do
     let(:app_root) { PolishGeeks::DevTools.app_root }
     let(:path) { "#{app_root}/#{file}" }
 
-    it { expect(subject.send(:sanitize, "#{app_root}/#{path}")).to eq file }
+    it { expect(empty_methods.send(:sanitize, "#{app_root}/#{path}")).to eq file }
   end
 end