polishgeeks-dev-tools 1.3.2 → 1.4.0

data/spec/lib/polish_geeks/dev_tools/commands/haml_lint_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
-  subject { described_class.new }
+  subject(:haml_lint) { described_class.new }
 
   describe '#execute' do
     let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
@@ -19,9 +19,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
           .with("bundle exec haml-lint -c #{path}.haml-lint.yml app/views")
       end
 
-      it 'executes the command' do
-        subject.execute
-      end
+      it { haml_lint.execute }
     end
 
     context 'when app config does not exist' do
@@ -33,31 +31,25 @@ RSpec.describe PolishGeeks::DevTools::Commands::HamlLint do
           .with("bundle exec haml-lint -c #{path}/config/haml-lint.yml app/views")
       end
 
-      it 'executes the command' do
-        subject.execute
-      end
+      it { haml_lint.execute }
     end
   end
 
   describe '#valid?' do
     context 'when there are some issues' do
       before do
-        subject.instance_variable_set('@output', '[W] SpaceInsideHashAttributes')
+        haml_lint.instance_variable_set('@output', '[W] SpaceInsideHashAttributes')
       end
 
-      it 'is false' do
-        expect(subject.valid?).to eq false
-      end
+      it { expect(haml_lint.valid?).to eq false }
     end
 
     context 'when there are no issues' do
       before do
-        subject.instance_variable_set('@output', '')
+        haml_lint.instance_variable_set('@output', '')
       end
 
-      it 'is true' do
-        expect(subject.valid?).to eq true
-      end
+      it { expect(haml_lint.valid?).to eq true }
     end
   end
 

data/spec/lib/polish_geeks/dev_tools/commands/required_files_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::RequiredFiles do
-  subject { described_class.new }
+  subject(:required_files) { described_class.new }
 
   let(:config) { double }
 
@@ -17,22 +17,22 @@ RSpec.describe PolishGeeks::DevTools::Commands::RequiredFiles do
 
       before do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
-        subject.execute
+        required_files.execute
       end
 
-      it { expect(subject.error_message.match(/REVIEW.md not exist/)).not_to be_nil }
+      it { expect(required_files.error_message.match(/REVIEW.md not exist/)).not_to be_nil }
     end
 
     context 'when required_files_include is empty' do
-      it { expect(subject.error_message).to be_nil }
+      it { expect(required_files.error_message).to be_nil }
     end
   end
 
   describe '#valid?' do
     context 'when file exist' do
-      before { subject.instance_variable_set('@output', []) }
+      before { required_files.instance_variable_set('@output', []) }
 
-      it { expect(subject.valid?).to be true }
+      it { expect(required_files.valid?).to be true }
     end
   end
 
@@ -42,9 +42,9 @@ RSpec.describe PolishGeeks::DevTools::Commands::RequiredFiles do
       let(:output) { [file_name] }
       let(:expected) { "Following files does not exist or are empty:\n#{file_name}\n" }
       before do
-        subject.instance_variable_set('@output', output)
+        required_files.instance_variable_set('@output', output)
       end
-      it { expect(subject.error_message).to eq expected }
+      it { expect(required_files.error_message).to eq expected }
     end
   end
 end

data/spec/lib/polish_geeks/dev_tools/commands/rspec_files_names_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesNames do
-  subject { described_class.new }
+  subject(:rspec_files_names) { described_class.new }
 
   let(:config) { double }
 
@@ -27,43 +27,47 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesNames do
         .and_return(true)
         .exactly(described_class::CHECKED_DIRS.count).times
 
-      subject.execute
+      rspec_files_names.execute
     end
 
     context 'when we dont have invalid files' do
       let(:files) { ['test_spec.rb'] }
 
-      it 'sets appropriate variables' do
-        expect(subject.output).to eq []
-        expect(subject.counter).to eq(described_class::CHECKED_DIRS.count * files.count)
+      it { expect(rspec_files_names.output).to eq [] }
+      it do
+        expect(
+          rspec_files_names.counter
+        ).to eq(described_class::CHECKED_DIRS.count * files.count)
       end
     end
 
     context 'when we have invalid files' do
       let(:files) { ['test_spe.rb'] }
 
-      it 'sets appropriate variables' do
-        expect(subject.output).to eq(files * described_class::CHECKED_DIRS.count)
-        expect(subject.counter).to eq(described_class::CHECKED_DIRS.count * files.count)
+      it { expect(rspec_files_names.output).to eq(files * described_class::CHECKED_DIRS.count) }
+      it do
+        expect(
+          rspec_files_names.counter
+        ).to eq(described_class::CHECKED_DIRS.count * files.count)
       end
     end
   end
 
   describe '#valid?' do
     before do
-      subject.instance_variable_set('@output', output)
+      rspec_files_names.instance_variable_set('@output', output)
     end
 
     context 'when output is empty' do
       let(:output) { [] }
 
-      it { expect(subject.valid?).to eq true }
+      it { expect(rspec_files_names.valid?).to eq true }
     end
 
     context 'when output is not empty' do
       let(:output) { ['file_name'] }
 
-      it { expect(subject.valid?).to eq false }
+      it { expect(rspec_files_names.valid?).to eq false }
     end
   end
 
@@ -72,10 +76,10 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesNames do
     let(:expected) { "Rspec files names: #{counter} files checked" }
 
     before do
-      subject.instance_variable_set('@counter', counter)
+      rspec_files_names.instance_variable_set('@counter', counter)
     end
 
-    it { expect(subject.label).to eq expected }
+    it { expect(rspec_files_names.label).to eq expected }
   end
 
   describe '#error_message' do
@@ -83,9 +87,9 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesNames do
     let(:expected) { "Following files have invalid name: \n #{output.join("\n")}\n" }
 
     before do
-      subject.instance_variable_set('@output', output)
+      rspec_files_names.instance_variable_set('@output', output)
     end
 
-    it { expect(subject.error_message).to eq expected }
+    it { expect(rspec_files_names.error_message).to eq expected }
   end
 end

data/spec/lib/polish_geeks/dev_tools/commands/rspec_files_structure_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'tempfile'
 
 RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
-  subject { described_class.new }
+  subject(:rspec_files_structure) { described_class.new }
 
   describe '#execute' do
     let(:analyzed_files_result) { double }
@@ -12,12 +12,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
     let(:expected) { Hash(app: substract_result, rspec: substract_rspec_result) }
 
     before do
-      expect(subject)
+      expect(rspec_files_structure)
         .to receive(:analyzed_files)
         .twice
         .and_return(analyzed_files_result)
 
-      expect(subject)
+      expect(rspec_files_structure)
         .to receive(:analyzed_rspec_files)
         .exactly(2).times
         .and_return(rspec_files_result)
@@ -29,12 +29,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       expect(rspec_files_result)
         .to receive(:-)
         .and_return(substract_rspec_result)
-    end
 
-    it 'is subtraction' do
-      subject.execute
+      rspec_files_structure.execute
+    end
 
-      expect(subject.instance_variable_get(:@output)).to eq expected
+    it do
+      expect(rspec_files_structure.instance_variable_get(:@output)).to eq expected
     end
   end
 
@@ -50,20 +50,21 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       expect(PolishGeeks::DevTools::Config).to receive(:config).at_least(:once) { config }
     end
 
-    it { expect(subject.send(:analyzed_files)).not_to be_empty }
+    it { expect(rspec_files_structure.send(:analyzed_files)).not_to be_empty }
 
     context 'when we gather files for analyze' do
       let(:file) { Tempfile.new('tempfile') }
       let(:files_collection) { [file] }
 
-      before { expect(subject).to receive(:checked_files) { files_collection } }
-
-      it 'flatten,s uniq and sanitize' do
+      before do
+        expect(rspec_files_structure).to receive(:checked_files) { files_collection }
         expect(files_collection).to receive(:flatten!)
         expect(files_collection).to receive(:uniq!)
-        expect(subject).to receive(:sanitize).with(file)
+        expect(rspec_files_structure).to receive(:sanitize).with(file)
+      end
 
-        subject.send(:analyzed_files)
+      it 'flatten,s uniq and sanitize' do
+        rspec_files_structure.send(:analyzed_files)
       end
     end
   end
@@ -80,45 +81,40 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       expect(PolishGeeks::DevTools::Config).to receive(:config).at_least(:once) { config }
     end
 
-    it { expect(subject.send(:analyzed_rspec_files)).not_to be_empty }
+    it { expect(rspec_files_structure.send(:analyzed_rspec_files)).not_to be_empty }
 
     context 'when we gather rspec files' do
       let(:file) { double }
       let(:files_collection) { [file] }
 
-      before { expect(subject).to receive(:rspec_files) { files_collection } }
+      before do
+        expect(rspec_files_structure).to receive(:rspec_files) { files_collection }
+        expect(files_collection).to receive(:flatten!)
+        expect(files_collection).to receive(:uniq!)
+        expect(rspec_files_structure).to receive(:sanitize).with(file)
+      end
 
       it 'flatten,s uniq and sanitize' do
-        expect(files_collection)
-          .to receive(:flatten!)
-
-        expect(files_collection)
-          .to receive(:uniq!)
-
-        expect(subject)
-          .to receive(:sanitize)
-          .with(file)
-
-        subject.send(:analyzed_rspec_files)
+        rspec_files_structure.send(:analyzed_rspec_files)
       end
     end
   end
 
   describe '#valid?' do
     before do
-      subject.instance_variable_set('@output', output)
+      rspec_files_structure.instance_variable_set('@output', output)
     end
 
     context 'when output is empty' do
       let(:output) { Hash(app: [], rspec: []) }
 
-      it { expect(subject.valid?).to eq true }
+      it { expect(rspec_files_structure.valid?).to eq true }
     end
 
     context 'when output is not empty' do
       let(:output) { Hash(app: [double], rspec: [double]) }
 
-      it { expect(subject.valid?).to eq false }
+      it { expect(rspec_files_structure.valid?).to eq false }
     end
   end
 
@@ -129,12 +125,12 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       end
 
       before do
-        expect(subject).to receive(:analyzed_files) { analyzed_files_result }
+        expect(rspec_files_structure).to receive(:analyzed_files) { analyzed_files_result }
       end
 
       it 'returns the label' do
         expected = "Rspec files structure (#{analyzed_files_result.count} checked)"
-        expect(subject.label).to eq expected
+        expect(rspec_files_structure.label).to eq expected
       end
     end
   end
@@ -144,16 +140,16 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       let(:message) { rand.to_s }
       let(:expected) { message + message }
       before do
-        expect(subject)
+        expect(rspec_files_structure)
           .to receive(:files_error_message)
           .and_return(message)
-        expect(subject)
+        expect(rspec_files_structure)
           .to receive(:rspec_error_message)
           .and_return(message)
       end
 
       it 'returns the error message' do
-        expect(subject.error_message).to eq expected
+        expect(rspec_files_structure.error_message).to eq expected
       end
     end
   end
@@ -171,7 +167,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:excludes)).to eq [] }
+      it { expect(rspec_files_structure.send(:excludes)).to eq [] }
     end
 
     context 'when rspec_files_structure_ignored is set' do
@@ -187,7 +183,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
         expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
       end
 
-      it { expect(subject.send(:excludes)).to eq rspec_files_structure_ignored }
+      it { expect(rspec_files_structure.send(:excludes)).to eq rspec_files_structure_ignored }
     end
   end
 
@@ -198,7 +194,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       let(:string) { "#{PolishGeeks::DevTools.app_root}/#{base}" }
 
       it ' should be removed' do
-        expect(subject.send(:sanitize, string)).to eq base
+        expect(rspec_files_structure.send(:sanitize, string)).to eq base
       end
     end
 
@@ -206,7 +202,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       let(:string) { "#{base}_spec.rb" }
 
       it ' should be removed' do
-        expect(subject.send(:sanitize, string)).to eq "#{base}.rb"
+        expect(rspec_files_structure.send(:sanitize, string)).to eq "#{base}.rb"
       end
     end
 
@@ -214,7 +210,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       let(:string) { "spec/#{base}" }
 
       it ' should be removed' do
-        expect(subject.send(:sanitize, string)).to eq base
+        expect(rspec_files_structure.send(:sanitize, string)).to eq base
       end
     end
 
@@ -222,7 +218,7 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
       let(:string) { "app/#{base}" }
 
       it ' should be removed' do
-        expect(subject.send(:sanitize, string)).to eq base
+        expect(rspec_files_structure.send(:sanitize, string)).to eq base
       end
     end
   end
@@ -231,11 +227,11 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
     let(:output) { Hash(app: ['test.rb'], rspec: ['test_rspec.rb']) }
 
     before do
-      subject.instance_variable_set(:@output, output)
+      rspec_files_structure.instance_variable_set(:@output, output)
     end
 
     it 'returns the error message' do
-      expect(subject.send(:files_error_message))
+      expect(rspec_files_structure.send(:files_error_message))
         .to eq "Following files don't have corresponding Rspec files:\n\ntest.rb\n"
     end
   end
@@ -244,11 +240,11 @@ RSpec.describe PolishGeeks::DevTools::Commands::RspecFilesStructure do
     let(:output) { Hash(app: ['test.rb'], rspec: ['test_rspec.rb']) }
 
     before do
-      subject.instance_variable_set(:@output, output)
+      rspec_files_structure.instance_variable_set(:@output, output)
     end
 
     it 'returns the error message' do
-      expect(subject.send(:rspec_error_message))
+      expect(rspec_files_structure.send(:rspec_error_message))
         .to eq "\n\nFollowing Rspec don't have corresponding files:\n\ntest_rspec_spec.rb\n"
     end
   end

data/spec/lib/polish_geeks/dev_tools/commands/rspec_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe PolishGeeks::DevTools::Commands::Rspec do
-  subject { described_class.new }
+  subject(:rspec) { described_class.new }
 
   describe '#execute' do
     let(:instance) { instance_double(PolishGeeks::DevTools::Shell) }
@@ -13,27 +13,27 @@ RSpec.describe PolishGeeks::DevTools::Commands::Rspec do
           .with('bundle exec rspec spec')
       end
 
-      it { subject.execute }
+      it { rspec.execute }
     end
   end
 
   describe '#valid?' do
     context 'when there is 1 failure' do
-      before { subject.instance_variable_set(:@output, '1 failure') }
+      before { rspec.instance_variable_set(:@output, '1 failure') }
 
-      it { expect(subject.valid?).to eq false }
+      it { expect(rspec.valid?).to eq false }
     end
 
     context 'when there are failures' do
-      before { subject.instance_variable_set(:@output, '2 failures') }
+      before { rspec.instance_variable_set(:@output, '2 failures') }
 
-      it { expect(subject.valid?).to eq false }
+      it { expect(rspec.valid?).to eq false }
     end
 
     context 'when there are no failures' do
-      before { subject.instance_variable_set(:@output, '0 failures') }
+      before { rspec.instance_variable_set(:@output, '0 failures') }
 
-      it { expect(subject.valid?).to eq true }
+      it { expect(rspec.valid?).to eq true }
     end
 
     context 'when there are no failures' do
@@ -43,10 +43,10 @@ RSpec.describe PolishGeeks::DevTools::Commands::Rspec do
         before do
           expect(PolishGeeks::DevTools::Config).to receive(:config) { config }
           expect(config).to receive(:rspec_disallow_pending?) { false }
-          subject.instance_variable_set(:@output, '0 failures, 2 pending')
+          rspec.instance_variable_set(:@output, '0 failures, 2 pending')
         end
 
-        it { expect(subject.valid?).to eq true }
+        it { expect(rspec.valid?).to eq true }
       end
 
       context 'and disallow pending true' do
@@ -57,18 +57,18 @@ RSpec.describe PolishGeeks::DevTools::Commands::Rspec do
 
         context 'and there are pendings' do
           before do
-            subject.instance_variable_set(:@output, '0 failures, 2 pending')
+            rspec.instance_variable_set(:@output, '0 failures, 2 pending')
           end
 
-          it { expect(subject.valid?).to eq false }
+          it { expect(rspec.valid?).to eq false }
         end
 
         context 'and there are no pendings' do
           before do
-            subject.instance_variable_set(:@output, '0 failures, 0 pending')
+            rspec.instance_variable_set(:@output, '0 failures, 0 pending')
           end
 
-          it { expect(subject.valid?).to eq true }
+          it { expect(rspec.valid?).to eq true }
         end
       end
     end
@@ -78,28 +78,28 @@ RSpec.describe PolishGeeks::DevTools::Commands::Rspec do
     context 'when we run rspec' do
       let(:label) { '10 examples, 5 failures, 2 pending' }
 
-      before { subject.instance_variable_set(:@output, label) }
+      before { rspec.instance_variable_set(:@output, label) }
 
-      it { expect(subject.label).to eq 'Rspec (10 ex, 5 fa, 2 pe)' }
+      it { expect(rspec.label).to eq 'Rspec (10 ex, 5 fa, 2 pe)' }
     end
   end
 
   describe '#examples_count' do
-    before { subject.instance_variable_set(:@output, '10 examples') }
+    before { rspec.instance_variable_set(:@output, '10 examples') }
 
-    it { expect(subject.send(:examples_count)).to eq(10) }
+    it { expect(rspec.send(:examples_count)).to eq(10) }
   end
 
   describe '#failures_count' do
-    before { subject.instance_variable_set(:@output, '10 failures') }
+    before { rspec.instance_variable_set(:@output, '10 failures') }
 
-    it { expect(subject.send(:failures_count)).to eq(10) }
+    it { expect(rspec.send(:failures_count)).to eq(10) }
   end
 
   describe '#pending_count' do
-    before { subject.instance_variable_set(:@output, '10 pending') }
+    before { rspec.instance_variable_set(:@output, '10 pending') }
 
-    it { expect(subject.send(:pending_count)).to eq(10) }
+    it { expect(rspec.send(:pending_count)).to eq(10) }
   end
 
   describe '.generator?' do